On 21-06-2019 10:02 AM, greg Luce wrote:
Split this patch off since it just deals with documentation for
features already present in the code. Hope I formatted everything
correctly!
Gyan and kepstin helped write the documentation
Adjusted commit msg and text for grammar nits and pushed as
> Subject: [Patch V2] lavf/qsv_scale: add scaling modes support
>
> low_power mode will use a fixed HW engine (SFC), thus can offload EU
> usage.
> high quality mode will take EU usage (AVS sampler).
>
> Performance and EU usage (Render usage) comparsion on Intel(R) Xeon(R)
> CPU E3-1225 v5 @
On Thu, Jun 20, 2019 at 09:43:46PM +0800, Jun Zhao wrote:
> From: Jun Zhao
>
> Remove unnecessary max value found, it's will improve the performance
> about 10%. Used the test command like:
> ffmpeg -i 1080P.mp4 -an -vf normalize -f null /dev/null, the FPS change
> from 96fps to 107fps.
>
>
On 18.06.2019, at 16:25, Michael Niedermayer wrote:
> Fixes: addition of unsigned offset to 0x7f56fc26a9b6 overflowed to
> 0x7f56fc26a8be*
> Fixes:
> clusterfuzz-testcase-minimized-mediasource_MP4_AVC1_pipeline_integration_fuzzer-4917949056679936
>
> Reported-by: Matt Wolenetz
>
On 18.06.2019, at 14:55, Michael Niedermayer wrote:
> Fixes: signed integer overflow: -3447 * 2883584 cannot be represented in type
> 'int'
> Fixes:
> 15265/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BINK_fuzzer-5088311799971840
>
> Found-by: continuous fuzzing process
>
On 21.06.2019, at 00:47, Michael Niedermayer wrote:
> Fixes: signed integer overflow: 65313 * 65313 cannot be represented in type
> 'int'
> Fixes:
> 15290/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5738074249625600
>
> Found-by: continuous fuzzing process
>
On Thu, Jun 20, 2019 at 12:06:38PM -0400, greg Luce wrote:
> Info at https://trac.ffmpeg.org/ticket/7947
> C code in file 0001, documentation and version tick in file 0002
> Documentation written with help from Gyan and Moritz Barsnick
> Documentation patch has info in what I hope is the commit
> code changes should be ok
> the doc and code belong in the same patch/commit though
I had them in a single patch before but split them as requested here
http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245613.html
Is there something I'm missing that allows me to split the patch but
have the
greg Luce (12019-06-21):
> From: greg Luce
> Changes to vf_drawtext.c written by
> Calvin Walton
>
> Changes to filters.texi written by
> greg Luce
> with lots of help from Moritz Barsnick and Gyan
Do you consider the doc change to be more important than the code
change?
If not, you need to
On 21/06/2019 15:26, Nicolas George wrote:
> How can the packet not be unreferenced when the very previous
> instruction is av_packet_unref()? All the code paths I see either pass
> through the existing av_packet_unref() before reaching the new one or
> arrive with a blank packet. Am I missing
Thanks will resubmit that way
On Fri, 21 Jun 2019 at 08:53, Nicolas George wrote:
>
> greg Luce (12019-06-21):
> > I had them in a single patch before but split them as requested here
> > http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245613.html
> > Is there something I'm missing that
Derek Buitenhuis (12019-06-21):
> The previous instructions is not an unref if it hits one of the breaks
> in the loop above.
Of course. Sorry for wasting your time.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
On Thu, Jun 20, 2019 at 12:50:33PM +0800, Jun Zhao wrote:
> From: Jun Zhao
>
> Respect default disposition when select audio/video
>
> Signed-off-by: Jun Zhao
> ---
> fftools/ffmpeg_opt.c |6 --
> 1 files changed, 4 insertions(+), 2 deletions(-)
this is probably ok
some testcase in
Info at https://trac.ffmpeg.org/ticket/7947
Changes to vf_drawtext.c written by
Calvin Walton
Changes to filters.texi written by
greg Luce
with lots of help from Moritz Barsnick and Gyan
[PATCH]-vf_drawtext-Add-pkt_pos-pkt_duration-pkt_size-as-var.patch
Description: Binary data
This packet was not necessarily unreferenced.
Signed-off-by: Derek Buitenhuis
---
fftools/ffprobe.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
index 3becb6330e..52f24e7dfd 100644
--- a/fftools/ffprobe.c
+++
On 6/21/2019 10:36 AM, Derek Buitenhuis wrote:
> This packet was not necessarily unreferenced.
>
> Signed-off-by: Derek Buitenhuis
> ---
> fftools/ffprobe.c | 10 +-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
> index
set AVFrame decode_error_flags in case h->slice_ctx->er.error_occurred is set
after the call to ff_h264_execute_decode_slices. This allows the user to detect
concealed decoding errors in the call to avcodec_receive_frame
Signed-off-by: Amir Pauker
---
libavcodec/error_resilience.c | 2 ++
On 21/06/2019 14:46, James Almer wrote:
> Why not just call this unconditionally instead of the init() + zero below?
I wasn't sure from a quick skim if these packets were
referenced elsewhere (and thus unrefercing twice would
be problematic).
If it's safe to do so, I will.
- Derel
This packet was not necessarily unreferenced.
Signed-off-by: Derek Buitenhuis
---
fftools/ffprobe.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
index 3becb6330e..5aaddb0308 100644
--- a/fftools/ffprobe.c
+++ b/fftools/ffprobe.c
@@
greg Luce (12019-06-21):
> I had them in a single patch before but split them as requested here
> http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245613.html
> Is there something I'm missing that allows me to split the patch but
> have the code and doc in the same patch?
Asking you to split
> Do you consider the doc change to be more important than the code
> change?
>
> If not, you need to change the From line of the commit.
Makes sense!
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Info at https://trac.ffmpeg.org/ticket/7947
Changes to vf_drawtext.c written by
Calvin Walton
Changes to filters.texi written by
greg Luce
with lots of help from Moritz Barsnick and Gyan
[PATCH]-vf_drawtext-Add-pkt_pos-pkt_duration-pkt_size-as-var.patch
Description: Binary data
FF_DECODE_ERROR_DECODE_SLICES is set when decoding slices result with error(s)
but the returned value from
avcodec_receive_frame is zero
Signed-off-by: Amir Pauker
---
doc/APIchanges | 3 +++
libavutil/frame.h | 1 +
libavutil/version.h | 2 +-
3 files changed, 5 insertions(+), 1
This packet was not necessarily unreferenced.
Signed-off-by: Derek Buitenhuis
---
fftools/ffprobe.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
index 3becb6330e..dac70ba5a1 100644
--- a/fftools/ffprobe.c
+++ b/fftools/ffprobe.c
@@ -2429,6 +2429,8
On Mon, Jun 03, 2019 at 10:55:20AM +0200, Paul B Mahol wrote:
> On 6/2/19, Michael Niedermayer wrote:
> > Fixes: Timeout (15sec -> 0.5sec)
> > Fixes:
> > 14846/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FMVC_fuzzer-5068322120400896
> >
> > Found-by: continuous fuzzing process
> >
On 6/21/2019 1:24 AM, Gyan wrote:
>
>
> On 20-06-2019 11:15 PM, James Almer wrote:
>> The spec states they can't be higher than the respective dimensions of
>> the
>> stream in CTBs.
>>
>> Signed-off-by: James Almer
>> ---
>> I don't think it's wise further limiting the range to the maximum
>>
On 6/21/2019 11:13 AM, Derek Buitenhuis wrote:
> On 21/06/2019 14:46, James Almer wrote:
>> Why not just call this unconditionally instead of the init() + zero below?
>
> I wasn't sure from a quick skim if these packets were
> referenced elsewhere (and thus unrefercing twice would
> be
On 6/21/2019 11:15 AM, Derek Buitenhuis wrote:
> This packet was not necessarily unreferenced.
>
> Signed-off-by: Derek Buitenhuis
> ---
> fftools/ffprobe.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
> index 3becb6330e..dac70ba5a1 100644
>
Derek Buitenhuis (12019-06-21):
> This packet was not necessarily unreferenced.
>
> Signed-off-by: Derek Buitenhuis
> ---
> fftools/ffprobe.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
> index 3becb6330e..dac70ba5a1 100644
> ---
Thanks Michael,
I submitted two new patches.
I add a new value FF_DECODE_ERROR_DECODE_SLICES.
FF_DECODE_ERROR_DECODE_SLICES indicates that error(s) occurred during
slices decoding but the return code is set to zero (set where previously
FF_DECODE_ERROR_CONCEALMENT_ACTIVE was set).
On 21/06/2019 15:26, James Almer wrote:
> Remove the three lines below as well before pushing. They are
> superfluous as av_packet_unref() does the same internally.
OK.
The documentation for av_packet_unref says it sets the 'remaining'
fields to default values, but av_init_packet says it sets
On Sun, Jun 02, 2019 at 01:25:32AM +0200, Michael Niedermayer wrote:
> Fixes: Timeout (18sec -> 7sec)
> Fixes:
> 14835/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WCMV_fuzzer-5646714897170432
>
> Found-by: continuous fuzzing process
>
On 6/21/2019 11:39 AM, Derek Buitenhuis wrote:
> On 21/06/2019 15:26, James Almer wrote:
>> Remove the three lines below as well before pushing. They are
>> superfluous as av_packet_unref() does the same internally.
>
> OK.
>
> The documentation for av_packet_unref says it sets the 'remaining'
>
On 6/21/2019 11:41 AM, Derek Buitenhuis wrote:
> This packet was not necessarily unreferenced.
>
> Signed-off-by: Derek Buitenhuis
> ---
> fftools/ffprobe.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
> index
On Sat, Jun 08, 2019 at 08:23:22AM +0200, Reimar Döffinger wrote:
>
>
> On 07.06.2019, at 23:56, Michael Niedermayer wrote:
>
> > Signed-off-by: Michael Niedermayer
> > ---
> > libavformat/vividas.c | 12 ++--
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git
Commit 31f9032b added the audio_preload feature; its goal is to
interleave audio earlier than the rest. Unfortunately, it has never ever
worked, because the check for whether a packet should be interleaved
before or after another packet was completely wrong: When audio_preload
vanishes,
On Sat, Jun 08, 2019 at 06:11:02PM +0200, Reimar Döffinger wrote:
>
>
> On 08.06.2019, at 11:28, Michael Niedermayer wrote:
>
> > Fixes: left shift of 1 by 31 places cannot be represented in type 'int'
> > Fixes:
> > 15123/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5738039235575808
Fixes: Timeout (40sec -> 13sec)
Fixes:
15417/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FLIC_fuzzer-5679812615602176
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer
---
libavcodec/flicvideo.c | 4
Fixes: signed integer overflow: 6494225984479297536 - -6043795377581187040
cannot be represented in type 'long'
Fixes:
15285/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFWAVESYNTH_fuzzer-5632780307791872
Found-by: continuous fuzzing process
Fixes: negation of -9223372036854775808 cannot be represented in type 'int64_t'
(aka 'long'); cast to an unsigned type to negate this value to itself
Fixes:
15289/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFWAVESYNTH_fuzzer-5709034499342336
Found-by: continuous fuzzing process
> Am 21.06.2019 um 14:53 schrieb Nicolas George :
>
> greg Luce (12019-06-21):
>> I had them in a single patch before but split them as requested here
>> http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245613.html
>> Is there something I'm missing that allows me to split the patch but
>>
Fixes: out of array access
Fixes:
15360/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FLIC_fuzzer-5653837190266880
Fixes:
15412/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FLIC_fuzzer-5740537648250880
Found-by: continuous fuzzing process
Fixes: signed integer overflow: -32768 * 196032 cannot be represented in type
'int'
Fixes:
15300/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FLIC_fuzzer-5733319519502336
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by:
Signed-off-by: Michael Niedermayer
---
libavcodec/ffwavesynth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/ffwavesynth.c b/libavcodec/ffwavesynth.c
index a66113972b..cf8c780f3e 100644
--- a/libavcodec/ffwavesynth.c
+++ b/libavcodec/ffwavesynth.c
@@ -122,7
44 matches
Mail list logo
