Re: [FFmpeg-devel] [PATCH 3/3 v4] avcodec/cbs_h265: add missing support for reserved_payload_extension_data SEI bits

2020-05-03 Thread Andreas Rheinhardt
Mark Thompson: > On 30/04/2020 22:50, James Almer wrote: >> Fixes ticket #8622 >> >> Signed-off-by: James Almer >> --- >> libavcodec/cbs_h2645.c| 1 + >> libavcodec/cbs_h265.h | 1 + >> libavcodec/cbs_h265_syntax_template.c | 85 +-- >> 3

Re: [FFmpeg-devel] [PATCH 3/4] lavc/pgs_frame_split_bsf: add bsf to split PGS segments

2020-05-03 Thread John Stebbins
On Sat, 2020-05-02 at 23:05 +0200, Andreas Rheinhardt wrote: > John Stebbins: > > Requried to remux mkv to m2ts > > --- > > Changelog| 1 + > > doc/bitstream_filters.texi | 8 ++ > > libavcodec/Makefile | 1 + > > libavcodec/bitstream_filters.c |

Re: [FFmpeg-devel] [PATCH v1 2/4] avcodec/prores_metadata_bsf: add smpte2084 format support

2020-05-03 Thread Marton Balint
On Sun, 3 May 2020, lance.lmw...@gmail.com wrote: On Sun, May 03, 2020 at 10:01:31AM +0200, Marton Balint wrote: On Fri, 15 Nov 2019, Limin Wang wrote: > > ping, the patchset is for HDR/HLG color support for prores. > > On Mon, Nov 04, 2019 at 07:10:00PM +0800, lance.lmw...@gmail.com

Re: [FFmpeg-devel] subtitles filter and -ss

2020-05-03 Thread Manolis Stamatogiannakis
Thanks for the prompt response. It did save me from wasting more time trying to get the value of -ss starting from the AVFilterContext pointer. I've submitted a patch that adds a "shift" option to the plugin. I've opted for "shift" instead of "seek" as the name of the new option. This should make

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/av1_metadata: filter parameter sets in packet side data

2020-05-03 Thread James Almer
On 4/22/2020 9:37 PM, Andreas Rheinhardt wrote: > James Almer: >> Extradata included in packet side data is meant to replace the codec context >> extradata. So when muxing for example to MP4 without this change and if >> extradata is present in a packet side data, the result will be that the >>

Re: [FFmpeg-devel] [PATCH v1] avcodec/h264_metadata_bsf: add option to delete SEI user data

2020-05-03 Thread Mark Thompson
On 20/04/2020 12:01, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > doc/bitstream_filters.texi | 3 +++ > libavcodec/h264_metadata_bsf.c | 19 +++ > 2 files changed, 22 insertions(+) > > diff --git a/doc/bitstream_filters.texi

[FFmpeg-devel] [PATCH] avfilter/vf_subtitles: add shift options

2020-05-03 Thread Manolis Stamatogiannakis
Allows shifting of subtitle display times to align them with the video. This avoids having to rewrite the subtitle file in order to display subtitles correctly when input is seeked (-ss). Also handy for minor subtitle timing corrections without rewriting the subtitles file. Signed-off-by: Manolis

[FFmpeg-devel] subtitles filter and -ss

2020-05-03 Thread Manolis Stamatogiannakis
Hello, I've noticed what appears to be a bug/missing feature in the subtitles filter: when "-ss" is used for the input, it is not applied to the subtitles stream. E.g., for the following command line, the video playback will start on 20:10, but the subtitles will start from 00:00. ffmpeg -re -ss

[FFmpeg-devel] [PATCH] cbs_h265: Ensure that a predicted RPS doesn't contain too many pictures

2020-05-03 Thread Mark Thompson
If the RPS we are predicting from has maximum size then at least one of the pictures in it must be discarded before adding the current one. Also revert 588114cea4ee434c9c61353ed91ffc817d2965f5, which added now-redundant checks for the special case of a too-large RPS with all pictures being in the

Re: [FFmpeg-devel] [PATCH 1/4] lavc/pgs_frame_merge_bsf: add bsf to merge PGS segments

2020-05-03 Thread John Stebbins
On Sat, 2020-05-02 at 22:30 +0200, Andreas Rheinhardt wrote: > John Stebbins: > > Required to remux m2ts to mkv > > --- > > Changelog| 1 + > > doc/bitstream_filters.texi | 8 ++ > > libavcodec/Makefile | 1 + > > libavcodec/bitstream_filters.c |

Re: [FFmpeg-devel] [PATCH 3/3 v4] avcodec/cbs_h265: add missing support for reserved_payload_extension_data SEI bits

2020-05-03 Thread Mark Thompson
On 30/04/2020 22:50, James Almer wrote: > Fixes ticket #8622 > > Signed-off-by: James Almer > --- > libavcodec/cbs_h2645.c| 1 + > libavcodec/cbs_h265.h | 1 + > libavcodec/cbs_h265_syntax_template.c | 85 +-- > 3 files changed, 70

Re: [FFmpeg-devel] [PATCH 2/3] libswscale: add output support for AV_PIX_FMT_GBRAPF32

2020-05-03 Thread Michael Niedermayer
On Sun, May 03, 2020 at 02:01:21AM -0700, Mark Reid wrote: > On Thu., Apr. 30, 2020, 11:46 a.m. Mark Reid, wrote: > > > > > > > On Thu, Apr 30, 2020 at 7:59 AM Michael Niedermayer > > wrote: > > > >> On Wed, Apr 29, 2020 at 02:49:35PM -0700, Mark Reid wrote: > >> > On Wed, Apr 29, 2020 at 2:22

Re: [FFmpeg-devel] [PATCH] ffmpeg: Don't require a known device to pass a frames context to an encoder

2020-05-03 Thread Mark Thompson
On 29/04/2020 06:34, Fu, Linjie wrote: >> From: ffmpeg-devel On Behalf Of >> Mark Thompson >> Sent: Wednesday, April 29, 2020 06:57 >> To: FFmpeg development discussions and patches > de...@ffmpeg.org> >> Subject: [FFmpeg-devel] [PATCH] ffmpeg: Don't require a known device to >> pass a frames

Re: [FFmpeg-devel] subtitles filter and -ss

2020-05-03 Thread Gyan Doshi
On 03-05-2020 08:36 pm, Manolis Stamatogiannakis wrote: Hello, I've noticed what appears to be a bug/missing feature in the subtitles filter: when "-ss" is used for the input, it is not applied to the subtitles stream. E.g., for the following command line, the video playback will start on

Re: [FFmpeg-devel] [PATCH 2/4] lavf/matroskaenc: add PGS merge to auto bsf list

2020-05-03 Thread John Stebbins
On Sat, 2020-05-02 at 22:40 +0200, Andreas Rheinhardt wrote: > John Stebbins: > > PGS segments must be merged to one packet for muxing to mkv > > --- > > libavformat/matroskaenc.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/libavformat/matroskaenc.c

Re: [FFmpeg-devel] [PATCH v1 4/4] avcodec/proresenc_anatoliy: support for more color matrix for proresenc

2020-05-03 Thread Marton Balint
On Sun, 3 May 2020, lance.lmw...@gmail.com wrote: On Sun, May 03, 2020 at 09:53:09AM +0200, Marton Balint wrote: On Tue, 5 Nov 2019, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Please tested with below command: > ./ffmpeg -i ../fate-suite/mpeg2/t.mpg -c:v prores_aw

Re: [FFmpeg-devel] [PATCH] cbs_h265: Ensure that a predicted RPS doesn't contain too many pictures

2020-05-03 Thread Michael Niedermayer
On Sun, May 03, 2020 at 04:30:00PM +0100, Mark Thompson wrote: > If the RPS we are predicting from has maximum size then at least one of > the pictures in it must be discarded before adding the current one. > > Also revert 588114cea4ee434c9c61353ed91ffc817d2965f5, which added > now-redundant

Re: [FFmpeg-devel] [PATCH] cbs_h265: Ensure that a predicted RPS doesn't contain too many pictures

2020-05-03 Thread James Almer
On 5/3/2020 12:30 PM, Mark Thompson wrote: > If the RPS we are predicting from has maximum size then at least one of > the pictures in it must be discarded before adding the current one. > > Also revert 588114cea4ee434c9c61353ed91ffc817d2965f5, which added > now-redundant checks for the special

Re: [FFmpeg-devel] [PATCH 3/3 v4] avcodec/cbs_h265: add missing support for reserved_payload_extension_data SEI bits

2020-05-03 Thread James Almer
On 5/3/2020 12:39 PM, Mark Thompson wrote: > On 30/04/2020 22:50, James Almer wrote: >> Fixes ticket #8622 >> >> Signed-off-by: James Almer >> --- >> libavcodec/cbs_h2645.c| 1 + >> libavcodec/cbs_h265.h | 1 + >> libavcodec/cbs_h265_syntax_template.c | 85

Re: [FFmpeg-devel] [PATCH] avcodec/librav1e: Require a bitrate to be set when using 2-pass mode

2020-05-03 Thread Derek Buitenhuis
On 02/05/2020 15:46, James Almer wrote: >> +if ((avctx->flags & AV_CODEC_FLAG_PASS1 || avctx->flags & >> AV_CODEC_FLAG_PASS2) && !avctx->bit_rate) { > > Maybe avctx->flags & (AV_CODEC_FLAG_PASS1 | AV_CODEC_FLAG_PASS2) instead. I thought about it, but I think the way I already have it is a

Re: [FFmpeg-devel] [PATCH v1] avfilter/src_movie: Fix the loop function of dynamic logo

2020-05-03 Thread Marton Balint
On Sun, 3 May 2020, lance.lmw...@gmail.com wrote: On Tue, Mar 17, 2020 at 06:55:00PM +0800, lance.lmw...@gmail.com wrote: From: Limin Wang The following command will attempt to create the input and overlay test sequence for you. ./ffmpeg -f lavfi -i

Re: [FFmpeg-devel] [PATCH v11] avformat: add demuxer for Pro Pinball Series' Soundbanks

2020-05-03 Thread Michael Niedermayer
On Sun, May 03, 2020 at 01:43:24PM +, Zane van Iperen wrote: > On Sun, 3 May 2020 15:23:19 +0200 > "Michael Niedermayer" wrote: > > > On Fri, May 01, 2020 at 12:55:18AM +, Zane van Iperen wrote: > > > On Fri, 01 May 2020 00:36:57 + > > > "Zane van Iperen" wrote: > > > > > > > On

[FFmpeg-devel] [PATCH] avcodec/prores_metadata_bsf: Use AVCOL_TRC_NB - 1 for the valid max range

2020-05-03 Thread lance . lmwang
From: Limin Wang Report by Marton after commit. Reviewed-by: Marton Balint Signed-off-by: Limin Wang --- libavcodec/prores_metadata_bsf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/prores_metadata_bsf.c b/libavcodec/prores_metadata_bsf.c index

[FFmpeg-devel] [PATCH v5 21/22] h264_metadata_bsf: Refactor the filter function into smaller parts

2020-05-03 Thread Mark Thompson
--- libavcodec/h264_metadata_bsf.c | 447 ++--- 1 file changed, 244 insertions(+), 203 deletions(-) diff --git a/libavcodec/h264_metadata_bsf.c b/libavcodec/h264_metadata_bsf.c index 451eaa0b67..bfb5b7d7e4 100644 --- a/libavcodec/h264_metadata_bsf.c +++

[FFmpeg-devel] [PATCH v5 18/22] vaapi_encode_h264: Support stereo 3D metadata

2020-05-03 Thread Mark Thompson
Insert frame packing arrangement messages into the stream when input frames have associated stereo 3D side-data. --- doc/encoders.texi | 3 +++ libavcodec/vaapi_encode.h | 1 + libavcodec/vaapi_encode_h264.c | 24 +++- 3 files changed, 27 insertions(+), 1

[FFmpeg-devel] [PATCH v5 11/22] cbs_av1: Use table-based alloc/free

2020-05-03 Thread Mark Thompson
--- libavcodec/cbs_av1.c | 85 1 file changed, 39 insertions(+), 46 deletions(-) diff --git a/libavcodec/cbs_av1.c b/libavcodec/cbs_av1.c index fc228086c2..7b1f6c8a44 100644 --- a/libavcodec/cbs_av1.c +++ b/libavcodec/cbs_av1.c @@ -812,50 +812,6 @@

[FFmpeg-devel] [PATCH v5 16/22] cbs_h264: Add a function to turn stereo 3D metadata into SEI

2020-05-03 Thread Mark Thompson
--- libavcodec/cbs_h264.c | 47 +++ libavcodec/cbs_h264.h | 8 2 files changed, 55 insertions(+) diff --git a/libavcodec/cbs_h264.c b/libavcodec/cbs_h264.c index 75759c7f25..096949e67b 100644 --- a/libavcodec/cbs_h264.c +++

[FFmpeg-devel] [PATCH v5 17/22] vaapi_encode: Unify SEI types enum

2020-05-03 Thread Mark Thompson
This was in two disjoint parts in the H.264 and H.265 files. Unify them in the header to avoid any confusion, because they are really the same enum. --- libavcodec/vaapi_encode.h | 10 ++ libavcodec/vaapi_encode_h264.c | 6 -- libavcodec/vaapi_encode_h265.c | 5 - 3 files

[FFmpeg-devel] [PATCH v5 22/22] h264_metadata_bsf: Improve interpretation of input display matrices

2020-05-03 Thread Mark Thompson
The previous code here only worked in more limited cases. --- libavcodec/h264_metadata_bsf.c | 42 +++--- 1 file changed, 29 insertions(+), 13 deletions(-) diff --git a/libavcodec/h264_metadata_bsf.c b/libavcodec/h264_metadata_bsf.c index bfb5b7d7e4..10f4c3c56d 100644

[FFmpeg-devel] [PATCH v5 19/22] cbs_h265: Add functions to turn HDR metadata into SEI

2020-05-03 Thread Mark Thompson
--- libavcodec/Makefile | 2 +- libavcodec/cbs_h265.c | 100 ++ libavcodec/cbs_h265.h | 18 3 files changed, 119 insertions(+), 1 deletion(-) create mode 100644 libavcodec/cbs_h265.c diff --git a/libavcodec/Makefile b/libavcodec/Makefile

[FFmpeg-devel] [PATCH v5 20/22] vaapi_encode_h265: Use common handling for HDR metadata

2020-05-03 Thread Mark Thompson
--- libavcodec/vaapi_encode_h265.c | 45 +- 1 file changed, 6 insertions(+), 39 deletions(-) diff --git a/libavcodec/vaapi_encode_h265.c b/libavcodec/vaapi_encode_h265.c index ee44d7c442..4307da7bb1 100644 --- a/libavcodec/vaapi_encode_h265.c +++

[FFmpeg-devel] [PATCH v5 08/22] h264_redundant_pps: Make it reference-compatible

2020-05-03 Thread Mark Thompson
From: Andreas Rheinhardt Since c6a63e11092c975b89d824f08682fe31948d3686, the parameter sets modified as content of PPS units were references shared with the CodedBitstreamH264Context, so modifying them alters the parsing process of future access units which meant that frames often got discarded

[FFmpeg-devel] [PATCH v2 1/2] libswscale: add input support AV_PIX_FMT_GBRAPF32

2020-05-03 Thread mindmark
From: Mark Reid --- libswscale/input.c | 91 ++ libswscale/utils.c | 4 ++ 2 files changed, 95 insertions(+) diff --git a/libswscale/input.c b/libswscale/input.c index 099661cb6d..e74cf04133 100644 --- a/libswscale/input.c +++ b/libswscale/input.c

Re: [FFmpeg-devel] [PATCH 3/3 v4] avcodec/cbs_h265: add missing support for reserved_payload_extension_data SEI bits

2020-05-03 Thread James Almer
On 5/3/2020 7:22 PM, Mark Thompson wrote: > On 03/05/2020 16:55, James Almer wrote: >> On 5/3/2020 12:39 PM, Mark Thompson wrote: >>> On 30/04/2020 22:50, James Almer wrote: Fixes ticket #8622 Signed-off-by: James Almer --- libavcodec/cbs_h2645.c| 1 +

Re: [FFmpeg-devel] [PATCH v1 4/4] avcodec/proresenc_anatoliy: support for more color matrix for proresenc

2020-05-03 Thread lance . lmwang
On Sun, May 03, 2020 at 07:01:36PM +0200, Marton Balint wrote: > > > On Sun, 3 May 2020, lance.lmw...@gmail.com wrote: > > > On Sun, May 03, 2020 at 09:53:09AM +0200, Marton Balint wrote: > > > > > > > > > On Tue, 5 Nov 2019, lance.lmw...@gmail.com wrote: > > > > > > > From: Limin Wang > >

[FFmpeg-devel] [PATCH v5 03/22] cbs: Describe allocate/free methods in tabular form

2020-05-03 Thread Mark Thompson
Unit types are split into three categories, depending on how their content is managed: * POD structure - these require no special treatment. * Structure containing references to refcounted buffers - these can use a common free function when the offsets of all the internal references are known.

[FFmpeg-devel] [PATCH v5 07/22] cbs_h2645: Ensure that non-refcounted parameter sets are fully copied

2020-05-03 Thread Mark Thompson
Only copying the main structure is not necessarily sufficient - there could be references to substructures. --- libavcodec/cbs_h2645.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c index b5a033dcbd..e4fbd8e633 100644

[FFmpeg-devel] [PATCH v5 12/22] cbs_mpeg2: Use table-based alloc/free

2020-05-03 Thread Mark Thompson
--- libavcodec/cbs_mpeg2.c | 70 +- 1 file changed, 35 insertions(+), 35 deletions(-) diff --git a/libavcodec/cbs_mpeg2.c b/libavcodec/cbs_mpeg2.c index 97f7889cbb..94e02945f3 100644 --- a/libavcodec/cbs_mpeg2.c +++ b/libavcodec/cbs_mpeg2.c @@ -140,28

[FFmpeg-devel] [PATCH v5 06/22] cbs: Add support functions for handling unit content references

2020-05-03 Thread Mark Thompson
Use the unit type table to determine what we need to do to clone the internals of the unit content when making copies for refcounting or writeability. (This will still fail for units with complex content if they do not have a defined clone function.) Setup and naming from a patch by Andreas

[FFmpeg-devel] [PATCH v5 13/22] cbs: Expose the function to insert a new empty unit into a fragment

2020-05-03 Thread Mark Thompson
This will be helpful when adding new SEI to an existing access unit. --- libavcodec/cbs.c | 10 +- libavcodec/cbs.h | 7 +++ 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/libavcodec/cbs.c b/libavcodec/cbs.c index 2f39ddbfb4..2346b1621b 100644 --- a/libavcodec/cbs.c

[FFmpeg-devel] [PATCH v5 05/22] cbs_h264: Use table-based alloc/free

2020-05-03 Thread Mark Thompson
--- libavcodec/cbs_h2645.c | 163 ++--- 1 file changed, 70 insertions(+), 93 deletions(-) diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c index d42073cc5a..b5a033dcbd 100644 --- a/libavcodec/cbs_h2645.c +++ b/libavcodec/cbs_h2645.c @@ -443,52

[FFmpeg-devel] [PATCH v5 04/22] cbs: Add macros to support defining unit type tables

2020-05-03 Thread Mark Thompson
--- libavcodec/cbs_internal.h | 24 1 file changed, 24 insertions(+) diff --git a/libavcodec/cbs_internal.h b/libavcodec/cbs_internal.h index 282492bc88..35159f9c5f 100644 --- a/libavcodec/cbs_internal.h +++ b/libavcodec/cbs_internal.h @@ -167,6 +167,30 @@ int

[FFmpeg-devel] [PATCH v5 14/22] cbs_h264: Simplify SEI addition

2020-05-03 Thread Mark Thompson
At the same time, move the H.264 SEI functions to a new file - the combined H.26[45] CBS file is already very large, and these functions do not require any of the common read/write elements. --- libavcodec/Makefile| 2 +- libavcodec/cbs_h264.c | 106

[FFmpeg-devel] [PATCH v5 09/22] cbs_h265: Use table-based alloc/free

2020-05-03 Thread Mark Thompson
--- libavcodec/cbs_h2645.c | 196 +++-- 1 file changed, 92 insertions(+), 104 deletions(-) diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c index e4fbd8e633..b70aa3c39d 100644 --- a/libavcodec/cbs_h2645.c +++ b/libavcodec/cbs_h2645.c @@ -443,71

[FFmpeg-devel] [PATCH v5 15/22] cbs_h264: Add support for frame packing arrangement SEI messages

2020-05-03 Thread Mark Thompson
--- libavcodec/cbs_h264.h | 24 libavcodec/cbs_h2645.c| 1 + libavcodec/cbs_h264_syntax_template.c | 40 +++ 3 files changed, 65 insertions(+) diff --git a/libavcodec/cbs_h264.h b/libavcodec/cbs_h264.h index

[FFmpeg-devel] [PATCH v5 10/22] cbs_vp9: Use table-based alloc/free

2020-05-03 Thread Mark Thompson
--- libavcodec/cbs_vp9.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/libavcodec/cbs_vp9.c b/libavcodec/cbs_vp9.c index eef603bfb2..37b817cfde 100644 --- a/libavcodec/cbs_vp9.c +++ b/libavcodec/cbs_vp9.c @@ -479,13 +479,6 @@ static int

[FFmpeg-devel] [PATCH v5 01/22] cbs: Mention all codecs in unit type comment

2020-05-03 Thread Mark Thompson
--- libavcodec/cbs.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/cbs.h b/libavcodec/cbs.h index 9ca1fbd609..cb3081e2c6 100644 --- a/libavcodec/cbs.h +++ b/libavcodec/cbs.h @@ -45,8 +45,10 @@ struct CodedBitstreamType; /** * The codec-specific type of a bitstream unit. *

[FFmpeg-devel] [PATCH v5 02/22] cbs: Ensure that reference fields always follow the associated pointer

2020-05-03 Thread Mark Thompson
Having these together allows us to find both pointers given the address of only one of them. --- libavcodec/cbs_av1.h | 6 +++--- libavcodec/cbs_h264.h | 18 +- libavcodec/cbs_h265.h | 16 libavcodec/cbs_jpeg.h | 2 +- libavcodec/cbs_mpeg2.h | 10 +-

Re: [FFmpeg-devel] [PATCH 3/3 v4] avcodec/cbs_h265: add missing support for reserved_payload_extension_data SEI bits

2020-05-03 Thread Mark Thompson
On 03/05/2020 16:55, James Almer wrote: > On 5/3/2020 12:39 PM, Mark Thompson wrote: >> On 30/04/2020 22:50, James Almer wrote: >>> Fixes ticket #8622 >>> >>> Signed-off-by: James Almer >>> --- >>> libavcodec/cbs_h2645.c| 1 + >>> libavcodec/cbs_h265.h | 1 + >>>

Re: [FFmpeg-devel] [PATCH] lavf/fps: add cmd to force write buf frame

2020-05-03 Thread Jim DeLaHunt
On 2020-05-02 15:35, Jai Luthra wrote: Enables writing buffered frames to the outsink using send command api. This is useful when a lavf user wants to fetch buffered frames without closing/reopening the filtergraph again and again. Signed-off-by: Jai Luthra --- libavfilter/vf_fps.c | 36

[FFmpeg-devel] [PATCH v2 2/2] libswscale: add output support for AV_PIX_FMT_GBRAPF32

2020-05-03 Thread mindmark
From: Mark Reid --- libswscale/output.c | 82 libswscale/slice.c | 28 libswscale/swscale.c | 5 ++ libswscale/swscale_internal.h| 36 +++ libswscale/swscale_unscaled.c

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/wavpack: Check rate_x and sample rate for overflow

2020-05-03 Thread David Bryant
On 5/2/20 2:08 PM, Michael Niedermayer wrote: > Fixes: shift exponent 32 is too large for 32-bit type 'int' > Fixes: > 21647/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVPACK_fuzzer-5686168323883008 > > Found-by: continuous fuzzing process >

[FFmpeg-devel] [PATCH] lavc/bsf: add an Opus metadata bitstream filter

2020-05-03 Thread Lynne
The only adjustable field is the gain. Some ripping/transcoding programs have started to use it for replaygain adjustments. Patch attached. >From 44f83786e057d468efee986ee865ba8c776ebe9b Mon Sep 17 00:00:00 2001 From: Lynne Date: Sun, 3 May 2020 21:17:33 +0100 Subject: [PATCH] lavc/bsf: add an

[FFmpeg-devel] [RFC][PATCH] avfilter: add speechnorm filter

2020-05-03 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/Makefile| 1 + libavfilter/af_speechnorm.c | 381 libavfilter/allfilters.c| 1 + 3 files changed, 383 insertions(+) create mode 100644 libavfilter/af_speechnorm.c diff --git a/libavfilter/Makefile

Re: [FFmpeg-devel] [PATCH v1 2/4] avcodec/prores_metadata_bsf: add smpte2084 format support

2020-05-03 Thread lance . lmwang
On Sun, May 03, 2020 at 07:05:14PM +0200, Marton Balint wrote: > > > On Sun, 3 May 2020, lance.lmw...@gmail.com wrote: > > > On Sun, May 03, 2020 at 10:01:31AM +0200, Marton Balint wrote: > > > > > > > > > On Fri, 15 Nov 2019, Limin Wang wrote: > > > > > > > > ping, the patchset is for

Re: [FFmpeg-devel] avdevice/v4l2enc: Allow writing non-rawvideos to v4l2

2020-05-03 Thread Mark Thompson
On 26/04/2020 21:26, David Manouchehri wrote: > Resubmit of a previous patch, not sure why the diff didn't come through. > > From d125fea410dea1c2d4bd791a7472a72822de54a3 Mon Sep 17 00:00:00 2001 > From: David Manouchehri > Date: Sat, 4 Nov 2017 16:32:41 -0400 > Subject: [PATCH]

Re: [FFmpeg-devel] [PATCH] cbs_h265: Ensure that a predicted RPS doesn't contain too many pictures

2020-05-03 Thread Mark Thompson
On 03/05/2020 19:14, Michael Niedermayer wrote: > On Sun, May 03, 2020 at 04:30:00PM +0100, Mark Thompson wrote: >> If the RPS we are predicting from has maximum size then at least one of >> the pictures in it must be discarded before adding the current one. >> >> Also revert

[FFmpeg-devel] [PATCH v2 0/2] initial input/output support for AV_PIX_FMT_GBRAPF32

2020-05-03 Thread mindmark
From: Mark Reid changes since v1 - added missing fillPlane32 function - tests should pass now for qemu-mips - removed exr patch for now Mark Reid (2): libswscale: add input support AV_PIX_FMT_GBRAPF32 libswscale: add output support for AV_PIX_FMT_GBRAPF32 libswscale/input.c

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode: add FF_CODEC_CAP_INIT_CLEANUP caps for encoders

2020-05-03 Thread Fu, Linjie
> From: ffmpeg-devel On Behalf Of Fu, > Linjie > Sent: Thursday, April 23, 2020 22:59 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode: add > FF_CODEC_CAP_INIT_CLEANUP caps for encoders > > > From: Fu, Linjie > > Sent: Tuesday, March 31, 2020 23:34 > > To:

[FFmpeg-devel] [PATCH v4] avcodec/options_table: Support mpeg2 encoder profile with const options

2020-05-03 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/options_table.h | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/options_table.h b/libavcodec/options_table.h index 5436674..044a8a2 100644 --- a/libavcodec/options_table.h +++ b/libavcodec/options_table.h @@ -280,6

[FFmpeg-devel] [PATCH] avformat/hlsenc: resend full url of the init fragment mp4

2020-05-03 Thread Steven Liu
fix ticket: 8651 because the init fragment mp4 file name is without base url name, so just modify it use the full url which splice after init function. Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/hlsenc.c

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode: add FF_CODEC_CAP_INIT_CLEANUP caps for encoders

2020-05-03 Thread Timo Rothenpieler
On 31.03.2020 17:34, Linjie Fu wrote: ff_vaapi_encode_close() is not enough to free the resources like cbs if initialization failure happens after codec->configure (except for vp8/vp9). We need to call avctx->codec->close() to deallocate, otherwise memory leak happens. Add

Re: [FFmpeg-devel] [PATCH v3] libavformat/flacdec: Workaround for truncated metadata picture size

2020-05-03 Thread Mattias Wadman
Sorry for nagging, something left to fix? On Mon, Apr 27, 2020 at 10:10 AM Mattias Wadman wrote: > > Hi again, looks ok? > > On Fri, Apr 24, 2020 at 12:54 PM Mattias Wadman > wrote: > > > > lavf flacenc could previously write truncated metadata picture size if > > the picture data did not fit

Re: [FFmpeg-devel] [PATCH] lavf/fps: add cmd to force write buf frame

2020-05-03 Thread Paul B Mahol
Missing documentation. Also it is lavfi not lavf. On 5/3/20, Jai Luthra wrote: > Enables writing buffered frames to the outsink using send command api. > > This is useful when a lavf user wants to fetch buffered frames without > closing/reopening the filtergraph again and again. > >

Re: [FFmpeg-devel] [PATCH v1 2/4] avcodec/prores_metadata_bsf: add smpte2084 format support

2020-05-03 Thread lance . lmwang
On Sun, May 03, 2020 at 10:01:31AM +0200, Marton Balint wrote: > > > On Fri, 15 Nov 2019, Limin Wang wrote: > > > > > ping, the patchset is for HDR/HLG color support for prores. > > > > On Mon, Nov 04, 2019 at 07:10:00PM +0800, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > >

Re: [FFmpeg-devel] [PATCH v1 1/2] avfilter/vf_subtitles: remove unneeded ifdef

2020-05-03 Thread lance . lmwang
On Mon, Mar 30, 2020 at 06:52:32PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavfilter/vf_subtitles.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/libavfilter/vf_subtitles.c b/libavfilter/vf_subtitles.c >

Re: [FFmpeg-devel] [PATCH v1] avfilter/src_movie: Fix the loop function of dynamic logo

2020-05-03 Thread lance . lmwang
On Tue, Mar 17, 2020 at 06:55:00PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > The following command will attempt to create the input and overlay test > sequence for you. > ./ffmpeg -f lavfi -i color=white:duration=100:r=25:size=1280x720 input.mkv > ./ffmpeg -f lavfi -i

Re: [FFmpeg-devel] [PATCH v1] avcodec/utils: use av_rescale()

2020-05-03 Thread lance . lmwang
On Mon, Apr 20, 2020 at 07:00:55PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/utils.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/utils.c b/libavcodec/utils.c > index

Re: [FFmpeg-devel] [PATCH v1] avcodec/h264_metadata_bsf: add option to delete SEI user data

2020-05-03 Thread lance . lmwang
On Mon, Apr 20, 2020 at 07:01:09PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > doc/bitstream_filters.texi | 3 +++ > libavcodec/h264_metadata_bsf.c | 19 +++ > 2 files changed, 22 insertions(+) > > diff --git

Re: [FFmpeg-devel] [PATCH v1 2/4] avcodec/prores_metadata_bsf: add smpte2084 format support

2020-05-03 Thread Marton Balint
On Fri, 15 Nov 2019, Limin Wang wrote: ping, the patchset is for HDR/HLG color support for prores. On Mon, Nov 04, 2019 at 07:10:00PM +0800, lance.lmw...@gmail.com wrote: From: Limin Wang It's based on the following specs: RDD 36:2015 - SMPTE Registered Disclosure Doc - Apple ProRes

Re: [FFmpeg-devel] [PATCH v1 4/4] avcodec/proresenc_anatoliy: support for more color matrix for proresenc

2020-05-03 Thread Marton Balint
On Tue, 5 Nov 2019, lance.lmw...@gmail.com wrote: From: Limin Wang Please tested with below command: ./ffmpeg -i ../fate-suite/mpeg2/t.mpg -c:v prores_aw -color_primaries bt2020 -colorspace bt2020_ncl -color_trc smpte2084 -an output.mov mediainfo outout.mov ... Color primaries

Re: [FFmpeg-devel] [PATCH 2/3] libswscale: add output support for AV_PIX_FMT_GBRAPF32

2020-05-03 Thread Carl Eugen Hoyos
Am So., 3. Mai 2020 um 11:08 Uhr schrieb Mark Reid : > lt appears the mips test where only failing on the alpha channel formats. > it seems to because of a planefill function I missed implementing. I've > fixed it and the same test results work both on mips and x86, so I don't > think this is

[FFmpeg-devel] [PATCH] avcodec/wmv2dsp: fix wrong macro for init_mips

2020-05-03 Thread Rosen Penev
ff_wmv2dsp_init_mips is a void function that only does anything for HAVE_MMI, which is 64-bit specific. Signed-off-by: Rosen Penev --- libavcodec/wmv2dsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/wmv2dsp.c b/libavcodec/wmv2dsp.c index

Re: [FFmpeg-devel] [PATCH]lavfi/signature: Fix a cast of a function pointer

2020-05-03 Thread Carl Eugen Hoyos
Am Fr., 1. Mai 2020 um 23:57 Uhr schrieb Carl Eugen Hoyos : > Attached patch fixes an ugly warning when compiling with -Wpedantic. > I am not in favour of adding casts to silence such warnings, but there > already is an incorrect cast. Will push if there are no comments. Carl Eugen

[FFmpeg-devel] [PATCH] avformat/matroskadec: Free right buffer on error

2020-05-03 Thread Andreas Rheinhardt
Since commit 979b5b89594c7628bd846c63198cb64ef9d81d16, reverting the Matroska ContentCompression is no longer done inside matroska_parse_frame() (the function that creates AVPackets out of the parsed data (unless we are dealing with certain codecs that need special handling)), but instead in

Re: [FFmpeg-devel] [PATCH 2/3] libswscale: add output support for AV_PIX_FMT_GBRAPF32

2020-05-03 Thread Mark Reid
On Thu., Apr. 30, 2020, 11:46 a.m. Mark Reid, wrote: > > > On Thu, Apr 30, 2020 at 7:59 AM Michael Niedermayer > wrote: > >> On Wed, Apr 29, 2020 at 02:49:35PM -0700, Mark Reid wrote: >> > On Wed, Apr 29, 2020 at 2:22 PM Michael Niedermayer >> >> > wrote: >> > >> > > On Wed, Apr 29, 2020 at

Re: [FFmpeg-devel] [PATCH v1] avcodec/utils: use av_rescale()

2020-05-03 Thread Andreas Rheinhardt
lance.lmw...@gmail.com: > On Mon, Apr 20, 2020 at 07:00:55PM +0800, lance.lmw...@gmail.com wrote: >> From: Limin Wang >> >> Signed-off-by: Limin Wang >> --- >> libavcodec/utils.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/libavcodec/utils.c

Re: [FFmpeg-devel] [PATCH 1/2] avformat/vividas: simplify, use av_rescale_q() instead

2020-05-03 Thread lance . lmwang
On Tue, Apr 28, 2020 at 11:49:16AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > note it'll cause a small difference in accuracy for the pts, please see the > testing result below: > $ wget >

Re: [FFmpeg-devel] [PATCH v1] avcodec/utils: use av_rescale()

2020-05-03 Thread lance . lmwang
On Sun, May 03, 2020 at 03:10:09PM +0200, Andreas Rheinhardt wrote: > lance.lmw...@gmail.com: > > On Mon, Apr 20, 2020 at 07:00:55PM +0800, lance.lmw...@gmail.com wrote: > >> From: Limin Wang > >> > >> Signed-off-by: Limin Wang > >> --- > >> libavcodec/utils.c | 4 ++-- > >> 1 file changed, 2

Re: [FFmpeg-devel] [PATCH v1 4/4] avcodec/proresenc_anatoliy: support for more color matrix for proresenc

2020-05-03 Thread lance . lmwang
On Sun, May 03, 2020 at 09:53:09AM +0200, Marton Balint wrote: > > > On Tue, 5 Nov 2019, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > Please tested with below command: > > ./ffmpeg -i ../fate-suite/mpeg2/t.mpg -c:v prores_aw -color_primaries > > bt2020 -colorspace bt2020_ncl

Re: [FFmpeg-devel] [PATCH v1 2/3] avutil/avstring: add support for '\\' seperator for the path append

2020-05-03 Thread lance . lmwang
On Mon, Jan 13, 2020 at 09:44:50PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > I don't have a windows develoment system yet, so I had to test with modified > avutil/tests/avstring.c like below, > (change / to \\) and change HAVE_DOS_PATHS to 1 in config.h: > -

Re: [FFmpeg-devel] [PATCH v11] avformat: add demuxer for Pro Pinball Series' Soundbanks

2020-05-03 Thread Michael Niedermayer
On Fri, May 01, 2020 at 12:55:18AM +, Zane van Iperen wrote: > On Fri, 01 May 2020 00:36:57 + > "Zane van Iperen" wrote: > > > On Fri, 1 May 2020 01:09:17 +0200 > > "Michael Niedermayer" wrote: > > > > > > +size = FFMIN(trk->data_size - ctx->bytes_read, > > > >

Re: [FFmpeg-devel] [PATCH v1 1/2] avfilter/vf_subtitles: remove unneeded ifdef

2020-05-03 Thread Andreas Rheinhardt
lance.lmw...@gmail.com: > On Mon, Mar 30, 2020 at 06:52:32PM +0800, lance.lmw...@gmail.com wrote: >> From: Limin Wang >> >> Signed-off-by: Limin Wang >> --- >> libavfilter/vf_subtitles.c | 6 ++ >> 1 file changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/libavfilter/vf_subtitles.c

Re: [FFmpeg-devel] [PATCH v11] avformat: add demuxer for Pro Pinball Series' Soundbanks

2020-05-03 Thread Zane van Iperen
On Sun, 3 May 2020 15:23:19 +0200 "Michael Niedermayer" wrote: > On Fri, May 01, 2020 at 12:55:18AM +, Zane van Iperen wrote: > > On Fri, 01 May 2020 00:36:57 + > > "Zane van Iperen" wrote: > > > > > On Fri, 1 May 2020 01:09:17 +0200 > > > "Michael Niedermayer" wrote: > > > > > > >

Re: [FFmpeg-devel] [PATCH 3/3 v4] avcodec/cbs_h265: add missing support for reserved_payload_extension_data SEI bits

2020-05-03 Thread James Almer
On 4/30/2020 6:50 PM, James Almer wrote: > Fixes ticket #8622 > > Signed-off-by: James Almer > --- > libavcodec/cbs_h2645.c| 1 + > libavcodec/cbs_h265.h | 1 + > libavcodec/cbs_h265_syntax_template.c | 85 +-- > 3 files changed, 70

Re: [FFmpeg-devel] [PATCH v1 1/2] avfilter/vf_subtitles: remove unneeded ifdef

2020-05-03 Thread lance . lmwang
On Sun, May 03, 2020 at 03:35:19PM +0200, Andreas Rheinhardt wrote: > lance.lmw...@gmail.com: > > On Mon, Mar 30, 2020 at 06:52:32PM +0800, lance.lmw...@gmail.com wrote: > >> From: Limin Wang > >> > >> Signed-off-by: Limin Wang > >> --- > >> libavfilter/vf_subtitles.c | 6 ++ > >> 1 file