Re: [FFmpeg-devel] Project orientation

On Sun, Jul 05, 2020 at 11:42:19PM +, Soft Works wrote: > When then reviewer would not have to look for code style and could > assume that this is all right, he would be free to focus on the actual things. FWIW: At work, we went to clang-format to simply automate away 90% of these things

[FFmpeg-devel] [PATCH] dnn_backend_native: Add overflow check for length calculation.

We should not silently allocate an incorrect sized buffer. Fixes trac issue #8718. TODO1: calculate_operand_dims_count is almost identical code, should they be merged and its usages check for overflow? TODO2: the -1 return value seems questionable to me, but is aligned with the return value used

Re: [FFmpeg-devel] Project orientation

> Is it? It works easily for me just using msmtp or a similar > sendmail implementation that speaks SMTP. > No need for a mail server. > If you think it's an issue, maybe it needs to be documented? See the comments about Gmail above from a few people. Yes it can be done but it's another barrier

Re: [FFmpeg-devel] [PATCH] [GSoC 3/6] avformat/hls: use abr to switch streams

Hongcheng Zhong 于2020年7月5日周日 下午7:35写道： > > From: spartazhc > > When abr is enable, it will take over the task to call http to > download segments, and will return a switch-request for hls to > switch streams. > For reason not to waste segments that have been downloaded, > switch will become

[FFmpeg-devel] [PATCH] dnn_backend_native: Add overflow check for length calculation.

We should not silently allocate an incorrect sized buffer. Fixes trac issue #8718. TODO1: calculate_operand_dims_count is almost identical code, should they be merged and its usages check for overflow? TODO2: the -1 return value seems questionable to me, but is aligned with the return value used

[FFmpeg-devel] [PATCH v5 1/6] avformat/apm: use new extradata format

Signed-off-by: Zane van Iperen --- libavformat/Makefile | 2 +- libavformat/apm.c| 62 2 files changed, 35 insertions(+), 29 deletions(-) diff --git a/libavformat/Makefile b/libavformat/Makefile index 26af859a28..a4113fe644 100644 ---

[FFmpeg-devel] [PATCH v5 4/6] avformat: add apm muxer

Signed-off-by: Zane van Iperen --- Changelog| 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/apm.c| 110 ++- libavformat/version.h| 2 +- 5 files changed, 112 insertions(+), 3 deletions(-)

[FFmpeg-devel] [PATCH v5 2/6] avformat/apm: fix variable/structure names and cosmetics

Signed-off-by: Zane van Iperen --- libavformat/apm.c | 94 --- 1 file changed, 48 insertions(+), 46 deletions(-) diff --git a/libavformat/apm.c b/libavformat/apm.c index b51b9fcbe6..666cb97fd3 100644 --- a/libavformat/apm.c +++ b/libavformat/apm.c @@

[FFmpeg-devel] [PATCH v5 0/6] adpcm_ima_apm encoder + apm muxer

Add support for encoding adpcm_ima_apm and muxing to apm. v5: [7] * split out cosmetic changes into their own patch v4: * fix rebase issues v3: [4][5][6] * Support both extradata formats - fixes FATE failure + preserves compatibility * EINVAL->ERANGE v2: [1][2][3] * fix mixed declarations

Re: [FFmpeg-devel] Project orientation

On Sun, Jul 05, 2020 at 10:50:14PM +0200, Michael Niedermayer wrote: > To Achieve this, we could try to > * attract more developers doing reviews, i have generally suggested > contributors to help review other peoples patches. Maybe i should > take a step back and ask developers to ask

Re: [FFmpeg-devel] RfP Candidates

On Mon, Jul 6, 2020, at 09:48, Paul B Mahol wrote: > On 7/3/20, Jean-Baptiste Kempf wrote: > > On Thu, Jul 2, 2020, at 12:46, Jean-Baptiste Kempf wrote: > >> We'll accept candidates until Saturday night, 23:59UTC. > > > > 24-hours remaining ping. > > > > Everyone can make it :) > > Time passed.

Re: [FFmpeg-devel] Project orientation

On Sun, Jul 05, 2020 at 06:18:20PM +0100, Kieran Kunhya wrote: > On Sun, Jul 5, 2020 at 6:01 PM Kieran Kunhya wrote: > > > > Going back to the original point in hand. > > Many patches aren't getting reviewed and pushed any more. > > > > In part this is because in 2020 whether we like it or not

Re: [FFmpeg-devel] RfP Candidates

On 7/3/20, Jean-Baptiste Kempf wrote: > On Thu, Jul 2, 2020, at 12:46, Jean-Baptiste Kempf wrote: >> We'll accept candidates until Saturday night, 23:59UTC. > > 24-hours remaining ping. > > Everyone can make it :) Time passed. Is there enough candidates? Or we vote like in North Korea? > -- >

Re: [FFmpeg-devel] [PATCH V2 12/12] dnn-layer-math-unary-test: add unit test for atanh

> -Original Message- > From: ffmpeg-devel On Behalf Of Ting Fu > Sent: 2020年6月29日 22:54 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH V2 12/12] dnn-layer-math-unary-test: add unit > test for atanh > > Signed-off-by: Ting Fu > --- >

Re: [FFmpeg-devel] [PATCH] [GSoC 1/6] avformat/abr: Adaptive Bitrate support

Hongcheng Zhong 于2020年7月5日周日 下午7:35写道： > > From: spartazhc > > Add abr module for hls/dash. > > Signed-off-by: spartazhc > --- > doc/protocols.texi | 7 + > libavformat/Makefile| 1 + > libavformat/abr.c | 282 >

Re: [FFmpeg-devel] [PATCH] [GSoC 1/6] avformat/abr: Adaptive Bitrate support

On Sun, Jul 05, 2020 at 19:34:54 +0800, Hongcheng Zhong wrote: > +static int abr_rule(ABRContext *c, float bw_estimate) > +{ > +int ret = -1; > + > +if (c->n_throughputs > 6) { > +if (bw_estimate < c->variants_bitrate[c->cur_pls].value / 1000 * 1.2 > && > +bw_estimate

[FFmpeg-devel] [PATCH v5 3/6] avcodec: add adpcm_ima_apm encoder

Signed-off-by: Zane van Iperen --- Changelog | 1 + doc/general.texi | 2 +- libavcodec/Makefile| 1 + libavcodec/adpcmenc.c | 34 -- libavcodec/allcodecs.c | 1 + libavcodec/utils.c | 1 + libavcodec/version.h | 2 +- 7 files

[FFmpeg-devel] [PATCH v5 5/6] fate: add adpcm_ima_apm encoding test

Signed-off-by: Zane van Iperen --- tests/fate/acodec.mak | 2 ++ tests/ref/acodec/adpcm-ima_apm | 4 2 files changed, 6 insertions(+) create mode 100644 tests/ref/acodec/adpcm-ima_apm diff --git a/tests/fate/acodec.mak b/tests/fate/acodec.mak index bb6bfe5ada..197b6ed7c0 100644

[FFmpeg-devel] [PATCH v5 6/6] avcodec/adpcmenc: cleanup trellis checks

Signed-off-by: Zane van Iperen --- libavcodec/adpcmenc.c | 35 ++- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/libavcodec/adpcmenc.c b/libavcodec/adpcmenc.c index 4985abb163..adb7bf0bbf 100644 --- a/libavcodec/adpcmenc.c +++

Re: [FFmpeg-devel] [PATCH] Ticket #8750 Add inline function for the vec_xl intrinsic in non-VSX environments

ffmpeg_altivec_yuv2rgb_novsx.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject

Re: [FFmpeg-devel] [PATCH] Ticket #8750 Add inline function for the vec_xl intrinsic in non-VSX environments

ffmpeg_altivec_yuv2rgb_novsx.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject

Re: [FFmpeg-devel] [PATCH] dnn_backend_native: Add overflow check for length calculation.

> -Original Message- > From: ffmpeg-devel On Behalf Of Reimar > D?ffinger > Sent: 2020年7月6日 15:32 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH] dnn_backend_native: Add overflow check for > length calculation. > > We should not silently allocate an incorrect sized

Re: [FFmpeg-devel] [PATCH 1/3] lavu: add a template for refcounted objects.

Hi all! On 2020-07-01 17:05 +0200, Anton Khirnov wrote: > Quoting Nicolas George (2020-06-27 17:16:44) > > Signed-off-by: Nicolas George > > --- > > libavutil/avrefcount_template.h | 140 > > tests/ref/fate/source | 1 + > > 2 files changed, 141

Re: [FFmpeg-devel] [PATCH] avcodec/h264: support sps/pps AV_PKT_DATA_NEW_EXTRADATA

On 6/19/2020 5:10 PM, Olly Woodman wrote: > On Tue, 2 Jun 2020 at 22:32, Olly Woodman wrote: > >> >> >> On Fri, 8 May 2020 at 03:10, Oliver Woodman wrote: >> >>> https://github.com/FFmpeg/FFmpeg/commit/601c238 added support >>> for AV_PKT_DATA_NEW_EXTRADATA, but only for avcC extradata. >>>

Re: [FFmpeg-devel] [PATCH] avformat/isom: allow ISO 639 codes for mov

On Fri, Jun 19, 2020 at 5:11 PM Yongle Lin wrote: > Allow ISO 639 language codes for text tracks in mov format when > strictness is set to experimental > --- > libavformat/isom.c | 9 +++-- > libavformat/isom.h | 2 +- > libavformat/movenc.c | 6 +++--- >

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_codecview: add block structure visualization

On Thu, Jul 2, 2020 at 8:09 AM Michael Niedermayer wrote: > On Wed, Jul 01, 2020 at 05:42:48PM +, Yongle Lin wrote: > > example command line to visualize block decomposition: > > ./ffmpeg -export_side_data +venc_params -i input.webm -vf > > codecview=bs=true output.webm > > --- > > >

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_codecview: enable qp visualization for H264 and VP9

On Thu, Jun 25, 2020 at 12:09 PM Yongle Lin wrote: > Add qp visualization in codecview filter which supports H264 and VP9 > codecs. Add options for luma/chroma qp and AC/DC qp as well. There is a old > way to visualize it but it's deprecated since version 58. > example command line to visualize

Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_edgedetect: properly implement double_threshold()

On 2020-07-04 23:19 -0400, Andriy Gelman wrote: > On Sun, 05. Jul 09:37, lance.lmw...@gmail.com wrote: > > On Sat, Jul 04, 2020 at 01:03:48PM -0400, Andriy Gelman wrote: > > > On Mon, 29. Jun 09:26, Valery Kot wrote: > > > > On Sun, Jun 28, 2020 at 12:03 AM Andriy Gelman > > > > wrote: > > > > >

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: fix build w/libaom v1.0.0

James, On Thu, Jul 2, 2020 at 10:28 AM James Zern wrote: > > broken since: > aa5c6f382b avcodec/libaomenc: Add command-line options to control the use of > partition tools > > Signed-off-by: James Zern > --- > doc/encoders.texi | 20 ++-- > libavcodec/libaomenc.c | 4

[FFmpeg-devel] [PATCH] libavcodec/vp9: export block structure when segmentation isn't enable

it makes sense to export block structure like src_x, src_y, width and height when segmentation isn't enable so we could visualize and see the structure of the block. --- libavcodec/vp9.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/libavcodec/vp9.c

Re: [FFmpeg-devel] [PATCH v5 1/6] avformat/apm: use new extradata format

On Mon, Jul 06, 2020 at 09:24:20AM +, Zane van Iperen wrote: > Signed-off-by: Zane van Iperen > --- > libavformat/Makefile | 2 +- > libavformat/apm.c| 62 > 2 files changed, 35 insertions(+), 29 deletions(-) I think the commit message

Re: [FFmpeg-devel] [PATCH] avcodec/h264: support sps/pps AV_PKT_DATA_NEW_EXTRADATA

On 6/19/20, Olly Woodman wrote: > On Tue, 2 Jun 2020 at 22:32, Olly Woodman wrote: > >> >> >> On Fri, 8 May 2020 at 03:10, Oliver Woodman wrote: >> >>> https://github.com/FFmpeg/FFmpeg/commit/601c238 added support >>> for AV_PKT_DATA_NEW_EXTRADATA, but only for avcC extradata. >>> This commit

Re: [FFmpeg-devel] Project orientation

On Mon, 6 Jul 2020 at 05:54, Jim DeLaHunt wrote: > On 2020-07-04 07:43, Nicolas George wrote: > > [In the FFmpeg project,] [t]here is work in making highly-optimized > > decoders, this work is impressive and creative…. But as far as I can see, > > that is mostly all there is going on. The rest

[FFmpeg-devel] [PATCH] libavfilter/vf_codecview: add block structure visualization

example command line to visualize block decomposition: ./ffmpeg -export_side_data +venc_params -i input.webm -vf codecview=bs=true output.webm --- doc/filters.texi | 3 +++ libavfilter/vf_codecview.c | 41 ++ 2 files changed, 44 insertions(+) diff

[FFmpeg-devel] [PATCH] avformat/smjpegdec: Check the existence of referred streams

Fixes: Assertion failure Fixes: 23758/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5160954605338624.fuzz Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/smjpegdec.c | 7 +++ 1

Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_edgedetect: properly implement double_threshold()

Hi Alex, Thanks for testing. On Mon, 6 Jul 2020 at 14:49, Alexander Strasser wrote: > On 2020-07-04 23:19 -0400, Andriy Gelman wrote: > > On Sun, 05. Jul 09:37, lance.lmw...@gmail.com wrote: > > > On Sat, Jul 04, 2020 at 01:03:48PM -0400, Andriy Gelman wrote: > > > > On Mon, 29. Jun 09:26,

Re: [FFmpeg-devel] Bad language on this mailing list

On 2020-07-04 14:08, Jean-Baptiste Kempf wrote: On Sat, Jul 4, 2020, at 20:09, Paul B Mahol wrote: Why is bad and offensive language tolerated on this mailing list and on IRC? It is not tolerated. Whatever the reason. -- Jean-Baptiste Kempf - President Jean-Baptiste, with respect,

Re: [FFmpeg-devel] Bad language on this mailing list

On 7/6/20, Jim DeLaHunt wrote: > On 2020-07-04 14:08, Jean-Baptiste Kempf wrote: > >> On Sat, Jul 4, 2020, at 20:09, Paul B Mahol wrote: >>> Why is bad and offensive language tolerated on this mailing list and on >>> IRC? >> It is not tolerated. >> Whatever the reason. >> >> -- >> Jean-Baptiste

Re: [FFmpeg-devel] libavutil/imgutils: UBSan nullptr-with-offset in av_image_fill_pointer

I'm using clang 10.0.0 and configuring with with `configure --enable-gpl --enable-libass --enable-libfdk-aac --enable-libmp3lame --enable-libopencore-amrnb --enable-libopencore-amrwb --enable-librtmp --enable-libtheora --enable-libvorbis --enable-libopus --enable-libx264 --enable-libvpx

Re: [FFmpeg-devel] [PATCH v2] avfilter: add nonlinearstretch filter.

> On 29 Jun 2020, at 17.33, Mathias Rasmussen wrote: > > How do I proceed? If there is no chance this is going to get merged, please let me know. I’m following the writing filters docs that recommends submitting the filter, but I would rather spend my time on a different solution if this is

Re: [FFmpeg-devel] [PATCH] [GSoC 1/6] avformat/abr: Adaptive Bitrate support

On Sun, 5 Jul 2020, Hongcheng Zhong wrote: From: spartazhc Add abr module for hls/dash. Signed-off-by: spartazhc --- doc/protocols.texi | 7 + libavformat/Makefile| 1 + libavformat/abr.c | 282 libavformat/protocols.c | 1 + 4 files

Re: [FFmpeg-devel] [PATCH v1 1/3] doc/developer.texi: Improvements in "Submitting patches" section.

On 2020-07-05 14:45, Manolis Stamatogiannakis wrote: The section has been expanded to outline how to manage patch revisions. --- doc/developer.texi | 37 ++--- 1 file changed, 26 insertions(+), 11 deletions(-) Thank you for taking the time to improve the

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/h26[45]_metadata_bsf: Use separate contexts for reading/writing

On 7/6/2020 6:52 PM, Mark Thompson wrote: > On 06/07/2020 01:53, Andreas Rheinhardt wrote: >> Currently, both bsfs used the same CodedBitstreamContext for reading and >> writing; as a consequence, the state of the writer's context at the >> beginning of writing a fragment is exactly the state of

Re: [FFmpeg-devel] [PATCH] libavutil/video_enc_params: add block type

On 06/07/2020 22:08, Yongle Lin wrote: add block type field to AVVideoBlockParams so we could either export or visualize it later. --- libavutil/video_enc_params.h | 20 1 file changed, 20 insertions(+) diff --git a/libavutil/video_enc_params.h

Re: [FFmpeg-devel] [PATCH v06 2/5] fbtile helperRoutines cpu based framebuffer detiling

On 06/07/2020 00:30, Lynne wrote: Jul 5, 2020, 23:47 by s...@jkqxz.net: On 04/07/2020 14:17, hanishkvc wrote: Add helper routines which can be used to detile tiled framebuffer layouts into a linear layout, using the cpu. Currently it supports Legacy Intel Tile-X, Legacy Intel Tile-Y and

[FFmpeg-devel] [PATCH] libavutil/video_enc_params: add block type

add block type field to AVVideoBlockParams so we could either export or visualize it later. --- libavutil/video_enc_params.h | 20 1 file changed, 20 insertions(+) diff --git a/libavutil/video_enc_params.h b/libavutil/video_enc_params.h index 43fa443154..55b9fc4031 100644

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/cbs: Remove unused function parameters

On 06/07/2020 01:53, Andreas Rheinhardt wrote: Several cbs-functions had an unused CodedBitstreamContext parameter. This commit removes these. Yeah, the intent was that every call would be attached to a single context for logging / debug stuff. That didn't end up getting any use, so it's

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/h26[45]_metadata_bsf: Use separate contexts for reading/writing

On 06/07/2020 01:53, Andreas Rheinhardt wrote: Currently, both bsfs used the same CodedBitstreamContext for reading and writing; as a consequence, the state of the writer's context at the beginning of writing a fragment is exactly the state of the reader after having read the fragment; in

Re: [FFmpeg-devel] [PATCH] avformat/isom: allow ISO 639 codes for mov

Hi Yongle, I hope you are doing well > On Jul 6, 2020, at 11:04 AM, Yongle Lin wrote: > > On Fri, Jun 19, 2020 at 5:11 PM Yongle Lin > wrote: > >> Allow ISO 639 language codes for text tracks in mov format when >> strictness is set to experimental >> --- >>

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/h26[45]_metadata_bsf: Use separate contexts for reading/writing

Mark Thompson: > On 06/07/2020 01:53, Andreas Rheinhardt wrote: >> Currently, both bsfs used the same CodedBitstreamContext for reading and >> writing; as a consequence, the state of the writer's context at the >> beginning of writing a fragment is exactly the state of the reader after >> having

Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_edgedetect: properly implement double_threshold()

On Mon, 06. Jul 16:02, Andriy Gelman wrote: > Hi Alex, > Thanks for testing. > > On Mon, 6 Jul 2020 at 14:49, Alexander Strasser wrote: > > > On 2020-07-04 23:19 -0400, Andriy Gelman wrote: > > > On Sun, 05. Jul 09:37, lance.lmw...@gmail.com wrote: > > > > On Sat, Jul 04, 2020 at 01:03:48PM

Re: [FFmpeg-devel] [FFmpeg-cvslog] swscale: Add swscale input/output support for X2RGB10LE

On Mon, 06. Jul 02:33, Wang, Fei W wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Michael Niedermayer > > Sent: Monday, July 6, 2020 7:47 AM > > To: ffmpeg-devel@ffmpeg.org > > Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] swscale: Add swscale > > input/output