[FFmpeg-devel] [PATCH 3/4] avfilter/vf_deshake: Remove unnecessary emms_c

2023-11-01 Thread Andreas Rheinhardt
Redundant since ea043cc53ed3506775ec6239ed5f8a20718b1098 (which made 16x16 no longer use MMX). Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_deshake.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavfilter/vf_deshake.c b/libavfilter/vf_deshake.c index d44dd71eb0..cb062dd11f

[FFmpeg-devel] [PATCH 4/4] avfilter/deshake: Merge header into its only user

2023-11-01 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/deshake.h| 83 libavfilter/vf_deshake.c | 55 +- 2 files changed, 54 insertions(+), 84 deletions(-) delete mode 100644 libavfilter/deshake.h diff --git a/libavfilter/deshake.h

[FFmpeg-devel] [PATCH 2/4] avfilter/vf_mpdecimate: Remove emms_c

2023-11-01 Thread Andreas Rheinhardt
Unnecessary now that the pixelutils API abides by the ABI. Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_mpdecimate.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/libavfilter/vf_mpdecimate.c b/libavfilter/vf_mpdecimate.c index baba1f183f..dab8941e46 100644 ---

[FFmpeg-devel] [PATCH 04/11] avfilter/vf_aspect: Deduplicate inputs

2023-11-01 Thread Andreas Rheinhardt
Also avoid using the avfilter-prefix for static objects. Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_aspect.c | 28 ++-- 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/libavfilter/vf_aspect.c b/libavfilter/vf_aspect.c index

[FFmpeg-devel] [PATCH 03/11] avfilter/f_graphmonitor: Deduplicate outputs

2023-11-01 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/f_graphmonitor.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/libavfilter/f_graphmonitor.c b/libavfilter/f_graphmonitor.c index ce4153fc79..d2c0ae81bf 100644 --- a/libavfilter/f_graphmonitor.c +++

[FFmpeg-devel] [PATCH 02/11] avfilter/f_drawgraph: Deduplicate outputs

2023-11-01 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/f_drawgraph.c | 25 - 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/libavfilter/f_drawgraph.c b/libavfilter/f_drawgraph.c index d29a7fb60a..d53598ee15 100644 --- a/libavfilter/f_drawgraph.c +++

[FFmpeg-devel] [PATCH 1/4] avutil/x86/pixelutils: Empty MMX state in ff_pixelutils_sad_8x8_mmxext

2023-11-01 Thread Andreas Rheinhardt
We currently mostly do not empty the MMX state in our MMX DSP functions; instead we only do so before code that might be using x87 code. This is a violation of the System V i386 ABI (and maybe of other ABIs, too): "The CPU shall be in x87 mode upon entry to a function. Therefore, every function

Re: [FFmpeg-devel] [PATCH 1/4] avutil/x86/pixelutils: Empty MMX state in ff_pixelutils_sad_8x8_mmxext

2023-11-01 Thread Andreas Rheinhardt
Henrik Gramner via ffmpeg-devel: > On Wed, Nov 1, 2023 at 10:44 AM Andreas Rheinhardt > wrote: >> libavutil/x86/pixelutils.asm | 1 + >> 1 file changed, 1 insertion(+) > > IIRC the emms instructions is quite slow on many systems, so if this > is the only pixelutils function using mmx it's

[FFmpeg-devel] [PATCH 10/11] avfilter/vsrc_testsrc: Deduplicate outputs

2023-11-01 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/vsrc_testsrc.c | 64 ++ 1 file changed, 16 insertions(+), 48 deletions(-) diff --git a/libavfilter/vsrc_testsrc.c b/libavfilter/vsrc_testsrc.c index 9081b55f1c..da17e950d8 100644 ---

[FFmpeg-devel] [PATCH 11/11] avfilter/vf_format: Deduplicate inputs

2023-11-01 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_format.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/libavfilter/vf_format.c b/libavfilter/vf_format.c index 04c265f59f..1189bd61c2 100644 --- a/libavfilter/vf_format.c +++ b/libavfilter/vf_format.c

[FFmpeg-devel] [PATCH 09/11] avfilter/vf_xmedian: Deduplicate outputs

2023-11-01 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_xmedian.c | 26 +- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/libavfilter/vf_xmedian.c b/libavfilter/vf_xmedian.c index 0a02ca065e..ebcbea97ed 100644 --- a/libavfilter/vf_xmedian.c +++

[FFmpeg-devel] [PATCH 05/11] avfilter/vf_blend: Deduplicate outputs

2023-11-01 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_blend.c | 26 +- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/libavfilter/vf_blend.c b/libavfilter/vf_blend.c index 7100d9f372..ecabb78e61 100644 --- a/libavfilter/vf_blend.c +++

[FFmpeg-devel] [PATCH 06/11] avfilter/vf_chromakey: Deduplicate inputs and outputs

2023-11-01 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_chromakey.c | 30 ++ 1 file changed, 6 insertions(+), 24 deletions(-) diff --git a/libavfilter/vf_chromakey.c b/libavfilter/vf_chromakey.c index c204a58328..9c0918bb4d 100644 --- a/libavfilter/vf_chromakey.c +++

[FFmpeg-devel] [PATCH 08/11] avfilter/vf_hsvkey: Deduplicate inputs and outputs

2023-11-01 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_hsvkey.c | 30 ++ 1 file changed, 6 insertions(+), 24 deletions(-) diff --git a/libavfilter/vf_hsvkey.c b/libavfilter/vf_hsvkey.c index 542ac1f3b2..0bd8cace37 100644 --- a/libavfilter/vf_hsvkey.c +++

[FFmpeg-devel] [PATCH 07/11] avfilter/vf_convolve: Deduplicate outputs

2023-11-01 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_convolve.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/libavfilter/vf_convolve.c b/libavfilter/vf_convolve.c index 324686..25dc92e988 100644 --- a/libavfilter/vf_convolve.c +++ b/libavfilter/vf_convolve.c @@

[FFmpeg-devel] [PATCH] fftools/ffmpeg_mux: keep write_header and write_packet in the same thread

2023-11-01 Thread angus . chen-at-intel . com
From: "Chen, Angus" sdl2_muxer(wayland): In ffmpeg6, we create a separate thread for muxer after calling avformat_write_header(). It may generate EGL_BAD_ACCESS when we call write_packet. This is because egl_context is bound to previous thread. >From EGL spec: If ctx is current to some other

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_mux_init: Restrict disabling automatic copying of metadata

2023-11-01 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Fixes ticket #10638 and restores the behaviour from before > 3c7dd5ed37da6d2de06c4850de5a319ca9cdd47f. > > Signed-off-by: Andreas Rheinhardt > --- > fftools/ffmpeg_mux_init.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git

[FFmpeg-devel] [PATCH 01/11] avcodec/aactab: Deduplicate swb_offset_960 tabs

2023-11-01 Thread Andreas Rheinhardt
swb_offset_960_48 and swb_offset_960_32 coincide. Signed-off-by: Andreas Rheinhardt --- libavcodec/aactab.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/libavcodec/aactab.c b/libavcodec/aactab.c index d20ac56a3f..63a478f33f 100644 --- a/libavcodec/aactab.c +++

Re: [FFmpeg-devel] [PATCH 1/4] avutil/x86/pixelutils: Empty MMX state in ff_pixelutils_sad_8x8_mmxext

2023-11-01 Thread Henrik Gramner via ffmpeg-devel
On Wed, Nov 1, 2023 at 10:44 AM Andreas Rheinhardt wrote: > libavutil/x86/pixelutils.asm | 1 + > 1 file changed, 1 insertion(+) IIRC the emms instructions is quite slow on many systems, so if this is the only pixelutils function using mmx it's probably better to just rewrite it to use SSE2

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_mux: keep write_header and write_packet in the same thread

2023-11-01 Thread Zhao Zhili
> On Nov 1, 2023, at 17:01, angus.chen-at-intel@ffmpeg.org wrote: > > From: "Chen, Angus" > > sdl2_muxer(wayland): > In ffmpeg6, we create a separate thread for muxer after calling > avformat_write_header(). > It may generate EGL_BAD_ACCESS when we call write_packet. This is because >

[FFmpeg-devel] [PATCH 1/1] lavc/libaribcaption: Fix mistake in document decoders.texi

2023-11-01 Thread zheng qian
Fix the mistake in the description of `-caption_encoding encoding_scheme` option. Signed-off-by: zheng qian --- doc/decoders.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/decoders.texi b/doc/decoders.texi index eb00e2a9e9..59279bde24 100644 ---

[FFmpeg-devel] [PATCH 0/1] Fix document mistake for lavc/libaribcaption

2023-11-01 Thread zheng qian
Hi, I'm fixing a mistake contained in the document for lavc/libaribcaption. This affects the 6.1 release so please also cheery-pick this patch to 6.1. zheng qian (1): lavc/libaribcaption: Fix mistake in document decoders.texi doc/decoders.texi | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [FFmpeg-devel] [PATCH 1/2] avutil/hwcontext_vulkan: add get_proc_addr option

2023-11-01 Thread Anton Khirnov
Quoting Zhao Zhili (2023-11-01 17:56:46) > From: Zhao Zhili > > It allows to pass SDL_Vulkan_GetVkGetInstanceProcAddr to hwcontext. > --- > libavutil/hwcontext_vulkan.c | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/libavutil/hwcontext_vulkan.c

Re: [FFmpeg-devel] [ANNOUNCE] upcoming GA vote

2023-11-01 Thread Michael Niedermayer
On Mon, Oct 30, 2023 at 11:50:26AM +0100, Jean-Baptiste Kempf wrote: > On Mon, 30 Oct 2023, at 11:33, Thilo Borgmann via ffmpeg-devel wrote: > > Am 30.10.23 um 09:18 schrieb Jean-Baptiste Kempf: > >> Hello, > >> > >> On Sun, 29 Oct 2023, at 10:33, Anton Khirnov wrote: > >>> vote question

[FFmpeg-devel] [PATCH 2/2] fftools/ffplay: pass SDL vulkan get_proc_addr to hwcontext

2023-11-01 Thread Zhao Zhili
From: Zhao Zhili --- Maybe this patch should be squashed into the patch which add ffplay_renderer. fftools/ffplay_renderer.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/fftools/ffplay_renderer.c b/fftools/ffplay_renderer.c index f25796133e..143c327287

[FFmpeg-devel] [PATCH 1/2] avutil/hwcontext_vulkan: add get_proc_addr option

2023-11-01 Thread Zhao Zhili
From: Zhao Zhili It allows to pass SDL_Vulkan_GetVkGetInstanceProcAddr to hwcontext. --- libavutil/hwcontext_vulkan.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c index 8481427b42..155fe37a33 100644 ---

Re: [FFmpeg-devel] [RFC] Release 6.1

2023-11-01 Thread Thilo Borgmann via ffmpeg-devel
Am 29.10.23 um 20:27 schrieb Jean-Baptiste Kempf: On Sun, 29 Oct 2023, at 19:46, Thilo Borgmann via ffmpeg-devel wrote: Am 29.10.23 um 18:56 schrieb Jean-Baptiste Kempf: On Sun, 29 Oct 2023, at 18:20, Thilo Borgmann via ffmpeg-devel wrote: In this case as well, I think you should have

Re: [FFmpeg-devel] [PATCH] avfillter/buffersrc: activate and EOF fix

2023-11-01 Thread Nicolas George
Paul B Mahol (12023-11-01): > It fixes it for me, ffmpeg no longer keeps sending frames to EOF > filtergraph. > And no more memory is allocated and never freed. And that is just LUCK because you changed unrelated things. You have to provide a PROOF, starting with what was wrong in the original

Re: [FFmpeg-devel] [PATCH] avfillter/buffersrc: activate and EOF fix

2023-11-01 Thread Nicolas George
Paul B Mahol (12023-10-31): > Huh? I fixed this, and you need to give proof that this does not fixes it. It is you wou have to prove that your patches fix anything or are in any way useful. > Because You can be mistaken and/or evil and simply lie. Seriously, get a grip. -- Nicolas George

Re: [FFmpeg-devel] [PATCH] avfillter/buffersrc: activate and EOF fix

2023-11-01 Thread Paul B Mahol
On Wed, Nov 1, 2023 at 2:58 PM Nicolas George wrote: > Paul B Mahol (12023-10-31): > > Huh? I fixed this, and you need to give proof that this does not fixes > it. > > It is you wou have to prove that your patches fix anything or are in any > way useful. > It fixes it for me, ffmpeg no longer

Re: [FFmpeg-devel] [PATCH] avfillter/buffersrc: activate and EOF fix

2023-11-01 Thread Nicolas George
James Almer (12023-11-01): > Can you be more specific? Do you not see the result Jan described? Do you > see something different? Or is it that you do see what he described, but > it's not a proper fix in your opinion as Paul's patch simply prevents the > leak from being triggered in his specific

Re: [FFmpeg-devel] [PATCH 1/1] lavc/libaribcaption: Fix mistake in document decoders.texi

2023-11-01 Thread Gyan Doshi
On 2023-11-01 08:33 pm, zheng qian wrote: Fix the mistake in the description of `-caption_encoding encoding_scheme` option. Signed-off-by: zheng qian --- doc/decoders.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/decoders.texi b/doc/decoders.texi index

Re: [FFmpeg-devel] [PATCH] avfillter/buffersrc: activate and EOF fix

2023-11-01 Thread Jan Ekström
On Tue, Oct 31, 2023 at 12:55 PM Nicolas George wrote: > > Paul B Mahol (12023-10-27): > > Both patches are required to fix out of memory scenario with this use case: > > I checked. The OOM still happens with these two patches => they do not > fix the issue => rejected. So for me I have the

Re: [FFmpeg-devel] [PATCH] avfillter/buffersrc: activate and EOF fix

2023-11-01 Thread Nicolas George
Jan Ekström (12023-11-01): > So my question is: Does this test case not improve for you after you > have applied these patches? Or are you speaking of a separate problem > which is bad both in master as well as after these patches have been > applied? This is the test case Paul posted yesterday

Re: [FFmpeg-devel] [PATCH] avfillter/buffersrc: activate and EOF fix

2023-11-01 Thread James Almer
On 11/1/2023 10:56 AM, Nicolas George wrote: Jan Ekström (12023-11-01): So my question is: Does this test case not improve for you after you have applied these patches? Or are you speaking of a separate problem which is bad both in master as well as after these patches have been applied? This

[FFmpeg-devel] [PATCH v2] lavc/libaribcaption: Fix mistake in document decoders.texi

2023-11-01 Thread zheng qian
Fix the mistake in the description of `-caption_encoding encoding_scheme` option. Signed-off-by: zheng qian --- doc/decoders.texi | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/doc/decoders.texi b/doc/decoders.texi index eb00e2a9e9..f75364166e 100644 ---

[FFmpeg-devel] [PATCH] lavc/sbrdsp: R-V V sbr_hf_g_filt

2023-11-01 Thread Rémi Denis-Courmont
hf_g_filt_c: 1552.5 hf_g_filt_rvv_f32: 679.5 --- libavcodec/riscv/sbrdsp_init.c | 3 +++ libavcodec/riscv/sbrdsp_rvv.S | 20 2 files changed, 23 insertions(+) diff --git a/libavcodec/riscv/sbrdsp_init.c b/libavcodec/riscv/sbrdsp_init.c index 1b85b2cae9..71de681185

Re: [FFmpeg-devel] FFmpeg at NAB 2024

2023-11-01 Thread Kieran Kunhya
On Wed, 1 Nov 2023 at 20:37, Thilo Borgmann via ffmpeg-devel < ffmpeg-devel@ffmpeg.org> wrote: > Hi, > > FFmpeg will have a booth at the next NAB from April 14th to 17th 2024 in > Las > Vegas [1]! > > We reiceived an anonymous corporate sponsorship for the booth, so there > are no > costs for the

Re: [FFmpeg-devel] FFmpeg at NAB 2024

2023-11-01 Thread Derek Buitenhuis
On 11/1/2023 8:37 PM, Thilo Borgmann via ffmpeg-devel wrote: > We reiceived an anonymous corporate sponsorship for the booth, so there are > no > costs for the FFmpeg project to it (and no obligations, of course). This is certainly interesting considering we just had a giant thread about not

[FFmpeg-devel] [PATCH] lavc/pixblockdsp: rework R-V V get_pixels_unaligned

2023-11-01 Thread Rémi Denis-Courmont
As in the aligned case, we can use VLSE64.V, though the way of doing so gets more convoluted, so the performance gains are more modest: get_pixels_unaligned_c: 126.7 get_pixels_unaligned_rvv_i32: 145.5 (before) get_pixels_unaligned_rvv_i64: 62.2 (after) For the reference, those are the

Re: [FFmpeg-devel] [ANNOUNCE] upcoming GA vote

2023-11-01 Thread Jean-Baptiste Kempf
Hey, On Wed, 1 Nov 2023, at 18:19, Michael Niedermayer wrote: > Please provide the list of email addresses OR peoples names who > should have received a mail for voting I don't think listing emails on this mailing list is a good idea, or even legal (GDPR, for example). And the old lists (+ the

Re: [FFmpeg-devel] [PATCH v2] lavc/libaribcaption: Fix mistake in document decoders.texi

2023-11-01 Thread Gyan Doshi
On 2023-11-01 08:54 pm, zheng qian wrote: Fix the mistake in the description of `-caption_encoding encoding_scheme` option. Will fix commit message and push. Thanks, Gyan Signed-off-by: zheng qian --- doc/decoders.texi | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff

[FFmpeg-devel] FFmpeg at NAB 2024

2023-11-01 Thread Thilo Borgmann via ffmpeg-devel
Hi, FFmpeg will have a booth at the next NAB from April 14th to 17th 2024 in Las Vegas [1]! We reiceived an anonymous corporate sponsorship for the booth, so there are no costs for the FFmpeg project to it (and no obligations, of course). Any FFmpeg developer is welcome to join in and man

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_mux: keep write_header and write_packet in the same thread

2023-11-01 Thread Michael Niedermayer
On Wed, Nov 01, 2023 at 05:01:15PM +0800, angus.chen-at-intel@ffmpeg.org wrote: > From: "Chen, Angus" > > sdl2_muxer(wayland): > In ffmpeg6, we create a separate thread for muxer after calling > avformat_write_header(). > It may generate EGL_BAD_ACCESS when we call write_packet. This is

Re: [FFmpeg-devel] [ANNOUNCE] upcoming GA vote

2023-11-01 Thread Gerion Entrup via ffmpeg-devel
Am Mittwoch, 1. November 2023, 23:07:16 CET schrieb Jean-Baptiste Kempf: > Hey, > > On Wed, 1 Nov 2023, at 18:19, Michael Niedermayer wrote: > > Please provide the list of email addresses OR peoples names who > > should have received a mail for voting > > I don't think listing emails on this

Re: [FFmpeg-devel] [PATCH 1/2] avutil/hwcontext_vulkan: add get_proc_addr option

2023-11-01 Thread Zhao Zhili
> 在 2023年11月2日,上午2:12,Anton Khirnov 写道: > > Quoting Zhao Zhili (2023-11-01 17:56:46) >> From: Zhao Zhili >> >> It allows to pass SDL_Vulkan_GetVkGetInstanceProcAddr to hwcontext. >> --- >> libavutil/hwcontext_vulkan.c | 14 ++ >> 1 file changed, 14 insertions(+) >> >> diff --git

[FFmpeg-devel] [PATCH] mailmap: remap my email accounts

2023-11-01 Thread Zhao Zhili
From: Zhao Zhili Signed-off-by: Zhao Zhili --- .mailmap | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.mailmap b/.mailmap index af60290f77..7546cf0caf 100644 --- a/.mailmap +++ b/.mailmap @@ -1,8 +1,8 @@ - - + + -- 2.34.1

[FFmpeg-devel] Separate stream for subtitles in HLS?

2023-11-01 Thread David Johansen
Currently, I have to put the subtitles on the video stream and when I make the subtitles their own stream, I get this error: No streams to mux were specified Would it be possible to have the subtitles as their own stream or is too engrained of an assumption that there's an output stream tied to