Re: [FFmpeg-devel] [PATCH 1/2] Replace FFMIN/FFMAX by type specific macros

2025-06-07 Thread Marton Balint
On Sun, 8 Jun 2025, Michael Niedermayer wrote: Hi On Wed, Jun 04, 2025 at 03:05:12AM +0200, Michael Niedermayer wrote: [...] #define FFSWAP(type,a,b) do{type SWAP_tmp= b; b= a; a= SWAP_tmp;}while(0) 1. I don't like that you change the common case (namely the integer one) and thereby maki

[FFmpeg-devel] [PATCH v2] rtpdec: Fix RTP timestamp wraparound in Producer Reference Time

2025-06-07 Thread Clément Péron
The rtp_set_prft() function incorrectly calculates the timestamp delta when RTP timestamps wrap around the 32-bit boundary. The current code: delta_timestamp = (int64_t)timestamp - (int64_t)s->last_rtcp_timestamp; treats both timestamps as large positive values, causing wraparound to produce

Re: [FFmpeg-devel] [PATCH] avformat/tls_openssl: fix warnings when openssl is lower version

2025-06-07 Thread Steven Liu
Jack Lau via ffmpeg-devel 于2025年6月7日周六 09:35写道: > > In higher versions (like openssl 1.1.1 and higher), > the function signature is BIO *BIO_new_mem_buf(const void *buf, int len), > so passing a const string doesn't cause an warnings. > However, in lower versions of OpenSSL, > the function signatu

[FFmpeg-devel] [PATCH 1/2] wasm/hevc: Add sao_band_filter

2025-06-07 Thread Zhao Zhili
From: Zhao Zhili hevc_sao_band_8_8_c:63.0 ( 1.00x) hevc_sao_band_8_8_simd128: 10.4 ( 6.06x) hevc_sao_band_16_8_c: 230.4 ( 1.00x) hevc_sao_band_16_8_simd128: 22.9 (10.07x)

[FFmpeg-devel] [PATCH 2/2] wasm/hevc: Add sao_edge_filter

2025-06-07 Thread Zhao Zhili
From: Zhao Zhili hevc_sao_edge_8_8_c: 124.5 ( 1.00x) hevc_sao_edge_8_8_simd128: 18.1 ( 6.89x) hevc_sao_edge_16_8_c: 478.6 ( 1.00x) hevc_sao_edge_16_8_simd128: 48.9 ( 9.79x)

Re: [FFmpeg-devel] [PATCH v3 2/2] MAINTAINERS: Add myself as vvc maintainer

2025-06-07 Thread Nuo Mi
On Wed, Jun 4, 2025 at 9:12 AM Michael Niedermayer wrote: > On Mon, Jun 02, 2025 at 09:47:56AM +0800, Nuo Mi wrote: > > From: Frank Plowman > > > > My OpenPGP key is available at > > > > > https://keys.openpgp.org/vks/v1/by-fingerprint/34E248D6B7DF476970C7330403A84C6A098F2C6B > > > > and > > > >

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Fix unchecked return code and shadowing

2025-06-07 Thread Nuo Mi
On Mon, Jun 2, 2025 at 9:08 PM Nuo Mi wrote: > > > On Sun, Jun 1, 2025 at 4:59 AM Frank Plowman > wrote: > >> Signed-off-by: Frank Plowman >> --- >> libavcodec/vvc/dec.c | 8 ++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/libavcodec/vvc/dec.c b/libavcodec/vvc/de

[FFmpeg-devel] [PATCH] avcodec/libx264: Remove unnecessary include

2025-06-07 Thread Zhao Zhili
From: Zhao Zhili eval is for av_strtod, which wasn't been used by libx264 now. --- libavcodec/libx264.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index d7f8683b09..58c03a77ad 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -2

Re: [FFmpeg-devel] [PATCH v2] avformat/tls_openssl: fix build error when openssl version < 3

2025-06-07 Thread Michael Niedermayer
On Fri, Jun 06, 2025 at 11:32:24AM +0300, Martin Storsjö wrote: > On Fri, 6 Jun 2025, Jack Lau via ffmpeg-devel wrote: > > > add the missing data structure pkey in the tls_context > > properly set this pkey and free it > > > > Signed-off-by: Jack Lau > > --- > > libavformat/tls_openssl.c | 33 ++

Re: [FFmpeg-devel] [PATCH v2 2/4] tools/target_dec_fuzzer: suppress Wunused-function

2025-06-07 Thread Michael Niedermayer
On Fri, Jun 06, 2025 at 07:20:33PM +0200, Kacper Michajłow wrote: > Signed-off-by: Kacper Michajłow > --- > tools/target_dec_fuzzer.c | 3 +++ > 1 file changed, 3 insertions(+) will apply patches 2-4 thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB "Nothin

Re: [FFmpeg-devel] [PATCH v2 1/4] tools/target_dec_fuzzer: move things to suppress Wdeclaration-after-statement

2025-06-07 Thread Kacper Michajlow
On Fri, 6 Jun 2025 at 23:49, Michael Niedermayer wrote: > > Hi Kacper > > On Fri, Jun 06, 2025 at 07:20:32PM +0200, Kacper Michajłow wrote: > > To avoid spam in log, each fuzzer is built separately so it's amplified > > a lot. > > > > Signed-off-by: Kacper Michajłow > > --- > > tools/target_dec_

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Support pps_mixed_nalu_types_in_pic_flag

2025-06-07 Thread Nuo Mi
On Sun, Jun 1, 2025 at 9:45 PM Frank Plowman wrote: > Add support for the pps_mixed_nalu_types_in_pic_flag, which permits > using different NALU types for different VCL NAL units of a single > picture. > > Fixes decoding of the only two Main 10 conformance bitstreams which > could not previously

Re: [FFmpeg-devel] [RFC] Subtitle Filtering Ramp-Up

2025-06-07 Thread softworkz .
It's MythBusters Day! = Today: Busting the Lies of Nicolas George > -Original Message- > From: ffmpeg-devel On Behalf Of > Nicolas George > > [...] > > When I say that softworkz's approach is broken, I know what I am > talking about. Oh wow, that sounds impres

Re: [FFmpeg-devel] [PATCH] avformat/dhav: Do not evaluate avio_size() multiple times

2025-06-07 Thread Derek Buitenhuis
On 6/7/2025 12:12 AM, Michael Niedermayer wrote: > Code like FFMIN(MAX_DURATION_BUFFER_SIZE, avio_size(s->pb)) is not safe > as FFMIN() is a macro and avio_size() is thus evaluated multiple > times > > CC: Justin Ruggles > Signed-off-by: Michael Niedermayer > --- > libavformat/dhav.c | 7 --

Re: [FFmpeg-devel] [PATCH] add yuv444p support to mcdeint

2025-06-07 Thread Ethan Halsall
Hi Michael, Apologies for the late response, I missed this message. On 6/2/25 1:39 PM, Michael Niedermayer wrote: > Hi Ethan > > On Fri, May 30, 2025 at 12:29:19AM -0500, Ethan Halsall wrote: >> On 5/29/25 7:58 PM, Michael Niedermayer wrote: >>> On Tue, May 27, 2025 at 01:24:57PM -0500, Ethan Ha

Re: [FFmpeg-devel] [RFC] Subtitle Filtering Ramp-Up

2025-06-07 Thread Kieran Kunhya via ffmpeg-devel
On Sat, Jun 7, 2025 at 5:20 PM softworkz . wrote: > > > It's MythBusters Day! > = > > > Today: Busting the Lies of Nicolas George Can you stop spamming this list with your rants and get a blog or something? Kieran ___ ffmpeg-devel m

Re: [FFmpeg-devel] [RFC] Subtitle Filtering Ramp-Up

2025-06-07 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Kieran Kunhya via ffmpeg-devel > Sent: Samstag, 7. Juni 2025 19:25 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: Kieran Kunhya > Subject: Re: [FFmpeg-devel] [RFC] Subtitle Filtering Ramp-Up > > On Sat,

Re: [FFmpeg-devel] [PATCH] avformat/dhav: Do not evaluate avio_size() multiple times

2025-06-07 Thread Michael Niedermayer
On Sat, Jun 07, 2025 at 05:23:26PM +0100, Derek Buitenhuis wrote: > On 6/7/2025 12:12 AM, Michael Niedermayer wrote: > > Code like FFMIN(MAX_DURATION_BUFFER_SIZE, avio_size(s->pb)) is not safe > > as FFMIN() is a macro and avio_size() is thus evaluated multiple > > times > > > > CC: Justin Ruggles

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: List types and checksums for for side data

2025-06-07 Thread Michael Niedermayer
On Sun, May 18, 2025 at 09:51:16PM +0200, Michael Niedermayer wrote: > Hi > > On Sun, May 18, 2025 at 04:43:01PM +0200, Andreas Rheinhardt wrote: > > Michael Niedermayer: > > > This allows detecting changes and regressions in side data related code, > > > same as what > > > framecrc does for befo

Re: [FFmpeg-devel] [PATCH] avformat/tls_openssl: fix warnings when openssl is lower version

2025-06-07 Thread Andreas Rheinhardt
Jack Lau via ffmpeg-devel: > In higher versions (like openssl 1.1.1 and higher), > the function signature is BIO *BIO_new_mem_buf(const void *buf, int len), > so passing a const string doesn't cause an warnings. > However, in lower versions of OpenSSL, > the function signature becomes BIO *BIO_new_

[FFmpeg-devel] [PATCH 1/6] avfilter/vf_overlay: Don't perform UB pointer arithmetic

2025-06-07 Thread Andreas Rheinhardt
Patches attached. - Andreas From 9de09c4db6c914eeec505d4365850fda3bf86b8d Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Wed, 4 Jun 2025 03:20:02 +0200 Subject: [PATCH 1/6] avfilter/vf_overlay: Don't perform UB pointer arithmetic This happens when the pixel format of the output does not

[FFmpeg-devel] [PATCH 2/7] avutil/frame: add a 3D Reference Displays Information side data type

2025-06-07 Thread Timo Rothenpieler
From: James Almer Signed-off-by: James Almer --- libavutil/frame.h | 11 +++ libavutil/side_data.c | 1 + 2 files changed, 12 insertions(+) diff --git a/libavutil/frame.h b/libavutil/frame.h index 8493233ba2..c50cd263d9 100644 --- a/libavutil/frame.h +++ b/libavutil/frame.h @@ -24

[FFmpeg-devel] [PATCH 3/7] avcodec/packet: add a 3D Reference Displays Information side data type

2025-06-07 Thread Timo Rothenpieler
From: James Almer Signed-off-by: James Almer --- libavcodec/avcodec.c | 1 + libavcodec/packet.c | 1 + libavcodec/packet.h | 11 +++ 3 files changed, 13 insertions(+) diff --git a/libavcodec/avcodec.c b/libavcodec/avcodec.c index 7bcb0295e5..03c3d09b87 100644 --- a/libavcodec/avco

[FFmpeg-devel] [PATCH 4/7] avformat/dump: add support for 3D Reference Displays Information side data

2025-06-07 Thread Timo Rothenpieler
From: James Almer Signed-off-by: James Almer --- libavformat/dump.c | 13 + 1 file changed, 13 insertions(+) diff --git a/libavformat/dump.c b/libavformat/dump.c index c263921b99..49506455d3 100644 --- a/libavformat/dump.c +++ b/libavformat/dump.c @@ -37,6 +37,7 @@ #include "libav

[FFmpeg-devel] [PATCH 5/7] avfilter/vf_showinfo: add support for 3D Reference Displays Information side data

2025-06-07 Thread Timo Rothenpieler
From: James Almer Signed-off-by: James Almer --- libavfilter/vf_showinfo.c | 12 1 file changed, 12 insertions(+) diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c index 8109ca7fce..c706d00c96 100644 --- a/libavfilter/vf_showinfo.c +++ b/libavfilter/vf_showinfo.c

[FFmpeg-devel] [PATCH 6/7] avcodec/hevc/hevcdec: export 3D Reference Displays side data

2025-06-07 Thread Timo Rothenpieler
From: James Almer Signed-off-by: James Almer --- libavcodec/hevc/hevcdec.c | 52 ++- 1 file changed, 51 insertions(+), 1 deletion(-) diff --git a/libavcodec/hevc/hevcdec.c b/libavcodec/hevc/hevcdec.c index 636df5a4e9..797c9c76c9 100644 --- a/libavcodec/hevc/

[FFmpeg-devel] [PATCH 7/7] avcodec/nvenc: add MV-HEVC encoding support

2025-06-07 Thread Timo Rothenpieler
From: Diego de Souza Added support for MV-HEVC encoding for stereoscopic videos (2 views only). Compatible with the framepack filter when using the AV_STEREO3D_FRAMESEQUENCE format. Signed-off-by: Diego de Souza --- libavcodec/nvenc.c | 102 libavc

[FFmpeg-devel] [PATCH 1/7] avutil: add an API to handle 3D Reference Displays Information

2025-06-07 Thread Timo Rothenpieler
From: James Almer As defined in section G.14.3.2.3 of ITU-T H.265, it's required for proper signaling of MV-HEVC. Signed-off-by: James Almer --- libavutil/Makefile | 2 + libavutil/tdrdi.c | 51 ++ libavutil/tdrdi.h | 164 + 3 files

[FFmpeg-devel] [PATCH 1/3] avformat/dhav: Fix check for seekability

2025-06-07 Thread Andreas Rheinhardt
Patches attached. - Andreas From 95e88893123bae89991bf45a6c5db0173e158574 Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Sun, 8 Jun 2025 00:52:46 +0200 Subject: [PATCH 1/3] avformat/dhav: Fix check for seekability AVIOContext.seekable is a bitfield. Also check for seekability earlier.

Re: [FFmpeg-devel] [PATCH] add yuv444p support to mcdeint

2025-06-07 Thread Michael Niedermayer
Hi Ethan On Sat, Jun 07, 2025 at 12:15:06PM -0500, Ethan Halsall wrote: > Hi Michael, [...] > @@ -201,8 +203,14 @@ static int filter_frame(AVFilterLink *inlink, AVFrame > *inpic) > > for (i = 0; i < 3; i++) { > int is_chroma = !!i; > -int w = AV_CEIL_RSHIFT(inlink->w, is_c

Re: [FFmpeg-devel] [PATCH 1/2] Replace FFMIN/FFMAX by type specific macros

2025-06-07 Thread Michael Niedermayer
Hi On Wed, Jun 04, 2025 at 03:05:12AM +0200, Michael Niedermayer wrote: [...] > > > #define FFSWAP(type,a,b) do{type SWAP_tmp= b; b= a; a= SWAP_tmp;}while(0) > > > > 1. I don't like that you change the common case (namely the integer one) > > and thereby making the name longer (and making this p

Re: [FFmpeg-devel] [PATCH v2] rtpdec: Fix RTP timestamp wraparound in Producer Reference Time

2025-06-07 Thread Michael Niedermayer
Hi On Sat, Jun 07, 2025 at 10:06:19AM +0200, Clément Péron wrote: > The rtp_set_prft() function incorrectly calculates the timestamp delta > when RTP timestamps wrap around the 32-bit boundary. The current code: > > delta_timestamp = (int64_t)timestamp - (int64_t)s->last_rtcp_timestamp; > >

Re: [FFmpeg-devel] [PATCH 1/2] Replace FFMIN/FFMAX by type specific macros

2025-06-07 Thread Andreas Rheinhardt
Michael Niedermayer: > Hi > > On Wed, Jun 04, 2025 at 03:05:12AM +0200, Michael Niedermayer wrote: > [...] #define FFSWAP(type,a,b) do{type SWAP_tmp= b; b= a; a= SWAP_tmp;}while(0) >>> >>> 1. I don't like that you change the common case (namely the integer one) >>> and thereby making the nam

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/ac3_parser: use a padded buffer in av_ac3_parse_header()

2025-06-07 Thread James Almer
On 6/5/2025 9:14 PM, James Almer wrote: The GetBitContext API requires the buffer to be padded, and the documentation for av_ac3_parse_header() does not specify it, so use a temporary local buffer. Signed-off-by: James Almer --- libavcodec/ac3_parser.c | 16 +--- 1 file changed,

[FFmpeg-devel] [PATCH v2] avformat/tls_openssl: fix warnings when openssl is lower version

2025-06-07 Thread Jack Lau via ffmpeg-devel
api doc: https://docs.openssl.org/1.0.2/man3/BIO_s_mem In higher versions (openssl 1.0.2 and higher), the function signature is BIO *BIO_new_mem_buf(const void *buf, int len), so passing a const string doesn't cause an warnings. However, in lower versions of OpenSSL, the function signature becomes

Re: [FFmpeg-devel] [PATCH v2] avformat/format: make experimental flag works for muxer

2025-06-07 Thread Jack Lau
> On Jun 6, 2025, at 12:44, Zhao Zhili > wrote: > > From: Zhao Zhili > > --- > libavformat/avformat.h | 3 +-- > libavformat/format.c | 2 ++ > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libavformat/avformat.h b/libavformat/avformat.h > index 2034d2aecc..441e31bc2f 10

[FFmpeg-devel] [PATCH] avformat/format: fix muxer experimental check is always false

2025-06-07 Thread Jack Lau via ffmpeg-devel
if muxer has a name, !short_name is always false Signed-off-by: Jack Lau --- libavformat/format.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/format.c b/libavformat/format.c index 516925e7e4..ad8c17b6d7 100644 --- a/libavformat/format.c +++ b/libavformat/forma

Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: List types and checksums for for side data

2025-06-07 Thread James Almer
On 5/18/2025 6:23 PM, Michael Niedermayer wrote: On Sun, May 18, 2025 at 11:43:14AM -0300, James Almer wrote: On 5/18/2025 9:25 AM, Michael Niedermayer wrote: This allows detecting changes and regressions in side data related code, same as what framecrc does for before already for packet data

Re: [FFmpeg-devel] [PATCH] add yuv444p support to mcdeint

2025-06-07 Thread Ethan Halsall
Hi Michael, On 6/7/25 6:25 PM, Michael Niedermayer wrote: > Hi Ethan > > On Sat, Jun 07, 2025 at 12:15:06PM -0500, Ethan Halsall wrote: >> Hi Michael, > [...] >> @@ -201,8 +203,14 @@ static int filter_frame(AVFilterLink *inlink, AVFrame >> *inpic) >> >> for (i = 0; i < 3; i++) { >>