Re: [FFmpeg-devel] [PATCH 2/4] avcodec/samidec: use ff_htmlmarkup_to_ass()

2015-08-08 Thread Yayoi Ukai
On Sat, Aug 8, 2015 at 8:23 AM, Clément Bœsch wrote: > On Fri, Aug 07, 2015 at 11:03:29PM -0700, Yayoi wrote: >> --- >> libavcodec/samidec.c| 59 >> + >> tests/ref/fate/sub-sami | 18 +++ >> 2 files changed, 44 insertions(+), 33 del

Re: [FFmpeg-devel] [PATCH] avcodec/vc1dec: Re-order init to avoid initting hwaccel too early

2015-08-08 Thread Philip Langdale
On Sun, 9 Aug 2015 03:56:08 +0200 Michael Niedermayer wrote: > > > +ff_vc1_decode_end(avctx); > > this will dealocate sprite_output_frame and crash when its used later Thanks. Sending updated patch. --phil ___ ffmpeg-devel mailing list ffmpeg-de

[FFmpeg-devel] [PATCH] avcodec/vc1dec: Re-order init to avoid initting hwaccel too early

2015-08-08 Thread Philip Langdale
At least for vdpau, the hwaccel init code tries to check the video profile and ensure that there is a matching vdpau profile available. If it can't find a match, it will fail to initialise. In the case of wmv3/vc1, I observed initialisation to fail all the time. It turns out that this is due to t

Re: [FFmpeg-devel] [libav-devel] [PATCH 2/6] avutil: remove av_reverse deprecation

2015-08-08 Thread Michael Niedermayer
On Sat, Aug 08, 2015 at 09:38:39PM +0200, Andreas Cadhalpun wrote: > On 08.08.2015 18:40, Martin Storsjö wrote: > > As Hendrik said, public data symbols are problematic from a portability > > point of view > > (they behave differently than public functions in DLLs and require jumping > > through

Re: [FFmpeg-devel] [PATCH 4/6] avcodec: delay removal of avcodec_*_frame

2015-08-08 Thread Michael Niedermayer
On Sat, Aug 08, 2015 at 01:37:08PM +0200, Andreas Cadhalpun wrote: > They are still widely used and have been deprecated for less than two years. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/avcodec.h | 2 +- > libavcodec/utils.c | 2 +- > libavcodec/version.h | 3 +++ > 3 files cha

Re: [FFmpeg-devel] [PATCH 3/6] avutil: delay removal of the PIX_FMT_* flags

2015-08-08 Thread Michael Niedermayer
On Sat, Aug 08, 2015 at 01:36:58PM +0200, Andreas Cadhalpun wrote: > Only the PixelFormat removal is not delayed, because it is a very generic > name. > > Signed-off-by: Andreas Cadhalpun > --- > libavutil/pixfmt.h | 4 +++- > libavutil/version.h | 5 - > 2 files changed, 7 insertions(+),

Re: [FFmpeg-devel] [PATCH 02/13] avfilter: add missing FF_API_AVFILTERPAD_PUBLIC guard

2015-08-08 Thread Michael Niedermayer
On Sat, Aug 08, 2015 at 01:31:51PM +0200, Andreas Cadhalpun wrote: > Signed-off-by: Andreas Cadhalpun > --- > libavfilter/avfilter.c | 2 ++ > 1 file changed, 2 insertions(+) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Rewriting code that is poor

Re: [FFmpeg-devel] [PATCH] avcodec/vc1dec: Re-order init to avoid initting hwaccel too early

2015-08-08 Thread Michael Niedermayer
On Sat, Aug 08, 2015 at 03:03:27PM -0700, Philip Langdale wrote: > At least for vdpau, the hwaccel init code tries to check the video > profile and ensure that there is a matching vdpau profile available. > > If it can't find a match, it will fail to initialise. > > In the case of wmv3/vc1, I obs

Re: [FFmpeg-devel] [PATCH 2/2] ffplay: increase MIN_FRAMES to 25

2015-08-08 Thread Michael Niedermayer
On Sat, Aug 08, 2015 at 10:07:00PM +0200, Marton Balint wrote: > FFplay was using a 5 frame packet buffer, this is not much (e.g. 200 ms for > 25fps video), when HLS is requesting a new segment via HTTP, it may take > longer > for the request to complete. > > Should fix ticket #4720. > > Signed-

Re: [FFmpeg-devel] [PATCH 2/2] mmaldec: restore extradata destroyed by bitstream filter

2015-08-08 Thread Michael Niedermayer
On Sat, Aug 08, 2015 at 07:39:25PM +0200, wm4 wrote: > This matters because avformat_find_stream_info() can open this decoder > under certain circumstances. It will not create a copy of the context, > and all changes done to AVCodecContext must be undone on closing. > --- > Shitty avformat_find_str

[FFmpeg-devel] [PATCH 3/3] lavf/ftp: implement NLST method

2015-08-08 Thread Mariusz Szczepańczyk
--- libavformat/ftp.c | 98 +++ 1 file changed, 84 insertions(+), 14 deletions(-) diff --git a/libavformat/ftp.c b/libavformat/ftp.c index 542cf6a..5a312b9 100644 --- a/libavformat/ftp.c +++ b/libavformat/ftp.c @@ -38,6 +38,12 @@ typedef enum {

[FFmpeg-devel] [PATCH 1/3] lavf/ftp: implement directory listing callbacks

2015-08-08 Thread Mariusz Szczepańczyk
From: Lukasz Marek Signed-off-by: Lukasz Marek --- libavformat/ftp.c | 193 ++ 1 file changed, 182 insertions(+), 11 deletions(-) diff --git a/libavformat/ftp.c b/libavformat/ftp.c index 27a172e..c92ed11 100644 --- a/libavformat/ftp.c +++ b/l

[FFmpeg-devel] [PATCH 2/3] lavf/ftp: properly read an empty path

2015-08-08 Thread Mariusz Szczepańczyk
--- libavformat/ftp.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/libavformat/ftp.c b/libavformat/ftp.c index c92ed11..542cf6a 100644 --- a/libavformat/ftp.c +++ b/libavformat/ftp.c @@ -354,10 +354,7 @@ static int ftp_current_dir(FTPContext *s) if (

[FFmpeg-devel] [PATCH 0/3] [GSoC] Browsing content on server - FTP callbacks

2015-08-08 Thread Mariusz Szczepańczyk
Lukasz Marek (1): lavf/ftp: implement directory listing callbacks Mariusz Szczepańczyk (2): lavf/ftp: properly read an empty path lavf/ftp: implement NLST method libavformat/ftp.c | 283 +- 1 file changed, 261 insertions(+), 22 deletions(

Re: [FFmpeg-devel] [PATCH 10/13] ffmpeg: replace deprecated av_log_ask_for_sample with av_log

2015-08-08 Thread Michael Niedermayer
On Sat, Aug 08, 2015 at 09:55:03PM +0200, Andreas Cadhalpun wrote: > On 08.08.2015 18:01, Hendrik Leppkes wrote: > > On Sat, Aug 8, 2015 at 5:55 PM, Michael Niedermayer > > wrote: > >> On Sat, Aug 08, 2015 at 01:32:56PM +0200, Andreas Cadhalpun wrote: > >> iam not objecting to the change but > >>

[FFmpeg-devel] [PATCH] avcodec/vc1dec: Re-order init to avoid initting hwaccel too early

2015-08-08 Thread Philip Langdale
At least for vdpau, the hwaccel init code tries to check the video profile and ensure that there is a matching vdpau profile available. If it can't find a match, it will fail to initialise. In the case of wmv3/vc1, I observed initialisation to fail all the time. It turns out that this is due to t

[FFmpeg-devel] [PATCH 2/2] ffplay: increase MIN_FRAMES to 25

2015-08-08 Thread Marton Balint
FFplay was using a 5 frame packet buffer, this is not much (e.g. 200 ms for 25fps video), when HLS is requesting a new segment via HTTP, it may take longer for the request to complete. Should fix ticket #4720. Signed-off-by: Marton Balint --- ffplay.c | 2 +- 1 file changed, 1 insertion(+), 1 d

[FFmpeg-devel] [PATCH 1/2] ffplay: add specific constants for buffer fullness settings when using external clock

2015-08-08 Thread Marton Balint
Signed-off-by: Marton Balint --- ffplay.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/ffplay.c b/ffplay.c index 7e673f0..6f28694 100644 --- a/ffplay.c +++ b/ffplay.c @@ -67,6 +67,8 @@ const int program_birth_year = 2003; #define MAX_QUEUE_SIZE (15 * 1024 * 10

Re: [FFmpeg-devel] [PATCH 08/13] graphdump: include internal.h for AVFilterPad

2015-08-08 Thread Andreas Cadhalpun
On 08.08.2015 17:48, Michael Niedermayer wrote: > On Sat, Aug 08, 2015 at 01:32:40PM +0200, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> libavfilter/graphdump.c | 1 + >> 1 file changed, 1 insertion(+) > > LGTM Pushed. Best regards, Andreas __

Re: [FFmpeg-devel] [PATCH 07/13] use avfilter_pad_get_{type, name} accessor functions

2015-08-08 Thread Andreas Cadhalpun
On 08.08.2015 18:25, Michael Niedermayer wrote: > On Sat, Aug 08, 2015 at 01:32:31PM +0200, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> cmdutils.c | 4 ++-- >> libavdevice/lavfi.c | 2 +- >> 2 files changed, 3 insertions(+), 3 deletions(-) > > LGTM Pushed. B

Re: [FFmpeg-devel] [PATCH 05/13] avfilter: remove obsolete function declarations

2015-08-08 Thread Andreas Cadhalpun
On 08.08.2015 17:56, Michael Niedermayer wrote: > On Sat, Aug 08, 2015 at 01:32:14PM +0200, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> libavfilter/audio.h| 20 >> libavfilter/avfilter.c | 1 - >> libavfilter/internal.h | 6 -- >> 3 files

Re: [FFmpeg-devel] [PATCH 01/13] avcodec: add missing FF_API_CODEC_ID guard

2015-08-08 Thread Andreas Cadhalpun
On 08.08.2015 17:45, Michael Niedermayer wrote: > On Sat, Aug 08, 2015 at 01:31:45PM +0200, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> libavcodec/utils.c | 2 ++ >> 1 file changed, 2 insertions(+) > > LGTM Pushed. Best regards, Andreas _

Re: [FFmpeg-devel] [PATCH 10/13] ffmpeg: replace deprecated av_log_ask_for_sample with av_log

2015-08-08 Thread Andreas Cadhalpun
On 08.08.2015 18:01, Hendrik Leppkes wrote: > On Sat, Aug 8, 2015 at 5:55 PM, Michael Niedermayer > wrote: >> On Sat, Aug 08, 2015 at 01:32:56PM +0200, Andreas Cadhalpun wrote: >> iam not objecting to the change but >> wouldnt it make sense for ffmpeg/ffplay/ffserver and other tools >> to be able

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/strdec: factor out HTML parsing code

2015-08-08 Thread Yayoi Ukai
On Sat, Aug 8, 2015 at 8:17 AM, Clément Bœsch wrote: >> Subject: Re: [FFmpeg-devel] [PATCH 1/4] avcodec/strdec: factor out HTML >> parsing code > > typo in the commit message: srtdec > > On Fri, Aug 07, 2015 at 11:03:28PM -0700, Yayoi wrote: >> This code will be used in SAMI decoder in a later co

Re: [FFmpeg-devel] [libav-devel] [PATCH 2/6] avutil: remove av_reverse deprecation

2015-08-08 Thread Andreas Cadhalpun
On 08.08.2015 18:40, Martin Storsjö wrote: > As Hendrik said, public data symbols are problematic from a portability point > of view > (they behave differently than public functions in DLLs and require jumping > through > extra hoops, which we've chosen not to jump through - the MSVC portability

Re: [FFmpeg-devel] [PATCH 6/6] doc: add API porting guide

2015-08-08 Thread Andreas Cadhalpun
On 08.08.2015 17:30, Clément Bœsch wrote: > On Sat, Aug 08, 2015 at 01:37:37PM +0200, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> >> It would be great if someone knowledgeable would fix the TODOs. >> Lacking documentation it might be better to delay removal of those APIs

Re: [FFmpeg-devel] [PATCH] avfilter: add showfreqs filter

2015-08-08 Thread Paul B Mahol
Hi, Here is updated version, please comment. 0001-avfilter-add-showfreqs-filter.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] swscale: Make sws_alloc_set_opts() public

2015-08-08 Thread wm4
On Sat, 8 Aug 2015 19:05:39 +0200 Michael Niedermayer wrote: > > Where are the > > input and output colorspaces and ranges set? > > they would be set with sws_setColorspaceDetails() But they're pretty important, so why aren't they part of the parameter list too? In the end, the parameter list w

[FFmpeg-devel] [PATCH 2/2] mmaldec: restore extradata destroyed by bitstream filter

2015-08-08 Thread wm4
This matters because avformat_find_stream_info() can open this decoder under certain circumstances. It will not create a copy of the context, and all changes done to AVCodecContext must be undone on closing. --- Shitty avformat_find_stream_info() implementation meats shitty BSF API, wasting develop

[FFmpeg-devel] [PATCH 1/2] mmaldec: hack against buffering problems on broken input

2015-08-08 Thread wm4
I can't come up with a nice way to handle this. It's hard to keep the lock-stepped input/output in this case. You can't predict whether the MMAL decoder will output a picture (because it's asynchronous), so you have to assume in general that any packet could produce 0 or 1 frames. You can't continu

Re: [FFmpeg-devel] [PATCH] swscale: Make sws_alloc_set_opts() public

2015-08-08 Thread Michael Niedermayer
On Sat, Aug 08, 2015 at 06:49:10PM +0200, wm4 wrote: > On Sat, 8 Aug 2015 18:17:37 +0200 > Michael Niedermayer wrote: > > > On Sat, Aug 08, 2015 at 05:58:29PM +0200, wm4 wrote: > > > On Sat, 8 Aug 2015 17:14:58 +0200 > > > Michael Niedermayer wrote: > > > > > > > From: Michael Niedermayer > >

Re: [FFmpeg-devel] [PATCH 4/5] crypto_bench: add support for des

2015-08-08 Thread Nicolas George
Le primidi 21 thermidor, an CCXXIII, James Almer a écrit : > Both tomcrypt and openssl named their function DES_ecb_encrypt(), and it > fails to compile if you include OpenSSL's des header while also compiling > with tomcrypt. > > I couldn't find a way to get around this aside from making them exc

Re: [FFmpeg-devel] [PATCH] swscale: Make sws_alloc_set_opts() public

2015-08-08 Thread Paul B Mahol
On 8/8/15, wm4 wrote: > On Sat, 8 Aug 2015 18:17:37 +0200 > Michael Niedermayer wrote: > >> On Sat, Aug 08, 2015 at 05:58:29PM +0200, wm4 wrote: >> > On Sat, 8 Aug 2015 17:14:58 +0200 >> > Michael Niedermayer wrote: >> > >> > > From: Michael Niedermayer >> > > >> > > Signed-off-by: Michael Nie

Re: [FFmpeg-devel] [PATCH 4/5] crypto_bench: add support for des

2015-08-08 Thread James Almer
On 08/08/15 5:56 AM, Nicolas George wrote: > Le quintidi 15 thermidor, an CCXXIII, James Almer a écrit : >> OpenSSL and Tomcrypt des modules are not benched together as there's >> some naming collisions between the two. >> >> Signed-off-by: James Almer >> --- >> tools/crypto_bench.c | 58 >>

Re: [FFmpeg-devel] [PATCH] swscale: Make sws_alloc_set_opts() public

2015-08-08 Thread wm4
On Sat, 8 Aug 2015 18:17:37 +0200 Michael Niedermayer wrote: > On Sat, Aug 08, 2015 at 05:58:29PM +0200, wm4 wrote: > > On Sat, 8 Aug 2015 17:14:58 +0200 > > Michael Niedermayer wrote: > > > > > From: Michael Niedermayer > > > > > > Signed-off-by: Michael Niedermayer > > > --- > > > libsws

Re: [FFmpeg-devel] [PATCH 07/13] use avfilter_pad_get_{type, name} accessor functions

2015-08-08 Thread Michael Niedermayer
On Sat, Aug 08, 2015 at 01:32:31PM +0200, Andreas Cadhalpun wrote: > Signed-off-by: Andreas Cadhalpun > --- > cmdutils.c | 4 ++-- > libavdevice/lavfi.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) LGTM thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BAD

Re: [FFmpeg-devel] [PATCH] swscale: Make sws_alloc_set_opts() public

2015-08-08 Thread Michael Niedermayer
On Sat, Aug 08, 2015 at 05:58:29PM +0200, wm4 wrote: > On Sat, 8 Aug 2015 17:14:58 +0200 > Michael Niedermayer wrote: > > > From: Michael Niedermayer > > > > Signed-off-by: Michael Niedermayer > > --- > > libswscale/swscale.h | 11 +++ > > libswscale/swscale_internal.h |

Re: [FFmpeg-devel] [PATCH 10/13] ffmpeg: replace deprecated av_log_ask_for_sample with av_log

2015-08-08 Thread Hendrik Leppkes
On Sat, Aug 8, 2015 at 5:55 PM, Michael Niedermayer wrote: > On Sat, Aug 08, 2015 at 01:32:56PM +0200, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> cmdutils.c | 2 +- >> ffmpeg.c | 10 -- >> 2 files changed, 5 insertions(+), 7 deletions(-) >> >> diff --git a/

Re: [FFmpeg-devel] [PATCH] swscale: Make sws_alloc_set_opts() public

2015-08-08 Thread wm4
On Sat, 8 Aug 2015 17:14:58 +0200 Michael Niedermayer wrote: > From: Michael Niedermayer > > Signed-off-by: Michael Niedermayer > --- > libswscale/swscale.h | 11 +++ > libswscale/swscale_internal.h | 11 --- > libswscale/version.h |4 ++-- > 3 files

Re: [FFmpeg-devel] [libav-devel] [PATCH 1/6] avutil: remove deprecation of qscale_{table, type}, qstride

2015-08-08 Thread Hendrik Leppkes
On Sat, Aug 8, 2015 at 2:49 PM, wm4 wrote: > On Sat, 8 Aug 2015 14:31:21 +0200 > Hendrik Leppkes wrote: > >> On Sat, Aug 8, 2015 at 1:36 PM, Andreas Cadhalpun >> wrote: >> > They are used by the not deprecated av_frame_{g,s}et_qp_table. >> > >> > Signed-off-by: Andreas Cadhalpun >> > --- >> >

Re: [FFmpeg-devel] [PATCH 05/13] avfilter: remove obsolete function declarations

2015-08-08 Thread Michael Niedermayer
On Sat, Aug 08, 2015 at 01:32:14PM +0200, Andreas Cadhalpun wrote: > Signed-off-by: Andreas Cadhalpun > --- > libavfilter/audio.h| 20 > libavfilter/avfilter.c | 1 - > libavfilter/internal.h | 6 -- > 3 files changed, 27 deletions(-) should be ok thanks [...] --

Re: [FFmpeg-devel] [PATCH 10/13] ffmpeg: replace deprecated av_log_ask_for_sample with av_log

2015-08-08 Thread Michael Niedermayer
On Sat, Aug 08, 2015 at 01:32:56PM +0200, Andreas Cadhalpun wrote: > Signed-off-by: Andreas Cadhalpun > --- > cmdutils.c | 2 +- > ffmpeg.c | 10 -- > 2 files changed, 5 insertions(+), 7 deletions(-) > > diff --git a/cmdutils.c b/cmdutils.c > index 9bbd54b..ff5e833 100644 > --- a/cmdu

Re: [FFmpeg-devel] [PATCH 08/13] graphdump: include internal.h for AVFilterPad

2015-08-08 Thread Michael Niedermayer
On Sat, Aug 08, 2015 at 01:32:40PM +0200, Andreas Cadhalpun wrote: > Signed-off-by: Andreas Cadhalpun > --- > libavfilter/graphdump.c | 1 + > 1 file changed, 1 insertion(+) LGTM thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB He who knows, does not sp

Re: [FFmpeg-devel] [PATCH 01/13] avcodec: add missing FF_API_CODEC_ID guard

2015-08-08 Thread Michael Niedermayer
On Sat, Aug 08, 2015 at 01:31:45PM +0200, Andreas Cadhalpun wrote: > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/utils.c | 2 ++ > 1 file changed, 2 insertions(+) LGTM thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB When the tyrant has dispose

Re: [FFmpeg-devel] [libav-devel] [PATCH 1/6] avutil: remove deprecation of qscale_{table, type}, qstride

2015-08-08 Thread Clément Bœsch
On Sat, Aug 08, 2015 at 02:49:38PM +0200, wm4 wrote: > On Sat, 8 Aug 2015 14:31:21 +0200 > Hendrik Leppkes wrote: > > > On Sat, Aug 8, 2015 at 1:36 PM, Andreas Cadhalpun > > wrote: > > > They are used by the not deprecated av_frame_{g,s}et_qp_table. > > > > > > Signed-off-by: Andreas Cadhalpun

Re: [FFmpeg-devel] [PATCH] swscale: Make sws_alloc_set_opts() public

2015-08-08 Thread Clément Bœsch
On Sat, Aug 08, 2015 at 05:14:58PM +0200, Michael Niedermayer wrote: > From: Michael Niedermayer > > Signed-off-by: Michael Niedermayer > --- > libswscale/swscale.h | 11 +++ > libswscale/swscale_internal.h | 11 --- > libswscale/version.h |4 ++-- > 3

Re: [FFmpeg-devel] [PATCH 6/6] doc: add API porting guide

2015-08-08 Thread Clément Bœsch
On Sat, Aug 08, 2015 at 01:37:37PM +0200, Andreas Cadhalpun wrote: > Signed-off-by: Andreas Cadhalpun > --- > > It would be great if someone knowledgeable would fix the TODOs. > Lacking documentation it might be better to delay removal of those APIs. > > --- > doc/API-porting-guide.txt | 62 >

Re: [FFmpeg-devel] [PATCH 4/4] fate reference for samidec

2015-08-08 Thread Clément Bœsch
> Subject: Re: [FFmpeg-devel] [PATCH 4/4] fate reference for samidec no verb sentence. Suggestion: "fate/subtitles: add a new test for SAMI demuxer and decoder" On Fri, Aug 07, 2015 at 11:03:31PM -0700, Yayoi wrote: > --- > tests/fate/subtitles.mak | 3 ++ > tests/ref/fate/sub-sami2 | 91 > +++

Re: [FFmpeg-devel] [PATCH 3/4] avformat/samidec: fix tag close

2015-08-08 Thread Clément Bœsch
> Subject: Re: [FFmpeg-devel] [PATCH 3/4] avformat/samidec: fix tag close "fix tag close" is not very informative. Maybe "do not include trailing SAMI footer in the last packet" would be better. [...] -- Clément B. pgpODO2SZRZ_s.pgp Description: PGP signature _

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/samidec: use ff_htmlmarkup_to_ass()

2015-08-08 Thread Clément Bœsch
On Fri, Aug 07, 2015 at 11:03:29PM -0700, Yayoi wrote: > --- > libavcodec/samidec.c| 59 > + > tests/ref/fate/sub-sami | 18 +++ > 2 files changed, 44 insertions(+), 33 deletions(-) > > diff --git a/libavcodec/samidec.c b/libavcodec

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/strdec: factor out HTML parsing code

2015-08-08 Thread Clément Bœsch
> Subject: Re: [FFmpeg-devel] [PATCH 1/4] avcodec/strdec: factor out HTML > parsing code typo in the commit message: srtdec On Fri, Aug 07, 2015 at 11:03:28PM -0700, Yayoi wrote: > This code will be used in SAMI decoder in a later commit. > --- > libavcodec/Makefile| 4 +- > libavcode

[FFmpeg-devel] [PATCH] swscale: Make sws_alloc_set_opts() public

2015-08-08 Thread Michael Niedermayer
From: Michael Niedermayer Signed-off-by: Michael Niedermayer --- libswscale/swscale.h | 11 +++ libswscale/swscale_internal.h | 11 --- libswscale/version.h |4 ++-- 3 files changed, 13 insertions(+), 13 deletions(-) diff --git a/libswscale/swscale.h b

Re: [FFmpeg-devel] [PATCH] swscale: Implement alphablendaway for planar 4:4:4 formats

2015-08-08 Thread Michael Niedermayer
On Fri, Aug 07, 2015 at 10:21:14AM -0400, Ronald S. Bultje wrote: > Hi, > > On Fri, Aug 7, 2015 at 6:43 AM, Michael Niedermayer > wrote: > > > On Thu, Aug 06, 2015 at 10:24:52PM -0400, Ronald S. Bultje wrote: > > > Hi, > > > > > > On Thu, Aug 6, 2015 at 4:27 PM, Michael Niedermayer > > > wrote:

Re: [FFmpeg-devel] [libav-devel] [PATCH 2/6] avutil: remove av_reverse deprecation

2015-08-08 Thread Andreas Cadhalpun
On 08.08.2015 14:33, Hendrik Leppkes wrote: > On Sat, Aug 8, 2015 at 1:36 PM, Andreas Cadhalpun > wrote: >> +const uint8_t *ff_reverse = av_reverse; > > Importing data tables from another library is something we try to > avoid. Keeping a duplicate of 256 bytes is favorable. Why? > Maybe the dep

Re: [FFmpeg-devel] [libav-devel] [PATCH 1/6] avutil: remove deprecation of qscale_{table, type}, qstride

2015-08-08 Thread Andreas Cadhalpun
On 08.08.2015 14:31, Hendrik Leppkes wrote: > On Sat, Aug 8, 2015 at 1:36 PM, Andreas Cadhalpun > wrote: >> They are used by the not deprecated av_frame_{g,s}et_qp_table. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> libavutil/frame.h | 6 ++ >> 1 file changed, 2 insertions(+), 4 deletion

Re: [FFmpeg-devel] [libav-devel] [PATCH 1/6] avutil: remove deprecation of qscale_{table, type}, qstride

2015-08-08 Thread wm4
On Sat, 8 Aug 2015 14:31:21 +0200 Hendrik Leppkes wrote: > On Sat, Aug 8, 2015 at 1:36 PM, Andreas Cadhalpun > wrote: > > They are used by the not deprecated av_frame_{g,s}et_qp_table. > > > > Signed-off-by: Andreas Cadhalpun > > --- > > libavutil/frame.h | 6 ++ > > 1 file changed, 2 inse

Re: [FFmpeg-devel] [libav-devel] [PATCH 1/6] avutil: remove deprecation of qscale_{table, type}, qstride

2015-08-08 Thread Hendrik Leppkes
On Sat, Aug 8, 2015 at 1:36 PM, Andreas Cadhalpun wrote: > They are used by the not deprecated av_frame_{g,s}et_qp_table. > > Signed-off-by: Andreas Cadhalpun > --- > libavutil/frame.h | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/libavutil/frame.h b/libavutil/fr

[FFmpeg-devel] [PATCH] concatdec: fix broken file_inpoint calculation

2015-08-08 Thread Marton Balint
Should fix ticket #4765. Signed-off-by: Marton Balint --- libavformat/concatdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/concatdec.c b/libavformat/concatdec.c index 1fe294b..969b001 100644 --- a/libavformat/concatdec.c +++ b/libavformat/concatdec.c @@ -31

[FFmpeg-devel] [PATCH 5/6] Postpone API-incompatible changes until the next bump

2015-08-08 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun --- libavcodec/version.h | 54 +-- libavfilter/version.h | 10 +- libavformat/version.h | 6 +++--- libavutil/version.h | 10 +- 4 files changed, 40 insertions(+), 40 deletions(-) diff --git a/li

[FFmpeg-devel] [PATCH 6/6] doc: add API porting guide

2015-08-08 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun --- It would be great if someone knowledgeable would fix the TODOs. Lacking documentation it might be better to delay removal of those APIs. --- doc/API-porting-guide.txt | 62 +++ 1 file changed, 62 insertions(+) cre

[FFmpeg-devel] [PATCH 01/13] avcodec: add missing FF_API_CODEC_ID guard

2015-08-08 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun --- libavcodec/utils.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index 5dbd0cf..22dcc82 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -3275,11 +3275,13 @@ unsigned avcodec_version(void) av_asse

[FFmpeg-devel] [PATCH 4/6] avcodec: delay removal of avcodec_*_frame

2015-08-08 Thread Andreas Cadhalpun
They are still widely used and have been deprecated for less than two years. Signed-off-by: Andreas Cadhalpun --- libavcodec/avcodec.h | 2 +- libavcodec/utils.c | 2 +- libavcodec/version.h | 3 +++ 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcod

[FFmpeg-devel] [PATCH 3/6] avutil: delay removal of the PIX_FMT_* flags

2015-08-08 Thread Andreas Cadhalpun
Only the PixelFormat removal is not delayed, because it is a very generic name. Signed-off-by: Andreas Cadhalpun --- libavutil/pixfmt.h | 4 +++- libavutil/version.h | 5 - 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/libavutil/pixfmt.h b/libavutil/pixfmt.h index 5cdbeb9..

[FFmpeg-devel] [PATCH 1/6] avutil: remove deprecation of qscale_{table, type}, qstride

2015-08-08 Thread Andreas Cadhalpun
They are used by the not deprecated av_frame_{g,s}et_qp_table. Signed-off-by: Andreas Cadhalpun --- libavutil/frame.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavutil/frame.h b/libavutil/frame.h index 196b578..c4e333c 100644 --- a/libavutil/frame.h +++ b/libavu

[FFmpeg-devel] [PATCH 2/6] avutil: remove av_reverse deprecation

2015-08-08 Thread Andreas Cadhalpun
It is used in libavutil/eval.c. Signed-off-by: Andreas Cadhalpun --- libavcodec/mathops.h| 2 +- libavcodec/mathtables.c | 19 +-- libavutil/common.h | 4 +--- libavutil/mathematics.c | 2 -- libavutil/version.h | 3 --- 5 files changed, 3 insertions(+), 27 delet

[FFmpeg-devel] [PATCH 13/13] disable deprecation warnings in deprecated code

2015-08-08 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun --- libavcodec/mpeg12dec.c | 5 - libavcodec/options_table.h | 3 +++ libavcodec/pthread_frame.c | 9 - libavcodec/resample.c | 2 ++ libavfilter/audio.c| 2 ++ libavfilter/avcodec.c | 2 ++ libavutil/frame.c | 2 ++ liba

[FFmpeg-devel] [PATCH 12/13] buffersink: use sizeof(void *) because AVFilterBufferRef is deprecated

2015-08-08 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun --- libavfilter/buffersink.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavfilter/buffersink.c b/libavfilter/buffersink.c index a303127..5bf31a0 100644 --- a/libavfilter/buffersink.c +++ b/libavfilter/buffersink.c @@ -72,7 +

[FFmpeg-devel] [PATCH 11/13] ffmpeg: use av_buffersrc_add_frame instead of av_buffersrc_add_ref

2015-08-08 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun --- ffmpeg.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/ffmpeg.c b/ffmpeg.c index 5c44ad2..3858a4d 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -294,7 +294,7 @@ static void sub2video_flush(InputStream *ist) if (ist->sub2video.end_pts

[FFmpeg-devel] [PATCH 10/13] ffmpeg: replace deprecated av_log_ask_for_sample with av_log

2015-08-08 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun --- cmdutils.c | 2 +- ffmpeg.c | 10 -- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/cmdutils.c b/cmdutils.c index 9bbd54b..ff5e833 100644 --- a/cmdutils.c +++ b/cmdutils.c @@ -2048,7 +2048,7 @@ double get_rotation(AVStream *st)

[FFmpeg-devel] [PATCH 09/13] fate: replace deprecated request_channels with request_channel_layout

2015-08-08 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun --- tests/fate/ac3.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/ac3.mak b/tests/fate/ac3.mak index 6760de3..e636271 100644 --- a/tests/fate/ac3.mak +++ b/tests/fate/ac3.mak @@ -33,7 +33,7 @@ fate-ac3-fixed-2.0: CMD = pcm -c ac

[FFmpeg-devel] [PATCH 08/13] graphdump: include internal.h for AVFilterPad

2015-08-08 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun --- libavfilter/graphdump.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/graphdump.c b/libavfilter/graphdump.c index 3d702c6..531bb57 100644 --- a/libavfilter/graphdump.c +++ b/libavfilter/graphdump.c @@ -26,6 +26,7 @@ #include "libavutil/pixde

[FFmpeg-devel] [PATCH 07/13] use avfilter_pad_get_{type, name} accessor functions

2015-08-08 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun --- cmdutils.c | 4 ++-- libavdevice/lavfi.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cmdutils.c b/cmdutils.c index 8a585e7..9bbd54b 100644 --- a/cmdutils.c +++ b/cmdutils.c @@ -1581,10 +1581,10 @@ int show_filters(void *optc

[FFmpeg-devel] [PATCH 06/13] openal-dec: replace av_destruct_packet with av_free_packet

2015-08-08 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun --- libavdevice/openal-dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/openal-dec.c b/libavdevice/openal-dec.c index b552158..cab1eb6 100644 --- a/libavdevice/openal-dec.c +++ b/libavdevice/openal-dec.c @@ -204,7 +204,7 @@ sta

[FFmpeg-devel] [PATCH 04/13] add missing FF_API_DESTRUCT_PACKET guards

2015-08-08 Thread Andreas Cadhalpun
--- ffmpeg.c | 8 +++- libavdevice/iec61883.c | 4 libavformat/mux.c | 4 libavformat/tee.c | 8 +++- 4 files changed, 22 insertions(+), 2 deletions(-) diff --git a/ffmpeg.c b/ffmpeg.c index 434abd4..6937a00 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -692,7

[FFmpeg-devel] [PATCH 05/13] avfilter: remove obsolete function declarations

2015-08-08 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun --- libavfilter/audio.h| 20 libavfilter/avfilter.c | 1 - libavfilter/internal.h | 6 -- 3 files changed, 27 deletions(-) diff --git a/libavfilter/audio.h b/libavfilter/audio.h index 3335c96..6adc82d 100644 --- a/libavfilter/audio.

[FFmpeg-devel] [PATCH 03/13] avfilter: add missing FF_API_AVFILTERBUFFER guards

2015-08-08 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun --- libavfilter/audio.c | 4 libavfilter/avfilter.h | 6 +- libavfilter/buffersink.c | 4 libavfilter/buffersrc.h | 3 +++ libavfilter/internal.h | 2 ++ 5 files changed, 18 insertions(+), 1 deletion(-) diff --git a/libavfilter/audio.c b/l

[FFmpeg-devel] [PATCH 02/13] avfilter: add missing FF_API_AVFILTERPAD_PUBLIC guard

2015-08-08 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun --- libavfilter/avfilter.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index bcf8d3f..e1ffc4e 100644 --- a/libavfilter/avfilter.c +++ b/libavfilter/avfilter.c @@ -508,8 +508,10 @@ int avfilter_register(AVFi

Re: [FFmpeg-devel] [libav-devel] [PATCH 0/20] removal of deprecated features

2015-08-08 Thread Andreas Cadhalpun
On 07.08.2015 00:42, Luca Barbato wrote: > On 06/08/15 23:26, Andreas Cadhalpun wrote: >> I'm seeing more dramatic words than good arguments in your mail. > > Could we please tune it down a little? Tell that wm4. > For this release the deprecated APIs will be dropped w/out a third > warning, if

Re: [FFmpeg-devel] [PATCH 5/5] crypto_bench: add support for ripemd-128

2015-08-08 Thread Nicolas George
Le quintidi 15 thermidor, an CCXXIII, James Almer a écrit : > Signed-off-by: James Almer > --- > tools/crypto_bench.c | 4 > 1 file changed, 4 insertions(+) LGTM Regards, -- Nicolas George signature.asc Description: Digital signature ___ ff

Re: [FFmpeg-devel] [PATCH 4/5] crypto_bench: add support for des

2015-08-08 Thread Nicolas George
Le quintidi 15 thermidor, an CCXXIII, James Almer a écrit : > OpenSSL and Tomcrypt des modules are not benched together as there's > some naming collisions between the two. > > Signed-off-by: James Almer > --- > tools/crypto_bench.c | 58 > >

Re: [FFmpeg-devel] [PATCH 3/5] crypto_bench: add support for xtea

2015-08-08 Thread Nicolas George
Le quintidi 15 thermidor, an CCXXIII, James Almer a écrit : > Signed-off-by: James Almer > --- > tools/crypto_bench.c | 24 > 1 file changed, 24 insertions(+) LGTM Regards, -- Nicolas George signature.asc Description: Digital signature

Re: [FFmpeg-devel] [PATCH 2/5] crypto_bench: add support for rc4

2015-08-08 Thread Nicolas George
Le quintidi 15 thermidor, an CCXXIII, James Almer a écrit : > Signed-off-by: James Almer > --- > tools/crypto_bench.c | 24 > 1 file changed, 24 insertions(+) LGTM Regards, -- Nicolas George signature.asc Description: Digital signature

Re: [FFmpeg-devel] [PATCH 1/5] crypto_bench: add support for blowfish

2015-08-08 Thread Nicolas George
Le quintidi 15 thermidor, an CCXXIII, James Almer a écrit : > Signed-off-by: James Almer > --- > tools/crypto_bench.c | 45 + > 1 file changed, 45 insertions(+) Sorry for the delay, I forgot. LGTM, thanks. Regards, -- Nicolas George signature.as

Re: [FFmpeg-devel] [PATCH] api-h264-test: structure changes

2015-08-08 Thread Michael Niedermayer
On Mon, Aug 03, 2015 at 10:49:21PM +0300, Ludmila Glinskih wrote: > To avoid duplicate code > --- > tests/api/api-h264-test.c | 47 > +++ > 1 file changed, 15 insertions(+), 32 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2

[FFmpeg-devel] VideoLAN Dev Days 2015 registration

2015-08-08 Thread Jean-Baptiste Kempf
Hello my FFmpeg fellows, VideoLAN Dev Days 2015, in Paris, is approaching. It's on September 19-20, 2015, in the St Lazare district, in Paris. So far, we've registration from numerous people from VLC, FFmpeg, x264, x265, KDE, MPlayer, libav, aegisub, handbrake, and many other... We've already pla