Re: [FFmpeg-devel] [PATCH 1/2] lavu/intmath.h: Add msvc/icl ctzll optimisations.

2015-10-15 Thread James Almer
On 10/16/2015 3:03 AM, Matt Oliver wrote: > Take 3. Updated the patch based on comments so that it correctly supports > msvc, icl and icc LGTM. How does the assembly ICL generates for the x86_32 version look like? ICC seems to create a branch for the v == 0 check, so a handwritten inline assembly

Re: [FFmpeg-devel] [PATCH] fix b frame n_quant_offset

2015-10-15 Thread Timo Rothenpieler
Anyone takes a look at this patch? Thanks Looks fine, if noone objects, i'll merge it this weekend. signature.asc Description: OpenPGP digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg

Re: [FFmpeg-devel] [PATCH 2/2] lavu/intmath.h: Move x86 only msvc/icl functions to x86 specific header.

2015-10-15 Thread Matt Oliver
On 16 October 2015 at 16:13, James Almer wrote: > On 10/15/2015 10:26 PM, Matt Oliver wrote: > > On 16 October 2015 at 01:10, Matt Oliver wrote: > > > >> > Some of the existing msvc/icl optimised versions for ctz and log2 use > >> > intrinsics that are only usable on x86 systems. This patch move

Re: [FFmpeg-devel] [PATCH 1/2] lavu/intmath.h: Add msvc/icl ctzll optimisations.

2015-10-15 Thread Matt Oliver
On 16 October 2015 at 12:25, Matt Oliver wrote: > On 16 October 2015 at 09:46, James Almer wrote: > >> On 10/15/2015 7:25 PM, Matt Oliver wrote: >> > ICC defines __GNUC__ but ICL does not! ICC (being the linux variant) >> > supports all the same functions as gcc so theres no need in this case >>

Re: [FFmpeg-devel] [PATCH 2/2] lavu/intmath.h: Move x86 only msvc/icl functions to x86 specific header.

2015-10-15 Thread James Almer
On 10/15/2015 10:26 PM, Matt Oliver wrote: > On 16 October 2015 at 01:10, Matt Oliver wrote: > >> > Some of the existing msvc/icl optimised versions for ctz and log2 use >> > intrinsics that are only usable on x86 systems. This patch moves them from >> > intmath.h to x86/intmath.h. This is techni

[FFmpeg-devel] [PATCH] avcodec: loongson optimize h264dsp idct and loop filter with mmi

2015-10-15 Thread 周晓勇
Hi, i am making rpm package on fedora21-loongson but find out the master contain this patch, but neither in release/2.8 or n2.8.1 git log master: commit f7e9b9d260f9c7f065791c70d9ca6b89b5164742 Author: 周晓勇 Date: Wed Sep 2 18:02:24 2015 +0800 avcodec: loongson optimize h264dsp idct and

Re: [FFmpeg-devel] [PATCH] fix b frame n_quant_offset

2015-10-15 Thread Agatha Hu
在 2015/10/9 17:38, Agatha Hu 写道: --- libavcodec/nvenc.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 18bcd96..0e6ef43 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -742,8 +742,6 @@ static av_cold int nvenc

Re: [FFmpeg-devel] [PATCH] avutil/opencl: add av_warn_unused_result

2015-10-15 Thread highgod0401
From: Ganesh Ajjanagadde Date: 2015-10-16 08:08 To: ffmpeg-devel CC: Ganesh Ajjanagadde Subject: [FFmpeg-devel] [PATCH] avutil/opencl: add av_warn_unused_result This will trigger a few warnings. My config does not compile the opencl code, so this is untested. Signed-off-by: Ganesh Ajjanagadde --

Re: [FFmpeg-devel] usage of AV_GLUE?

2015-10-15 Thread Ronald S. Bultje
Hi, On Thu, Oct 15, 2015 at 8:37 PM, Ganesh Ajjanagadde wrote: > Hi all, > > Examining libavutil/macros, there is AV_GLUE/AV_JOIN (why are there > two?) defined for preprocessor token pasting. However, it is not being > used anywhere, instead people have use "##". There are a number of > options

[FFmpeg-devel] [PATCH 11/11] avdevice/decklink_dec: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
This should not trigger any warnings, but adds robustness. Untested. Signed-off-by: Ganesh Ajjanagadde --- libavdevice/decklink_dec.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavdevice/decklink_dec.h b/libavdevice/decklink_dec.h index 6bd9226..b19bdc6 100644 --- a/libavdevice/deckli

Re: [FFmpeg-devel] [PATCH 2/2] swresample/swresample_internal: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 10:04 PM, Michael Niedermayer wrote: > On Thu, Oct 15, 2015 at 09:32:18PM -0400, Ganesh Ajjanagadde wrote: >> This will trigger a few warnings that need to be fixed. >> >> Signed-off-by: Ganesh Ajjanagadde >> --- >> libswresample/swresample_internal.h | 4 >> 1 file

[FFmpeg-devel] [PATCH 08/11] avdevice/oss: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
This does not trigger any warnings, but adds robustness. Signed-off-by: Ganesh Ajjanagadde --- libavdevice/oss.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavdevice/oss.h b/libavdevice/oss.h index 1f3f5e4..c5eab75 100644 --- a/libavdevice/oss.h +++ b/libavdevice/oss.h @@ -37,6 +37,7

[FFmpeg-devel] [PATCH 09/11] avdevice/fbdev_common: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
This does not trigger any warnings, but adds robustness. Signed-off-by: Ganesh Ajjanagadde --- libavdevice/fbdev_common.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavdevice/fbdev_common.h b/libavdevice/fbdev_common.h index 7b81a8d..f19371d 100644 --- a/libavdevice/fbdev_common.h +

[FFmpeg-devel] [PATCH 10/11] avdevice/dshow_capture: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
This does not trigger any warnings, but adds robustness. Untested. Signed-off-by: Ganesh Ajjanagadde --- libavdevice/dshow_capture.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavdevice/dshow_capture.h b/libavdevice/dshow_capture.h index b17da10..7f5192b 100644 --- a/libavdevice/dshow

Re: [FFmpeg-devel] [PATCH] avutil/cast5: update Doxygen for av_castt_init with return information

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 10:08 PM, Michael Niedermayer wrote: > On Thu, Oct 15, 2015 at 05:44:49PM -0400, Ganesh Ajjanagadde wrote: >> Signed-off-by: Ganesh Ajjanagadde >> --- >> libavutil/cast5.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/libavutil/cast5.h b/libavutil/cast5.h >>

Re: [FFmpeg-devel] [PATCH] avutil/parseutils: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 10:22 PM, Ganesh Ajjanagadde wrote: > On Thu, Oct 15, 2015 at 10:16 PM, James Almer wrote: >> On 10/15/2015 10:23 PM, Ganesh Ajjanagadde wrote: >>> On Thu, Oct 15, 2015 at 8:06 PM, James Almer wrote: On 10/15/2015 8:52 PM, Ganesh Ajjanagadde wrote: > This trigger

[FFmpeg-devel] [PATCH 04/11] avdevice/alsa: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
This does not trigger any warnings, but adds robustness. Signed-off-by: Ganesh Ajjanagadde --- libavdevice/alsa.h | 4 1 file changed, 4 insertions(+) diff --git a/libavdevice/alsa.h b/libavdevice/alsa.h index f8b7449..cd41d96 100644 --- a/libavdevice/alsa.h +++ b/libavdevice/alsa.h @@ -74

[FFmpeg-devel] [PATCH 05/11] avdevice/decklink_common: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
This should not trigger any warnings, but adds robustness. Untested. Signed-off-by: Ganesh Ajjanagadde --- libavdevice/decklink_common.h | 4 1 file changed, 4 insertions(+) diff --git a/libavdevice/decklink_common.h b/libavdevice/decklink_common.h index 3bc30f0..eb13a1b 100644 --- a/libav

[FFmpeg-devel] [PATCH 07/11] avdevice/avdevice: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
This triggers a bunch of warnings that need to be fixed. Signed-off-by: Ganesh Ajjanagadde --- libavdevice/avdevice.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavdevice/avdevice.h b/libavdevice/avdevice.h index 6b0446c..23611e6 100644 --- a/libavdevice/avdevice.h +++ b/libavde

[FFmpeg-devel] [PATCH 06/11] avdevice/decklink_enc: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
Should not trigger any warnings, but adds robustness. Untested. Signed-off-by: Ganesh Ajjanagadde --- libavdevice/decklink_enc.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavdevice/decklink_enc.h b/libavdevice/decklink_enc.h index 6086947..462e031 100644 --- a/libavdevice/decklink_

[FFmpeg-devel] [PATCH 03/11] avdevice/sndio: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
This does not trigger any warnings, but adds robustness. Untested, as my configure does not compile this file. Signed-off-by: Ganesh Ajjanagadde --- libavdevice/sndio.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavdevice/sndio.h b/libavdevice/sndio.h index 54a5ec3..6571429 100644 ---

[FFmpeg-devel] [PATCH 02/11] avdevice/pulse_audio_common: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
This does not trigger any warnings, but adds robustness. Signed-off-by: Ganesh Ajjanagadde --- libavdevice/pulse_audio_common.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavdevice/pulse_audio_common.h b/libavdevice/pulse_audio_common.h index 02534f7..902795e 100644 --- a/libavdevic

[FFmpeg-devel] [PATCH 01/11] avdevice/internal: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
This does not trigger any warnings but adds robustness. Signed-off-by: Ganesh Ajjanagadde --- libavdevice/internal.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavdevice/internal.h b/libavdevice/internal.h index 3cd1b06..e222cf2 100644 --- a/libavdevice/internal.h +++ b/libavdevice/in

Re: [FFmpeg-devel] [PATCH] avutil/parseutils: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 10:16 PM, James Almer wrote: > On 10/15/2015 10:23 PM, Ganesh Ajjanagadde wrote: >> On Thu, Oct 15, 2015 at 8:06 PM, James Almer wrote: >>> On 10/15/2015 8:52 PM, Ganesh Ajjanagadde wrote: This triggers a few warnings that will need to be fixed - not that bad, th

Re: [FFmpeg-devel] [PATCH] avutil/parseutils: add av_warn_unused_result

2015-10-15 Thread James Almer
On 10/15/2015 10:23 PM, Ganesh Ajjanagadde wrote: > On Thu, Oct 15, 2015 at 8:06 PM, James Almer wrote: >> On 10/15/2015 8:52 PM, Ganesh Ajjanagadde wrote: >>> This triggers a few warnings that will need to be fixed - not that bad, >>> the current code is mostly fine. >>> >> >> I think i asked you

Re: [FFmpeg-devel] [PATCH 2/2] swresample/swresample_internal: add av_warn_unused_result

2015-10-15 Thread Michael Niedermayer
On Thu, Oct 15, 2015 at 09:32:18PM -0400, Ganesh Ajjanagadde wrote: > This will trigger a few warnings that need to be fixed. > > Signed-off-by: Ganesh Ajjanagadde > --- > libswresample/swresample_internal.h | 4 > 1 file changed, 4 insertions(+) LGTM thanks [...] -- Michael GnuPG f

Re: [FFmpeg-devel] [PATCH] avutil/cast5: update Doxygen for av_castt_init with return information

2015-10-15 Thread Michael Niedermayer
On Thu, Oct 15, 2015 at 05:44:49PM -0400, Ganesh Ajjanagadde wrote: > Signed-off-by: Ganesh Ajjanagadde > --- > libavutil/cast5.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavutil/cast5.h b/libavutil/cast5.h > index e5cc8b1..68513e5 100644 > --- a/libavutil/cast5.h > +++ b/libav

[FFmpeg-devel] [PATCH 1/2] swscale/swscale_internal: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
This triggers a few warnings that need to be fixed. Signed-off-by: Ganesh Ajjanagadde --- libswscale/swscale_internal.h | 8 1 file changed, 8 insertions(+) diff --git a/libswscale/swscale_internal.h b/libswscale/swscale_internal.h index 27a40af..6e4d031 100644 --- a/libswscale/swscale

[FFmpeg-devel] [PATCH 2/2] swscale/swscale: add av_warn_unused_result to sws_init_context

2015-10-15 Thread Ganesh Ajjanagadde
This should not trigger any warnings; but adds robustness. Signed-off-by: Ganesh Ajjanagadde --- libswscale/swscale.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libswscale/swscale.h b/libswscale/swscale.h index ff3f630..da9dd2e 100644 --- a/libswscale/swscale.h +++ b/libswscale/swscale.

Re: [FFmpeg-devel] [PATCH] avutil/crc: add av_warn_unused_result to av_crc_init

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 9:24 PM, Michael Niedermayer wrote: > On Thu, Oct 15, 2015 at 07:32:45PM -0400, Ganesh Ajjanagadde wrote: >> This triggers useful warnings in avcodec/mlp that need to be fixed. >> >> Signed-off-by: Ganesh Ajjanagadde >> --- >> libavutil/crc.h | 1 + >> 1 file changed, 1 i

Re: [FFmpeg-devel] [PATCH 1/2] lavu/intmath.h: Add msvc/icl ctzll optimisations.

2015-10-15 Thread Matt Oliver
On 16 October 2015 at 09:46, James Almer wrote: > On 10/15/2015 7:25 PM, Matt Oliver wrote: > > ICC defines __GNUC__ but ICL does not! ICC (being the linux variant) > > supports all the same functions as gcc so theres no need in this case for > > special handling. However ICL defines _MSC_VER so

[FFmpeg-devel] [PATCH 2/2] swresample/swresample_internal: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
This will trigger a few warnings that need to be fixed. Signed-off-by: Ganesh Ajjanagadde --- libswresample/swresample_internal.h | 4 1 file changed, 4 insertions(+) diff --git a/libswresample/swresample_internal.h b/libswresample/swresample_internal.h index ce5eef4..bf0cec7 100644 --- a

[FFmpeg-devel] [PATCH 1/2] swresample/swresample: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
This will trigger a few warnings (e.g in avfilter) that need to be fixed. Signed-off-by: Ganesh Ajjanagadde --- libswresample/swresample.h | 9 + 1 file changed, 9 insertions(+) diff --git a/libswresample/swresample.h b/libswresample/swresample.h index 10eaebc..d21084f 100644 --- a/libs

Re: [FFmpeg-devel] [PATCH 2/2] lavu/intmath.h: Move x86 only msvc/icl functions to x86 specific header.

2015-10-15 Thread Matt Oliver
On 16 October 2015 at 01:10, Matt Oliver wrote: > Some of the existing msvc/icl optimised versions for ctz and log2 use > intrinsics that are only usable on x86 systems. This patch moves them from > intmath.h to x86/intmath.h. This is technically where such functions should > go but this will als

Re: [FFmpeg-devel] [PATCH] avutil/crc: add av_warn_unused_result to av_crc_init

2015-10-15 Thread Michael Niedermayer
On Thu, Oct 15, 2015 at 07:32:45PM -0400, Ganesh Ajjanagadde wrote: > This triggers useful warnings in avcodec/mlp that need to be fixed. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavutil/crc.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavutil/crc.h b/libavutil/crc.h > in

Re: [FFmpeg-devel] [PATCH] avutil/parseutils: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 8:06 PM, James Almer wrote: > On 10/15/2015 8:52 PM, Ganesh Ajjanagadde wrote: >> This triggers a few warnings that will need to be fixed - not that bad, >> the current code is mostly fine. >> > > I think i asked you before, but in any case i'll do it again. Please, > send

Re: [FFmpeg-devel] [PATCH] avutil/parseutils: add av_warn_unused_result

2015-10-15 Thread Michael Niedermayer
On Thu, Oct 15, 2015 at 08:15:20PM -0400, Ganesh Ajjanagadde wrote: > On Thu, Oct 15, 2015 at 8:06 PM, James Almer wrote: > > On 10/15/2015 8:52 PM, Ganesh Ajjanagadde wrote: > >> This triggers a few warnings that will need to be fixed - not that bad, > >> the current code is mostly fine. > >> > >

[FFmpeg-devel] [PATCH] avutil/imgutils: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
This will trigger a few warnings, mainly in swscale. Signed-off-by: Ganesh Ajjanagadde --- libavutil/imgutils.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavutil/imgutils.h b/libavutil/imgutils.h index 23282a3..164d0ad 100644 --- a/libavutil/imgutils.h +++ b/libavutil/imgutils.h @

Re: [FFmpeg-devel] [PATCH] avutil/imgutils: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 8:52 PM, Ganesh Ajjanagadde wrote: > This will trigger a few warnings, mainly in swscale. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavutil/imgutils.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavutil/imgutils.h b/libavutil/imgutils.h > index 232

[FFmpeg-devel] usage of AV_GLUE?

2015-10-15 Thread Ganesh Ajjanagadde
Hi all, Examining libavutil/macros, there is AV_GLUE/AV_JOIN (why are there two?) defined for preprocessor token pasting. However, it is not being used anywhere, instead people have use "##". There are a number of options regarding this: 1. Start using them, and convert the ## usage to AV_GLUE/AV_

Re: [FFmpeg-devel] [PATCH] avutil/parseutils: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 8:06 PM, James Almer wrote: > On 10/15/2015 8:52 PM, Ganesh Ajjanagadde wrote: >> This triggers a few warnings that will need to be fixed - not that bad, >> the current code is mostly fine. >> > > I think i asked you before, but in any case i'll do it again. Please, > send

[FFmpeg-devel] [PATCH] avutil/opencl: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
This will trigger a few warnings. My config does not compile the opencl code, so this is untested. Signed-off-by: Ganesh Ajjanagadde --- libavutil/opencl.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavutil/opencl.h b/libavutil/opencl.h index e423e55..6a5b0ab 100644 --- a/

Re: [FFmpeg-devel] [PATCH] avutil/parseutils: add av_warn_unused_result

2015-10-15 Thread James Almer
On 10/15/2015 8:52 PM, Ganesh Ajjanagadde wrote: > This triggers a few warnings that will need to be fixed - not that bad, > the current code is mostly fine. > I think i asked you before, but in any case i'll do it again. Please, send patchsets contained in a single thread. You're making things h

[FFmpeg-devel] [PATCH] avutil/wchar_filename: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
Current code is fine, this just adds robustness. Signed-off-by: Ganesh Ajjanagadde --- libavutil/wchar_filename.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/wchar_filename.h b/libavutil/wchar_filename.h index c553c46..2ade321 100644 --- a/libavutil/wchar_filename.h +++ b/libav

Re: [FFmpeg-devel] [PATCH] avutil/sha512: add av_warn_unused_result to av_sha512_init

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 7:37 PM, Ganesh Ajjanagadde wrote: > This will trigger some useful warnings in avutil/hash that need to be fixed. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavutil/sha512.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavutil/sha512.h b/libavutil/sha51

[FFmpeg-devel] [PATCH] avutil/parseutils: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
This triggers a few warnings that will need to be fixed - not that bad, the current code is mostly fine. Signed-off-by: Ganesh Ajjanagadde --- libavutil/parseutils.h | 5 + 1 file changed, 5 insertions(+) diff --git a/libavutil/parseutils.h b/libavutil/parseutils.h index e66d24b..46de518 10

[FFmpeg-devel] [PATCH] avutil/frame: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
This is going to trigger a lot of warnings all over the place that need fixing. Main culprits are in avfilter, when one tries to copy a frame without checking whether src and dest formats actually are compatible. Signed-off-by: Ganesh Ajjanagadde --- libavutil/frame.h | 5 + 1 file changed,

[FFmpeg-devel] [PATCH] avutil/sha512: add av_warn_unused_result to av_sha512_init

2015-10-15 Thread Ganesh Ajjanagadde
This will trigger some useful warnings in avutil/hash that need to be fixed. Signed-off-by: Ganesh Ajjanagadde --- libavutil/sha512.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/sha512.h b/libavutil/sha512.h index 7b08701..6aecf31 100644 --- a/libavutil/sha512.h +++ b/libavutil

[FFmpeg-devel] [PATCH] avutil/crc: add av_warn_unused_result to av_crc_init

2015-10-15 Thread Ganesh Ajjanagadde
This triggers useful warnings in avcodec/mlp that need to be fixed. Signed-off-by: Ganesh Ajjanagadde --- libavutil/crc.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/crc.h b/libavutil/crc.h index e86bf1d..75929b2 100644 --- a/libavutil/crc.h +++ b/libavutil/crc.h @@ -60,6 +60,7

[FFmpeg-devel] [PATCH] avutil/audio_fifo: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
This one should not trigger any warnings, but will be useful for future robustness. Signed-off-by: Ganesh Ajjanagadde --- libavutil/audio_fifo.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/audio_fifo.h b/libavutil/audio_fifo.h index d93be2a..24f91da 100644 --- a/libavutil/audio

[FFmpeg-devel] [PATCH] avutil/pixdesc: add av_warn_unused_result to av_pix_fmt_get_chroma_sub_sample

2015-10-15 Thread Ganesh Ajjanagadde
This will trigger a bunch of warnings (rightfully so). This API has been abused, see the Doxygen comment above for what to do if the error code is not meant to be checked. Signed-off-by: Ganesh Ajjanagadde --- libavutil/pixdesc.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/pixd

Re: [FFmpeg-devel] [PATCH] avutil/buffer: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 6:22 PM, Ganesh Ajjanagadde wrote: > Signed-off-by: Ganesh Ajjanagadde > --- > libavutil/buffer.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavutil/buffer.h b/libavutil/buffer.h > index b4399fd..6f03677 100644 > --- a/libavutil/buffer.h > +++ b/libavuti

[FFmpeg-devel] [PATCHv2] avutil/buffer: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
Signed-off-by: Ganesh Ajjanagadde --- libavutil/buffer.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavutil/buffer.h b/libavutil/buffer.h index b4399fd..e0dbc8a 100644 --- a/libavutil/buffer.h +++ b/libavutil/buffer.h @@ -26,6 +26,7 @@ #define AVUTIL_BUFFER_H #include +#include

[FFmpeg-devel] [PATCH] version.sh: add note that ffversion.h is auto-generated

2015-10-15 Thread Ganesh Ajjanagadde
Signed-off-by: Ganesh Ajjanagadde --- version.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/version.sh b/version.sh index f9754eb..a9d7e39 100755 --- a/version.sh +++ b/version.sh @@ -54,6 +54,7 @@ GUARD=$(echo "$2" | sed 's/\//_/' | sed 's/\./_/' | tr '[:lower:]' '[:upper:]' | # Updat

[FFmpeg-devel] [PATCH] avfilter/avfilter: Error out if audio parameters change instead of failing an assert

2015-10-15 Thread Michael Niedermayer
From: Michael Niedermayer Filters which support such changes should be excluded from these checks Fixes Ticket4884 Signed-off-by: Michael Niedermayer --- libavfilter/avfilter.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/libavfilter/avfilter.

Re: [FFmpeg-devel] [PATCH 1/2] lavu/intmath.h: Add msvc/icl ctzll optimisations.

2015-10-15 Thread James Almer
On 10/15/2015 7:25 PM, Matt Oliver wrote: > ICC defines __GNUC__ but ICL does not! ICC (being the linux variant) > supports all the same functions as gcc so theres no need in this case for > special handling. However ICL defines _MSC_VER so this is correct. Ah, good to know then. >> > >>> > > +#d

[FFmpeg-devel] [PATCH] avutil/samplefmt: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
Signed-off-by: Ganesh Ajjanagadde --- libavutil/samplefmt.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavutil/samplefmt.h b/libavutil/samplefmt.h index 6a8a031..246147f 100644 --- a/libavutil/samplefmt.h +++ b/libavutil/samplefmt.h @@ -222,6 +222,7 @@ int av_samples_fill_arrays(uint

[FFmpeg-devel] [PATCH] libavformat/Makefile: remove unnecessary object file from wtv demuxer

2015-10-15 Thread Hendrik Leppkes
The wtv demuxer doesn't reference any functionality from asfdec or asfcrypt --- Found another one.. libavformat/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/Makefile b/libavformat/Makefile index c58cfb4..7bcdadf 100644 --- a/libavformat/Makefile +++ b/li

Re: [FFmpeg-devel] [PATCH 1/2] lavu/intmath.h: Add msvc/icl ctzll optimisations.

2015-10-15 Thread Matt Oliver
On 16 October 2015 at 03:47, James Almer wrote: > On 10/15/2015 11:07 AM, Matt Oliver wrote: > > This patch just adds the msvc and icl equivalent ctzll optimisations to > > correspond with the recently added gcc variant > > > > > > 0001-lavu-intmath.h-Add-msvc-icl-ctzll-optimisations.patch > > >

[FFmpeg-devel] [PATCH] avutil/opencl_internal: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
Signed-off-by: Ganesh Ajjanagadde --- libavutil/opencl_internal.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/opencl_internal.h b/libavutil/opencl_internal.h index dacd930..a4f5885 100644 --- a/libavutil/opencl_internal.h +++ b/libavutil/opencl_internal.h @@ -30,4 +30,5 @@ typed

[FFmpeg-devel] [PATCH] avutil/file: add av_warn_unused_result to av_file_map

2015-10-15 Thread Ganesh Ajjanagadde
The return code here should be checked. Signed-off-by: Ganesh Ajjanagadde --- libavutil/file.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/file.h b/libavutil/file.h index 1cae295..e931be7 100644 --- a/libavutil/file.h +++ b/libavutil/file.h @@ -40,6 +40,7 @@ * @return a non n

[FFmpeg-devel] [PATCH] avutil/buffer: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
Signed-off-by: Ganesh Ajjanagadde --- libavutil/buffer.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavutil/buffer.h b/libavutil/buffer.h index b4399fd..6f03677 100644 --- a/libavutil/buffer.h +++ b/libavutil/buffer.h @@ -178,6 +178,7 @@ int av_buffer_get_ref_count(const AVBufferRef

[FFmpeg-devel] [PATCH] avutil/opt: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
Some warnings do get triggered that will need to be fixed. Signed-off-by: Ganesh Ajjanagadde --- libavutil/opt.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavutil/opt.h b/libavutil/opt.h index 753434d..5abe963 100644 --- a/libavutil/opt.h +++ b/libavutil/opt.h @@ -414,6 +414,7 @@ v

[FFmpeg-devel] [PATCH] libavformat/Makefile: remove unnecessary object file from wtv demuxer

2015-10-15 Thread Hendrik Leppkes
The wtv demuxer doesn't reference any functionality from asfdec_f --- libavformat/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/Makefile b/libavformat/Makefile index c58cfb4..b8eb30b 100644 --- a/libavformat/Makefile +++ b/libavformat/Makefile @@ -471,7 +

[FFmpeg-devel] [PATCH] avutil/avstring: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
Signed-off-by: Ganesh Ajjanagadde --- libavutil/avstring.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavutil/avstring.h b/libavutil/avstring.h index a306e89..a46d012 100644 --- a/libavutil/avstring.h +++ b/libavutil/avstring.h @@ -339,6 +339,7 @@ enum AVEscapeMode { * @return the

Re: [FFmpeg-devel] [PATCH][RFC] avutil/time: add av_warn_unused_result to av_usleep

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 6:01 PM, Hendrik Leppkes wrote: > On Thu, Oct 15, 2015 at 11:59 PM, Ganesh Ajjanagadde > wrote: >> av_usleep can fail. Forcing users to check the error code here may be >> somewhat controversial. >> >> Signed-off-by: Ganesh Ajjanagadde >> --- >> libavutil/time.h | 1 + >>

Re: [FFmpeg-devel] [PATCH][RFC] avutil/time: add av_warn_unused_result to av_usleep

2015-10-15 Thread Hendrik Leppkes
On Thu, Oct 15, 2015 at 11:59 PM, Ganesh Ajjanagadde wrote: > av_usleep can fail. Forcing users to check the error code here may be > somewhat controversial. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavutil/time.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavutil/time.h b

[FFmpeg-devel] [PATCH][RFC] avutil/time: add av_warn_unused_result to av_usleep

2015-10-15 Thread Ganesh Ajjanagadde
av_usleep can fail. Forcing users to check the error code here may be somewhat controversial. Signed-off-by: Ganesh Ajjanagadde --- libavutil/time.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/time.h b/libavutil/time.h index dc169b0..f55167b 100644 --- a/libavutil/time.h +++ b/

[FFmpeg-devel] [PATCH] avutil/internal: add av_warn_unused_result to avpriv_open

2015-10-15 Thread Ganesh Ajjanagadde
The open syscall can obviously fail, and its return code needs to be checked. Signed-off-by: Ganesh Ajjanagadde --- libavutil/internal.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/internal.h b/libavutil/internal.h index 13dbd3b..5c2cd99 100644 --- a/libavutil/internal.h +++ b/

[FFmpeg-devel] [PATCH] avutil/cast5: update Doxygen for av_castt_init with return information

2015-10-15 Thread Ganesh Ajjanagadde
Signed-off-by: Ganesh Ajjanagadde --- libavutil/cast5.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/cast5.h b/libavutil/cast5.h index e5cc8b1..68513e5 100644 --- a/libavutil/cast5.h +++ b/libavutil/cast5.h @@ -48,6 +48,7 @@ struct AVCAST5 *av_cast5_alloc(void); * @param ctx a

Re: [FFmpeg-devel] [PATCH] avutil/cast5: update Doxygen for av_castt_init with return information

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 5:44 PM, Ganesh Ajjanagadde wrote: > Signed-off-by: Ganesh Ajjanagadde > --- > libavutil/cast5.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavutil/cast5.h b/libavutil/cast5.h > index e5cc8b1..68513e5 100644 > --- a/libavutil/cast5.h > +++ b/libavutil/cast

[FFmpeg-devel] [PATCH] avutil/mem: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
This adds av_warn_unused_result to functions whose return codes need to be checked. Signed-off-by: Ganesh Ajjanagadde --- libavutil/mem.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavutil/mem.h b/libavutil/mem.h index 2a1e36d..285697c 100644 --- a/libavutil/mem.h +++ b/libavutil/m

[FFmpeg-devel] [PATCH] avfilter/transform: add av_warn_unused_result to avfilter_transform

2015-10-15 Thread Ganesh Ajjanagadde
This adds av_warn_unused_result to avfilter_transform to trigger warnings for non-checked return codes, currently none. Signed-off-by: Ganesh Ajjanagadde --- libavfilter/transform.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/transform.h b/libavfilter/transform.h index 07436b

Re: [FFmpeg-devel] [PATCH] avfilter, swresample, swscale: use fabs, fabsf instead of FFABS

2015-10-15 Thread Ganesh Ajjanagadde
On Wed, Oct 14, 2015 at 6:54 AM, Carl Eugen Hoyos wrote: > Hendrik Leppkes gmail.com> writes: > >> One thing I don't understand - why are we bothering >> with something that at best comes out as "same speed" >> from tests performed? (low number of runs are >> irrelevant as they are not statistica

Re: [FFmpeg-devel] [PATCH] swresample: slightly nicer debug output for auto matrix

2015-10-15 Thread wm4
On Thu, 15 Oct 2015 19:50:13 +0200 Michael Niedermayer wrote: > On Thu, Oct 15, 2015 at 07:07:48PM +0200, wm4 wrote: > > This is the matrix that will be used for up/downmixing. > > --- > > libswresample/rematrix.c | 9 +++-- > > 1 file changed, 7 insertions(+), 2 deletions(-) > > LGTM > >

Re: [FFmpeg-devel] [PATCH] mips: disable all features in configure if no cpu is matched

2015-10-15 Thread Michael Niedermayer
On Thu, Oct 15, 2015 at 01:22:39PM +, Nedeljko Babic wrote: > >> > >> On the other hand, if cpu option is used with some cpu that is not > >> supported in > >> the list, configuration will break since “-march” is set to that cpu > >> value. > > > >Are you sure? What happen if you pass --cpu=

Re: [FFmpeg-devel] [PATCH] swresample: slightly nicer debug output for auto matrix

2015-10-15 Thread Michael Niedermayer
On Thu, Oct 15, 2015 at 07:07:48PM +0200, wm4 wrote: > This is the matrix that will be used for up/downmixing. > --- > libswresample/rematrix.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) LGTM thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC7870

Re: [FFmpeg-devel] [PATCH] vp9: use AVFrame.buf[0] to check if a frame is valid

2015-10-15 Thread wm4
On Thu, 15 Oct 2015 08:52:33 -0400 "Ronald S. Bultje" wrote: > Hi, > > On Thu, Oct 15, 2015 at 8:02 AM, Hendrik Leppkes > wrote: > > > AVFrame.data[0] is not guaranteed to be set with a HWAccel > > --- > > libavcodec/vp9.c | 46 +++--- > > 1 file change

Re: [FFmpeg-devel] [PATCH] avfilter: add setfps filter

2015-10-15 Thread Paul B Mahol
Dana 15. 10. 2015. 15:44 osoba "Nicholas Robbins" < nickrobbins-at-yahoo@ffmpeg.org> napisala je: > > > On Thursday, October 15, 2015 7:18 AM, Paul B Mahol wrote: > > > > On 10/15/15, Nicolas George wrote: > >> Le quartidi 24 vendemiaire, an CCXXIV, Paul B Mahol a ecrit : > >>> IMHO, it is

[FFmpeg-devel] [PATCH] swresample: slightly nicer debug output for auto matrix

2015-10-15 Thread wm4
This is the matrix that will be used for up/downmixing. --- libswresample/rematrix.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libswresample/rematrix.c b/libswresample/rematrix.c index 54ebb96..932088f 100644 --- a/libswresample/rematrix.c +++ b/libswresample/rem

Re: [FFmpeg-devel] [PATCH 1/2] lavu/intmath.h: Add msvc/icl ctzll optimisations.

2015-10-15 Thread James Almer
On 10/15/2015 11:07 AM, Matt Oliver wrote: > This patch just adds the msvc and icl equivalent ctzll optimisations to > correspond with the recently added gcc variant > > > 0001-lavu-intmath.h-Add-msvc-icl-ctzll-optimisations.patch > > > From 2b8e7757cdb8595181a01bb18756d60662c41fde Mon Sep 17 0

[FFmpeg-devel] QSV dynamically linked on linux

2015-10-15 Thread Julien Fond
Hi all, I'm using QuickSync and FFmpeg on linux. It works well for encoding and decoding when I build it with --enable-static. But when I build it with --enable-shared, it hangs. So my question is: is it supposed to work when dynamically linked? Thanks in advance, Julien

Re: [FFmpeg-devel] [PATCH] configure, avutil/libm: add fmax, fmaxf, fmin, fminf support

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 11:12 AM, Ganesh Ajjanagadde wrote: > On Thu, Oct 15, 2015 at 10:18 AM, Hendrik Leppkes wrote: >> On Thu, Oct 15, 2015 at 4:04 PM, Derek Buitenhuis >> wrote: >>> On 10/15/2015 1:18 PM, Ganesh Ajjanagadde wrote: It has been demonstrated that using libc provided floati

Re: [FFmpeg-devel] [PATCH] configure, avutil/libm: add fmax, fmaxf, fmin, fminf support

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 10:18 AM, Hendrik Leppkes wrote: > On Thu, Oct 15, 2015 at 4:04 PM, Derek Buitenhuis > wrote: >> On 10/15/2015 1:18 PM, Ganesh Ajjanagadde wrote: >>> It has been demonstrated that using libc provided floating point >>> functions is beneficial, in the context of fabs() vs F

[FFmpeg-devel] [PATCH] avfilter/af_flanger: free frame on ENOMEM

2015-10-15 Thread Kyle Swanson
Signed-off-by: Kyle Swanson --- libavfilter/af_flanger.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavfilter/af_flanger.c b/libavfilter/af_flanger.c index 39d4e7b..f8ec830 100644 --- a/libavfilter/af_flanger.c +++ b/libavfilter/af_flanger.c @@ -149,8 +149,10 @@ stat

Re: [FFmpeg-devel] [PATCH] configure, avutil/libm: add fmax, fmaxf, fmin, fminf support

2015-10-15 Thread Hendrik Leppkes
On Thu, Oct 15, 2015 at 4:04 PM, Derek Buitenhuis wrote: > On 10/15/2015 1:18 PM, Ganesh Ajjanagadde wrote: >> It has been demonstrated that using libc provided floating point >> functions is beneficial, in the context of fabs() vs FFABS. >> >> Unfortunately, MSVC 2012 (and earlier) lack the ISO C

[FFmpeg-devel] [PATCH 1/2] lavu/intmath.h: Add msvc/icl ctzll optimisations.

2015-10-15 Thread Matt Oliver
This patch just adds the msvc and icl equivalent ctzll optimisations to correspond with the recently added gcc variant 0001-lavu-intmath.h-Add-msvc-icl-ctzll-optimisations.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.

[FFmpeg-devel] [PATCH 2/2] lavu/intmath.h: Move x86 only msvc/icl functions to x86 specific header.

2015-10-15 Thread Matt Oliver
Some of the existing msvc/icl optimised versions for ctz and log2 use intrinsics that are only usable on x86 systems. This patch moves them from intmath.h to x86/intmath.h. This is technically where such functions should go but this will also fix any issues with trying to use msvc to compile arm co

Re: [FFmpeg-devel] [PATCH] winrt: multithreading support

2015-10-15 Thread Matt Oliver
On 15 October 2015 at 07:35, Michael Niedermayer wrote: > On Thu, Oct 15, 2015 at 02:46:21AM +0800, Wang Bin wrote: > > > > > compat/w32pthreads.h |5 + > > configure|7 +++ > > libavutil/cpu.c |8 +++- > > 3 files changed, 19 insertions(+), 1 deletion(-)

Re: [FFmpeg-devel] [PATCH] configure, avutil/libm: add fmax, fmaxf, fmin, fminf support

2015-10-15 Thread Derek Buitenhuis
On 10/15/2015 1:18 PM, Ganesh Ajjanagadde wrote: > It has been demonstrated that using libc provided floating point > functions is beneficial, in the context of fabs() vs FFABS. > > Unfortunately, MSVC 2012 (and earlier) lack the ISO C99 fmax, fmaxf, > fmin, fminf functions. This patch adds them,

Re: [FFmpeg-devel] [PATCH] avfilter: add setfps filter

2015-10-15 Thread Nicholas Robbins
> On Thursday, October 15, 2015 7:18 AM, Paul B Mahol wrote: > > On 10/15/15, Nicolas George wrote: >> Le quartidi 24 vendemiaire, an CCXXIV, Paul B Mahol a ecrit : >>> IMHO, it is far easier to use this filter than some complicated setpts >>> expression. >> >> True, but shortcuts in the se

Re: [FFmpeg-devel] [PATCH] configure, avutil/libm: add fmax, fmaxf, fmin, fminf support

2015-10-15 Thread Clément Bœsch
On Thu, Oct 15, 2015 at 09:10:00AM -0400, Ganesh Ajjanagadde wrote: > On Thu, Oct 15, 2015 at 8:31 AM, Clément Bœsch wrote: > > On Thu, Oct 15, 2015 at 08:18:02AM -0400, Ganesh Ajjanagadde wrote: > >> It has been demonstrated that using libc provided floating point > >> functions is beneficial, in

Re: [FFmpeg-devel] [PATCH] configure, avutil/libm: add fmax, fmaxf, fmin, fminf support

2015-10-15 Thread Carl Eugen Hoyos
Ganesh Ajjanagadde mit.edu> writes: > > Ganesh Ajjanagadde gmail.com> writes: > > > >> It has been demonstrated that using libc provided floating point > >> functions is beneficial, in the context of fabs() vs FFABS. > > > > Please provide actual numbers for this patch. > > For a change, why do

Re: [FFmpeg-devel] [PATCH] mips: disable all features in configure if no cpu is matched

2015-10-15 Thread Nedeljko Babic
>> >> On the other hand, if cpu option is used with some cpu that is not supported >> in >> the list, configuration will break since “-march” is set to that cpu value. > >Are you sure? What happen if you pass --cpu=mips32r2? Then -march will >be set to mips32r2 which is valid :-) Yes, you are co

Re: [FFmpeg-devel] [PATCH] configure, avutil/libm: add fmax, fmaxf, fmin, fminf support

2015-10-15 Thread Ronald S. Bultje
Hi, On Thu, Oct 15, 2015 at 9:10 AM, Ganesh Ajjanagadde wrote: > On Thu, Oct 15, 2015 at 8:31 AM, Clément Bœsch wrote: > > On Thu, Oct 15, 2015 at 08:18:02AM -0400, Ganesh Ajjanagadde wrote: > >> It has been demonstrated that using libc provided floating point > >> functions is beneficial, in t

Re: [FFmpeg-devel] [PATCH] configure, avutil/libm: add fmax, fmaxf, fmin, fminf support

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 9:10 AM, Ganesh Ajjanagadde wrote: > On Thu, Oct 15, 2015 at 8:31 AM, Clément Bœsch wrote: >> On Thu, Oct 15, 2015 at 08:18:02AM -0400, Ganesh Ajjanagadde wrote: >>> It has been demonstrated that using libc provided floating point >>> functions is beneficial, in the contex

Re: [FFmpeg-devel] [PATCH] configure, avutil/libm: add fmax, fmaxf, fmin, fminf support

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 8:20 AM, Carl Eugen Hoyos wrote: > Ganesh Ajjanagadde gmail.com> writes: > >> It has been demonstrated that using libc provided floating point >> functions is beneficial, in the context of fabs() vs FFABS. > > Please provide actual numbers for this patch. For a change, wh

Re: [FFmpeg-devel] [PATCH] configure, avutil/libm: add fmax, fmaxf, fmin, fminf support

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 8:31 AM, Clément Bœsch wrote: > On Thu, Oct 15, 2015 at 08:18:02AM -0400, Ganesh Ajjanagadde wrote: >> It has been demonstrated that using libc provided floating point >> functions is beneficial, in the context of fabs() vs FFABS. >> >> Unfortunately, MSVC 2012 (and earlier

Re: [FFmpeg-devel] [PATCH] vp9: use AVFrame.buf[0] to check if a frame is valid

2015-10-15 Thread Ronald S. Bultje
Hi, On Thu, Oct 15, 2015 at 8:02 AM, Hendrik Leppkes wrote: > AVFrame.data[0] is not guaranteed to be set with a HWAccel > --- > libavcodec/vp9.c | 46 +++--- > 1 file changed, 23 insertions(+), 23 deletions(-) Obscure. But OK. Is this documented in the

Re: [FFmpeg-devel] [PATCH] configure, avutil/libm: add fmax, fmaxf, fmin, fminf support

2015-10-15 Thread Clément Bœsch
On Thu, Oct 15, 2015 at 08:18:02AM -0400, Ganesh Ajjanagadde wrote: > It has been demonstrated that using libc provided floating point > functions is beneficial, in the context of fabs() vs FFABS. > > Unfortunately, MSVC 2012 (and earlier) lack the ISO C99 fmax, fmaxf, > fmin, fminf functions. Thi

  1   2   >