Re: [FFmpeg-devel] [PATCH] avfilter, swresample, swscale: use fabs, fabsf instead of FFABS

2015-10-15 Thread Hendrik Leppkes
On Thu, Oct 15, 2015 at 12:53 PM, Ganesh Ajjanagadde wrote: > On Thu, Oct 15, 2015 at 6:50 AM, Hendrik Leppkes wrote: >> On Thu, Oct 15, 2015 at 12:41 PM, Ganesh Ajjanagadde >> wrote: >>> On Thu, Oct 15, 2015 at 6:37 AM, Hendrik Leppkes

[FFmpeg-devel] [PATCH] ffmpeg_dxva2: set AVFrame.data[0] to the surface pointer as well

2015-10-15 Thread Hendrik Leppkes
Some decoders specifically test if data[0] is set to check if a frame is valid. This allows these checks to pass and decoding to continue. --- ffmpeg_dxva2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ffmpeg_dxva2.c b/ffmpeg_dxva2.c index 905bf89..8641a0d 100644 --- a/ffmpeg_dxva2.c +++

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/internal: Doxygen for ff_fmt_is_in

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 1:45 AM, Timothy Gu wrote: > On Wed, Oct 14, 2015 at 8:05 PM Ganesh Ajjanagadde > wrote: >> This clarifies and Doxygen's the comment for ff_fmt_is_in. > > ^ > gajjanag.c:1:23: error: unexpected token

Re: [FFmpeg-devel] [PATCH] mips: disable all features in configure if no cpu is matched

2015-10-15 Thread Nedeljko Babic
Hello, >Signed-off-by: Vicente Olivert Riera >--- > configure |9 + > 1 files changed, 9 insertions(+), 0 deletions(-) > >diff --git a/configure b/configure >index 7e55e92..cd27ad7 100755 >--- a/configure >+++ b/configure >@@ -4130,6 +4130,15 @@ elif enabled

Re: [FFmpeg-devel] [PATCH] configure, avutil/libm: add fmax, fmaxf, fmin, fminf support

2015-10-15 Thread Clément Bœsch
On Thu, Oct 15, 2015 at 08:18:02AM -0400, Ganesh Ajjanagadde wrote: > It has been demonstrated that using libc provided floating point > functions is beneficial, in the context of fabs() vs FFABS. > > Unfortunately, MSVC 2012 (and earlier) lack the ISO C99 fmax, fmaxf, > fmin, fminf functions.

Re: [FFmpeg-devel] [PATCH] avfilter, swresample, swscale: use fabs, fabsf instead of FFABS

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 6:50 AM, Hendrik Leppkes wrote: > On Thu, Oct 15, 2015 at 12:41 PM, Ganesh Ajjanagadde wrote: >> On Thu, Oct 15, 2015 at 6:37 AM, Hendrik Leppkes wrote: >>> On Thu, Oct 15, 2015 at 12:34 PM, Ganesh Ajjanagadde

Re: [FFmpeg-devel] [PATCH] avfilter: add setfps filter

2015-10-15 Thread Paul B Mahol
On 10/15/15, Nicolas George wrote: > Le quartidi 24 vendemiaire, an CCXXIV, Paul B Mahol a ecrit : >> IMHO, it is far easier to use this filter than some complicated setpts >> expression. > > True, but shortcuts in the setpts filter would be a better solution for > that: having a

Re: [FFmpeg-devel] [PATCH] avfilter, swresample, swscale: use fabs, fabsf instead of FFABS

2015-10-15 Thread Ganesh Ajjanagadde
On Wed, Oct 14, 2015 at 6:50 AM, Hendrik Leppkes wrote: > On Wed, Oct 14, 2015 at 12:37 PM, Ganesh Ajjanagadde wrote: >> On Wed, Oct 14, 2015 at 5:01 AM, Matt Oliver wrote: >>> On 14 October 2015 at 09:46, Ganesh Ajjanagadde

Re: [FFmpeg-devel] [PATCH] avfilter, swresample, swscale: use fabs, fabsf instead of FFABS

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 6:37 AM, Hendrik Leppkes wrote: > On Thu, Oct 15, 2015 at 12:34 PM, Ganesh Ajjanagadde wrote: >> On Wed, Oct 14, 2015 at 6:50 AM, Hendrik Leppkes wrote: >>> On Wed, Oct 14, 2015 at 12:37 PM, Ganesh Ajjanagadde

Re: [FFmpeg-devel] [PATCH] avfilter, swresample, swscale: use fabs, fabsf instead of FFABS

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 6:41 AM, Ganesh Ajjanagadde wrote: > On Thu, Oct 15, 2015 at 6:37 AM, Hendrik Leppkes wrote: >> On Thu, Oct 15, 2015 at 12:34 PM, Ganesh Ajjanagadde >> wrote: >>> On Wed, Oct 14, 2015 at 6:50 AM, Hendrik Leppkes

Re: [FFmpeg-devel] [PATCH] avfilter, swresample, swscale: use fabs, fabsf instead of FFABS

2015-10-15 Thread Hendrik Leppkes
On Thu, Oct 15, 2015 at 12:41 PM, Ganesh Ajjanagadde wrote: > On Thu, Oct 15, 2015 at 6:37 AM, Hendrik Leppkes wrote: >> On Thu, Oct 15, 2015 at 12:34 PM, Ganesh Ajjanagadde >> wrote: >>> On Wed, Oct 14, 2015 at 6:50 AM, Hendrik Leppkes

[FFmpeg-devel] [PATCH] vp9: use AVFrame.buf[0] to check if a frame is valid

2015-10-15 Thread Hendrik Leppkes
AVFrame.data[0] is not guaranteed to be set with a HWAccel --- libavcodec/vp9.c | 46 +++--- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c index 27fb956..3753e89 100644 --- a/libavcodec/vp9.c +++

Re: [FFmpeg-devel] [PATCH] mips: disable all features in configure if no cpu is matched

2015-10-15 Thread Vicente Olivert Riera
Dear Nedeljko Babic, On 10/15/2015 01:05 PM, Nedeljko Babic wrote: > Hello, > >> Signed-off-by: Vicente Olivert Riera >> --- >> configure |9 + >> 1 files changed, 9 insertions(+), 0 deletions(-) >> >> diff --git a/configure b/configure >> index

Re: [FFmpeg-devel] [PATCH] configure, avutil/libm: add fmax, fmaxf, fmin, fminf support

2015-10-15 Thread Carl Eugen Hoyos
Ganesh Ajjanagadde gmail.com> writes: > It has been demonstrated that using libc provided floating point > functions is beneficial, in the context of fabs() vs FFABS. Please provide actual numbers for this patch. Carl Eugen ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH] avfilter: add setfps filter

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 5:56 AM, Nicolas George wrote: > Le quartidi 24 vendémiaire, an CCXXIV, Paul B Mahol a écrit : >> IMHO, it is far easier to use this filter than some complicated setpts >> expression. > > True, but shortcuts in the setpts filter would be a better solution

Re: [FFmpeg-devel] [PATCH] configure, avutil/libm: add fmax, fmaxf, fmin, fminf support

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 8:31 AM, Clément Bœsch wrote: > On Thu, Oct 15, 2015 at 08:18:02AM -0400, Ganesh Ajjanagadde wrote: >> It has been demonstrated that using libc provided floating point >> functions is beneficial, in the context of fabs() vs FFABS. >> >> Unfortunately, MSVC

Re: [FFmpeg-devel] [PATCH] avfilter, swresample, swscale: use fabs, fabsf instead of FFABS

2015-10-15 Thread Ganesh Ajjanagadde
On Wed, Oct 14, 2015 at 6:53 AM, Hendrik Leppkes wrote: > On Wed, Oct 14, 2015 at 12:49 PM, Carl Eugen Hoyos wrote: >> Ganesh Ajjanagadde mit.edu> writes: >> >>> What? My numbers actually show that the new code may be faster - >> >> No, you are

Re: [FFmpeg-devel] [PATCH] avfilter, swresample, swscale: use fabs, fabsf instead of FFABS

2015-10-15 Thread Hendrik Leppkes
On Thu, Oct 15, 2015 at 12:34 PM, Ganesh Ajjanagadde wrote: > On Wed, Oct 14, 2015 at 6:50 AM, Hendrik Leppkes wrote: >> On Wed, Oct 14, 2015 at 12:37 PM, Ganesh Ajjanagadde >> wrote: >>> On Wed, Oct 14, 2015 at 5:01 AM, Matt Oliver

Re: [FFmpeg-devel] [PATCH] avfilter, swresample, swscale: use fabs, fabsf instead of FFABS

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 6:57 AM, Hendrik Leppkes wrote: > On Thu, Oct 15, 2015 at 12:53 PM, Ganesh Ajjanagadde wrote: >> On Thu, Oct 15, 2015 at 6:50 AM, Hendrik Leppkes wrote: >>> On Thu, Oct 15, 2015 at 12:41 PM, Ganesh Ajjanagadde

Re: [FFmpeg-devel] [PATCH] ffmpeg_dxva2: set AVFrame.data[0] to the surface pointer as well

2015-10-15 Thread Hendrik Leppkes
On Thu, Oct 15, 2015 at 1:29 PM, Hendrik Leppkes wrote: > Some decoders specifically test if data[0] is set to check if a frame is > valid. This allows these checks to pass and decoding to continue. > --- > ffmpeg_dxva2.c | 1 + > 1 file changed, 1 insertion(+) > > diff

[FFmpeg-devel] [PATCH] configure, avutil/libm: add fmax, fmaxf, fmin, fminf support

2015-10-15 Thread Ganesh Ajjanagadde
It has been demonstrated that using libc provided floating point functions is beneficial, in the context of fabs() vs FFABS. Unfortunately, MSVC 2012 (and earlier) lack the ISO C99 fmax, fmaxf, fmin, fminf functions. This patch adds them, thus making their usage in FFmpeg safe. Signed-off-by:

Re: [FFmpeg-devel] [PATCH] vp9: use AVFrame.buf[0] to check if a frame is valid

2015-10-15 Thread Ronald S. Bultje
Hi, On Thu, Oct 15, 2015 at 8:02 AM, Hendrik Leppkes wrote: > AVFrame.data[0] is not guaranteed to be set with a HWAccel > --- > libavcodec/vp9.c | 46 +++--- > 1 file changed, 23 insertions(+), 23 deletions(-) Obscure. But OK. Is

Re: [FFmpeg-devel] [PATCH] Stream specifier enhancement

2015-10-15 Thread Bodecs Bela
Dear Marton Balint, thank you for your feedback. See my comments below. 2015.10.14. 1:20 keltezéssel, Marton Balint írta: On Tue, 13 Oct 2015, Bodecs Bela wrote: Dear Marton Balint, 2015.10.12. 23:07 keltezéssel, Marton Balint írta: On Mon, 12 Oct 2015, Bodecs Bela wrote: Dear All,

Re: [FFmpeg-devel] [PATCH] avfilter: add setfps filter

2015-10-15 Thread Paul B Mahol
On 10/15/15, Nicolas George wrote: > Le quartidi 24 vendemiaire, an CCXXIV, Paul B Mahol a ecrit : >> But not framerate. > > Yes, framerate. Please, could you make a little bit of effort so that this > can be a two-sided discussion? > > The following command produces a 40-FPS

Re: [FFmpeg-devel] [PATCH] avfilter: add setfps filter

2015-10-15 Thread Nicolas George
Le quartidi 24 vendémiaire, an CCXXIV, Paul B Mahol a écrit : > IMHO, it is far easier to use this filter than some complicated setpts > expression. True, but shortcuts in the setpts filter would be a better solution for that: having a bunch of filters that do slightly different things with the

Re: [FFmpeg-devel] [PATCH] avfilter: add setfps filter

2015-10-15 Thread Nicolas George
Le quartidi 24 vendémiaire, an CCXXIV, Paul B Mahol a écrit : > But not framerate. Yes, framerate. Please, could you make a little bit of effort so that this can be a two-sided discussion? The following command produces a 40-FPS Matroska file, and the next one transforms it into a 25-FPS file:

Re: [FFmpeg-devel] [PATCH] avfilter: add setfps filter

2015-10-15 Thread Nicolas George
Le quartidi 24 vendémiaire, an CCXXIV, Paul B Mahol a écrit : > This filter sets outlink->frame_rate. Does any of your solutions do that? Oh, THAT's what you were talking about! Do you realize that this field is purely informational? Having a dedicated filter to set it seems like utter overkill.

Re: [FFmpeg-devel] [PATCH] avfilter: add setfps filter

2015-10-15 Thread Paul B Mahol
On 10/15/15, Nicolas George wrote: > Le quartidi 24 vendemiaire, an CCXXIV, Paul B Mahol a ecrit : >> Timebase and stream framerate are same. > > Not at all. For Matroska, timebase is usually 1/1000; for MPEG-[PT]S, > timebase is 1/9; timebase can also be set using settb.

Re: [FFmpeg-devel] [PATCH] avfilter: add setfps filter

2015-10-15 Thread Paul B Mahol
On 10/15/15, Nicolas George wrote: > Le quartidi 24 vendemiaire, an CCXXIV, Paul B Mahol a ecrit : >> This filter sets outlink->frame_rate. Does any of your solutions do that? > > Oh, THAT's what you were talking about! > > Do you realize that this field is purely informational?

Re: [FFmpeg-devel] [PATCH] configure, avutil/libm: add fmax, fmaxf, fmin, fminf support

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 9:10 AM, Ganesh Ajjanagadde wrote: > On Thu, Oct 15, 2015 at 8:31 AM, Clément Bœsch wrote: >> On Thu, Oct 15, 2015 at 08:18:02AM -0400, Ganesh Ajjanagadde wrote: >>> It has been demonstrated that using libc provided floating point >>>

[FFmpeg-devel] [PATCH 2/2] lavu/intmath.h: Move x86 only msvc/icl functions to x86 specific header.

2015-10-15 Thread Matt Oliver
Some of the existing msvc/icl optimised versions for ctz and log2 use intrinsics that are only usable on x86 systems. This patch moves them from intmath.h to x86/intmath.h. This is technically where such functions should go but this will also fix any issues with trying to use msvc to compile arm

[FFmpeg-devel] [PATCH 1/2] lavu/intmath.h: Add msvc/icl ctzll optimisations.

2015-10-15 Thread Matt Oliver
This patch just adds the msvc and icl equivalent ctzll optimisations to correspond with the recently added gcc variant 0001-lavu-intmath.h-Add-msvc-icl-ctzll-optimisations.patch Description: Binary data ___ ffmpeg-devel mailing list

[FFmpeg-devel] QSV dynamically linked on linux

2015-10-15 Thread Julien Fond
Hi all, I'm using QuickSync and FFmpeg on linux. It works well for encoding and decoding when I build it with --enable-static. But when I build it with --enable-shared, it hangs. So my question is: is it supposed to work when dynamically linked? Thanks in advance, Julien

[FFmpeg-devel] [PATCH] avfilter/af_flanger: free frame on ENOMEM

2015-10-15 Thread Kyle Swanson
Signed-off-by: Kyle Swanson --- libavfilter/af_flanger.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavfilter/af_flanger.c b/libavfilter/af_flanger.c index 39d4e7b..f8ec830 100644 --- a/libavfilter/af_flanger.c +++ b/libavfilter/af_flanger.c @@ -149,8

Re: [FFmpeg-devel] [PATCH] configure, avutil/libm: add fmax, fmaxf, fmin, fminf support

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 10:18 AM, Hendrik Leppkes wrote: > On Thu, Oct 15, 2015 at 4:04 PM, Derek Buitenhuis > wrote: >> On 10/15/2015 1:18 PM, Ganesh Ajjanagadde wrote: >>> It has been demonstrated that using libc provided floating point >>>

Re: [FFmpeg-devel] [PATCH] configure, avutil/libm: add fmax, fmaxf, fmin, fminf support

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 11:12 AM, Ganesh Ajjanagadde wrote: > On Thu, Oct 15, 2015 at 10:18 AM, Hendrik Leppkes wrote: >> On Thu, Oct 15, 2015 at 4:04 PM, Derek Buitenhuis >> wrote: >>> On 10/15/2015 1:18 PM, Ganesh Ajjanagadde

Re: [FFmpeg-devel] [PATCH] configure, avutil/libm: add fmax, fmaxf, fmin, fminf support

2015-10-15 Thread Carl Eugen Hoyos
Ganesh Ajjanagadde mit.edu> writes: > > Ganesh Ajjanagadde gmail.com> writes: > > > >> It has been demonstrated that using libc provided floating point > >> functions is beneficial, in the context of fabs() vs FFABS. > > > > Please provide actual numbers for this patch. > > For a change, why

Re: [FFmpeg-devel] [PATCH] configure, avutil/libm: add fmax, fmaxf, fmin, fminf support

2015-10-15 Thread Derek Buitenhuis
On 10/15/2015 1:18 PM, Ganesh Ajjanagadde wrote: > It has been demonstrated that using libc provided floating point > functions is beneficial, in the context of fabs() vs FFABS. > > Unfortunately, MSVC 2012 (and earlier) lack the ISO C99 fmax, fmaxf, > fmin, fminf functions. This patch adds them,

Re: [FFmpeg-devel] [PATCH] winrt: multithreading support

2015-10-15 Thread Matt Oliver
On 15 October 2015 at 07:35, Michael Niedermayer wrote: > On Thu, Oct 15, 2015 at 02:46:21AM +0800, Wang Bin wrote: > > > > > compat/w32pthreads.h |5 + > > configure|7 +++ > > libavutil/cpu.c |8 +++- > > 3 files changed, 19

Re: [FFmpeg-devel] [PATCH] configure, avutil/libm: add fmax, fmaxf, fmin, fminf support

2015-10-15 Thread Hendrik Leppkes
On Thu, Oct 15, 2015 at 4:04 PM, Derek Buitenhuis wrote: > On 10/15/2015 1:18 PM, Ganesh Ajjanagadde wrote: >> It has been demonstrated that using libc provided floating point >> functions is beneficial, in the context of fabs() vs FFABS. >> >> Unfortunately, MSVC 2012

Re: [FFmpeg-devel] [PATCH] mips: disable all features in configure if no cpu is matched

2015-10-15 Thread Nedeljko Babic
>> >> On the other hand, if cpu option is used with some cpu that is not supported >> in >> the list, configuration will break since “-march” is set to that cpu value. > >Are you sure? What happen if you pass --cpu=mips32r2? Then -march will >be set to mips32r2 which is valid :-) Yes, you are

Re: [FFmpeg-devel] [PATCH] configure, avutil/libm: add fmax, fmaxf, fmin, fminf support

2015-10-15 Thread Clément Bœsch
On Thu, Oct 15, 2015 at 09:10:00AM -0400, Ganesh Ajjanagadde wrote: > On Thu, Oct 15, 2015 at 8:31 AM, Clément Bœsch wrote: > > On Thu, Oct 15, 2015 at 08:18:02AM -0400, Ganesh Ajjanagadde wrote: > >> It has been demonstrated that using libc provided floating point > >> functions is

Re: [FFmpeg-devel] [PATCH] avfilter: add setfps filter

2015-10-15 Thread Nicholas Robbins
> On Thursday, October 15, 2015 7:18 AM, Paul B Mahol wrote: > > On 10/15/15, Nicolas George wrote: >> Le quartidi 24 vendemiaire, an CCXXIV, Paul B Mahol a ecrit : >>> IMHO, it is far easier to use this filter than some complicated setpts >>> expression.

Re: [FFmpeg-devel] [PATCH] configure, avutil/libm: add fmax, fmaxf, fmin, fminf support

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 8:20 AM, Carl Eugen Hoyos wrote: > Ganesh Ajjanagadde gmail.com> writes: > >> It has been demonstrated that using libc provided floating point >> functions is beneficial, in the context of fabs() vs FFABS. > > Please provide actual numbers for this

Re: [FFmpeg-devel] [PATCH] configure, avutil/libm: add fmax, fmaxf, fmin, fminf support

2015-10-15 Thread Ronald S. Bultje
Hi, On Thu, Oct 15, 2015 at 9:10 AM, Ganesh Ajjanagadde wrote: > On Thu, Oct 15, 2015 at 8:31 AM, Clément Bœsch wrote: > > On Thu, Oct 15, 2015 at 08:18:02AM -0400, Ganesh Ajjanagadde wrote: > >> It has been demonstrated that using libc provided floating point >

Re: [FFmpeg-devel] [PATCH] avfilter, swresample, swscale: use fabs, fabsf instead of FFABS

2015-10-15 Thread Ganesh Ajjanagadde
On Wed, Oct 14, 2015 at 6:54 AM, Carl Eugen Hoyos wrote: > Hendrik Leppkes gmail.com> writes: > >> One thing I don't understand - why are we bothering >> with something that at best comes out as "same speed" >> from tests performed? (low number of runs are >> irrelevant as they

[FFmpeg-devel] [PATCH] avutil/wchar_filename: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
Current code is fine, this just adds robustness. Signed-off-by: Ganesh Ajjanagadde --- libavutil/wchar_filename.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/wchar_filename.h b/libavutil/wchar_filename.h index c553c46..2ade321 100644 ---

Re: [FFmpeg-devel] [PATCH] avutil/parseutils: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 8:06 PM, James Almer wrote: > On 10/15/2015 8:52 PM, Ganesh Ajjanagadde wrote: >> This triggers a few warnings that will need to be fixed - not that bad, >> the current code is mostly fine. >> > > I think i asked you before, but in any case i'll do it

Re: [FFmpeg-devel] [PATCH] avutil/parseutils: add av_warn_unused_result

2015-10-15 Thread Michael Niedermayer
On Thu, Oct 15, 2015 at 08:15:20PM -0400, Ganesh Ajjanagadde wrote: > On Thu, Oct 15, 2015 at 8:06 PM, James Almer wrote: > > On 10/15/2015 8:52 PM, Ganesh Ajjanagadde wrote: > >> This triggers a few warnings that will need to be fixed - not that bad, > >> the current code is

Re: [FFmpeg-devel] [PATCH 1/2] lavu/intmath.h: Add msvc/icl ctzll optimisations.

2015-10-15 Thread Matt Oliver
On 16 October 2015 at 09:46, James Almer wrote: > On 10/15/2015 7:25 PM, Matt Oliver wrote: > > ICC defines __GNUC__ but ICL does not! ICC (being the linux variant) > > supports all the same functions as gcc so theres no need in this case for > > special handling. However ICL

Re: [FFmpeg-devel] [PATCH] fix b frame n_quant_offset

2015-10-15 Thread Agatha Hu
在 2015/10/9 17:38, Agatha Hu 写道: --- libavcodec/nvenc.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 18bcd96..0e6ef43 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -742,8 +742,6 @@ static av_cold int

[FFmpeg-devel] [PATCHv2] avutil/buffer: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
Signed-off-by: Ganesh Ajjanagadde --- libavutil/buffer.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavutil/buffer.h b/libavutil/buffer.h index b4399fd..e0dbc8a 100644 --- a/libavutil/buffer.h +++ b/libavutil/buffer.h @@ -26,6 +26,7 @@ #define

[FFmpeg-devel] [PATCH] avutil/pixdesc: add av_warn_unused_result to av_pix_fmt_get_chroma_sub_sample

2015-10-15 Thread Ganesh Ajjanagadde
This will trigger a bunch of warnings (rightfully so). This API has been abused, see the Doxygen comment above for what to do if the error code is not meant to be checked. Signed-off-by: Ganesh Ajjanagadde --- libavutil/pixdesc.h | 1 + 1 file changed, 1 insertion(+)

Re: [FFmpeg-devel] [PATCH] avutil/cast5: update Doxygen for av_castt_init with return information

2015-10-15 Thread Michael Niedermayer
On Thu, Oct 15, 2015 at 05:44:49PM -0400, Ganesh Ajjanagadde wrote: > Signed-off-by: Ganesh Ajjanagadde > --- > libavutil/cast5.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavutil/cast5.h b/libavutil/cast5.h > index e5cc8b1..68513e5 100644 > ---

Re: [FFmpeg-devel] [PATCH 2/2] swresample/swresample_internal: add av_warn_unused_result

2015-10-15 Thread Michael Niedermayer
On Thu, Oct 15, 2015 at 09:32:18PM -0400, Ganesh Ajjanagadde wrote: > This will trigger a few warnings that need to be fixed. > > Signed-off-by: Ganesh Ajjanagadde > --- > libswresample/swresample_internal.h | 4 > 1 file changed, 4 insertions(+) LGTM thanks

[FFmpeg-devel] [PATCH 08/11] avdevice/oss: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
This does not trigger any warnings, but adds robustness. Signed-off-by: Ganesh Ajjanagadde --- libavdevice/oss.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavdevice/oss.h b/libavdevice/oss.h index 1f3f5e4..c5eab75 100644 --- a/libavdevice/oss.h +++

[FFmpeg-devel] [PATCH 11/11] avdevice/decklink_dec: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
This should not trigger any warnings, but adds robustness. Untested. Signed-off-by: Ganesh Ajjanagadde --- libavdevice/decklink_dec.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavdevice/decklink_dec.h b/libavdevice/decklink_dec.h index 6bd9226..b19bdc6 100644

Re: [FFmpeg-devel] [PATCH 2/2] swresample/swresample_internal: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 10:04 PM, Michael Niedermayer wrote: > On Thu, Oct 15, 2015 at 09:32:18PM -0400, Ganesh Ajjanagadde wrote: >> This will trigger a few warnings that need to be fixed. >> >> Signed-off-by: Ganesh Ajjanagadde >> --- >>

[FFmpeg-devel] [PATCH] version.sh: add note that ffversion.h is auto-generated

2015-10-15 Thread Ganesh Ajjanagadde
Signed-off-by: Ganesh Ajjanagadde --- version.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/version.sh b/version.sh index f9754eb..a9d7e39 100755 --- a/version.sh +++ b/version.sh @@ -54,6 +54,7 @@ GUARD=$(echo "$2" | sed 's/\//_/' | sed 's/\./_/' | tr

[FFmpeg-devel] [PATCH 1/2] swscale/swscale_internal: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
This triggers a few warnings that need to be fixed. Signed-off-by: Ganesh Ajjanagadde --- libswscale/swscale_internal.h | 8 1 file changed, 8 insertions(+) diff --git a/libswscale/swscale_internal.h b/libswscale/swscale_internal.h index 27a40af..6e4d031 100644

[FFmpeg-devel] [PATCH 2/2] swscale/swscale: add av_warn_unused_result to sws_init_context

2015-10-15 Thread Ganesh Ajjanagadde
This should not trigger any warnings; but adds robustness. Signed-off-by: Ganesh Ajjanagadde --- libswscale/swscale.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libswscale/swscale.h b/libswscale/swscale.h index ff3f630..da9dd2e 100644 --- a/libswscale/swscale.h

Re: [FFmpeg-devel] [PATCH] avutil/opencl: add av_warn_unused_result

2015-10-15 Thread highgod0401
From: Ganesh Ajjanagadde Date: 2015-10-16 08:08 To: ffmpeg-devel CC: Ganesh Ajjanagadde Subject: [FFmpeg-devel] [PATCH] avutil/opencl: add av_warn_unused_result This will trigger a few warnings. My config does not compile the opencl code, so this is untested. Signed-off-by: Ganesh Ajjanagadde

[FFmpeg-devel] [PATCH] avutil/crc: add av_warn_unused_result to av_crc_init

2015-10-15 Thread Ganesh Ajjanagadde
This triggers useful warnings in avcodec/mlp that need to be fixed. Signed-off-by: Ganesh Ajjanagadde --- libavutil/crc.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/crc.h b/libavutil/crc.h index e86bf1d..75929b2 100644 --- a/libavutil/crc.h +++

Re: [FFmpeg-devel] [PATCH] avutil/sha512: add av_warn_unused_result to av_sha512_init

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 7:37 PM, Ganesh Ajjanagadde wrote: > This will trigger some useful warnings in avutil/hash that need to be fixed. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavutil/sha512.h | 1 + > 1 file changed, 1 insertion(+) > >

[FFmpeg-devel] [PATCH] avutil/parseutils: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
This triggers a few warnings that will need to be fixed - not that bad, the current code is mostly fine. Signed-off-by: Ganesh Ajjanagadde --- libavutil/parseutils.h | 5 + 1 file changed, 5 insertions(+) diff --git a/libavutil/parseutils.h b/libavutil/parseutils.h

[FFmpeg-devel] [PATCH 2/2] swresample/swresample_internal: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
This will trigger a few warnings that need to be fixed. Signed-off-by: Ganesh Ajjanagadde --- libswresample/swresample_internal.h | 4 1 file changed, 4 insertions(+) diff --git a/libswresample/swresample_internal.h b/libswresample/swresample_internal.h index

Re: [FFmpeg-devel] [PATCH 2/2] lavu/intmath.h: Move x86 only msvc/icl functions to x86 specific header.

2015-10-15 Thread Matt Oliver
On 16 October 2015 at 01:10, Matt Oliver wrote: > Some of the existing msvc/icl optimised versions for ctz and log2 use > intrinsics that are only usable on x86 systems. This patch moves them from > intmath.h to x86/intmath.h. This is technically where such functions should

[FFmpeg-devel] [PATCH 1/2] swresample/swresample: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
This will trigger a few warnings (e.g in avfilter) that need to be fixed. Signed-off-by: Ganesh Ajjanagadde --- libswresample/swresample.h | 9 + 1 file changed, 9 insertions(+) diff --git a/libswresample/swresample.h b/libswresample/swresample.h index

[FFmpeg-devel] [PATCH 03/11] avdevice/sndio: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
This does not trigger any warnings, but adds robustness. Untested, as my configure does not compile this file. Signed-off-by: Ganesh Ajjanagadde --- libavdevice/sndio.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavdevice/sndio.h b/libavdevice/sndio.h index

[FFmpeg-devel] [PATCH 02/11] avdevice/pulse_audio_common: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
This does not trigger any warnings, but adds robustness. Signed-off-by: Ganesh Ajjanagadde --- libavdevice/pulse_audio_common.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavdevice/pulse_audio_common.h b/libavdevice/pulse_audio_common.h index

Re: [FFmpeg-devel] [PATCH] avutil/parseutils: add av_warn_unused_result

2015-10-15 Thread James Almer
On 10/15/2015 8:52 PM, Ganesh Ajjanagadde wrote: > This triggers a few warnings that will need to be fixed - not that bad, > the current code is mostly fine. > I think i asked you before, but in any case i'll do it again. Please, send patchsets contained in a single thread. You're making things

[FFmpeg-devel] usage of AV_GLUE?

2015-10-15 Thread Ganesh Ajjanagadde
Hi all, Examining libavutil/macros, there is AV_GLUE/AV_JOIN (why are there two?) defined for preprocessor token pasting. However, it is not being used anywhere, instead people have use "##". There are a number of options regarding this: 1. Start using them, and convert the ## usage to

Re: [FFmpeg-devel] [PATCH] avutil/parseutils: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 8:06 PM, James Almer wrote: > On 10/15/2015 8:52 PM, Ganesh Ajjanagadde wrote: >> This triggers a few warnings that will need to be fixed - not that bad, >> the current code is mostly fine. >> > > I think i asked you before, but in any case i'll do it

Re: [FFmpeg-devel] [PATCH] avutil/crc: add av_warn_unused_result to av_crc_init

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 9:24 PM, Michael Niedermayer wrote: > On Thu, Oct 15, 2015 at 07:32:45PM -0400, Ganesh Ajjanagadde wrote: >> This triggers useful warnings in avcodec/mlp that need to be fixed. >> >> Signed-off-by: Ganesh Ajjanagadde >> ---

Re: [FFmpeg-devel] [PATCH] avutil/parseutils: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 10:22 PM, Ganesh Ajjanagadde wrote: > On Thu, Oct 15, 2015 at 10:16 PM, James Almer wrote: >> On 10/15/2015 10:23 PM, Ganesh Ajjanagadde wrote: >>> On Thu, Oct 15, 2015 at 8:06 PM, James Almer wrote: On

[FFmpeg-devel] [PATCH 04/11] avdevice/alsa: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
This does not trigger any warnings, but adds robustness. Signed-off-by: Ganesh Ajjanagadde --- libavdevice/alsa.h | 4 1 file changed, 4 insertions(+) diff --git a/libavdevice/alsa.h b/libavdevice/alsa.h index f8b7449..cd41d96 100644 --- a/libavdevice/alsa.h +++

[FFmpeg-devel] [PATCH 05/11] avdevice/decklink_common: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
This should not trigger any warnings, but adds robustness. Untested. Signed-off-by: Ganesh Ajjanagadde --- libavdevice/decklink_common.h | 4 1 file changed, 4 insertions(+) diff --git a/libavdevice/decklink_common.h b/libavdevice/decklink_common.h index

[FFmpeg-devel] [PATCH 07/11] avdevice/avdevice: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
This triggers a bunch of warnings that need to be fixed. Signed-off-by: Ganesh Ajjanagadde --- libavdevice/avdevice.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavdevice/avdevice.h b/libavdevice/avdevice.h index 6b0446c..23611e6 100644 ---

[FFmpeg-devel] [PATCH 06/11] avdevice/decklink_enc: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
Should not trigger any warnings, but adds robustness. Untested. Signed-off-by: Ganesh Ajjanagadde --- libavdevice/decklink_enc.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavdevice/decklink_enc.h b/libavdevice/decklink_enc.h index 6086947..462e031 100644

Re: [FFmpeg-devel] usage of AV_GLUE?

2015-10-15 Thread Ronald S. Bultje
Hi, On Thu, Oct 15, 2015 at 8:37 PM, Ganesh Ajjanagadde wrote: > Hi all, > > Examining libavutil/macros, there is AV_GLUE/AV_JOIN (why are there > two?) defined for preprocessor token pasting. However, it is not being > used anywhere, instead people have use "##". There are a

[FFmpeg-devel] [PATCH] avfilter/avfilter: Error out if audio parameters change instead of failing an assert

2015-10-15 Thread Michael Niedermayer
From: Michael Niedermayer Filters which support such changes should be excluded from these checks Fixes Ticket4884 Signed-off-by: Michael Niedermayer --- libavfilter/avfilter.c | 23 +++ 1 file changed, 19 insertions(+), 4

Re: [FFmpeg-devel] [PATCH] avutil/buffer: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 6:22 PM, Ganesh Ajjanagadde wrote: > Signed-off-by: Ganesh Ajjanagadde > --- > libavutil/buffer.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavutil/buffer.h b/libavutil/buffer.h > index b4399fd..6f03677

[FFmpeg-devel] [PATCH] avutil/audio_fifo: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
This one should not trigger any warnings, but will be useful for future robustness. Signed-off-by: Ganesh Ajjanagadde --- libavutil/audio_fifo.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/audio_fifo.h b/libavutil/audio_fifo.h index d93be2a..24f91da

[FFmpeg-devel] [PATCH] avutil/sha512: add av_warn_unused_result to av_sha512_init

2015-10-15 Thread Ganesh Ajjanagadde
This will trigger some useful warnings in avutil/hash that need to be fixed. Signed-off-by: Ganesh Ajjanagadde --- libavutil/sha512.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/sha512.h b/libavutil/sha512.h index 7b08701..6aecf31 100644 ---

Re: [FFmpeg-devel] [PATCH] avutil/imgutils: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 8:52 PM, Ganesh Ajjanagadde wrote: > This will trigger a few warnings, mainly in swscale. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavutil/imgutils.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git

Re: [FFmpeg-devel] [PATCH] avutil/crc: add av_warn_unused_result to av_crc_init

2015-10-15 Thread Michael Niedermayer
On Thu, Oct 15, 2015 at 07:32:45PM -0400, Ganesh Ajjanagadde wrote: > This triggers useful warnings in avcodec/mlp that need to be fixed. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavutil/crc.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git

[FFmpeg-devel] [PATCH] avutil/frame: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
This is going to trigger a lot of warnings all over the place that need fixing. Main culprits are in avfilter, when one tries to copy a frame without checking whether src and dest formats actually are compatible. Signed-off-by: Ganesh Ajjanagadde --- libavutil/frame.h |

[FFmpeg-devel] [PATCH] avutil/opencl: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
This will trigger a few warnings. My config does not compile the opencl code, so this is untested. Signed-off-by: Ganesh Ajjanagadde --- libavutil/opencl.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavutil/opencl.h b/libavutil/opencl.h index

[FFmpeg-devel] [PATCH] avutil/imgutils: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
This will trigger a few warnings, mainly in swscale. Signed-off-by: Ganesh Ajjanagadde --- libavutil/imgutils.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavutil/imgutils.h b/libavutil/imgutils.h index 23282a3..164d0ad 100644 --- a/libavutil/imgutils.h +++

Re: [FFmpeg-devel] [PATCH] avutil/parseutils: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 10:16 PM, James Almer wrote: > On 10/15/2015 10:23 PM, Ganesh Ajjanagadde wrote: >> On Thu, Oct 15, 2015 at 8:06 PM, James Almer wrote: >>> On 10/15/2015 8:52 PM, Ganesh Ajjanagadde wrote: This triggers a few warnings that will

Re: [FFmpeg-devel] [PATCH] avutil/parseutils: add av_warn_unused_result

2015-10-15 Thread James Almer
On 10/15/2015 10:23 PM, Ganesh Ajjanagadde wrote: > On Thu, Oct 15, 2015 at 8:06 PM, James Almer wrote: >> On 10/15/2015 8:52 PM, Ganesh Ajjanagadde wrote: >>> This triggers a few warnings that will need to be fixed - not that bad, >>> the current code is mostly fine. >>> >> >>

[FFmpeg-devel] [PATCH 01/11] avdevice/internal: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
This does not trigger any warnings but adds robustness. Signed-off-by: Ganesh Ajjanagadde --- libavdevice/internal.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavdevice/internal.h b/libavdevice/internal.h index 3cd1b06..e222cf2 100644 ---

Re: [FFmpeg-devel] [PATCH] avutil/cast5: update Doxygen for av_castt_init with return information

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 10:08 PM, Michael Niedermayer wrote: > On Thu, Oct 15, 2015 at 05:44:49PM -0400, Ganesh Ajjanagadde wrote: >> Signed-off-by: Ganesh Ajjanagadde >> --- >> libavutil/cast5.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff

[FFmpeg-devel] [PATCH 09/11] avdevice/fbdev_common: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
This does not trigger any warnings, but adds robustness. Signed-off-by: Ganesh Ajjanagadde --- libavdevice/fbdev_common.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavdevice/fbdev_common.h b/libavdevice/fbdev_common.h index 7b81a8d..f19371d 100644 ---

[FFmpeg-devel] [PATCH 10/11] avdevice/dshow_capture: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde
This does not trigger any warnings, but adds robustness. Untested. Signed-off-by: Ganesh Ajjanagadde --- libavdevice/dshow_capture.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavdevice/dshow_capture.h b/libavdevice/dshow_capture.h index b17da10..7f5192b

Re: [FFmpeg-devel] [PATCH][RFC] avutil/time: add av_warn_unused_result to av_usleep

2015-10-15 Thread Hendrik Leppkes
On Thu, Oct 15, 2015 at 11:59 PM, Ganesh Ajjanagadde wrote: > av_usleep can fail. Forcing users to check the error code here may be > somewhat controversial. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavutil/time.h | 1 + > 1 file changed, 1

Re: [FFmpeg-devel] [PATCH] avutil/cast5: update Doxygen for av_castt_init with return information

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 5:44 PM, Ganesh Ajjanagadde wrote: > Signed-off-by: Ganesh Ajjanagadde > --- > libavutil/cast5.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavutil/cast5.h b/libavutil/cast5.h > index e5cc8b1..68513e5 100644

Re: [FFmpeg-devel] [PATCH][RFC] avutil/time: add av_warn_unused_result to av_usleep

2015-10-15 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 6:01 PM, Hendrik Leppkes wrote: > On Thu, Oct 15, 2015 at 11:59 PM, Ganesh Ajjanagadde > wrote: >> av_usleep can fail. Forcing users to check the error code here may be >> somewhat controversial. >> >> Signed-off-by: Ganesh

Re: [FFmpeg-devel] [PATCH 1/2] lavu/intmath.h: Add msvc/icl ctzll optimisations.

2015-10-15 Thread Matt Oliver
On 16 October 2015 at 03:47, James Almer wrote: > On 10/15/2015 11:07 AM, Matt Oliver wrote: > > This patch just adds the msvc and icl equivalent ctzll optimisations to > > correspond with the recently added gcc variant > > > > > >

[FFmpeg-devel] [PATCH] libavformat/Makefile: remove unnecessary object file from wtv demuxer

2015-10-15 Thread Hendrik Leppkes
The wtv demuxer doesn't reference any functionality from asfdec or asfcrypt --- Found another one.. libavformat/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/Makefile b/libavformat/Makefile index c58cfb4..7bcdadf 100644 --- a/libavformat/Makefile +++

  1   2   >