Re: [FFmpeg-devel] [PATCH v3] avformat/hlsenc: add hls_flag option to write segments to temporary file until complete

2017-02-06 Thread Steven Liu
2017-02-05 23:09 GMT+08:00 Steven Liu : > > > 2017-02-05 4:38 GMT+08:00 Bodecs Bela : > >> >> >> 2017.02.04. 20:45 keltezéssel, Hendrik Leppkes írta: >> >>> On Sat, Feb 4, 2017 at 6:55 PM, Aman Gupta wrote: >>> From: Aman Gupta

Re: [FFmpeg-devel] [PATCH 1/3] libavcodec/cinepakenc.c: comments cleanup (contents)

2017-02-06 Thread Michael Niedermayer
On Mon, Feb 06, 2017 at 10:51:30AM +0100, u-9...@aetey.se wrote: > On Thu, Feb 02, 2017 at 05:19:16PM +0100, Michael Niedermayer wrote: > > On Thu, Feb 02, 2017 at 04:22:28PM +0100, u-9...@aetey.se wrote: > > > On Thu, Feb 02, 2017 at 01:31:00PM +0100, Michael Niedermayer wrote: > > patch applied

[FFmpeg-devel] [PATCH] avcodec/internal: Expand the documentation for FF_CODEC_CAP_INIT_THREADSAFE

2017-02-06 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/internal.h | 9 + 1 file changed, 9 insertions(+) diff --git a/libavcodec/internal.h b/libavcodec/internal.h index c92dba472a..a72f8628db 100644 --- a/libavcodec/internal.h +++ b/libavcodec/internal.h @@ -36,6

[FFmpeg-devel] h264 bitstream corruption in videotoolbox encoder with a53cc=1

2017-02-06 Thread Aman Gupta
Last October, kernrj and I commited a series of patches to add a53cc support to the videotoolbox encoder. In using that feature over the past few months, I've discovered that the generated streams can sometimes contain random/intermittent errors. This only appears to occur on some Macs and not

Re: [FFmpeg-devel] [rfc] tasks for new ffmpeg developers

2017-02-06 Thread James Almer
On 2/6/2017 2:54 AM, Compn wrote: > people new to the project join #ffmpeg-devel and ask us for help on how > to start contributing to ffmpeg. > > usually none of us have any cohesive answers. mostly suggestions are to > review bugs or patches or code. nothing really concise or organized. > >

Re: [FFmpeg-devel] [PATCH] mov, matroskadec : Allow matroskadec & mov to share spherical parsing logic.

2017-02-06 Thread Michael Niedermayer
On Mon, Feb 06, 2017 at 09:59:58PM +, Aaron Colwell wrote: > - Extracts common spherical metadata parsing logic. > - Adds checks to enforce that only non-tiled equirect & non-padded cubemaps > are accepted. > Makefile|5 ++- > matroskadec.c | 39 ++--

Re: [FFmpeg-devel] [rfc] tasks for new ffmpeg developers

2017-02-06 Thread Compn
On Mon, 06 Feb 2017 13:22:31 +, Kieran Kunhya wrote: > On Mon, 6 Feb 2017 at 05:54 Compn wrote: > > > people new to the project join #ffmpeg-devel and ask us for help on how > > to start contributing to ffmpeg. > > > > A simple one is work on making

Re: [FFmpeg-devel] [PATCH] omx: Add support for specifying H.264 profile [v2]

2017-02-06 Thread Michael Niedermayer
On Tue, Feb 07, 2017 at 06:28:11AM +0900, Takayuki 'January June' Suwa wrote: > This adds "-profile[:v] profile_name"-style option IOW. > > Thanks for reviewing my poor ugly patch, Mark... and I get back to > an original purpose - forcing OMX to use baseline profile. > (eg. RasPiCam-to-Ustream

[FFmpeg-devel] [PATCH] omx: Add support for specifying H.264 profile [v2]

2017-02-06 Thread Takayuki 'January June' Suwa
This adds "-profile[:v] profile_name"-style option IOW. Thanks for reviewing my poor ugly patch, Mark... and I get back to an original purpose - forcing OMX to use baseline profile. (eg. RasPiCam-to-Ustream webcasting w/o additional xcoding) --- libavcodec/omx.c | 19 +++ 1

Re: [FFmpeg-devel] [PATCH] avfilter: add midequalizer filter

2017-02-06 Thread Calvin Walton
Hi, just a quick note below... On Thu, 2017-02-02 at 14:40 +0100, Paul B Mahol wrote: > > +++ b/doc/filters.texi > @@ -9643,6 +9643,17 @@ Macroblock size. Default @code{16}. >  Search parameter. Default @code{7}. >  @end table >   > +@section midequalizer > + > +Apply Midway Image Equalization

Re: [FFmpeg-devel] [PATCH] Cinepak: speed up decoding several-fold, depending on the scenario, by supporting multiple output pixel formats.

2017-02-06 Thread Clément Bœsch
On Mon, Feb 06, 2017 at 10:05:10AM +0100, u-9...@aetey.se wrote: [...] > > No, code quality is not outside the scope of your patch. > > Code quality is a subjective matter. > I'm not going to fight with you: several developers consider your patch does not pass the quality requirements of the

[FFmpeg-devel] [PATCH] Allow Data URI scheme for hls

2017-02-06 Thread fairytale
#EXT-X-KEY:METHOD=AES-128,URI="data:text/plain;charset=utf-8,abcdefgh12345678",IV=0x video-js support this and as ffurl_connect support data uri, just allow it. --- libavformat/hls.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] matroskaenc: Add support for writing video projection.

2017-02-06 Thread Aaron Colwell
Given this insistence on using a separate type, the fact that the "tiled equirect" is under specified, and folks don't actually care about the "tiled equirect" case right now could I just add code to mux the 2 cases that are already well specified? I could also send out a patch to fix the demuxers

Re: [FFmpeg-devel] Can BSF delay packets?

2017-02-06 Thread Ronald S. Bultje
Hi Aleksey, On Mon, Feb 6, 2017 at 12:14 PM, Aleksey M wrote: > Ronald, > > I looked the vp9_superframe_bsf.c code, but it doesn't help: The only place > which returns EAGAIN does output packet unref and frees input packet. > > I tried memset zero on output packet,

[FFmpeg-devel] [PATCH] lavc/h264dec: use OFFSET macro

2017-02-06 Thread Matthieu Bouron
--- libavcodec/h264dec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c index 41c0964392..da34be81cc 100644 --- a/libavcodec/h264dec.c +++ b/libavcodec/h264dec.c @@ -1072,8 +1072,8 @@ static int h264_decode_frame(AVCodecContext

[FFmpeg-devel] [PATCH] Fix chroma positioning for 4:2:0 pixel format

2017-02-06 Thread Maksym Veremeyenko
Hi, Attached patch fixes chroma positioning during scaling interlaced 4:2:0. On a first iteration default context value been overwritten by new value and not been update on next iterations for fields. This mean that vertical chroma position remain 128 for field#0 and field#1 instead of *64*

Re: [FFmpeg-devel] Can BSF delay packets?

2017-02-06 Thread Ronald S. Bultje
Hi, On Mon, Feb 6, 2017 at 9:33 AM, wm4 wrote: > On Mon, 6 Feb 2017 09:06:37 -0500 > "Ronald S. Bultje" wrote: > > > Please don't top-post. > > > > I have to admit the new BSF API is super-confusing. I think you return > > EAGAIN but you also have to

Re: [FFmpeg-devel] Can BSF delay packets?

2017-02-06 Thread wm4
On Mon, 6 Feb 2017 09:06:37 -0500 "Ronald S. Bultje" wrote: > Please don't top-post. > > I have to admit the new BSF API is super-confusing. I think you return > EAGAIN but you also have to deallocate the "out" AVPacket. See >

Re: [FFmpeg-devel] Can BSF delay packets?

2017-02-06 Thread Ronald S. Bultje
Hi Aleksey, On Mon, Feb 6, 2017 at 8:45 AM, Aleksey M wrote: > Hi Ronald. > > Thank you for replying! > > If I return 0 -- how the calling function determines that I've produced an > output packet? > > What do I do to signal caller that I don't want to produce an output >

Re: [FFmpeg-devel] Can BSF delay packets?

2017-02-06 Thread Aleksey M
Hi Ronald. Thank you for replying! If I return 0 -- how the calling function determines that I've produced an output packet? What do I do to signal caller that I don't want to produce an output packet? On Mon, Feb 6, 2017 at 3:42 PM, Ronald S. Bultje wrote: > Hi Aleksey,

Re: [FFmpeg-devel] [rfc] tasks for new ffmpeg developers

2017-02-06 Thread Kieran Kunhya
On Mon, 6 Feb 2017 at 05:54 Compn wrote: > people new to the project join #ffmpeg-devel and ask us for help on how > to start contributing to ffmpeg. > A simple one is work on making decoders threadsafe (pthread_once on static inits). Regards, Kieran

Re: [FFmpeg-devel] Can BSF delay packets?

2017-02-06 Thread Ronald S. Bultje
Hi Aleksey, On Mon, Feb 6, 2017 at 5:18 AM, Aleksey M wrote: > Hi dear FFMPEG contributors, > > Does the bitstream filter (BSF) interface allow to delay packets? > > From Luca's description > https://blogs.gentoo.org/lu_zero/2016/03/21/bitstream-filtering/ > it looks like it

[FFmpeg-devel] [PATCH v2 3/3] avcodec: estimate output bitrate for uncompressed video codecs

2017-02-06 Thread Tobias Rapp
Allows to get a more realistic total bitrate (and estimated file size) in avi_write_header. Previously a static default value of 200k was assumed. Signed-off-by: Tobias Rapp --- libavcodec/r210enc.c | 15 +++ libavcodec/rawenc.c

[FFmpeg-devel] [PATCH v2 1/3] ffmpeg_opt: pass output framerate as a hint to the encoder

2017-02-06 Thread Tobias Rapp
Sets framerate field in output codec context if explicitly specified on the command-line. Signed-off-by: Tobias Rapp --- ffmpeg_opt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ffmpeg_opt.c b/ffmpeg_opt.c index 6a47d32..3b532da 100644 --- a/ffmpeg_opt.c +++

[FFmpeg-devel] [PATCH v2 2/3] avcodec: estimate output bitrate for ffv1/huffyuv codecs

2017-02-06 Thread Tobias Rapp
Allows to get a more realistic total bitrate (and estimated file size) in avi_write_header. Previously a static default value of 200k was assumed. Signed-off-by: Tobias Rapp --- libavcodec/ffv1enc.c | 4 libavcodec/huffyuvenc.c

[FFmpeg-devel] Can BSF delay packets?

2017-02-06 Thread Aleksey M
Hi dear FFMPEG contributors, Does the bitstream filter (BSF) interface allow to delay packets? From Luca's description https://blogs.gentoo.org/lu_zero/2016/03/21/bitstream-filtering/ it looks like it can produce any number of output packets or consume any number of input packets. But any

Re: [FFmpeg-devel] [PATCH 1/3] libavcodec/cinepakenc.c: comments cleanup (contents)

2017-02-06 Thread u-9iep
On Thu, Feb 02, 2017 at 05:19:16PM +0100, Michael Niedermayer wrote: > On Thu, Feb 02, 2017 at 04:22:28PM +0100, u-9...@aetey.se wrote: > > On Thu, Feb 02, 2017 at 01:31:00PM +0100, Michael Niedermayer wrote: > patch applied > > thx Thanks Michael. What about the other patches from that series?

Re: [FFmpeg-devel] [PATCH] Cinepak: speed up decoding several-fold, depending on the scenario, by supporting multiple output pixel formats.

2017-02-06 Thread u-9iep
On Mon, Feb 06, 2017 at 07:57:25AM +0100, Clément Bœsch wrote: > On Sun, Feb 05, 2017 at 12:24:30PM +0100, u-9...@aetey.se wrote: > > Hello, > > > > Here comes an amended patch, I think all the relevant points > > in the discussion have been addressed: > > > > - maintainability and code

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: fix is_keyframe for early Blocks

2017-02-06 Thread wm4
On Fri, 3 Feb 2017 14:42:44 -0800 Chris Cunningham wrote: > Blocks are marked as key frames whenever the "reference" field is > zero. This breaks for non-keyframe Blocks with a reference timestamp > of zero. > > The likelihood of reference timestamp being zero is