Re: [FFmpeg-devel] [PATCH] libavformat/rtspdec.c: flush pes buffer while rtsp seek

2022-12-28 Thread zhilizhao(赵志立)
> On Dec 29, 2022, at 11:43, tanwei (D) wrote: > >>> >>> +if (rt->cur_transport_priv && rt->transport == >>> + RTSP_TRANSPORT_RTP) { >>> >>> +ff_rtp_seek_flush(rt->cur_transport_priv); >>> >>> +} else if (CONFIG_RTPDEC && rt->ts) { >>> >>> +av_freep(>recvbuf); >

[FFmpeg-devel] [PATCH] libavformat/rtspdec.c: flush pes buffer while rtsp seek

2022-12-28 Thread tanwei (D)
>> >> +if (rt->cur_transport_priv && rt->transport == >> + RTSP_TRANSPORT_RTP) { >> >> +ff_rtp_seek_flush(rt->cur_transport_priv); >> >> +} else if (CONFIG_RTPDEC && rt->ts) { >> >> +av_freep(>recvbuf); >Is it necessary to free rt->recvbuf? The recvbuf must be

[FFmpeg-devel] [PATCH] avformat/mux: use only valid timestamps when calculating packet distance

2022-12-28 Thread James Almer
Fixes: signed integer overflow: 0 - -9223372036854775808 cannot be represented in type 'long int' Fixes: fate-cover-art-aiff-id3v2-remux, fate-cover-art-mp3-id3v2-remux and fate-mov-cover-image under ubsan. Signed-off-by: James Almer --- libavformat/mux.c | 1 + 1 file changed, 1 insertion(+)

Re: [FFmpeg-devel] [PATCH v2 01/32] avfilter/palettegen: allow a minimum of 2 colors

2022-12-28 Thread Clément Bœsch
On Wed, Dec 28, 2022 at 10:04:26PM +0100, Tomas Härdin wrote: [...] > Does this mean all-black with transparent is disallowed? Yes a single color with or without an extra transparency slot makes no sense. > Shouldn't it be max_colors + reserve < 2? max_colors accounts for the transparent color

Re: [FFmpeg-devel] [PATCH v2 01/32] avfilter/palettegen: allow a minimum of 2 colors

2022-12-28 Thread Tomas Härdin
ons 2022-12-28 klockan 00:17 +0100 skrev Clément Bœsch: > --- >  libavfilter/vf_palettegen.c | 7 ++- >  1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/libavfilter/vf_palettegen.c > b/libavfilter/vf_palettegen.c > index 27f74fd147..c03f62b942 100644 > ---

Re: [FFmpeg-devel] Would a crypto file be acceptable?

2022-12-28 Thread Michael Niedermayer
Hi On Tue, Dec 27, 2022 at 11:46:38PM +0100, Mark Gaiser wrote: > On Tue, Dec 27, 2022 at 10:40 PM Michael Niedermayer > wrote: > > > On Wed, Dec 21, 2022 at 04:44:59PM +0100, Mark Gaiser wrote: > > > Hi, > > > > > > The ffmpeg crypto protocol handler [1] allows one to play encrypted > > media.

[FFmpeg-devel] [PATCH 2/2] avcodec/jpeg2000dec: Add support for HTJ2K decoding

2022-12-28 Thread etemesicaleb
From: caleb --- libavcodec/Makefile|2 +- libavcodec/jpeg2000.h |3 + libavcodec/jpeg2000dec.c | 69 +- libavcodec/jpeg2000htdec.c | 1425 libavcodec/jpeg2000htdec.h | 28 + 5 files changed, 1511 insertions(+), 16 deletions(-)

[FFmpeg-devel] [PATCH 1/2] avcodec/jpeg2000dec: Move decoder structs to header files.

2022-12-28 Thread etemesicaleb
From: caleb --- libavcodec/jpeg2000dec.c | 88 +--- libavcodec/jpeg2000dec.h | 121 +++ 2 files changed, 122 insertions(+), 87 deletions(-) create mode 100644 libavcodec/jpeg2000dec.h diff --git a/libavcodec/jpeg2000dec.c

Re: [FFmpeg-devel] [PATCH v2] avcodec/mediacodecdec: add AV1 decoding support

2022-12-28 Thread Zhao Zhili
On Tue, 2022-12-20 at 19:03 +0100, Tomas Härdin wrote: > mån 2022-12-19 klockan 20:45 +0800 skrev Zhao Zhili: > > From: Zhao Zhili > > > > Signed-off-by: Zhao Zhili > > --- > > configure | 2 ++ > > libavcodec/Makefile| 1 + > > libavcodec/allcodecs.c | 1 + > >

Re: [FFmpeg-devel] [PATCH v3 1/8] avformat/file: add fd option for pipe

2022-12-28 Thread Zhao Zhili
On Thu, 2022-12-15 at 01:10 +0800, Zhao Zhili wrote: > From: Zhao Zhili > > --- > doc/protocols.texi| 4 +++- > libavformat/file.c| 9 +++-- > libavformat/version.h | 2 +- > 3 files changed, 11 insertions(+), 4 deletions(-) > > diff --git a/doc/protocols.texi b/doc/protocols.texi

[FFmpeg-devel] [PATCH] avcodec/h264_mp4toannexb: fix missing SPS/PPS to IDR frames

2022-12-28 Thread Zhao Zhili
From: Zhao Zhili If there is a single group of SPS/PPS before an IDR frame, but no SPS/PPS after that, we will miss the chance to reset idr_sps_seen/idr_pps_seen. The result is missing SPS/PPS for all IDR frames except the first one. Signed-off-by: Zhao Zhili ---

Re: [FFmpeg-devel] Would a crypto file be acceptable?

2022-12-28 Thread Mark Gaiser
On Wed, Dec 28, 2022 at 5:30 PM Nicolas George wrote: > Mark Gaiser (12022-12-28): > > > Ok, that made me laugh :) > > I did not write that. And that feels rude. > > > Please correct me as I'm probably wrong. > > But where did anyone say that there was a working alternative solution > that > >

Re: [FFmpeg-devel] Would a crypto file be acceptable?

2022-12-28 Thread Nicolas George
Mark Gaiser (12022-12-28): > > Ok, that made me laugh :) I did not write that. And that feels rude. > Please correct me as I'm probably wrong. > But where did anyone say that there was a working alternative solution that > did not require customizing how ffmpeg is used? > Like disabling safe.

[FFmpeg-devel] [PATCH][RFC][CURSED] mov: Disable advanced_editlist for fragmented MP4 input

2022-12-28 Thread Derek Buitenhuis
Advanced edit list support is entirely broken for fragmented MP4s, currently. mov_fix_index is never run in mov_build_index, since in fragmented MP4s the stco, stsz, stts, and stsc boxes have zero entries, with the index being filled in as each fragment's trun box is seen. The result of this is

Re: [FFmpeg-devel] Would a crypto file be acceptable?

2022-12-28 Thread Mark Gaiser
On Wed, Dec 28, 2022 at 5:22 PM Nicolas George wrote: > Mark Gaiser (12022-12-28): > > There's definitely multiple things going on but it's not what you > summarize. > > You forgot the bit where “MU” told you your proposal was mostly > redundant, too limited and ad-hoc and would have security

Re: [FFmpeg-devel] Would a crypto file be acceptable?

2022-12-28 Thread Nicolas George
Mark Gaiser (12022-12-28): > There's definitely multiple things going on but it's not what you summarize. You forgot the bit where “MU” told you your proposal was mostly redundant, too limited and ad-hoc and would have security implications if more generic, and “DEV” conveniently ignored it. --

Re: [FFmpeg-devel] Would a crypto file be acceptable?

2022-12-28 Thread Mark Gaiser
On Wed, Dec 28, 2022 at 3:27 PM Ronald S. Bultje wrote: > Hi Mark, > > On Tue, Dec 27, 2022 at 5:47 PM Mark Gaiser wrote: > > > The tricky part here is for anyone using this scheme to play this file. > > Right now i'm doing this with a command line like: > > ffplay crypto://encrypted_file

Re: [FFmpeg-devel] [PATCH] avfilter/vf_cropdetect: add ability to change limit/reset at runtime

2022-12-28 Thread Jeffrey CHAPUIS
You need a custom function that will keep old values around and realloc the buffers for bboxes using the new reset_count value passed as a runtime command, but one that will not call config_input() like you did the first time as that one does a lot more than what you need. It should also

Re: [FFmpeg-devel] Would a crypto file be acceptable?

2022-12-28 Thread Ronald S. Bultje
Hi Mark, On Tue, Dec 27, 2022 at 5:47 PM Mark Gaiser wrote: > The tricky part here is for anyone using this scheme to play this file. > Right now i'm doing this with a command line like: > ffplay crypto://encrypted_file -decryption_key $AES_KEY -decryption_iv > $AES_IV > > For brevity's sake,

Re: [FFmpeg-devel] [PATCH] avfilter/vf_cropdetect: add ability to change limit/reset at runtime

2022-12-28 Thread James Almer
On 12/28/2022 8:02 AM, Jeffrey CHAPUIS wrote: Updated working patch with ff_filter_process_command and no memory leaks. Signed-off-by: Ashyni ---  doc/filters.texi   | 13 +  libavfilter/vf_cropdetect.c    | 15 --  

Re: [FFmpeg-devel] [PATCH] avfilter/vf_cropdetect: add ability to change limit/reset at runtime

2022-12-28 Thread Marton Balint
On Wed, 28 Dec 2022, Jeffrey CHAPUIS wrote: Updated working patch with ff_filter_process_command and no memory leaks. Signed-off-by: Ashyni --- doc/filters.texi | 13 + libavfilter/vf_cropdetect.c| 15 --

Re: [FFmpeg-devel] [PATCH] avfilter/vf_cropdetect: add ability to change limit/reset at runtime

2022-12-28 Thread Jeffrey CHAPUIS
Updated working patch with ff_filter_process_command and no memory leaks. Signed-off-by: Ashyni --- doc/filters.texi | 13 + libavfilter/vf_cropdetect.c| 15 -- tests/ref/fate/filter-metadata-cropdetect | 60 +++---

[FFmpeg-devel] 答复: [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils: add -mask_url to replace the protocol address in the command with the asterisk (*)

2022-12-28 Thread Wujian(Chin)
>On Mon, Dec 26, 2022 at 01:07:51PM +, Wujian(Chin) wrote: >> The issue has been modified. Please review again, thank you! >> >> Signed-off-by: wujian_nanjing >> --- >> doc/fftools-common-opts.texi | 11 +++ >> fftools/cmdutils.c | 77 >>