Re: [FFmpeg-devel] [PATCH v2] avutil: deprecate AVRational field inside AVOption::default_val

> 在 2023年5月2日，19:39，James Almer 写道： > > On 5/2/2023 8:34 AM, Tomas Härdin wrote: >> tis 2023-05-02 klockan 15:48 +0800 skrev Zhao Zhili: >>> From: Zhao Zhili >>> >>> Signed-off-by: Zhao Zhili >>> --- >>> libavutil/opt.h | 2 ++ >>> libavutil/version.h | 1 + >>> 2 files changed, 3

Re: [FFmpeg-devel] [PATCH] [RFC] avformat: Add basic same origin check

On Tue, May 02, 2023 at 05:57:09PM -0300, James Almer wrote: > On 5/2/2023 5:16 PM, Michael Niedermayer wrote: > > On Tue, May 02, 2023 at 05:00:29PM -0300, James Almer wrote: > > > On 5/2/2023 4:36 PM, Michael Niedermayer wrote: > > > > TODO: bump minor version, add docs > > > > > > > >

Re: [FFmpeg-devel] [PATCH] [RFC] avformat: Add basic same origin check

On 5/2/2023 5:16 PM, Michael Niedermayer wrote: On Tue, May 02, 2023 at 05:00:29PM -0300, James Almer wrote: On 5/2/2023 4:36 PM, Michael Niedermayer wrote: TODO: bump minor version, add docs Signed-off-by: Michael Niedermayer --- libavformat/avformat.h | 10 ++

[FFmpeg-devel] sendcmd filter now can send metadata

Hi! I googled tonnes of information about how to forward data from one filter to another, but nothing possible. The only way is to send some current frame data as a command with sendcmd filter, but most of it accessible by filters themselves. Most of interesting data prepared by some analysing

Re: [FFmpeg-devel] [PATCH] [RFC] avformat: Add basic same origin check

On Tue, May 02, 2023 at 05:00:29PM -0300, James Almer wrote: > On 5/2/2023 4:36 PM, Michael Niedermayer wrote: > > TODO: bump minor version, add docs > > > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/avformat.h | 10 ++ > > libavformat/options.c | 29

Re: [FFmpeg-devel] [PATCH] [RFC] avformat: Add basic same origin check

On 5/2/2023 4:36 PM, Michael Niedermayer wrote: TODO: bump minor version, add docs Signed-off-by: Michael Niedermayer --- libavformat/avformat.h | 10 ++ libavformat/options.c | 29 + libavformat/options_table.h | 3 +++ 3 files changed, 42

[FFmpeg-devel] [PATCH] [RFC] avformat: Add basic same origin check

TODO: bump minor version, add docs Signed-off-by: Michael Niedermayer --- libavformat/avformat.h | 10 ++ libavformat/options.c | 29 + libavformat/options_table.h | 3 +++ 3 files changed, 42 insertions(+) diff --git a/libavformat/avformat.h

Re: [FFmpeg-devel] [PATCH 2/8] lavu: new AVWriter API

Rémi Denis-Courmont (12023-05-02): > I think that that is pretty rich coming from you, just judging by your > earlier > responses to other people. Pointers? -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 2/8] lavu: new AVWriter API

Le tiistaina 2. toukokuuta 2023, 21.36.53 EEST Nicolas George a écrit : > The only thing dumb and confusing I see here is the mail I am answering > to. > I must say, I am impressed by the rudeness and arrogance of such a > comment without even looking at the code itself. I think that that is

Re: [FFmpeg-devel] [PATCH 1/8] lavu: add macros to help making future-proof structures

Rémi Denis-Courmont (12023-05-02): > So it must be very poorly written because C union are supposed to avoid this > cleanly. > If you need padding where any sane implementation does not, then it is > clearly > poorly written. I must say, I am impressed by the rudeness and arrogance of such a

Re: [FFmpeg-devel] [PATCH 2/8] lavu: new AVWriter API

Rémi Denis-Courmont (12023-05-02): > Please re-read the comments. You are totally misses the point. I confess so, indeed, I completely failed to understand your point after reading your comment multiple times. > Well, I'll add myself to the already long list of people publicly objecting > to >

Re: [FFmpeg-devel] [PATCH 1/8] lavu: add macros to help making future-proof structures

Le tiistaina 2. toukokuuta 2023, 19.42.39 EEST Nicolas George a écrit : > Rémi Denis-Courmont (12023-05-02): > > A JSON writer that requires forced alignment is a poorly-written JSON > > parser. > This JSON writer requires that the structures that contain its state are > aligned, just like any

Re: [FFmpeg-devel] [PATCH 2/8] lavu: new AVWriter API

Le tiistaina 2. toukokuuta 2023, 19.53.43 EEST Nicolas George a écrit : > Rémi Denis-Courmont (12023-05-02): > > Indirecting the printf function seems pretty pointless. The last thing you > > Please re-read the code, there is no other way of obtaining a va_list > from an actual argument than

Re: [FFmpeg-devel] [PATCH 2/8] lavu: new AVWriter API

Rémi Denis-Courmont (12023-05-02): > Indirecting the printf function seems pretty pointless. The last thing you Please re-read the code, there is no other way of obtaining a va_list from an actual argument than making a call to a vararg function. > want are different implementations of printf()

Re: [FFmpeg-devel] [PATCH 1/8] lavu: add macros to help making future-proof structures

Rémi Denis-Courmont (12023-05-02): > A JSON writer that requires forced alignment is a poorly-written JSON parser. This JSON writer requires that the structures that contain its state are aligned, just like any other piece of C code. There is nothing poorly-written here. > This is reinventing

Re: [FFmpeg-devel] [PATCH 1/2] riscv/bswap: use compiler builtins

Ping. -- 雷米‧德尼-库尔蒙 http://www.remlab.net/ ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/8] lavu: new AVWriter API

Le perjantaina 28. huhtikuuta 2023, 12.55.02 EEST Nicolas George a écrit : > +/** > * + * Generic API > + > *** > / + > +#define FIELDOK(st, f) ((char

Re: [FFmpeg-devel] [PATCH] MXF - Add jpeg2000 subdescriptor - Sponsored by INA

Le 27/04/2023 à 14:45, Tomas Hardin a écrit : static inline uint16_t rescale_mastering_chroma(AVRational q) { @@ -1260,7 +1305,6 @@ static int64_t mxf_write_cdci_common(AVFormatContext *s, AVStream *st, const UID f1 *= 2; } - Stray deleted line +/* Image components

Re: [FFmpeg-devel] [PATCH 4/4] fftools/ffmpeg: deprecate -re

On Tue, May 2, 2023 at 11:36 AM Timo Rothenpieler wrote: > Not sure if deprecating that option is a good idea. > It's in A LOT of guides, and in a lot of peoples scripts. > > I see no harm in keeping it around as a shorthand for a common use of > -readrate. I actually thought about making a

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/pdvdec: Check previous frame before using it

approved ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 3/3] avcodec/pdvdec: Check previous frame before using it

Fixes: load of null pointer of type 'uint8_t' (aka 'unsigned char') Fixes: 58256/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PDV_fuzzer-4776436325285888 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer

[FFmpeg-devel] [PATCH 2/3] avformat/oggparsetheora: clip duration within 64bit

Fixes: signed integer overflow: 9079256848778919936 - -288230376151711746 cannot be represented in type 'long' Fixes: 58248/clusterfuzz-testcase-minimized-ffmpeg_dem_OGG_fuzzer-6326851353313280 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

[FFmpeg-devel] [PATCH 1/3] avcodec/rka: avoid undefined multiply in cmode==0

Fixes: signed integer overflow: -182838 * 32768 cannot be represented in type 'int' Fixes: 58179/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RKA_fuzzer-5333265899978752 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

Re: [FFmpeg-devel] [PATCH 1/8] lavu: add macros to help making future-proof structures

Le perjantaina 28. huhtikuuta 2023, 12.55.01 EEST Nicolas George a écrit : > Signed-off-by: Nicolas George > --- > libavutil/extendable.h | 59 ++ > 1 file changed, 59 insertions(+) > create mode 100644 libavutil/extendable.h > > > FFReservedPadding is

Re: [FFmpeg-devel] [PATCH 4/4] fftools/ffmpeg: deprecate -re

On 02.05.2023 15:43, Anton Khirnov wrote: It is exactly equivalent to -readrate 1.0 --- Changelog | 1 + doc/ffmpeg.texi| 2 +- fftools/ffmpeg.h | 3 +++ fftools/ffmpeg_demux.c | 5 + fftools/ffmpeg_opt.c | 4 +++- 5 files changed, 13 insertions(+), 2

Re: [FFmpeg-devel] [PATCH v4 6/6] decklink_enc: add support for playout of 608 captions in MOV files

Hi Lance, On Sun, Apr 30, 2023 at 7:01 PM Lance Wang wrote: > This implementation is limited to decklink SDI output only, If possible, > can we implement the function from demuxer layer, and then passthrough > by SEI side data? By this way, we can convert such stream in streaming > to

Re: [FFmpeg-devel] [PATCH v4 5/6] vf_ccrepack: Add new filter to repack CEA-708 side data

Hi Lance, On Sun, Apr 30, 2023 at 6:42 PM Lance Wang wrote: > > On Fri, Apr 28, 2023 at 11:43 PM Devin Heitmueller < > devin.heitmuel...@ltnglobal.com> wrote: > > > THis filter can correct certain issues seen from upstream sources > > where the cc_count is not properly set or the CEA-608 tuples

[FFmpeg-devel] [PATCH 2/4] fftools/ffmpeg: use a non-zero default for -readrate_initial_burst

Use it to replace a hack added in 6f206852289. --- fftools/ffmpeg_demux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c index 37d7649da9..e6f700f6c3 100644 --- a/fftools/ffmpeg_demux.c +++ b/fftools/ffmpeg_demux.c @@ -461,7

[FFmpeg-devel] [PATCH 3/4] fftools/ffmpeg: reduce -re to -readrate 1

They are exactly equivalent, so there is no point in maintaining a separate flag for -re. --- fftools/ffmpeg.c | 2 +- fftools/ffmpeg.h | 1 - fftools/ffmpeg_demux.c | 16 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/fftools/ffmpeg.c

[FFmpeg-devel] [PATCH 1/4] fftools/ffmpeg: add ability to set a input burst time before readrate is enforced

From: Davy Durham Signed-off-by: Anton Khirnov --- Picking up this patch because it interacts with my ongoing work on ffmpeg CLI. Applied my review comments, including renaming the option to -readrate_initial_burst. CCing the original author, please let me know if you'd prefer to handle this

[FFmpeg-devel] [PATCH 4/4] fftools/ffmpeg: deprecate -re

It is exactly equivalent to -readrate 1.0 --- Changelog | 1 + doc/ffmpeg.texi| 2 +- fftools/ffmpeg.h | 3 +++ fftools/ffmpeg_demux.c | 5 + fftools/ffmpeg_opt.c | 4 +++- 5 files changed, 13 insertions(+), 2 deletions(-) diff --git a/Changelog b/Changelog index

Re: [FFmpeg-devel] [PATCH v5] avformat: add MMTP parser and MMT/TLV demuxer

I can remove the NULL checks, sure. I could change L289 in mmttlv.c to a freep and reset the priv_data. Other places have no need to change. On Tue, May 2, 2023 at 9:58 PM Paul B Mahol wrote: > Use av_freep(), non need to check for NULL before av_freep() / av_free() >

Re: [FFmpeg-devel] [PATCH v5] avformat: add MMTP parser and MMT/TLV demuxer

Use av_freep(), non need to check for NULL before av_freep() / av_free() ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] lavc/aarch64: new optimization for 8-bit hevc_pel_uni_w_pixels, qpel_uni_w_h, qpel_uni_w_v, qpel_uni_w_hv and qpel_h

Hello, Just 2 questions: - could you split this patch into several (3,4 or 5) - are all those functions checked by chekasm? Thanks, jb On Sun, 30 Apr 2023, at 10:57, myais wrote: > Hi, > This is a patch for the aarch64, which completes the neon versions of > the hevc_pel_uni_w_pixels,

[FFmpeg-devel] [PATCH v2] avcodec/mediacodec: Add AV1 encoder

Connected FFmpeg to Mediacodec AV1 encoder Minor version bump. Minor whitespaces fix. Signed-off-by: Samuel Mira samuel.m...@qt.io --- configure | 1 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 +

Re: [FFmpeg-devel] [PATCH v2] avutil: deprecate AVRational field inside AVOption::default_val

On Tue, May 2, 2023 at 1:40 PM James Almer wrote: > On 5/2/2023 8:34 AM, Tomas Härdin wrote: > > tis 2023-05-02 klockan 15:48 +0800 skrev Zhao Zhili: > >> From: Zhao Zhili > >> > >> Signed-off-by: Zhao Zhili > >> --- > >> libavutil/opt.h | 2 ++ > >> libavutil/version.h | 1 + > >> 2

Re: [FFmpeg-devel] [PATCH v2] avutil: deprecate AVRational field inside AVOption::default_val

On 5/2/2023 8:34 AM, Tomas Härdin wrote: tis 2023-05-02 klockan 15:48 +0800 skrev Zhao Zhili: From: Zhao Zhili Signed-off-by: Zhao Zhili ---  libavutil/opt.h | 2 ++  libavutil/version.h | 1 +  2 files changed, 3 insertions(+) diff --git a/libavutil/opt.h b/libavutil/opt.h index

Re: [FFmpeg-devel] [PATCH] avcodec/mediacodec: Add VP8 encoder

fre 2023-04-28 klockan 11:07 + skrev Samuel Raposo Vieira Mira: > > Connected FFmpeg to Mediacodec VP8 encoder. > Minor Version bump. > --- > configure   |  1 + > libavcodec/Makefile |  1 + > libavcodec/allcodecs.c  |  1 + >

Re: [FFmpeg-devel] [PATCH v2] avutil: deprecate AVRational field inside AVOption::default_val

tis 2023-05-02 klockan 15:48 +0800 skrev Zhao Zhili: > From: Zhao Zhili > > Signed-off-by: Zhao Zhili > --- >  libavutil/opt.h | 2 ++ >  libavutil/version.h | 1 + >  2 files changed, 3 insertions(+) > > diff --git a/libavutil/opt.h b/libavutil/opt.h > index 461b5d3b6b..46915754ea 100644 >

[FFmpeg-devel] [PATCH 1/2] lavc/codec_par: add AVCodecParameters.framerate

This corresponds to AVCodecContext.framerate. --- This will be useful in my ffmpeg CLI work, but sending the patches separately because it's an API addition. --- doc/APIchanges | 3 +++ libavcodec/codec_par.c | 3 +++ libavcodec/codec_par.h | 12 libavcodec/version.h | 2

[FFmpeg-devel] [PATCH 2/2] lavf/demux: export codec-level framerate in avformat_find_stream_info()

--- libavformat/demux.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/demux.c b/libavformat/demux.c index 45e5f5c4c2..2a32bde7f5 100644 --- a/libavformat/demux.c +++ b/libavformat/demux.c @@ -2878,6 +2878,7 @@ int avformat_find_stream_info(AVFormatContext *ic, AVDictionary

[FFmpeg-devel] [PATCH 1/4] lavf/demux: use avg_frame_rate for packet durations for notimestamps formats

avg_frame_rate, if set, should be more reliable than stream timebase in this case. --- libavformat/demux.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/demux.c b/libavformat/demux.c index 06de71cd6e..45e5f5c4c2 100644 --- a/libavformat/demux.c +++ b/libavformat/demux.c @@

[FFmpeg-devel] [PATCH 2/4] lavf/rawdec: stop setting codec context framerate

Demuxers are not supposed to do this. --- libavformat/rawdec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/rawdec.c b/libavformat/rawdec.c index 9126a9e53b..6b623d366e 100644 --- a/libavformat/rawdec.c +++ b/libavformat/rawdec.c @@ -87,7 +87,6 @@ int

[FFmpeg-devel] [PATCH 4/4] lavf/av1dec: stop setting codec context framerate

Demuxers are not supposed to do this. --- libavformat/av1dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/av1dec.c b/libavformat/av1dec.c index ba7fee60cd..216d4e2298 100644 --- a/libavformat/av1dec.c +++ b/libavformat/av1dec.c @@ -80,7 +80,7 @@ static int

[FFmpeg-devel] [PATCH 3/4] lavf/av1dec: mark as notimestamps

--- libavformat/av1dec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/av1dec.c b/libavformat/av1dec.c index d4b430af7e..ba7fee60cd 100644 --- a/libavformat/av1dec.c +++ b/libavformat/av1dec.c @@ -287,7 +287,7 @@ const AVInputFormat ff_av1_demuxer = {

Re: [FFmpeg-devel] [PATCH v2] avutil: deprecate AVRational field inside AVOption::default_val

NAK It can be made useful. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v2] avutil: deprecate AVRational field inside AVOption::default_val

From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavutil/opt.h | 2 ++ libavutil/version.h | 1 + 2 files changed, 3 insertions(+) diff --git a/libavutil/opt.h b/libavutil/opt.h index 461b5d3b6b..46915754ea 100644 --- a/libavutil/opt.h +++ b/libavutil/opt.h @@ -271,8 +271,10 @@ typedef

Re: [FFmpeg-devel] I have an issue when try to using h264_amf encoding rtsp stream

Thanks, that's working! On Sat, Apr 29, 2023 at 3:02 PM Dmitrii Ovchinnikov < ovchinnikov.dmit...@gmail.com> wrote: > > could you also try adding one more parameter and try again? > > * -header_spacing 30*it should have the same value as -g in commandline. > For example: *ffmpeg -i input.mkv