Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support

2023-06-24 Thread Nicolas George
Michael Niedermayer (12023-06-23): > * What iam interrested in was working with the signals at a low level, why > because i find it interresting and fun. Then this is what you should be spending your time on, and to hell with anybody who says otherwise. Unless you have commitments that we are

Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support

2023-06-24 Thread Tomas Härdin
lör 2023-06-24 klockan 23:01 +0200 skrev Michael Niedermayer: > On Sat, Jun 24, 2023 at 11:51:57AM +0200, Tomas Härdin wrote: > > fre 2023-06-23 klockan 23:18 +0200 skrev Michael Niedermayer: > > > > > > Are you planing to add SDR support through some library like GNU > > > radio > > > to FFmpeg

[FFmpeg-devel] [PATCH v4] avformat: add Software Defined Radio support

2023-06-24 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- configure|4 + doc/demuxers.texi| 72 ++ libavdevice/Makefile |1 + libavdevice/alldevices.c |1 + libavdevice/sdrindev.c | 369 ++ libavformat/Makefile |1 + libavformat/allformats.c |1 +

[FFmpeg-devel] [PATCH v4 0/1] avformat: add Software Defined Radio support

2023-06-24 Thread Michael Niedermayer
Changes relative to last revissions * split between libavformat and and libavdevice * internal buffers switched to the hardware native format 50-75% less space required * The dumped and replayed format for rtlsdr should be bitexact now previously there was a small bias * some bugfixes *

Re: [FFmpeg-devel] [RFC] SDR

2023-06-24 Thread Michael Niedermayer
On Sat, Jun 24, 2023 at 12:12:50PM +0200, Tomas Härdin wrote: > fre 2023-06-23 klockan 23:36 +0200 skrev Michael Niedermayer: > > On Fri, Jun 23, 2023 at 10:19:37PM +0200, Tomas Härdin wrote: > > > fre 2023-06-23 klockan 22:18 +0200 skrev Tomas Härdin: > > > > tor 2023-06-22 klockan 16:57 +0200

Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support

2023-06-24 Thread Tomas Härdin
lör 2023-06-24 klockan 22:27 +0200 skrev Rémi Denis-Courmont: > Unless you're connecting to the radio receiver via IP (which would be > a kludge IMO) Just a minor point: piping IQ data over TCP or UDP is actually quite common in the radio scene. I also wouldn't be surprised if Linux gains an API

Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support

2023-06-24 Thread Michael Niedermayer
On Sat, Jun 24, 2023 at 11:51:57AM +0200, Tomas Härdin wrote: > fre 2023-06-23 klockan 23:18 +0200 skrev Michael Niedermayer: > > Hi Tomas > > > > On Fri, Jun 23, 2023 at 10:10:29PM +0200, Tomas Härdin wrote: > > > No. Absolutely not. > > > > > > Radio stuff belongs in radio projects such as GNU

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/jpeg2000dec: jpeg2000 has its own lowres option

2023-06-24 Thread James Almer
On 6/24/2023 5:46 PM, Tomas Härdin wrote: lör 2023-06-24 klockan 19:54 +0200 skrev Paul B Mahol: On Sat, Jun 24, 2023 at 12:53 PM Tomas Härdin wrote: lör 2023-06-10 klockan 20:31 +0200 skrev Michael Niedermayer: jpeg2000 overrides the global lowres variable with a lowres field called

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/jpeg2000dec: jpeg2000 has its own lowres option

2023-06-24 Thread Tomas Härdin
lör 2023-06-24 klockan 19:54 +0200 skrev Paul B Mahol: > On Sat, Jun 24, 2023 at 12:53 PM Tomas Härdin wrote: > > > lör 2023-06-10 klockan 20:31 +0200 skrev Michael Niedermayer: > > > jpeg2000 overrides the global lowres variable with a lowres field > > > called reduction_factor > > > ffmpeg

Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support

2023-06-24 Thread Rémi Denis-Courmont
Le 23 juin 2023 20:12:41 GMT+02:00, Michael Niedermayer a écrit : >Hi > >On Fri, Jun 23, 2023 at 06:37:18PM +0200, Rémi Denis-Courmont wrote: >> Hi, >> >> Le 23 juin 2023 13:17:28 GMT+02:00, Michael Niedermayer >> a écrit : >> >On Fri, Jun 23, 2023 at 10:34:10AM +0800, Kieran Kunhya wrote:

Re: [FFmpeg-devel] [PATCH] avcodec/parser: Check next against buffer index

2023-06-24 Thread Reimar Döffinger
Hi! > On 24 Jun 2023, at 21:14, Andreas Rheinhardt > wrote: > > Michael Niedermayer: >> Fixes: out of array access >> Fixes: crash-0d640731c7da52415670eb47a2af701cbe2e1a3b >> >> Found-by: Catena cyber >> Signed-off-by: Michael Niedermayer >> --- >> libavcodec/parser.c | 2 +- >> 1 file

Re: [FFmpeg-devel] [PATCH] avcodec/j2kenc: use uint64_t type for the lambda value

2023-06-24 Thread Michael Niedermayer
On Sat, Jun 24, 2023 at 02:12:45PM -0300, James Almer wrote: > Should fix integer overflows, and improve encoding results. > > Signed-off-by: James Almer > --- > libavcodec/j2kenc.c | 4 ++-- > tests/ref/vsynth/vsynth1-jpeg2000-yuva444p16 | 8 >

Re: [FFmpeg-devel] [PATCH] avcodec/parser: Check next against buffer index

2023-06-24 Thread Michael Niedermayer
On Sat, Jun 24, 2023 at 09:14:53PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: out of array access > > Fixes: crash-0d640731c7da52415670eb47a2af701cbe2e1a3b > > > > Found-by: Catena cyber > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/parser.c | 2 +- > >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/jpeg2000dec: Check for reduction factor and image offset

2023-06-24 Thread Michael Niedermayer
On Sat, Jun 24, 2023 at 12:50:27PM +0200, Tomas Härdin wrote: > lör 2023-06-10 klockan 20:31 +0200 skrev Michael Niedermayer: > > This combination is not working (it writes out of array) > > Looks OK for now will apply thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH 4/9] lavc: add generic-decode-layer private data

2023-06-24 Thread Andreas Rheinhardt
Anton Khirnov: > Move AVCodecInternal.nb_draining_errors to it, should should not be > visible outside of decode.c. > --- > libavcodec/avcodec.c | 4 +++- > libavcodec/avcodec_internal.h | 2 ++ > libavcodec/decode.c | 22 -- > libavcodec/internal.h

Re: [FFmpeg-devel] [PATCH] avcodec/parser: Check next against buffer index

2023-06-24 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: out of array access > Fixes: crash-0d640731c7da52415670eb47a2af701cbe2e1a3b > > Found-by: Catena cyber > Signed-off-by: Michael Niedermayer > --- > libavcodec/parser.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/parser.c

Re: [FFmpeg-devel] [PATCH 2/9] lavc/avcodec: split flushing into decode- and encode-specific functions

2023-06-24 Thread Andreas Rheinhardt
Anton Khirnov: > Will allow making some state private to encoding/decoding in the future. > --- > libavcodec/avcodec.c | 26 ++ > libavcodec/avcodec_internal.h | 3 +++ > libavcodec/decode.c | 15 +++ > libavcodec/encode.c | 18

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/jpeg2000dec: jpeg2000 has its own lowres option

2023-06-24 Thread Paul B Mahol
On Sat, Jun 24, 2023 at 12:53 PM Tomas Härdin wrote: > lör 2023-06-10 klockan 20:31 +0200 skrev Michael Niedermayer: > > jpeg2000 overrides the global lowres variable with a lowres field > > called reduction_factor > > ffmpeg -lowres X causes the reduction_factor to be set > > ffplay -lowres X

Re: [FFmpeg-devel] [PATCH] avcodec/j2kenc: use uint64_t type for the lambda value

2023-06-24 Thread Paul B Mahol
LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] avcodec/j2kenc: use uint64_t type for the lambda value

2023-06-24 Thread James Almer
Should fix integer overflows, and improve encoding results. Signed-off-by: James Almer --- libavcodec/j2kenc.c | 4 ++-- tests/ref/vsynth/vsynth1-jpeg2000-yuva444p16 | 8 tests/ref/vsynth/vsynth2-jpeg2000-yuva444p16 | 8

Re: [FFmpeg-devel] [PATCH v3 4/4] fate/jpegxl_anim: add demuxer fate test for jpegxl_anim

2023-06-24 Thread Leo Izen
On 6/24/23 08:26, James Almer wrote: On 6/24/2023 1:38 AM, Leo Izen wrote: Adds a fate test for the jpegxl_anim demuxer, that should allow testing for true positives and false positives for animated jpegxl files. Note that two of the test cases are not animated, in order to help sort out false

Re: [FFmpeg-devel] [PATCH v3 3/4] avformat/jpegxl: remove jpegxl_probe, instead call avcodec/jpegxl_parse

2023-06-24 Thread Leo Izen
On 6/24/23 08:21, James Almer wrote: On 6/24/2023 1:38 AM, Leo Izen wrote: diff --git a/libavformat/Makefile b/libavformat/Makefile index 2b90b788c0..0637199c9d 100644 --- a/libavformat/Makefile +++ b/libavformat/Makefile @@ -283,7 +283,7 @@ OBJS-$(CONFIG_IMAGE_HDR_PIPE_DEMUXER) +=

Re: [FFmpeg-devel] [PATCH v3 1/4] avcodec/libjxldec: use internal AVFrame as buffered space

2023-06-24 Thread Leo Izen
On 6/24/23 07:49, James Almer wrote: On 6/24/2023 1:38 AM, Leo Izen wrote: Before this commit, the decoder erroneously assumes that the AVFrame passed to the receive_frame is the same one each time. Now it keeps an internal AVFrame to write into, and copies it over when it's done. ---  

Re: [FFmpeg-devel] [PATCH v3 4/4] fate/jpegxl_anim: add demuxer fate test for jpegxl_anim

2023-06-24 Thread James Almer
On 6/24/2023 1:38 AM, Leo Izen wrote: Adds a fate test for the jpegxl_anim demuxer, that should allow testing for true positives and false positives for animated jpegxl files. Note that two of the test cases are not animated, in order to help sort out false positives. Signed-off-by: ---

Re: [FFmpeg-devel] [PATCH v3 3/4] avformat/jpegxl: remove jpegxl_probe, instead call avcodec/jpegxl_parse

2023-06-24 Thread James Almer
On 6/24/2023 1:38 AM, Leo Izen wrote: diff --git a/libavformat/Makefile b/libavformat/Makefile index 2b90b788c0..0637199c9d 100644 --- a/libavformat/Makefile +++ b/libavformat/Makefile @@ -283,7 +283,7 @@ OBJS-$(CONFIG_IMAGE_HDR_PIPE_DEMUXER) += img2dec.o img2.o

Re: [FFmpeg-devel] [PATCH v3 1/4] avcodec/libjxldec: use internal AVFrame as buffered space

2023-06-24 Thread James Almer
On 6/24/2023 1:38 AM, Leo Izen wrote: Before this commit, the decoder erroneously assumes that the AVFrame passed to the receive_frame is the same one each time. Now it keeps an internal AVFrame to write into, and copies it over when it's done. --- libavcodec/libjxldec.c | 40

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/videotoolboxenc: use int as the type of profile

2023-06-24 Thread Tomas Härdin
fre 2023-06-09 klockan 19:14 +0800 skrev Zhao Zhili: > From: Zhao Zhili > > Other than save a few bytes, it also has the benefit to show the > AV_OPT_TYPE_CONST value in help, e.g., > >   -profile       E..V... Profile (from 0 to > INT_MAX) (default 0) > baseline    66  

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-06-24 Thread Anton Khirnov
Quoting Carotti, Elias (2023-06-22 19:23:05) > On Thu, 2023-06-22 at 10:44 +0200, Anton Khirnov wrote: > > CAUTION: This email originated from outside of the organization. Do > > not click links or open attachments unless you can confirm the sender > > and know the content is safe. > > > > > >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/jpeg2000dec: jpeg2000 has its own lowres option

2023-06-24 Thread Tomas Härdin
lör 2023-06-10 klockan 20:31 +0200 skrev Michael Niedermayer: > jpeg2000 overrides the global lowres variable with a lowres field > called reduction_factor > ffmpeg -lowres X causes the reduction_factor to be set > ffplay -lowres X causes both lowres and the reduction_factor to be > set > ossfuss

Re: [FFmpeg-devel] [PATCH] libavformat/mpegts.c: fix hardcoded 5-bytes skip for metadata streams.

2023-06-24 Thread Thilo Borgmann
Am 24.06.23 um 12:43 schrieb Anton Khirnov: Quoting Romain Beauxis (2023-06-22 16:19:36) commit ca0472eeebe478b7eb6e7d1dc4351037f8811728 Author: Romain Beauxis Date: Thu Jun 22 09:14:18 2023 -0500 Add FATE test for timed id3 demux. diff --git a/tests/fate/demux.mak

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/jpeg2000dec: Check for reduction factor and image offset

2023-06-24 Thread Tomas Härdin
lör 2023-06-10 klockan 20:31 +0200 skrev Michael Niedermayer: > This combination is not working (it writes out of array) Looks OK for now /Tomas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To

Re: [FFmpeg-devel] [PATCH] libavformat/mpegts.c: fix hardcoded 5-bytes skip for metadata streams.

2023-06-24 Thread Anton Khirnov
Quoting Romain Beauxis (2023-06-22 16:19:36) > commit ca0472eeebe478b7eb6e7d1dc4351037f8811728 > Author: Romain Beauxis > Date: Thu Jun 22 09:14:18 2023 -0500 > > Add FATE test for timed id3 demux. > > diff --git a/tests/fate/demux.mak b/tests/fate/demux.mak > index d8fc68af88..ace8fa0b52

Re: [FFmpeg-devel] [PATCH 5/5] avformat: add sdr support

2023-06-24 Thread Tomas Härdin
mån 2023-06-19 klockan 00:36 +1200 skrev Kieran Kunhya: > On Sun, 18 Jun 2023 at 23:46, Paul B Mahol wrote: > > > > sdrdemux in libavformat will demodulate, do error correction then > > > return > > > AVPacket > > > with H.264 / Mpeg2 video or AAC or wahetever > > > That then will get passed to

Re: [FFmpeg-devel] [RFC] SDR

2023-06-24 Thread Tomas Härdin
fre 2023-06-23 klockan 23:36 +0200 skrev Michael Niedermayer: > On Fri, Jun 23, 2023 at 10:19:37PM +0200, Tomas Härdin wrote: > > fre 2023-06-23 klockan 22:18 +0200 skrev Tomas Härdin: > > > tor 2023-06-22 klockan 16:57 +0200 skrev Michael Niedermayer: > > > > If we support just audio and video

Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support

2023-06-24 Thread Tomas Härdin
fre 2023-06-23 klockan 23:18 +0200 skrev Michael Niedermayer: > Hi Tomas > > On Fri, Jun 23, 2023 at 10:10:29PM +0200, Tomas Härdin wrote: > > No. Absolutely not. > > > > Radio stuff belongs in radio projects such as GNU Radio. This is > > extreme scope creep. > > > > I can throw an AM detector

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/videotoolboxenc: remove AUTO_PROFILE define

2023-06-24 Thread Tomas Härdin
fre 2023-06-09 klockan 19:14 +0800 skrev Zhao Zhili: > From: Zhao Zhili > > Use FF_PROFILE_UNKNOWN as auto mode. Won't this break code that relies on AUTO_PROFILE? On the other hand zero refers to profiles that actually exist such as profile0 for vp9, so the old behavior is kinda bad. /Tomas

Re: [FFmpeg-devel] [PATCH] avcodec/mediacodecenc: add profile names to options

2023-06-24 Thread Tomas Härdin
fre 2023-06-09 klockan 19:14 +0800 skrev Zhao Zhili: > From: Zhao Zhili > > H.264 high10/high422/high44 are unlikely supported by devices. > It's there for developers to do the experiment. > > H.265 main10 works on my device with AV_PIX_FMT_MEDIACODEC. > OMX_COLOR_FormatYUV420Planar16 doesn't