[FFmpeg-devel] [PATCH] avcodec/decode: log hwaccel name

2024-03-13 Thread Zhao Zhili
From: Zhao Zhili Many users mistakenly think that hwaccel is an instance of a decoder, and cannot find the corresponding decoder name in the logs. Log hwaccel name so user know hwaccel has taken effect. --- libavcodec/decode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[FFmpeg-devel] [PATCH v1] lavc/vaapi_decode: Don't update buffer number if allocataion fail

2024-03-13 Thread fei . w . wang-at-intel . com
From: Fei Wang Signed-off-by: Fei Wang --- libavcodec/vaapi_decode.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/libavcodec/vaapi_decode.c b/libavcodec/vaapi_decode.c index ceac769c52..cca94b5336 100644 --- a/libavcodec/vaapi_decode.c +++

[FFmpeg-devel] [PATCH 3/3] avformat/aiffenc: Usw avio_wb32() where possible

2024-03-13 Thread Andreas Rheinhardt
AIFF is a big-endian format, so this is more natural. Signed-off-by: Andreas Rheinhardt --- libavformat/aiffenc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavformat/aiffenc.c b/libavformat/aiffenc.c index 37aca41847..2cd1119409 100644 ---

[FFmpeg-devel] [PATCH 2/3] avformat/aiffenc: Simplify padding tag

2024-03-13 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/aiffenc.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavformat/aiffenc.c b/libavformat/aiffenc.c index 11a5b18d57..37aca41847 100644 --- a/libavformat/aiffenc.c +++ b/libavformat/aiffenc.c @@ -87,13 +87,15 @@

[FFmpeg-devel] [PATCH 1/3] fate/lavf-audio: Test writing AIFF-native tags

2024-03-13 Thread Andreas Rheinhardt
In particular, test writing tags with odd strlen. (These tags are zero-padded to even size.) Signed-off-by: Andreas Rheinhardt --- tests/fate/lavf-audio.mak | 1 + tests/ref/lavf/aiff | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/fate/lavf-audio.mak

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/vf_scale2ref: switch to FFFrameSync

2024-03-13 Thread Michael Niedermayer
On Wed, Mar 13, 2024 at 08:43:58PM -0300, James Almer wrote: > On 3/13/2024 8:41 PM, Michael Niedermayer wrote: > > On Wed, Mar 13, 2024 at 01:24:25PM +0100, Niklas Haas wrote: > > > From: Niklas Haas > > > > > > This filter's existing design has a number of issues: > > > > > > - There is no

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/vf_scale2ref: switch to FFFrameSync

2024-03-13 Thread Andreas Rheinhardt
Niklas Haas: > From: Niklas Haas > > This filter's existing design has a number of issues: > > - There is no guarantee whatsoever about the order in which frames are > pushed onto the main and ref link, due to this being entirely > dependent on the order in which downstream filters decide

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/vf_scale2ref: switch to FFFrameSync

2024-03-13 Thread James Almer
On 3/13/2024 8:41 PM, Michael Niedermayer wrote: On Wed, Mar 13, 2024 at 01:24:25PM +0100, Niklas Haas wrote: From: Niklas Haas This filter's existing design has a number of issues: - There is no guarantee whatsoever about the order in which frames are pushed onto the main and ref link,

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/vf_scale2ref: switch to FFFrameSync

2024-03-13 Thread Michael Niedermayer
On Wed, Mar 13, 2024 at 01:24:25PM +0100, Niklas Haas wrote: > From: Niklas Haas > > This filter's existing design has a number of issues: > > - There is no guarantee whatsoever about the order in which frames are > pushed onto the main and ref link, due to this being entirely > dependent

[FFmpeg-devel] [PATCH 6/7] avcodec/vorbis_data: Mark symbols as hidden

2024-03-13 Thread Andreas Rheinhardt
Avoids .got entries for ff_vorbis_ch_layouts. Signed-off-by: Andreas Rheinhardt --- libavcodec/vorbis_data.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/vorbis_data.h b/libavcodec/vorbis_data.h index 51c91c9e04..327e5ab2ef 100644 --- a/libavcodec/vorbis_data.h +++

[FFmpeg-devel] [PATCH 7/7] avcodec/mpegaudio(data|dsp): Mark symbols as hidden

2024-03-13 Thread Andreas Rheinhardt
Avoids .got entries for ff_mpa_bitrate_tab, ff_mpa_synth_window_fixed, ff_band_size_long, ff_mpa_pretab, ff_band_size_short, ff_mpa_synth_window_float and ff_band_index_long here. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegaudiodata.h | 3 +++ libavcodec/mpegaudiodsp.h | 3 +++ 2

[FFmpeg-devel] [PATCH 5/7] avcodec/dirac_arith: Only include x86/asm.h for ARCH_X86

2024-03-13 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/dirac_arith.h | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/dirac_arith.h b/libavcodec/dirac_arith.h index 350a58fca6..203d481603 100644 --- a/libavcodec/dirac_arith.h +++ b/libavcodec/dirac_arith.h @@ -28,7 +28,11 @@ #ifndef

[FFmpeg-devel] [PATCH 4/7] avdevice/alldevices: Mark iterators as av_cold

2024-03-13 Thread Andreas Rheinhardt
Because they are. Signed-off-by: Andreas Rheinhardt --- libavdevice/alldevices.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/libavdevice/alldevices.c b/libavdevice/alldevices.c index 6396076ecf..9b9a9146c7 100644 --- a/libavdevice/alldevices.c +++

[FFmpeg-devel] [PATCH 3/7] avdevice/alldevices: Mark devices as hidden

2024-03-13 Thread Andreas Rheinhardt
Both GCC and Clang create code that inlines the loops in next_input() and next_output() at high optimization levels (presumably when there are not too many devices) and this code leads to the creation of .got entries: e7: 48 3b 3d 00 00 00 00cmp0x0(%rip),%rdi# ee

[FFmpeg-devel] [PATCH 2/7] avcodec/ac3tab: Remove enum CustomChannelMapLocation

2024-03-13 Thread Andreas Rheinhardt
Forgotten in 4c8d9b1d0901b0fba0887e53463574913e8862c5. Signed-off-by: Andreas Rheinhardt --- libavcodec/ac3tab.h | 16 1 file changed, 16 deletions(-) diff --git a/libavcodec/ac3tab.h b/libavcodec/ac3tab.h index 2531d80677..dcef643acb 100644 --- a/libavcodec/ac3tab.h +++

[FFmpeg-devel] [PATCH 1/7] avformat/iamf: Mark symbols as hidden

2024-03-13 Thread Andreas Rheinhardt
Avoids .got entries for ff_iamf_scalable_ch_layouts and ff_iamf_sound_system_map (whether they would have been created otherwise depends upon the compiler and compiler options). Signed-off-by: Andreas Rheinhardt --- libavformat/iamf.h | 3 +++ 1 file changed, 3 insertions(+) diff --git

[FFmpeg-devel] [PATCH] avutil/hwcontext_d3d11va: add logging to d3d11/dxgi interfaces

2024-03-13 Thread Timo Rothenpieler
--- libavutil/hwcontext_d3d11va.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/libavutil/hwcontext_d3d11va.c b/libavutil/hwcontext_d3d11va.c index cf793a2f48..522c15a58b 100644 --- a/libavutil/hwcontext_d3d11va.c +++ b/libavutil/hwcontext_d3d11va.c @@

Re: [FFmpeg-devel] [PATCH] vvcdec: Mark as experimental

2024-03-13 Thread James Almer
On 2/14/2024 10:41 AM, Kieran Kunhya wrote: On Wed, 14 Feb 2024 at 11:47, Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: Kieran Kunhya: From 15c9311c49ebbe87fc4517b67cb73b3079ec3510 Mon Sep 17 00:00:00 2001 From: Kieran Kunhya Date: Wed, 7 Feb 2024 21:10:08 + Subject:

Re: [FFmpeg-devel] [PATCH] Change rdiv (vf_convolution) documentation to reflect actual behavior

2024-03-13 Thread Marton Balint
On Wed, 13 Mar 2024, Stone Chen wrote: On Wed, Mar 13, 2024 at 4:26 AM Marton Balint wrote: On Tue, 12 Mar 2024, Stone Chen wrote: > The documentation correctly states that the rdiv is a multiplier but incorrectly states the default behavior is to multiply by the sum of all matrix

[FFmpeg-devel] [PATCH] avutil/hwcontext_d3d11va: prefer DXGI 1.1 factory when available

2024-03-13 Thread Timo Rothenpieler
A lot of modern stuff straight up fails on the old 1.0 factory, which is masked by the fact that it's only used when an explicit adapter is specified. --- libavutil/hwcontext_d3d11va.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavutil/hwcontext_d3d11va.c

[FFmpeg-devel] [PATCH v3 2/2] lavc/vulkan_av1: port to the new stable API

2024-03-13 Thread Lynne
Tested by multiple users on multiple operating systems, driver implementations and test samples to work. Co-Authored-by: Dave Airlie >From e2d31951f46fcc10e1263b8603e486e111e9578c Mon Sep 17 00:00:00 2001 From: Lynne Date: Fri, 19 Jan 2024 10:49:02 +1000 Subject: [PATCH v3 2/2]

[FFmpeg-devel] [PATCH v3 1/2] lavc/cbs_av1: fill in ref_frame_sign_bias and order_hints

2024-03-13 Thread Lynne
Unchanged from v2 >From 426701f4fb00123f2fc46efda188ca7d2413b187 Mon Sep 17 00:00:00 2001 From: Lynne Date: Fri, 2 Feb 2024 03:54:06 +0100 Subject: [PATCH v3 1/2] lavc/cbs_av1: fill in ref_frame_sign_bias and order_hints Needed for Vulkan AV1. --- libavcodec/cbs_av1.h | 2 ++

Re: [FFmpeg-devel] [PATCH] Change rdiv (vf_convolution) documentation to reflect actual behavior

2024-03-13 Thread Stone Chen
On Wed, Mar 13, 2024 at 4:26 AM Marton Balint wrote: > > > On Tue, 12 Mar 2024, Stone Chen wrote: > > > The documentation correctly states that the rdiv is a multiplier but > incorrectly states the default behavior is to multiply by the sum of all > matrix elements - it multiplies by 1/sum. > >

[FFmpeg-devel] [PATCH] avformat/internal: Remove declaration for ff_format_io_close_default()

2024-03-13 Thread Andreas Rheinhardt
Forgotten in d6799ee0e41dee35ebf9c664173aed8e3ab24141. Signed-off-by: Andreas Rheinhardt --- libavformat/internal.h | 4 1 file changed, 4 deletions(-) diff --git a/libavformat/internal.h b/libavformat/internal.h index 2e59036a53..e5f8337130 100644 --- a/libavformat/internal.h +++

[FFmpeg-devel] [PATCH] fate/ffmpeg: add a test for loopback decoding

2024-03-13 Thread James Almer
Signed-off-by: James Almer --- tests/fate/ffmpeg.mak | 7 +++ tests/ref/fate/ffmpeg-loopback-decoding | 57 + 2 files changed, 64 insertions(+) create mode 100644 tests/ref/fate/ffmpeg-loopback-decoding diff --git a/tests/fate/ffmpeg.mak

Re: [FFmpeg-devel] [PATCH v4] avcodec/libx264: fix extradata when config annexb=0

2024-03-13 Thread Zhao Zhili
> On Mar 12, 2024, at 23:00, Andreas Rheinhardt > wrote: > > Zhao Zhili: >> From: Zhao Zhili >> >> --- >> v4: Fix missing SEI in set_avcc_extradata >> v3: Remove unnecessary inclusion >> >> configure| 2 +- >> libavcodec/libx264.c | 153

[FFmpeg-devel] [PATCH v5] avcodec/libx264: fix extradata when config annexb=0

2024-03-13 Thread Zhao Zhili
From: Zhao Zhili --- v5: Decode chroma_format_idc directly instead of ff_h264_decode_seq_parameter_set v4: Fix missing SEI in set_avcc_extradata v3: Remove unnecessary inclusion libavcodec/libx264.c | 162 --- 1 file changed, 138 insertions(+), 24

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/vf_scale2ref: switch to FFFrameSync

2024-03-13 Thread Gyan Doshi
On 2024-03-13 05:54 pm, Niklas Haas wrote: From: Niklas Haas This filter's existing design has a number of issues: - There is no guarantee whatsoever about the order in which frames are pushed onto the main and ref link, due to this being entirely dependent on the order in which

Re: [FFmpeg-devel] [PATCH 1/2] avfilter: mark scale2ref as supporting dynamic sizes

2024-03-13 Thread Gyan Doshi
On 2024-03-13 05:54 pm, Niklas Haas wrote: From: Niklas Haas Analogous to the "scale" filter, which this is practically identical with. --- libavfilter/avfilter.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/vf_scale2ref: switch to FFFrameSync

2024-03-13 Thread Niklas Haas
On Wed, 13 Mar 2024 13:24:25 +0100 Niklas Haas wrote: > -frame_changed = in->width != link->w || > -in->height != link->h || > -in->format != link->format || > -in->sample_aspect_ratio.den != > link->sample_aspect_ratio.den || > -

[FFmpeg-devel] [PATCH 2/2] avfilter/vf_scale2ref: switch to FFFrameSync

2024-03-13 Thread Niklas Haas
From: Niklas Haas This filter's existing design has a number of issues: - There is no guarantee whatsoever about the order in which frames are pushed onto the main and ref link, due to this being entirely dependent on the order in which downstream filters decide to request frames from

[FFmpeg-devel] [PATCH 1/2] avfilter: mark scale2ref as supporting dynamic sizes

2024-03-13 Thread Niklas Haas
From: Niklas Haas Analogous to the "scale" filter, which this is practically identical with. --- libavfilter/avfilter.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 831871de90b..dcad4d55292 100644 ---

Re: [FFmpeg-devel] [PATCH v2] avcodec/ppc/h264dsp: Fix unaligned stores

2024-03-13 Thread Andreas Rheinhardt
James Almer: > On 3/13/2024 8:30 AM, Andreas Rheinhardt wrote: >> Also fix an effective-type violation. >> Exposed by >> https://fate.ffmpeg.org/report.cgi?time=20240312011016=ppc-linux-gcc-13.2-ubsan-altivec-qemu >> >> Signed-off-by: Andreas Rheinhardt >> --- >>   libavcodec/ppc/h264dsp.c | 35

Re: [FFmpeg-devel] [PATCH v2] avcodec/ppc/h264dsp: Fix unaligned stores

2024-03-13 Thread James Almer
On 3/13/2024 8:30 AM, Andreas Rheinhardt wrote: Also fix an effective-type violation. Exposed by https://fate.ffmpeg.org/report.cgi?time=20240312011016=ppc-linux-gcc-13.2-ubsan-altivec-qemu Signed-off-by: Andreas Rheinhardt --- libavcodec/ppc/h264dsp.c | 35

[FFmpeg-devel] [PATCH v2] avcodec/ppc/h264dsp: Fix unaligned stores

2024-03-13 Thread Andreas Rheinhardt
Also fix an effective-type violation. Exposed by https://fate.ffmpeg.org/report.cgi?time=20240312011016=ppc-linux-gcc-13.2-ubsan-altivec-qemu Signed-off-by: Andreas Rheinhardt --- libavcodec/ppc/h264dsp.c | 35 +-- 1 file changed, 17 insertions(+), 18

Re: [FFmpeg-devel] [PATCH] lavfi/atempo: avoid asendcmd assertion failure

2024-03-13 Thread Rajiv Harlalka
On 3/13/24 8:39 AM, Pavel Koshevoy wrote: On Tue, Mar 12, 2024 at 9:01 PM Pavel Koshevoy wrote: From: Rajiv Harlalka Check for zeros equal to the total samples early, because in that case we would already be leaving the first few frames out. Fixes trac ticket #10692 ---

[FFmpeg-devel] [PATCH] fftools/ffmpeg_sched: Remove set-but-unused variable

2024-03-13 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- fftools/ffmpeg_sched.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fftools/ffmpeg_sched.c b/fftools/ffmpeg_sched.c index d1fb942c34..f739066921 100644 --- a/fftools/ffmpeg_sched.c +++ b/fftools/ffmpeg_sched.c @@ -2310,7 +2310,6 @@ int

Re: [FFmpeg-devel] [PATCH] avcodec/mpeg4videodec: Align idct-block appropriately

2024-03-13 Thread Kieran Kunhya
On Wed, 13 Mar 2024 at 00:53, Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > It is accessed via AV_RN64() in ff_simple_idct_put_int32_10bit(). > Should fix the UBSan failures in the mpeg4-simple-studio-profile > test here: > >

Re: [FFmpeg-devel] [PATCH] Change rdiv (vf_convolution) documentation to reflect actual behavior

2024-03-13 Thread Marton Balint
On Tue, 12 Mar 2024, Stone Chen wrote: The documentation correctly states that the rdiv is a multiplier but incorrectly states the default behavior is to multiply by the sum of all matrix elements - it multiplies by 1/sum. This changes the documentation to match the code. Please mention

Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/ffmpeg: add loopback decoding

2024-03-13 Thread Gyan Doshi
On 2024-03-13 12:57 pm, Anton Khirnov wrote: ffmpeg | branch: master | Anton Khirnov | Mon Feb 19 10:27:44 2024 +0100| [a9193f7b7d65aafa326e25571c6672636a8ee3d2] | committer: Anton Khirnov fftools/ffmpeg: add loopback decoding ... +E.g. the following example: + +@example +ffmpeg -i

Re: [FFmpeg-devel] [PATCH v6 2/9] avcodec/vaapi_encode: introduce a base layer for vaapi encode

2024-03-13 Thread Wu, Tong1
> >Feb 29, 2024, 06:35 by tong1.wu-at-intel@ffmpeg.org: > >> From: Tong Wu >> >> Since VAAPI and future D3D12VA implementation may share the same dpb >> logic and some other functions. A base layer encode context is introduced >> as vaapi context's base and extract the related funtions to a

Re: [FFmpeg-devel] [PATCH] change av_ts_make_time_string precision

2024-03-13 Thread Allan Cady via ffmpeg-devel
I've been meaning to ask -- what version of C are we using? I know it's at least 99, because of the compound literal (had to look that up). ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To

Re: [FFmpeg-devel] [PATCH] change av_ts_make_time_string precision

2024-03-13 Thread Allan Cady via ffmpeg-devel
On Tuesday, March 12, 2024 at 02:24:47 PM PDT, Marton Balint wrote: > On Tue, 12 Mar 2024, Allan Cady via ffmpeg-devel wrote: >> On Monday, March 11, 2024 at 12:11:45 PM PDT, Marton Balint >> wrote: >>> On Mon, 11 Mar 2024, Andreas Rheinhardt wrote: >>> Allan Cady via ffmpeg-devel: From: