Re: [FFmpeg-devel] [RFC] avcodec/avcodec.h: Add encryption info side data

2018-01-05 Thread wm4
On Fri, 5 Jan 2018 10:22:31 -0800 Jacob Trimble wrote: > Just noticed the new files were in libavcodec, moved to libavutil. > Can someone please review this so it can be pushed. I have the MP4 > implementation ready and I would like to get that reviewed and pushed > as soon as possible. I'd ass

Re: [FFmpeg-devel] avcodec/rkmpp : Fix broken build and remove some useless code

2018-01-05 Thread wm4
On Fri, 5 Jan 2018 19:02:25 + "LongChair ." wrote: > Hi, > > Here are two patches that should : > > - fix https://trac.ffmpeg.org/ticket/6834. > > - remove code that looked a bit hackish and which is not necessary anymore. > > The first patch is required as mpp removed some control operat

Re: [FFmpeg-devel] [PATCH 3/3 v2] avfilter: use a mutex instead of atomics in avfilter_register()

2018-01-05 Thread wm4
On Thu, 4 Jan 2018 22:42:52 -0300 James Almer wrote: > Signed-off-by: James Almer > --- > libavfilter/avfilter.c | 15 +++ > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c > index b98b32bacb..ff7df672fd 100644 > --

Re: [FFmpeg-devel] [PATCH 2/3 v2] avformat: use mutexes instead of atomics in av_register_{input, output}_format()

2018-01-05 Thread wm4
On Thu, 4 Jan 2018 22:41:38 -0300 James Almer wrote: > Signed-off-by: James Almer > --- > libavformat/format.c | 34 +++--- > 1 file changed, 23 insertions(+), 11 deletions(-) > > diff --git a/libavformat/format.c b/libavformat/format.c > index 38ca2a3465..759b5b1a

Re: [FFmpeg-devel] [PATCH 1/3 v2] avcodec/util: use a mutex instead of atomics in avcodec_register()

2018-01-05 Thread wm4
On Thu, 4 Jan 2018 22:40:44 -0300 James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/utils.c | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/utils.c b/libavcodec/utils.c > index dfbfe98d63..4d736d2e7d 100644 > --- a/libavcodec/u

Re: [FFmpeg-devel] [PATCH] hwcontext_vaapi: implement auto connecting to a wayland display

2018-01-04 Thread wm4
On Thu, 4 Jan 2018 20:33:16 + Rostislav Pehlivanov wrote: > Allows Wayland users to use vaapi without having to specify a > vaapi drm device path. > > Signed-off-by: Rostislav Pehlivanov > --- > configure | 6 +- > libavutil/hwcontext_vaapi.c | 29 ++

Re: [FFmpeg-devel] [PATCH 4/4] avfilter: use a mutex instead of atomics in avfilter_register()

2018-01-04 Thread wm4
On Thu, 4 Jan 2018 15:19:04 -0300 James Almer wrote: > Signed-off-by: James Almer > --- > With this, the last users of libavutil's atomic wrappers are dealt > with. Technically, you need to lock when reading the next pointers too? Don't know if that actually matters. __

Re: [FFmpeg-devel] [PATCH 2/2] avcodec: mark AV_CODEC_CAP_SUBFRAMES as deprecated

2018-01-04 Thread wm4
On Sun, 31 Dec 2017 13:23:44 + Rostislav Pehlivanov wrote: > On 31 December 2017 at 13:13, wm4 wrote: > > > On Sun, 31 Dec 2017 13:07:28 + > > Rostislav Pehlivanov wrote: > > > > > The new decoding API supports 1 avpkt -> multiple avframes

Re: [FFmpeg-devel] [PATCH] http: avoid logging reconnect warning if stream was aborted

2018-01-04 Thread wm4
On Thu, 4 Jan 2018 12:01:02 -0500 "Ronald S. Bultje" wrote: > Hi, > > On Thu, Jan 4, 2018 at 11:07 AM, wm4 wrote: > > > If the stream was aborted using the libavformat interrupt callback, we > > don't want it to log the reconnect warning. (Exiting aft

[FFmpeg-devel] [PATCH] http: avoid logging reconnect warning if stream was aborted

2018-01-04 Thread wm4
If the stream was aborted using the libavformat interrupt callback, we don't want it to log the reconnect warning. (Exiting after logging this warning worked well, so this is only for avoiding the ugly warning.) --- I don't want to stick this as an additional condition into the 150 column while() c

[FFmpeg-devel] [PATCH] lavf: make avformat_network_init() explicitly optional

2018-01-04 Thread wm4
It was sort of optional before - if you didn't call it, networking was initialized on demand, and an ugly warning was logged. Also, the doxygen comments threatened that it would be made strictly required one day. Make it explicitly optional. I would prefer to deprecate it fully, but there might st

Re: [FFmpeg-devel] [PATCH] libavutil/hwcontext_dxva2: Add check for possible errors from GetAdapterDisplayModeEx

2018-01-04 Thread wm4
On Wed, 3 Jan 2018 15:22:15 -0800 Humberto Ribeiro wrote: > This prevents a possible crash in CreateDeviceEx when using faulty response > from GetAdapterDisplayModeEx and allows ffmpeg to fallback to classic d3d9. > --- > libavutil/hwcontext_dxva2.c | 6 +- > 1 file changed, 5 insertions(+

Re: [FFmpeg-devel] [PATCH] libavutil/hwcontext_dxva2: Add check for possible errors from GetAdapterDisplayModeEx

2018-01-04 Thread wm4
On Wed, 3 Jan 2018 15:22:15 -0800 Humberto Ribeiro wrote: > This prevents a possible crash in CreateDeviceEx when using faulty response > from GetAdapterDisplayModeEx and allows ffmpeg to fallback to classic d3d9. > --- > libavutil/hwcontext_dxva2.c | 6 +- > 1 file changed, 5 insertions(+

Re: [FFmpeg-devel] [PATCH v2 1/2] http: block while waiting for reconnecting

2018-01-04 Thread wm4
On Tue, 2 Jan 2018 17:19:14 +0100 wm4 wrote: > It makes no sense to return an error after the first reconnect, and then > somehow resume the next time it's called. Usually this will lead to > demuxer errors. Make reconnecting block instead, until it has either > successfull

Re: [FFmpeg-devel] [PATCH v2 1/2] http: block while waiting for reconnecting

2018-01-04 Thread wm4
On Tue, 2 Jan 2018 17:19:14 +0100 wm4 wrote: > It makes no sense to return an error after the first reconnect, and then > somehow resume the next time it's called. Usually this will lead to > demuxer errors. Make reconnecting block instead, until it has either > successfull

Re: [FFmpeg-devel] [PATCH 2/2] avutil/log: use thread wrappers for the locking functionality

2018-01-04 Thread wm4
On Thu, 4 Jan 2018 01:14:08 -0300 James Almer wrote: > w32threads and os2threads both support static mutex initialization now, > so don't limit it to pthreads only. > > Signed-off-by: James Almer > --- > libavutil/log.c | 14 -- > 1 file changed, 4 insertions(+), 10 deletions(-) >

Re: [FFmpeg-devel] [PATCH] Prevents crash from CreateDeviceEx and proper fallback to classic d3d9.

2018-01-03 Thread wm4
On Thu, 4 Jan 2018 00:26:01 +0100 Hendrik Leppkes wrote: > On Wed, Jan 3, 2018 at 11:18 PM, wm4 wrote: > > On Wed, 3 Jan 2018 13:59:34 -0800 > > Humberto Ribeiro wrote: > > > >> --- > >> libavutil/hwcontext_dxva2.c | 6 +- > >&

Re: [FFmpeg-devel] [PATCH] Prevents crash from CreateDeviceEx and proper fallback to classic d3d9.

2018-01-03 Thread wm4
On Wed, 3 Jan 2018 14:34:59 -0800 Mont3z Claros wrote: > > LGTM, but when does it happen? Why would creation of IDirect3D9Ex > > succeed, but this method fail? The strangest thing being that > > CreateDeviceEx apparently fails, even though modeex is > > zero-initialized and doesn't contain any po

Re: [FFmpeg-devel] [PATCH] Prevents crash from CreateDeviceEx and proper fallback to classic d3d9.

2018-01-03 Thread wm4
On Wed, 3 Jan 2018 13:59:34 -0800 Humberto Ribeiro wrote: > --- > libavutil/hwcontext_dxva2.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/libavutil/hwcontext_dxva2.c b/libavutil/hwcontext_dxva2.c > index 2ddd4be..44ebdbc 100644 > --- a/libavutil/hwcontext_dxva

Re: [FFmpeg-devel] [PATCH v2 1/6] lavc: add new API for iterating codecs and codec parsers

2018-01-03 Thread wm4
On Wed, 3 Jan 2018 16:50:00 + Rostislav Pehlivanov wrote: > On 3 January 2018 at 15:25, wm4 wrote: > > > On Wed, 3 Jan 2018 00:42:36 + > > Josh de Kock wrote: > > > > > +static AVCodec *find_codec_by_name(const char *name, int (*x)(const > >

Re: [FFmpeg-devel] [PATCH 4/6] lavf: move fifo test muxer into separate file

2018-01-03 Thread wm4
On Wed, 3 Jan 2018 16:46:14 +0100 Hendrik Leppkes wrote: > On Wed, Jan 3, 2018 at 4:37 PM, wm4 wrote: > > On Wed, 3 Jan 2018 00:43:02 + > > Josh de Kock wrote: > > > >> This fixes the fate-fifo-muxer test. > >> --- > >> libavform

Re: [FFmpeg-devel] [PATCH 6/6] lavf: add avpriv function to register devices

2018-01-03 Thread wm4
On Wed, 3 Jan 2018 00:43:12 + Josh de Kock wrote: > --- > libavdevice/alldevices.c | 6 +- > libavformat/allformats.c | 44 +++- > libavformat/avformat.h | 4 > 3 files changed, 48 insertions(+), 6 deletions(-) > > diff --git a/libavdevic

Re: [FFmpeg-devel] [PATCH 5/6] lavd: add new API for iterating input and output devices

2018-01-03 Thread wm4
On Wed, 3 Jan 2018 00:43:06 + Josh de Kock wrote: > --- > configure| 27 ++-- > libavdevice/alldevices.c | 172 > +++ > libavdevice/avdevice.c | 46 - > libavdevice/avdevice.h | 28 > libavdevice/ver

Re: [FFmpeg-devel] [PATCH 4/6] lavf: move fifo test muxer into separate file

2018-01-03 Thread wm4
On Wed, 3 Jan 2018 00:43:02 + Josh de Kock wrote: > This fixes the fate-fifo-muxer test. > --- > libavformat/Makefile | 2 +- > libavformat/allformats.c | 1 + > libavformat/fifo_test.c| 150 > + > libavformat/tests/fifo_mu

Re: [FFmpeg-devel] [PATCH 3/6] lavf: add new API for iterating muxers and demuxers

2018-01-03 Thread wm4
On Wed, 3 Jan 2018 00:42:53 + Josh de Kock wrote: > --- > configure| 6 +- > doc/APIchanges | 5 + > libavformat/allformats.c | 870 > --- > libavformat/avformat.h | 31 ++ > libavformat/format.c | 56 +-- > l

Re: [FFmpeg-devel] [PATCH v2 1/6] lavc: add new API for iterating codecs and codec parsers

2018-01-03 Thread wm4
On Wed, 3 Jan 2018 00:42:36 + Josh de Kock wrote: > Also replace linked list with an array. > --- > diff --git a/doc/APIchanges b/doc/APIchanges > index 3c9f237..3d28d85 100644 > --- a/doc/APIchanges > +++ b/doc/APIchanges > @@ -15,6 +15,10 @@ libavutil: 2017-10-21 > > API changes, mo

Re: [FFmpeg-devel] [PATCH 2/6] lavf/rtp: replace linked list with array

2018-01-03 Thread wm4
On Wed, 3 Jan 2018 00:42:45 + Josh de Kock wrote: > --- > libavformat/allformats.c | 4 -- > libavformat/rdt.c| 8 +-- > libavformat/rdt.h| 3 + > libavformat/rtpdec.c | 157 > ++- > libavformat/rtpdec.h | 29 +++

Re: [FFmpeg-devel] [PATCH v2 1/6] lavc: add new API for iterating codecs and codec parsers

2018-01-03 Thread wm4
On Wed, 3 Jan 2018 00:42:36 + Josh de Kock wrote: > Also replace linked list with an array. > --- > configure | 12 +- > doc/APIchanges |4 + > libavcodec/allcodecs.c | 1473 > > libavcodec/avcodec.h | 31 + > l

Re: [FFmpeg-devel] [PATCH v2, 2/2] avformat/hls: fix start time seek error

2018-01-03 Thread wm4
On Tue, 2 Jan 2018 22:44:47 -0500 mymoey...@gmail.com wrote: > From: Wu Zhiqiang > > Calculate first_timestamp based on first packet timestamp. > Some m3u8 have streams that second one has smaller timestamp > in first packet of this stream. > Start/seek from start time may fail due to EIO error

Re: [FFmpeg-devel] Global options to compile FFmpeg with only audio-related features

2018-01-02 Thread wm4
On Tue, 2 Jan 2018 19:41:39 +0100 "Cyber Sinh" wrote: > Nobody has an idea? > > Thanks. > > Checking AVMEDIA_TYPE seems to be the best way to split audio and video > codecs. > But what is the best way to exclude demuxers and parsers which have no sense > for audio (because they are intended

Re: [FFmpeg-devel] [PATCH v4] lavr: deprecate the entire library

2018-01-02 Thread wm4
On Tue, 2 Jan 2018 16:47:14 + Rostislav Pehlivanov wrote: > On 30 December 2017 at 14:59, Rostislav Pehlivanov > wrote: > > > Deprecate the entire library. Merged years ago to provide compatibility > > with Libav, it remained unmaintained by the FFmpeg project and duplicated > > functionali

[FFmpeg-devel] [PATCH v2 1/2] http: block while waiting for reconnecting

2018-01-02 Thread wm4
It makes no sense to return an error after the first reconnect, and then somehow resume the next time it's called. Usually this will lead to demuxer errors. Make reconnecting block instead, until it has either successfully reconnected, or given up. Also make the wait reasonably interruptible. Sinc

[FFmpeg-devel] [PATCH v2 2/2] http: bump message level for reconnect message and log timeout

2018-01-02 Thread wm4
--- libavformat/http.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/http.c b/libavformat/http.c index 5eff87f8bb..eb029e33a0 100644 --- a/libavformat/http.c +++ b/libavformat/http.c @@ -1455,7 +1455,7 @@ static int http_read_stream(URLContext *h, uint8_t *buf, i

Re: [FFmpeg-devel] [PATCH] lavc/audiotoolboxenc: fix noise in encoded audio

2018-01-02 Thread wm4
On Tue, 2 Jan 2018 22:27:49 +0800 Jiejun Zhang wrote: > On Tue, Jan 2, 2018 at 8:03 PM, Carl Eugen Hoyos wrote: > > 2018-01-02 8:52 GMT+01:00 : > > > >> @@ -565,6 +579,10 @@ static av_cold int ffat_close_encoder(AVCodecContext > >> *avctx) > >> ff_bufqueue_discard_all(&at->frame_queue);

Re: [FFmpeg-devel] [FFmpeg-cvslog] w32pthreads: always use Vista+ API, drop XP support

2018-01-02 Thread wm4
On Tue, 2 Jan 2018 03:55:18 +0100 Michael Niedermayer wrote: > On Tue, Dec 26, 2017 at 01:50:08AM +0000, wm4 wrote: > > ffmpeg | branch: master | wm4 | Thu Dec 21 20:23:14 > > 2017 +0100| [9b121dfc32810250938021952aab4172a988cb56] | committer: wm4 > > > > w32pthr

Re: [FFmpeg-devel] [PATCH] lavc/qsvdec: hw device should be set

2018-01-02 Thread wm4
On Mon, 1 Jan 2018 23:35:42 + Mark Thompson wrote: > On 29/12/17 07:06, Zhong Li wrote: > > Add the flag "AV_CODEC_HW_CONFIG_METHOD_HW_DEVICE_CTX" to indicate > > AVCodecContext.hw_device_ctx should be set before calling > > avcodec_open2() for qsv decoding. > > It is consistent with examples

Re: [FFmpeg-devel] [PATCH] tcp: properly return EOF

2017-12-31 Thread wm4
On Sat, 30 Dec 2017 13:22:37 -0800 Aaron Levinson wrote: > On 12/30/2017 8:44 AM, wm4 wrote: > > There is no POSIX error code for EOF - recv() signals EOF by simply > > returning 0. But libavformat recently changed its conventionts and > > "conventionts" ->

Re: [FFmpeg-devel] [PATCH 2/2] avcodec: mark AV_CODEC_CAP_SUBFRAMES as deprecated

2017-12-31 Thread wm4
On Sun, 31 Dec 2017 13:07:28 + Rostislav Pehlivanov wrote: > The new decoding API supports 1 avpkt -> multiple avframes natively. > > Signed-off-by: Rostislav Pehlivanov > --- > libavcodec/avcodec.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/avcodec.h b/libavco

Re: [FFmpeg-devel] [PATCH 1/2] avformat/http: return EINVAL if ff_http_do_new_request is called with non-http URLContext

2017-12-30 Thread wm4
On Fri, 29 Dec 2017 15:41:57 -0800 Aman Gupta wrote: > From: Aman Gupta > > Signed-off-by: Aman Gupta > --- > libavformat/http.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/libavformat/http.c b/libavformat/http.c > index a376f1a488..8f7e56de54 100644 > --- a/libavformat/htt

Re: [FFmpeg-devel] [PATCH v4] lavr: deprecate the entire library

2017-12-30 Thread wm4
On Sat, 30 Dec 2017 17:21:46 + Derek Buitenhuis wrote: > On 12/30/2017 5:11 PM, Ronald S. Bultje wrote: > > I'm in favour of deprecating and eventually removing it. As Mike used to > > say: you need to break eggs to make omelettes. > > I'm in favour simply because I don't know of a good re

[FFmpeg-devel] [PATCH] http: block while waiting for reconnecting

2017-12-30 Thread wm4
It makes no sense to return an error after the first reconnect, and then somehow resume the next time it's called. Also make the wait reasonably interruptible. Since there is no mechanism for this in the API, polling is the best we can do. (Some effort could be put into making the wait more accura

[FFmpeg-devel] [PATCH] tcp: properly return EOF

2017-12-30 Thread wm4
There is no POSIX error code for EOF - recv() signals EOF by simply returning 0. But libavformat recently changed its conventionts and requires an explicit AVERROR_EOF, or it might get into an endless retry loop, consuming 100% CPU while doing nothing. --- libavformat/tcp.c | 2 ++ 1 file changed,

Re: [FFmpeg-devel] [PATCH v4] lavr: deprecate the entire library

2017-12-30 Thread wm4
On Sat, 30 Dec 2017 14:59:19 + Rostislav Pehlivanov wrote: > Deprecate the entire library. Merged years ago to provide compatibility > with Libav, it remained unmaintained by the FFmpeg project and duplicated > functionality provided by libswresample. > > In order to improve consistency and

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: use AVIOContext new_http_request callback

2017-12-30 Thread wm4
On Sat, 30 Dec 2017 11:53:14 +0100 Nicolas George wrote: > Aman Gupta (2017-12-29): > > It also makes it easier in the future to add http keepalive support to > > other consumers like the dash demuxer and the crypto protocol. > > For that, the API does not need to be public, it just need to be

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: use AVIOContext new_http_request callback

2017-12-30 Thread wm4
On Fri, 29 Dec 2017 23:45:10 +0100 Nicolas George wrote: > Aman Gupta (2017-12-29): > > From: Aman Gupta > > > > This fixes a segfault when streaming from an HLS playlist which uses > > crypto, by ensuring ff_http_do_new_request will never be invoked on a > > non-http URLContext. > > > > Addit

Re: [FFmpeg-devel] [MSVC toolchain] Patch to allow building FFmpeg with Linux bash on Windows (WSL)

2017-12-29 Thread wm4
On Fri, 29 Dec 2017 10:44:21 +0100 Hendrik Leppkes wrote: > On Fri, Dec 29, 2017 at 3:43 AM, Cyber Sinh wrote: > > The attached patch changes the configure script for FFmpeg (and associated > > shell scripts) to call MSVC tools including their extensions (cl.exe instead > > of cl for example). T

Re: [FFmpeg-devel] [PATCH] lavc/qsvdec: hw device should be set

2017-12-29 Thread wm4
On Fri, 29 Dec 2017 15:06:09 +0800 Zhong Li wrote: > Add the flag "AV_CODEC_HW_CONFIG_METHOD_HW_DEVICE_CTX" to indicate > AVCodecContext.hw_device_ctx should be set before calling > avcodec_open2() for qsv decoding. > It is consistent with examples/qsvdec.c. > > It also can make function "hw_dev

Re: [FFmpeg-devel] [PATCH] lavr: deprecate the entire library

2017-12-28 Thread wm4
YPE_KAISER, /**< Kaiser Windowed Sinc > > */ > > }; > > > > -enum AVResampleDitherMethod { > > +enum attribute_deprecated AVResampleDitherMethod { > > AV_RESAMPLE_DITHER_NONE,/**< Do not use dithering */ > > AV_RESAM

Re: [FFmpeg-devel] [PATCH] compat/os2threads: support static mutexes

2017-12-28 Thread wm4
On Thu, 28 Dec 2017 22:03:56 +0900 KO Myung-Hun wrote: > --- > compat/os2threads.h | 14 -- > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/compat/os2threads.h b/compat/os2threads.h > index 40a119ffe1..2177a033ec 100644 > --- a/compat/os2threads.h > +++ b/compat/o

Re: [FFmpeg-devel] [PATCH] h264: add AVOption to set x264_build default

2017-12-27 Thread wm4
On Thu, 28 Dec 2017 00:56:05 +0100 Carl Eugen Hoyos wrote: > 2017-12-26 3:02 GMT+01:00 wm4 : > > On Sat, 23 Dec 2017 03:14:49 +0100 > > wm4 wrote: > > > >> This provides a generic way to the API user to deal with files that > >> either lack this SEI, or

Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/hls: add http_persistent option

2017-12-25 Thread wm4
On Tue, 26 Dec 2017 05:26:34 + Aman Gupta wrote: > On Mon, Dec 25, 2017 at 7:55 PM Aman Gupta wrote: > > > On Mon, Dec 25, 2017 at 6:29 PM wm4 wrote: > > > >> On Tue, 26 Dec 2017 02:14:11 + > >> Aman Gupta wrote: > >> > >>

Re: [FFmpeg-devel] [PATCH v2 2/4] avformat/hls: respect http_persistent only for http playlist urls

2017-12-25 Thread wm4
On Mon, 25 Dec 2017 21:22:59 -0800 Aman Gupta wrote: > From: Aman Gupta > > Fixes a segfault when reading a live playlist (without end tag) from non-http > url (like a file on disk). > > Signed-off-by: Aman Gupta > --- > libavformat/hls.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 dele

Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/hls: add http_persistent option

2017-12-25 Thread wm4
On Tue, 26 Dec 2017 02:14:11 + Aman Gupta wrote: > On Mon, Dec 25, 2017 at 1:03 PM Michael Niedermayer > wrote: > > > On Mon, Dec 25, 2017 at 06:08:11PM +, Aman Gupta wrote: > > > On Mon, Dec 25, 2017 at 9:58 AM Michael Niedermayer > > > > > wrote: > > > > > > > On Fri, Dec 22,

Re: [FFmpeg-devel] [PATCH] h264: add AVOption to set x264_build default

2017-12-25 Thread wm4
On Sat, 23 Dec 2017 03:14:49 +0100 wm4 wrote: > This provides a generic way to the API user to deal with files that > either lack this SEI, or which have the SEI only in packets not passed > to the decoder (such as the common case of the SEI being in the very > firsat video packet,

Re: [FFmpeg-devel] [PATCH v3 1/5] w32pthreads: always use Vista+ API, drop XP support

2017-12-25 Thread wm4
On Sun, 24 Dec 2017 00:51:16 +0100 wm4 wrote: > This removes the XP compatibility code, and switches entirely to SWR > locks, which are available starting at Windows Vista. > > This removes CRITICAL_SECTION use, which allows us to add > PTHREAD_MUTEX_INITIALIZER, which will

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/libx264: fix compilation with x264 builds >= 153

2017-12-25 Thread wm4
On Mon, 25 Dec 2017 19:52:57 -0300 James Almer wrote: > x264 now supports multibitdepth builds, with a slightly changed API to > request bitdepth during initialization. > > Signed-off-by: James Almer > --- > libavcodec/libx264.c | 45 + > 1 file chan

Re: [FFmpeg-devel] [PATCH] avformat/hls: fix compiling error

2017-12-25 Thread wm4
On Mon, 25 Dec 2017 17:21:23 + Aman Gupta wrote: > On Sun, Dec 24, 2017 at 7:48 PM Steven Liu wrote: > > > fix --disable-network compipling error > > > > Signed-off-by: Steven Liu > > --- > > libavformat/hls.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git

Re: [FFmpeg-devel] [PATCH] lavr: deprecate the entire library

2017-12-25 Thread wm4
On Mon, 25 Dec 2017 10:44:40 + Rostislav Pehlivanov wrote: > On 25 December 2017 at 06:50, wm4 wrote: > > > On Mon, 25 Dec 2017 02:12:38 + > > Rostislav Pehlivanov wrote: > > > > > Signed-off-by: Rostislav Pehlivanov > > >

Re: [FFmpeg-devel] [PATCH] lavr: deprecate the entire library

2017-12-24 Thread wm4
On Mon, 25 Dec 2017 02:12:38 + Rostislav Pehlivanov wrote: > Signed-off-by: Rostislav Pehlivanov > --- > doc/APIchanges | 5 + > libavresample/avresample.h | 30 +- > 2 files changed, 30 insertions(+), 5 deletions(-) > > diff --git a/doc/APIchan

Re: [FFmpeg-devel] [PATCH] lavc: add new API for iterating codecs and codec parsers

2017-12-24 Thread wm4
On Sun, 24 Dec 2017 12:43:27 +0100 Michael Niedermayer wrote: > On Sun, Dec 24, 2017 at 02:31:16AM +0100, wm4 wrote: > > On Sun, 24 Dec 2017 02:06:40 +0100 > > Michael Niedermayer wrote: > > > > > If you and others agree we can also easily maintain support f

Re: [FFmpeg-devel] [PATCH] lavc: add new API for iterating codecs and codec parsers

2017-12-23 Thread wm4
On Sun, 24 Dec 2017 02:06:40 +0100 Michael Niedermayer wrote: > If you and others agree we can also easily maintain support for user apps > to register codecs. The only thing needed is to make the array bigger and > add codecs which arent ours in there as long as there is space. > doing this woul

[FFmpeg-devel] [PATCH v3 4/5] lavc, lavf: move avformat static mutex from avcodec to avformat

2017-12-23 Thread wm4
It's completely absurd that libavcodec would care about libavformat locking, but it was there because the lock manager was in libavcodec. This is more stright forward. Changes ABI, but we don't require ABI compatibility currently. --- libavcodec/internal.h | 3 --- libavcodec/utils.c

[FFmpeg-devel] [PATCH v3 5/5] lavc: remove complex debug code around avcodec init locking

2017-12-23 Thread wm4
This is just a lot of complicated and confusing code that had no purpose anymore. Also, the functions return values were checked only sometimes. Locking shouldn't fail anyway, so remove the return values. Barely any other pthread lock calls check the return value (including more important code tha

[FFmpeg-devel] [PATCH v3 2/5] lavc: replace and deprecate the lock manager

2017-12-23 Thread wm4
Use static mutexes instead of requiring a lock manager. The behavior should be roughly the same before and after this change for API users which did not set the lock manager at all (except that a minor memory leak disappears). --- doc/APIchanges | 5 +++ libavcodec/avcodec.h | 8 +++- li

[FFmpeg-devel] [PATCH v3 1/5] w32pthreads: always use Vista+ API, drop XP support

2017-12-23 Thread wm4
This removes the XP compatibility code, and switches entirely to SWR locks, which are available starting at Windows Vista. This removes CRITICAL_SECTION use, which allows us to add PTHREAD_MUTEX_INITIALIZER, which will be useful later. Windows XP is hereby not a supported build target anymore. It

[FFmpeg-devel] [PATCH v3 3/5] ffplay: drop lock manager use

2017-12-23 Thread wm4
Deprecated and useless. --- fftools/ffplay.c | 27 --- 1 file changed, 27 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 10a917194d..9bfa3e6cea 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@ -1284,7 +1284,6 @@ static void do_exit(VideoState *i

Re: [FFmpeg-devel] [PATCH 2/5] lavc: replace and deprecate the lock manager

2017-12-23 Thread wm4
On Sat, 23 Dec 2017 22:32:36 +0100 Michael Niedermayer wrote: > On Thu, Dec 21, 2017 at 11:22:21PM +0100, wm4 wrote: > > Use static mutexes instead of requiring a lock manager. The behavior > > should be roughly the same before and after this change for API users > > which

Re: [FFmpeg-devel] [PATCH] lavc: add new API for iterating codecs and codec parsers

2017-12-23 Thread wm4
On Sat, 23 Dec 2017 13:27:53 + Josh de Kock wrote: > From 1d84641556eea563b82b17a6ffe54226e0e31c4e Mon Sep 17 00:00:00 2001 > From: Josh de Kock > Date: Fri, 22 Dec 2017 22:17:00 + > Subject: [PATCH] lavc: add new API for iterating codecs and codec parsers > > Also replace linked list w

[FFmpeg-devel] [PATCH] h264: add AVOption to set x264_build default

2017-12-22 Thread wm4
This provides a generic way to the API user to deal with files that either lack this SEI, or which have the SEI only in packets not passed to the decoder (such as the common case of the SEI being in the very firsat video packet, but decoding is started somewhere in the middle of the file). Bugs lik

Re: [FFmpeg-devel] [PATCH 2/5] lavc: replace and deprecate the lock manager

2017-12-22 Thread wm4
On Sat, 23 Dec 2017 02:25:11 +0100 Michael Niedermayer wrote: > On Thu, Dec 21, 2017 at 11:22:21PM +0100, wm4 wrote: > > Use static mutexes instead of requiring a lock manager. The behavior > > should be roughly the same before and after this change for API users > > which

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/h264_cabac: Fix CABAC+8x8dct in 4:4:4

2017-12-22 Thread wm4
On Thu, 15 Jun 2017 15:50:31 -0400 "Ronald S. Bultje" wrote: > From: Anton Mitrofanov > > Use the correct ctxIdxInc calculation for coded_block_flag. > Keep old behavior for old versions of x264 for backward compatibility. > > Signed-off-by: Ronald S. Bultje > --- > libavcodec/h264_cabac.c |

Re: [FFmpeg-devel] [PATCH] avformat/internal: log errno with ff_rename failure

2017-12-22 Thread wm4
On Fri, 22 Dec 2017 15:17:33 -0800 Aman Gupta wrote: > From: Aman Gupta > > --- > libavformat/internal.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/internal.h b/libavformat/internal.h > index 36a57214ce..aac566aace 100644 > --- a/libavformat/internal.

Re: [FFmpeg-devel] [PATCH v2] w32pthreads: always use Vista+ API, drop XP support

2017-12-22 Thread wm4
On Fri, 22 Dec 2017 23:17:21 +0100 wm4 wrote: > This removes the XP compatibility code, and switches entirely to SWR > locks, which are available starting at Windows Vista. > > This removes CRITICAL_SECTION use, which allows us to add > PTHREAD_MUTEX_INITIALIZER, which will

[FFmpeg-devel] [PATCH v2] w32pthreads: always use Vista+ API, drop XP support

2017-12-22 Thread wm4
This removes the XP compatibility code, and switches entirely to SWR locks, which are available starting at Windows Vista. This removes CRITICAL_SECTION use, which allows us to add PTHREAD_MUTEX_INITIALIZER, which will be useful later. Windows XP is hereby not a supported build target anymore. It

Re: [FFmpeg-devel] [PATCH 1/5] oma: move some constants into libavcodec

2017-12-22 Thread wm4
On Fri, 22 Dec 2017 22:35:08 +0800 mi...@brew.sh wrote: > From: Misty De Meo > > Most of the constants in libavcodec/oma aren't specific to > libavformat; moving them into libavcodec makes them available to > libavcodec as well as keeping them compatible with libavformat. > > ff_oma_codec_tags

Re: [FFmpeg-devel] [PATCH 1/2] avformat/http: Added a library-internal API for signalling end of chunk

2017-12-21 Thread wm4
On Fri, 22 Dec 2017 12:34:41 +0530 Karthick J wrote: > From: Karthick Jeyapal > > Right now there is no explicit way to signal end of chunk, when http_multiple > is set. > ff_http_do_new_request() function implicitly signals end of chunk. But that > could be too late for certain applications.

Re: [FFmpeg-devel] [PATCH 1/5] w32pthreads: always use Vista+ API, drop XP support

2017-12-21 Thread wm4
On Thu, 21 Dec 2017 22:57:42 -0300 James Almer wrote: > On 12/21/2017 10:49 PM, wm4 wrote: > > On Thu, 21 Dec 2017 22:05:11 -0300 > > James Almer wrote: > > > >> On 12/21/2017 9:40 PM, wm4 wrote: > >>> On Thu, 21 Dec 2017 21:31:37 -0300 > >&

Re: [FFmpeg-devel] [PATCH 1/5] w32pthreads: always use Vista+ API, drop XP support

2017-12-21 Thread wm4
On Thu, 21 Dec 2017 22:05:11 -0300 James Almer wrote: > On 12/21/2017 9:40 PM, wm4 wrote: > > On Thu, 21 Dec 2017 21:31:37 -0300 > > James Almer wrote: > > > >> On 12/21/2017 7:22 PM, wm4 wrote: > >>> This removes the XP compatibility code, and s

Re: [FFmpeg-devel] [PATCH 1/5] w32pthreads: always use Vista+ API, drop XP support

2017-12-21 Thread wm4
On Thu, 21 Dec 2017 21:31:37 -0300 James Almer wrote: > On 12/21/2017 7:22 PM, wm4 wrote: > > This removes the XP compatibility code, and switches entirely to SWR > > locks, which are available starting at Windows Vista. > > > > This removes CRITICAL_SECTION

[FFmpeg-devel] [PATCH 4/5] lavc, lavf: move avformat static mutex from avcodec to avformat

2017-12-21 Thread wm4
It's completely absurd that libavcodec would care about libavformat locking, but it was there because the lock manager was in libavcodec. This is more stright forward. Changes ABI, but we don't require ABI compatibility currently. --- openssl, avisynth, chromaprint build untested --- libavcodec/i

[FFmpeg-devel] [PATCH 3/5] ffplay: drop lock manager use

2017-12-21 Thread wm4
Deprecated and useless. --- fftools/ffplay.c | 27 --- 1 file changed, 27 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 10a917194d..9bfa3e6cea 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@ -1284,7 +1284,6 @@ static void do_exit(VideoState *i

[FFmpeg-devel] [PATCH 2/5] lavc: replace and deprecate the lock manager

2017-12-21 Thread wm4
Use static mutexes instead of requiring a lock manager. The behavior should be roughly the same before and after this change for API users which did not set the lock manager at all (except that a minor memory leak disappears). --- doc/APIchanges | 5 +++ libavcodec/avcodec.h | 8 +++- li

[FFmpeg-devel] [PATCH 5/5] lavc: remove weird debug code around avcodec init locking

2017-12-21 Thread wm4
This is just a lot of complicated and confusing code that does nothing. Also, the functions return values were checked only sometimes. Locking shouldn't fail anyway, so remove the return values. Barely any other pthread lock calls check the return value (including more important code that is more l

[FFmpeg-devel] [PATCH 1/5] w32pthreads: always use Vista+ API, drop XP support

2017-12-21 Thread wm4
This removes the XP compatibility code, and switches entirely to SWR locks, which are available starting at Windows Vista. This removes CRITICAL_SECTION use, which allows us to add PTHREAD_MUTEX_INITIALIZER, which will be useful later. Windows XP is hereby not a supported build target anymore. It

Re: [FFmpeg-devel] [PATCH 1/2] v4l_m2m: add missing AV_CODEC_CAP_DELAY flags

2017-12-21 Thread wm4
On Fri, 15 Dec 2017 12:46:10 +0100 Jorge Ramirez wrote: > On 12/14/2017 07:54 PM, Jorge Ramirez wrote: > > On 12/14/2017 07:48 PM, wm4 wrote: > >> This is pretty much a requirement for any codec that handles modern > >> codecs like h264, but it was missing. Poten

Re: [FFmpeg-devel] [RFC] avcodec/avcodec.h: Add encryption info side data

2017-12-20 Thread wm4
On Wed, 20 Dec 2017 15:10:43 -0800 Jacob Trimble wrote: > From 1508d19e9f7acf43d76010ce54d59ff204613601 Mon Sep 17 00:00:00 2001 > From: Jacob Trimble > Date: Tue, 5 Dec 2017 14:52:22 -0800 > Subject: [PATCH] avcodec/avcodec.h: Add encryption info side data. > > This new side-data will contain

Re: [FFmpeg-devel] [RFC] avcodec/avcodec.h: Add encryption info side data

2017-12-20 Thread wm4
On Wed, 20 Dec 2017 12:07:09 -0800 Jacob Trimble wrote: > On Tue, Dec 19, 2017 at 3:05 PM, wm4 wrote: > > On Tue, 19 Dec 2017 14:20:38 -0800 > > Jacob Trimble wrote: > > > >> > I don't think this is sane. So far, side data could simply be copied > >

Re: [FFmpeg-devel] [RFC] avcodec/avcodec.h: Add encryption info side data

2017-12-19 Thread wm4
On Tue, 19 Dec 2017 14:20:38 -0800 Jacob Trimble wrote: > > You pretty much did. Side data is an ffmpeg internal concept, and if > > your hypothetical streaming protocol needs special support for side > > data, it's automatically relying on ffmpeg internals. > > I thought side data was public

Re: [FFmpeg-devel] [RFC] avcodec/avcodec.h: Add encryption info side data

2017-12-18 Thread wm4
On Tue, 19 Dec 2017 01:14:37 +0100 Michael Niedermayer wrote: > On Tue, Dec 19, 2017 at 12:17:11AM +0100, wm4 wrote: > > On Tue, 19 Dec 2017 00:00:15 +0100 > > Michael Niedermayer wrote: > > > > > On Mon, Dec 18, 2017 at 10:28:14PM +0100, wm4 wrote: > &

Re: [FFmpeg-devel] [RFC] avcodec/avcodec.h: Add encryption info side data

2017-12-18 Thread wm4
On Tue, 19 Dec 2017 00:36:36 +0100 Carl Eugen Hoyos wrote: > 2017-12-19 0:17 GMT+01:00 wm4 : > > [...] > > Instead of sending random insults, could you just go away? Why don't you follow your own advice? At this point you're acting like a miserable troll who

Re: [FFmpeg-devel] [RFC] avcodec/avcodec.h: Add encryption info side data

2017-12-18 Thread wm4
On Tue, 19 Dec 2017 00:00:15 +0100 Michael Niedermayer wrote: > On Mon, Dec 18, 2017 at 10:28:14PM +0100, wm4 wrote: > > On Mon, 18 Dec 2017 22:17:14 +0100 > > Michael Niedermayer wrote: > > > > > On Mon, Dec 18, 2017 at 10:02:52PM +0100, wm4 wrote: > &

Re: [FFmpeg-devel] [RFC] avcodec/avcodec.h: Add encryption info side data

2017-12-18 Thread wm4
On Mon, 18 Dec 2017 22:17:14 +0100 Michael Niedermayer wrote: > On Mon, Dec 18, 2017 at 10:02:52PM +0100, wm4 wrote: > > On Mon, 18 Dec 2017 21:38:24 +0100 > > Michael Niedermayer wrote: > > > > > On Mon, Dec 18, 2017 at 04:56:08PM -0300, James Almer wrote:

Re: [FFmpeg-devel] [RFC] avcodec/avcodec.h: Add encryption info side data

2017-12-18 Thread wm4
On Mon, 18 Dec 2017 21:38:24 +0100 Michael Niedermayer wrote: > On Mon, Dec 18, 2017 at 04:56:08PM -0300, James Almer wrote: > > On 12/18/2017 4:52 PM, wm4 wrote: > > > On Fri, 15 Dec 2017 14:24:17 -0800 > > > Jacob Trimble wrote: > > > > > >&g

Re: [FFmpeg-devel] [RFC] avcodec/avcodec.h: Add encryption info side data

2017-12-18 Thread wm4
On Mon, 18 Dec 2017 16:56:08 -0300 James Almer wrote: > On 12/18/2017 4:52 PM, wm4 wrote: > > On Fri, 15 Dec 2017 14:24:17 -0800 > > Jacob Trimble wrote: > > > >> From a1b2cbcb7da4da69685f8f1299b70b672ce448e3 Mon Sep 17 00:00:00 2001 > >> From: Jacob Tr

Re: [FFmpeg-devel] [RFC] avcodec/avcodec.h: Add encryption info side data

2017-12-18 Thread wm4
On Fri, 15 Dec 2017 14:24:17 -0800 Jacob Trimble wrote: > From a1b2cbcb7da4da69685f8f1299b70b672ce448e3 Mon Sep 17 00:00:00 2001 > From: Jacob Trimble > Date: Tue, 5 Dec 2017 14:52:22 -0800 > Subject: [PATCH] avcodec/avcodec.h: Add encryption info side data. > > This new side-data will contain

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/vf_aspect: change outlink sample aspect ratio instead of inlink

2017-12-17 Thread wm4
On Sun, 17 Dec 2017 14:03:49 +0100 Carl Eugen Hoyos wrote: > 2017-12-17 13:53 GMT+01:00 wm4 : > > > This is a project of volunteers. If you don't want to commit to the > > rules and responsibilities of the project, you can just remove yourself > > from the main

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/vf_aspect: change outlink sample aspect ratio instead of inlink

2017-12-17 Thread wm4
On Sun, 17 Dec 2017 13:02:14 +0100 Nicolas George wrote: > Paul B Mahol (2017-12-16): > > What's wrong then your highness? > > What makes you think it is acceptable to talk to people that way? Oh boy this sure is a civil and friendly project. What makes _you_ think it's acceptable to treat p

Re: [FFmpeg-devel] [PATCH 08/25] fftools/ffplay: support only limited color range

2017-12-17 Thread wm4
On Sat, 16 Dec 2017 11:12:28 +0100 Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > fftools/ffplay.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/fftools/ffplay.c b/fftools/ffplay.c > index 10a917194d..f023c81575 100644 > --- a/fftools/ffplay.c > +++ b

Re: [FFmpeg-devel] [PATCH 13/14] mmal: add option copy_frame to support retrieving sw frames w/o copy

2017-12-16 Thread wm4
On Sat, 16 Dec 2017 20:26:56 +0800 Wang Bin wrote: > 2017-12-16 19:47 GMT+08:00 wm4 : > > On Sat, 16 Dec 2017 13:48:05 +0800 > > Wang Bin wrote: > > > >> 2017-12-16 2:50 GMT+08:00 wm4 : > >> > On Fri, 15 Dec 2017 15:05:50 +0800 > >> > wb

Re: [FFmpeg-devel] [PATCH 13/14] mmal: add option copy_frame to support retrieving sw frames w/o copy

2017-12-16 Thread wm4
On Sat, 16 Dec 2017 13:48:05 +0800 Wang Bin wrote: > 2017-12-16 2:50 GMT+08:00 wm4 : > > On Fri, 15 Dec 2017 15:05:50 +0800 > > wbse...@gmail.com wrote: > > > >> From: wang-bin > >> > >> mmal buffer->data is already in host memory. A

<    1   2   3   4   5   6   7   8   9   10   >