: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Philip
Langdale
Sent: Tuesday, February 28, 2017 5:54 AM
To: Miroslav Slugeň
Cc: FFmpeg development discussions and patches
Subject: Re: [FFmpeg-devel] [PATCH] Remove qmin and qmax constraints for nvenc
vbr
On Tue, 28 Feb 2017 11:54
> Patch looks good to me too. Timo, I can push it if you don't mind not
> testing it yourself.
I have some stilistic nits, otherwise it's ok.
It leaves the fall through comment dangling, even though there is no
fall through anymore.
And it could use fallthrough to in the new location of RC_(2_PASS
On Tue, 28 Feb 2017 11:54:32 +0100
Miroslav Slugeň wrote:
> Dne 28.2.2017 v 10:44 Timo Rothenpieler napsal(a):
> > Am 28.02.2017 um 01:24 schrieb Ganapathy Raman Kasi:
> >> Can someone please help review patch. Thanks.
> > I have seen an marked it, but I don't have time to review and test
> >
Dne 28.2.2017 v 10:44 Timo Rothenpieler napsal(a):
Am 28.02.2017 um 01:24 schrieb Ganapathy Raman Kasi:
Can someone please help review patch. Thanks.
I have seen an marked it, but I don't have time to review and test stuff
right now.
Will get to it eventually.
__
Am 28.02.2017 um 01:24 schrieb Ganapathy Raman Kasi:
> Can someone please help review patch. Thanks.
I have seen an marked it, but I don't have time to review and test stuff
right now.
Will get to it eventually.
___
ffmpeg-devel mailing list
ffmpeg-devel
] [PATCH] Remove qmin and qmax constraints for nvenc vbr
Hi,
qmin and qmax are not necessary for nvenc vbr. Enforcing this constraint,
doesn't allow user to use vbr 2 pass mode (
NV_ENC_PARAMS_RC_2_PASS_VBR) without explicity setting the qmin and qmax
options and reverts to the default vbr
: Re: [FFmpeg-devel] [PATCH] Remove qmin and qmax constraints for nvenc
vbr
Adding on to the previous mail,
To test this patch, please try :
i) ffmpeg -y -i $INPUT -vcodec h264_nvenc -preset medium $OUT_medium.mp4
ii) ffmpeg -y -i $INPUT -vcodec h264_nvenc -preset slow $OUT_slow.mp4
Without patch
: Thursday, February 23, 2017 5:42 PM
To: FFmpeg development discussions and patches
Subject: [FFmpeg-devel] [PATCH] Remove qmin and qmax constraints for nvenc vbr
Hi,
qmin and qmax are not necessary for nvenc vbr. Enforcing this constraint,
doesn't allow user to use vbr 2 pass
Hi,
qmin and qmax are not necessary for nvenc vbr. Enforcing this constraint,
doesn't allow user to use vbr 2 pass mode (
NV_ENC_PARAMS_RC_2_PASS_VBR) without explicity setting the qmin and qmax
options and reverts to the default vbr mode (
NV_ENC_PARAMS_RC_VBR). If needed user can still set
