Re: [FFmpeg-devel] [PATCH] avcodec: Remove libfaac, the internal AAC encoder is better

2016-08-16 Thread Paul B Mahol
On 8/16/16, Roger Pack wrote: > On 4/10/16, Michael Niedermayer wrote: >> On Sun, Apr 10, 2016 at 07:29:05PM +0100, Rostislav Pehlivanov wrote: >>> On 10 April 2016 at 17:42, Michael Niedermayer >>> wrote: >>> >>> > On Sun, Apr 10, 2016 at 04:38:35PM +0100, Kieran Kunhya wrote: >>> > > --- >>> >

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libfaac, the internal AAC encoder is better

2016-08-16 Thread Roger Pack
On 4/10/16, Michael Niedermayer wrote: > On Sun, Apr 10, 2016 at 07:29:05PM +0100, Rostislav Pehlivanov wrote: >> On 10 April 2016 at 17:42, Michael Niedermayer >> wrote: >> >> > On Sun, Apr 10, 2016 at 04:38:35PM +0100, Kieran Kunhya wrote: >> > > --- >> > > Changelog | 1 + >> >

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libfaac, the internal AAC encoder is better

2016-08-16 Thread Robert Krüger
On Mon, Aug 15, 2016 at 7:47 PM, Rostislav Pehlivanov wrote: > On 15 August 2016 at 11:51, Robert Krüger > wrote: > > > On Sun, Aug 14, 2016 at 5:05 PM, Rostislav Pehlivanov < > atomnu...@gmail.com > > > > > wrote: > > > > > On 10 April 2016 at 16:38, Kieran Kunhya wrote: > > > > > > http://ffm

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libfaac, the internal AAC encoder is better

2016-08-16 Thread Robert Krüger
On Mon, Aug 15, 2016 at 7:58 PM, Nicolas George wrote: > Le nonidi 29 thermidor, an CCXXIV, Rostislav Pehlivanov a écrit : > > The git master is fast changing and can happen API or setting > > wise every day. Deprecations, behavioral changes, etc. This is why users > > who need stability use the

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libfaac, the internal AAC encoder is better

2016-08-15 Thread Nicolas George
Le nonidi 29 thermidor, an CCXXIV, Rostislav Pehlivanov a écrit : > The git master is fast changing and can happen API or setting > wise every day. Deprecations, behavioral changes, etc. This is why users > who need stability use the stable releases. Actually, I think the consensus is that releas

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libfaac, the internal AAC encoder is better

2016-08-15 Thread Rostislav Pehlivanov
On 15 August 2016 at 11:51, Robert Krüger wrote: > On Sun, Aug 14, 2016 at 5:05 PM, Rostislav Pehlivanov > > wrote: > > > On 10 April 2016 at 16:38, Kieran Kunhya wrote: > > > > > --- > > > Changelog | 1 + > > > configure | 6 -- > > > doc/encoders.texi | 10

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libfaac, the internal AAC encoder is better

2016-08-15 Thread Robert Krüger
On Sun, Aug 14, 2016 at 5:05 PM, Rostislav Pehlivanov wrote: > On 10 April 2016 at 16:38, Kieran Kunhya wrote: > > > --- > > Changelog | 1 + > > configure | 6 -- > > doc/encoders.texi | 105 - > > doc/ffserver.conf | 2 +- > > doc/

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libfaac, the internal AAC encoder is better

2016-08-15 Thread Carl Eugen Hoyos
Hi! > Am 14.08.2016 um 18:20 schrieb Rostislav Pehlivanov : > >> On 14 August 2016 at 16:10, Carl Eugen Hoyos wrote: >> >> Needs a corresponding news entry imo. > > As in the changelog or the website news? Both are necessary imo: I'd really like to point the users asking to the news entry. T

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libfaac, the internal AAC encoder is better

2016-08-14 Thread Rostislav Pehlivanov
On 14 August 2016 at 16:10, Carl Eugen Hoyos wrote: > Hi! > > Needs a corresponding news entry imo. > > Carl Eugen > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > As in the changelog or th

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libfaac, the internal AAC encoder is better

2016-08-14 Thread Carl Eugen Hoyos
Hi! Needs a corresponding news entry imo. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libfaac, the internal AAC encoder is better

2016-08-14 Thread Rostislav Pehlivanov
On 10 April 2016 at 16:38, Kieran Kunhya wrote: > --- > Changelog | 1 + > configure | 6 -- > doc/encoders.texi | 105 - > doc/ffserver.conf | 2 +- > doc/general.texi | 2 +- > doc/muxers.texi| 4 +- > doc/platform

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libfaac, the internal AAC encoder is better

2016-04-10 Thread Michael Niedermayer
On Sun, Apr 10, 2016 at 08:49:16PM +, Kieran Kunhya wrote: > On Sun, 10 Apr 2016 at 21:39 Michael Niedermayer > wrote: > > > On Sun, Apr 10, 2016 at 11:00:23PM +0300, Jan Ekstrom wrote: > > > Hi, > > > > > > On Sun, Apr 10, 2016 at 10:13 PM, Michael Niedermayer > > > wrote: > > > > This is n

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libfaac, the internal AAC encoder is better

2016-04-10 Thread Kieran Kunhya
On Sun, 10 Apr 2016 at 21:39 Michael Niedermayer wrote: > On Sun, Apr 10, 2016 at 11:00:23PM +0300, Jan Ekstrom wrote: > > Hi, > > > > On Sun, Apr 10, 2016 at 10:13 PM, Michael Niedermayer > > wrote: > > > This is not about changing a bad encoder to a good encoder, this patch > > > is about remo

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libfaac, the internal AAC encoder is better

2016-04-10 Thread Michael Niedermayer
On Sun, Apr 10, 2016 at 11:00:23PM +0300, Jan Ekstrom wrote: > Hi, > > On Sun, Apr 10, 2016 at 10:13 PM, Michael Niedermayer > wrote: > > This is not about changing a bad encoder to a good encoder, this patch > > is about removing choices. > > Before this patch users can force libfaac and have tw

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libfaac, the internal AAC encoder is better

2016-04-10 Thread Lou Logan
On Sun, Apr 10, 2016, at 12:00 PM, Jan Ekstrom wrote: > Additionally, as a minor not-really-related anecdote, I have only seen > people on #ffmpeg having -c:a/-acodec libfaac on their command lines > when they have followed very old tutorials from up to just before > fdk-aac got published. From t

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libfaac, the internal AAC encoder is better

2016-04-10 Thread Jan Ekstrom
Hi, On Sun, Apr 10, 2016 at 10:13 PM, Michael Niedermayer wrote: > This is not about changing a bad encoder to a good encoder, this patch > is about removing choices. > Before this patch users can force libfaac and have twice as long > battery life at lower quality after the patch the users do no

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libfaac, the internal AAC encoder is better

2016-04-10 Thread Kieran Kunhya
On Sun, 10 Apr 2016 at 20:46 Michael Niedermayer wrote: > On Sun, Apr 10, 2016 at 09:24:21PM +0200, wm4 wrote: > > On Sun, 10 Apr 2016 21:13:13 +0200 > > Michael Niedermayer wrote: > > > > > On Sun, Apr 10, 2016 at 07:29:05PM +0100, Rostislav Pehlivanov wrote: > > > > On 10 April 2016 at 17:42,

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libfaac, the internal AAC encoder is better

2016-04-10 Thread Michael Niedermayer
On Sun, Apr 10, 2016 at 04:34:02PM -0300, Claudio Freire wrote: > On Sun, Apr 10, 2016 at 4:13 PM, Michael Niedermayer > wrote: > > that said, to be blunt, make your encoder be capable to encode as fast > > and as good quality as libfaac and after that remove libfaac support > > if you want. > >

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libfaac, the internal AAC encoder is better

2016-04-10 Thread Michael Niedermayer
On Sun, Apr 10, 2016 at 09:24:21PM +0200, wm4 wrote: > On Sun, 10 Apr 2016 21:13:13 +0200 > Michael Niedermayer wrote: > > > On Sun, Apr 10, 2016 at 07:29:05PM +0100, Rostislav Pehlivanov wrote: > > > On 10 April 2016 at 17:42, Michael Niedermayer > > > wrote: > > > > > > > On Sun, Apr 10, 20

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libfaac, the internal AAC encoder is better

2016-04-10 Thread Claudio Freire
On Sun, Apr 10, 2016 at 4:13 PM, Michael Niedermayer wrote: > that said, to be blunt, make your encoder be capable to encode as fast > and as good quality as libfaac and after that remove libfaac support > if you want. I could make a small patch that could do just that, I believe. I've always m

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libfaac, the internal AAC encoder is better

2016-04-10 Thread wm4
On Sun, 10 Apr 2016 21:13:13 +0200 Michael Niedermayer wrote: > On Sun, Apr 10, 2016 at 07:29:05PM +0100, Rostislav Pehlivanov wrote: > > On 10 April 2016 at 17:42, Michael Niedermayer > > wrote: > > > > > On Sun, Apr 10, 2016 at 04:38:35PM +0100, Kieran Kunhya wrote: > > > > --- > > > > C

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libfaac, the internal AAC encoder is better

2016-04-10 Thread Michael Niedermayer
On Sun, Apr 10, 2016 at 07:29:05PM +0100, Rostislav Pehlivanov wrote: > On 10 April 2016 at 17:42, Michael Niedermayer > wrote: > > > On Sun, Apr 10, 2016 at 04:38:35PM +0100, Kieran Kunhya wrote: > > > --- > > > Changelog | 1 + > > > configure | 6 -- > > > doc/en

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libfaac, the internal AAC encoder is better

2016-04-10 Thread Derek Buitenhuis
On 4/10/2016 8:09 PM, Rostislav Pehlivanov wrote: > There are far less users of libfaac than libstagefright, so I think just a > changelog entry would be enough. I very much doubt this. Very few people could even *compile* the libstagefright code. - Derek

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libfaac, the internal AAC encoder is better

2016-04-10 Thread Rostislav Pehlivanov
On 10 April 2016 at 19:43, Carl Eugen Hoyos wrote: > Kieran Kunhya kunhya.com> writes: > > [...] > > While it's - unfortunately - still too early to remove, this > will also need a news entry. > > We've removed far bigger things (libstagefright) without a news entry. There are far less users of

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libfaac, the internal AAC encoder is better

2016-04-10 Thread Carl Eugen Hoyos
Kieran Kunhya kunhya.com> writes: [...] While it's - unfortunately - still too early to remove, this will also need a news entry. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libfaac, the internal AAC encoder is better

2016-04-10 Thread Rostislav Pehlivanov
On 10 April 2016 at 17:42, Michael Niedermayer wrote: > On Sun, Apr 10, 2016 at 04:38:35PM +0100, Kieran Kunhya wrote: > > --- > > Changelog | 1 + > > configure | 6 -- > > doc/encoders.texi | 105 - > > doc/ffserver.conf | 2 +- > >

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libfaac, the internal AAC encoder is better

2016-04-10 Thread Reimar Döffinger
On 10.04.2016, at 20:00, Derek Buitenhuis wrote: > On 4/10/2016 5:42 PM, Michael Niedermayer wrote: >> this is not possible currently libfaac is twice as fast than the >> native encoder. > > Twice as fast and produces crap output. Someone like me almost certain doesn't notice that it's crap. I'

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libfaac, the internal AAC encoder is better

2016-04-10 Thread Derek Buitenhuis
On 4/10/2016 5:42 PM, Michael Niedermayer wrote: > this is not possible currently libfaac is twice as fast than the > native encoder. Twice as fast and produces crap output. Personally I think 31x realtime (which is the example you've given) is pretty quick. I somewhat double people are using t

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libfaac, the internal AAC encoder is better

2016-04-10 Thread Michael Niedermayer
On Sun, Apr 10, 2016 at 04:38:35PM +0100, Kieran Kunhya wrote: > --- > Changelog | 1 + > configure | 6 -- > doc/encoders.texi | 105 - > doc/ffserver.conf | 2 +- > doc/general.texi | 2 +- > doc/muxers.texi| 4 +- >

[FFmpeg-devel] [PATCH] avcodec: Remove libfaac, the internal AAC encoder is better

2016-04-10 Thread Kieran Kunhya
--- Changelog | 1 + configure | 6 -- doc/encoders.texi | 105 - doc/ffserver.conf | 2 +- doc/general.texi | 2 +- doc/muxers.texi| 4 +- doc/platform.texi | 2 +- libavcodec/Makefile| 1 - libavcodec/al