Re: [FFmpeg-devel] [PATCH 1/2] avcodec: Add Cineform HD Decoder

2016-01-10 Thread Piotr Bandurski
Hi, Great work, but I found some issues. This I got with fuzzed file: ==13422== Invalid read of size 4 ==13422==at 0x834D003: cfhd_decode (cfhd.c:293) ==13422==by 0x863D051: frame_worker_thread (pthread_frame.c:147) ==13422==by 0x40ECF6F: start_thread (pthread_create.c:312) ==13422==

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: Add Cineform HD Decoder

2016-01-10 Thread Derek Buitenhuis
On 1/10/2016 1:54 AM, James Almer wrote: >> +AVCodec ff_cfhd_decoder = { >> +.name = "cfhd", >> +.long_name = NULL_IF_CONFIG_SMALL("Cineform HD"), >> +.type = AVMEDIA_TYPE_VIDEO, >> +.id = AV_CODEC_ID_CFHD, >> +.priv_data_size = sizeof(CFHDCo

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: Add Cineform HD Decoder

2016-01-09 Thread James Almer
On 1/9/2016 9:28 PM, Kieran Kunhya wrote: > --- > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/avcodec.h| 1 + > libavcodec/cfhd.c | 565 > > libavcodec/cfhd.h | 99 + > libavcodec/cfhd

[FFmpeg-devel] [PATCH 1/2] avcodec: Add Cineform HD Decoder

2016-01-09 Thread Kieran Kunhya
--- libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h| 1 + libavcodec/cfhd.c | 565 libavcodec/cfhd.h | 99 + libavcodec/cfhddata.c | 470 li