Re: [FFmpeg-devel] [PATCH] avcodec: add OpenJPEG 2.x compatibility

2015-11-19 Thread Moritz Barsnick
On Wed, Nov 18, 2015 at 21:22:57 -0800, Michael Bradshaw wrote: > if (!dec) { > av_log(avctx, AV_LOG_ERROR, "Error initializing decoder.\n"); > -return AVERROR_UNKNOWN; > +ret = AVERROR_EXTERNAL; > +goto done; > } [...] > if (!stream) { > av

Re: [FFmpeg-devel] [PATCH 3/6] lavf/tee: use lavf API for applying bitstream filters

2015-11-19 Thread Nicolas George
L'octidi 28 brumaire, an CCXXIV, Rodger Combs a écrit : > --- > libavformat/tee.c | 43 ++- > 1 file changed, 2 insertions(+), 41 deletions(-) Still LGTM, thanks. Regards, -- Nicolas George signature.asc Description: Digital signature ___

Re: [FFmpeg-devel] UDP constant bitrate feature (cbr)

2015-11-19 Thread Michael Niedermayer
On Wed, Nov 18, 2015 at 08:54:13PM -0800, Zach Swena wrote: [...] > Is udp.c supposed to work with any other multiplexer then > mpegts? In my experience it doesn't. udp can work with any muxer that does not require seeking (if all packets are received at the receiver end) if OTOH some packets ar

[FFmpeg-devel] [PATCH] swscale/arm: add ff_nv{12, 21}_to_{argb, rgba, abgr, bgra}_neon

2015-11-19 Thread Clément Bœsch
From: Matthieu Bouron Signed-off-by: Matthieu Bouron Signed-off-by: Clément Bœsch --- The function takes about 29ms with a 1080p source (testsrc2) on a cortex-a8. Though, 16ms (more than half the time!) is spend in the vst2 call. Any suggestion on how to speed up this? Also, the reference cod

Re: [FFmpeg-devel] [PATCH] swscale/arm: add ff_nv{12, 21}_to_{argb, rgba, abgr, bgra}_neon

2015-11-19 Thread Clément Bœsch
On Thu, Nov 19, 2015 at 11:48:53AM +0100, Clément Bœsch wrote: [...] > +vst2.32 {q6, q7}, [\dst,:128]! Sorry, this is supposed to be vst4.8 -- Clément B. signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-de

Re: [FFmpeg-devel] UDP constant bitrate feature (cbr)

2015-11-19 Thread Kieran Kunhya
> Why is there a udp stream output option then? Are you trying to say that > this isn't a bug because FFmpeg isn't supposed to be able to stream? I am > using FFmpeg mpeg2video as the encoder and multiplexing with mpegts. The > data FFmpeg produces is fine, it just doesn't send it quite right.

Re: [FFmpeg-devel] [PATCH 2/4] lavf/utils: avoid decoding a frame to get the codec parameters

2015-11-19 Thread Matthieu Bouron
On Mon, Nov 16, 2015 at 11:16:42AM -0500, Ronald S. Bultje wrote: > Hi, > > On Mon, Nov 16, 2015 at 11:06 AM, Matthieu Bouron > wrote: > > > On Sun, Nov 15, 2015 at 08:12:57AM -0500, Ronald S. Bultje wrote: > > > Hi, > > > > Hi, > > > > > > > > On Sun, Nov 15, 2015 at 4:49 AM, Matthieu Bouron <

Re: [FFmpeg-devel] UDP constant bitrate feature (cbr)

2015-11-19 Thread Pavel Meshkov
FYI, our awful hack looks like almost working except sometimes effective bitrate lost for 1-2 seconds, then spike and then returns to normal (it can be once after 15 minutes or after more than 4 hours before this issue). Also there is a question: how it supposed schedule to send packets of 131

[FFmpeg-devel] Using ASAN address sanitizer

2015-11-19 Thread floyd
Hi there I had an issue when trying to use Address Sanitizer with ffmpeg, I'm using the git version with latest commit being 50ce510ac4e3ed093c051738242a9a75aeeb36ce. Although I had similar problems in the past for quiet a while. The configure script works fine without address sanitizer: CFLAGS="

Re: [FFmpeg-devel] UDP constant bitrate feature (cbr)

2015-11-19 Thread Kieran Kunhya
On 19 November 2015 at 12:00, Pavel Meshkov wrote: > FYI, our awful hack looks like almost working except sometimes effective > bitrate lost for 1-2 seconds, then spike and then returns to normal (it can > be once after 15 minutes or after more than 4 hours before this issue). > > Also there is a

Re: [FFmpeg-devel] [PATCH 1/3] aacsbr_fixed: avoid division by zero in sbr_gain_calc

2015-11-19 Thread Michael Niedermayer
On Thu, Nov 19, 2015 at 01:31:19AM +0100, Michael Niedermayer wrote: > On Thu, Nov 19, 2015 at 12:31:17AM +0100, Andreas Cadhalpun wrote: > > On 16.11.2015 13:46, Michael Niedermayer wrote: > > > On Fri, Nov 13, 2015 at 11:19:44PM +0100, Andreas Cadhalpun wrote: > > >> Well, unfortunately just reje

Re: [FFmpeg-devel] Using ASAN address sanitizer

2015-11-19 Thread Ronald S. Bultje
Hi Floyd, On Thu, Nov 19, 2015 at 7:09 AM, floyd wrote: > Hi there > > I had an issue when trying to use Address Sanitizer with ffmpeg, I'm > using the git version with latest commit being > 50ce510ac4e3ed093c051738242a9a75aeeb36ce. Although I had similar > problems in the past for quiet a while

Re: [FFmpeg-devel] [PATCH] all: use M_SQRT1_2, M_SQRT2, M_PI

2015-11-19 Thread Ganesh Ajjanagadde
On Sat, Nov 14, 2015 at 11:15 AM, Ganesh Ajjanagadde wrote: > > This uses M_SQRT1_2, M_SQRT2, and M_PI instead of the actual literals. > Benefits include: > 1. Reduced scope for copy/paste errors and improved readability. > 2. Consistency across the codebase. > 3. Actually fixes an incorrect sqrt(

[FFmpeg-devel] [PATCH 0/8] replacing #define by typedef

2015-11-19 Thread Ganesh Ajjanagadde
#define is often abused for doing typedefs. Usually there is no issue, but the usage is unnecessarily risky and should be avoided. Concrete example taken from https://stackoverflow.com/questions/1666353/are-typedef-and-define-the-same-in-c: typedef int* int_p1; int_p1 a, b, c; // a, b, c are all po

[FFmpeg-devel] [PATCH 1/8] avcodec/lpc: replace #define by typedef

2015-11-19 Thread Ganesh Ajjanagadde
See e.g https://stackoverflow.com/questions/1666353/are-typedef-and-define-the-same-in-c for rationale. Signed-off-by: Ganesh Ajjanagadde --- libavcodec/lpc.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/lpc.h b/libavcodec/lpc.h index 7e0ee3e..edb1a6b 100

[FFmpeg-devel] [PATCH 2/8] avcodec/aac_defines: replace #define by typedef

2015-11-19 Thread Ganesh Ajjanagadde
See e.g https://stackoverflow.com/questions/1666353/are-typedef-and-define-the-same-in-c for rationale. Signed-off-by: Ganesh Ajjanagadde --- libavcodec/aac_defines.h | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/libavcodec/aac_defines.h b/libavcodec

[FFmpeg-devel] [PATCH 3/8] avcodec/ac3: replace #define by typedef

2015-11-19 Thread Ganesh Ajjanagadde
See e.g https://stackoverflow.com/questions/1666353/are-typedef-and-define-the-same-in-c for rationale. Signed-off-by: Ganesh Ajjanagadde --- libavcodec/ac3.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/ac3.h b/libavcodec/ac3.h index 3676b4e..747f2f5 1

[FFmpeg-devel] [PATCH 4/8] avcodec/aacps_tablegen_template: replace #define by typedef

2015-11-19 Thread Ganesh Ajjanagadde
See e.g https://stackoverflow.com/questions/1666353/are-typedef-and-define-the-same-in-c for rationale. Signed-off-by: Ganesh Ajjanagadde --- libavcodec/aacps_tablegen_template.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/aacps_tablegen_template.c b/liba

[FFmpeg-devel] [PATCH 5/8] avcodec/amr: replace #define by typedef

2015-11-19 Thread Ganesh Ajjanagadde
See e.g https://stackoverflow.com/questions/1666353/are-typedef-and-define-the-same-in-c for rationale. Signed-off-by: Ganesh Ajjanagadde --- libavcodec/amr.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/amr.h b/libavcodec/amr.h index 1ac73ab..727f8c3 10064

[FFmpeg-devel] [PATCH 6/8] tests/tiny_ssim: replace #define by typedef

2015-11-19 Thread Ganesh Ajjanagadde
See e.g https://stackoverflow.com/questions/1666353/are-typedef-and-define-the-same-in-c for rationale. Signed-off-by: Ganesh Ajjanagadde --- tests/tiny_ssim.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/tiny_ssim.c b/tests/tiny_ssim.c index 9f355a3..ebd0216 1

[FFmpeg-devel] [PATCH 7/8] avcodec/faanidct: replace #define by typedef

2015-11-19 Thread Ganesh Ajjanagadde
See e.g https://stackoverflow.com/questions/1666353/are-typedef-and-define-the-same-in-c for rationale. Signed-off-by: Ganesh Ajjanagadde --- libavcodec/faanidct.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/faanidct.c b/libavcodec/faanidct.c index ca82f77..bb

[FFmpeg-devel] [PATCH 2/3] avcodec/aacsbr: Add comment about possibly optimization in sbr_dequant()

2015-11-19 Thread Michael Niedermayer
From: Michael Niedermayer Signed-off-by: Michael Niedermayer --- libavcodec/aacsbr.c |1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/aacsbr.c b/libavcodec/aacsbr.c index d1e3a91..e014646 100644 --- a/libavcodec/aacsbr.c +++ b/libavcodec/aacsbr.c @@ -73,6 +73,7 @@ static void s

[FFmpeg-devel] [PATCH 8/8] avcodec/resample2: replace #define by typedef

2015-11-19 Thread Ganesh Ajjanagadde
See e.g https://stackoverflow.com/questions/1666353/are-typedef-and-define-the-same-in-c for rationale. Signed-off-by: Ganesh Ajjanagadde --- libavcodec/resample2.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/resample2.c b/libavcodec/resample2.c i

[FFmpeg-devel] [PATCH 1/3] avcodec/aacsbr: Split the env_facs table

2015-11-19 Thread Michael Niedermayer
From: Michael Niedermayer This also removes a #ifdef and special case for the fixed point case Signed-off-by: Michael Niedermayer --- libavcodec/aacsbr.c |6 +++--- libavcodec/aacsbr_fixed.c|6 +++--- libavcodec/aacsbr_template.c | 42

[FFmpeg-devel] [PATCH 3/3] avcodec/aacsbr_template: Add Check to read_sbr_envelope()

2015-11-19 Thread Michael Niedermayer
From: Michael Niedermayer The limit is a conservative guess, the spec does not seem to specify a limit Signed-off-by: Michael Niedermayer --- libavcodec/aacsbr_template.c | 41 + 1 file changed, 33 insertions(+), 8 deletions(-) diff --git a/libavcodec

Re: [FFmpeg-devel] Using ASAN address sanitizer

2015-11-19 Thread floyd
Ok, maybe someone could instead confirm that it is this issue (seems most likely): https://savannah.gnu.org/patch/?8775 And if one of the main devs could comment on that bug that would probably be helpful too (so it gets prioritized) On 19/11/15 13:09, floyd wrote: > Hi there > > I had an issue

Re: [FFmpeg-devel] [PATCH 6/8] tests/tiny_ssim: replace #define by typedef

2015-11-19 Thread Ronald S. Bultje
Hi, On Thu, Nov 19, 2015 at 8:14 AM, Ganesh Ajjanagadde wrote: > See e.g > https://stackoverflow.com/questions/1666353/are-typedef-and-define-the-same-in-c > for rationale. > > Signed-off-by: Ganesh Ajjanagadde > --- > tests/tiny_ssim.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions

Re: [FFmpeg-devel] [PATCH 6/8] tests/tiny_ssim: replace #define by typedef

2015-11-19 Thread Ganesh Ajjanagadde
On Thu, Nov 19, 2015 at 8:36 AM, Ronald S. Bultje wrote: > Hi, > > On Thu, Nov 19, 2015 at 8:14 AM, Ganesh Ajjanagadde > wrote: >> >> See e.g >> https://stackoverflow.com/questions/1666353/are-typedef-and-define-the-same-in-c >> for rationale. >> >> Signed-off-by: Ganesh Ajjanagadde >> --- >> t

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/aacsbr: Add comment about possibly optimization in sbr_dequant()

2015-11-19 Thread Ganesh Ajjanagadde
On Thu, Nov 19, 2015 at 8:17 AM, Michael Niedermayer wrote: > From: Michael Niedermayer > > Signed-off-by: Michael Niedermayer > --- > libavcodec/aacsbr.c |1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/aacsbr.c b/libavcodec/aacsbr.c > index d1e3a91..e014646 100644 > ---

Re: [FFmpeg-devel] [PATCH 1/6] lavf: add API to apply a list of bsfs to a packet

2015-11-19 Thread Michael Niedermayer
On Wed, Nov 18, 2015 at 05:28:17PM -0600, Rodger Combs wrote: > --- > libavformat/avformat.h | 8 > libavformat/utils.c| 49 + > 2 files changed, 57 insertions(+) > > diff --git a/libavformat/avformat.h b/libavformat/avformat.h > index

Re: [FFmpeg-devel] [PATCH 2/6] ffmpeg: use lavf API for applying bitstream filters

2015-11-19 Thread Michael Niedermayer
On Wed, Nov 18, 2015 at 05:28:18PM -0600, Rodger Combs wrote: > --- > ffmpeg.c | 46 -- > ffmpeg.h | 1 - > ffmpeg_opt.c | 6 +- > 3 files changed, 9 insertions(+), 44 deletions(-) no objections from me [...] -- Michael GnuPG finger

Re: [FFmpeg-devel] [PATCH 5/6] lavf: add API to append a bsf to a stream's list

2015-11-19 Thread Michael Niedermayer
On Wed, Nov 18, 2015 at 05:28:21PM -0600, Rodger Combs wrote: > --- > libavformat/avformat.h | 9 + > libavformat/utils.c| 20 > 2 files changed, 29 insertions(+) > > diff --git a/libavformat/avformat.h b/libavformat/avformat.h > index 6e9ffe2..cedcb8f 100644 > -

Re: [FFmpeg-devel] [PATCH 1/6] lavf: add API to apply a list of bsfs to a packet

2015-11-19 Thread Michael Niedermayer
On Wed, Nov 18, 2015 at 05:28:17PM -0600, Rodger Combs wrote: > --- > libavformat/avformat.h | 8 > libavformat/utils.c| 49 + > 2 files changed, 57 insertions(+) a comment about the whole patchset: seems working! thanks [..] -- Mic

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/aacsbr: Add comment about possibly optimization in sbr_dequant()

2015-11-19 Thread Michael Niedermayer
On Thu, Nov 19, 2015 at 09:03:03AM -0500, Ganesh Ajjanagadde wrote: > On Thu, Nov 19, 2015 at 8:17 AM, Michael Niedermayer wrote: > > From: Michael Niedermayer > > > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/aacsbr.c |1 + > > 1 file changed, 1 insertion(+) > > > > diff --

Re: [FFmpeg-devel] [PATCH 6/8] tests/tiny_ssim: replace #define by typedef

2015-11-19 Thread Hendrik Leppkes
On Thu, Nov 19, 2015 at 2:50 PM, Ganesh Ajjanagadde wrote: > On Thu, Nov 19, 2015 at 8:36 AM, Ronald S. Bultje wrote: >> Hi, >> >> On Thu, Nov 19, 2015 at 8:14 AM, Ganesh Ajjanagadde >> wrote: >>> >>> See e.g >>> https://stackoverflow.com/questions/1666353/are-typedef-and-define-the-same-in-c >>

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/aacsbr: Add comment about possibly optimization in sbr_dequant()

2015-11-19 Thread Ganesh Ajjanagadde
On Thu, Nov 19, 2015 at 9:18 AM, Michael Niedermayer wrote: > On Thu, Nov 19, 2015 at 09:03:03AM -0500, Ganesh Ajjanagadde wrote: >> On Thu, Nov 19, 2015 at 8:17 AM, Michael Niedermayer >> wrote: >> > From: Michael Niedermayer >> > >> > Signed-off-by: Michael Niedermayer >> > --- >> > libavco

Re: [FFmpeg-devel] [PATCH 6/8] tests/tiny_ssim: replace #define by typedef

2015-11-19 Thread Ganesh Ajjanagadde
On Thu, Nov 19, 2015 at 9:19 AM, Hendrik Leppkes wrote: > On Thu, Nov 19, 2015 at 2:50 PM, Ganesh Ajjanagadde > wrote: >> On Thu, Nov 19, 2015 at 8:36 AM, Ronald S. Bultje wrote: >>> Hi, >>> >>> On Thu, Nov 19, 2015 at 8:14 AM, Ganesh Ajjanagadde >>> wrote: See e.g https://stacko

Re: [FFmpeg-devel] [PATCH 1/8] avcodec/lpc: replace #define by typedef

2015-11-19 Thread Michael Niedermayer
On Thu, Nov 19, 2015 at 08:14:08AM -0500, Ganesh Ajjanagadde wrote: > See e.g > https://stackoverflow.com/questions/1666353/are-typedef-and-define-the-same-in-c > for rationale. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavcodec/lpc.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 delet

Re: [FFmpeg-devel] [PATCH 7/8] avcodec/faanidct: replace #define by typedef

2015-11-19 Thread Michael Niedermayer
On Thu, Nov 19, 2015 at 08:14:14AM -0500, Ganesh Ajjanagadde wrote: > See e.g > https://stackoverflow.com/questions/1666353/are-typedef-and-define-the-same-in-c > for rationale. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavcodec/faanidct.c | 2 +- > 1 file changed, 1 insertion(+), 1 delet

Re: [FFmpeg-devel] [PATCH 8/8] avcodec/resample2: replace #define by typedef

2015-11-19 Thread Michael Niedermayer
On Thu, Nov 19, 2015 at 08:14:15AM -0500, Ganesh Ajjanagadde wrote: > See e.g > https://stackoverflow.com/questions/1666353/are-typedef-and-define-the-same-in-c > for rationale. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavcodec/resample2.c | 12 ++-- > 1 file changed, 6 insertion

Re: [FFmpeg-devel] [PATCH] avcodec: add OpenJPEG 2.x compatibility

2015-11-19 Thread Michael Bradshaw
On Thu, Nov 19, 2015 at 1:21 AM, Moritz Barsnick wrote: > On Wed, Nov 18, 2015 at 21:22:57 -0800, Michael Bradshaw wrote: > > > if (!dec) { > > av_log(avctx, AV_LOG_ERROR, "Error initializing decoder.\n"); > > -return AVERROR_UNKNOWN; > > +ret = AVERROR_EXTERNAL; > >

Re: [FFmpeg-devel] [PATCH] swscale/arm: add ff_nv{12, 21}_to_{argb, rgba, abgr, bgra}_neon

2015-11-19 Thread Michael Niedermayer
On Thu, Nov 19, 2015 at 11:48:53AM +0100, Clément Bœsch wrote: > From: Matthieu Bouron > > Signed-off-by: Matthieu Bouron > Signed-off-by: Clément Bœsch > > --- > The function takes about 29ms with a 1080p source (testsrc2) on a > cortex-a8. Though, 16ms (more than half the time!) is spend in

Re: [FFmpeg-devel] [PATCH] all: use M_SQRT1_2, M_SQRT2, M_PI

2015-11-19 Thread James Darnley
On 2015-11-19 13:52, Ganesh Ajjanagadde wrote: > diff --git a/libavfilter/af_dynaudnorm.c b/libavfilter/af_dynaudnorm.c >> index 8f0c2d0..62a2653 100644 >> --- a/libavfilter/af_dynaudnorm.c >> +++ b/libavfilter/af_dynaudnorm.c >> @@ -227,8 +227,6 @@ static int cqueue_pop(cqueue *q) >> return 0

Re: [FFmpeg-devel] [PATCH 3/8] avcodec/ac3: replace #define by typedef

2015-11-19 Thread Michael Niedermayer
On Thu, Nov 19, 2015 at 08:14:10AM -0500, Ganesh Ajjanagadde wrote: > See e.g > https://stackoverflow.com/questions/1666353/are-typedef-and-define-the-same-in-c > for rationale. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavcodec/ac3.h | 8 > 1 file changed, 4 insertions(+), 4 del

Re: [FFmpeg-devel] [PATCH] all: use M_SQRT1_2, M_SQRT2, M_PI

2015-11-19 Thread Ganesh Ajjanagadde
On Thu, Nov 19, 2015 at 10:53 AM, James Darnley wrote: > On 2015-11-19 13:52, Ganesh Ajjanagadde wrote: >> diff --git a/libavfilter/af_dynaudnorm.c b/libavfilter/af_dynaudnorm.c >>> index 8f0c2d0..62a2653 100644 >>> --- a/libavfilter/af_dynaudnorm.c >>> +++ b/libavfilter/af_dynaudnorm.c >>> @@ -22

Re: [FFmpeg-devel] [PATCH] all: use M_SQRT1_2, M_SQRT2, M_PI

2015-11-19 Thread Ganesh Ajjanagadde
On Thu, Nov 19, 2015 at 11:03 AM, Ganesh Ajjanagadde wrote: > On Thu, Nov 19, 2015 at 10:53 AM, James Darnley > wrote: >> On 2015-11-19 13:52, Ganesh Ajjanagadde wrote: >>> diff --git a/libavfilter/af_dynaudnorm.c b/libavfilter/af_dynaudnorm.c index 8f0c2d0..62a2653 100644 --- a/libavf

Re: [FFmpeg-devel] UDP constant bitrate feature (cbr)

2015-11-19 Thread Zach Swena
> How have you confirmed MPEG-TS compliance? While not completely definitive, I looked at it with a transport stream analyser and tested it at our TV station. At the TV station stream the file from our server through a remultiplexer that assembles the multi program transport stream with our vario

Re: [FFmpeg-devel] UDP constant bitrate feature (cbr)

2015-11-19 Thread Kieran Kunhya
On 19 November 2015 at 16:15, Zach Swena wrote: >> How have you confirmed MPEG-TS compliance? > > While not completely definitive, I looked at it with a transport stream > analyser and tested it at our TV station. At the TV station stream the > file from our server through a remultiplexer that as

Re: [FFmpeg-devel] [PATCH] all: use M_SQRT1_2, M_SQRT2, M_PI

2015-11-19 Thread Ganesh Ajjanagadde
On Thu, Nov 19, 2015 at 11:12 AM, Ganesh Ajjanagadde wrote: > On Thu, Nov 19, 2015 at 11:03 AM, Ganesh Ajjanagadde wrote: >> On Thu, Nov 19, 2015 at 10:53 AM, James Darnley >> wrote: >>> On 2015-11-19 13:52, Ganesh Ajjanagadde wrote: diff --git a/libavfilter/af_dynaudnorm.c b/libavfilter/a

Re: [FFmpeg-devel] [PATCH] all: use M_SQRT1_2, M_SQRT2, M_PI

2015-11-19 Thread Derek Buitenhuis
On 11/19/2015 4:12 PM, Ganesh Ajjanagadde wrote: > Confirmed just now bit-exactness via the hex print: > 0x1.921fb54442d18p+1 > 0x1.921fb54442d18p+1. Paul uses FreeBSD, if I recall. This is probably with glibc. - Derek ___ ffmpeg-devel mailing list ffmp

[FFmpeg-devel] [PATCH] avfilter/WIP: add streamselect filter

2015-11-19 Thread Clément Bœsch
From: Clément Bœsch --- No documentation so the concept is simply to map N streams to M other streams, with the possibility to live configure the filter (process_command). For example, let's say you have 2 a/v inputs and you want to live switch between the two, you will do something like: ffm

Re: [FFmpeg-devel] UDP constant bitrate feature (cbr)

2015-11-19 Thread Zach Swena
> FFmpeg is trying to remux this file and breaking its compliance then. > It's the same problem VLC has had for years (and why multicat was > written). No, I don't think FFmpeg is not trying to remux the file. I use FFmpeg to transcode and mux the file as a single program transport stream and out

Re: [FFmpeg-devel] [PATCH] swscale/arm: add ff_nv{12, 21}_to_{argb, rgba, abgr, bgra}_neon

2015-11-19 Thread Clément Bœsch
On Thu, Nov 19, 2015 at 04:50:54PM +0100, Michael Niedermayer wrote: > On Thu, Nov 19, 2015 at 11:48:53AM +0100, Clément Bœsch wrote: > > From: Matthieu Bouron > > > > Signed-off-by: Matthieu Bouron > > Signed-off-by: Clément Bœsch > > > > --- > > The function takes about 29ms with a 1080p sou

Re: [FFmpeg-devel] [PATCH] all: use M_SQRT1_2, M_SQRT2, M_PI

2015-11-19 Thread Nicolas George
Le nonidi 29 brumaire, an CCXXIV, Derek Buitenhuis a écrit : > Paul uses FreeBSD, if I recall. This is probably with glibc. Still, M_PI is meant to have the full precision of the underlying type, and I very much doubt that kind of bug to be present in any common implementation. And let us be reali

Re: [FFmpeg-devel] [PATCH] avfilter/WIP: add streamselect filter

2015-11-19 Thread Nicolas George
Le nonidi 29 brumaire, an CCXXIV, Clement Boesch a écrit : > - I always receive frames from the first input link... I suppose I need > to write a "smart" request_frame callback, but things changed recently > so maybe there are new guidelines for this? Nicolas, can I call for > your help again

Re: [FFmpeg-devel] [PATCH] all: use M_SQRT1_2, M_SQRT2, M_PI

2015-11-19 Thread Ganesh Ajjanagadde
On Thu, Nov 19, 2015 at 12:35 PM, Nicolas George wrote: > Le nonidi 29 brumaire, an CCXXIV, Derek Buitenhuis a écrit : >> Paul uses FreeBSD, if I recall. This is probably with glibc. > > Still, M_PI is meant to have the full precision of the underlying type, and > I very much doubt that kind of bu

Re: [FFmpeg-devel] [PATCH] all: use M_SQRT1_2, M_SQRT2, M_PI

2015-11-19 Thread Nicolas George
Le nonidi 29 brumaire, an CCXXIV, Ganesh Ajjanagadde a écrit : > Exactly. Can't pull the source for bsd easily, but it likely is > identical to openlibm since openlibm imported from freebsd: > https://github.com/JuliaLang/openlibm/blob/master/include/openlibm_math.h > which has an identical definit

Re: [FFmpeg-devel] [PATCH] all: use M_SQRT1_2, M_SQRT2, M_PI

2015-11-19 Thread Paul B Mahol
On 11/19/15, Ganesh Ajjanagadde wrote: > On Thu, Nov 19, 2015 at 12:35 PM, Nicolas George wrote: >> Le nonidi 29 brumaire, an CCXXIV, Derek Buitenhuis a ecrit : >>> Paul uses FreeBSD, if I recall. This is probably with glibc. >> >> Still, M_PI is meant to have the full precision of the underlying

[FFmpeg-devel] [PATCH] Map description metadata to ©inf tag in .mov wrapper

2015-11-19 Thread Brian Wheeler
The description metadata isn't mapped to anything when the mov wrapper is used.This patch maps description to ©inf for both reading and writing. The change to mov.c makes the mapping round-trip. Signed-off-by: Brian Wheeler --- libavformat/mov.c| 2 +- libavformat/movenc.c | 1 + 2 fi

[FFmpeg-devel] Ffmpeg Consulting

2015-11-19 Thread d...@faceflow.com
Hi, I am currently working on a project in which we want to use Ffmpeg. I have a lot of data to handle with different options on the Ffmpeg command — mostly combining segments of several small A/V files in one big file A/V file at specific times. Anybody available for a more detailed talk? If

[FFmpeg-devel] [PATCH] ffmpeg: enable echoing with command and debug modes

2015-11-19 Thread Clément Bœsch
Allow seeing text when pressing 'c' or 'd'. --- ffmpeg.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/ffmpeg.c b/ffmpeg.c index c4e9280..8d558e3 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -3395,6 +3395,18 @@ static OutputStream *choose_output(void) return ost_min; }

Re: [FFmpeg-devel] [PATCH] ffmpeg: enable echoing with command and debug modes

2015-11-19 Thread Michael Niedermayer
On Thu, Nov 19, 2015 at 10:54:45PM +0100, Clément Bœsch wrote: > Allow seeing text when pressing 'c' or 'd'. > --- > ffmpeg.c | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/ffmpeg.c b/ffmpeg.c > index c4e9280..8d558e3 100644 > --- a/ffmpeg.c > +++ b/ffmpeg.c > @@ -3

Re: [FFmpeg-devel] [PATCH] ffmpeg: enable echoing with command and debug modes

2015-11-19 Thread Clément Bœsch
On Thu, Nov 19, 2015 at 11:16:46PM +0100, Michael Niedermayer wrote: > On Thu, Nov 19, 2015 at 10:54:45PM +0100, Clément Bœsch wrote: > > Allow seeing text when pressing 'c' or 'd'. > > --- > > ffmpeg.c | 18 ++ > > 1 file changed, 18 insertions(+) > > > > > diff --git a/ffmpeg.c

Re: [FFmpeg-devel] [PATCH 1/3] aacsbr_fixed: avoid division by zero in sbr_gain_calc

2015-11-19 Thread Andreas Cadhalpun
On 19.11.2015 01:31, Michael Niedermayer wrote: > On Thu, Nov 19, 2015 at 12:31:17AM +0100, Andreas Cadhalpun wrote: >> So far so good. However, the next time sbr_dequant is called this breaks: >> noise_facs[1][0].exp = 6 - 536870912 + 1 = -536870905; >> > >> This is obviously completely bogus. >

Re: [FFmpeg-devel] [PATCH] ffprobe: do not exit in case the demuxer returns AVERROR(EAGAIN)

2015-11-19 Thread Andreas Cadhalpun
On 19.11.2015 02:36, Michael Niedermayer wrote: > On Thu, Nov 19, 2015 at 01:25:53AM +0100, Andreas Cadhalpun wrote: >> On 18.11.2015 15:07, Michael Niedermayer wrote: >>> iam not aware of any inf loops with EAGAIN >> >> Well, I am. I even sent patches fixing that, but you had objections. [1] > >

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/aacsbr: Split pre dequantization noise factors table

2015-11-19 Thread Andreas Cadhalpun
On 19.11.2015 13:16, Michael Niedermayer wrote: > ffmpeg | branch: master | Michael Niedermayer | Thu > Nov 19 12:03:22 2015 +0100| [bfd0e02dd64e912a6b67c25d9f86b3b0b849ad10] | > committer: Michael Niedermayer > > avcodec/aacsbr: Split pre dequantization noise factors table > > This allows rem

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/aacsbr: Replace a noise_facs_q check by an av_assert0

2015-11-19 Thread Andreas Cadhalpun
On 19.11.2015 13:55, Michael Niedermayer wrote: > ffmpeg | branch: master | Michael Niedermayer | Thu > Nov 19 13:32:40 2015 +0100| [58fba4b02f65e8f9878cd5e41d24bb8e452f6631] | > committer: Michael Niedermayer > > avcodec/aacsbr: Replace a noise_facs_q check by an av_assert0 > > The replaced c

Re: [FFmpeg-devel] [libav-devel] [PATCH] hqx: correct type and size check of info_offset

2015-11-19 Thread Andreas Cadhalpun
On 16.11.2015 12:55, Vittorio Giovara wrote: > On Sun, Nov 15, 2015 at 10:50 AM, Andreas Cadhalpun > wrote: >> It is used as size argument of ff_canopus_parse_info_tag, which uses it >> as size argument to bytestream2_init, which only supports sizes up to >> INT_MAX. >> Changing it's type to unsig

[FFmpeg-devel] [PATCH]lavc/opusdec: Fix a memleak when reading invalid files

2015-11-19 Thread Carl Eugen Hoyos
Hi! Attached patch fixes a memleak with the sample from bug 909. Please comment, Carl Eugen diff --git a/libavcodec/opusdec.c b/libavcodec/opusdec.c index 31871e9..6102591 100644 --- a/libavcodec/opusdec.c +++ b/libavcodec/opusdec.c @@ -671,8 +671,10 @@ static av_cold int opus_decode_init(AVCodec

Re: [FFmpeg-devel] [PATCH]lavc/opusdec: Fix a memleak when reading invalid files

2015-11-19 Thread James Almer
On 11/19/2015 10:05 PM, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes a memleak with the sample from bug 909. > > Please comment, Carl Eugen > > > patchopus.diff > > > diff --git a/libavcodec/opusdec.c b/libavcodec/opusdec.c > index 31871e9..6102591 100644 > --- a/libavcodec/opusdec.

[FFmpeg-devel] [PATCH 1/3] avformat/ffmdec: Add cleaner API for ffserver to interface without depending on internal ABI

2015-11-19 Thread Michael Niedermayer
From: Michael Niedermayer Signed-off-by: Michael Niedermayer --- libavformat/ffm.h |2 ++ libavformat/ffmdec.c | 14 ++ libavformat/version.h |2 +- 3 files changed, 17 insertions(+), 1 deletion(-) diff --git a/libavformat/ffm.h b/libavformat/ffm.h index b392b8d..c44

[FFmpeg-devel] [PATCH 2/3] ffserver: Use AVOption API to access ffm demuxer instead of direct access depending on ABI

2015-11-19 Thread Michael Niedermayer
From: Michael Niedermayer Signed-off-by: Michael Niedermayer --- ffserver.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ffserver.c b/ffserver.c index fb8ab7d..7e4f620 100644 --- a/ffserver.c +++ b/ffserver.c @@ -300,9 +300,9 @@ bail_eio: static void ffm_set_wri

[FFmpeg-devel] [PATCH 3/3] avformat/ffmdec: Only return EAGAIN if a server is attached

2015-11-19 Thread Michael Niedermayer
From: Michael Niedermayer This should fix a infinite loop Signed-off-by: Michael Niedermayer --- libavformat/ffmdec.c |9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libavformat/ffmdec.c b/libavformat/ffmdec.c index c3850db..e7c1449 100644 --- a/libavformat/ffmd

Re: [FFmpeg-devel] [PATCH] avcodec: add OpenJPEG 2.x compatibility

2015-11-19 Thread Michael Niedermayer
On Wed, Nov 18, 2015 at 09:22:57PM -0800, Michael Bradshaw wrote: > On Wed, Nov 18, 2015 at 8:00 AM, Michael Niedermayer > wrote: > > > On Tue, Nov 17, 2015 at 07:27:55AM -0800, Michael Bradshaw wrote: > > > Hi, > > > > > > Attached patch adds support for OpenJPEG 2.0/2.1. Please review. > > > >

Re: [FFmpeg-devel] [PATCH] ffmpeg: enable echoing with command and debug modes

2015-11-19 Thread Michael Niedermayer
On Thu, Nov 19, 2015 at 11:23:38PM +0100, Clément Bœsch wrote: > On Thu, Nov 19, 2015 at 11:16:46PM +0100, Michael Niedermayer wrote: > > On Thu, Nov 19, 2015 at 10:54:45PM +0100, Clément Bœsch wrote: > > > Allow seeing text when pressing 'c' or 'd'. > > > --- > > > ffmpeg.c | 18 +

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/aacsbr: Split pre dequantization noise factors table

2015-11-19 Thread Michael Niedermayer
On Fri, Nov 20, 2015 at 12:34:05AM +0100, Andreas Cadhalpun wrote: > On 19.11.2015 13:16, Michael Niedermayer wrote: > > ffmpeg | branch: master | Michael Niedermayer | > > Thu Nov 19 12:03:22 2015 +0100| [bfd0e02dd64e912a6b67c25d9f86b3b0b849ad10] > > | committer: Michael Niedermayer > > > > av

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/aacsbr: Replace a noise_facs_q check by an av_assert0

2015-11-19 Thread Michael Niedermayer
On Fri, Nov 20, 2015 at 12:35:29AM +0100, Andreas Cadhalpun wrote: > On 19.11.2015 13:55, Michael Niedermayer wrote: > > ffmpeg | branch: master | Michael Niedermayer | > > Thu Nov 19 13:32:40 2015 +0100| [58fba4b02f65e8f9878cd5e41d24bb8e452f6631] > > | committer: Michael Niedermayer > > > > av