Re: [FFmpeg-devel] [PATCHv2] avcodec/aacsbr_tablegen: always initialize tables at runtime

On Sat, 2015-12-05 at 14:48 -0500, Ganesh Ajjanagadde wrote: >  libavcodec/Makefile |  8 ++-- >  libavcodec/aacsbr_fixed_tablegen.c  | 39 - > >  libavcodec/aacsbr_fixed_tablegen.h  |  4 >  libavcodec/aacsbr_tablegen.c| 39

Re: [FFmpeg-devel] [PATCH 04/11] diracdec: Make slice parameters common between lowdelay and future hq profile

On Wed, Dec 09, 2015 at 12:05:30AM +, Kieran Kunhya wrote: > --- > libavcodec/diracdec.c | 36 +++- > 1 file changed, 19 insertions(+), 17 deletions(-) LGTM thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is

[FFmpeg-devel] [PATCH 02/12] diracdec: Template DSP functions adding 10-bit versions

--- libavcodec/dirac_dwt.c | 530 ++--- libavcodec/dirac_dwt.h | 20 +- libavcodec/dirac_dwt_template.c | 615 +++ libavcodec/diracdec.c| 8 +- libavcodec/diracdsp.c| 25 +-

Re: [FFmpeg-devel] [PATCH 06/11] diracdec: Add 10-bits to pix_fmt table

On Wed, Dec 09, 2015 at 12:05:32AM +, Kieran Kunhya wrote: > --- > libavcodec/dirac.c | 15 ++- > 1 file changed, 6 insertions(+), 9 deletions(-) > > diff --git a/libavcodec/dirac.c b/libavcodec/dirac.c > index fd6e869..6b1a93b 100644 > --- a/libavcodec/dirac.c > +++

Re: [FFmpeg-devel] [PATCH 05/11] diracdec: Extract version parameters

On Wed, Dec 09, 2015 at 12:05:31AM +, Kieran Kunhya wrote: > --- > libavcodec/dirac.c | 1 + > libavcodec/dirac.h | 6 ++ > libavcodec/diracdec.c | 3 ++- > libavformat/oggparsedirac.c | 3 ++- > 4 files changed, 11 insertions(+), 2 deletions(-) LGTM thx [...]

[FFmpeg-devel] [PATCH] avfilter/vf_delogo: round to the closest value

When the interpolated value is divided by the sum of weights, no rounding is done, which means the value is truncated. This results in a slight bias towards dark green in the interpolated area. Rounding properly removes the bias. I measured this change to reduce the interpolation error by 1 to 2

Re: [FFmpeg-devel] [PATCH] avfilter/vf_delogo: round to the closest value

On Wed, Dec 09, 2015 at 12:07:47PM +0100, Jean Delvare wrote: > When the interpolated value is divided by the sum of weights, no > rounding is done, which means the value is truncated. This results in > a slight bias towards dark green in the interpolated area. Rounding > properly removes the

Re: [FFmpeg-devel] [PATCH 2/2] configure: libbsd support for arc4random()

On Tue, 8 Dec 2015 09:01:47 -0500 Ganesh Ajjanagadde wrote: > On Tue, Dec 8, 2015 at 8:16 AM, Clément Bœsch wrote: > > On Tue, Dec 08, 2015 at 07:34:51AM -0500, Ganesh Ajjanagadde wrote: > >> On Tue, Dec 8, 2015 at 7:27 AM, wm4 wrote: >

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000: use powf instead of pow

On Wed, Dec 9, 2015 at 4:21 AM, Michael Niedermayer wrote: > On Tue, Dec 08, 2015 at 10:44:31PM -0500, Ganesh Ajjanagadde wrote: >> It may be entirely possible to optimize further by exploiting the fact >> that it is always an integer exponent. However, care must be taken since

Re: [FFmpeg-devel] [PATCH 1/2] avutil/random_seed: use arc4random() when available

On Sun, Dec 6, 2015 at 10:56 PM, Ganesh Ajjanagadde wrote: > arc4random() was designed as a superior interface for system random > number generation, designed for OpenBSD. It is thus an improvement to > use it whenever available. > > As a side note, this may or may not get

Re: [FFmpeg-devel] [PATCHv2] avcodec/aacsbr_tablegen: always initialize tables at runtime

On Wed, Dec 9, 2015 at 5:30 AM, Rostislav Pehlivanov wrote: > On Sat, 2015-12-05 at 14:48 -0500, Ganesh Ajjanagadde wrote: >> libavcodec/Makefile | 8 ++-- >> libavcodec/aacsbr_fixed_tablegen.c | 39 - >> >>

Re: [FFmpeg-devel] [PATCH 1/8] avfilter/vf_overlay: fix memory leaks

On Fri, Dec 4, 2015 at 9:39 AM, Ganesh Ajjanagadde wrote: > Recent commits 6aaac24d72a7da631173209841a3944fcb4a3309 and > 3835554bf8ed78539a3492c239f979c0ab03a15f made progress towards cleaning > up usage of the formats API, and in particular fixed possible NULL pointer >

Re: [FFmpeg-devel] [PATCH 2/8] avfilter/vf_alphamerge: fix memory leaks

On Fri, Dec 4, 2015 at 9:39 AM, Ganesh Ajjanagadde wrote: > Recent commits 6aaac24d72a7da631173209841a3944fcb4a3309 and > 3835554bf8ed78539a3492c239f979c0ab03a15f made progress towards cleaning > up usage of the formats API, and in particular fixed possible NULL pointer >

Re: [FFmpeg-devel] [PATCH 3/8] avfilter/af_channelmap: fix memory leak

On Sat, Dec 5, 2015 at 3:55 PM, Ganesh Ajjanagadde wrote: > On Sat, Dec 5, 2015 at 3:50 PM, Paul B Mahol wrote: >> On 12/4/15, Ganesh Ajjanagadde wrote: >>> Recent commits 6aaac24d72a7da631173209841a3944fcb4a3309 and >>>

Re: [FFmpeg-devel] [PATCH 07/11] diracdec: Replace dirac parse codes with better ones

On Wed, Dec 09, 2015 at 12:05:33AM +, Kieran Kunhya wrote: > --- > libavcodec/dirac.h| 22 ++ > libavcodec/diracdec.c | 18 +++--- > 2 files changed, 25 insertions(+), 15 deletions(-) > > diff --git a/libavcodec/dirac.h b/libavcodec/dirac.h > index

[FFmpeg-devel] [PATCHv3 01/12] diracdec: Move strides to bytes, and pointer types to uint8_t.

Start templating functions for move to support 10-bit Parts of this patch were written by Rostislav Pehlivanov --- libavcodec/dirac.c | 10 +- libavcodec/dirac.h | 3 +- libavcodec/diracdec.c | 252 +++-

Re: [FFmpeg-devel] [PATCH 2/2] configure: libbsd support for arc4random()

On Wed, Dec 9, 2015 at 8:28 AM, wm4 wrote: > On Tue, 8 Dec 2015 09:01:47 -0500 > Ganesh Ajjanagadde wrote: > >> On Tue, Dec 8, 2015 at 8:16 AM, Clément Bœsch wrote: >> > On Tue, Dec 08, 2015 at 07:34:51AM -0500, Ganesh Ajjanagadde wrote: >>

Re: [FFmpeg-devel] [PATCH 2/2] configure: libbsd support for arc4random()

On Wed, Dec 09, 2015 at 09:39:47AM -0500, Ganesh Ajjanagadde wrote: > On Wed, Dec 9, 2015 at 8:28 AM, wm4 wrote: > > On Tue, 8 Dec 2015 09:01:47 -0500 > > Ganesh Ajjanagadde wrote: > > > >> On Tue, Dec 8, 2015 at 8:16 AM, Clément Bœsch

Re: [FFmpeg-devel] [PATCH 2/2] configure: libbsd support for arc4random()

On Tue, Dec 08, 2015 at 09:12:42AM -0500, Ganesh Ajjanagadde wrote: > On Tue, Dec 8, 2015 at 9:01 AM, Ganesh Ajjanagadde wrote: > > On Tue, Dec 8, 2015 at 8:16 AM, Clément Bœsch wrote: > >> On Tue, Dec 08, 2015 at 07:34:51AM -0500, Ganesh Ajjanagadde wrote: > >>>

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/nvenc: Include NVENC SDK header

Hi! On Monday 07 December 2015 07:37:21 pm Timo Rothenpieler wrote: > > On Monday 07 December 2015 03:14:08 pm Timo Rothenpieler wrote: > >> Nvidia finaly decided to put a propper MIT license on their nvenc > >> header, so it can be included, removing any external dependencies for > >> nvenc and

Re: [FFmpeg-devel] [PATCH]lavc/libvo-aac: Mark the encoder as experimental

On Sunday 06 December 2015 01:31:17 am Carl Eugen Hoyos wrote: > Hi! > > I prefer attached patch over removing the encoder immediately. No opinions? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCHv2 07/12] diracdec: Replace dirac parse codes with better ones

On Wed, Dec 09, 2015 at 01:45:23PM +, Kieran Kunhya wrote: > --- > libavcodec/dirac.h| 22 ++ > libavcodec/diracdec.c | 17 +++-- > 2 files changed, 25 insertions(+), 14 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH 0/3] Workaround for large JPEG over RTP

On Tuesday 08 December 2015 01:10:30 pm Andrey Utkin wrote: > RFCs for JPEG over RTP don't support dimensions larger than pixels, > but it is possible to work around if we stick with information from SDP. Sorry if I misunderstand: If the rfc does not allow framesizes over 2040x2040 why should

[FFmpeg-devel] [PATCH][RFC]lavf/rtpenc_jpeg: Do not allow invalid resolutions

Hi! This should imo not get applied if there are applications that allow larger resolutions. Please comment, Carl Eugen diff --git a/libavformat/rtpenc_jpeg.c b/libavformat/rtpenc_jpeg.c index 60629cf..c50f25f 100644 --- a/libavformat/rtpenc_jpeg.c +++ b/libavformat/rtpenc_jpeg.c @@ -41,6

Re: [FFmpeg-devel] [PATCH] [RFC] avcodec/h264_slice: Duplicate addition to avoid ubsan warning

On Wed, Dec 09, 2015 at 03:17:26PM +0100, Carl Eugen Hoyos wrote: > On Wednesday 09 December 2015 02:08:06 am Michael Niedermayer wrote: > > From: Michael Niedermayer > > > > Fixes mozilla bug 1230247 > > Does this make the code slower and works around a bug in ubsan? i

Re: [FFmpeg-devel] [PATCH 2/2] configure: libbsd support for arc4random()

On Wed, Dec 9, 2015 at 8:28 AM, wm4 wrote: > On Tue, 8 Dec 2015 09:01:47 -0500 > Ganesh Ajjanagadde wrote: > >> On Tue, Dec 8, 2015 at 8:16 AM, Clément Bœsch wrote: >> > On Tue, Dec 08, 2015 at 07:34:51AM -0500, Ganesh Ajjanagadde wrote: >>

Re: [FFmpeg-devel] [PATCH 2/2] configure: libbsd support for arc4random()

On Wed, Dec 9, 2015 at 9:44 AM, Michael Niedermayer wrote: > On Wed, Dec 09, 2015 at 09:39:47AM -0500, Ganesh Ajjanagadde wrote: >> On Wed, Dec 9, 2015 at 8:28 AM, wm4 wrote: >> > On Tue, 8 Dec 2015 09:01:47 -0500 >> > Ganesh Ajjanagadde

Re: [FFmpeg-devel] [PATCH 06/11] diracdec: Add 10-bits to pix_fmt table

> this is maybe missing a < 2 check > i see a > 4 check but didnt find a < 2 check from a quick look There is an existing check as far as I can tell. Kieran ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] [RFC] avcodec/h264_slice: Duplicate addition to avoid ubsan warning

On Wednesday 09 December 2015 02:08:06 am Michael Niedermayer wrote: > From: Michael Niedermayer > > Fixes mozilla bug 1230247 Does this make the code slower and works around a bug in ubsan? Carl Eugen ___ ffmpeg-devel mailing

[FFmpeg-devel] [PATCH] avutil/random_seed: Add the runtime in cycles of the main loop to the entropy pool

From: Michael Niedermayer This should theoretically improve the randomness slightly Signed-off-by: Michael Niedermayer --- libavutil/random_seed.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH 2/2] configure: libbsd support for arc4random()

On Wed, Dec 09, 2015 at 09:16:34AM -0500, Ganesh Ajjanagadde wrote: > On Wed, Dec 9, 2015 at 8:54 AM, Michael Niedermayer wrote: > > On Tue, Dec 08, 2015 at 09:12:42AM -0500, Ganesh Ajjanagadde wrote: > >> On Tue, Dec 8, 2015 at 9:01 AM, Ganesh Ajjanagadde >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/nvenc: Include NVENC SDK header

>> Should fall under the system library stuff the GPL defines. > > I may misunderstand (I am not a native speaker) but the word > "should" imo indicates that you cannot commit your patch. Guess why I sent it here first... > Sorry, Carl Eugen > ___ >

[FFmpeg-devel] [PATCHv2 07/12] diracdec: Replace dirac parse codes with better ones

--- libavcodec/dirac.h| 22 ++ libavcodec/diracdec.c | 17 +++-- 2 files changed, 25 insertions(+), 14 deletions(-) diff --git a/libavcodec/dirac.h b/libavcodec/dirac.h index 6852e82..b4982f8 100644 --- a/libavcodec/dirac.h +++ b/libavcodec/dirac.h @@ -34,6

Re: [FFmpeg-devel] [PATCH 2/2] configure: libbsd support for arc4random()

On Wed, Dec 9, 2015 at 8:54 AM, Michael Niedermayer wrote: > On Tue, Dec 08, 2015 at 09:12:42AM -0500, Ganesh Ajjanagadde wrote: >> On Tue, Dec 8, 2015 at 9:01 AM, Ganesh Ajjanagadde wrote: >> > On Tue, Dec 8, 2015 at 8:16 AM, Clément Bœsch

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/nvenc: Include NVENC SDK header

On Wed, Dec 9, 2015 at 3:14 PM, Carl Eugen Hoyos wrote: > Hi! > > On Monday 07 December 2015 07:37:21 pm Timo Rothenpieler wrote: >> > On Monday 07 December 2015 03:14:08 pm Timo Rothenpieler wrote: >> >> Nvidia finaly decided to put a propper MIT license on their nvenc >> >>

Re: [FFmpeg-devel] [PATCH] [RFC] avcodec/h264_slice: Duplicate addition to avoid ubsan warning

On Wed, Dec 9, 2015 at 9:32 AM, Michael Niedermayer wrote: > On Wed, Dec 09, 2015 at 03:17:26PM +0100, Carl Eugen Hoyos wrote: >> On Wednesday 09 December 2015 02:08:06 am Michael Niedermayer wrote: >> > From: Michael Niedermayer >> > >> > Fixes mozilla

Re: [FFmpeg-devel] [PATCH 2/2] configure: libbsd support for arc4random()

On Wed, 9 Dec 2015 09:39:47 -0500 Ganesh Ajjanagadde wrote: > On Wed, Dec 9, 2015 at 8:28 AM, wm4 wrote: > > On Tue, 8 Dec 2015 09:01:47 -0500 > > Ganesh Ajjanagadde wrote: > > > >> On Tue, Dec 8, 2015 at 8:16 AM, Clément Bœsch

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/nvenc: Include NVENC SDK header

>>> Should fall under the system library stuff the GPL defines. >> >> I may misunderstand (I am not a native speaker) but the word >> "should" imo indicates that you cannot commit your patch. >> > > The header is licensed rather liberally and doesn't actually link > against anything, I don't see

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/nvenc: Include NVENC SDK header

On Wed, Dec 9, 2015 at 5:33 PM, Timo Rothenpieler wrote: Should fall under the system library stuff the GPL defines. >>> >>> I may misunderstand (I am not a native speaker) but the word >>> "should" imo indicates that you cannot commit your patch. >>> >> >> The header

[FFmpeg-devel] Detecting invalid filter parameters

Hi FFmpeg developers, The delogo video filter currently doesn't check the logo area passed as parameters for validity. If the logo area is partly outside of the frame or inside but too close to the border, the code will silently trim the area to make it fit inside the frame, then go on, with

[FFmpeg-devel] [PATCH] lavf/mpjpegdec: Fixed dereference after null check

From 36596b444e584eb7ccceb24c838f0273116691f8 Mon Sep 17 00:00:00 2001 From: Alex Agranovsky Date: Wed, 9 Dec 2015 12:48:20 -0500 Subject: [PATCH] lavf/mpjpegdec: Fixed dereference after null check Fixes Coverity CID 1341576 --- libavformat/mpjpegdec.c | 6 -- 1 file

Re: [FFmpeg-devel] [PATCH]lavc/libvo-aac: Mark the encoder as experimental

On Wed, Dec 9, 2015 at 11:15 AM, Carl Eugen Hoyos wrote: > On Sunday 06 December 2015 01:31:17 am Carl Eugen Hoyos wrote: >> Hi! >> >> I prefer attached patch over removing the encoder immediately. > > No opinions? > > Carl Eugen LGTM, but I don't use the libvo-aac, so... :-p

Re: [FFmpeg-devel] [PATCH] aaccoder: prevent crash of anmr coder

On Sun, Dec 6, 2015 at 6:36 PM, Andreas Cadhalpun wrote: > The other is a regression since 01ecb71, so I hope you know how to fix that. > In search_for_pns in libavcodec/aaccoder.c: > for (w = 0; w < sce->ics.num_windows; w += sce->ics.group_len[w]) { > [...]

Re: [FFmpeg-devel] [PATCH]lavc/libvo-aac: Mark the encoder as experimental

On 12/5/2015 9:31 PM, Carl Eugen Hoyos wrote: > Hi! > > I prefer attached patch over removing the encoder immediately. > > Carl Eugen What is experimental? Our wrapper or the library? If the latter then maybe it would be better to use a static init function to mark the encoder as experimental

Re: [FFmpeg-devel] [PATCH] lavf/mpjpegdec: Fixed dereference after null check

On Wed, Dec 09, 2015 at 12:55:14PM -0500, Alexander Agranovsky wrote: > > From 36596b444e584eb7ccceb24c838f0273116691f8 Mon Sep 17 00:00:00 2001 > From: Alex Agranovsky > Date: Wed, 9 Dec 2015 12:48:20 -0500 > Subject: [PATCH] lavf/mpjpegdec: Fixed dereference after null

Re: [FFmpeg-devel] [PATCH 2/2] configure: libbsd support for arc4random()

On Wed, Dec 9, 2015 at 11:00 AM, wm4 wrote: > On Wed, 9 Dec 2015 09:39:47 -0500 > Ganesh Ajjanagadde wrote: > >> On Wed, Dec 9, 2015 at 8:28 AM, wm4 wrote: >> > On Tue, 8 Dec 2015 09:01:47 -0500 >> > Ganesh Ajjanagadde

Re: [FFmpeg-devel] [PATCH] aaccoder: prevent crash of anmr coder

On Wed, Dec 9, 2015 at 4:42 PM, Andreas Cadhalpun wrote: >>> [...] >>> for (w2 = 0; w2 < sce->ics.group_len[w]; w2++) { >>> [...] >>> } > > Now we are after the w2-loop and thus: > w2 = sce->ics.group_len[w] = 2 > Ah, I see, it's outside

[FFmpeg-devel] [PATCH 1/2] doc/errno: fix description typo for ENAMETOOLONG

Signed-off-by: Marton Balint --- doc/errno.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/errno.txt b/doc/errno.txt index 31cab26..933a4de 100644 --- a/doc/errno.txt +++ b/doc/errno.txt @@ -76,7 +76,7 @@ EMFILE POSIX ++ Too many

[FFmpeg-devel] [PATCH] avformat/mov: Enable parser for mp3s by old HandBrake

From: Michael Niedermayer Fixes Ticket5047 Signed-off-by: Michael Niedermayer --- libavformat/isom.h |1 + libavformat/mov.c | 11 +++ 2 files changed, 12 insertions(+) diff --git a/libavformat/isom.h b/libavformat/isom.h index

Re: [FFmpeg-devel] [PATCH 02/12] diracdec: Template DSP functions adding 10-bit versions

On Wed, Dec 09, 2015 at 08:24:36AM +, Kieran Kunhya wrote: > --- > libavcodec/dirac_dwt.c | 530 ++--- > libavcodec/dirac_dwt.h | 20 +- > libavcodec/dirac_dwt_template.c | 615 > +++ >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/nvenc: Include NVENC SDK header

On 09.12.2015 17:38, Hendrik Leppkes wrote: > On Wed, Dec 9, 2015 at 5:33 PM, Timo Rothenpieler > wrote: >> If I understand carl right, the question is not about the header, but >> about if dlopen'ing a non-free library, the CUDA and NVENC ones in this >> case, makes

Re: [FFmpeg-devel] [PATCH] aaccoder: prevent crash of anmr coder

On 09.12.2015 21:38, Claudio Freire wrote: > On Wed, Dec 9, 2015 at 5:29 PM, Claudio Freire wrote: >> On Wed, Dec 9, 2015 at 4:42 PM, Andreas Cadhalpun >> wrote: > [...] > for (w2 = 0; w2 < sce->ics.group_len[w]; w2++)

Re: [FFmpeg-devel] [PATCH] aaccoder: prevent crash of anmr coder

On Wed, Dec 9, 2015 at 5:29 PM, Claudio Freire wrote: > On Wed, Dec 9, 2015 at 4:42 PM, Andreas Cadhalpun > wrote: [...] for (w2 = 0; w2 < sce->ics.group_len[w]; w2++) { [...] } >> >> Now we are

[FFmpeg-devel] [PATCH 2/2] lavu/error: add missing error messages for errors supported on all platforms

We need these if we have no strerror_r. Descriptions are taken from doc/errno.txt except for ENOMEM. Signed-off-by: Marton Balint --- libavutil/error.c | 37 + 1 file changed, 37 insertions(+) diff --git a/libavutil/error.c

Re: [FFmpeg-devel] [PATCH 2/2] configure: libbsd support for arc4random()

On Wed, Dec 9, 2015 at 1:56 PM, Ganesh Ajjanagadde wrote: > On Wed, Dec 9, 2015 at 11:00 AM, wm4 wrote: >> On Wed, 9 Dec 2015 09:39:47 -0500 >> Ganesh Ajjanagadde wrote: >> >>> On Wed, Dec 9, 2015 at 8:28 AM, wm4

[FFmpeg-devel] [PATCH] avcodec/nellymoserdec: replace pow by exp2

exp2 suffices here. Signed-off-by: Ganesh Ajjanagadde --- libavcodec/nellymoserdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/nellymoserdec.c b/libavcodec/nellymoserdec.c index 5f18593..e6625cb 100644 --- a/libavcodec/nellymoserdec.c

Re: [FFmpeg-devel] [PATCH] avfilter/avf_showfreqs: avoid wasteful pow

On Wed, Dec 9, 2015 at 6:11 PM, Paul B Mahol wrote: > On 12/9/15, Ganesh Ajjanagadde wrote: >> pow is a ridiculous function for computing a simple Gaussian. >> >> Signed-off-by: Ganesh Ajjanagadde >> --- >>

Re: [FFmpeg-devel] [PATCH] avfilter/avf_showfreqs: avoid wasteful pow

On 12/9/15, Ganesh Ajjanagadde wrote: > pow is a ridiculous function for computing a simple Gaussian. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavfilter/avf_showfreqs.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff

Re: [FFmpeg-devel] [PATCH 1/8] avfilter/vf_overlay: fix memory leaks

On Wed, Dec 9, 2015 at 6:09 PM, Paul B Mahol wrote: > On 12/9/15, Ganesh Ajjanagadde wrote: >> On Fri, Dec 4, 2015 at 9:39 AM, Ganesh Ajjanagadde >> wrote: >>> Recent commits 6aaac24d72a7da631173209841a3944fcb4a3309 and >>>

Re: [FFmpeg-devel] [PATCH 1/8] avfilter/vf_overlay: fix memory leaks

On 12/9/15, Ganesh Ajjanagadde wrote: > On Fri, Dec 4, 2015 at 9:39 AM, Ganesh Ajjanagadde > wrote: >> Recent commits 6aaac24d72a7da631173209841a3944fcb4a3309 and >> 3835554bf8ed78539a3492c239f979c0ab03a15f made progress towards cleaning >> up

[FFmpeg-devel] [PATCH] avcodec/nellymoserenc: avoid wasteful pow

exp2 suffices here. Some trivial (~ 4x) speedup is done in addition here by reusing results. This is bit-identical to the old values. Signed-off-by: Ganesh Ajjanagadde --- libavcodec/nellymoserenc.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff

[FFmpeg-devel] [PATCH] avfilter/avf_showfreqs: avoid wasteful pow

pow is a ridiculous function for computing a simple Gaussian. Signed-off-by: Ganesh Ajjanagadde --- libavfilter/avf_showfreqs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavfilter/avf_showfreqs.c b/libavfilter/avf_showfreqs.c index

[FFmpeg-devel] [PATCH] avcodec/dcaenc: avoid wasteful cos calls

cos is an even function; use this. Signed-off-by: Ganesh Ajjanagadde --- libavcodec/dcaenc.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavcodec/dcaenc.c b/libavcodec/dcaenc.c index 5a6bdac..b12d27b 100644 --- a/libavcodec/dcaenc.c +++

[FFmpeg-devel] [PATCHv2] avcodec/dcaenc: avoid wasteful cos calls

cos has symmetry; use this. Signed-off-by: Ganesh Ajjanagadde --- libavcodec/dcaenc.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/libavcodec/dcaenc.c b/libavcodec/dcaenc.c index 5a6bdac..6fcfb1a 100644 --- a/libavcodec/dcaenc.c +++

[FFmpeg-devel] [RFC][WIP][PATCH] avfilter: add SOFAlizer audio filter

Signed-off-by: Paul B Mahol --- libavfilter/Makefile | 1 + libavfilter/af_sofalizer.c | 816 + libavfilter/allfilters.c | 1 + 3 files changed, 818 insertions(+) create mode 100644 libavfilter/af_sofalizer.c diff --git

Re: [FFmpeg-devel] Detecting invalid filter parameters

Hi Paul, Thanks for your quick reply. On Wed, 9 Dec 2015 19:45:16 +, Paul B Mahol wrote: > On 12/9/15, Jean Delvare wrote: > > I would like to add a check for the delogo filter parameters to ensure > > that there is enough frame room around the area to execute the > >

Re: [FFmpeg-devel] Detecting invalid filter parameters

Le decadi 20 frimaire, an CCXXIV, Jean Delvare a écrit : > This brings two additional questions: > > 1* Can a filter declare which midstream changes it does or does not > support? > > 2* Can a filter be called back on midstream changes, or does it have to > detect it by itself? Midstream

Re: [FFmpeg-devel] [PATCH] aaccoder: prevent crash of anmr coder

On 09.12.2015 19:08, Claudio Freire wrote: > On Sun, Dec 6, 2015 at 6:36 PM, Andreas Cadhalpun > wrote: >> The other is a regression since 01ecb71, so I hope you know how to fix that. Let me add example numbers to the code. That should make the problem obvious.

Re: [FFmpeg-devel] Detecting invalid filter parameters

On 12/9/15, Jean Delvare wrote: > Hi FFmpeg developers, > > The delogo video filter currently doesn't check the logo area passed as > parameters for validity. If the logo area is partly outside of the > frame or inside but too close to the border, the code will silently > trim

[FFmpeg-devel] [PATCH] avformat/mxfenc: Fix integer overflow in length computation

From: Michael Niedermayer Fixes: CID1341577 Signed-off-by: Michael Niedermayer --- libavformat/mxfenc.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c index e4e4272..043daff