Re: [FFmpeg-devel] [PATCH]configure: Enable pie for toolchain=hardened.

2016-10-11 Thread Carl Eugen Hoyos
2016-10-05 15:14 GMT+02:00 Carl Eugen Hoyos : > Patch sent that fixes this issue. I'll apply both patches if there are no objections. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]lavf/mxfenc: Do not print a useless error message

2016-10-11 Thread Carl Eugen Hoyos
2016-10-08 11:28 GMT+02:00 Carl Eugen Hoyos : > Attached patch removes a warning that is always shown if the > default mxf muxer is used. Patch applied. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo

Re: [FFmpeg-devel] [PATCH]lavc/pnmdec: Do not fail by default for truncated pbm files

2016-10-11 Thread Carl Eugen Hoyos
2016-09-05 11:12 GMT+02:00 Carl Eugen Hoyos : > 2016-09-05 10:26 GMT+02:00 Paul B Mahol : >> On 9/5/16, Carl Eugen Hoyos wrote: > >>> New patch attached. >> >> It seems this patch disables check for all cases when experimental is >> enabled, >> but check for overflow in only one case. > > I am no

Re: [FFmpeg-devel] [PATCH]lavf/riffenc: Always write unexpected channel_mask

2016-10-11 Thread Carl Eugen Hoyos
2016-09-26 12:39 GMT+02:00 Carl Eugen Hoyos : > Attached patch allows to write arbitrary (mono) channel_masks > even for 16bit 48kHz pcm audio. I'll push this if there are no objections. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] d3d11va: use the proper slice index

2016-10-11 Thread Hendrik Leppkes
On Mon, Oct 10, 2016 at 11:34 PM, compn wrote: > On Mon, 10 Oct 2016 17:07:06 +0200 > Hendrik Leppkes wrote: > >> On Mon, Oct 10, 2016 at 4:01 PM, Michael Niedermayer >> > >> > maybe our dxva2 maintainer wants a co maintainer? >> > if so would someone be interrested to help ? >> > >> >> Unfortuna

Re: [FFmpeg-devel] [PATCH] lavfi/pan: allow negative gain parameters also for other inputs than the first named

2016-10-11 Thread Moritz Barsnick
On Mon, Oct 10, 2016 at 19:09:34 +0200, Nicolas George wrote: > Maybe I am missing something, but I do not see where sign is reset to 1 > before the next run of the loop. You are correct. Too stupid me, I must pay more attention. And improve my testing. ;-) New patch coming. Thanks for checking,

Re: [FFmpeg-devel] [RFC/PATCH]lavc/vp8: Read a frame to set pix_fmt

2016-10-11 Thread Carl Eugen Hoyos
Hi! Sorry for the delay! 2016-08-28 14:25 GMT+02:00 Ronald S. Bultje : > On Sun, Aug 28, 2016 at 7:24 AM, Carl Eugen Hoyos wrote: >> Currently, FFmpeg reports "1920x1080" for >> fate-suite/vp8/frame_size_change.webm although the first >> frame is 160x90. >> This is different for "--enable-libv

Re: [FFmpeg-devel] [PATCH 2/3] lavc/mediacodecdec: rename dequeued_buffer_nb to output_buffer_count

2016-10-11 Thread Matthieu Bouron
On Thu, Oct 6, 2016 at 2:31 PM, Matthieu Bouron wrote: > From: Matthieu Bouron > > --- > libavcodec/mediacodecdec.c | 6 +++--- > libavcodec/mediacodecdec.h | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/mediacodecdec.c b/libavcodec/mediacodecdec.c > inde

[FFmpeg-devel] [PATCH] avformat/mxfdec: Detect field_order based on video_line_map

2016-10-11 Thread Tobias Rapp
Read video_line_map from MXF generic picture essence descriptor and use it to derive the coded field order. Use field_dominance to derive the display field order from coded field order. If field_dominance is not available the default value "1" is used as defined in SMPTE S377-1. Fixes field_order

Re: [FFmpeg-devel] [PATCH]lavc/pnmdec: Do not fail by default for truncated pbm files

2016-10-11 Thread Michael Niedermayer
On Tue, Oct 11, 2016 at 10:06:54AM +0200, Carl Eugen Hoyos wrote: > 2016-09-05 11:12 GMT+02:00 Carl Eugen Hoyos : > > 2016-09-05 10:26 GMT+02:00 Paul B Mahol : > >> On 9/5/16, Carl Eugen Hoyos wrote: > > > >>> New patch attached. > >> > >> It seems this patch disables check for all cases when expe

[FFmpeg-devel] [PATCH] lavfi/pan: allow negative gain parameters also for other inputs than the first named

2016-10-11 Thread Moritz Barsnick
Expands the parser to also accept the separator '-' in addition to '+', and take the negative sign into consideration. Signed-off-by: Moritz Barsnick --- doc/filters.texi | 2 +- libavfilter/af_pan.c | 11 --- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/doc/filter

[FFmpeg-devel] [PATCH] lavf/movenc: suggest video_track_timescale for invalid timescale

2016-10-11 Thread Josh de Kock
Fixes ticket #5882. While it doesn't automatically set the timescale for the user as that would destroy data without prompt, it will tell the user how they could set the timescale (as this is mostly likely what they want). Signed-off-by: Josh de Kock --- libavformat/movenc.c | 4 +++- 1 file cha

Re: [FFmpeg-devel] [PATCH] lavf/movenc: suggest video_track_timescale for invalid timescale

2016-10-11 Thread Moritz Barsnick
On Tue, Oct 11, 2016 at 12:30:30 +0100, Josh de Kock wrote: > "WARNING codec timebase is very high. If duration is > too long,\n" > "file may not be playable by quicktime. Specify a > shorter timebase\n" > - "or choose differen

Re: [FFmpeg-devel] [PATCH] lavf/movenc: suggest video_track_timescale for invalid timescale

2016-10-11 Thread Alexey Eromenko
Also the patch needs to cover both MP4 and MOV containers. On Tue, Oct 11, 2016 at 1:49 PM, Moritz Barsnick wrote: > On Tue, Oct 11, 2016 at 12:30:30 +0100, Josh de Kock wrote: >> "WARNING codec timebase is very high. If duration is >> too long,\n" >>

Re: [FFmpeg-devel] [PATCH] lavf/movenc: suggest video_track_timescale for invalid timescale

2016-10-11 Thread Alexey Eromenko
Josh, thanks for your efforts. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavf/movenc: suggest video_track_timescale for invalid timescale

2016-10-11 Thread Alexey Eromenko
I have written a different patch, which should auto-fix the problem, but I can't compile and test it now (due to build system issues): movenc.c affects both MP4 and MOV containers, right ? --- ./movenc.c.orig 2016-10-11 06:24:44.328730759 -0400 +++ ./ffmpeg-3.1.3/ffmpeg-3.1.3/libavformat

Re: [FFmpeg-devel] [PATCH] lavf/movenc: suggest video_track_timescale for invalid timescale

2016-10-11 Thread Michael Niedermayer
On Tue, Oct 11, 2016 at 02:40:57PM +0200, Alexey Eromenko wrote: > I have written a different patch, which should auto-fix the problem, > but I can't compile and test it now (due to build system issues): > movenc.c affects both MP4 and MOV containers, right ? > > > > --- ./movenc.c.orig

[FFmpeg-devel] [PATCH] libavf: Auto-detect mjpeg 2000 in mpeg-ts

2016-10-11 Thread Ståle kristoffersen
Hi, I have some transport streams with only one pid, containing MJPEG 2000 video. Since the PMT/PAT is missing ffmpeg is unable to decode it. The attached patch makes ffmpeg able to guess that it does contain a stream of jpeg 2000, but I am not sure if this is the correct approach. Also, should L

Re: [FFmpeg-devel] [PATCH] libavf: Auto-detect mjpeg 2000 in mpeg-ts

2016-10-11 Thread Moritz Barsnick
On Tue, Oct 11, 2016 at 15:52:33 +0200, Ståle kristoffersen wrote: > + * VC-1 demuxer > + * Copyright (c) 2016 Ståle Kristoffersen I don't think it's a VC-1 demuxer. ;-) Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mail

Re: [FFmpeg-devel] [PATCH] libavf: Auto-detect mjpeg 2000 in mpeg-ts

2016-10-11 Thread Michael Niedermayer
On Tue, Oct 11, 2016 at 03:52:33PM +0200, Ståle kristoffersen wrote: > Hi, > I have some transport streams with only one pid, containing MJPEG 2000 > video. Since the PMT/PAT is missing ffmpeg is unable to decode it. > > The attached patch makes ffmpeg able to guess that it does contain a > stream

Re: [FFmpeg-devel] [PATCH] avformat/udp: deprecate local_port option

2016-10-11 Thread Steven Liu
ping 2016-10-10 10:50 GMT+08:00 Steven Liu : > > Signed-off-by: Steven Liu > --- > doc/protocols.texi|3 +++ > libavformat/udp.c | 19 ++- > libavformat/version.h |3 +++ > 3 files changed, 24 insertions(+), 1 deletions(-) > > diff --git a/doc/protocols.texi b/

Re: [FFmpeg-devel] [PATCH] doc: fix various typos and grammar errors

2016-10-11 Thread Michael Niedermayer
On Sun, Oct 09, 2016 at 08:51:57PM +0200, Moritz Barsnick wrote: > Signed-off-by: Moritz Barsnick > --- > doc/codecs.texi | 2 +- > doc/demuxers.texi| 4 ++-- > doc/ffmpeg.texi | 2 +- > doc/fftools-common-opts.texi | 8 > doc/filters.texi

Re: [FFmpeg-devel] [PATCH] libavf: Auto-detect mjpeg 2000 in mpeg-ts

2016-10-11 Thread Ståle Kristoffersen
On 2016-10-11 at 16:23, Moritz Barsnick wrote: > On Tue, Oct 11, 2016 at 15:52:33 +0200, Ståle kristoffersen wrote: > > + * VC-1 demuxer > > + * Copyright (c) 2016 Ståle Kristoffersen > > I don't think it's a VC-1 demuxer. ;-) I guess I took the line "Do not copy and paste it from a random place,

Re: [FFmpeg-devel] [PATCH] lavf/movenc: suggest video_track_timescale for invalid timescale

2016-10-11 Thread Alexey Eromenko
GMail disallows me to paste unwrapped text, so I will use good-old pastebin plain text. http://pastebin.com/SPUF4NTS ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavf/movenc: suggest video_track_timescale for invalid timescale

2016-10-11 Thread Clément Bœsch
On Tue, Oct 11, 2016 at 05:16:30PM +0200, Alexey Eromenko wrote: > GMail disallows me to paste unwrapped text, so I will use good-old > pastebin plain text. > > http://pastebin.com/SPUF4NTS No, please fix or learn how to use your mailer. BTW, what if I actually want/need a large timebase because

Re: [FFmpeg-devel] [PATCH] lavf/movenc: suggest video_track_timescale for invalid timescale

2016-10-11 Thread Alexey Eromenko
In which cases a large timebase would help ? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavf/movenc: suggest video_track_timescale for invalid timescale

2016-10-11 Thread Alexey Eromenko
So, in which cases a large timebase would help ? Okay, I have allowed to manually over-ride the auto-detect setting via -video_track_timescale parameter, if someone really knows what he's doing. But the default settings (after my patch) work fine, with Windows Media Player, Quicktime, iTunes and V

Re: [FFmpeg-devel] [PATCH] lavf/movenc: suggest video_track_timescale for invalid timescale

2016-10-11 Thread Josh de Kock
On 11/10/2016 16:47, Alexey Eromenko wrote: So, in which cases a large timebase would help ? Okay, I have allowed to manually over-ride the auto-detect setting via -video_track_timescale parameter, if someone really knows what he's doing. But the default settings (after my patch) work fine, with

[FFmpeg-devel] [PATCH] libopenjpeg: do not define OPJ_STATIC for shared builds

2016-10-11 Thread Andreas Cadhalpun
Setting OPJ_STATIC when building shared libraries with openjpeg 2 causes the openjpeg symbols to have visibility hidden and the final linker step to fail due to undefined references. Signed-off-by: Andreas Cadhalpun --- libavcodec/libopenjpegdec.c | 3 +++ libavcodec/libopenjpegenc.c | 3 +++ 2

Re: [FFmpeg-devel] [OPW] OPW Project Proposal

2016-10-11 Thread Pallavi Kumari
>> added the entry with the sugested addition >> also you didnt list "Expected results" so i added some Thank you. Is the preferred language C for this kind of filter? C++ ? I don't see a qualification task on the wiki. Let me know so that that I can start with it and with writing the applicat

Re: [FFmpeg-devel] [PATCH] lavfi/metadata: fix metadata deletion if comparison returns false

2016-10-11 Thread Marton Balint
On Sat, 8 Oct 2016, Paul B Mahol wrote: On 10/6/16, Marton Balint wrote: Signed-off-by: Marton Balint --- libavfilter/f_metadata.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) lgtm Thanks, applied. Regards, Marton ___ ffmpeg-deve

Re: [FFmpeg-devel] [PATCH] libavf: Auto-detect mjpeg 2000 in mpeg-ts

2016-10-11 Thread Ståle Kristoffersen
On 2016-10-11 at 16:27, Michael Niedermayer wrote: > > +for (i=0; ibuf_size-5; i++) { > > +soc = AV_RB16(p->buf + i); > > +if (soc == JPEG2000_SOC ) { > > +marker = AV_RB16(p->buf + i + 2); > > +marker_size = AV_RB16(p->buf + i + 4); > > +if

Re: [FFmpeg-devel] [PATCH 1/2] aacenc: use the decoder's lcg PRNG

2016-10-11 Thread Claudio Freire
LGTM. However, On Sat, Oct 8, 2016 at 12:20 PM, Rostislav Pehlivanov wrote: > +/** > + * linear congruential pseudorandom number generator > + * > + * @param previous_valpointer to the current state of the generator > + * > + * @return Returns a 32-bit pseudorandom integer > + */ > +stati

[FFmpeg-devel] [PATCH] libopenjpegenc: recreate image data buffer after encoding frame

2016-10-11 Thread Andreas Cadhalpun
openjpeg 2 sets the data pointers of the image components to NULL, causing segfaults if the image is reused. Signed-off-by: Andreas Cadhalpun --- The relevant openjpeg2 code is: https://sources.debian.net/src/openjpeg2/2.1.2-1/src/lib/openjp2/j2k.c/?hl=10253#L10247 --- libavcodec/libopenjpegen

[FFmpeg-devel] webvtt in dash

2016-10-11 Thread Haris Zukanovic
Hi everyone, I would like to convert dvb_subtitle to TTML and wrap in m4s to be muxed in dash. Example streams: http://vm2.dashif.org/dash/vod/testpic_2s/img_subs.mpd http://vm2.dashif.org/livesim/testpic_2s/multi_subs.mpd Can we played by: http://dashif.org/reference/players/javascript/v2.3.

Re: [FFmpeg-devel] [PATCH] libopenjpeg: do not define OPJ_STATIC for shared builds

2016-10-11 Thread Hendrik Leppkes
On Tue, Oct 11, 2016 at 5:50 PM, Andreas Cadhalpun wrote: > Setting OPJ_STATIC when building shared libraries with openjpeg 2 causes > the openjpeg symbols to have visibility hidden and the final linker step > to fail due to undefined references. Aren't these type of macros typically related to t

Re: [FFmpeg-devel] [PATCH] lavf/movenc: suggest video_track_timescale for invalid timescale

2016-10-11 Thread Alexey Eromenko
>I don't think it's good to have the default behaviour destroy the original >timestamps. Okay, I don't modify this timebase on correctly encoded videos (99.5% of my collection, and probably 100% of YouTube collection). Only on the few videos with problematic timebase I modify it, and there is a w

[FFmpeg-devel] [PATCH] Apple Quicktime fix

2016-10-11 Thread Alexey Eromenko
--- libavformat/movenc.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 8b4aa5f..0e2fc55 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -5666,16 +5666,20 @@ static int mov_write_header(AVFormatCo

[FFmpeg-devel] [PATCH] Apple Quicktime fix / MP4 and MOV Timebase

2016-10-11 Thread Alexey Eromenko
*** BLURB HERE *** Alexey Eromenko (1): Apple Quicktime fix libavformat/movenc.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) -- 2.9.3 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo

Re: [FFmpeg-devel] [PATCH] libopenjpeg: do not define OPJ_STATIC for shared builds

2016-10-11 Thread Andreas Cadhalpun
On 11.10.2016 19:13, Hendrik Leppkes wrote: > On Tue, Oct 11, 2016 at 5:50 PM, Andreas Cadhalpun > wrote: >> Setting OPJ_STATIC when building shared libraries with openjpeg 2 causes >> the openjpeg symbols to have visibility hidden and the final linker step >> to fail due to undefined references.

Re: [FFmpeg-devel] [PATCH] Apple Quicktime fix

2016-10-11 Thread Josh de Kock
On 11/10/2016 18:24, Alexey Eromenko wrote: --- libavformat/movenc.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 8b4aa5f..0e2fc55 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -5666,16 +566

Re: [FFmpeg-devel] [PATCH] Apple Quicktime fix / MP4 and MOV Timebase

2016-10-11 Thread Josh de Kock
On 11/10/2016 18:24, Alexey Eromenko wrote: *** BLURB HERE *** Alexey Eromenko (1): Apple Quicktime fix libavformat/movenc.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) This commit message isn't very useful, it doesn't describe the change at all. See: https://ww

Re: [FFmpeg-devel] [PATCH] avformat/udp: deprecate local_port option

2016-10-11 Thread Josh de Kock
On 10/10/2016 03:50, Steven Liu wrote: Signed-off-by: Steven Liu --- doc/protocols.texi|3 +++ libavformat/udp.c | 19 ++- libavformat/version.h |3 +++ 3 files changed, 24 insertions(+), 1 deletions(-) diff --git a/doc/protocols.texi b/doc/protocols.texi i

[FFmpeg-devel] [PATCH] configure: fix detection of libopenjpeg

2016-10-11 Thread Andreas Cadhalpun
Use check_lib2 to test the header together with the function. This is necessary, because '-DOPJ_STATIC' changes what the included header does. Also add '-DOPJ_STATIC' to CFLAGS, so that it isn't necessary to hardcode this in libavcodec/libopenjpeg{dec,enc}.c. Finally, check for non-static libopen

Re: [FFmpeg-devel] [PATCH] Apple Quicktime fix

2016-10-11 Thread Alexey Eromenko
On Tue, Oct 11, 2016 at 8:29 PM, Josh de Kock wrote: > On 11/10/2016 18:24, Alexey Eromenko wrote: >> >> --- >> libavformat/movenc.c | 14 +- >> 1 file changed, 9 insertions(+), 5 deletions(-) >> >> diff --git a/libavformat/movenc.c b/libavformat/movenc.c >> index 8b4aa5f..0e2fc55 100

Re: [FFmpeg-devel] [PATCH] lavfi/sidedata: add filter for manipulating frame side data

2016-10-11 Thread Marton Balint
On Thu, 6 Oct 2016, Marton Balint wrote: This is a similar filter to f_metadata, only it works on side data. Since adding side data from a user provided arbitrary binary string is unsafe, because current code assumes that a side data of a certain kind has the proper size, this filter only imple

Re: [FFmpeg-devel] [PATCH] Apple Quicktime fix

2016-10-11 Thread Alexey Eromenko
>>> +unsigned int timescale_new = (unsigned >>> int)((double)(st->time_base.den) >>> +* 1000 / (double)(st->time_base.num)); >> >> You surely don't need all these casts. > > Unless I'm guaranteed to get int64 on ALL platforms, I don't see > how-to write this code wit

[FFmpeg-devel] [PATCH v2] lavf/movenc: suggest video_track_timescale for invalid timescale

2016-10-11 Thread Josh de Kock
Fixes ticket #5882. While it doesn't automatically set the timescale for the user as that would destroy data without prompt, it will tell the user how they could set the timescale (as this is mostly likely what they want). Signed-off-by: Josh de Kock --- >Would it be useful to print the max dura

Re: [FFmpeg-devel] [PATCH] Apple Quicktime fix

2016-10-11 Thread Carl Eugen Hoyos
Hi! > Am 11.10.2016 um 19:24 schrieb Alexey Eromenko : > -if (track->mode == MODE_MOV This change is not acceptable: The problem only affects mov, not isom. Mentioning the option name in the existing warning message is of course a good idea. Carl Eugen

Re: [FFmpeg-devel] [PATCH] Apple Quicktime fix

2016-10-11 Thread Alexey Eromenko
On Tuesday, 11 October 2016, Carl Eugen Hoyos wrote: > Hi! > > > Am 11.10.2016 um 19:24 schrieb Alexey Eromenko >: > > > > -if (track->mode == MODE_MOV > > This change is not acceptable: > The problem only affects mov, not isom. > Mentioning the option name in the existing warning me

Re: [FFmpeg-devel] [PATCH] doc/developer: Mention mime type and patchwork in "Submitting patches"

2016-10-11 Thread Michael Niedermayer
On Tue, Oct 11, 2016 at 09:16:14AM +0800, Steven Liu wrote: > 2016-10-11 9:05 GMT+08:00 Michael Niedermayer : > > > Suggested-by: ronald > > Signed-off-by: Michael Niedermayer > > --- > > doc/developer.texi | 6 +- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/doc/d

[FFmpeg-devel] [PATCH] avformat/matroskaenc: don't write a FlagInterlaced element if it would write the default value

2016-10-11 Thread James Almer
The spec says: "Mandatory elements with a default value may be left out of the file. In the absence of a mandatory element, the element's default value is used." Signed-off-by: James Almer --- libavformat/matroskaenc.c | 2 -- tests/fate/matroska.mak | 2 +- 2 files changed, 1 insertion(+), 3

Re: [FFmpeg-devel] [PATCH] Apple Quicktime fix / MP4 and MOV Timebase

2016-10-11 Thread Moritz Barsnick
On Tue, Oct 11, 2016 at 19:32:14 +0100, Josh de Kock wrote: > On 11/10/2016 18:24, Alexey Eromenko wrote: > > *** BLURB HERE *** > > This commit message isn't very useful, it doesn't describe the change at > all. See: > https://www.ffmpeg.org/developer.html#Patches_002fCommitting That's the cove

Re: [FFmpeg-devel] [OPW] OPW Project Proposal

2016-10-11 Thread Michael Niedermayer
On Tue, Oct 11, 2016 at 09:52:08PM +0530, Pallavi Kumari wrote: > >> added the entry with the sugested addition > > >> also you didnt list "Expected results" so i added some > > Thank you. > > Is the preferred language C for this kind of filter? C++ ? C (optional assembly optimizations are welc

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: don't write a FlagInterlaced element if it would write the default value

2016-10-11 Thread Hendrik Leppkes
On Tue, Oct 11, 2016 at 11:33 PM, James Almer wrote: > The spec says: > "Mandatory elements with a default value may be left out of the file. In the > absence > of a mandatory element, the element's default value is used." > > Signed-off-by: James Almer > --- > libavformat/matroskaenc.c | 2 --

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: don't write a FlagInterlaced element if it would write the default value

2016-10-11 Thread James Almer
On 10/11/2016 6:51 PM, Hendrik Leppkes wrote: > On Tue, Oct 11, 2016 at 11:33 PM, James Almer wrote: >> The spec says: >> "Mandatory elements with a default value may be left out of the file. In the >> absence >> of a mandatory element, the element's default value is used." >> >> Signed-off-by: J

Re: [FFmpeg-devel] [PATCH v2] lavf/movenc: suggest video_track_timescale for invalid timescale

2016-10-11 Thread Michael Niedermayer
On Tue, Oct 11, 2016 at 08:06:39PM +0100, Josh de Kock wrote: > Fixes ticket #5882. While it doesn't automatically set the timescale > for the user as that would destroy data without prompt, it will tell > the user how they could set the timescale (as this is mostly likely > what they want). > > S

Re: [FFmpeg-devel] [OPW] OPW Project Proposal

2016-10-11 Thread Michael Niedermayer
On Tue, Oct 11, 2016 at 11:54:04PM +0200, Michael Niedermayer wrote: > On Tue, Oct 11, 2016 at 09:52:08PM +0530, Pallavi Kumari wrote: > > >> added the entry with the sugested addition > > > > >> also you didnt list "Expected results" so i added some > > > > Thank you. > > > > Is the preferred l

Re: [FFmpeg-devel] [PATCH] configure: fix detection of libopenjpeg

2016-10-11 Thread Michael Bradshaw
Oh man, I literally just wrote a patch for this today. You beat me by 6 hours. Anyway, thanks for the patch! On Tue, Oct 11, 2016 at 11:37 AM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > Use check_lib2 to test the header together with the function. This is > necessary, because

Re: [FFmpeg-devel] [PATCH] libopenjpegenc: recreate image data buffer after encoding frame

2016-10-11 Thread Michael Bradshaw
On Tue, Oct 11, 2016 at 9:57 AM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > openjpeg 2 sets the data pointers of the image components to NULL, > causing segfaults if the image is reused. > I've never seen this issue. Is there a particular version of OpenJPEG or reproduction st

Re: [FFmpeg-devel] [PATCH] configure: fix detection of libopenjpeg

2016-10-11 Thread Michael Bradshaw
On Tue, Oct 11, 2016 at 6:35 PM, Michael Bradshaw wrote: > > On Tue, Oct 11, 2016 at 11:37 AM, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com> wrote: >> >> + check_lib2 openjpeg-2.1/openjpeg.h >> opj_version -lopenjp2 || >> + { ch

[FFmpeg-devel] [PATCH] add hds demuxer

2016-10-11 Thread Steven Liu
init add hds demuxer Based-on: patch by CORY MCCARTHY Based-on: patch by Gorilla Maguila Signed-off-by: Steven Liu --- configure |5 + libavformat/Makefile |1 + libavformat/allformats.c |2 +- libavformat/amfmetadata.c | 219 + libavformat/amfmet

[FFmpeg-devel] [PATCH] add init hds demuxer

2016-10-11 Thread Steven Liu
TODO: docs, version bump, TODO: option passing support (as seperate commit/patch) TODO: refine AMF parser TODO: refine Metadata Steven Liu (1): add hds demuxer configure |5 + libavformat/Makefile |1 + libavformat/allformats.c |2 +- libavformat/amfmetadata.c

[FFmpeg-devel] [PATCH] avformat/udp: deprecate local_port option

2016-10-11 Thread Steven Liu
Signed-off-by: Steven Liu --- doc/protocols.texi|3 +++ libavformat/udp.c | 19 ++- libavformat/version.h |3 +++ 3 files changed, 24 insertions(+), 1 deletions(-) diff --git a/doc/protocols.texi b/doc/protocols.texi index 3abc5f3..85a3f56 100644 --- a/doc/prot

[FFmpeg-devel] [PATCH 2/3] Selftest coverage for libavutil/fifo.c

2016-10-11 Thread Thomas Turner
code coverage for av_fifo_grow(...), av_fifo_generic_peek(...) Modified the folling files to get the selftest program to compile with: "make fate-fifo2" --- libavutil/Makefile | 1 + libavutil/tests/fifo2.c | 3 ++- tests/fate/libavutil.mak | 4 tests/ref/fate/fifo2 | 3 +++ 4 fil

[FFmpeg-devel] [PATCH 3/3] Selftest coverage for libavutil/fifo.c

2016-10-11 Thread Thomas Turner
Fixed trailing whitespace in fifo2.c selftest and fifo2 reference file that prevented the patch from being applied cleanly to git master --- libavutil/tests/fifo2.c | 17 + tests/ref/fate/fifo2| 6 +++--- 2 files changed, 12 insertions(+), 11 deletions(-) diff --git a/libavu

[FFmpeg-devel] [PATCH 1/3] Improve selftest coverage for libavutil library

2016-10-11 Thread Thomas Turner
Code coverage for av_fifo_generic_peek(...) and av_fifo_grow(...) . --- libavutil/tests/fifo2.c | 77 + 1 file changed, 77 insertions(+) create mode 100644 libavutil/tests/fifo2.c diff --git a/libavutil/tests/fifo2.c b/libavutil/tests/fifo2.c new f

[FFmpeg-devel] [PATCH] avformat/rtmpproto: Fix RTMP control message handling error in listen mode.

2016-10-11 Thread Hiroyuki OYAMA
Fix problem to fail by a RTMP Control Message except "Set Chunk Size (1)" after an RTMP handshake. When 'nginx-rtmp-module' relays an RTMP, it sends not only control message 'Set Chunk Size (1)' but also 'Window Acknowledgement Size (5)'. --- libavformat/rtmpproto.c | 47