Re: [FFmpeg-devel] On in-tree external headers

2017-11-05 Thread Mark Thompson
On 30/10/17 19:51, Mark Thompson wrote: > > Hi all, > > The recent submission of AMD AMF patches including a builtin header prompted > me to think further about what external API headers should actually be > included in the tree. > > For the AMD headers (like V4L2 previously), it seems

Re: [FFmpeg-devel] [PATCH] avutil/frame: Add avcodec_private_ref to AVFrame

2017-11-05 Thread James Almer
On 11/5/2017 9:34 AM, Michael Niedermayer wrote: > This gives libavcodec a field that it can freely and safely use. > Avoiding the need of wraping of a users opaque_ref field and its issues. Could this perhaps be in an opaque internal struct instead, much like AVCodecInternal and whatnot? As wm4

[FFmpeg-devel] [PATCH] avutil/frame: Add avcodec_private_ref to AVFrame

2017-11-05 Thread Michael Niedermayer
This gives libavcodec a field that it can freely and safely use. Avoiding the need of wraping of a users opaque_ref field and its issues. Signed-off-by: Michael Niedermayer --- libavutil/frame.c | 8 +++- libavutil/frame.h | 10 ++ 2 files changed, 17

Re: [FFmpeg-devel] [PATCH] avutil/frame: Add avcodec_private_ref to AVFrame

2017-11-05 Thread Hendrik Leppkes
On Sun, Nov 5, 2017 at 1:34 PM, Michael Niedermayer wrote: > This gives libavcodec a field that it can freely and safely use. > Avoiding the need of wraping of a users opaque_ref field and its issues. > > Signed-off-by: Michael Niedermayer > --- >

Re: [FFmpeg-devel] [PATCH] avutil/frame: Add avcodec_private_ref to AVFrame

2017-11-05 Thread Michael Niedermayer
On Sun, Nov 05, 2017 at 02:52:50PM +0100, Hendrik Leppkes wrote: > On Sun, Nov 5, 2017 at 1:34 PM, Michael Niedermayer > wrote: > > This gives libavcodec a field that it can freely and safely use. > > Avoiding the need of wraping of a users opaque_ref field and its issues.

Re: [FFmpeg-devel] On in-tree external headers

2017-11-05 Thread James Almer
On 11/5/2017 3:42 PM, Carl Eugen Hoyos wrote: > 2017-11-05 19:35 GMT+01:00 Mark Thompson : >> On 05/11/17 18:28, Carl Eugen Hoyos wrote: >>> 2017-11-05 15:24 GMT+01:00 Mark Thompson : On 30/10/17 19:51, Mark Thompson wrote: >>> "No external headers may be

Re: [FFmpeg-devel] On in-tree external headers

2017-11-05 Thread Timo Rothenpieler
Am 05.11.2017 um 19:59 schrieb Mark Thompson: On 05/11/17 18:42, Carl Eugen Hoyos wrote: 2017-11-05 19:35 GMT+01:00 Mark Thompson : On 05/11/17 18:28, Carl Eugen Hoyos wrote: 2017-11-05 15:24 GMT+01:00 Mark Thompson : On 30/10/17 19:51, Mark Thompson wrote:

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

2017-11-05 Thread Mironov, Mikhail
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Moritz Barsnick > Sent: November 5, 2017 2:11 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD >

Re: [FFmpeg-devel] [RFC/PATCH]lavc/v4l2_context: Change the type of the ioctl cmd to unsigned long

2017-11-05 Thread Carl Eugen Hoyos
2017-11-05 2:46 GMT+01:00 Mark Thompson : > On 05/11/17 00:46, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch fixes a warning on a current 64bit Linux system (that I >> do not see on my ancient system where the ioctl cmd has type int). >> Is there a better way to deal with it?

Re: [FFmpeg-devel] On in-tree external headers

2017-11-05 Thread Mark Thompson
On 05/11/17 18:28, Carl Eugen Hoyos wrote: > 2017-11-05 15:24 GMT+01:00 Mark Thompson : >> On 30/10/17 19:51, Mark Thompson wrote: > >> "No external headers may be included in the ffmpeg tree." > > So you suggest to remove the Nvidia header? If that specific policy is adopted

Re: [FFmpeg-devel] FFplay: progress bar feature proposal

2017-11-05 Thread Michael Niedermayer
On Thu, Apr 13, 2017 at 10:53:49AM -0500, Raymond Pierce wrote: > 13.04.2017, 09:40, "Steven Liu" : > > 2017-04-13 20:48 GMT+08:00 Raymond Pierce : > > > >>  Hi. Currently FFplay has no visible progress bar and it is hard to tell > >>  where a stream

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mpegts: opus muxing & demuxing expanded

2017-11-05 Thread Carl Eugen Hoyos
2017-09-01 1:10 GMT+02:00 pkv.stream : > Hello > > per Michael requests: > 1) I have split patch in 2 > 2) added malloc checks > 3) changed "for int" loop to C89 style (if I understood well the comment) > regards What happened to this patch? Carl Eugen

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

2017-11-05 Thread Moritz Barsnick
On Sun, Nov 05, 2017 at 02:41:54 +, Mironov, Mikhail wrote: > > > +{ "quality","", 0, AV_OPT_TYPE_CONST, { .i64 = > > AMF_VIDEO_ENCODER_HEVC_QUALITY_PRESET_QUALITY }, 0, 0, VE, > > "quality" }, > > > > These are 0, 5, 10. Do the intermediate values work? Should they be > >

Re: [FFmpeg-devel] Maintainers : add myself for exr

2017-11-05 Thread Michael Niedermayer
On Sat, Nov 04, 2017 at 03:23:07PM +0100, Martin Vignali wrote: > Hello, > > Following Michael Niedermayer request, patch in attach > to add myself for exr decoder > > > Martin > MAINTAINERS |1 + > 1 file changed, 1 insertion(+) > b0b5ec77736730c422425d34e683d5fd476c512b >

[FFmpeg-devel] [PATCH] lavu/timecode: clarify error msg for timecode_rate

2017-11-05 Thread Gyan Doshi
Prompted by an issue reported at StackExchange, patch changes error message for timecode_rate values below 1. The user-supplied value for timecode_rate in drawtext is rounded to nearest integer. So, a supplied value of 0.49 or lower is rounded to 0. This throws a misleading error message which

Re: [FFmpeg-devel] [PATCH] lavfi/drawtext: change minimum value for timecode_rate

2017-11-05 Thread Gyan Doshi
Withdrawn. New patch sent. On 11/2/2017 11:17 AM, Gyan Doshi wrote: Prompted by an issue reported at StackExchange, patch changes minimum value for timecode_rate to 1. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avutil/frame: Add avcodec_private_ref to AVFrame

2017-11-05 Thread Hendrik Leppkes
On Sun, Nov 5, 2017 at 7:08 PM, Rostislav Pehlivanov wrote: > On 5 November 2017 at 13:52, Hendrik Leppkes wrote: > >> On Sun, Nov 5, 2017 at 1:34 PM, Michael Niedermayer >> wrote: >> > This gives libavcodec a field that it can

Re: [FFmpeg-devel] On in-tree external headers

2017-11-05 Thread Nicolas George
Le quintidi 15 brumaire, an CCXXVI, Mark Thompson a écrit : > +AviSynth and Nvidia are exempt from this prohibition on external headers. So if somebody wants to add new headers, they just have to propose a patch to this sentence to add another exception? I will not vote for a proposal like that.

Re: [FFmpeg-devel] [PATCH] avutil/frame: Add avcodec_private_ref to AVFrame

2017-11-05 Thread Rostislav Pehlivanov
On 5 November 2017 at 13:52, Hendrik Leppkes wrote: > On Sun, Nov 5, 2017 at 1:34 PM, Michael Niedermayer > wrote: > > This gives libavcodec a field that it can freely and safely use. > > Avoiding the need of wraping of a users opaque_ref field and

Re: [FFmpeg-devel] On in-tree external headers

2017-11-05 Thread Carl Eugen Hoyos
2017-11-05 15:24 GMT+01:00 Mark Thompson : > On 30/10/17 19:51, Mark Thompson wrote: > "No external headers may be included in the ffmpeg tree." So you suggest to remove the Nvidia header? Carl Eugen ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] On in-tree external headers

2017-11-05 Thread Mark Thompson
On 05/11/17 18:42, Carl Eugen Hoyos wrote: > 2017-11-05 19:35 GMT+01:00 Mark Thompson : >> On 05/11/17 18:28, Carl Eugen Hoyos wrote: >>> 2017-11-05 15:24 GMT+01:00 Mark Thompson : On 30/10/17 19:51, Mark Thompson wrote: >>> "No external headers may be

[FFmpeg-devel] [PATCH 3/4] avcodec/aacdec_fixed: Fix undefined shift

2017-11-05 Thread Michael Niedermayer
Fixes: runtime error: left shift of negative value -801112064 Fixes: 3492/clusterfuzz-testcase-minimized-5784775283441664 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

[FFmpeg-devel] [PATCH 1/4] avcodec/snowdec: Fix integer overflow in header parsing

2017-11-05 Thread Michael Niedermayer
Fixes: 3984/clusterfuzz-testcase-minimized-5265759929368576 Fixes: runtime error: signed integer overflow: -1085585801 + -1094995529 cannot be represented in type 'int' Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael

[FFmpeg-devel] [PATCH 2/4] avcodec/mdct_*: Fix integer overflow in addition in RESCALE()

2017-11-05 Thread Michael Niedermayer
Fixes: runtime error: signed integer overflow: 1219998458 - -1469874012 cannot be represented in type 'int' Fixes: 3443/clusterfuzz-testcase-minimized-5369987105554432 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael

[FFmpeg-devel] [PATCH 4/4] avcodec/aacpsdsp_template: Fix integer overflows in ps_decorrelate_c()

2017-11-05 Thread Michael Niedermayer
Fixes: runtime error: signed integer overflow: 1939661764 - -454942263 cannot be represented in type 'int' Fixes: 3191/clusterfuzz-testcase-minimized-5688798451073024 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael

[FFmpeg-devel] [PATCH] Fixing small memory leak when wrapping texture in AVD3D11FrameDescriptor

2017-11-05 Thread Greg Wessels
--- libavutil/hwcontext_d3d11va.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/hwcontext_d3d11va.c b/libavutil/hwcontext_d3d11va.c index 52683b9..65dd665 100644 --- a/libavutil/hwcontext_d3d11va.c +++ b/libavutil/hwcontext_d3d11va.c @@ -123,6 +123,7 @@ static void

[FFmpeg-devel] Must I subscribe to ffmpeg-devel in order to submit a patch?

2017-11-05 Thread Jim DeLaHunt
Hello, ffmpeg developers: I'm gearing up to submit a patch, adding an FAQ to the documentation. According to , "Patches should be posted to the ffmpeg-devel mailing list."  But

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/h264idct_template: Fix integer overflows in ff_h264_idct8_add()

2017-11-05 Thread Michael Niedermayer
On Sat, Nov 04, 2017 at 01:19:20AM +0100, Michael Niedermayer wrote: > Fixes: runtime error: signed integer overflow: -503316480 + -2013265038 > cannot be represented in type 'int' > Fixes: 3805/clusterfuzz-testcase-minimized-6578427831255040 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 1/3] avutil/softfloat: Add FLOAT_MIN

2017-11-05 Thread Michael Niedermayer
On Wed, Nov 01, 2017 at 02:00:18PM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavutil/softfloat.h | 1 + > 1 file changed, 1 insertion(+) will apply patchset [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] On in-tree external headers

2017-11-05 Thread Michael Niedermayer
On Sun, Nov 05, 2017 at 06:59:42PM +, Mark Thompson wrote: > On 05/11/17 18:42, Carl Eugen Hoyos wrote: > > 2017-11-05 19:35 GMT+01:00 Mark Thompson : > >> On 05/11/17 18:28, Carl Eugen Hoyos wrote: > >>> 2017-11-05 15:24 GMT+01:00 Mark Thompson : > On

Re: [FFmpeg-devel] [PATCH] avutil/frame: Add avcodec_private_ref to AVFrame

2017-11-05 Thread Michael Niedermayer
On Sun, Nov 05, 2017 at 10:35:06AM -0300, James Almer wrote: > On 11/5/2017 9:34 AM, Michael Niedermayer wrote: > > This gives libavcodec a field that it can freely and safely use. > > Avoiding the need of wraping of a users opaque_ref field and its issues. > > Could this perhaps be in an opaque

Re: [FFmpeg-devel] [PATCH] web/template_head2: Prevent battleforthenet widget to show again after being clicked away

2017-11-05 Thread Michael Niedermayer
On Sat, Nov 04, 2017 at 05:48:57PM +0100, Michael Niedermayer wrote: > Also ensure that the widget does not use google analytics. > Iam not sure it actually did before, my box has too many layers that stop > this. > > Signed-off-by: Michael Niedermayer > --- >

Re: [FFmpeg-devel] [PATCH 0/6] avcodec: Vorbis encoder improvements

2017-11-05 Thread Carl Eugen Hoyos
2017-08-22 3:23 GMT+02:00 Tyler Jones : > Please see the following patches. > > The first two patches are identical to my latest pending changes sent to the > mailing list on July 28. Changelogs are included regardless. The clipping > avoidance patch should remove most

Re: [FFmpeg-devel] On in-tree external headers

2017-11-05 Thread Mark Thompson
On 05/11/17 20:04, Timo Rothenpieler wrote: > Am 05.11.2017 um 19:59 schrieb Mark Thompson: >> On 05/11/17 18:42, Carl Eugen Hoyos wrote: >>> 2017-11-05 19:35 GMT+01:00 Mark Thompson : On 05/11/17 18:28, Carl Eugen Hoyos wrote: > 2017-11-05 15:24 GMT+01:00 Mark Thompson

Re: [FFmpeg-devel] On in-tree external headers

2017-11-05 Thread Timo Rothenpieler
How about: "No external headers may be added to the ffmpeg tree, unless they are for AviSynth or Nvidia." I don't think a strict "no external headers" rule makes sense or is a good idea at all. Specially if there are seemingly arbitrary exceptions. If such a rule is to be added at all, it

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mpegts: opus muxing & demuxing expanded

2017-11-05 Thread pkv.stream
Le 05/11/2017 à 9:35 PM, Carl Eugen Hoyos a écrit : 2017-09-01 1:10 GMT+02:00 pkv.stream : Hello per Michael requests: 1) I have split patch in 2 2) added malloc checks 3) changed "for int" loop to C89 style (if I understood well the comment) regards What happened to

Re: [FFmpeg-devel] [PATCH 2/2] Document the fact that -to option is now also for input

2017-11-05 Thread Moritz Barsnick
On Sat, Nov 04, 2017 at 10:02:05 +0300, vi0...@gmail.com wrote: > From: Vitaly _Vi Shukela > > Signed-off-by: Vitaly _Vi Shukela > --- > doc/ffmpeg.texi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) You can add the documentation in the same commit

Re: [FFmpeg-devel] [PATCH]lavf/amr: Add amrnb and amrwb demuxers

2017-11-05 Thread Carl Eugen Hoyos
2017-10-09 0:24 GMT+02:00 Carl Eugen Hoyos : > 2017-10-07 16:51 GMT+02:00 Carl Eugen Hoyos : >> 2017-10-01 18:23 GMT+02:00 Carl Eugen Hoyos : >>> 2017-09-27 18:08 GMT+02:00 Carl Eugen Hoyos : >>> The existing amr

Re: [FFmpeg-devel] Must I subscribe to ffmpeg-devel in order to submit a patch?

2017-11-05 Thread Nicolas George
Le quartidi 14 brumaire, an CCXXVI, Jim DeLaHunt a écrit : > I'm gearing up to submit a patch, adding an FAQ to the documentation. > According to , "Patches > should be posted to the ffmpeg-devel >

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mpegts: opus muxing & demuxing expanded

2017-11-05 Thread Carl Eugen Hoyos
2017-11-05 22:07 GMT+01:00 pkv.stream : > Le 05/11/2017 à 9:35 PM, Carl Eugen Hoyos a écrit : >> >> 2017-09-01 1:10 GMT+02:00 pkv.stream : >>> >>> Hello >>> >>> per Michael requests: >>> 1) I have split patch in 2 >>> 2) added malloc checks >>> 3)

Re: [FFmpeg-devel] Must I subscribe to ffmpeg-devel in order to submit a patch?

2017-11-05 Thread Thilo Borgmann
Am 05.11.17 um 21:37 schrieb Nicolas George: > Le quartidi 14 brumaire, an CCXXVI, Jim DeLaHunt a écrit : >> I'm gearing up to submit a patch, adding an FAQ to the documentation. >> According to , "Patches >> should be posted to the ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] HW accelerator: Indicate when HW acceleration is in use

2017-11-05 Thread Lim, Michele
Mark, Thanks for your response. I agree with you and actually had an implementation similar to what you've described for the decoder but abandoned it; I haven't found an elegant way without making too many changes to indicate it much later when hardware is actually set up for execution.

[FFmpeg-devel] [PATCH 1/2] aptx: implement the aptX bluetooth codec

2017-11-05 Thread Aurelien Jacobs
The encoder was reverse engineered from binary library and from EP0398973B1 patent (long expired). The decoder was simply deduced from the encoder. --- doc/general.texi| 2 + libavcodec/Makefile | 2 + libavcodec/allcodecs.c | 1 + libavcodec/aptx.c | 854

[FFmpeg-devel] adding bluetooth aptX codec

2017-11-05 Thread Aurelien Jacobs
Hi again, Here is the other codec I added for my bluetooth needs: aptX. This one is based on my reverse engineering and my understanding of patent EP0398973B1 (long expired). [PATCH 1/2] aptx: implement the aptX bluetooth codec [PATCH 2/2] aptx: add raw muxer and demuxer for aptX -- Aurel

[FFmpeg-devel] [PATCH 2/2] aptx: add raw muxer and demuxer for aptX

2017-11-05 Thread Aurelien Jacobs
--- doc/general.texi | 1 + libavformat/Makefile | 2 ++ libavformat/allformats.c | 1 + libavformat/aptxdec.c| 70 libavformat/rawenc.c | 13 + libavformat/utils.c | 1 + 6 files changed, 88 insertions(+)

Re: [FFmpeg-devel] FFplay: progress bar feature proposal

2017-11-05 Thread Steven Liu
2017-11-06 4:36 GMT+08:00 Michael Niedermayer : > On Thu, Apr 13, 2017 at 10:53:49AM -0500, Raymond Pierce wrote: >> 13.04.2017, 09:40, "Steven Liu" : >> > 2017-04-13 20:48 GMT+08:00 Raymond Pierce : >> > >> >> Hi. Currently

Re: [FFmpeg-devel] [PATCH 1/3] sbc: implement SBC codec (low-complexity subband codec)

2017-11-05 Thread Rostislav Pehlivanov
On 5 November 2017 at 23:35, Aurelien Jacobs wrote: > This was originally based on libsbc, and was fully integrated into ffmpeg. > --- > doc/general.texi | 2 + > libavcodec/Makefile | 4 + > libavcodec/allcodecs.c | 2 + >

Re: [FFmpeg-devel] [PATCH 1/1] avdevice/decklink_dec: Autodetect the video input format

2017-11-05 Thread Aaron Levinson
See comments below. Aaron Levinson On 11/5/2017 4:49 PM, Marton Balint wrote: On Fri, 27 Oct 2017, Jeyapal, Karthick wrote: Please find the patch attached. Thanks, below some comments: From b18679b91a79f5e23a5ad23ae70f3862a34ddfb8 Mon Sep 17 00:00:00 2001 From: Karthick J

[FFmpeg-devel] [PATCH] avcodec/mips: Improve avc avg mc 10, 30, 01 and 03 msa functions

2017-11-05 Thread kaustubh.raste
From: Kaustubh Raste Align the mask buffer to 64 bytes. Load the specific destination bytes instead of MSA load and pack. Remove unused macros and functions. Signed-off-by: Kaustubh Raste --- libavcodec/mips/h264qpel_msa.c | 1269

[FFmpeg-devel] [PATCH] avcodec/mips: Improve hevc bi 4 tap hv mc msa functions

2017-11-05 Thread kaustubh.raste
From: Kaustubh Raste Use global mask buffer for appropriate mask load. Use immediate unsigned saturation for clip to max saving one vector register. Signed-off-by: Kaustubh Raste --- libavcodec/mips/hevc_mc_bi_msa.c | 1140

Re: [FFmpeg-devel] On in-tree external headers

2017-11-05 Thread Jan Ekstrom
On Sun, Nov 5, 2017 at 10:40 PM, Timo Rothenpieler wrote: > For once, there should be a good reason to do so. > Agreed. > In case of nvidia the headers in this form is otherwise unobtainable, and > it's also partially modified specifically for use in ffmpeg. > Getting the

Re: [FFmpeg-devel] [PATCH 2/2] aptx: add raw muxer and demuxer for aptX

2017-11-05 Thread Carl Eugen Hoyos
2017-11-06 0:39 GMT+01:00 Aurelien Jacobs : > +static int aptx_probe(AVProbeData *p) > +{ > +int len, score = 0; > +if (!p || !p->filename) > +return 0; > +len = strlen(p->filename); > +if (len > 5 && !strcmp(>filename[len-4], ".aptx")) > +score =

Re: [FFmpeg-devel] adding bluetooth aptX codec

2017-11-05 Thread Carl Eugen Hoyos
2017-11-06 0:39 GMT+01:00 Aurelien Jacobs : > Here is the other codec I added for my bluetooth needs: aptX. Just curious: Could you comment on the quality? Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avutil/frame: Add avcodec_private_ref to AVFrame

2017-11-05 Thread James Almer
On 11/5/2017 12:25 PM, Michael Niedermayer wrote: > On Sun, Nov 05, 2017 at 02:52:50PM +0100, Hendrik Leppkes wrote: >> On Sun, Nov 5, 2017 at 1:34 PM, Michael Niedermayer >> wrote: >>> This gives libavcodec a field that it can freely and safely use. >>> Avoiding the need

Re: [FFmpeg-devel] [PATCH 3/3] sbc: add raw muxer and demuxer for SBC

2017-11-05 Thread Carl Eugen Hoyos
2017-11-06 0:35 GMT+01:00 Aurelien Jacobs : > +static int sbc_probe(AVProbeData *p) > +{ > +int score = 0; > +int l = strlen(p->filename); > +if (l > 4 && !strcmp(>filename[l-4], ".sbc")) > +score = AVPROBE_SCORE_EXTENSION; This may make sense but we don't

Re: [FFmpeg-devel] [PATCH 1/2] aptx: implement the aptX bluetooth codec

2017-11-05 Thread Rostislav Pehlivanov
On 5 November 2017 at 23:39, Aurelien Jacobs wrote: > The encoder was reverse engineered from binary library and from > EP0398973B1 patent (long expired). > The decoder was simply deduced from the encoder. > --- > doc/general.texi| 2 + > libavcodec/Makefile |

Re: [FFmpeg-devel] [PATCH 3/3] sbc: add raw muxer and demuxer for SBC

2017-11-05 Thread Aurelien Jacobs
On Mon, Nov 06, 2017 at 12:48:32AM +0100, Carl Eugen Hoyos wrote: > 2017-11-06 0:35 GMT+01:00 Aurelien Jacobs : > > > +static int sbc_probe(AVProbeData *p) > > +{ > > +int score = 0; > > > +int l = strlen(p->filename); > > +if (l > 4 && !strcmp(>filename[l-4],

Re: [FFmpeg-devel] [PATCH 1/2] aptx: implement the aptX bluetooth codec

2017-11-05 Thread Rostislav Pehlivanov
On 6 November 2017 at 00:30, Rostislav Pehlivanov wrote: > > > On 5 November 2017 at 23:39, Aurelien Jacobs wrote: > >> +*ptr++ = samples[RIGHT][i] >> 8; >> > > How horrible, don't interleave the samples, leave them as planar. > Change the

Re: [FFmpeg-devel] [PATCH 2/3] sbc: add parser for SBC

2017-11-05 Thread Rostislav Pehlivanov
On 5 November 2017 at 23:35, Aurelien Jacobs wrote: > --- > libavcodec/Makefile | 2 + > libavcodec/allcodecs.c | 2 + > libavcodec/sbc_parser.c | 135 ++ > ++ > 3 files changed, 139 insertions(+) > create mode 100644

Re: [FFmpeg-devel] adding bluetooth aptX codec

2017-11-05 Thread Aurelien Jacobs
On Mon, Nov 06, 2017 at 12:51:55AM +0100, Carl Eugen Hoyos wrote: > 2017-11-06 0:39 GMT+01:00 Aurelien Jacobs : > > > Here is the other codec I added for my bluetooth needs: aptX. > > Just curious: > Could you comment on the quality? Well, my ears aren't really good enough to

[FFmpeg-devel] [PATCH] avcodec/mips: Improve hevc bi wgt 4 tap hv mc msa functions

2017-11-05 Thread kaustubh.raste
From: Kaustubh Raste Use global mask buffer for appropriate mask load. Use immediate unsigned saturation for clip to max saving one vector register. Signed-off-by: Kaustubh Raste --- libavcodec/mips/hevc_mc_biw_msa.c | 1396

Re: [FFmpeg-devel] [PATCH 1/1] avdevice/decklink_dec: Autodetect the video input format

2017-11-05 Thread Marton Balint
On Fri, 27 Oct 2017, Jeyapal, Karthick wrote: Please find the patch attached. Thanks, below some comments: From b18679b91a79f5e23a5ad23ae70f3862a34ddfb8 Mon Sep 17 00:00:00 2001 From: Karthick J Date: Fri, 27 Oct 2017 12:00:23 +0530 Subject: [PATCH 1/1]

[FFmpeg-devel] [PATCH 2/3] sbc: add parser for SBC

2017-11-05 Thread Aurelien Jacobs
--- libavcodec/Makefile | 2 + libavcodec/allcodecs.c | 2 + libavcodec/sbc_parser.c | 135 3 files changed, 139 insertions(+) create mode 100644 libavcodec/sbc_parser.c diff --git a/libavcodec/Makefile b/libavcodec/Makefile index

[FFmpeg-devel] [PATCH 3/3] sbc: add raw muxer and demuxer for SBC

2017-11-05 Thread Aurelien Jacobs
--- doc/general.texi | 1 + libavformat/Makefile | 4 +++ libavformat/allformats.c | 2 ++ libavformat/rawenc.c | 28 ++ libavformat/sbcdec.c | 76 libavformat/utils.c | 1 + 6 files changed, 112

Re: [FFmpeg-devel] [PATCH 3/3] sbc: add raw muxer and demuxer for SBC

2017-11-05 Thread Carl Eugen Hoyos
2017-11-06 1:31 GMT+01:00 Aurelien Jacobs : > Well, the best might be to just remove this probing > function. +1 Merci, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/3] sbc: add parser for SBC

2017-11-05 Thread Aurelien Jacobs
On Sun, Nov 05, 2017 at 11:43:37PM +, Rostislav Pehlivanov wrote: > On 5 November 2017 at 23:35, Aurelien Jacobs wrote: > > > --- > > libavcodec/Makefile | 2 + > > libavcodec/allcodecs.c | 2 + > > libavcodec/sbc_parser.c | 135 ++ > >

Re: [FFmpeg-devel] [PATCH] ffplay: use SDL2 audio API

2017-11-05 Thread Marton Balint
On Sat, 4 Nov 2017, James Almer wrote: On 11/4/2017 3:54 PM, Marton Balint wrote: It allows us to specify what kind of audio parameter changes are allowed. Should fix ticket #6721. Seems to work. Thanks. Thanks, applied. Regards, Marton ___

[FFmpeg-devel] adding bluetooth SBC codec

2017-11-05 Thread Aurelien Jacobs
Hello everyone, Long time no see ! I'm glad to see ffmpeg still strong. I'm curently playing with bluetooth audio (A2DP) and I wanted to use lavc to do the encoding/decoding, so I added some codecs that I need to ffmpeg. Here is the result for the SBC codec. [PATCH 1/3] sbc: implement SBC

Re: [FFmpeg-devel] [PATCH 2/2] aptx: add raw muxer and demuxer for aptX

2017-11-05 Thread Aurelien Jacobs
On Mon, Nov 06, 2017 at 12:51:19AM +0100, Carl Eugen Hoyos wrote: > 2017-11-06 0:39 GMT+01:00 Aurelien Jacobs : > > > +static int aptx_probe(AVProbeData *p) > > +{ > > +int len, score = 0; > > +if (!p || !p->filename) > > +return 0; > > +len =

Re: [FFmpeg-devel] [PATCH 1/3] sbc: implement SBC codec (low-complexity subband codec)

2017-11-05 Thread Michael Niedermayer
Hi On Mon, Nov 06, 2017 at 12:35:18AM +0100, Aurelien Jacobs wrote: > This was originally based on libsbc, and was fully integrated into ffmpeg. > --- > doc/general.texi | 2 + > libavcodec/Makefile | 4 + > libavcodec/allcodecs.c | 2 + >

[FFmpeg-devel] [PATCH] examples/vaapi_encode: Add a VA-API encode example.

2017-11-05 Thread Jun Zhao
From d16f766363d9ecc240b0f8e025c2a8f91ea4775e Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Mon, 6 Nov 2017 14:45:27 +0800 Subject: [PATCH] examples/vaapi_encode: Add a VA-API encode example. add a VA-API encode example, only support NV12 input, usage like: ./vaapi_encode

[FFmpeg-devel] [PATCH] avformat: move priv_pts from AVStream to an internal struct

2017-11-05 Thread James Almer
It has no reason to be in a public header, even if defined as private. Signed-off-by: James Almer --- To be honest, none of the fields below the "not part of the API" notice have any reason to be in the public struct, but this one is particularly pointless and ugly to have

Re: [FFmpeg-devel] On in-tree external headers

2017-11-05 Thread Carl Eugen Hoyos
2017-11-05 19:35 GMT+01:00 Mark Thompson : > On 05/11/17 18:28, Carl Eugen Hoyos wrote: >> 2017-11-05 15:24 GMT+01:00 Mark Thompson : >>> On 30/10/17 19:51, Mark Thompson wrote: >> >>> "No external headers may be included in the ffmpeg tree." >> >> So you suggest to

Re: [FFmpeg-devel] On in-tree external headers

2017-11-05 Thread Mark Thompson
On 05/11/17 19:01, Nicolas George wrote: > Le quintidi 15 brumaire, an CCXXVI, Mark Thompson a écrit : >> +AviSynth and Nvidia are exempt from this prohibition on external headers. > > So if somebody wants to add new headers, they just have to propose a > patch to this sentence to add another