Re: [FFmpeg-devel] [PATCH]: Change Stack Frame Limit in Cuda Context

2018-01-26 Thread Ben Chang
Thanks for the review Mark. On Thu, Jan 25, 2018 at 4:13 PM, Mark Thompson wrote: > > > diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c > > index 4a91d99..2da251b 100644 > > --- a/libavcodec/nvenc.c > > +++ b/libavcodec/nvenc.c > > @@ -420,6 +420,12 @@ static av_cold int

Re: [FFmpeg-devel] [PATCH] lavc/qsv: skip the packet if decoding failure.

2018-01-26 Thread Mark Thompson
On 26/01/18 07:33, Song, Ruiling wrote: > > >> -Original Message- >> From: Jun Zhao [mailto:mypopy...@gmail.com] >> Sent: Friday, January 26, 2018 1:02 PM >> To: FFmpeg development discussions and patches ; >> Song, Ruiling >> Subject:

Re: [FFmpeg-devel] [PATCH] lavc/aarch64/sbrdsp_neon: fix build on old binutils

2018-01-26 Thread Matthieu Bouron
On Thu, Jan 25, 2018 at 09:44:55PM -0600, Rodger Combs wrote: > --- > libavcodec/aarch64/sbrdsp_neon.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/aarch64/sbrdsp_neon.S > b/libavcodec/aarch64/sbrdsp_neon.S > index d1d79b749c..d23717e760 100644 > ---

Re: [FFmpeg-devel] [PATCH]: Change Stack Frame Limit in Cuda Context

2018-01-26 Thread Mark Thompson
On 26/01/18 09:06, Ben Chang wrote: > Thanks for the review Mark. > > On Thu, Jan 25, 2018 at 4:13 PM, Mark Thompson wrote: >> >>> diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c >>> index 4a91d99..2da251b 100644 >>> --- a/libavcodec/nvenc.c >>> +++ b/libavcodec/nvenc.c >>>

[FFmpeg-devel] [PATCH v3] avcodec/libopus: support disabling phase inversion.

2018-01-26 Thread Menno de Gier
From: Menno This supports disabling phase inversion in both the libopus encoder and the decoder. Signed-off-by: Menno --- doc/encoders.texi | 5 + libavcodec/libopusdec.c | 33 + libavcodec/libopusenc.c | 14

[FFmpeg-devel] [PATCH] avformat/mpegenc - fix PCM 16BE muxing and disallow, unsupported audio codecs

2018-01-26 Thread Gyan Doshi
From 7c31072230e392ca8be218df4a1f5a2c1b5d Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Fri, 26 Jan 2018 19:15:28 +0530 Subject: [PATCH] avformat/mpegenc - fix PCM 16BE muxing and disallow unsupported audio codecs PCM_S16BE streams in MPEG-PS are recognized as PCM_DVD

Re: [FFmpeg-devel] [PATCH] rtsp: rename certain options after a deprecation period

2018-01-26 Thread Michael Niedermayer
On Fri, Jan 26, 2018 at 02:45:47AM +0200, Jan Ekström wrote: > On Fri, Jan 26, 2018 at 1:56 AM, Carl Eugen Hoyos wrote: > > 2018-01-26 0:52 GMT+01:00 wm4 : > >> (and I already wrote that on IRC too, where he lurks as > >> michaelni) > > > > Could one of

[FFmpeg-devel] [PATCH V2] example/vaapi_transcode: Add a VA-API transcode example.

2018-01-26 Thread Jun Zhao
V2: - deduce output format from file extension, because VP8/VP9 encoder need to a muxer (e,g ivf or/and mp4). From 9828a8889d5279202c2e8ef9429eb06ad869842b Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Thu, 11 Jan 2018 15:00:30 +0800 Subject: [PATCH V2]

Re: [FFmpeg-devel] GSoC 2018

2018-01-26 Thread Thilo Borgmann
Am 26.01.18 um 18:15 schrieb Pedro Arthur: > 2018-01-26 14:26 GMT-02:00 Rostislav Pehlivanov : > >> I think actually writing and reading papers for the filter is pointless - >> RAVU already exists in shader form, its well known in the community and >> we'll essentially get it

Re: [FFmpeg-devel] GSoC 2018

2018-01-26 Thread Pedro Arthur
2018-01-26 14:26 GMT-02:00 Rostislav Pehlivanov : > I think actually writing and reading papers for the filter is pointless - > RAVU already exists in shader form, its well known in the community and > we'll essentially get it for free once the Vulkan backend is complete. >

Re: [FFmpeg-devel] GSoC 2018

2018-01-26 Thread Rostislav Pehlivanov
On 15 January 2018 at 22:08, Pedro Arthur wrote: > Added an entry in the ideas page for the super resolution project. I'd like > to know if any one could be co-mentor with me? just in case my studies > conflicts with mentoring as gsoc overlaps with half of my phd period. >

Re: [FFmpeg-devel] [PATCH 1/2] lavc: Add coded_w/h to AVCodecParameters

2018-01-26 Thread Michael Niedermayer
On Fri, Jan 19, 2018 at 01:15:13PM -0300, James Almer wrote: > On 1/19/2018 7:12 AM, Hendrik Leppkes wrote: > > On Fri, Jan 19, 2018 at 4:19 AM, Li, Zhong wrote: > >>> -Original Message- > >>> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > >>>

Re: [FFmpeg-devel] [PATCH]: Change Stack Frame Limit in Cuda Context

2018-01-26 Thread Timo Rothenpieler
Am 26.01.2018 um 10:06 schrieb Ben Chang: Thanks for the review Mark. On Thu, Jan 25, 2018 at 4:13 PM, Mark Thompson wrote: diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 4a91d99..2da251b 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -420,6 +420,12

[FFmpeg-devel] [PATCH] avcodec/nvenc: refcount input frame mappings

2018-01-26 Thread Timo Rothenpieler
If some logic like vsync in ffmpeg.c duplicates frames, it might pass the same frame twice, which will result in a crash due it being effectively mapped and unmapped twice. Signed-off-by: Timo Rothenpieler --- libavcodec/nvenc.c | 39

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-26 Thread Kieran Kunhya
On Mon, Jan 22, 2018 at 2:07 AM, Michael Niedermayer wrote: > On Sun, Jan 21, 2018 at 12:37:21PM +, Kieran Kunhya wrote: > > On Mon, Jan 1, 2018 at 7:01 PM, Michael Niedermayer > > > wrote: > > > > > Hi > > > > > > > Patch updated. > > Some

Re: [FFmpeg-devel] [PATCH]: Change Stack Frame Limit in Cuda Context

2018-01-26 Thread Ben Chang
On Fri, Jan 26, 2018 at 3:32 AM, Mark Thompson wrote: > On 26/01/18 09:06, Ben Chang wrote: > > Thanks for the review Mark. > > > > There are some cuda kernels in the driver that may be invoked depending > on > > the nvenc operations specified in the commandline. My observation

Re: [FFmpeg-devel] [PATCH]: Change Stack Frame Limit in Cuda Context

2018-01-26 Thread Mark Thompson
On 26/01/18 20:51, Ben Chang wrote: > On Fri, Jan 26, 2018 at 3:32 AM, Mark Thompson wrote: > >> On 26/01/18 09:06, Ben Chang wrote: >>> Thanks for the review Mark. >>> To clarify, since it is less clear now with the trimmed context: my two comments about this change are

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-26 Thread Kieran Kunhya
On Mon, Jan 22, 2018 at 10:53 AM, Carl Eugen Hoyos wrote: > 2018-01-22 11:41 GMT+01:00 Marton Balint : > > > Your command line shows gcc 4.7. Maybe this is > > some compiler issue then? > > I can also reproduce the issue with vanilla gcc 6.3.0, > so I don't

Re: [FFmpeg-devel] [PATCH] rtsp: rename certain options after a deprecation period

2018-01-26 Thread wm4
On Thu, 25 Jan 2018 19:00:43 +0100 wm4 wrote: > The names inherently clash with the meanings of the HTTP libavformat > protocol options. Rename them after a deprecation period to make them > compatible with the HTTP ones. > --- > I see no better way that wouldn't require

Re: [FFmpeg-devel] [PATCH V2 2/2] Don't overwrite previously setup dimensions for all codecs

2018-01-26 Thread Michael Niedermayer
On Thu, Jan 18, 2018 at 01:03:34PM +0800, Zhong Li wrote: > Currently a hacky way is used for some specific codecs such as > H264/VP6F/DXV (and "lowres" case is broken now). > Replace with a more generic way(an evolution based on a libav commit > 9de9b828 but hasn't been merged since it breaks

[FFmpeg-devel] [PATCH] mov: do not mark timed thumbnail tracks as attached picture

2018-01-26 Thread wm4
The AV_DISPOSITION_ATTACHED_PIC flag is meant only for exporting a static picture (such as embedded cover art) as pseudo video track. The requirement is that there is exactly 1 packet, and that normal demuxing does not return it (otherwise avformat_queue_attached_pictures() would add it a second

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-26 Thread Michael Niedermayer
On Fri, Jan 26, 2018 at 08:04:39PM +, Kieran Kunhya wrote: > On Mon, Jan 22, 2018 at 2:07 AM, Michael Niedermayer > wrote: > > > On Sun, Jan 21, 2018 at 12:37:21PM +, Kieran Kunhya wrote: > > > On Mon, Jan 1, 2018 at 7:01 PM, Michael Niedermayer > >

Re: [FFmpeg-devel] [PATCH V2 2/2] Don't overwrite previously setup dimensions for all codecs

2018-01-26 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Michael Niedermayer > Sent: Saturday, January 27, 2018 8:05 AM > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH V2 2/2] Don't overwrite previously setup >

Re: [FFmpeg-devel] [PATCH] avfilter/vf_transpose: Fix used plane count.

2018-01-26 Thread Michael Niedermayer
On Wed, Jan 24, 2018 at 09:51:42PM +0100, Michael Niedermayer wrote: > Fixes out of array access > Fixes: poc.mp4 > > Found-by: GwanYeong Kim > Signed-off-by: Michael Niedermayer > --- > libavfilter/vf_transpose.c | 8 +++- > 1 file changed, 7

Re: [FFmpeg-devel] [PATCH] avfilter/vf_framerate: fix cpy_line_width calculation on >8 bits format

2018-01-26 Thread Michael Niedermayer
On Sat, Jan 20, 2018 at 03:04:58PM +0700, Muhammad Faiz wrote: > Fix tsan warnings on fate-filter-framerate-12bit-down and > fate-filter-framerate-12bit-up. > > Signed-off-by: Muhammad Faiz > --- > libavfilter/vf_framerate.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [FFmpeg-devel] [PATCH] rtsp: rename certain options after a deprecation period

2018-01-26 Thread James Almer
On 1/26/2018 11:23 PM, wm4 wrote: > On Sat, 27 Jan 2018 02:25:49 +0100 > Michael Niedermayer wrote: > >> On Fri, Jan 26, 2018 at 12:52:19AM +0100, wm4 wrote: >>> On Fri, 26 Jan 2018 00:21:14 +0100 >>> Carl Eugen Hoyos wrote: >>> 2018-01-26

Re: [FFmpeg-devel] [PATCH] rtsp: rename certain options after a deprecation period

2018-01-26 Thread wm4
On Fri, 26 Jan 2018 23:26:20 -0300 James Almer wrote: > On 1/26/2018 11:23 PM, wm4 wrote: > > On Sat, 27 Jan 2018 02:25:49 +0100 > > Michael Niedermayer wrote: > > > >> On Fri, Jan 26, 2018 at 12:52:19AM +0100, wm4 wrote: > >>> On Fri, 26 Jan 2018

Re: [FFmpeg-devel] [PATCH] mov: do not mark timed thumbnail tracks as attached picture

2018-01-26 Thread Marton Balint
On Sat, 27 Jan 2018, wm4 wrote: The AV_DISPOSITION_ATTACHED_PIC flag is meant only for exporting a static picture (such as embedded cover art) as pseudo video track. The requirement is that there is exactly 1 packet, and that normal demuxing does not return it (otherwise

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-26 Thread Kieran Kunhya
On Sat, Jan 27, 2018 at 12:33 AM, Michael Niedermayer < mich...@niedermayer.cc> wrote: > On Fri, Jan 26, 2018 at 08:04:39PM +, Kieran Kunhya wrote: > > On Mon, Jan 22, 2018 at 2:07 AM, Michael Niedermayer > > > wrote: > > > > > On Sun, Jan 21, 2018 at 12:37:21PM

Re: [FFmpeg-devel] [PATCH 3/3] hls: don't print a certain warning if playlist loading is aborted

2018-01-26 Thread wm4
On Fri, 26 Jan 2018 11:11:46 +0800 刘歧 wrote: > > On 24 Jan 2018, at 15:08, wm4 wrote: > > > > AVERROR_EXIT happens when the user's interrupt callback signals that > > playback should be aborted. In this case, the demuxer shouldn't print a > >

Re: [FFmpeg-devel] [PATCH] mov: do not mark timed thumbnail tracks as attached picture

2018-01-26 Thread wm4
On Sat, 27 Jan 2018 01:44:04 +0100 (CET) Marton Balint wrote: > On Sat, 27 Jan 2018, wm4 wrote: > > > The AV_DISPOSITION_ATTACHED_PIC flag is meant only for exporting a > > static picture (such as embedded cover art) as pseudo video track. The > > requirement is that there is

Re: [FFmpeg-devel] [PATCH] rtsp: rename certain options after a deprecation period

2018-01-26 Thread Michael Niedermayer
On Fri, Jan 26, 2018 at 12:52:19AM +0100, wm4 wrote: > On Fri, 26 Jan 2018 00:21:14 +0100 > Carl Eugen Hoyos wrote: > > > 2018-01-26 0:00 GMT+01:00 Hendrik Leppkes : > > > On Thu, Jan 25, 2018 at 11:35 PM, Carl Eugen Hoyos > > >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/hevc_cabac: Check prefix so as to avoid invalid shifts in coeff_abs_level_remaining_decode()

2018-01-26 Thread Michael Niedermayer
On Tue, Jan 23, 2018 at 07:44:24PM +0100, Michael Niedermayer wrote: > On Tue, Jan 16, 2018 at 12:37:28AM +0100, Michael Niedermayer wrote: > > I suspect that this can be limited tighter, but i failed to find anything > > in the spec that would confirm that. > > > > Fixes:

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/mjpegdec: Fix integer overflow in DC dequantization

2018-01-26 Thread Michael Niedermayer
On Wed, Jan 24, 2018 at 04:34:50AM +0100, Michael Niedermayer wrote: > Fixes: runtime error: signed integer overflow: -65535 * 65312 cannot be > represented in type 'int' > Fixes: 4900/clusterfuzz-testcase-minimized-5769019744321536 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-01-26 Thread Michael Niedermayer
On Mon, Jan 15, 2018 at 09:02:01AM -0500, Nablet Developer wrote: > protocol requires libsrt (https://github.com/Haivision/srt) to be > installed This overall looks good, a few issues/suggestions i spoted are below: [...] > +@table @option > +@item conntimeo=@var{milliseconds} > +Connection

Re: [FFmpeg-devel] [PATCH] rtsp: rename certain options after a deprecation period

2018-01-26 Thread wm4
On Sat, 27 Jan 2018 02:25:49 +0100 Michael Niedermayer wrote: > On Fri, Jan 26, 2018 at 12:52:19AM +0100, wm4 wrote: > > On Fri, 26 Jan 2018 00:21:14 +0100 > > Carl Eugen Hoyos wrote: > > > > > 2018-01-26 0:00 GMT+01:00 Hendrik Leppkes

Re: [FFmpeg-devel] [PATCH] avfilter/vf_framerate: fix cpy_line_width calculation on >8 bits format

2018-01-26 Thread Marton Balint
On Sat, 27 Jan 2018, Michael Niedermayer wrote: On Sat, Jan 20, 2018 at 03:04:58PM +0700, Muhammad Faiz wrote: Fix tsan warnings on fate-filter-framerate-12bit-down and fate-filter-framerate-12bit-up. Signed-off-by: Muhammad Faiz --- libavfilter/vf_framerate.c | 2 +- 1

[FFmpeg-devel] [PATCH] qsvdec: Relax the surface vs coded dimension check

2018-01-26 Thread Zhong Li
Fix a common vp8 decoding failure. Many vp8 clips cannot decode if hw_frames_ctx is enabled, reporting "Error during QSV decoding.: incompatible video parameters (-14)". It is due to mfx.FrameInfo.Width/Height not matching coded_w/coded_h. See: -hwaccel qsv -init_hw_device qsv -c:v vp8_qsv -i

[FFmpeg-devel] [PATCH V3] lavc: Don't overwrite previously setup dimensions for all codecs

2018-01-26 Thread Zhong Li
Currently a hacky way is used for some specific codecs such as H264/VP6F/DXV. Replace with a more generic way(an evolution based on a libav commit 9de9b828 but hasn't been merged since it breaks lowres). Verified it won't introduce regression of original ticket #1386 fixing. V2: add "lowres"