Re: [FFmpeg-devel] [RFC] avpriv cleanup

2018-03-25 Thread wm4
On Sun, 25 Mar 2018 23:46:25 +0200 Michael Niedermayer wrote: > On Sun, Mar 25, 2018 at 05:55:37PM +0200, wm4 wrote: > > On Sun, 25 Mar 2018 17:34:51 +0200 > > Michael Niedermayer wrote: > > > > > On Sun, Mar 25, 2018 at 05:07:33PM +0200, wm4

[FFmpeg-devel] [V2 2/2] lavc/vaapi_encode: fix to set the default max bitrate for VBR

2018-03-25 Thread Pengfei Qu
The current RC(CBR/VBR) mode in ffmpeg-vaapi depends on the target bitrate and max bitrate. CBR when target bitrate equal to max bitrate, or VBR. Here is the background to have this solution. One issue I saw when doing transcoding Mpeg2(interlace)->AVC on VBR mode, the real output bitrate go away

[FFmpeg-devel] [V2 1/2] lavc/vaapi_encode: fix the caculation overflow

2018-03-25 Thread Pengfei Qu
this fix the overflow during the caculation before value assignment. Signed-off-by: Pengfei Qu --- libavcodec/vaapi_encode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c index 36c85a3..78347d4

[FFmpeg-devel] [PATCH] avcodec/dcaenc: Use aac psychoacoustic model for dcaenc

2018-03-25 Thread Даниил Чередник
There are several reasons to replace dca psychoacoustic to common model: - dca psychoacoustic has some quality problems especially at high frequency bands - unclear implementation - aac implementation allows to use tonality measurement for future improvements - a bit faster AAC psychoacoustic

Re: [FFmpeg-devel] [PATCH v2] avcodec/arm/hevcdsp_sao : add NEON optimization for sao

2018-03-25 Thread Shengbin Meng
> On 22 Mar 2018, at 20:51, Yingming Fan wrote: > > From: Meng Wang > > Signed-off-by: Meng Wang > --- > This v2 patch remove unused codes 'stride_dst /= sizeof(uint8_t);' compared > to v1. V1 have this codes

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: initialize saveptrs

2018-03-25 Thread Timo Rothenpieler
Am 21.03.2018 um 20:37 schrieb Timo Rothenpieler: Am 21.03.2018 um 20:33 schrieb Timo Rothenpieler: av_strtok calls strspn on a non-NULL *saveptr, so not NULL initializing it is an issue. Fixes CID #1428568 ---   libavformat/hlsenc.c | 3 ++-   1 file changed, 2 insertions(+), 1 deletion(-)

[FFmpeg-devel] [Patch][GSoC] srcnn - a super resolution filter using CNN

2018-03-25 Thread Mina
Hi,   This patch is introduced as a qualification task required by Super Resolution project for GSoC. It passes patchcheck and make fate, doesn't introduce new warnings and gives expected results for all tested images. It's implemented by the help of the mentor: Pedro Arthur. Best regards,

[FFmpeg-devel] [PATCH] avfilter/vf_avgblur_opencl: fix error when clSetKernelArg fails

2018-03-25 Thread dylanf123
From: drfer3 Fixes Coverity CID 1430382 --- libavfilter/vf_avgblur_opencl.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavfilter/vf_avgblur_opencl.c b/libavfilter/vf_avgblur_opencl.c index 5ee66c0ba2..09caa1fd4f 100644 ---

Re: [FFmpeg-devel] [PATCH] avcodec/dcaenc: Use aac psychoacoustic model for dcaenc

2018-03-25 Thread Michael Niedermayer
On Sun, Mar 25, 2018 at 01:55:42PM +0300, Даниил Чередник wrote: [...] > libavcodec/dcaenc.c | 369 > -- > libavcodec/psymodel.c |1 > tests/fate/acodec.mak |4 > 3 files changed, 156 insertions(+), 218 deletions(-) >

Re: [FFmpeg-devel] [RFC] avpriv cleanup

2018-03-25 Thread Nicolas George
Michael Niedermayer (2018-03-25): > The thread is for finding out peoples oppinon before anyone spends time > writing patches. If you have time to spend on the avpriv issue, I suggest you spend it trying to get this working. It would be most beneficial. Regards, -- Nicolas George From

Re: [FFmpeg-devel] [PATCH] avcodec/avpacket: ensure the packet is writable in av_shrink_packet()

2018-03-25 Thread wm4
On Sat, 24 Mar 2018 22:39:45 -0300 James Almer wrote: > On 3/24/2018 6:46 PM, wm4 wrote: > > On Sat, 24 Mar 2018 18:11:53 -0300 > > James Almer wrote: > > > >> Signed-off-by: James Almer > >> --- > >> This is a good time to deprecate

Re: [FFmpeg-devel] [PATCH] lavc: Add filter_units bitstream filter

2018-03-25 Thread Eran Kornblau
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Mark > Thompson > Sent: Sunday, March 11, 2018 8:38 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] lavc: Add filter_units bitstream filter > > On 08/03/18 04:01, James

Re: [FFmpeg-devel] [PATCH 0/5] Add lavfi api & remove device iteration

2018-03-25 Thread Josh de Kock
On 2018/03/23 20:48, Josh de Kock wrote: This set is an alternative to the previous set I posted, it makes it so that the current behaviour is kept (devices are returned in by the iteration functions but must be loaded in manually). It is a compromise between what Nicolas George suggested and a

Re: [FFmpeg-devel] [PATCH] avfilter/af_pan: parse properly expressions referencing the same channel multiple times

2018-03-25 Thread Nicolas George
Marton Balint (2018-03-24): > Fixes parsing of expressions like c0=c0+c0. Previously no error was thrown and > only the last gain factor was used. > > Signed-off-by: Marton Balint > --- > libavfilter/af_pan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks for

Re: [FFmpeg-devel] [PATCH v4 3/7] cmdutils: use new iteration APIs

2018-03-25 Thread wm4
On Sun, 25 Mar 2018 16:41:12 +0200 Michael Niedermayer wrote: > On Sun, Mar 25, 2018 at 03:32:33PM +0200, Nicolas George wrote: > > Josh de Kock (2018-03-23): > [...] > > > You can observe just that by the fact that you needed to add an avpriv > > function to let lavd

Re: [FFmpeg-devel] [RFC] avpriv cleanup

2018-03-25 Thread Michael Niedermayer
On Sun, Mar 25, 2018 at 05:07:33PM +0200, wm4 wrote: > On Sun, 25 Mar 2018 17:00:32 +0200 > Michael Niedermayer wrote: > > > Hi all > > > > Nicolas wrote an interresting comment about avpriv, and as this better > > belongs into a new thread, here it is in a new thread >

Re: [FFmpeg-devel] [PATCH v4 3/7] cmdutils: use new iteration APIs

2018-03-25 Thread Josh de Kock
On 2018/03/25 16:21, Michael Niedermayer wrote: On Fri, Mar 23, 2018 at 11:05:22AM +0100, Nicolas George wrote: Josh de Kock (2018-03-22): move lavd avinputformats and avoutputformats into lavf delete lavd Possibly ok in principle for me, but see below. write new lavd aimed at actual

Re: [FFmpeg-devel] [RFC] avpriv cleanup

2018-03-25 Thread James Almer
On 3/25/2018 12:19 PM, Nicolas George wrote: > Michael Niedermayer (2018-03-25): >> looking at what we have as avprivs, in the tree, i think some of these >> could be indeed usefull as public APIs. And we need to already keep them >> compatible as they are exported as avpriv too, so making such

Re: [FFmpeg-devel] [RFC] avpriv cleanup

2018-03-25 Thread wm4
On Sun, 25 Mar 2018 17:39:17 +0200 Nicolas George wrote: > Michael Niedermayer (2018-03-25): > > The thread is for finding out peoples oppinon before anyone spends time > > writing patches. > > If you have time to spend on the avpriv issue, I suggest you spend it > trying to

Re: [FFmpeg-devel] [PATCH v4 3/7] cmdutils: use new iteration APIs

2018-03-25 Thread Michael Niedermayer
On Sun, Mar 25, 2018 at 04:35:12PM +0100, Josh de Kock wrote: > On 2018/03/25 16:21, Michael Niedermayer wrote: > >On Fri, Mar 23, 2018 at 11:05:22AM +0100, Nicolas George wrote: > >>Josh de Kock (2018-03-22): [...] > > >People would just start to switch to the current API only to have it >

Re: [FFmpeg-devel] [PATCH] vf_avgblur_opencl: Don't run kernel on pixels outside the image

2018-03-25 Thread Dylan Fernando
On Sun, Mar 25, 2018 at 1:06 AM, Mark Thompson wrote: > The output frame size is larger than the image containing a subsampled > plane - use the actual size of the image being written rather than the > dimensions of the intended output frame. > --- >

Re: [FFmpeg-devel] [PATCH v4 3/7] cmdutils: use new iteration APIs

2018-03-25 Thread Nicolas George
Josh de Kock (2018-03-23): > I personally think this will fix a lot of the weird interactions between the > two libraries, and should be considered a serious option independent of the > new API. Maybe. But that is for another discussion. > Sure, I guess but I still think it's more involved than

[FFmpeg-devel] [PATCH] lavc/cfhd: error due to improper allocation of height in buffers

2018-03-25 Thread Gagandeep Singh
ticket #6675 the distortion in the bottom 8 pixels fixed --- libavcodec/cfhd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/cfhd.c b/libavcodec/cfhd.c index e35732df45..f10742f4fa 100644 --- a/libavcodec/cfhd.c +++ b/libavcodec/cfhd.c @@ -213,13 +213,14 @@

Re: [FFmpeg-devel] [PATCH v4 3/7] cmdutils: use new iteration APIs

2018-03-25 Thread Michael Niedermayer
On Sun, Mar 25, 2018 at 03:32:33PM +0200, Nicolas George wrote: > Josh de Kock (2018-03-23): [...] > You can observe just that by the fact that you needed to add an avpriv > function to let lavd communicate with lavf. Each time an avpriv function > appears, it shows there is something flawed in

Re: [FFmpeg-devel] [RFC] avpriv cleanup

2018-03-25 Thread wm4
On Sun, 25 Mar 2018 17:00:32 +0200 Michael Niedermayer wrote: > Hi all > > Nicolas wrote an interresting comment about avpriv, and as this better > belongs into a new thread, here it is in a new thread > > On Sun, Mar 25, 2018 at 03:32:33PM +0200, Nicolas George wrote:

Re: [FFmpeg-devel] [RFC] avpriv cleanup

2018-03-25 Thread Nicolas George
Michael Niedermayer (2018-03-25): > looking at what we have as avprivs, in the tree, i think some of these > could be indeed usefull as public APIs. And we need to already keep them > compatible as they are exported as avpriv too, so making such changes does > indeed in some cases look like a good

Re: [FFmpeg-devel] [PATCH v4 3/7] cmdutils: use new iteration APIs

2018-03-25 Thread Michael Niedermayer
On Fri, Mar 23, 2018 at 11:05:22AM +0100, Nicolas George wrote: > Josh de Kock (2018-03-22): > > move lavd avinputformats and avoutputformats into lavf > > > > delete lavd > > Possibly ok in principle for me, but see below. > > > write new lavd aimed at actual devices > > There are already

Re: [FFmpeg-devel] [PATCH] avcodec/avpacket: ensure the packet is writable in av_shrink_packet()

2018-03-25 Thread James Almer
On 3/25/2018 9:14 AM, wm4 wrote: > On Sat, 24 Mar 2018 22:39:45 -0300 > James Almer wrote: > >> On 3/24/2018 6:46 PM, wm4 wrote: >>> On Sat, 24 Mar 2018 18:11:53 -0300 >>> James Almer wrote: >>> Signed-off-by: James Almer

[FFmpeg-devel] [RFC] avpriv cleanup

2018-03-25 Thread Michael Niedermayer
Hi all Nicolas wrote an interresting comment about avpriv, and as this better belongs into a new thread, here it is in a new thread On Sun, Mar 25, 2018 at 03:32:33PM +0200, Nicolas George wrote: > Josh de Kock (2018-03-23): [...] > You can observe just that by the fact that you needed to

Re: [FFmpeg-devel] [RFC] avpriv cleanup

2018-03-25 Thread wm4
On Sun, 25 Mar 2018 17:34:51 +0200 Michael Niedermayer wrote: > On Sun, Mar 25, 2018 at 05:07:33PM +0200, wm4 wrote: > > On Sun, 25 Mar 2018 17:00:32 +0200 > > Michael Niedermayer wrote: > > > > > Hi all > > > > > > Nicolas wrote an

Re: [FFmpeg-devel] [RFC] avpriv cleanup

2018-03-25 Thread wm4
On Sun, 25 Mar 2018 12:47:41 -0300 James Almer wrote: > On 3/25/2018 12:19 PM, Nicolas George wrote: > > Michael Niedermayer (2018-03-25): > >> looking at what we have as avprivs, in the tree, i think some of these > >> could be indeed usefull as public APIs. And we need to

Re: [FFmpeg-devel] [PATCH] avfilter/vf_scale: Do not set YUV color range for RGB formats

2018-03-25 Thread Michael Niedermayer
On Wed, Mar 21, 2018 at 03:04:35PM +0100, wm4 wrote: > On Tue, 20 Mar 2018 23:59:46 +0100 > Michael Niedermayer wrote: > > > Signed-off-by: Michael Niedermayer > > --- > > libavfilter/vf_scale.c | 7 ++- > > 1 file changed, 6 insertions(+), 1

Re: [FFmpeg-devel] [PATCH] avfilter/vf_scale: Do not set YUV color range for RGB formats

2018-03-25 Thread Michael Niedermayer
On Wed, Mar 21, 2018 at 09:18:21AM +0100, Paul B Mahol wrote: > On 3/20/18, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > libavfilter/vf_scale.c | 7 ++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > >

[FFmpeg-devel] [PATCH] avfilter/vf_avgblur_opencl: fix error when clSetKernelArg fails

2018-03-25 Thread dylanf123
From: drfer3 Fixes Coverity CID 1430382 --- libavfilter/vf_avgblur_opencl.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavfilter/vf_avgblur_opencl.c b/libavfilter/vf_avgblur_opencl.c index 5ee66c0ba2..53db83c21f 100644 ---

Re: [FFmpeg-devel] [PATCH] avcodec/get_bits: Document skip_bits_long()

2018-03-25 Thread Michael Niedermayer
apparently i failed to send this reply after writing it On Fri, Mar 23, 2018 at 10:02:39PM +0100, Thilo Borgmann wrote: > Am 23.03.18 um 20:20 schrieb Michael Niedermayer: > > Found-by: Kieran > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/get_bits.h | 7

Re: [FFmpeg-devel] [PATCH] avcodec/get_bits: Make sure the input bitstream with padding can be addressed

2018-03-25 Thread Michael Niedermayer
On Sat, Mar 24, 2018 at 01:56:26AM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/get_bits.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) will apply [...] -- Michael GnuPG fingerprint:

[FFmpeg-devel] (no subject)

2018-03-25 Thread dylanf123
Thanks, fixed - Dylan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] ffmpeg_filter: enable stream_loop in HWAccel transcoding.

2018-03-25 Thread Jun Zhao
On 2018/3/24 8:14, Michael Niedermayer wrote: > On Wed, Mar 14, 2018 at 04:26:54PM +0800, Jun Zhao wrote: >> ffmpeg_filter.c |4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> 170327a7137d3ce26124c86525566d32c523a948 >>

Re: [FFmpeg-devel] [PATCH 2/5] h264_metadata: Add support for A/53 closed captions

2018-03-25 Thread James Almer
On 3/25/2018 2:41 PM, Mark Thompson wrote: > Allows insertion (from side data), extraction (to side data), and removal > of closed captions in SEI messages. > --- > libavcodec/Makefile| 2 +- > libavcodec/h264_metadata_bsf.c | 138 > + > 2

Re: [FFmpeg-devel] [PATCH] avcodec/mpeg4videodec: Use more specific error codes

2018-03-25 Thread Michael Niedermayer
On Sat, Mar 10, 2018 at 10:17:05PM +0100, Michael Niedermayer wrote: > Forward error codes where possible. > > Signed-off-by: Michael Niedermayer > --- > libavcodec/mpeg4video.h| 4 +- > libavcodec/mpeg4videodec.c | 100 >

Re: [FFmpeg-devel] [PATCH] avformat/mov: Move +1 in check to avoid hypothetical overflow in add_ctts_entry()

2018-03-25 Thread Michael Niedermayer
On Sat, Feb 03, 2018 at 10:45:24PM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavformat/mov.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) will apply [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH 2/2] doc/examples/hw_decode: Remove logically dead code in decode_write()

2018-03-25 Thread Jun Zhao
On 2018/3/26 2:21, Michael Niedermayer wrote: > Fixes CID1415951 > > Signed-off-by: Michael Niedermayer > --- > doc/examples/hw_decode.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/doc/examples/hw_decode.c b/doc/examples/hw_decode.c >

[FFmpeg-devel] [PATCH] kmsgrab: add category for kmsgrab

2018-03-25 Thread Jun Zhao
From fc9b04d95b1e21fa9985dc611fcf43d2a4c635c0 Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Fri, 23 Mar 2018 21:32:03 +0800 Subject: [PATCH] kmsgrab: add category for kmsgrab add category for kmsgrab, then we can display kmsgrab in "ffmpeg -devices". Signed-off-by: Jun

[FFmpeg-devel] [PATCH] avcodec/avpacket: remove unnecessary check in av_packet_make_writable()

2018-03-25 Thread James Almer
Zero sized packets are already handled below in the function. This is more in line with av_packet_ref(). Signed-off-by: James Almer --- libavcodec/avpacket.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c index

Re: [FFmpeg-devel] [PATCH] avcodec: add a subcharenc mode that disables UTF-8 check

2018-03-25 Thread wm4
On Sun, 25 Mar 2018 09:00:45 -0700 Philip Langdale wrote: > On Sat, 24 Mar 2018 13:43:21 +0100 > wm4 wrote: > > > This is for applications which want to explicitly check for invalid > > UTF-8 manually, and take actions that are better than dropping

[FFmpeg-devel] [PATCHv2] avfilter/af_pan: reject expressions referencing the same channel multiple times

2018-03-25 Thread Marton Balint
Fixes parsing of expressions like c0=c0+c0 or c0=c0|c0=c1. Previously no error was thrown and for input channels, only the last gain factor was used, for output channels the source channel gains were combined. Signed-off-by: Marton Balint --- libavfilter/af_pan.c | 16

[FFmpeg-devel] [PATCH 2/5] h264_metadata: Add support for A/53 closed captions

2018-03-25 Thread Mark Thompson
Allows insertion (from side data), extraction (to side data), and removal of closed captions in SEI messages. --- libavcodec/Makefile| 2 +- libavcodec/h264_metadata_bsf.c | 138 + 2 files changed, 139 insertions(+), 1 deletion(-) diff --git

[FFmpeg-devel] [PATCH 4/5] mpeg2_metadata: Add support for A/53 closed captions

2018-03-25 Thread Mark Thompson
Allows extraction (to side data) and removal of closed captions in user data blocks. --- doc/bitstream_filters.texi | 12 ++ libavcodec/Makefile | 2 +- libavcodec/mpeg2_metadata_bsf.c | 81 - 3 files changed, 93 insertions(+), 2

[FFmpeg-devel] [PATCH 1/5] cbs: Add some common code for read/write of miscellaneous user data

2018-03-25 Thread Mark Thompson
Supports closed captions, active format and bar data as defined by SCTE 128 part 1 or A/53 part 4, suitable for use with both MPEG-2 and H.264. --- libavcodec/cbs_misc.c | 216 ++ libavcodec/cbs_misc.h | 109 +

Re: [FFmpeg-devel] [PATCH] avfilter/vf_avgblur_opencl: fix error when clSetKernelArg fails

2018-03-25 Thread Mark Thompson
On 25/03/18 13:42, dylanf...@gmail.com wrote: > From: drfer3 > > Fixes Coverity CID 1430382 > ---> Following is a patch attempting to fix the err issue. It returns -1 if > any > clSetKernelArg() fails. Is this good, or should I be using a different > return value for

[FFmpeg-devel] [PATCH 1/2] doc/examples/hw_decode: Remove useless NULL check

2018-03-25 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- doc/examples/hw_decode.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/doc/examples/hw_decode.c b/doc/examples/hw_decode.c index 14fe08b374..74a0ca32db 100644 --- a/doc/examples/hw_decode.c +++

[FFmpeg-devel] [PATCH 2/2] doc/examples/hw_decode: Remove logically dead code in decode_write()

2018-03-25 Thread Michael Niedermayer
Fixes CID1415951 Signed-off-by: Michael Niedermayer --- doc/examples/hw_decode.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/doc/examples/hw_decode.c b/doc/examples/hw_decode.c index 74a0ca32db..77ae8df35b 100644 --- a/doc/examples/hw_decode.c

Re: [FFmpeg-devel] [RFC] avpriv cleanup

2018-03-25 Thread James Almer
On 3/25/2018 1:58 PM, Nicolas George wrote: > James Almer (2018-03-25): >> Most avpriv_ functions exist solely to avoid code duplication. If it's > > Most functions exist solely to avoid code duplication. Functions, > unqualified, all of them: static, ff_, etc. The avpriv_ prefix only > exists

Re: [FFmpeg-devel] [PATCH] lavc/cfhd: error due to improper allocation of height in buffers

2018-03-25 Thread Paul B Mahol
On 3/25/18, Gagandeep Singh wrote: > ticket #6675 the distortion in the bottom 8 pixels fixed > --- > libavcodec/cfhd.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/cfhd.c b/libavcodec/cfhd.c > index e35732df45..f10742f4fa

Re: [FFmpeg-devel] [PATCH v4 3/7] cmdutils: use new iteration APIs

2018-03-25 Thread wm4
On Sun, 25 Mar 2018 17:46:50 +0200 Michael Niedermayer wrote: > On Sun, Mar 25, 2018 at 04:35:12PM +0100, Josh de Kock wrote: > > On 2018/03/25 16:21, Michael Niedermayer wrote: > > >On Fri, Mar 23, 2018 at 11:05:22AM +0100, Nicolas George wrote: > > >>Josh de Kock

Re: [FFmpeg-devel] [PATCH] avcodec: add a subcharenc mode that disables UTF-8 check

2018-03-25 Thread Philip Langdale
On Sat, 24 Mar 2018 13:43:21 +0100 wm4 wrote: > This is for applications which want to explicitly check for invalid > UTF-8 manually, and take actions that are better than dropping invalid > subtitles silently. (It's pretty much silent because sporadic avcodec > error

Re: [FFmpeg-devel] [PATCH] movtextdec: fix handling of UTF-8 subtitles

2018-03-25 Thread wm4
On Sat, 24 Mar 2018 15:48:36 +0100 wm4 wrote: > Subtitles which contained styled UTF-8 subtitles (i.e. not just 7 bit > ASCII characters) were not handled correctly. The spec mandates that > styling start/end ranges are in "characters". It's not quite clear what > a

Re: [FFmpeg-devel] [PATCHv2] avfilter/af_pan: reject expressions referencing the same channel multiple times

2018-03-25 Thread Nicolas George
Marton Balint (2018-03-25): > Fixes parsing of expressions like c0=c0+c0 or c0=c0|c0=c1. Previously no > error was thrown and for input channels, only the last gain factor was used, > for output channels the source channel gains were combined. > > Signed-off-by: Marton Balint >

Re: [FFmpeg-devel] [PATCH] lavc: Add filter_units bitstream filter

2018-03-25 Thread Mark Thompson
On 25/03/18 13:40, Eran Kornblau wrote: >> -Original Message- >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of >> Mark Thompson >> Sent: Sunday, March 11, 2018 8:38 PM >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH] lavc: Add filter_units

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/avpacket: add av_packet_make_ref()

2018-03-25 Thread James Almer
On 3/25/2018 2:54 PM, Mark Thompson wrote: > On 25/03/18 05:03, James Almer wrote: >> It works as a drop in replacement for the deprecated av_dup_packet(), >> to ensure a packet is reference counted. >> >> Signed-off-by: James Almer >> --- >> Better name welcome. >> >>

Re: [FFmpeg-devel] [RFC] avpriv cleanup

2018-03-25 Thread James Almer
On 3/25/2018 12:56 PM, wm4 wrote: > On Sun, 25 Mar 2018 12:47:41 -0300 > James Almer wrote: > >> On 3/25/2018 12:19 PM, Nicolas George wrote: >>> Michael Niedermayer (2018-03-25): looking at what we have as avprivs, in the tree, i think some of these could be

[FFmpeg-devel] [PATCH 2/2] avfilter: add declip audio filter

2018-03-25 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- Depends on declick filter. --- doc/filters.texi | 28 +++ libavfilter/Makefile | 1 + libavfilter/af_declick.c | 73 +--- libavfilter/allfilters.c | 1 + 4 files changed,

[FFmpeg-devel] [PATCH] vf_libvmaf: Fix memory leak

2018-03-25 Thread enctac
Fixes ticket #6967 --- libavfilter/vf_libvmaf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavfilter/vf_libvmaf.c b/libavfilter/vf_libvmaf.c index dfe474c40c..42c6b66b69 100644 --- a/libavfilter/vf_libvmaf.c +++ b/libavfilter/vf_libvmaf.c @@ -130,6 +130,8 @@

Re: [FFmpeg-devel] [RFC] avpriv cleanup

2018-03-25 Thread Nicolas George
James Almer (2018-03-25): > Most avpriv_ functions exist solely to avoid code duplication. If it's Most functions exist solely to avoid code duplication. Functions, unqualified, all of them: static, ff_, etc. The avpriv_ prefix only exists because of library boundaries. > so much of an issue we

[FFmpeg-devel] [PATCH 5/5] lavc/Makefile: Fix ordering of bitstream filter components

2018-03-25 Thread Mark Thompson
--- libavcodec/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index e5430ab10b..02f778231c 100644 --- a/libavcodec/Makefile +++ b/libavcodec/Makefile @@ -1039,8 +1039,8 @@ OBJS-$(CONFIG_XMA_PARSER) +=

[FFmpeg-devel] [PATCH 3/5] h264_metadata: Update documentation

2018-03-25 Thread Mark Thompson
Improve documentation for the delete_filler option, and add the display_orientation and a53_cc options. --- doc/bitstream_filters.texi | 51 +- 1 file changed, 50 insertions(+), 1 deletion(-) diff --git a/doc/bitstream_filters.texi

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/avpacket: add av_packet_make_ref()

2018-03-25 Thread Mark Thompson
On 25/03/18 05:03, James Almer wrote: > It works as a drop in replacement for the deprecated av_dup_packet(), > to ensure a packet is reference counted. > > Signed-off-by: James Almer > --- > Better name welcome. > > libavcodec/avcodec.h | 18 +- >

[FFmpeg-devel] [PATCH v2] avformat/dashdec: Support signaling of last segment number

2018-03-25 Thread sanilraut
Last segment indicated by mpd is not parsed. Example stream: http://dash.akamaized.net/dash264/TestCasesIOP41/LastSegmentNumber/1/manifest_last_segment_num.mpd This patch supports parsing of Supplemental Descriptor with @schemeIdUri set to http://dashif.org/guide- lines/last-segment-number with

Re: [FFmpeg-devel] [PATCH] Support signaling of last segment number

2018-03-25 Thread sanilraut
Thanks. @Jan: I will look into the FATE tests. I have emailed you a few questions that I have about FATE. Looking forward to your reply. @Michael: I have added the prefix and resubmitted the patch. Regards, Sanil On Fri, Mar 23, 2018 at 5:24 PM, Michael Niedermayer

Re: [FFmpeg-devel] [RFC] avpriv cleanup

2018-03-25 Thread Nicolas George
First of all, thanks for taking the time to discuss this. It has been too long, and the arguments need to be sharpened. James Almer (2018-03-25): > Considering most are pretty small but not small enough to be dumped into > a header, no, I'm not joking. > Maybe avpriv_dnxhd_get_frame_size()

Re: [FFmpeg-devel] [RFC] avpriv cleanup

2018-03-25 Thread Michael Niedermayer
On Sun, Mar 25, 2018 at 05:55:37PM +0200, wm4 wrote: > On Sun, 25 Mar 2018 17:34:51 +0200 > Michael Niedermayer wrote: > > > On Sun, Mar 25, 2018 at 05:07:33PM +0200, wm4 wrote: > > > On Sun, 25 Mar 2018 17:00:32 +0200 > > > Michael Niedermayer

Re: [FFmpeg-devel] [RFC] avpriv cleanup

2018-03-25 Thread Michael Niedermayer
On Sun, Mar 25, 2018 at 10:24:31PM +0200, Nicolas George wrote: [...] > > If they used distro packages then they wouldn't have any power over what > > gets built or shipped. Distro packages are the "Enable everything" kind > > of build, so I'm of course talking about projects shipping their own >

[FFmpeg-devel] [PATCH] avformat/concatdec: only set output stream index before returning packet

2018-03-25 Thread Marton Balint
Fixes ticket #6434. Signed-off-by: Marton Balint --- libavformat/concatdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/concatdec.c b/libavformat/concatdec.c index 8fff9cc2cb..bbe13136fa 100644 --- a/libavformat/concatdec.c +++

[FFmpeg-devel] [PATCH V2] ffmpeg_filter: enable stream_loop in HWAccel transcoding.

2018-03-25 Thread Jun Zhao
V2: simplified the logic as Michael's review. From 6c332c65d64977c4d6220acfb7e9db3505281f87 Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Wed, 14 Mar 2018 16:13:39 +0800 Subject: [PATCH V2] ffmpeg_filter: enable stream_loop in HWAccel transcoding. use the cmd: ffmpeg -y

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: initialize saveptrs

2018-03-25 Thread Jeyapal, Karthick
On 3/25/18 1:43 PM, Timo Rothenpieler wrote: > Am 21.03.2018 um 20:37 schrieb Timo Rothenpieler: >> Am 21.03.2018 um 20:33 schrieb Timo Rothenpieler: >>> av_strtok calls strspn on a non-NULL *saveptr, so not NULL >>> initializing it is an issue. >>> >>> Fixes CID #1428568 >>> --- >>>