Re: [FFmpeg-devel] [PATCH 2/3 v2] avcodec/encode: restructure the old encode API

2020-03-26 Thread James Almer
On 3/26/2020 5:57 AM, Anton Khirnov wrote: > Quoting James Almer (2020-03-16 22:30:01) >> Following the same logic as 061a0c14bb, this commit turns the old encode API >> into a wrapper for the new one. >> >> Signed-off-by: James Almer >> --- >> This could be squashed with the previous commit,

Re: [FFmpeg-devel] [PATCH v3] avformat/dashdec: fix memleak for commit commit e134c203

2020-03-26 Thread Nicolas George
Steven Liu (12020-03-24): > These member will be used for get more correct information of the MPD > > Suggested-by: Andreas Rheinhardt > Suggested-by: Nicolas George > Signed-off-by: Steven Liu > --- > libavformat/dashdec.c | 244 -- > 1 file changed,

Re: [FFmpeg-devel] [PATCHv2][GSoC]audio filter-use cellular automata to generate tones

2020-03-26 Thread Thilo Borgmann
Am 26.03.20 um 12:18 schrieb Nicolas George: > Thilo Borgmann (12020-03-26): >> Ok. So if I understand all of this correctly, the overall goal of the >> tones project is already redundant to your old proposal (or at least >> partially, Paul?). > > I do not know what the overall goal of the tones

Re: [FFmpeg-devel] [PATCH] doc/developer.texi: Add variadic macros to allowed C language features

2020-03-26 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2020-03-23 03:38:38) >> They are used in several places like CBS. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> doc/developer.texi | 3 +++ >> 1 file changed, 3 insertions(+) > > Looks ok > Applied, thanks. - Andreas

Re: [FFmpeg-devel] [PATCH 2/3 v2] avcodec/encode: restructure the old encode API

2020-03-26 Thread James Almer
On 3/26/2020 4:42 PM, Anton Khirnov wrote: > Quoting James Almer (2020-03-26 20:28:12) >> On 3/26/2020 5:57 AM, Anton Khirnov wrote: >>> Quoting James Almer (2020-03-16 22:30:01) Following the same logic as 061a0c14bb, this commit turns the old encode API into a wrapper for the new

Re: [FFmpeg-devel] [PATCH 1/3 v2] avcodec/encode: restructure the core encoding code

2020-03-26 Thread James Almer
On 3/26/2020 5:43 AM, Anton Khirnov wrote: > Quoting James Almer (2020-03-16 22:30:00) >> This commit follows the same logic as 061a0c14bb, but for the encode API: The >> new public encoding API will no longer be a wrapper around the old deprecated >> one, and the internal API used by the encoders

[FFmpeg-devel] [PATCH 2/2 v3] avcodec/encode: restructure the old encode API

2020-03-26 Thread James Almer
Following the same logic as 061a0c14bb, this commit turns the old encode API into a wrapper for the new one. Signed-off-by: James Almer --- libavcodec/encode.c | 366 +- libavcodec/internal.h | 1 + libavcodec/utils.c| 8 + 3 files changed, 118

[FFmpeg-devel] [PATCH 0/2 v3] Restructuring the encode API

2020-03-26 Thread James Almer
This set follows the same logic as 061a0c14bb, but for the encode API: The new public API will no longer be a wrapper around the old deprecated one, and the internal API used by the encoders now consists of a single receive_packet() callback that pulls frames as required. Because of the above,

[FFmpeg-devel] [PATCH 1/2 v3] avcodec/encode: restructure the core encoding code

2020-03-26 Thread James Almer
This commit follows the same logic as 061a0c14bb, but for the encode API: The new public encoding API will no longer be a wrapper around the old deprecated one, and the internal API used by the encoders now consists of a single receive_packet() callback that pulls frames as required.

Re: [FFmpeg-devel] [PATCH 1/3] avformat/matroskadec: Don't discard the upper 32bits of TrackNumber

2020-03-26 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2020-03-26 01:41:42) >> Signed-off-by: Andreas Rheinhardt >> --- >> This has already been sent in [1]; I'm resending it because it fits >> here. >> >> [1]: https://ffmpeg.org/pipermail/ffmpeg-devel/2019-December/254841.html >> >>

Re: [FFmpeg-devel] [PATCH 01/21] avformat/nsvdec: Use av_packet_move_ref() for packet ownership transfer

2020-03-26 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2020-03-22 04:47:36) >> Also simply return 0 in case a packet has been successfully read. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> libavformat/nsvdec.c | 6 ++ >> 1 file changed, 2 insertions(+), 4 deletions(-) > > Looks ok. > Thanks,

Re: [FFmpeg-devel] [PATCH 02/21] avformat/yop: Use av_packet_move_ref() for packet ownership transfer

2020-03-26 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2020-03-22 04:47:37) >> Also return 0 after successfully reading a packet. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> libavformat/yop.c | 9 +++-- >> 1 file changed, 3 insertions(+), 6 deletions(-) > > ok > Thanks, applied. - Andreas

Re: [FFmpeg-devel] [PATCH 03/21] avformat/mpeg: Remove unnecessary av_packet_unref()

2020-03-26 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2020-03-22 04:47:38) >> Forgotten in 6a67d518. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> libavformat/mpeg.c | 8 ++-- >> 1 file changed, 2 insertions(+), 6 deletions(-) > > Looks ok > Applied, thanks. - Andreas

Re: [FFmpeg-devel] [PATCH 2/3 v2] avcodec/encode: restructure the old encode API

2020-03-26 Thread Anton Khirnov
Quoting James Almer (2020-03-26 20:28:12) > On 3/26/2020 5:57 AM, Anton Khirnov wrote: > > Quoting James Almer (2020-03-16 22:30:01) > >> Following the same logic as 061a0c14bb, this commit turns the old encode > >> API > >> into a wrapper for the new one. > >> > >> Signed-off-by: James Almer >

Re: [FFmpeg-devel] [PATCH]configure: Get the correct ident for clang-cl.exe

2020-03-26 Thread Carl Eugen Hoyos
Am Do., 26. März 2020 um 11:30 Uhr schrieb Martin Storsjö : > > On Thu, 26 Mar 2020, Carl Eugen Hoyos wrote: > > > Hi! > > > > Attached patch avoids that ffmpeg claims its compiler was "No input > > file" when using clang-cl. > > > > Please comment, Carl Eugen > > > @@ -4663,7 +4663,11 @@

Re: [FFmpeg-devel] [PATCH]configure: Remove all C standard versions from the MSVC command line

2020-03-26 Thread Carl Eugen Hoyos
Am Do., 26. März 2020 um 11:29 Uhr schrieb Martin Storsjö : > > On Thu, 26 Mar 2020, Carl Eugen Hoyos wrote: > > > Hi! > > > > Attached patch removes an ugly warning shown for every file when using > > clang-cl.exe. > > > > Please comment, Carl Eugen > > LGTM Patch applied. Thank you, Carl Eugen

Re: [FFmpeg-devel] [PATCH] lavc/v4l2_m2m_dec: Init reserved bytes to zero before ioctl call

2020-03-26 Thread Andriy Gelman
On Thu, 12. Mar 22:40, Andriy Gelman wrote: > On Sun, 08. Mar 11:49, Andriy Gelman wrote: > > From: Andriy Gelman > > > > struct v4l2_selection contains reserved bytes which should be set to > > zero before the ioctl call. > > > > Fixes valgrind error: > > Syscall param

Re: [FFmpeg-devel] [PATCH v1] fftools/ffmpeg: set AV_PKT_FLAG_KEY for the subtitle packet

2020-03-26 Thread Michael Niedermayer
On Thu, Mar 26, 2020 at 10:47:37AM +0100, Anton Khirnov wrote: > Quoting Andreas Rheinhardt (2020-03-20 17:51:41) > > Jan Ekström: > > > On Fri, Mar 20, 2020 at 5:45 PM wrote: > > >> > > >> From: Limin Wang > > >> > > >> This fixes webvtt segment output. > > >> > > >> Please testing with the

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/avpacket: Always treat dst in av_packet_ref as uninitialized

2020-03-26 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2020-02-12 16:02:21) >> av_packet_ref() mostly treated the destination packet dst as uninitialized, >> i.e. the destination fields were simply overwritten. But if the source >> packet was not reference-counted, dst->buf was treated as if it pointed >>

Re: [FFmpeg-devel] [PATCH v1 1/2] avfilter/vf_showinfo: check if the s12m data size is valid

2020-03-26 Thread Michael Niedermayer
On Wed, Mar 25, 2020 at 06:45:47PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavfilter/vf_showinfo.c | 4 > 1 file changed, 4 insertions(+) will apply thx [...] -- Michael GnuPG fingerprint:

[FFmpeg-devel] [PATCH 2/2] avcodec/avcodec, avpacket: Return blank packet on av_packet_ref() failure

2020-03-26 Thread Andreas Rheinhardt
Up until now, it was completely unspecified what the content of the destination packet dst was on error. Depending upon where the error happened calling av_packet_unref() on dst might be dangerous. This commit changes this by making sure that dst is blank on error, so unreferencing it again is

[FFmpeg-devel] [PATCH v2 1/2] avcodec/avpacket: Always treat dst in av_packet_ref as uninitialized

2020-03-26 Thread Andreas Rheinhardt
av_packet_ref() mostly treated the destination packet dst as uninitialized, i.e. the destination fields were simply overwritten. But if the source packet was not reference-counted, dst->buf was treated as if it pointed to an already allocated buffer (if != NULL) to be reallocated to the desired

Re: [FFmpeg-devel] [PATCH v3] avformat/dashdec: fix memleak for commit commit e134c203

2020-03-26 Thread Steven Liu
> 2020年3月26日 下午11:46,Nicolas George 写道: > > Steven Liu (12020-03-24): >> These member will be used for get more correct information of the MPD >> >> Suggested-by: Andreas Rheinhardt >> Suggested-by: Nicolas George >> Signed-off-by: Steven Liu >> --- >> libavformat/dashdec.c | 244

Re: [FFmpeg-devel] [PATCH] libavcodec/jpeg2000.h: fix comments for JPEG2000 markers

2020-03-26 Thread Michael Niedermayer
On Wed, Mar 25, 2020 at 06:48:44PM +0530, gautamr...@gmail.com wrote: > From: Gautam Ramakrishnan > > The comments for some of the markers were incorrect. > This patch fixes the comments associated with the markers. > --- > libavcodec/jpeg2000.h | 10 +- > 1 file changed, 5

Re: [FFmpeg-devel] [PATCH 2/3 v2] avcodec/encode: restructure the old encode API

2020-03-26 Thread Anton Khirnov
Quoting James Almer (2020-03-16 22:30:01) > Following the same logic as 061a0c14bb, this commit turns the old encode API > into a wrapper for the new one. > > Signed-off-by: James Almer > --- > This could be squashed with the previous commit, like it was done in > 061a0c14bb, > but i figured it

Re: [FFmpeg-devel] [PATCHv2][GSoC]audio filter-use cellular automata to generate tones

2020-03-26 Thread Nicolas George
Ashutosh Pradhan (12020-03-26): > I was trying to random tones using cellular automata (it won't sound good > if the tones are too random so I used a scale) for the GSoC audio tones > filter project. Yes, that's already in the doc. What I ask is what good you expect from it. > On Thu, Mar 26,

Re: [FFmpeg-devel] [PATCHv2][GSoC]audio filter-use cellular automata to generate tones

2020-03-26 Thread Nicolas George
Paul B Mahol (12020-03-26): > What kind of insinuation is this? No insinuation at all, just an honest question. > This is qualification task for GSoC project, if you have something against it, > ask me directly instead. Of course, feel free to answer the question. What is the use case for this

Re: [FFmpeg-devel] [PATCHv2][GSoC]audio filter-use cellular automata to generate tones

2020-03-26 Thread Nicolas George
Ashutosh Pradhan (12020-03-26): > Since random tones generated using seed( ) was already sent on the mailing > list, Paul had suggested me to control the duration between tones and to > generate tones using cellular automata. I am not asking what YOU are doing, I am asking what benefits our users

[FFmpeg-devel] [PATCHv2][GSoC]audio filter-use cellular automata to generate tones

2020-03-26 Thread Ashutosh Pradhan
Use cellular automata and fluidsynth sequencer to generate tones in major pentatonic scale diff --git a/Changelog b/Changelog index d1572553a5..5ddd2484b0 100644 --- a/Changelog +++ b/Changelog @@ -48,6 +48,7 @@ version : - AMQP 0-9-1 protocol (RabbitMQ) - Vulkan support - avgblur_vulkan,

Re: [FFmpeg-devel] [PATCH 02/21] avformat/yop: Use av_packet_move_ref() for packet ownership transfer

2020-03-26 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-03-22 04:47:37) > Also return 0 after successfully reading a packet. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/yop.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) ok -- Anton Khirnov

Re: [FFmpeg-devel] [PATCH v1] fftools/ffmpeg: set AV_PKT_FLAG_KEY for the subtitle packet

2020-03-26 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-03-20 17:51:41) > Jan Ekström: > > On Fri, Mar 20, 2020 at 5:45 PM wrote: > >> > >> From: Limin Wang > >> > >> This fixes webvtt segment output. > >> > >> Please testing with the following command and check the output: > >> ./ffmpeg -i

Re: [FFmpeg-devel] [PATCHv2][GSoC]audio filter-use cellular automata to generate tones

2020-03-26 Thread Paul B Mahol
On 3/26/20, Nicolas George wrote: > Ashutosh Pradhan (12020-03-26): >> I was trying to random tones using cellular automata (it won't sound good >> if the tones are too random so I used a scale) for the GSoC audio tones >> filter project. > > Yes, that's already in the doc. What I ask is what

Re: [FFmpeg-devel] [PATCHv2][GSoC]audio filter-use cellular automata to generate tones

2020-03-26 Thread Ashutosh Pradhan
On Thu, Mar 26, 2020 at 2:53 PM Nicolas George wrote: > Ashutosh Pradhan (12020-03-26): > > I was trying to random tones using cellular automata (it won't sound good > > if the tones are too random so I used a scale) for the GSoC audio tones > > filter project. > > Yes, that's already in the

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/avpacket: Always treat dst in av_packet_ref as uninitialized

2020-03-26 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-02-12 16:02:21) > av_packet_ref() mostly treated the destination packet dst as uninitialized, > i.e. the destination fields were simply overwritten. But if the source > packet was not reference-counted, dst->buf was treated as if it pointed > to an already

Re: [FFmpeg-devel] [PATCH 1/3 v2] avcodec/encode: restructure the core encoding code

2020-03-26 Thread Anton Khirnov
Quoting James Almer (2020-03-16 22:30:00) > This commit follows the same logic as 061a0c14bb, but for the encode API: The > new public encoding API will no longer be a wrapper around the old deprecated > one, and the internal API used by the encoders now consists of a single > receive_packet()

Re: [FFmpeg-devel] [PATCHv2][GSoC]audio filter-use cellular automata to generate tones

2020-03-26 Thread Nicolas George
Ashutosh Pradhan (12020-03-26): > Use cellular automata and fluidsynth sequencer to generate tones in major > pentatonic scale Can you explain the use cases for this filter? Regards, -- Nicolas George signature.asc Description: PGP signature ___

Re: [FFmpeg-devel] [PATCH 03/21] avformat/mpeg: Remove unnecessary av_packet_unref()

2020-03-26 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-03-22 04:47:38) > Forgotten in 6a67d518. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/mpeg.c | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) Looks ok -- Anton Khirnov ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 01/21] avformat/nsvdec: Use av_packet_move_ref() for packet ownership transfer

2020-03-26 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-03-22 04:47:36) > Also simply return 0 in case a packet has been successfully read. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/nsvdec.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) Looks ok. -- Anton Khirnov

Re: [FFmpeg-devel] [PATCHv2][GSoC]audio filter-use cellular automata to generate tones

2020-03-26 Thread Ashutosh Pradhan
I was trying to random tones using cellular automata (it won't sound good if the tones are too random so I used a scale) for the GSoC audio tones filter project. On Thu, Mar 26, 2020 at 2:41 PM Nicolas George wrote: > Ashutosh Pradhan (12020-03-26): > > Use cellular automata and fluidsynth

Re: [FFmpeg-devel] [PATCHv2][GSoC]audio filter-use cellular automata to generate tones

2020-03-26 Thread Paul B Mahol
On 3/26/20, Nicolas George wrote: > Paul B Mahol (12020-03-26): >> > No insinuation at all, just an honest question. >> We will see... > > This... is an insinuation. > >> Use case is to generate nice listenable music that is computer generated. >> This filter as is just prototype and is not meant

Re: [FFmpeg-devel] [PATCHv2][GSoC]audio filter-use cellular automata to generate tones

2020-03-26 Thread Paul B Mahol
On 3/26/20, Nicolas George wrote: > Paul B Mahol (12020-03-26): >> That is just your biased opinion. > > No, that is not my opinion, that is the position of the project for > years: we don't control external libraries, their output can change from > one version to the next or with forks and

Re: [FFmpeg-devel] [PATCHv2][GSoC]audio filter-use cellular automata to generate tones

2020-03-26 Thread Nicolas George
Paul B Mahol (12020-03-26): > Apparently you are talking about completely different and irrelevant stuff > for this task. Apparently, you did not read my previous mails very carefully, because I already explained. -- Nicolas George ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCHv2][GSoC]audio filter-use cellular automata to generate tones

2020-03-26 Thread Nicolas George
Thilo Borgmann (12020-03-26): > Ok. So if I understand all of this correctly, the overall goal of the > tones project is already redundant to your old proposal (or at least > partially, Paul?). I do not know what the overall goal of the tones project is: I have not seen it discussed on the list.

Re: [FFmpeg-devel] [PATCHv2][GSoC]audio filter-use cellular automata to generate tones

2020-03-26 Thread Thilo Borgmann
Am 26.03.20 um 11:24 schrieb Nicolas George: > Paul B Mahol (12020-03-26): >> Apparently you are talking about completely different and irrelevant stuff >> for this task. > > Apparently, you did not read my previous mails very carefully, because I > already explained. Please let's stop here,

Re: [FFmpeg-devel] [PATCH]configure: Remove all C standard versions from the MSVC command line

2020-03-26 Thread Martin Storsjö
On Thu, 26 Mar 2020, Carl Eugen Hoyos wrote: Hi! Attached patch removes an ugly warning shown for every file when using clang-cl.exe. Please comment, Carl Eugen LGTM // Martin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH]configure: Get the correct ident for clang-cl.exe

2020-03-26 Thread Martin Storsjö
On Thu, 26 Mar 2020, Carl Eugen Hoyos wrote: Hi! Attached patch avoids that ffmpeg claims its compiler was "No input file" when using clang-cl. Please comment, Carl Eugen @@ -4663,7 +4663,11 @@ probe_cc(){ _ld_path='-libpath:' elif $_cc -nologo- 2>&1 | grep -q Microsoft || {

Re: [FFmpeg-devel] [PATCHv2][GSoC]audio filter-use cellular automata to generate tones

2020-03-26 Thread Nicolas George
Paul B Mahol (12020-03-26): > > No insinuation at all, just an honest question. > We will see... This... is an insinuation. > Use case is to generate nice listenable music that is computer generated. > This filter as is just prototype and is not meant to be applied in > current version but only

Re: [FFmpeg-devel] [PATCH v2] ffplay, avcodec, avformat: Don't initialize before av_packet_ref()

2020-03-26 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-03-13 14:28:33) > It already initializes the packet. > > Signed-off-by: Andreas Rheinhardt > --- > Resending because of 3117f47f19d051d47ba29c9b78c2ca525f0fdb45. > > fftools/ffplay.c | 2 +- > libavcodec/qsvdec_h2645.c | 2 +- >

Re: [FFmpeg-devel] [PATCHv2][GSoC]audio filter-use cellular automata to generate tones

2020-03-26 Thread Paul B Mahol
On 3/26/20, Nicolas George wrote: > Paul B Mahol (12020-03-26): >> What kind of insinuation is this? > > No insinuation at all, just an honest question. We will see... > >> This is qualification task for GSoC project, if you have something against >> it, >> ask me directly instead. > > Of

Re: [FFmpeg-devel] [PATCH] lavc/pthread_frame: Update user context in ff_frame_thread_free

2020-03-26 Thread Anton Khirnov
Quoting Linjie Fu (2019-12-27 09:47:35) > Resolution/format changes lead to re-initialization of hardware > accelerations(vaapi/dxva2/..) with new hwaccel_priv_data in > the worker-thread. But hwaccel_priv_data in user context won't > be updated until the resolution changing frame is output. > >

Re: [FFmpeg-devel] [PATCHv2][GSoC]audio filter-use cellular automata to generate tones

2020-03-26 Thread Nicolas George
Paul B Mahol (12020-03-26): > That is just your biased opinion. No, that is not my opinion, that is the position of the project for years: we don't control external libraries, their output can change from one version to the next or with forks and patched versions. Only internal implementation is

Re: [FFmpeg-devel] [PATCHv2][GSoC]audio filter-use cellular automata to generate tones

2020-03-26 Thread Thilo Borgmann
Am 26.03.20 um 10:48 schrieb Paul B Mahol: > On 3/26/20, Nicolas George wrote: >> Ashutosh Pradhan (12020-03-26): >>> I was trying to random tones using cellular automata (it won't sound good >>> if the tones are too random so I used a scale) for the GSoC audio tones >>> filter project. >> >>

[FFmpeg-devel] [PATCH V2] avformat: Add Dynacolor MVC Demuxer

2020-03-26 Thread Tom Needham
Thanks for your feedback. Please see the attached patch with all the style changes addressed which also applies properly. 0001-avformat-Add-Dynacolor-MVC-Demuxer.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCHv2][GSoC]audio filter-use cellular automata to generate tones

2020-03-26 Thread Nicolas George
Thilo Borgmann (12020-03-26): > Let's look at this. There are two things here: > > a) Is it a good enough solution of the qualfification task Paul has > given to Ashutosh? > > b) Is it unsuitable to apply? Well that might be but we need to get > clear about a) for the sake of GSoC. > > Also, a)

Re: [FFmpeg-devel] [PATCHv2][GSoC]audio filter-use cellular automata to generate tones

2020-03-26 Thread Thilo Borgmann
Am 26.03.20 um 11:58 schrieb Nicolas George: > Thilo Borgmann (12020-03-26): >> Let's look at this. There are two things here: >> >> a) Is it a good enough solution of the qualfification task Paul has >> given to Ashutosh? >> >> b) Is it unsuitable to apply? Well that might be but we need to get

Re: [FFmpeg-devel] [PATCH 2/4] lavc/x86/hevc_add_res: Fix overflow in ADD_RES_SSE_8_8

2020-03-26 Thread Anton Khirnov
Quoting Linjie Fu (2020-03-05 08:47:54) > Fix overflow for coeff -32768 in function ADD_RES_SSE_8_8 with > no performance drop. > > ./checkasm --test=hevc_add_res --bench > > Mainline: > - hevc_add_res.add_residual [OK] > hevc_add_res_8x8_8_sse2: 15.5 > > Add overflow test case: > -

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Reduce size of the allocated MOVIentry array

2020-03-26 Thread James Almer
On 3/26/2020 11:22 AM, Anton Khirnov wrote: > Quoting James Almer (2020-03-26 15:18:53) >> On 3/26/2020 11:06 AM, Anton Khirnov wrote: >>> Quoting James Almer (2020-03-25 18:56:44) Increase it in a linear way instead. Helps reduce memory usage, especially on long, non fragmented output.

Re: [FFmpeg-devel] [PATCH 1/3] avformat/matroskadec: Don't discard the upper 32bits of TrackNumber

2020-03-26 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-03-26 01:41:42) > Signed-off-by: Andreas Rheinhardt > --- > This has already been sent in [1]; I'm resending it because it fits > here. > > [1]: https://ffmpeg.org/pipermail/ffmpeg-devel/2019-December/254841.html > > libavformat/matroskadec.c | 4 ++-- > 1 file

Re: [FFmpeg-devel] [PATCH 2/3] avformat/matroskadec: Don't discard valid packets

2020-03-26 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-03-26 01:41:43) > A Block (meaning both a Block in a BlockGroup as well as a SimpleBlock) > must have at least three bytes after the field containing the encoded > TrackNumber. So a if there are <= 3 bytes, the Matroska demuxer would > skip this block, believing it

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Reduce size of the allocated MOVIentry array

2020-03-26 Thread James Almer
On 3/26/2020 11:06 AM, Anton Khirnov wrote: > Quoting James Almer (2020-03-25 18:56:44) >> Increase it in a linear way instead. >> Helps reduce memory usage, especially on long, non fragmented output. >> >> Signed-off-by: James Almer >> --- >> An alternative is using av_fast_realloc(), in a

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Reduce size of the allocated MOVIentry array

2020-03-26 Thread Anton Khirnov
Quoting James Almer (2020-03-26 15:18:53) > On 3/26/2020 11:06 AM, Anton Khirnov wrote: > > Quoting James Almer (2020-03-25 18:56:44) > >> Increase it in a linear way instead. > >> Helps reduce memory usage, especially on long, non fragmented output. > >> > >> Signed-off-by: James Almer > >> ---

Re: [FFmpeg-devel] [PATCH 3/3] avformat/matroskadec: Improve forward compability

2020-03-26 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-03-26 01:41:44) > Matroska is built around the principle that a reader does not need to > understand everything in a file in order to be able to make use of it; > it just needs to ignore the data it doesn't know about. > > Our demuxer typically follows this

Re: [FFmpeg-devel] [PATCH] avcodec/vp9: use a buffer pool to allocate VP9Frame extradata

2020-03-26 Thread Anton Khirnov
Quoting James Almer (2020-03-06 01:09:39) > Signed-off-by: James Almer > --- > libavcodec/vp9.c| 13 - > libavcodec/vp9dec.h | 4 > 2 files changed, 16 insertions(+), 1 deletion(-) > Looks reasonable. Any measurable performance difference? -- Anton Khirnov

Re: [FFmpeg-devel] [PATCH] doc/developer.texi: Add variadic macros to allowed C language features

2020-03-26 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-03-23 03:38:38) > They are used in several places like CBS. > > Signed-off-by: Andreas Rheinhardt > --- > doc/developer.texi | 3 +++ > 1 file changed, 3 insertions(+) Looks ok -- Anton Khirnov ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/vp9: use a buffer pool to allocate VP9Frame extradata

2020-03-26 Thread James Almer
On 3/26/2020 11:30 AM, Anton Khirnov wrote: > Quoting James Almer (2020-03-06 01:09:39) >> Signed-off-by: James Almer >> --- >> libavcodec/vp9.c| 13 - >> libavcodec/vp9dec.h | 4 >> 2 files changed, 16 insertions(+), 1 deletion(-) >> > > Looks reasonable. Any measurable

Re: [FFmpeg-devel] [PATCH 1/4] lavc/x86/hevc_add_res: Fix overflow in ADD_RES_MMX_4_8

2020-03-26 Thread Anton Khirnov
Quoting Linjie Fu (2020-03-05 08:47:37) > Fix overflow for coeff -32768 in function ADD_RES_MMX_4_8 with no > performance drop. > > ./checkasm --test=hevc_add_res --bench > > Mainline: > - hevc_add_res.add_residual [OK] > hevc_add_res_4x4_8_mmxext: 15.5 > > Add overflow test case: > -

[FFmpeg-devel] [PATCH v1 4/4] avformat/hlsenc: use av_asprintf()

2020-03-26 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/hlsenc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index d7b9c0e20a..694dab42dd 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -2950,13 +2950,11

[FFmpeg-devel] [PATCH v1 1/4] avformat/hlsenc: remove the first slash of the relative path line in the master m3u8 file

2020-03-26 Thread lance . lmwang
From: Limin Wang Please testing with the following command: ./ffmpeg -y -i input.mkv \ -b:v:0 5250k -c:v h264 -pix_fmt yuv420p -profile:v main -level 4.1 \ -b:a:0 256k \ -c:a mp2 -ar 48000 -ac 2 -map 0:v -map 0:a:0\ -f hls -var_stream_map "v:0,a:0" \ -master_pl_name master.m3u8 -t 300

[FFmpeg-devel] [PATCH v1 3/4] avformat: add subtitle support in master playlist m3u8

2020-03-26 Thread lance . lmwang
From: Limin Wang Test with the following command for the webvtt subtitle: $ ./ffmpeg -y -i input_with_subtitle.mkv \ -b:v:0 5250k -c:v h264 -pix_fmt yuv420p -profile:v main -level 4.1 \ -b:a:0 256k \ -c:s webvtt -c:a mp2 -ar 48000 -ac 2 -map 0:v -map 0:a:0 -map 0:s:0 \ -f hls -var_stream_map

[FFmpeg-devel] [PATCH v1 2/4] avformat/hlsplaylist: simplify code for checking whether the string is empty

2020-03-26 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/hlsplaylist.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/hlsplaylist.c b/libavformat/hlsplaylist.c index 9cbd02353f..56244496c0 100644 --- a/libavformat/hlsplaylist.c +++

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Reduce size of the allocated MOVIentry array

2020-03-26 Thread Anton Khirnov
Quoting James Almer (2020-03-25 18:56:44) > Increase it in a linear way instead. > Helps reduce memory usage, especially on long, non fragmented output. > > Signed-off-by: James Almer > --- > An alternative is using av_fast_realloc(), in a similar fashion as > ff_add_index_entry(), which will

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: support XAVC long gop

2020-03-26 Thread Robert Krüger
Hi Baptiste, On Tue, May 14, 2019 at 10:38 AM Thomas Mundt wrote: > Hi Baptiste, > > Am Di., 14. Mai 2019 um 00:33 Uhr schrieb Baptiste Coudurier < > baptiste.coudur...@gmail.com>: > > > --- > > libavformat/Makefile | 2 +- > > libavformat/avc.c| 186 +