[FFmpeg-devel] [PATCH] avcodec/encode: restructure the core encoding code

2020-05-26 Thread James Almer
This commit follows the same logic as 061a0c14bb, but for the encode API: The new public encoding API will no longer be a wrapper around the old deprecated one, and the internal API used by the encoders now consists of a single receive_packet() callback that pulls frames as required. amf encoders

Re: [FFmpeg-devel] [PATCH 1/2 v4] avcodec/encode: restructure the core encoding code

2020-05-26 Thread Michael Niedermayer
On Mon, May 25, 2020 at 01:59:16PM -0300, James Almer wrote: > This commit follows the same logic as 061a0c14bb, but for the encode API: The > new public encoding API will no longer be a wrapper around the old deprecated > one, and the internal API used by the encoders now consists of a single >

Re: [FFmpeg-devel] [PATCH v6 2/9] libavcodec/qsv: enabling d3d11va support, added mfxhdlpair

2020-05-26 Thread Max Dmitrichenko
On Tue, May 19, 2020 at 10:11 AM Zhong Li wrote: > 于2020年5月19日周二 上午4:31写道: > > > > From: Artem Galin > > > > Adding DX11 relevant device type checks and adjusting callbacks with > > proper MediaSDK pair type support. > > > > Extending structure for proper MediaSDK pair type support. > > > >

[FFmpeg-devel] [PATCH] lavc/h264_cavlc: use inline function get_bits API

2020-05-26 Thread Josh de Kock
To prepare for using the cached bitstream reader, which only defines the inline functions rather than the macros, with CAVLC decoding. Signed-off-by: Josh de Kock --- libavcodec/h264_cavlc.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH 3/3] pngdec: add ability to check chunk CRC

2020-05-26 Thread Lynne
Pushed the patchset, thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] Best way for sharing libavcodec jni stuff

2020-05-26 Thread Dmitry A
Hello. Currently I working on android project where I need to use ffmpeg for working with camera and microphone. android_camera device works fine and video preview works. But building of openal is issue and I think some time about creating something like android_microphone via jni like media_codec

Re: [FFmpeg-devel] [PATCH 2/4] avformat/concatdec: Avoid duplicating buffer when adding side-data

2020-05-26 Thread Nicolas George
Andreas Rheinhardt (12020-05-24): > Signed-off-by: Andreas Rheinhardt > --- > The resulting side-data in this and the next two patches won't be padded > anymore. But the documentation doesn't require it and > av_packet_unpack_dictionary() doesn't rely on this anyway. > > libavformat/concatdec.c

[FFmpeg-devel] [PATCH 3/3] libavcodec: Enable runtime detection for MIPS MMI & MSA

2020-05-26 Thread Jiaxun Yang
Apply optimized functions according to cpuflags. MSA is always put after MMI as it's usually faster than MMI. Signed-off-by: Jiaxun Yang --- libavcodec/mips/blockdsp_init_mips.c| 22 +- libavcodec/mips/cabac.h | 2 +-

[FFmpeg-devel] [PATCH 0/3] MIPS MSA & MMI Runtime detection support

2020-05-26 Thread Jiaxun Yang
This series adds MIPS MSA & MMI runtime detection support. It have been tested on Loongson-3A4000 (with both MSA & MMI), Loongson-3B1500 (MMI only), MT7620A (no SIMD ASE). There is a MMI checkasm test failure but looks irrelevant with my changes, I have informed MIPS maintainer Shiyou Yin

[FFmpeg-devel] [PATCH 2/3] libavutil: Detect MMI and MSA flags for MIPS

2020-05-26 Thread Jiaxun Yang
Add MMI & MSA runtime detection for MIPS. Currently it's based on cpuinfo but in future we should consider to use CPUCFG instruction. Signed-off-by: Jiaxun Yang --- libavutil/cpu.c | 10 + libavutil/cpu.h | 3 ++ libavutil/cpu_internal.h | 2 +

[FFmpeg-devel] [PATCH 1/3] ffbuild: Refine MIPS handling

2020-05-26 Thread Jiaxun Yang
To enable runtime detection for MIPS, we need to refine ffbuild part to support buildding these feature together. Firstly, we fixed configure, let it probe native ability of toolchain to decide wether a feature can to be enabled, also clearly marked the conflictions between loongson2 & loongson3

Re: [FFmpeg-devel] [PATCH v5 0/4] adpcm_ima_ssi encoder + kvag muxer

2020-05-26 Thread Zane van Iperen
On Tue, 19 May 2020 11:07:09 + "Zane van Iperen" wrote: > > On Sat, 16 May 2020 11:53:27 + > "Zane van Iperen" wrote: > > > > > Add support for encoding adpcm_ima_ssi and muxing to kvag. > > Ping again. Zane ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH] avformat: fix apm makefile dependency

2020-05-26 Thread Zane van Iperen
Uses ff_get_wav_header() in riffdec.c Signed-off-by: Zane van Iperen --- libavformat/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/Makefile b/libavformat/Makefile index fa325d2320..efe82f9f08 100644 --- a/libavformat/Makefile +++ b/libavformat/Makefile

Re: [FFmpeg-devel] [PATCH] avformat: fix apm makefile dependency

2020-05-26 Thread Paul B Mahol
lgtm On 5/26/20, Zane van Iperen wrote: > Uses ff_get_wav_header() in riffdec.c > > Signed-off-by: Zane van Iperen > --- > libavformat/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/Makefile b/libavformat/Makefile > index fa325d2320..efe82f9f08

[FFmpeg-devel] [PATCH 2/2] Set stream_id correctly based on KLV profile selected.

2020-05-26 Thread Brad Hards
Previously we always set STREAM_TYPE_PRIVATE_DATA, and that remains the default value. --- libavformat/mpegtsenc.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index bf1a7ee13f..a7703ab120 100644 --- a/libavformat/mpegtsenc.c +++

[FFmpeg-devel] [PATCH 0/2] Allow SYNC / ASYNC metadata streams (MISB ST1402)

2020-05-26 Thread Brad Hards
MISB ST1402 (available at https://gwg.nga.mil/misb/docs/standards/ST1402.2.pdf) has two kinds of KLV metadata - synchronous and asynchronous. These patches provide initial support for that. Synchronous is stream_type = 0x15 for "Metadata carried in PES packets" with stream_id = 0xFC for "metadata

[FFmpeg-devel] [PATCH 1/2] Add constants for KLV pseudo-profile.

2020-05-26 Thread Brad Hards
There are two different ways KLV is used in MISB specs - sync and async. The corresponding text (in ST1401) says: ISO/IEC 13818-1 Table-34 defines a stream_type = 0x15 for “Metadata carried in PES packets,” and Table 2-22 defines a stream_id = 0xFC for “metadata stream.” and In ISO/IEC

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/adpcmenc: Add FF_CODEC_CAP_INIT_CLEANUP

2020-05-26 Thread lance . lmwang
On Mon, May 18, 2020 at 07:11:07PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > then we can remove adpcm_encode_close() in adpcm_encode_init() if have failed. > so the goto error lable wlll be unnecessary and can be removed later. > > Signed-off-by: Limin Wang > --- >

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mpegtsenc: simplify code by using OFFSET() and ENC macros

2020-05-26 Thread lance . lmwang
On Wed, May 20, 2020 at 10:31:13PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavformat/mpegtsenc.c | 92 > + > 1 file changed, 47 insertions(+), 45 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH] lavc/h264_cavlc: use inline function get_bits API

2020-05-26 Thread Kieran Kunhya
On Tue, 26 May 2020 at 15:14, Josh de Kock wrote: > To prepare for using the cached bitstream reader, which only defines the > inline functions rather than the macros, with CAVLC decoding. > > Signed-off-by: Josh de Kock IMO you should provide cached reader benchmarks on real world CAVLC

[FFmpeg-devel] [PATCH v2 3/4] lavc/libx264: misc style fixes

2020-05-26 Thread Jun Zhao
From: Jun Zhao commit 4ed3a01d717 missed coding style fix. Signed-off-by: Jun Zhao --- libavcodec/libx264.c | 76 ++-- 1 file changed, 38 insertions(+), 38 deletions(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index

[FFmpeg-devel] [PATCH v2 2/4] lavf/utils: fix start_time/duration dump if it is AV_NOPTS_VALUE

2020-05-26 Thread Jun Zhao
From: Jun Zhao e,g: the command: ffprobe -show_format -i fate-suite/aac/foo.aac -loglevel 99 will dump the trace message as follow when start_time is AV_NOPTS_VALUE [aac @ 0x55bf8e1f3dc0] stream 0: start_time: -326791809695.818 duration: 2.174 [aac @ 0x55bf8e1f3dc0] format: start_time:

Re: [FFmpeg-devel] [PATCH 2/2] mfenc: Avoid including codecapi.h, fix building in UWP mode with clang

2020-05-26 Thread Martin Storsjö
On Mon, 25 May 2020, Martin Storsjö wrote: Including codecapi.h and uuids.h in UWP mode doesn't define all defines properly, ending up with constructs that MSVC silently tolerates, but that clang errors out on, like this: DEFINE_GUIDEX(CODECAPI_AVEncCommonFormatConstraint); Just avoid

[FFmpeg-devel] [PATCH] avformat/fifo: add timeshift option to delay output

2020-05-26 Thread Marton Balint
Signed-off-by: Marton Balint --- doc/muxers.texi | 5 libavformat/fifo.c| 59 ++- libavformat/version.h | 2 +- 3 files changed, 64 insertions(+), 2 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index c598abbe66..d6f9de3702

[FFmpeg-devel] [PATCH] compat/cuda/ptx2c: remove shell loop; fix BSD sed compat

2020-05-26 Thread rcombs
This improves build times dramatically, and fixes building on macOS --- compat/cuda/ptx2c.sh | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/compat/cuda/ptx2c.sh b/compat/cuda/ptx2c.sh index 0750e7a3b7..c41875a2d4 100755 --- a/compat/cuda/ptx2c.sh +++

Re: [FFmpeg-devel] [PATCH] [libavformat] Avoid integer overflow on start_time with skip_samples.

2020-05-26 Thread Dale Curtis
This patch can be abandoned in favor of the other one which uses av_sat_add64(). - dale On Thu, Apr 30, 2020 at 3:20 PM Dale Curtis wrote: > I've sent a follow up patch set implementing saturating operations if > that's something folks are interested in. > > - dale > > On Thu, Apr 30, 2020 at

Re: [FFmpeg-devel] [PATCH 2/2] Use gcc/clang builtins for av_sat_(add|sub)_64_c if available.

2020-05-26 Thread Dale Curtis
On Fri, May 22, 2020 at 1:34 PM Michael Niedermayer wrote: > > does this produce faster / better code ? > that is do compilers actually fail to optimize this from plain > clean C code ? > Here's the difference: clang trunk: https://godbolt.org/z/6SHmEo gcc trunk: https://godbolt.org/z/iKb9jZ I

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: use get_packet_size in mpegts_resync for determining raw_packet_size

2020-05-26 Thread Marton Balint
On Wed, 20 May 2020, Marton Balint wrote: The old resync logic had some bugs, for example the packet size could stuck into 192 bytes, because pos47_full was not updated for every packet, and for unseekable inputs the resync logic simply skipped some 0x47 sync bytes, therefore the calculated

Re: [FFmpeg-devel] [PATCH] Don't adjust start time for MP3 files; packets are not adjusted.

2020-05-26 Thread Dale Curtis
On Wed, May 20, 2020 at 5:22 AM Anton Khirnov wrote: > > Looks reasonable, will push. > Thanks! I don't see this in the commit log. Did it end up getting pushed? - dale ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: add new abort_on flag which aborts if there is a stream which received no packets

2020-05-26 Thread Marton Balint
On Fri, 22 May 2020, Marton Balint wrote: On Sat, 16 May 2020, Marton Balint wrote: Signed-off-by: Marton Balint --- doc/ffmpeg.texi | 2 ++ fftools/ffmpeg.c | 4 fftools/ffmpeg.h | 3 ++- fftools/ffmpeg_opt.c | 5 +++-- 4 files changed, 11 insertions(+), 3 deletions(-)

Re: [FFmpeg-devel] [PATCH] lavc/h264_cavlc: use inline function get_bits API

2020-05-26 Thread Michael Niedermayer
On Tue, May 26, 2020 at 03:13:51PM +0100, Josh de Kock wrote: > To prepare for using the cached bitstream reader, which only defines the > inline functions rather than the macros, with CAVLC decoding. > > Signed-off-by: Josh de Kock > --- > libavcodec/h264_cavlc.c | 13 +++-- > 1 file

[FFmpeg-devel] [PATCH v2 1/4] lavc/aac_ac3_parser: improve the raw AAC file bit rate calculation

2020-05-26 Thread Jun Zhao
From: Jun Zhao Now we just use one ADTS raw frame to calculate the bit rate, it's lead to a larger error when get the duration from bit rate, the improvement cumulate Nth ADTS frames to get the average bit rate. e,g used the command get the duration like: ffprobe -show_entries format=duration

[FFmpeg-devel] [PATCH v2 4/4] lavf/mpegtsenc: misc style fixes

2020-05-26 Thread Jun Zhao
From: Jun Zhao commit 32aeba12755 missed coding style fix. Signed-off-by: Jun Zhao --- libavformat/mpegtsenc.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index bf1a7ee..de9819b 100644 ---

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: use get_packet_size in mpegts_resync for determining raw_packet_size

2020-05-26 Thread lance . lmwang
On Tue, May 26, 2020 at 09:52:45PM +0200, Marton Balint wrote: > > > On Wed, 20 May 2020, Marton Balint wrote: > > > The old resync logic had some bugs, for example the packet size could stuck > > into 192 bytes, because pos47_full was not updated for every packet, and for > > unseekable inputs

[FFmpeg-devel] [PATCH] avcodec/libaomenc: remove the experimental flag when using libaom 2.0.0 or newer

2020-05-26 Thread James Almer
Signed-off-by: James Almer --- Alternatively, we could remove support for libaom 1.0.0, since it's pretty much unusable. But unfortunately both current Debian Stable and latest Ubuntu LTS ship it, so i'm not sure if it would be wise. Any opinions? libavcodec/libaomenc.c | 5 - 1 file

Re: [FFmpeg-devel] [PATCH] avformat/OggPCM: Add partial support for muxing and playing

2020-05-26 Thread Andreas Rheinhardt
A G: > Sorry, I realize I made a mistake in the patch name. Should it be > "avformat: Add partial support for muxing and playing" or "avformat/ogg: > Add partial support for muxing and playing"? > "avformat/ogg: Add partial support for muxing and demuxing" would be better. But actually you should

[FFmpeg-devel] [PATCH v2 2/3] avcodec: Add FF_CODEC_CAP_INIT_CLEANUP

2020-05-26 Thread lance . lmwang
From: Limin Wang then ff_mpv_encode_end() will be unnecessary in ff_mpv_encode_init() if it's failed. The FF_CODEC_CAP_INIT_CLEANUP flag is need for single thread, For multithread, it'll be cleanup still by AV_CODEC_CAP_FRAME_THREADS flag if have. Signed-off-by: Limin Wang ---

[FFmpeg-devel] [PATCH] doc: add dia_size option documentation

2020-05-26 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- doc/codecs.texi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/doc/codecs.texi b/doc/codecs.texi index ece8d50edd..fd98db654b 100644 --- a/doc/codecs.texi +++ b/doc/codecs.texi @@ -646,6 +646,24 @@ noise preserving sum of

[FFmpeg-devel] [PATCH v3 3/3] avcodec/h264dec: Add FF_CODEC_CAP_INIT_CLEANUP

2020-05-26 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/h264dec.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c index 47d7cbf..e463fde 100644 --- a/libavcodec/h264dec.c +++ b/libavcodec/h264dec.c @@ -228,7 +228,6 @@ int

[FFmpeg-devel] [PATCH] avformat/OggPCM: Add partial support for muxing and playing

2020-05-26 Thread A G
From 16e0b79bcdc029b7ab34dfbf80b50868743a8e5e Mon Sep 17 00:00:00 2001 From: oreo639 <31916379+oreo...@users.noreply.github.com> Date: Sun, 24 May 2020 22:28:51 -0700 Subject: [PATCH] avformat/OggPCM: Add partial support This adds partial support for OggPCM muxing and playing. Heavily based on

Re: [FFmpeg-devel] [PATCH] avformat/OggPCM: Add partial support for muxing and playing

2020-05-26 Thread Andreas Rheinhardt
A G: > From 16e0b79bcdc029b7ab34dfbf80b50868743a8e5e Mon Sep 17 00:00:00 2001 > From: oreo639 <31916379+oreo...@users.noreply.github.com> > Date: Sun, 24 May 2020 22:28:51 -0700 > Subject: [PATCH] avformat/OggPCM: Add partial support > > This adds partial support for OggPCM muxing and playing. >

[FFmpeg-devel] [PATCH v2 1/3] avcodec/adpcmenc: Add FF_CODEC_CAP_INIT_CLEANUP

2020-05-26 Thread lance . lmwang
From: Limin Wang then we can remove adpcm_encode_close() in adpcm_encode_init() if have failed. so the goto error lable will be unnecessary and can be removed later. Signed-off-by: Limin Wang --- libavcodec/adpcmenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[FFmpeg-devel] [PATCH v2 3/3] avcodec/h264dec: Add FF_CODEC_CAP_INIT_CLEANUP

2020-05-26 Thread lance . lmwang
From: Limin Wang then ff_h264_free_tables() and h264_decode_end() can be removed in h264_decode_init() if it's failed. The FF_CODEC_CAP_INIT_CLEANUP flag is need for single thread, For multithread, it'll be cleanup still by AV_CODEC_CAP_FRAME_THREADS flag if have. Signed-off-by: Limin Wang

Re: [FFmpeg-devel] [PATCH 2/4] avformat/concatdec: Avoid duplicating buffer when adding side-data

2020-05-26 Thread Andreas Rheinhardt
Nicolas George: > Andreas Rheinhardt (12020-05-24): >> Signed-off-by: Andreas Rheinhardt >> --- >> The resulting side-data in this and the next two patches won't be padded >> anymore. But the documentation doesn't require it and >> av_packet_unpack_dictionary() doesn't rely on this anyway. >> >>

Re: [FFmpeg-devel] [PATCH] avformat/OggPCM: Add partial support for muxing and playing

2020-05-26 Thread A G
Sorry, I realize I made a mistake in the patch name. Should it be "avformat: Add partial support for muxing and playing" or "avformat/ogg: Add partial support for muxing and playing"? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org