Re: [FFmpeg-devel] [PATCH] avformat/utils: Find a fallback probe decoder that will also match a forced decoder's codec.

2020-06-04 Thread Michael Niedermayer
On Wed, Jun 03, 2020 at 07:15:28AM -0400, Samuel Foss wrote: > Prevent codecpar->codec_id from getting out of sync with the codec > instantiated for probing. > > Signed-off-by: Samuel Foss > --- > libavformat/utils.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) will apply thx

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/bitpacked: ,

2020-06-04 Thread Michael Niedermayer
On Thu, Jun 04, 2020 at 03:11:12AM +0200, James Darnley wrote: > On 2020-06-04 01:19, Michael Niedermayer wrote: > > Fixes: array end overread > > Fixes: > > 22395/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BITPACKED_fuzzer-5760940300828672 > > > > Found-by: continuous fuzzing process >

[FFmpeg-devel] [PATCH 2/3] lavf/hls: Add missed side data/disposition

2020-06-04 Thread Jun Zhao
From: vacingfang hls demuxer get the strem info form sub-stream, but missed sida data/disposition part, e,g, missed the DOVI sida data when the stream is Dolby Vision streams. Signed-off-by: vacingfang --- libavformat/hls.c | 14 ++ 1 file changed, 14 insertions(+) diff --git

[FFmpeg-devel] [PATCH 3/3] lavf/dashdec: Add missed side data/disposition

2020-06-04 Thread Jun Zhao
From: Jun Zhao dash demuxer get the strem info form sub-stream, but missed sida data/disposition part, e,g, missed the DOVI sida data when the stream is Dolby Vision streams Signed-off-by: Jun Zhao --- libavformat/dashdec.c | 14 ++ 1 file changed, 14 insertions(+) diff --git

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: maxBitrate is honored in CQ mode if set by user

2020-06-04 Thread Timo Rothenpieler
applied, thanks ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 1/3] fftools/ffmpeg: cosmetics

2020-06-04 Thread Jun Zhao
From: Jun Zhao Signed-off-by: Jun Zhao --- fftools/ffmpeg.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 2e9448e..93a86b9 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -3118,8 +3118,7 @@ static int

[FFmpeg-devel] [PATCH] libavcodec/png_parser.c: fix a use_of_uninitialized_value in target_dec_fuzzer.

2020-06-04 Thread Thierry Foucu
target_dec_fuzzer is checking for the avpkt.data pointer but if the png parser cannot combine the frame, the poutbuf is not set and so, the avpkt.data is not initialized. --- libavcodec/png_parser.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/png_parser.c

Re: [FFmpeg-devel] [PATCH] libavcodec/png_parser.c: fix a use_of_uninitialized_value in target_dec_fuzzer.

2020-06-04 Thread Thierry Foucu
On Thu, Jun 4, 2020 at 11:52 AM James Almer wrote: > On 6/4/2020 3:40 PM, Thierry Foucu wrote: > > target_dec_fuzzer is checking for the avpkt.data pointer but if the > > png parser cannot combine the frame, the poutbuf is not set and so, the > > avpkt.data is not initialized. > > --- > >

Re: [FFmpeg-devel] [PATCH] libavcodec/png_parser.c: fix a use_of_uninitialized_value in target_dec_fuzzer.

2020-06-04 Thread James Almer
On 6/4/2020 3:40 PM, Thierry Foucu wrote: > target_dec_fuzzer is checking for the avpkt.data pointer but if the > png parser cannot combine the frame, the poutbuf is not set and so, the > avpkt.data is not initialized. > --- > libavcodec/png_parser.c | 5 - > 1 file changed, 4 insertions(+),

[FFmpeg-devel] [PATCH 1/3] libavcodec/png_parser.c: fix a use_of_uninitialized_value in target_dec_fuzzer.

2020-06-04 Thread Thierry Foucu
the target_dec_fuzzer is checking for the avpkt.data pointer but if the png parser cannot combine the frame, the poutbuf is not set. --- libavcodec/png_parser.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/png_parser.c b/libavcodec/png_parser.c index 74f2964118..9ec8551a1b

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/wavpack: Do not allow the sample format to change between channels

2020-06-04 Thread David Bryant
On 6/3/20 4:19 PM, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 22692/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVPACK_fuzzer-5678686190960640 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by:

[FFmpeg-devel] [PATCH 2/3] libavcodec/mlp_parser.c: fix a use_of_uninitialized_value in target_dec_fuzzer.

2020-06-04 Thread Thierry Foucu
the target_dec_fuzzer is checking for the avpkt.data pointer but if the mlp parser cannot combine the frame, the poutbuf is not set. --- libavcodec/mlp_parser.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/mlp_parser.c b/libavcodec/mlp_parser.c index 5d2ddc5a70..e7162f4aa8

Re: [FFmpeg-devel] [RFC PATCH 1/2] libavcodec/jpeg2000_parser: Add jpeg2000 parser

2020-06-04 Thread Michael Niedermayer
On Thu, Jun 04, 2020 at 01:24:42PM +0530, gautamr...@gmail.com wrote: > From: Gautam Ramakrishnan > > I have attempted to write a JPEG2000 Parser. Have tested > by generating a file containing 14 frames, as mentioned > by Micheal. Have also tried testing with various packet > sizes by setting

[FFmpeg-devel] [PATCH 3/3] libavcodec/bmp_parser.c: fix a use_of_uninitialized_value in target_dec_fuzzer.

2020-06-04 Thread Thierry Foucu
the target_dec_fuzzer is checking for the avpkt.data pointer but if the bmp parser cannot combine the frame, the poutbuf is not set. --- libavcodec/bmp_parser.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/bmp_parser.c b/libavcodec/bmp_parser.c index cd65f02a2e..700bf27af1

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/wavpack: Do not allow the sample format to change between channels

2020-06-04 Thread Michael Niedermayer
On Thu, Jun 04, 2020 at 11:13:04AM -0700, David Bryant wrote: > On 6/3/20 4:19 PM, Michael Niedermayer wrote: > > Fixes: out of array access > > Fixes: > > 22692/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVPACK_fuzzer-5678686190960640 > > > > Found-by: continuous fuzzing process > >

Re: [FFmpeg-devel] [PATCH] avcodec/mv30: Do not allow MVs outside the allocated image

2020-06-04 Thread Michael Niedermayer
On Wed, May 20, 2020 at 10:51:01PM +0200, Michael Niedermayer wrote: > Fixes: out of array read > Fixes: > 21804/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MV30_fuzzer-5673678898724864 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/mv30: Fix multiple integer overflows in idct_1d()

2020-06-04 Thread Michael Niedermayer
On Mon, May 25, 2020 at 12:38:41AM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: -4869937 * 473 cannot be represented in type > 'int' > Fixes: > 21934/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MV30_fuzzer-5667289925156864 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] avcodec/hq_hqa: Check info size

2020-06-04 Thread Michael Niedermayer
On Sat, May 30, 2020 at 06:31:24PM +0200, Michael Niedermayer wrote: > On Sat, May 30, 2020 at 02:09:42AM +0200, Hendrik Leppkes wrote: > > On Sat, May 30, 2020 at 2:01 AM Michael Niedermayer > > wrote: > > > > > > Fixes: assertion failure > > > Fixes: > > >

Re: [FFmpeg-devel] [RFC PATCH 1/2] libavcodec/jpeg2000_parser: Add jpeg2000 parser

2020-06-04 Thread Gautam Ramakrishnan
On Fri, Jun 5, 2020 at 3:21 AM Michael Niedermayer wrote: > > On Thu, Jun 04, 2020 at 01:24:42PM +0530, gautamr...@gmail.com wrote: > > From: Gautam Ramakrishnan > > > > I have attempted to write a JPEG2000 Parser. Have tested > > by generating a file containing 14 frames, as mentioned > > by

Re: [FFmpeg-devel] [PATCH] avformat/dashenc: use AVCodecContext timebase when computing missing bitrate

2020-06-04 Thread Przemysław Sobala
On Thu, Jun 4, 2020 at 11:24 AM Jeyapal, Karthick wrote: > > On 6/4/20 1:29 PM, Przemysław Sobala wrote: > > On Tue, Jun 2, 2020 at 10:19 AM Przemysław Sobala < > > przemyslaw.sob...@gmail.com> wrote: > > > >> On Mon, Jun 1, 2020 at 3:30 PM Jeyapal, Karthick > >> wrote: > >> > >>> > >>> On

Re: [FFmpeg-devel] [PATCH v2 1/4] ffbuild: Refine MIPS handling

2020-06-04 Thread Shiyou Yin
For your convenience, I add the previous comments into this patch. >-Original Message- >From: ffmpeg-devel-boun...@ffmpeg.org [mailto:ffmpeg-devel-boun...@ffmpeg.org] >On Behalf Of >Jiaxun Yang >Sent: Tuesday, June 2, 2020 10:15 PM >To: ffmpeg-devel@ffmpeg.org >Cc: yinshi...@loongson.cn;

[FFmpeg-devel] [PATCH] pthread_frame: change the way delay is set

2020-06-04 Thread Anton Khirnov
It is a constant known at codec init, so set it in ff_frame_thread_init(). Also, only set it for video, since the meaning of this field is not well-defined for audio with frame threading. Fixes availability of delay in callbacks invoked from the per-thread contexts after

Re: [FFmpeg-devel] [PATCH 11/17] avflter: switch to child_class_iterate()

2020-06-04 Thread Moritz Barsnick
On Thu, May 28, 2020 at 22:15:53 +0200, Anton Khirnov wrote: > Subject: [PATCH 11/17] avflter: switch to child_class_iterate() Nit: avfilter Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavf/tee: pass options to protocol.

2020-06-04 Thread Nicolas George
Marvin Scholz (12020-06-03): > Oh whoops I completely overlooked that and got confused by the command line > on the > ticket itself. > That indeed works fine now with your patch, thanks a lot for the fix, as > this > greatly simplifies sourcing different icecast mountpoints at once for > testing.

Re: [FFmpeg-devel] [PATCH] avformat/dashenc: use AVCodecContext timebase when computing missing bitrate

2020-06-04 Thread Przemysław Sobala
On Tue, Jun 2, 2020 at 10:19 AM Przemysław Sobala < przemyslaw.sob...@gmail.com> wrote: > On Mon, Jun 1, 2020 at 3:30 PM Jeyapal, Karthick > wrote: > >> >> On 6/1/20 5:24 PM, Przemysław Sobala wrote: >> > On Mon, Jun 1, 2020 at 10:06 AM Anton Khirnov >> wrote: >> > >> >> Quoting Przemysław

[FFmpeg-devel] [RFC PATCH 2/2] fate/video.mak: fate test for jpeg2000 parser

2020-06-04 Thread gautamramk
From: Gautam Ramakrishnan This test generates a rawvideo video of jpeg2000 frames using lavfi testsrc2 as input. The reference file as 25 frames. --- tests/fate-run.sh | 4 +++- tests/fate/video.mak | 3 +++ tests/ref/fate/jpeg2000-parser | 32

[FFmpeg-devel] [RFC PATCH 1/2] libavcodec/jpeg2000_parser: Add jpeg2000 parser

2020-06-04 Thread gautamramk
From: Gautam Ramakrishnan I have attempted to write a JPEG2000 Parser. Have tested by generating a file containing 14 frames, as mentioned by Micheal. Have also tried testing with various packet sizes by setting -frame_size option. --- libavcodec/Makefile | 1 +

[FFmpeg-devel] [PATCH] avcodec/nvenc: maxBitrate is honored in CQ mode if set by user

2020-06-04 Thread Roman Arzumanyan
This fixes bug in my previous patch which was discarding maxBitrate. CQ mode shall honor maxBitrate value if it's set by user via CLI. How to check: ./ffmpeg.exe \ -i big_buck_bunny_1080p_h264.mov \ -c:v h264_nvenc \ -cq 10 \ -maxrate 10M \ -y output_cq10_10M.mp4 -- BR, Roman

Re: [FFmpeg-devel] [PATCH] avcodec: remove FLAG2_FAST mode

2020-06-04 Thread Kieran Kunhya
On Thu, 4 Jun 2020 at 00:05, Michael Niedermayer wrote: > On Wed, Jun 03, 2020 at 06:23:27PM +0100, Kieran Kunhya wrote: > > $subj > > > fftools/ffplay.c |5 > > libavcodec/avcodec.h |4 > > libavcodec/h264_slice.c|6 > > libavcodec/mpeg12dec.c | 273 >

Re: [FFmpeg-devel] [PATCH] avformat/dashenc: use AVCodecContext timebase when computing missing bitrate

2020-06-04 Thread Jeyapal, Karthick
On 6/4/20 1:29 PM, Przemysław Sobala wrote: > On Tue, Jun 2, 2020 at 10:19 AM Przemysław Sobala < > przemyslaw.sob...@gmail.com> wrote: > >> On Mon, Jun 1, 2020 at 3:30 PM Jeyapal, Karthick >> wrote: >> >>> >>> On 6/1/20 5:24 PM, Przemysław Sobala wrote: On Mon, Jun 1, 2020 at 10:06 AM