Re: [FFmpeg-devel] Project orientation

2020-07-05 Thread Michael Niedermayer
On Sun, Jul 05, 2020 at 08:42:13PM +0200, Steinar H. Gunderson wrote: > On Sun, Jul 05, 2020 at 08:13:25PM +0200, Manolis Stamatogiannakis wrote: > > As a fresh contributor, setting up git send-email was a hassle, but > > not an insurmountable obstacle. > > Speaking only for myself, having sent a

Re: [FFmpeg-devel] Project orientation

2020-07-05 Thread Kieran Kunhya
On Sun, Jul 5, 2020 at 6:01 PM Kieran Kunhya wrote: > > Going back to the original point in hand. > Many patches aren't getting reviewed and pushed any more. > > In part this is because in 2020 whether we like it or not mailing > lists are not the way to do Git based development. > The kernel is

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/jpeg2000dec: Enhance pix fmt selection

2020-07-05 Thread Michael Niedermayer
On Sun, Jul 05, 2020 at 12:33:08AM +0530, gautamr...@gmail.com wrote: > From: Gautam Ramakrishnan > > This patch assigns default pix format values when > a match does not take place. > --- > libavcodec/jpeg2000dec.c | 12 > 1 file changed, 12 insertions(+) will apply thx [...]

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/jpeg2000dec.c: Enable image offsets

2020-07-05 Thread Michael Niedermayer
On Sun, Jul 05, 2020 at 12:33:09AM +0530, gautamr...@gmail.com wrote: > From: Gautam Ramakrishnan > > This patch enables support for image offsets. > --- > libavcodec/jpeg2000dec.c | 4 > 1 file changed, 4 deletions(-) will apply thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] Project orientation

2020-07-05 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: Monday, July 6, 2020 1:18 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] Project orientation > > On Sun, Jul 05, 2020 at 09:56:02PM +, Soft

Re: [FFmpeg-devel] Project orientation

2020-07-05 Thread Andriy Gelman
On Sun, 05. Jul 23:42, Soft Works wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Michael Niedermayer > > Sent: Monday, July 6, 2020 1:18 AM > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] Project

Re: [FFmpeg-devel] Project orientation

2020-07-05 Thread Jean-Baptiste Kempf
On Sun, Jul 5, 2020, at 18:25, Marton Balint wrote: > > People aren't using it because people don't use MPEG-2. > > There is no maintenance to be done on a format that's 25 years old, do > > you want me to randomly change cosmetics to make you feel happy? > > If you'd get off your high horse for

Re: [FFmpeg-devel] Project orientation

2020-07-05 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Jean-Baptiste Kempf > Sent: Sunday, July 5, 2020 11:48 PM > To: ffmpeg-devel > Subject: Re: [FFmpeg-devel] Project orientation > > On Sun, Jul 5, 2020, at 22:50, Michael Niedermayer wrote: > > > Having your > > > patch being not

Re: [FFmpeg-devel] Project orientation

2020-07-05 Thread Timo Rothenpieler
On 06.07.2020 01:18, Michael Niedermayer wrote: On Sun, Jul 05, 2020 at 09:56:02PM +, Soft Works wrote: ... A significant part of code reviews are code-style violations. This is really not something where humans should need to spend time for when reviewing a patch. you are correct but

Re: [FFmpeg-devel] [PATCH v06 2/5] fbtile helperRoutines cpu based framebuffer detiling

2020-07-05 Thread Mark Thompson
On 04/07/2020 14:17, hanishkvc wrote: Add helper routines which can be used to detile tiled framebuffer layouts into a linear layout, using the cpu. Currently it supports Legacy Intel Tile-X, Legacy Intel Tile-Y and Newer Intel Tile-Yf tiled layouts. Currently supported pixel format is 32bit

Re: [FFmpeg-devel] Project orientation

2020-07-05 Thread Jean-Baptiste Kempf
On Sun, Jul 5, 2020, at 14:28, Marton Balint wrote: > having AMQP/ZMQ protocol support is much more useful then Lego Racers > demuxer... You are missing the point here: Lego Racers demuxer is in the scope of "play everything under the sun" that the FFmpeg project is, while AMQP/ZMQ is not.

[FFmpeg-devel] [PATCH v1 1/3] doc/developer.texi: Improvements in "Submitting patches" section.

2020-07-05 Thread Manolis Stamatogiannakis
The section has been expanded to outline how to manage patch revisions. --- doc/developer.texi | 37 ++--- 1 file changed, 26 insertions(+), 11 deletions(-) diff --git a/doc/developer.texi b/doc/developer.texi index b33cab0fc7..dec27cb509 100644 ---

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/tiff: Check frame parameters before blit for DNG

2020-07-05 Thread Michael Niedermayer
On Sat, Jul 04, 2020 at 02:45:52PM +0200, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 23888/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TIFF_fuzzer-6021365974171648.fuzz > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/mjpegdec: Limit bayer to single plane outputting format

2020-07-05 Thread Michael Niedermayer
On Sat, Jul 04, 2020 at 02:45:51PM +0200, Michael Niedermayer wrote: > This reduces the number of paths reachable with DNG and should > improve security > > Signed-off-by: Michael Niedermayer > --- > libavcodec/mjpegdec.c | 5 + > 1 file changed, 5 insertions(+) will apply [...] --

[FFmpeg-devel] [PATCH 1/2] avcodec/cbs: Remove unused function parameters

2020-07-05 Thread Andreas Rheinhardt
Several cbs-functions had an unused CodedBitstreamContext parameter. This commit removes these. Signed-off-by: Andreas Rheinhardt --- As one sees, removing the ctx parameter from some of these functions depends on removing it from others. But ff_cbs_alloc_unit_content is separate from all the

Re: [FFmpeg-devel] [FFmpeg-cvslog] swscale: Add swscale input/output support for X2RGB10LE

2020-07-05 Thread Wang, Fei W
> -Original Message- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: Monday, July 6, 2020 7:47 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] swscale: Add swscale > input/output support for X2RGB10LE > > On Fri, Jun 12, 2020 at 04:57:30PM

Re: [FFmpeg-devel] Project orientation

2020-07-05 Thread Anamitra Ghorui
July 5, 2020 11:43 PM, "Manolis Stamatogiannakis" wrote: > On Sun, 5 Jul 2020 at 19:01, Kieran Kunhya wrote: > >> For new contributors git send-email is annoying. For people wanting to >> push, the .mbox format is annoying, Gmail doesn't support it any more. >> And you can't get new

Re: [FFmpeg-devel] [PATCH 1/7] avcodec/cbs: Check for overflow when reading

2020-07-05 Thread Mark Thompson
On 09/12/2019 22:25, Andreas Rheinhardt wrote: While CBS itself uses size_t for sizes, it relies on other APIs that use int for their sizes; in particular, AVBuffer uses int for their size parameters and so does GetBitContext with their number of bits. While CBS aims to be a safe API, the checks

Re: [FFmpeg-devel] [FFmpeg-cvslog] swscale: Add swscale input/output support for X2RGB10LE

2020-07-05 Thread Michael Niedermayer
On Fri, Jun 12, 2020 at 04:57:30PM +, Fei Wang wrote: > ffmpeg | branch: master | Fei Wang | Wed Apr 22 > 13:23:02 2020 +0800| [c721b450141d6bbe1e977212a0bcb70118965c34] | committer: > Lynne > > swscale: Add swscale input/output support for X2RGB10LE > > Signed-off-by: Fei Wang > > >

[FFmpeg-devel] [PATCH 2/2] avcodec/h26[45]_metadata_bsf: Use separate contexts for reading/writing

2020-07-05 Thread Andreas Rheinhardt
Currently, both bsfs used the same CodedBitstreamContext for reading and writing; as a consequence, the state of the writer's context at the beginning of writing a fragment is exactly the state of the reader after having read the fragment; in particular, the writer might not have encountered one

Re: [FFmpeg-devel] Project orientation

2020-07-05 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Andriy Gelman > Sent: Monday, July 6, 2020 2:31 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] Project orientation > > On Sun, 05. Jul 23:42, Soft Works wrote: > > > > > > >

[FFmpeg-devel] Wow! SMPTE specs and journal articles, free (pandemic special)

2020-07-05 Thread Jim DeLaHunt
The Society of Motion Picture & Television Engineers (SMPTE) is making available 16 standards documents and 12 journal articles for free download at https://www.smpte.org/free-standards-and-publications [1], until 21. July 2020. I think this is fantastic news, and might be of interest to many

Re: [FFmpeg-devel] Project orientation

2020-07-05 Thread Kieran Kunhya
Going back to the original point in hand. Many patches aren't getting reviewed and pushed any more. In part this is because in 2020 whether we like it or not mailing lists are not the way to do Git based development. The kernel is the exception to the rule, as Linus says it has a whole load of

Re: [FFmpeg-devel] patch submission questions

2020-07-05 Thread Manolis Stamatogiannakis
Thanks for the tips Andriy. To make it easier for future new contributors I took the time to update developers.texi with the information I got from this thread, and revamp the chapter about submitting patches. Feedback is most welcome. Best regards, Manolis On Sun, 5 Jul 2020 at 20:56,

Re: [FFmpeg-devel] Project orientation

2020-07-05 Thread Michael Niedermayer
On Sun, Jul 05, 2020 at 09:56:02PM +, Soft Works wrote: > ... A significant part of code reviews are code-style violations. This is > really not something where humans should need to spend time for when > reviewing a patch. you are correct but that is also the easy part of reviews. Its not

Re: [FFmpeg-devel] ABI break in 4.3

2020-07-05 Thread Michael Niedermayer
On Sun, Jul 05, 2020 at 11:48:14PM +0200, Jan Engelhardt wrote: > > On Sunday 2020-07-05 23:17, Michael Niedermayer wrote: > > > >so its all doable in theory, but at that point the question arises, can we > >maybe generate this automatically from the APIchanges file if we decide to > >do that. >

Re: [FFmpeg-devel] [PATCH v06 2/5] fbtile helperRoutines cpu based framebuffer detiling

2020-07-05 Thread Lynne
Jul 5, 2020, 23:47 by s...@jkqxz.net: > On 04/07/2020 14:17, hanishkvc wrote: > >> Add helper routines which can be used to detile tiled framebuffer >> layouts into a linear layout, using the cpu. >> >> Currently it supports Legacy Intel Tile-X, Legacy Intel Tile-Y and >> Newer Intel Tile-Yf

Re: [FFmpeg-devel] [PATCH] libavformat/hlsenc: Remove duplicate close of the output stream.

2020-07-05 Thread Steven Liu
Andrey Semashev 于2020年7月5日周日 下午8:25写道: > > Ping? > > On 2020-07-01 17:59, Andrey Semashev wrote: > > The result of the first close attempt is ignored and may be lost. By > > removing > > it we ensure the close result code is properly analyzed. > > --- > > libavformat/hlsenc.c | 1 - > > 1

Re: [FFmpeg-devel] Project orientation

2020-07-05 Thread Henrik Gramner
On Sun, Jul 5, 2020 at 9:10 PM Marton Balint wrote: > I don't know enough about x262/x264 to do this with reasonable amount of > work. Do you think there is a chance of this happening if I post a bounty > or get a sponsorship? x264 is an H.264/AVC encoder and as such an MPEG-2 encoder is not in

Re: [FFmpeg-devel] Project orientation

2020-07-05 Thread Jean-Baptiste Kempf
On Sun, Jul 5, 2020, at 22:50, Michael Niedermayer wrote: > > Having your > > patch being not responded to (whether being forgotten, not found interesting > > enough, or whatever other reason) was. > > At least for me the reason to not review a patch is often simply > time. > But i agree the

Re: [FFmpeg-devel] ABI break in 4.3

2020-07-05 Thread Jan Engelhardt
On Sunday 2020-07-05 23:17, Michael Niedermayer wrote: > >so its all doable in theory, but at that point the question arises, can we >maybe generate this automatically from the APIchanges file if we decide to >do that. >APIchanges should list all added functions and the version numbers.

[FFmpeg-devel] [PATCH v1 3/3] doc/developer.texi: Swapped patch checklist and new codec/format checklist.

2020-07-05 Thread Manolis Stamatogiannakis
Adding a new codec/format should be more rare, so it makes sense to come after the detailed patch submission checklist. Signed-off-by: Manolis Stamatogiannakis --- doc/developer.texi | 105 ++--- 1 file changed, 52 insertions(+), 53 deletions(-) diff

[FFmpeg-devel] [PATCH v1 2/3] doc/developer.texi: Restructured "Submitting patches" section.

2020-07-05 Thread Manolis Stamatogiannakis
- Main text split to two sections. - Detailed checklist for new codecs or formats demoted to section. - Detailed checklist for patch submission demoted to section. Signed-off-by: Manolis Stamatogiannakis --- doc/developer.texi | 64 +++--- 1 file changed,

Re: [FFmpeg-devel] Project orientation

2020-07-05 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of Jim > DeLaHunt > Sent: Monday, July 6, 2020 6:54 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] Project orientation > > On 2020-07-04 07:43, Nicolas George wrote: > > Hi. > > > > When I first started progressively

Re: [FFmpeg-devel] ABI break in 4.3

2020-07-05 Thread Michael Niedermayer
On Sun, Jul 05, 2020 at 05:08:51PM +0200, Tomas Härdin wrote: > sön 2020-07-05 klockan 14:10 +0200 skrev Jan Engelhardt: > > On Sunday 2020-07-05 13:39, Tomas Härdin wrote: > > > > > Downgrading to a .so file with a lower minor version number than > > > > > the program is built against can never

Re: [FFmpeg-devel] Project orientation

2020-07-05 Thread Steinar H. Gunderson
On Sun, Jul 05, 2020 at 10:50:14PM +0200, Michael Niedermayer wrote: > At least for me the reason to not review a patch is often simply > time. > But i agree the amount of not reviewed patches is a problem. > > [...] > > The second thing is more reviews. > That can happen by > * More reviewers >

Re: [FFmpeg-devel] [PATCH] lavfi/vf_vpp_qsv: fix the infinite loop while framerate lower than input

2020-07-05 Thread Max Dmitrichenko
On Sun, Jul 5, 2020 at 5:56 PM Zhong Li wrote: > > > I can't see the benefit to use MSDK framerate conversion function. Is > > > it a good idea to drop it and use ffmpeg native fps filter instead? > > > > Reconsidering this, leaving the filter buggy doesn't seem to be > comfortable to me, > >

Re: [FFmpeg-devel] [PATCH v2 0/4] Supplement AVS3-P2/IEEE1857.10 video decoding via libuavs3d

2020-07-05 Thread hwren
Ping. Looking forward to more suggestions :-) At 2020-06-22 21:57:48, hwr...@126.com wrote: >From: hwren > >=== Version1 === >These patches are to supplement the third generation of Audio Video Coding >Standard, >part 2: video (AVS3-P2), aka IEEE1857.10, decoding support via

Re: [FFmpeg-devel] Project orientation

2020-07-05 Thread Jim DeLaHunt
On 2020-07-04 07:43, Nicolas George wrote: [In the FFmpeg project,] [t]here is work in making highly-optimized decoders, this work is impressive and creative…. But as far as I can see, that is mostly all there is going on. The rest seems to be rather basic: fixing bugs…, implementing support for

Re: [FFmpeg-devel] ABI break in 4.3

2020-07-05 Thread Tomas Härdin
sön 2020-07-05 klockan 14:10 +0200 skrev Jan Engelhardt: > On Sunday 2020-07-05 13:39, Tomas Härdin wrote: > > > > Downgrading to a .so file with a lower minor version number than > > > > the program is built against can never be expected to work. Else > > > > we couldn't add new functions without

Re: [FFmpeg-devel] Project orientation

2020-07-05 Thread Marton Balint
On Sun, 5 Jul 2020, Kieran Kunhya wrote: Would you want something experimental like x262 to be part of the > FFmpeg codebase, for us to have to maintain forever? If you don't limit > scope then that is what would happen. x262 is another example of a fork, where the fork alone was not

Re: [FFmpeg-devel] Project orientation

2020-07-05 Thread Tomas Härdin
sön 2020-07-05 klockan 14:28 +0200 skrev Marton Balint: > > On Sun, 5 Jul 2020, Tomas Härdin wrote: > > > sön 2020-07-05 klockan 12:42 +0200 skrev Marton Balint: > > > On Sun, 5 Jul 2020, Tomas Härdin wrote: > > > > > > > sön 2020-07-05 klockan 00:10 +0200 skrev Jean-Baptiste Kempf: > > > > >

Re: [FFmpeg-devel] [PATCH 3/3] avfilter/vf_subtitles: Reorganized subtitles filter options.

2020-07-05 Thread Gyan Doshi
On 05-07-2020 06:35 pm, Manolis Stamatogiannakis wrote: Some options are common between subtitles/ass filters. Rather than mentioning for each option whether it is common or not, the options are now displayed in two separate tables. Signed-off-by: Manolis Stamatogiannakis ---

Re: [FFmpeg-devel] ABI break in 4.3

2020-07-05 Thread Carl Eugen Hoyos
Am So., 5. Juli 2020 um 16:46 Uhr schrieb Timo Rothenpieler : > > On 05.07.2020 16:18, Carl Eugen Hoyos wrote: > > Am So., 5. Juli 2020 um 01:38 Uhr schrieb Andreas Rheinhardt > > : > > > >> This crash is due to Chromium using av_max_alloc in an undocumented way; > >> more exactly, the Chromium

Re: [FFmpeg-devel] ABI break in 4.3

2020-07-05 Thread Carl Eugen Hoyos
Am So., 5. Juli 2020 um 16:44 Uhr schrieb Timo Rothenpieler : > Generally, this seems incredibly hard to maintain and will very likely > cause confusion every time someone adds stuff in the future. True, and this is while this will not even reach the committee. Carl Eugen

Re: [FFmpeg-devel] ABI break in 4.3

2020-07-05 Thread Jan Engelhardt
On Sunday 2020-07-05 16:43, Timo Rothenpieler wrote: >> LIBAVCODEC_58 { >>global: >>av_foo; >>av_bar; >>av_whatever_else_there_is;... >>local: >>*; >> }; >> LIBAVCODEC_58.91 { >>global: >>avpriv_mpeg4audio_get_config2; >> } LIBAVCODEC_58; >> LIBAVCODEC_58.123 { /*

[FFmpeg-devel] [PATCH 1/4] kmsgrab: Refactor and clean error cases

2020-07-05 Thread Mark Thompson
--- libavdevice/kmsgrab.c | 151 ++ 1 file changed, 93 insertions(+), 58 deletions(-) diff --git a/libavdevice/kmsgrab.c b/libavdevice/kmsgrab.c index d0de774871..47ba15ca07 100644 --- a/libavdevice/kmsgrab.c +++ b/libavdevice/kmsgrab.c @@ -81,70 +81,42 @@

[FFmpeg-devel] [PATCH 4/4] doc/indevs: Note improved behaviour of kmsgrab with Linux 5.7

2020-07-05 Thread Mark Thompson
--- doc/indevs.texi | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/doc/indevs.texi b/doc/indevs.texi index 0f33fc66d8..4d2312e201 100644 --- a/doc/indevs.texi +++ b/doc/indevs.texi @@ -889,11 +889,15 @@ If you don't understand what all of that means, you probably

Re: [FFmpeg-devel] [PATCH] lavfi/vf_vpp_qsv: fix the infinite loop while framerate lower than input

2020-07-05 Thread Zhong Li
> > I can't see the benefit to use MSDK framerate conversion function. Is > > it a good idea to drop it and use ffmpeg native fps filter instead? > > Reconsidering this, leaving the filter buggy doesn't seem to be comfortable > to me, > hence IMHO it'll be better to have this bug fixed. My

[FFmpeg-devel] [PATCH 3/4] kmsgrab: Don't require the user to set framebuffer format

2020-07-05 Thread Mark Thompson
This is provided by GetFB2, but we still need the option for cases where that isn't available. --- libavdevice/kmsgrab.c | 55 +++ 1 file changed, 40 insertions(+), 15 deletions(-) diff --git a/libavdevice/kmsgrab.c b/libavdevice/kmsgrab.c index

[FFmpeg-devel] [PATCH 2/4] kmsgrab: Use GetFB2 if available

2020-07-05 Thread Mark Thompson
The most useful feature here is the ability to automatically extract the framebuffer format and modifiers. It also makes support for multi-plane framebuffers possible, though they will need to be added to the format table to work (not tested by me). This requires libdrm 2.4.101 (from April 2020)

Re: [FFmpeg-devel] patch submission questions

2020-07-05 Thread Manolis Stamatogiannakis
Thanks for the responses Hongcheng and Steinar! I'll use '-n' with git format-patch if I need to resubmit. Patches already work as Steinar describes. In the meantime patch 2/3 found its way to patchwork. The delay was probably due to some email processing hiccup. So all is good! Cheers,

Re: [FFmpeg-devel] ABI break in 4.3

2020-07-05 Thread Timo Rothenpieler
On 05.07.2020 17:46, Jan Engelhardt wrote: On Sunday 2020-07-05 16:43, Timo Rothenpieler wrote: LIBAVCODEC_58 { global: av_foo; av_bar; av_whatever_else_there_is;... local: *; }; LIBAVCODEC_58.91 { global: avpriv_mpeg4audio_get_config2; } LIBAVCODEC_58;

Re: [FFmpeg-devel] ABI break in 4.3

2020-07-05 Thread James Almer
On 7/5/2020 12:46 PM, Jan Engelhardt wrote: > > On Sunday 2020-07-05 16:43, Timo Rothenpieler wrote: >>> LIBAVCODEC_58 { >>>global: >>>av_foo; >>>av_bar; >>>av_whatever_else_there_is;... >>>local: >>>*; >>> }; >>> LIBAVCODEC_58.91 { >>>global: >>>

Re: [FFmpeg-devel] Project orientation

2020-07-05 Thread Marton Balint
On Sun, 5 Jul 2020, Kieran Kunhya wrote: x264 is practically feature complete, but x262 still miss some things, like 4:2:2 interlaced. Sure, x262 can work well enough for some use cases, but it is still not packaged in e.g. Ubuntu, so users are stuck with the - in some ways - inferior mpeg2

Re: [FFmpeg-devel] ABI break in 4.3

2020-07-05 Thread Jan Engelhardt
On Sunday 2020-07-05 01:04, James Almer wrote: >On 7/4/2020 7:54 PM, Jan Engelhardt wrote: >> @@ -67,6 +67,10 @@ typedef struct AVDCT { >> + >> +void (*get_pixels_unaligned)(int16_t *block /* align 16 */, >> + const uint8_t *pixels, >> + ptrdiff_t

Re: [FFmpeg-devel] Project orientation

2020-07-05 Thread Tomas Härdin
sön 2020-07-05 klockan 12:42 +0200 skrev Marton Balint: > > On Sun, 5 Jul 2020, Tomas Härdin wrote: > > > sön 2020-07-05 klockan 00:10 +0200 skrev Jean-Baptiste Kempf: > > > On Sat, Jul 4, 2020, at 23:51, Michael Niedermayer wrote: > > > > On Sat, Jul 04, 2020 at 11:25:31PM +0200, Jean-Baptiste

[FFmpeg-devel] [PATCH] [GSoC 3/6] avformat/hls: use abr to switch streams

2020-07-05 Thread Hongcheng Zhong
From: spartazhc When abr is enable, it will take over the task to call http to download segments, and will return a switch-request for hls to switch streams. For reason not to waste segments that have been downloaded, switch will become effective after old segments is used out. Abr cannot work

[FFmpeg-devel] [PATCH] [GSoC 2/6] avformat/http: Add abr to whitelist

2020-07-05 Thread Hongcheng Zhong
From: spartazhc add abr protocol to http's whitelist Signed-off-by: spartazhc --- libavformat/http.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/http.c b/libavformat/http.c index 6c39da1a8b..6a58c9afef 100644 --- a/libavformat/http.c +++

Re: [FFmpeg-devel] ABI break in 4.3

2020-07-05 Thread Jan Engelhardt
On Sunday 2020-07-05 13:39, Tomas Härdin wrote: >>> Downgrading to a .so file with a lower minor version number than >>> the program is built against can never be expected to work. Else >>> we couldn't add new functions without a major bump. >> >> It requires the use ELF symbol versions -- which

Re: [FFmpeg-devel] ABI break in 4.3

2020-07-05 Thread Tomas Härdin
sön 2020-07-05 klockan 10:43 +0200 skrev Jan Engelhardt: > On Sunday 2020-07-05 01:04, James Almer wrote: > > [[the header file says: > > * You can use AVOptions (av_opt* / av_set/get*()) to access these fields > > from user > > * applications.]] > > A "can" can be read as "need not". Perhaps

Re: [FFmpeg-devel] Project orientation

2020-07-05 Thread Marton Balint
On Sun, 5 Jul 2020, Tomas Härdin wrote: sön 2020-07-05 klockan 00:10 +0200 skrev Jean-Baptiste Kempf: On Sat, Jul 4, 2020, at 23:51, Michael Niedermayer wrote: > On Sat, Jul 04, 2020 at 11:25:31PM +0200, Jean-Baptiste Kempf > wrote: > [...] > > At some point, the project needs to decide

[FFmpeg-devel] How to resolve "ERROR: sdl2 requested but not found" when cross compile?

2020-07-05 Thread JACKY_ZZ [猫猫爱吃鱼]
I did compile SDL2 first, and run command "sudo ln -s /home/lixin/SDL2/bin/sdl2-config /usr/bin/arm-linux-gnueabihf-sdl2-config", but I got "ERROR: sdl2 requested but not found" message when I did cross compile. Here are commands what I did run for cross compile listed below: # export

[FFmpeg-devel] [PATCH v4] avdevice/xcbgrab: Add select_region option

2020-07-05 Thread Omar Emara
This patch adds a select_region option to the xcbgrab input device. If set to 1, the user will be prompted to select the grabbing area graphically by clicking and dragging. A rectangle will be drawn to mark the grabbing area. A single click with no dragging will select the whole screen. The option

Re: [FFmpeg-devel] ABI break in 4.3

2020-07-05 Thread Tomas Härdin
sön 2020-07-05 klockan 12:54 +0200 skrev Jan Engelhardt: > On Sunday 2020-07-05 12:06, Tomas Härdin wrote: > > > Or, summarized: A program may have been built with 4.3 but is > > > combined > > > with 4.2.3 at runtime, then this can happen: > > > > > > a = avcodec_dct_alloc(); // allocates 896

Re: [FFmpeg-devel] ABI break in 4.3

2020-07-05 Thread Hendrik Leppkes
On Sun, Jul 5, 2020 at 10:43 AM Jan Engelhardt wrote: > > Or, summarized: A program may have been built with 4.3 but is combined > with 4.2.3 at runtime, then this can happen: > Running against an older version then the build version is never supported. ABI compatibility is only guaranteed

[FFmpeg-devel] [PATCH] [GSoC 1/6] avformat/abr: Adaptive Bitrate support

2020-07-05 Thread Hongcheng Zhong
From: spartazhc Add abr module for hls/dash. Signed-off-by: spartazhc --- doc/protocols.texi | 7 + libavformat/Makefile| 1 + libavformat/abr.c | 282 libavformat/protocols.c | 1 + 4 files changed, 291 insertions(+) create mode

[FFmpeg-devel] [PATCH] [GSoC 5/6] avformat/utils: add av_packet_clean to remove AVPackets not needed in pktl

2020-07-05 Thread Hongcheng Zhong
From: spartazhc Add av_packet_clean to remove AVPackets whose stream_index is not in st_index list. Generally s->internal->packet_buffer may have pkts from different stream, and stream_index will be used to discard pkt that is not needed. But in case of abr, several streams may pass the

[FFmpeg-devel] [PATCH] [GSoC 4/6] ffplay: add an option to enable abr

2020-07-05 Thread Hongcheng Zhong
From: spartazhc Add abr option, ffplay can play hls using abr by: ffplay -i http://xxx/master.m3u8 -abr Structure ABRList is added to save stream type and index, it is used to allow packet_queue_put function to put pkt which from same type(for example: video pkt) but different stream index to

[FFmpeg-devel] [PATCH] [GSoC 6/6] ffplay: add av_packet_clean to remove AVPackets not needed

2020-07-05 Thread Hongcheng Zhong
From: spartazhc hls_read_header will add all streams to s->internal->packet_buffer. Use av_packet_clean to remove the AVPackets from other streams that are not needed, otherwise abr will allow them to be added to ffplay's packet_queue. Signed-off-by: spartazhc --- fftools/ffplay.c | 4 1

Re: [FFmpeg-devel] [PATCH v06 2/5] fbtile helperRoutines cpu based framebuffer detiling

2020-07-05 Thread Lynne
Jul 5, 2020, 04:57 by hanish...@gmail.com: > Hi Lynne, > > > On Sun, 5 Jul, 2020, 00:53 Lynne, wrote: > >> Jul 4, 2020, 14:17 by hanish...@gmail.com: >> >> > Add helper routines which can be used to detile tiled framebuffer >> > layouts into a linear layout, using the cpu. >> > >> > Currently it

Re: [FFmpeg-devel] [PATCH] libavformat/hlsenc: Remove duplicate close of the output stream.

2020-07-05 Thread Andrey Semashev
Ping? On 2020-07-01 17:59, Andrey Semashev wrote: The result of the first close attempt is ignored and may be lost. By removing it we ensure the close result code is properly analyzed. --- libavformat/hlsenc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/hlsenc.c

Re: [FFmpeg-devel] Project orientation

2020-07-05 Thread Kieran Kunhya
> x264 is practically feature complete, but x262 still miss some things, > like 4:2:2 interlaced. Sure, x262 can work well enough for some use cases, > but it is still not packaged in e.g. Ubuntu, so users are stuck with the > - in some ways - inferior mpeg2 encoder of ffmpeg. > > The point I am

Re: [FFmpeg-devel] [PATCH v06 1/5] KMSGrab: getfb2 format_modifier if user doesnt specify

2020-07-05 Thread C Hanish Menon
Hi Don't apply this patch, I will try and use ioctl directly instead of using xf86's GetFB2. Based on the reported compile issue with initialising global const for the fbtile patch when using older versions of gcc, I was checking the same using Ubuntu 16.04 setup, and realised that the older

Re: [FFmpeg-devel] [PATCH v06 3/5] hwcontext_drm detile non linear layout, if possible

2020-07-05 Thread C Hanish Menon
Hi Lynne, Am confused? Please look at this patch again. I directly detile from mmaped hardware framebuffer into specified output buffer. Only if the tile layout format is not supported, it falls back to the original frame copy. I am assuming you have misread the patch. On Sun, 5 Jul, 2020,

Re: [FFmpeg-devel] Project orientation

2020-07-05 Thread Kieran Kunhya
> > People aren't using it because people don't use MPEG-2. > > There is no maintenance to be done on a format that's 25 years old, do > > you want me to randomly change cosmetics to make you feel happy? > > If you'd get off your high horse for once, that would make me feel happy. Please let me

Re: [FFmpeg-devel] [PATCH v06 4/5] hwdownload detile framebuffer, if requested by user

2020-07-05 Thread C Hanish Menon
Hi Lynne, On Sun, 5 Jul, 2020, 00:59 Lynne, wrote: > Jul 4, 2020, 14:17 by hanish...@gmail.com: > > > Added logic to support detiling of framebuffer. > > > > By default this is disabled. Only if requested by the user, the > > logic will be triggered. > > > > It uses the fbtile helper routines

Re: [FFmpeg-devel] ABI break in 4.3

2020-07-05 Thread Jan Engelhardt
On Sunday 2020-07-05 18:18, James Almer wrote: >>> >>> Won't that break the entire ABI of anything currently linked, and thus would >>> require a major bump? >> >> Since 4.3 was sort of a break over 4.2.3 already > >No, it wasn't. Perhaps not on a high level. But for the ELF system, it was a

Re: [FFmpeg-devel] [PATCH 3/3] avfilter/vf_subtitles: Reorganized subtitles filter options.

2020-07-05 Thread Manolis Stamatogiannakis
Fair point. I've submitted a v2 where the docs reorganization is applied first. On Sun, 5 Jul 2020 at 17:30, Gyan Doshi wrote: > > > On 05-07-2020 06:35 pm, Manolis Stamatogiannakis wrote: > > Some options are common between subtitles/ass filters. > > Rather than mentioning for each option

Re: [FFmpeg-devel] Project orientation

2020-07-05 Thread Manolis Stamatogiannakis
On Sun, 5 Jul 2020 at 19:01, Kieran Kunhya wrote: > > For new contributors git send-email is annoying. For people wanting to > push, the .mbox format is annoying, Gmail doesn't support it any more. > And you can't get new contributors to start using CLI based email > clients or run their own

Re: [FFmpeg-devel] ABI break in 4.3

2020-07-05 Thread Hendrik Leppkes
On Sun, Jul 5, 2020 at 7:29 PM James Almer wrote: > > On 7/5/2020 1:58 PM, Jan Engelhardt wrote: > > > > On Sunday 2020-07-05 18:18, James Almer wrote: > > Won't that break the entire ABI of anything currently linked, and thus > would > require a major bump? > >>> > >>> Since

[FFmpeg-devel] [PATCH 2/2] avfilter/vf_subtitles: Added shift option for subtitles/ass filters.

2020-07-05 Thread Manolis Stamatogiannakis
Allows shifting of subtitle display times to align them with the video. This avoids having to rewrite the subtitle file in order to display subtitles correctly when input is seeked (-ss). Also handy for minor subtitle timing corrections without rewriting the subtitles file. Signed-off-by: Manolis

Re: [FFmpeg-devel] ABI break in 4.3

2020-07-05 Thread Jan Engelhardt
On Sunday 2020-07-05 19:21, James Almer wrote: >> 8 files changed, 1163 insertions(+), 44 deletions(-) > >The list of functions is incomplete. After a quick look, you're for >example missing av_map_videotoolbox_format_* in libavutil.[..] >This is another issue that i don't know if you

Re: [FFmpeg-devel] Project orientation

2020-07-05 Thread Marton Balint
On Sun, 5 Jul 2020, Kieran Kunhya wrote: People aren't using it because people don't use MPEG-2. > There is no maintenance to be done on a format that's 25 years old, do > you want me to randomly change cosmetics to make you feel happy? If you'd get off your high horse for once, that would

[FFmpeg-devel] [PATCH 2/2] avfilter/vf_subtitles: Added shift option for subtitles/ass filters.

2020-07-05 Thread Manolis Stamatogiannakis
Allows shifting of subtitle display times to align them with the video. This avoids having to rewrite the subtitle file in order to display subtitles correctly when input is seeked (-ss). Also handy for minor subtitle timing corrections without rewriting the subtitles file. Signed-off-by: Manolis

[FFmpeg-devel] [PATCH 1/2] avfilter/vf_subtitles: Reorganized subtitles filter options.

2020-07-05 Thread Manolis Stamatogiannakis
Some options are common between subtitles/ass filters. Rather than mentioning for each option whether it is common or not, the options are now displayed in two separate tables. Signed-off-by: Manolis Stamatogiannakis --- doc/filters.texi | 12 1 file changed, 8 insertions(+), 4

Re: [FFmpeg-devel] ABI break in 4.3

2020-07-05 Thread James Almer
On 7/5/2020 1:58 PM, Jan Engelhardt wrote: > > On Sunday 2020-07-05 18:18, James Almer wrote: Won't that break the entire ABI of anything currently linked, and thus would require a major bump? >>> >>> Since 4.3 was sort of a break over 4.2.3 already >> >> No, it wasn't. > >

[FFmpeg-devel] [PATCH 1/2] avfilter/vf_subtitles: Reorganized subtitles filter options.

2020-07-05 Thread Manolis Stamatogiannakis
Some options are common between subtitles/ass filters. Rather than mentioning for each option whether it is common or not, the options are now displayed in two separate tables. Signed-off-by: Manolis Stamatogiannakis --- doc/filters.texi | 12 1 file changed, 8 insertions(+), 4

Re: [FFmpeg-devel] patch submission questions

2020-07-05 Thread Manolis Stamatogiannakis
On Sun, 5 Jul 2020 at 15:48, Hongcheng Zhong wrote: > > You can use `git format-patch -v -n` to get patches like [PATCH > v2 1/20]. See git-format-patch documentation for more details. > > That didn't quite work. I used "git format-patch -s -n -v3 --to ffmpeg-devel@ffmpeg.org HEAD~2..HEAD" and

Re: [FFmpeg-devel] Project orientation

2020-07-05 Thread Steinar H. Gunderson
On Sun, Jul 05, 2020 at 08:13:25PM +0200, Manolis Stamatogiannakis wrote: > As a fresh contributor, setting up git send-email was a hassle, but > not an insurmountable obstacle. Speaking only for myself, having sent a single-digit number of patches to FFmpeg ever: Setting up git send-email was

Re: [FFmpeg-devel] patch submission questions

2020-07-05 Thread Andriy Gelman
On Sun, 05. Jul 20:34, Manolis Stamatogiannakis wrote: > On Sun, 5 Jul 2020 at 15:48, Hongcheng Zhong > wrote: > > > > > You can use `git format-patch -v -n` to get patches like [PATCH > > v2 1/20]. See git-format-patch documentation for more details. > > > > > That didn't quite work. > > I

Re: [FFmpeg-devel] ABI break in 4.3

2020-07-05 Thread James Almer
On 7/5/2020 3:59 PM, Jan Engelhardt wrote: > > On Sunday 2020-07-05 19:21, James Almer wrote: >>> 8 files changed, 1163 insertions(+), 44 deletions(-) >> >> The list of functions is incomplete. After a quick look, you're for >> example missing av_map_videotoolbox_format_* in libavutil.[..] >>

Re: [FFmpeg-devel] Project orientation

2020-07-05 Thread Marton Balint
On Sun, 5 Jul 2020, Tomas Härdin wrote: sön 2020-07-05 klockan 12:42 +0200 skrev Marton Balint: On Sun, 5 Jul 2020, Tomas Härdin wrote: > sön 2020-07-05 klockan 00:10 +0200 skrev Jean-Baptiste Kempf: > > On Sat, Jul 4, 2020, at 23:51, Michael Niedermayer wrote: > > > On Sat, Jul 04, 2020

[FFmpeg-devel] [PATCH 3/3] avfilter/vf_subtitles: Reorganized subtitles filter options.

2020-07-05 Thread Manolis Stamatogiannakis
Some options are common between subtitles/ass filters. Rather than mentioning for each option whether it is common or not, the options are now displayed in two separate tables. Signed-off-by: Manolis Stamatogiannakis --- doc/filters.texi | 18 +++--- 1 file changed, 11

[FFmpeg-devel] [PATCH 1/3] avfilter/vf_subtitles: add shift option

2020-07-05 Thread Manolis Stamatogiannakis
Allows shifting of subtitle display times to align them with the video. This avoids having to rewrite the subtitle file in order to display subtitles correctly when input is seeked (-ss). Also handy for minor subtitle timing corrections without rewriting the subtitles file. Signed-off-by: Manolis

Re: [FFmpeg-devel] [PATCH] [GSoC 5/6] avformat/utils: add av_packet_clean to remove AVPackets not needed in pktl

2020-07-05 Thread Andreas Rheinhardt
Hongcheng Zhong: > From: spartazhc > > Add av_packet_clean to remove AVPackets whose stream_index is not > in st_index list. > > Generally s->internal->packet_buffer may have pkts from different > stream, and stream_index will be used to discard pkt that is not > needed. But in case of abr,

Re: [FFmpeg-devel] Project orientation

2020-07-05 Thread Kieran Kunhya
> > So having something merged and maintained in ffmpeg has the benefit that > more people have the ability to test the code and to develop it. Also it > is more likely for the project to get developers if their code live in the > core ffmpeg respository. I also don't see that maitenance burden to

Re: [FFmpeg-devel] [PATCH] lavc/cfhd:3d transform decoding for both progressive and interlaced

2020-07-05 Thread Kieran Kunhya
> > > @@ -1064,6 +1446,6 @@ AVCodec ff_cfhd_decoder = { > > .init = cfhd_init, > > .close= cfhd_close, > > .decode = cfhd_decode, > > -.capabilities = AV_CODEC_CAP_DR1 | AV_CODEC_CAP_FRAME_THREADS, > > -.caps_internal=

Re: [FFmpeg-devel] [PATCH] [GSoC 5/6] avformat/utils: add av_packet_clean to remove AVPackets not needed in pktl

2020-07-05 Thread Hongcheng Zhong
- On Jul 5, 2020, at 9:14 PM, Andreas Rheinhardt andreas.rheinha...@gmail.com wrote: > Hongcheng Zhong: >> From: spartazhc >> >> Add av_packet_clean to remove AVPackets whose stream_index is not >> in st_index list. >> >> Generally s->internal->packet_buffer may have pkts from different

[FFmpeg-devel] patch submission questions

2020-07-05 Thread Manolis Stamatogiannakis
Hello, I'm trying to submit a patch for adding a "shift" option to subtitles/ass filters. Initial submission was ok, but resubmitting after addressing some emails didn't go as expected. I have the following two questions on the process: Q1: How do you get the "v2" label when you resubmit a

  1   2   >