Re: [FFmpeg-devel] [PATCH v3 2/2] lavc/vulkan_av1: port to the new stable API

2024-03-18 Thread Dave Airlie
> > > -/* Workaround for a spec issue. > > - *Can be removed once no longer needed, and threading can be enabled. > */ > > +/* TODO: investigate if this can be removed to make decoding > completely > > + * independent. */ > > FFVulkanDecodeContext *dec; > >

Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_vulkan: check both vendor and PCI IDs

2024-03-18 Thread Lynne
Mar 18, 2024, 06:57 by haihao.xiang-at-intel@ffmpeg.org: > On Vr, 2024-03-08 at 15:13 +0800, Xiang, Haihao wrote: > >> From: Haihao Xiang >> >> Otherwise the derived device and the source device might have different >> PCI ID or vendor ID in a multiple-device system. >> >> Signed-off-by:

Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_vulkan: check both vendor and PCI IDs

2024-03-18 Thread Xiang, Haihao
On Ma, 2024-03-18 at 07:18 +0100, Lynne wrote: > Mar 18, 2024, 06:57 by haihao.xiang-at-intel@ffmpeg.org: > > > On Vr, 2024-03-08 at 15:13 +0800, Xiang, Haihao wrote: > > > > > From: Haihao Xiang > > > > > > Otherwise the derived device and the source device might have different > > > PCI

Re: [FFmpeg-devel] [PATCH v3] lavc/vaapi_encode: Enable block level bitrate control

2024-03-18 Thread Xiang, Haihao
On Vr, 2024-03-15 at 02:46 +, Xiang, Haihao wrote: > On Vr, 2024-03-08 at 16:45 +0800, fei.w.wang-at-intel@ffmpeg.org wrote: > > From: Fei Wang > > > > Signed-off-by: Fei Wang > > --- > >  doc/encoders.texi |  4 > >  libavcodec/vaapi_encode.c | 13 - > >  

[FFmpeg-devel] [PATCH 2/3] lavfi: Add drawbox_vaapi filter

2024-03-18 Thread Xiang, Haihao
From: Haihao Xiang Signed-off-by: Haihao Xiang --- configure | 1 + doc/filters.texi | 85 libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_drawbox_vaapi.c | 369 + 5

[FFmpeg-devel] [PATCH 3/3] Changelog: Add pad_vaapi, drawbox_vaapi entry

2024-03-18 Thread Xiang, Haihao
From: Haihao Xiang Signed-off-by: Haihao Xiang --- Changelog | 1 + 1 file changed, 1 insertion(+) diff --git a/Changelog b/Changelog index b7d7535a9e..27da4b77f0 100644 --- a/Changelog +++ b/Changelog @@ -34,6 +34,7 @@ version : - ffprobe (with -export_side_data film_grain) now prints film

[FFmpeg-devel] [PATCH 1/3] lavfi: Add pad_vaapi filter

2024-03-18 Thread Xiang, Haihao
From: Haihao Xiang Signed-off-by: Haihao Xiang --- configure | 1 + doc/filters.texi | 77 ++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_pad_vaapi.c | 283 + 5 files changed,

Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_vulkan: check both vendor and PCI IDs

2024-03-18 Thread Lynne
Mar 18, 2024, 07:33 by haihao.xiang-at-intel@ffmpeg.org: > On Ma, 2024-03-18 at 07:18 +0100, Lynne wrote: > >> Mar 18, 2024, 06:57 by haihao.xiang-at-intel@ffmpeg.org: >> >> > On Vr, 2024-03-08 at 15:13 +0800, Xiang, Haihao wrote: >> > >> > > From: Haihao Xiang >> > > >> > > Otherwise

[FFmpeg-devel] [PATCH 3/3] lavfi/tonemap_vaapi: Add support for HDR to HDR tone mapping

2024-03-18 Thread Xiang, Haihao
From: Xinpeng Sun Usage example: ffmpeg -y -hwaccel vaapi -hwaccel_output_format vaapi -i hdr.mp4 \ -vf "tonemap_vaapi=display=7500 3000|34000 16000|13250 34500|15635 16450|500 1000:extra_hw_frames=64" \ -c:v hevc_vaapi output.mp4 Signed-off-by: Xinpeng Sun Signed-off-by: Haihao Xiang

[FFmpeg-devel] [PATCH 1/3] lavfi/tonemap_vaapi: By default use bt709 for output frame

2024-03-18 Thread Xiang, Haihao
From: Haihao Xiang By default don't use the color properties from input frame as output frame properties when performing HDR to SDR conversion Signed-off-by: Haihao Xiang --- doc/filters.texi | 4 ++-- libavfilter/vf_tonemap_vaapi.c | 7 +-- 2 files changed, 7 insertions(+),

[FFmpeg-devel] [PATCH 2/3] lavfi/tonemap_vaapi: Update the log

2024-03-18 Thread Xiang, Haihao
From: Haihao Xiang demote the message to AV_LOG_VERBOSE. Signed-off-by: Haihao Xiang --- libavfilter/vf_tonemap_vaapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_tonemap_vaapi.c b/libavfilter/vf_tonemap_vaapi.c index a21f565e3a..5d475e8ff2 100644 ---

[FFmpeg-devel] [PATCH] lavu/hwcontext_vulkan: check PCI ID if possible

2024-03-18 Thread Xiang, Haihao
From: Haihao Xiang Otherwise the derived device and the source device might have different PCI ID in a multiple-device system. Signed-off-by: Haihao Xiang --- libavutil/hwcontext_vulkan.c | 30 +++--- 1 file changed, 23 insertions(+), 7 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_vulkan: check both vendor and PCI IDs

2024-03-18 Thread Xiang, Haihao
On Ma, 2024-03-18 at 07:39 +0100, Lynne wrote: > Mar 18, 2024, 07:33 by haihao.xiang-at-intel@ffmpeg.org: > > > On Ma, 2024-03-18 at 07:18 +0100, Lynne wrote: > > > > > Mar 18, 2024, 06:57 by haihao.xiang-at-intel@ffmpeg.org: > > > > > > > On Vr, 2024-03-08 at 15:13 +0800, Xiang, Haihao

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

2024-03-18 Thread Martin Storsjö
On Sun, 17 Mar 2024, Rémi Denis-Courmont wrote: Obviously not. Imported libraries are only there to resolve missing symbols. Sure - but if resolving the missing symbols brings in those conflicting object files, there's not much to do about it. If the static library contains dec_init in a

Re: [FFmpeg-devel] [PATCH v5 1/3] avformat/flvdec: support enhanced flv PacketTypeMetadata

2024-03-18 Thread Dennis Mungai
On Mon, 18 Mar 2024 at 12:09, Steven Liu wrote: > Steven Liu 于2024年3月7日周四 17:33写道: > > > > zhupengfei via ffmpeg-devel 于2024年3月4日周一 > 21:52写道: > > > > > > From: Zhu Pengfei <411294...@qq.com> > > > > > > Signed-off-by: Zhu Pengfei <411294...@qq.com> > > > --- > > > libavformat/flvdec.c | 177

Re: [FFmpeg-devel] [PATCH] Changelog: Add Support PacketTypeMetadata of PacketType in enhanced flv

2024-03-18 Thread Liu Steven
> On Mar 18, 2024, at 18:23, Jean-Baptiste Kempf wrote: > > > > On Mon, 18 Mar 2024, at 11:01, Steven Liu via ffmpeg-devel wrote: >> Changelog | 1 + >> 1 file changed, 1 insertion(+) > > Obviously LGTM. Applied > > jbk Thanks jb > > -- > Jean-Baptiste Kempf - President > +33 672 704

Re: [FFmpeg-devel] [PATCH] tests/ref/lavf-fate/hevc.flv: Fix ref file

2024-03-18 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Unbreaks the lavf-fate-hevc.flv FATE test. > > Signed-off-by: Andreas Rheinhardt > --- > tests/ref/lavf-fate/hevc.flv | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/ref/lavf-fate/hevc.flv b/tests/ref/lavf-fate/hevc.flv > index

Re: [FFmpeg-devel] [PATCH v1] avcodec/cbs_vp8: Improve the bitstream position check

2024-03-18 Thread Andreas Rheinhardt
Dai, Jianhui J: > The VP8 compressed header may not be byte-aligned due to boolean > coding. Use bitwise comparison to prevent the potential overread. > > Signed-off-by: Jianhui Dai > --- > libavcodec/cbs_vp8.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH v5 1/3] avformat/flvdec: support enhanced flv PacketTypeMetadata

2024-03-18 Thread Zhao Zhili
> On Mar 18, 2024, at 17:14, Dennis Mungai wrote: > > Steven and Zhu Pengfei, > > Thank you for the patchset. Can this be back-ported to release/6.1? Only bug fix and security fix can be back ported to stable release. This patch is for new feature. >

Re: [FFmpeg-devel] [PATCH] fate/lavf-container: correct operator; unbreak build

2024-03-18 Thread Liu Steven
> On Mar 18, 2024, at 18:11, Gyan Doshi wrote: > > --- > tests/fate/lavf-container.mak | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/fate/lavf-container.mak b/tests/fate/lavf-container.mak > index b18ed2362b..7a925117c3 100644 > ---

[FFmpeg-devel] [PATCH] fate/lavf-container: correct operator; unbreak build

2024-03-18 Thread Gyan Doshi
--- tests/fate/lavf-container.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/lavf-container.mak b/tests/fate/lavf-container.mak index b18ed2362b..7a925117c3 100644 --- a/tests/fate/lavf-container.mak +++ b/tests/fate/lavf-container.mak @@ -80,7 +80,7 @@

[FFmpeg-devel] [PATCH] Changelog: Add Support PacketTypeMetadata of PacketType in enhanced flv

2024-03-18 Thread Steven Liu via ffmpeg-devel
Signed-off-by: Steven Liu --- Changelog | 1 + 1 file changed, 1 insertion(+) diff --git a/Changelog b/Changelog index b7d7535a9e..e3ca52430c 100644 --- a/Changelog +++ b/Changelog @@ -34,6 +34,7 @@ version : - ffprobe (with -export_side_data film_grain) now prints film grain metadata - AEA

Re: [FFmpeg-devel] [PATCH] fate/lavf-container: correct operator; unbreak build

2024-03-18 Thread Gyan Doshi
On 2024-03-18 04:11 pm, Liu Steven wrote: On Mar 18, 2024, at 18:11, Gyan Doshi wrote: --- tests/fate/lavf-container.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/lavf-container.mak b/tests/fate/lavf-container.mak index b18ed2362b..7a925117c3 100644 ---

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

2024-03-18 Thread Andreas Rheinhardt
Martin Storsjö: > On Sun, 17 Mar 2024, Rémi Denis-Courmont wrote: > >> Obviously not. Imported libraries are only there to resolve missing >> symbols. > > Sure - but if resolving the missing symbols brings in those conflicting > object files, there's not much to do about it. If the static

Re: [FFmpeg-devel] [PATCH 3/3] avutil/hwcontext_d3d11va: add logging to dxgi debug interfaces

2024-03-18 Thread Timo Rothenpieler
applied ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v5 1/3] avformat/flvdec: support enhanced flv PacketTypeMetadata

2024-03-18 Thread Steven Liu
Steven Liu 于2024年3月7日周四 17:33写道: > > zhupengfei via ffmpeg-devel 于2024年3月4日周一 21:52写道: > > > > From: Zhu Pengfei <411294...@qq.com> > > > > Signed-off-by: Zhu Pengfei <411294...@qq.com> > > --- > > libavformat/flvdec.c | 177 ++- > > 1 file changed, 176

Re: [FFmpeg-devel] [PATCH] Changelog: Add Support PacketTypeMetadata of PacketType in enhanced flv

2024-03-18 Thread Jean-Baptiste Kempf
On Mon, 18 Mar 2024, at 11:01, Steven Liu via ffmpeg-devel wrote: > Changelog | 1 + > 1 file changed, 1 insertion(+) Obviously LGTM. jbk -- Jean-Baptiste Kempf - President +33 672 704 734 https://jbkempf.com/ ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH] tests/ref/lavf-fate/hevc.flv: Fix ref file

2024-03-18 Thread Andreas Rheinhardt
Unbreaks the lavf-fate-hevc.flv FATE test. Signed-off-by: Andreas Rheinhardt --- tests/ref/lavf-fate/hevc.flv | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/ref/lavf-fate/hevc.flv b/tests/ref/lavf-fate/hevc.flv index 5f47c352fd..1105d8eddb 100644 ---

[FFmpeg-devel] [PATCH v4 12/13] avcodec/h2645_sei: decode AFGS1 T.35 SEI

2024-03-18 Thread Niklas Haas
From: Niklas Haas I restricted this SEI to HEVC for now, until I see a H.264 sample. --- libavcodec/Makefile| 2 +- libavcodec/h2645_sei.c | 25 + libavcodec/h2645_sei.h | 3 +++ 3 files changed, 29 insertions(+), 1 deletion(-) diff --git a/libavcodec/Makefile

[FFmpeg-devel] [PATCH v4 11/13] avcodec/aom_film_grain: implement AFGS1 parsing

2024-03-18 Thread Niklas Haas
From: Niklas Haas Based on the AOMedia Film Grain Synthesis 1 (AFGS1) spec: https://aomediacodec.github.io/afgs1-spec/ The parsing has been changed substantially relative to the AV1 film grain OBU. In particular: 1. There is the possibility of maintaining multiple independent film grain

[FFmpeg-devel] [PATCH v4 05/13] avcodec/h2645_sei: signal new AVFilmGrainParams members

2024-03-18 Thread Niklas Haas
From: Niklas Haas H.274 specifies that film grain parameters are signalled as intended for 4:4:4 frames, so we always signal this, regardless of the frame's actual subsampling. --- libavcodec/h2645_sei.c | 46 +- 1 file changed, 28 insertions(+), 18

[FFmpeg-devel] [PATCH v4 09/13] avutil/film_grain_params: add av_film_grain_params_select()

2024-03-18 Thread Niklas Haas
From: Niklas Haas Common utility function that can be used by all codecs to select the right (any valid) film grain parameter set. In particular, this is useful for AFGS1, which has support for multiple parameters. However, it also performs parameter validation for H274. --- doc/APIchanges

[FFmpeg-devel] [PATCH v4 13/13] avcodec/hevcdec: apply AOM film grain synthesis

2024-03-18 Thread Niklas Haas
From: Niklas Haas Following the usual logic for H.274 film grain. --- libavcodec/Makefile | 2 +- libavcodec/hevcdec.c | 29 ++--- 2 files changed, 23 insertions(+), 8 deletions(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index 824845276ae..7ef2e03ca6a

[FFmpeg-devel] [PATCH v4 07/13] avcodec/libdavv1d: signal new AVFilmGrainParams members

2024-03-18 Thread Niklas Haas
From: Niklas Haas Not directly signalled by AV1, but we should still set this accordingly so that users will know what the original intended video characteristics and chroma resolution were. --- libavcodec/libdav1d.c | 10 ++ 1 file changed, 10 insertions(+) diff --git

[FFmpeg-devel] [PATCH v4 06/13] avcodec/av1dec: signal new AVFilmGrainParams members

2024-03-18 Thread Niklas Haas
From: Niklas Haas Not directly signalled by AV1, but we should still set this accordingly so that users will know what the original intended video characteristics and chroma resolution were. --- libavcodec/av1dec.c | 10 ++ 1 file changed, 10 insertions(+) diff --git

[FFmpeg-devel] [PATCH 14/14] avcodec/vvcdec: inter prediction, support subpicture

2024-03-18 Thread Nuo Mi
passed files: CodingToolsSets_E_Tencent_1.bit SUBPIC_A_HUAWEI_3.bit SUBPIC_B_HUAWEI_3.bit SUBPIC_C_ERICSSON_1.bit SUBPIC_D_ERICSSON_1.bit SUBPIC_E_MediaTek_1.bit passed dvb conformance files (https://dvb.org/specifications/verification-validation/vvc-test-content):

[FFmpeg-devel] [PATCH 05/14] avcodec/vvcdec: ff_vvc_decode_neighbour, support subpicture

2024-03-18 Thread Nuo Mi
--- libavcodec/vvc/vvc_ctu.c | 4 libavcodec/vvc/vvc_ctu.h | 6 -- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/libavcodec/vvc/vvc_ctu.c b/libavcodec/vvc/vvc_ctu.c index 75b9e73ae3..75d9f07143 100644 --- a/libavcodec/vvc/vvc_ctu.c +++ b/libavcodec/vvc/vvc_ctu.c @@

[FFmpeg-devel] [PATCH 08/14] avcodec/vvcdec: deblock, support subpicture

2024-03-18 Thread Nuo Mi
--- libavcodec/vvc/vvc_filter.c | 52 + libavcodec/vvc/vvc_filter.h | 6 +++-- libavcodec/vvc/vvc_thread.c | 4 +-- 3 files changed, 35 insertions(+), 27 deletions(-) diff --git a/libavcodec/vvc/vvc_filter.c b/libavcodec/vvc/vvc_filter.c index

[FFmpeg-devel] [PATCH 03/14] avcodec/vvcdec: support rectangular single-slice subpics

2024-03-18 Thread Nuo Mi
From: Frank Plowman Co-authored-by: Nuo Mi --- libavcodec/cbs_h266_syntax_template.c | 5 +- libavcodec/vvc/vvc_ps.c | 93 +-- 2 files changed, 91 insertions(+), 7 deletions(-) diff --git a/libavcodec/cbs_h266_syntax_template.c

[FFmpeg-devel] [PATCH 01/14] avcodec/vvcdec: NoBackwardPredFlag, only check active pictures

2024-03-18 Thread Nuo Mi
see "8.3.6 Decoding process for collocated picture and no backward prediction" --- libavcodec/vvc/vvc_mvs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vvc/vvc_mvs.c b/libavcodec/vvc/vvc_mvs.c index 6398fd3571..cf92202b5b 100644 --- a/libavcodec/vvc/vvc_mvs.c

[FFmpeg-devel] [PATCH 04/14] avcodec/vvcdec: derive subpic postion for PPS

2024-03-18 Thread Nuo Mi
--- libavcodec/vvc/vvc_ps.c | 19 +++ libavcodec/vvc/vvc_ps.h | 4 2 files changed, 23 insertions(+) diff --git a/libavcodec/vvc/vvc_ps.c b/libavcodec/vvc/vvc_ps.c index bb13b04a5d..bbd666307f 100644 --- a/libavcodec/vvc/vvc_ps.c +++ b/libavcodec/vvc/vvc_ps.c @@ -511,6

[FFmpeg-devel] [PATCH 07/14] avcodec/vvcdec: refact out deblock_is_boundary

2024-03-18 Thread Nuo Mi
--- libavcodec/vvc/vvc_filter.c | 66 +++-- 1 file changed, 26 insertions(+), 40 deletions(-) diff --git a/libavcodec/vvc/vvc_filter.c b/libavcodec/vvc/vvc_filter.c index 10bd57e078..11972bde41 100644 --- a/libavcodec/vvc/vvc_filter.c +++

Re: [FFmpeg-devel] Fixes #10509

2024-03-18 Thread Poorva
> On Sun, Mar 17, 2024 at 12:26 AM Marton Balint wrote: > > > > On Sun, 17 Mar 2024, Poorva wrote: > > > On Mon, Mar 11, 2024 at 1:10 AM Leo Izen wrote: > >> > >> On 3/9/24 15:49, Poorva wrote: > >>> I have attached the git patch containing the changes for your review. > >>> > >>> This patch is

[FFmpeg-devel] [PATCH 02/14] avcodec/cbs_h266: fix sh_collocated_from_l0_flag and sh_collocated_ref_idx infer

2024-03-18 Thread Nuo Mi
we have to infer sh_collocated_from_l0_flag and sh_collocated_ref_idx from picture head if pps_rpl_info_in_ph_flag is true --- libavcodec/cbs_h266_syntax_template.c | 32 +-- 1 file changed, 20 insertions(+), 12 deletions(-) diff --git

[FFmpeg-devel] [PATCH 00/14] avcodec/vvcdec: support subpicture

2024-03-18 Thread Nuo Mi
see introductions here: https://dashif.org/docs/VVC%20HLS%20overview%20.pdf Frank Plowman (1): avcodec/vvcdec: support rectangular single-slice subpics Nuo Mi (13): avcodec/vvcdec: NoBackwardPredFlag, only check active pictures avcodec/cbs_h266: fix sh_collocated_from_l0_flag and

[FFmpeg-devel] [PATCH v4 00/13] AFGS1 film grain support

2024-03-18 Thread Niklas Haas
Changes since v3: - Moved metadata into common AVFilmGrainParams struct, as per James Almer's recommendation - Fixed width/height field validation - Signal this metadata for AV1 (instead of setting it to unspecified) - Implement ffprobe/showinfo support for the new fields

[FFmpeg-devel] [PATCH v4 04/13] ffprobe: adapt to new AVFilmGrainParams

2024-03-18 Thread Niklas Haas
From: Niklas Haas Follow the establish convention of printing the bit depth metadata per-component. --- fftools/ffprobe.c | 41 ++--- 1 file changed, 26 insertions(+), 15 deletions(-) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index

[FFmpeg-devel] [PATCH v4 08/13] avutil/frame: clarify AV_FRAME_DATA_FILM_GRAIN_PARAMS usage

2024-03-18 Thread Niklas Haas
From: Niklas Haas To allow for AFGS1 usage, which can expose multiple parameter sets for a single frame. --- libavutil/frame.h | 4 1 file changed, 4 insertions(+) diff --git a/libavutil/frame.h b/libavutil/frame.h index b94687941db..7f616488be8 100644 --- a/libavutil/frame.h +++

[FFmpeg-devel] [PATCH v4 01/13] avutil/film_grain_params: add metadata to common struct

2024-03-18 Thread Niklas Haas
From: Niklas Haas This is needed for AV1 film grain as well, when using AFGS1 streams. Also add extra width/height and subsampling information, which AFGS1 cares about, as part of the same API bump. (And in principle, H274 should also expose this information, since it is needed downstream to

[FFmpeg-devel] [PATCH v4 03/13] avfilter/vf_showinfo: adapt to new AVFilmGrainParams

2024-03-18 Thread Niklas Haas
From: Niklas Haas --- libavfilter/vf_showinfo.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c index 095cb22639f..28d8ea76e9b 100644 --- a/libavfilter/vf_showinfo.c +++

[FFmpeg-devel] [PATCH v4 02/13] avutil/film_grain_params: initialize VCS to UNSPECIFIED

2024-03-18 Thread Niklas Haas
From: Niklas Haas --- libavutil/film_grain_params.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/libavutil/film_grain_params.c b/libavutil/film_grain_params.c index 930d23c7fe9..230ce8d701c 100644 --- a/libavutil/film_grain_params.c +++

Re: [FFmpeg-devel] [PATCH] avformat: enable UDP IPv6 multicast interface selection

2024-03-18 Thread RS
This message has been marked as Public on 03/18/2024 13:45Z. On Thursday, March 14, 2024 10:14 PM, Michael Niedermayer wrote: > breaks mingw64 build > > CC libavformat/ip.o > src/libavformat/ip.c: In function ‘ff_ip_resolve_interface_index’: > src/libavformat/ip.c:206:1: error: control

Re: [FFmpeg-devel] [PATCH] doc/fate: advise on --assert-level=2

2024-03-18 Thread Nicolas Gaullier
>De : Nicolas Gaullier >Envoyé : mardi 12 mars 2024 13:09 >Objet : [PATCH] doc/fate: advise on --assert-level=2 > >diff --git a/doc/fate.texi b/doc/fate.texi index 2fa8c34c2d..17644ce65a 100644 >--- a/doc/fate.texi >+++ b/doc/fate.texi >@@ -79,6 +79,14 @@ Do not put a '~' character in the

[FFmpeg-devel] [PATCH] Changelog: mention ffplay with hwaccel decoding support

2024-03-18 Thread Zhao Zhili
From: Zhao Zhili --- Changelog | 1 + 1 file changed, 1 insertion(+) diff --git a/Changelog b/Changelog index e3ca52430c..c6e8f6bcaf 100644 --- a/Changelog +++ b/Changelog @@ -35,6 +35,7 @@ version : - AEA muxer - ffmpeg CLI loopback decoders - Support PacketTypeMetadata of PacketType in

[FFmpeg-devel] [PATCH v4 10/13] avcodec/aom_film_grain: add AOM film grain synthesis

2024-03-18 Thread Niklas Haas
From: Niklas Haas Implementation copied wholesale from dav1d, sans SIMD, under permissive license. This implementation was extensively verified to be bit-exact, so it serves as a much better starting point than trying to re-engineer this from scratch for no reason. (I also authored the original

Re: [FFmpeg-devel] [PATCH] doc/muxers: add flac

2024-03-18 Thread Stefano Sabatini
On date Tuesday 2024-03-12 22:17:36 +0100, Andreas Rheinhardt wrote: > Stefano Sabatini: > > --- > > doc/muxers.texi | 11 +++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/doc/muxers.texi b/doc/muxers.texi > > index de4b9b01f5..64d9221198 100644 > > --- a/doc/muxers.texi > >

[FFmpeg-devel] [PATCH 06/14] avcodec/vvcdec: misc, rename x_ctb, y_ctb, ctu_x, ctu_y to rx, ry to avoid misleading

2024-03-18 Thread Nuo Mi
--- libavcodec/vvc/vvc_ctu.c| 8 ++-- libavcodec/vvc/vvc_filter.c | 96 ++--- libavcodec/vvc/vvc_ps.c | 38 +++ 3 files changed, 71 insertions(+), 71 deletions(-) diff --git a/libavcodec/vvc/vvc_ctu.c b/libavcodec/vvc/vvc_ctu.c index

[FFmpeg-devel] [PATCH 09/14] avcodec/vvcdec: refact, movie the lc->sc assignment to task_run_stage to simplify the code

2024-03-18 Thread Nuo Mi
This change also make the lc->sc assigned for run_sao --- libavcodec/vvc/vvc_thread.c | 66 ++--- 1 file changed, 17 insertions(+), 49 deletions(-) diff --git a/libavcodec/vvc/vvc_thread.c b/libavcodec/vvc/vvc_thread.c index 5d2e8c67b9..8f23b8138b 100644 ---

[FFmpeg-devel] [PATCH 12/14] avcodec/vvcdec: alf, support subpicture

2024-03-18 Thread Nuo Mi
--- libavcodec/vvc/vvc_filter.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavcodec/vvc/vvc_filter.c b/libavcodec/vvc/vvc_filter.c index 6b4c2050c7..de0816619b 100644 --- a/libavcodec/vvc/vvc_filter.c +++ b/libavcodec/vvc/vvc_filter.c @@ -1199,6 +1199,7 @@ void

[FFmpeg-devel] [PATCH 10/14] avcodec/vvcdec: sao, refact out tile_edge arrays

2024-03-18 Thread Nuo Mi
--- libavcodec/vvc/vvc_filter.c | 36 ++-- 1 file changed, 14 insertions(+), 22 deletions(-) diff --git a/libavcodec/vvc/vvc_filter.c b/libavcodec/vvc/vvc_filter.c index ecb004d245..1a3cd02a9f 100644 --- a/libavcodec/vvc/vvc_filter.c +++

[FFmpeg-devel] [PATCH 11/14] avcodec/vvcdec: sao, support subpicture

2024-03-18 Thread Nuo Mi
--- libavcodec/vvc/vvc_filter.c | 40 + 1 file changed, 27 insertions(+), 13 deletions(-) diff --git a/libavcodec/vvc/vvc_filter.c b/libavcodec/vvc/vvc_filter.c index 1a3cd02a9f..6b4c2050c7 100644 --- a/libavcodec/vvc/vvc_filter.c +++

[FFmpeg-devel] [PATCH 13/14] avcodec/vvcdec: mvs, support subpicture

2024-03-18 Thread Nuo Mi
--- libavcodec/vvc/vvc_mvs.c | 33 + 1 file changed, 21 insertions(+), 12 deletions(-) diff --git a/libavcodec/vvc/vvc_mvs.c b/libavcodec/vvc/vvc_mvs.c index cf92202b5b..37a2d0a228 100644 --- a/libavcodec/vvc/vvc_mvs.c +++ b/libavcodec/vvc/vvc_mvs.c @@ -200,10

[FFmpeg-devel] [PATCH] fftools/ffplay: use correct buffersink channel layout parameters

2024-03-18 Thread Marton Balint
Regression since 0995e1f1b31f6e937a1b527407ed3e850f138098. Signed-off-by: Marton Balint --- fftools/ffplay.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 09b4846deb..fcd1319ce7 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@ -2040,6

[FFmpeg-devel] [PATCH v2 1/1] avformat/demux: Fix accurate probing of durations in mpegts/ps

2024-03-18 Thread Nicolas Gaullier
Two issues affect accuracy of duration in estimate_timings_from_pts(): - pkt->duration typically reports the duration of a single audio frame, whereas a pes often contain several audio frames - for video, compute_frame_duration() use r_frame_rate which is not reliable; typically, it is the

Re: [FFmpeg-devel] [PATCH] avformat: enable UDP IPv6 multicast interface selection

2024-03-18 Thread Michael Niedermayer
Hi On Mon, Mar 18, 2024 at 01:45:00PM +, Ignjatović, Lazar (RS)� wrote: > > This message has been marked as Public on 03/18/2024 13:45Z. > On Thursday, March 14, 2024 10:14 PM, Michael Niedermayer wrote: > > > breaks mingw64 build > > > > CC libavformat/ip.o > > src/libavformat/ip.c:

Re: [FFmpeg-devel] [PATCH 2/2] avformat/riffdec: follow the MS docs more strictly for setting wav channel layouts

2024-03-18 Thread Michael Niedermayer
On Sun, Mar 17, 2024 at 08:57:29PM +0100, Marton Balint wrote: > - Only parse the defined masks in dwChannelMask, unless strict_std_compliance > is less than normal. This matches with the behaviour of the wav muxer. > - Ignore additional bits in dwChannelMasks as the MS documentation suggests >

Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_vulkan: check PCI ID if possible

2024-03-18 Thread Xiang, Haihao
On Ma, 2024-03-18 at 18:41 +0100, Lynne wrote: > Mar 18, 2024, 08:27 by haihao.xiang-at-intel@ffmpeg.org: > > > From: Haihao Xiang > > > > Otherwise the derived device and the source device might have different > > PCI ID in a multiple-device system. > > > > Signed-off-by: Haihao Xiang >

Re: [FFmpeg-devel] [PATCH] doc/fate: advise on --assert-level=2

2024-03-18 Thread Michael Niedermayer
On Tue, Mar 12, 2024 at 01:09:20PM +0100, Nicolas Gaullier wrote: > Signed-off-by: Nicolas Gaullier > --- > doc/fate.texi | 8 > 1 file changed, 8 insertions(+) will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Let us carefully observe

Re: [FFmpeg-devel] [PATCH v3 2/2] lavc/get_buffer: Add a warning on failed allocation from a fixed pool

2024-03-18 Thread Mark Thompson
On 18/03/2024 05:53, Xiang, Haihao wrote: On So, 2024-03-17 at 20:51 +, Mark Thompson wrote: For hardware cases where we are forced to have a fixed pool of frames allocated up-front (such as array textures on decoder output), suggest a possible workaround to the user if an allocation fails

[FFmpeg-devel] [PATCH v10 14/14] avcodec/libx265: add support for writing out CLL and MDCV

2024-03-18 Thread Jan Ekström
The newer of these two are the separate integers for content light level, introduced in 3952bf3e98c76c31594529a3fe34e056d3e3e2ea , with X265_BUILD 75. As we already require X265_BUILD of at least 89, no further conditions are required. --- libavcodec/libx265.c | 89

[FFmpeg-devel] [PATCH v10 13/14] avcodec/libx264: add support for writing out CLL and MDCV

2024-03-18 Thread Jan Ekström
Both of these two structures were first available with X264_BUILD 163, so make relevant functionality conditional on the version being at least such. Keep handle_side_data available in all cases as this way X264_init does not require additional version based conditions within it. Finally, add a

[FFmpeg-devel] [PATCH v10 12/14] avcodec/libsvtav1: add support for writing out CLL and MDCV

2024-03-18 Thread Jan Ekström
These two were added in 28e23d7f348c78d49a726c7469f9d4e38edec341 and 3558c1f2e97455e0b89edef31b9a72ab7fa30550 for version 0.9.0 of SVT-AV1, which is also our minimum requirement right now. In other words, no additional version limiting conditions seem to be required. Additionally, add a FATE

[FFmpeg-devel] [PATCH v10 11/14] ffmpeg: pass first video AVFrame's side data to encoder

2024-03-18 Thread Jan Ekström
This enables further configuration of output based on the results of input decoding and filtering in a similar manner as the color information. --- fftools/ffmpeg_enc.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c index

[FFmpeg-devel] [PATCH v10 10/14] avcodec: add frame side data array to AVCodecContext

2024-03-18 Thread Jan Ekström
This allows configuring an encoder by using AVFrameSideData. --- doc/APIchanges | 3 +++ libavcodec/avcodec.h | 13 + libavcodec/options.c | 2 ++ libavcodec/version.h | 4 ++-- 4 files changed, 20 insertions(+), 2 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges

Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_vulkan: check PCI ID if possible

2024-03-18 Thread Lynne
Mar 18, 2024, 08:27 by haihao.xiang-at-intel@ffmpeg.org: > From: Haihao Xiang > > Otherwise the derived device and the source device might have different > PCI ID in a multiple-device system. > > Signed-off-by: Haihao Xiang > --- > libavutil/hwcontext_vulkan.c | 30

Re: [FFmpeg-devel] [PATCH v4] avformat/rcwtdec: add RCWT Closed Captions demuxer

2024-03-18 Thread Marth64
Bump on this small demuxer if possible. v4 in the last reply. Thank you. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org

Re: [FFmpeg-devel] [PATCH v3 1/2] lavc/vaapi_encode_h265: Map HEVC AV REXT profile to VA REXT profile

2024-03-18 Thread Mark Thompson
On 18/03/2024 04:21, fei.w.wang-at-intel@ffmpeg.org wrote: From: Fei Wang There is no Main8/10 profile defined in HEVC REXT profiles. Use Main12 which is compatible with 8/10bit. Signed-off-by: Fei Wang --- libavcodec/vaapi_encode_h265.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[FFmpeg-devel] [PATCH v10 06/14] avutil/frame: add helper for adding existing side data to array

2024-03-18 Thread Jan Ekström
--- libavutil/frame.c | 49 +++ libavutil/frame.h | 20 +++ 2 files changed, 69 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index e4c2fa4f6a..9d3eae4bae 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@

[FFmpeg-devel] [PATCH v10 05/14] avutil/frame: add helper for adding side data to array

2024-03-18 Thread Jan Ekström
Additionally, add an API test to check that the no-duplicates addition works after duplicates have been inserted. --- libavutil/Makefile| 1 + libavutil/frame.c | 17 + libavutil/frame.h | 22 +++ libavutil/tests/side_data_array.c | 103

[FFmpeg-devel] [PATCH v10 07/14] avutil/frame: add helper for adding side data w/ AVBufferRef to array

2024-03-18 Thread Jan Ekström
This was requested to be added in review. --- libavutil/frame.c | 43 ++- libavutil/frame.h | 21 + 2 files changed, 51 insertions(+), 13 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 9d3eae4bae..922185b823

[FFmpeg-devel] [PATCH v10 08/14] avutil/frame: add helper for getting side data from array

2024-03-18 Thread Jan Ekström
--- libavutil/frame.c | 20 +++- libavutil/frame.h | 14 ++ 2 files changed, 29 insertions(+), 5 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 922185b823..e8dfd4d926 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -830,16 +830,26 @@

[FFmpeg-devel] [PATCH v10 09/14] {avutil/version, APIchanges}: bump, document new AVFrameSideData functions

2024-03-18 Thread Jan Ekström
--- doc/APIchanges | 5 + libavutil/version.h | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index a44c8e4f10..4f906432d5 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -2,6 +2,11 @@ The last version increases of all libraries

[FFmpeg-devel] [PATCH v10 04/14] avutil/frame: split side data removal out to non-AVFrame function

2024-03-18 Thread Jan Ekström
This will make it possible to reuse logic in further commits. --- libavutil/frame.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 382e1f6d58..2a319adb86 100644 --- a/libavutil/frame.c +++

[FFmpeg-devel] [PATCH v10 03/14] avutil/frame: split side_data_from_buf to base and AVFrame func

2024-03-18 Thread Jan Ekström
--- libavutil/frame.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index baac0706db..382e1f6d58 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -679,23 +679,23 @@ AVBufferRef

Re: [FFmpeg-devel] [PATCH] fftools/ffplay: use correct buffersink channel layout parameters

2024-03-18 Thread James Almer
LGTM if tested. Sorry for the breakage. Please backport it to all the relevant release branches too. On Mon, Mar 18, 2024 at 5:20 PM Marton Balint wrote: > Regression since 0995e1f1b31f6e937a1b527407ed3e850f138098. > > Signed-off-by: Marton Balint > --- > fftools/ffplay.c | 2 ++ > 1 file

[FFmpeg-devel] [PATCH v2 0/1] avformat/demux: Fix accurate probing of durations in mpegts/ps

2024-03-18 Thread Nicolas Gaullier
v1: There was an issue with teletext where resolution is set just once at decoder init (teletext resolution is fixed/hard coded), so it is somewhat fragile: when a demuxer context update occurs, it is lost/overriden by avcodec_parameters_to_context(sti->avctx, st->codecpar) in

Re: [FFmpeg-devel] [PATCH v3 2/2] lavc/vaapi_encode_h265: Set general_*_constriaint flags with profile

2024-03-18 Thread Mark Thompson
On 18/03/2024 04:21, fei.w.wang-at-intel@ffmpeg.org wrote: From: Fei Wang According to Table A.2 in spec. Signed-off-by: Fei Wang --- libavcodec/vaapi_encode_h265.c | 176 +++-- 1 file changed, 123 insertions(+), 53 deletions(-) diff --git

[FFmpeg-devel] [PATCH v10 00/14] encoder AVCodecContext configuration side data

2024-03-18 Thread Jan Ekström
Differences to v9: 1. rebased on top of current master 2. renamed the avctx AVFrameSideData array according to Anton's naming sense, as at this point that is now OK by James as well and I just want to get this done with. 3. removed the avctx helper to get through review. 4. added "Afterwards

[FFmpeg-devel] [PATCH v10 01/14] avutil/frame: split side data list wiping out to non-AVFrame function

2024-03-18 Thread Jan Ekström
This will make it possible to to reuse logic in further commits. --- libavutil/frame.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index 079cf6595b..ab425b2235 100644 --- a/libavutil/frame.c +++

[FFmpeg-devel] [PATCH v10 02/14] avutil/frame: add helper for freeing arrays of side data

2024-03-18 Thread Jan Ekström
--- libavutil/frame.c | 5 + libavutil/frame.h | 11 +++ 2 files changed, 16 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index ab425b2235..baac0706db 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -78,6 +78,11 @@ static void

[FFmpeg-devel] [PATCH] avformat/flvenc: Avoid avio_write(pb, "", 0)

2024-03-18 Thread Andreas Rheinhardt
When the compiler chooses to inline put_amf_string(pb, ""), the avio_write(pb, "", 0) can be avoided. Happens with Clang-17 with -O1 and higher and GCC 13 with -O2 and higher here. Signed-off-by: Andreas Rheinhardt --- libavformat/flvenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[FFmpeg-devel] [PATCH 2/3] avformat/iamfenc: Align check and error message

2024-03-18 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/iamfenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/iamfenc.c b/libavformat/iamfenc.c index bf4a268c95..5e53a7748f 100644 --- a/libavformat/iamfenc.c +++ b/libavformat/iamfenc.c @@ -72,7 +72,7 @@ static int

[FFmpeg-devel] [PATCH 3/3] avformat/iamfenc: Remove unused headers

2024-03-18 Thread Andreas Rheinhardt
Forgotten in c95c8a0158073be84338d84c46529561bcc70a03. Signed-off-by: Andreas Rheinhardt --- libavformat/iamfenc.c | 5 - 1 file changed, 5 deletions(-) diff --git a/libavformat/iamfenc.c b/libavformat/iamfenc.c index 5e53a7748f..3169ff1eb8 100644 --- a/libavformat/iamfenc.c +++

[FFmpeg-devel] [PATCH 1/3] avformat/iamfenc: Remove always-false check

2024-03-18 Thread Andreas Rheinhardt
This muxer does not have the AVFMT_NOSTREAMS flag; therefore it is checked generically that there is at least a stream. Signed-off-by: Andreas Rheinhardt --- libavformat/iamfenc.c | 5 - 1 file changed, 5 deletions(-) diff --git a/libavformat/iamfenc.c b/libavformat/iamfenc.c index

Re: [FFmpeg-devel] [PATCH v3 2/2] lavc/get_buffer: Add a warning on failed allocation from a fixed pool

2024-03-18 Thread Xiang, Haihao
On Ma, 2024-03-18 at 21:33 +, Mark Thompson wrote: > On 18/03/2024 05:53, Xiang, Haihao wrote: > > On So, 2024-03-17 at 20:51 +, Mark Thompson wrote: > > > For hardware cases where we are forced to have a fixed pool of frames > > > allocated up-front (such as array textures on decoder