Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support for ROI-based encoding

2019-03-03 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Derek Buitenhuis > Sent: Friday, March 01, 2019 8:43 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support > f

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support for ROI-based encoding

2019-03-01 Thread James Zern
On Fri, Mar 1, 2019 at 4:51 AM Derek Buitenhuis wrote: > > On 01/03/2019 03:18, Guo, Yejun wrote: > > yes, that's the reason I pending VP9 work. As for VP8 ROI, another thinking > > is to first push vp8 roi, since libvpx is an external dependency and we > > don't > > know the time when it is avai

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support for ROI-based encoding

2019-03-01 Thread Derek Buitenhuis
On 01/03/2019 03:18, Guo, Yejun wrote: > yes, that's the reason I pending VP9 work. As for VP8 ROI, another thinking > is to first push vp8 roi, since libvpx is an external dependency and we don't > know the time when it is available for vp9 roi. Anyway, I'm open to both. Presumably the forthcomin

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support for ROI-based encoding

2019-02-28 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of James Zern > Sent: Friday, March 01, 2019 9:07 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libvp

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support for ROI-based encoding

2019-02-28 Thread James Zern
> > > > > +if (avctx->codec_id == AV_CODEC_ID_VP8) > > > +vp8_encode_set_roi(avctx, frame); > > > > The API only exists for VP8, or is this due to different quant scales or > > something? > > currently, VP9 ROI does not work, see my discussion at > https://groups.google.com/a/w

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support for ROI-based encoding

2019-02-28 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Derek Buitenhuis > Sent: Thursday, February 28, 2019 1:11 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support > f

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support for ROI-based encoding

2019-02-27 Thread Mark Thompson
On 27/02/2019 10:22, Gyan wrote: > On 27-02-2019 01:57 PM, Guo, Yejun wrote: >> >>> -Original Message- >>> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf >>> Of Guo, Yejun >>> Sent: Thursday, February 28, 2019 12:13 AM >>> To: ffmpeg-devel@ffmpeg.org >>> Subject: [FFm

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support for ROI-based encoding

2019-02-27 Thread Derek Buitenhuis
On 27/02/2019 17:57, Derek Buitenhuis wrote: > You're assuming a single ROI, though, which is only one case. Plenty of things > would need >1. Also note that sets of ROIs are per-frame. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support for ROI-based encoding

2019-02-27 Thread Derek Buitenhuis
On 27/02/2019 17:31, Gyan wrote: > Yes, a string. 4 integers and qp offset so either two more, in rational > form, or a float. You're assuming a single ROI, though, which is only one case. Plenty of things would need >1. > There's already multiple interfaces accepting long multi-entry > multi-v

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support for ROI-based encoding

2019-02-27 Thread Gyan
On 27-02-2019 10:32 PM, Derek Buitenhuis wrote: On 27/02/2019 13:48, Gyan wrote: Huh. I haven't suggested removing anything. I suggested *adding* a way for this feature to be useful for ffmpeg users in the near-term. Who knows how long will it take for a decent per-frame ROI filter, like the

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support for ROI-based encoding

2019-02-27 Thread Derek Buitenhuis
On 27/02/2019 16:12, Guo, Yejun wrote: > Signed-off-by: Guo, Yejun > --- > libavcodec/libvpxenc.c | 132 > + > 1 file changed, 132 insertions(+) Do these APIs exist for all supported libvpx versions? > +if (!sd) { > +if (vpx_codec_con

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support for ROI-based encoding

2019-02-27 Thread Derek Buitenhuis
On 27/02/2019 13:48, Gyan wrote: > Huh. I haven't suggested removing anything. > > I suggested *adding* a way for this feature to be useful for ffmpeg > users in the near-term. Who knows how long will it take for a decent > per-frame ROI filter, like the facedetect example mentioned in the > in

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support for ROI-based encoding

2019-02-27 Thread Gyan
On 27-02-2019 07:07 PM, Derek Buitenhuis wrote: On 27/02/2019 10:22, Gyan wrote: Looks like, at present, the only way to effect ROI is via side data, and no filter or other in-tree mechanism at present can convey or generate it. Life exists outside of ffmpeg.c, and it's an extremely useful AP

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support for ROI-based encoding

2019-02-27 Thread Derek Buitenhuis
On 27/02/2019 10:22, Gyan wrote: > Looks like, at present, the only way to effect ROI is via side data, and > no filter or other in-tree mechanism at present can convey or generate it. Life exists outside of ffmpeg.c, and it's an extremely useful API to have. > Are there any near-term plans to a

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support for ROI-based encoding

2019-02-27 Thread Gyan
On 27-02-2019 01:57 PM, Guo, Yejun wrote: -Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Guo, Yejun Sent: Thursday, February 28, 2019 12:13 AM To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support fo

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support for ROI-based encoding

2019-02-27 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Guo, Yejun > Sent: Thursday, February 28, 2019 12:13 AM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support for > ROI-based encoding > > Signed