Re: [FFmpeg-devel] [PATCH] lavfi: add erosion dilation filter

2015-02-27 Thread James Almer
On 27/02/15 5:19 AM, Paul B Mahol wrote: On 2/26/15, James Almer jamr...@gmail.com wrote: On 25/02/15 11:55 AM, Paul B Mahol wrote: +static inline void line_copy8(uint8_t *line, const uint8_t *srcp, int width, int mergin) Unless I'm missing something, mergin seems to always be 1. The code

Re: [FFmpeg-devel] [PATCH] lavfi: add erosion dilation filter

2015-02-27 Thread Paul B Mahol
On 2/26/15, James Almer jamr...@gmail.com wrote: On 25/02/15 11:55 AM, Paul B Mahol wrote: +static inline void line_copy8(uint8_t *line, const uint8_t *srcp, int width, int mergin) Unless I'm missing something, mergin seems to always be 1. The code below could be simplified. The function

Re: [FFmpeg-devel] [PATCH] lavfi: add erosion dilation filter

2015-02-27 Thread Paul B Mahol
On 2/26/15, Clement Boesch u...@pkh.me wrote: On Wed, Feb 25, 2015 at 02:55:58PM +, Paul B Mahol wrote: Signed-off-by: Paul B Mahol one...@gmail.com --- doc/filters.texi | 34 ++ libavfilter/Makefile | 2 + libavfilter/allfilters.c | 2 +

Re: [FFmpeg-devel] [PATCH] lavfi: add erosion dilation filter

2015-02-26 Thread James Almer
On 25/02/15 11:55 AM, Paul B Mahol wrote: +static inline void line_copy8(uint8_t *line, const uint8_t *srcp, int width, int mergin) Unless I'm missing something, mergin seems to always be 1. The code below could be simplified. +{ +memcpy(line, srcp, width); + +for (int i = mergin;

Re: [FFmpeg-devel] [PATCH] lavfi: add erosion dilation filter

2015-02-26 Thread Clément Bœsch
On Wed, Feb 25, 2015 at 02:55:58PM +, Paul B Mahol wrote: Signed-off-by: Paul B Mahol one...@gmail.com --- doc/filters.texi | 34 ++ libavfilter/Makefile | 2 + libavfilter/allfilters.c | 2 + libavfilter/vf_neighbor.c | 289

Re: [FFmpeg-devel] [PATCH] lavfi: add erosion dilation filter

2015-02-25 Thread Clément Bœsch
On Wed, Feb 25, 2015 at 02:55:58PM +, Paul B Mahol wrote: Signed-off-by: Paul B Mahol one...@gmail.com --- doc/filters.texi | 34 ++ libavfilter/Makefile | 2 + libavfilter/allfilters.c | 2 + libavfilter/vf_neighbor.c | 289

Re: [FFmpeg-devel] [PATCH] lavfi: add erosion dilation filter

2015-02-25 Thread Paul B Mahol
On 2/25/15, Clement Boesch u...@pkh.me wrote: On Wed, Feb 25, 2015 at 02:55:58PM +, Paul B Mahol wrote: Signed-off-by: Paul B Mahol one...@gmail.com --- doc/filters.texi | 34 ++ libavfilter/Makefile | 2 + libavfilter/allfilters.c | 2 +