Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

2019-05-23 Thread Peter Ross
On Tue, May 21, 2019 at 09:30:54PM +0200, Reimar Döffinger wrote: > On Tue, May 21, 2019 at 05:44:20PM +1000, Peter Ross wrote: > > +if (bits < 0x100) { > > +skip_bits(gb, 1); > > +} else if (bits < 0x180) { > > +skip_bits(gb, 2); > > +v += 1; > > +} > >

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

2019-05-23 Thread James Almer
On 5/23/2019 9:51 AM, Lynne wrote: > May 23, 2019, 12:22 PM by pr...@xvid.org: > >> On Tue, May 21, 2019 at 08:39:59PM +0200, Carl Eugen Hoyos wrote: >> >>> Am Di., 21. Mai 2019 um 19:18 Uhr schrieb Lynne : May 21, 2019, 8:44 AM by pr...@xvid.org : > ---

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

2019-05-23 Thread Lynne
May 23, 2019, 12:22 PM by pr...@xvid.org: > On Tue, May 21, 2019 at 08:39:59PM +0200, Carl Eugen Hoyos wrote: > >> Am Di., 21. Mai 2019 um 19:18 Uhr schrieb Lynne : >> > >> > May 21, 2019, 8:44 AM by pr...@xvid.org : >> > >> > > --- >> > > >> > > what's changed: >> > > *

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

2019-05-23 Thread Peter Ross
On Tue, May 21, 2019 at 11:34:34AM +0200, Tomas Härdin wrote: > tis 2019-05-21 klockan 17:44 +1000 skrev Peter Ross: > > --- > > > > what's changed: > > * apply #if CONFIG_VP4_DECODER around large vp4 code blocks > > * improved vp4_read_mb_value thanks to reminars suggestions > > * improved

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

2019-05-23 Thread Peter Ross
On Wed, May 22, 2019 at 09:45:46PM +0200, Reimar Döffinger wrote: > On Tue, May 21, 2019 at 09:30:54PM +0200, Reimar Döffinger wrote: > > > +#define SHIFT(v, shift) ((v) >> (shift)) > > > +#define ABS_SHIFT(v, shift) ((v) > 0 ? SHIFT(v, shift) : -SHIFT(-v, > > > shift)) > > > > Don't we have

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

2019-05-23 Thread Peter Ross
On Tue, May 21, 2019 at 08:38:02PM +0200, Reimar Döffinger wrote: > On Tue, May 21, 2019 at 11:15:03AM -0300, James Almer wrote: > > > I have a feeling this loop should have a stop condition like v < > > > SOME_LARGE_VALUE, say INT_MAX-255 or yuv_macroblock_count, to reject > > > corrupt/malicious

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

2019-05-23 Thread Peter Ross
On Tue, May 21, 2019 at 08:42:17PM +0200, Carl Eugen Hoyos wrote: > Am Di., 21. Mai 2019 um 09:45 Uhr schrieb Peter Ross : > > > diff --git a/configure b/configure > > index 9b4305cf0d..61eb774116 100755 > > --- a/configure > > +++ b/configure > > @@ -2825,6 +2825,7 @@

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

2019-05-23 Thread Peter Ross
On Tue, May 21, 2019 at 08:39:59PM +0200, Carl Eugen Hoyos wrote: > Am Di., 21. Mai 2019 um 19:18 Uhr schrieb Lynne : > > > > May 21, 2019, 8:44 AM by pr...@xvid.org : > > > > > --- > > > > > > what's changed: > > > * apply #if CONFIG_VP4_DECODER around large vp4 code blocks

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

2019-05-22 Thread Reimar Döffinger
On Tue, May 21, 2019 at 09:30:54PM +0200, Reimar Döffinger wrote: > > +#define SHIFT(v, shift) ((v) >> (shift)) > > +#define ABS_SHIFT(v, shift) ((v) > 0 ? SHIFT(v, shift) : -SHIFT(-v, shift)) > > Don't we have something like that already? Seems we don't > I think this should rather be: > (v -

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

2019-05-21 Thread James Almer
On 5/21/2019 3:42 PM, Carl Eugen Hoyos wrote: > Am Di., 21. Mai 2019 um 09:45 Uhr schrieb Peter Ross : > >> diff --git a/configure b/configure >> index 9b4305cf0d..61eb774116 100755 >> --- a/configure >> +++ b/configure >> @@ -2825,6 +2825,7 @@ vc1image_decoder_select="vc1_decoder" >>

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

2019-05-21 Thread Reimar Döffinger
On Tue, May 21, 2019 at 05:44:20PM +1000, Peter Ross wrote: > +if (bits < 0x100) { > +skip_bits(gb, 1); > +} else if (bits < 0x180) { > +skip_bits(gb, 2); > +v += 1; > +} > +#define body(n) { \ > +skip_bits(gb, 2 + n); \ > +v += (1 << n) + get_bits(gb,

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

2019-05-21 Thread Reimar Döffinger
On Tue, May 21, 2019 at 11:15:03AM -0300, James Almer wrote: > > I have a feeling this loop should have a stop condition like v < > > SOME_LARGE_VALUE, say INT_MAX-255 or yuv_macroblock_count, to reject > > corrupt/malicious files and not cause undefined behavior > > Using get_bits_left(gb) would

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

2019-05-21 Thread Carl Eugen Hoyos
Am Di., 21. Mai 2019 um 09:45 Uhr schrieb Peter Ross : > diff --git a/configure b/configure > index 9b4305cf0d..61eb774116 100755 > --- a/configure > +++ b/configure > @@ -2825,6 +2825,7 @@ vc1image_decoder_select="vc1_decoder" > vorbis_decoder_select="mdct" >

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

2019-05-21 Thread Carl Eugen Hoyos
Am Di., 21. Mai 2019 um 19:18 Uhr schrieb Lynne : > > May 21, 2019, 8:44 AM by pr...@xvid.org : > > > --- > > > > what's changed: > > * apply #if CONFIG_VP4_DECODER around large vp4 code blocks > > * improved vp4_read_mb_value thanks to reminars suggestions > > * improved

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

2019-05-21 Thread Lynne
May 21, 2019, 8:44 AM by pr...@xvid.org : > --- > > what's changed: > * apply #if CONFIG_VP4_DECODER around large vp4 code blocks > * improved vp4_read_mb_value thanks to reminars suggestions > * improved configure vp3_decoder_select > > > Changelog |1 + >

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

2019-05-21 Thread James Almer
On 5/21/2019 6:34 AM, Tomas Härdin wrote: > tis 2019-05-21 klockan 17:44 +1000 skrev Peter Ross: >> --- >> >> what's changed: >> * apply #if CONFIG_VP4_DECODER around large vp4 code blocks >> * improved vp4_read_mb_value thanks to reminars suggestions >> * improved configure vp3_decoder_select >>

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

2019-05-21 Thread Tomas Härdin
tis 2019-05-21 klockan 17:44 +1000 skrev Peter Ross: > --- > > what's changed: > * apply #if CONFIG_VP4_DECODER around large vp4 code blocks > * improved vp4_read_mb_value thanks to reminars suggestions > * improved configure vp3_decoder_select > > [...] >   > +#define BLOCK_X (2 * mb_x + (k &