t you need is a way to differentiate between "must not change" and "I
don't care" areas, but the current layout system provides no way to do
that. Traditionally "-i" is interpreted as declaring everything outside
as &
ge comes to my mind, although I understand that loading the
"-C" can well be performed after programmer initialization, but
initializing the emulated dummy flash chip is done during programmer
initialization. I still tend to work around that in code (i.e. having
the -C load
dress bits A18–A11 are don’t cares for
unlock and command cycles, unless SA or PA required." 0x2800 (the
additional Bits in 0x2AAA compared to 0x2AA) are bits A11 and A13, so
this chip just doesn't care.
Regards,
Michael Karcher
___
flashrom mailing list
flashrom@flashrom.org
http://www.flashrom.org/mailman/listinfo/flashrom
the FIXME comment into the validator declaration.
-struct pci_dev *pcidev_init(const struct dev_entry *devs, int bar);
+struct pci_dev *pcidev_init(const struct dev_entry *devs, int (*validator)
(struct pci_dev *dev));
typedef, as above.
Regards,
Michael Karcher
the right way (TM)
- loose the autoskip of disabled PCI devices
Regards,
Michael Karcher
___
flashrom mailing list
flashrom@flashrom.org
http://www.flashrom.org/mailman/listinfo/flashrom
.
Do we want to use the chance and replace the exit(1) in get_io_perms by
a return value?
Signed-off-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2...@gmx.net
Acked-by: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
Regards,
Michael Karcher
pci_read_long(...) ~7; invocations to
read BARs.
So the final vote is:
If you rename pcidev_validate to pcidev_readbar, this is
Acked-by: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
[1]: Remember the old saying: Never check for an error condition you
don't know how to handle
On Sat, 2012-05-05 at 21:15 +0200, Carl-Daniel Hailfinger wrote:
Am 01.05.2012 01:28 schrieb Michael Karcher:
Signed-off-by: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
Thanks for the documentation patch.
Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2...@gmx.net
Thanks
+#if CONFIG_PONY_SPI == 1
+ msg_ginfo(\nSupported devices for the %s programmer:\n,
+ programmer_table[PROGRAMMER_PONY_SPI].name);
+ /* FIXME */
+ msg_ginfo(SI-Prog serial port programmer\n);
Add serbang here, too.
Regards,
Michael Karcher
@@
}
if (!tmp)
msg_pdbg(Empty write\n);
- writecnt -= tmp;
+ writecnt -= tmp;
buf += tmp;
}
unrelated whitespace change.
Regards,
Michael Karcher
___
flashrom mailing list
.
the header in http://packages.slackverse.org/?v=3p=316 includes
linux/types.h itself at the top (as expected). can you explain why
yours does not?
Old kernel headers. We already fixed that incompatibility in r1517,
which is shortly after 0.9.5.2
Regards,
Michael Karcher
in the Appendix of the BIOS Boot Specification (which is
available copious times in the Internet).
Regards,
Michael Karcher
___
flashrom mailing list
flashrom@flashrom.org
http://www.flashrom.org/mailman/listinfo/flashrom
, so interesting fields do again line up.
For the suggested window size, I think carldani's value 100 would be a
good start.
Regards,
Michael Karcher
___
flashrom mailing list
flashrom@flashrom.org
http://www.flashrom.org/mailman/listinfo/flashrom
Am Dienstag, den 06.03.2012, 00:41 +0100 schrieb Stefan Tauner:
Signed-off-by: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
Acked-by: Stefan Tauner stefan.tau...@student.tuwien.ac.at
Thanks, this is r1513 now, after incorporating your suggestions. I
skipped the ?: idea, as using
(written) before reading data, so there is no such thing as
a pure-read transaction.
Signed-off-by: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
---
linux_spi.c | 10 +-
1 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/linux_spi.c b/linux_spi.c
index d994389
Am Freitag, den 02.03.2012, 00:43 +0100 schrieb Stefan Tauner:
Previously we relied on a correctly set up state.
Looks good. Still untested, though.
Signed-off-by: Stefan Tauner stefan.tau...@student.tuwien.ac.at
Acked-by: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
A test would
-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2...@gmx.net
Acked-by: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
Regards,
Michael Karcher
___
flashrom mailing list
flashrom@flashrom.org
http://www.flashrom.org/mailman/listinfo/flashrom
with the same image, and
attach the log of the write process to the mail, too.
Regards,
Michael Karcher
___
flashrom mailing list
flashrom@flashrom.org
http://www.flashrom.org/mailman/listinfo/flashrom
Signed-off-by: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
---
board_enable.c |2 ++
print.c|1 +
2 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/board_enable.c b/board_enable.c
index 06bbd70..2b682ea 100644
--- a/board_enable.c
+++ b/board_enable.c
Am Samstag, den 11.02.2012, 21:14 +0100 schrieb Michael Karcher:
Signed-off-by: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
Acked-by: Stefan Tauner stefan.tau...@student.tuwien.ac.at
(ack via IRC Feb 11, 23:14 GMT)
Stefan: Thanks for the ack!
+ {0x8086, 0x7120, 0x109f, 0x3157
Am Donnerstag, den 22.12.2011, 08:15 +0100 schrieb Michael Karcher:
Signed-off-by: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
self-review :)
+ while( chipcount ARRAY_SIZE(flashes) ) {
wrong spacing convention, as Stefan Tauner already pointed out in v1 of
the patch
Hello fellow developers,
attached is a private mail I received that contains a successful write
on a board with a MCP73 south bridge. The successful erase report by the
same author already went to the flashrom list. I guess, we can mark
MCP73 as tested now.
Regards,
Michael Karcher
Am Freitag, den 23.12.2011, 00:24 +0100 schrieb Carl-Daniel Hailfinger:
Am 22.12.2011 08:28 schrieb Michael Karcher:
Am Donnerstag, den 22.12.2011, 08:15 +0100 schrieb Michael Karcher:
Signed-off-by: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
+while (chipcount
As reported by Stefan Tauner on IRC, the new programmer-centric logic
is broken by re-using occupied members of the flashes array when changing
to the next programmer. This fixes it
Signed-off-by: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
---
cli_classic.c | 15 +--
1
idea.
Signed-off-by: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
---
cli_classic.c |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/cli_classic.c b/cli_classic.c
index 543b644..6580f7f 100644
--- a/cli_classic.c
+++ b/cli_classic.c
@@ -451,11 +451,12 @@ int
.
Please post the output of
lspci -nnvvvxxx (run as root)
Thanks in advance,
Michael Karcher
___
flashrom mailing list
flashrom@flashrom.org
http://www.flashrom.org/mailman/listinfo/flashrom
, und dann
sudo flashrom -w GF7100-M3_080707.ROM
ausführen, um das BIOS neu zu programmieren. Wenn flashrom VERIFIED am
Ende ausgibt, ist das System wieder in einem Zustand, in dem es einen
Neustart übersteht.
Regards hoping that this mail is not too late,
Michael Karcher
(Grüße in der Hoffnung
.
TODO: split the flash chip list into SPI and non-SPI lists. No need to
iterate over the other type and skip those chips because of bus
mismatches. Do it later.
Signed-off-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2...@gmx.net
Acked-by: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
Am Freitag, den 16.12.2011, 14:41 +0100 schrieb Carl-Daniel Hailfinger:
No functional changes. Please test anyway on real hardware.
flashrom -r works on my laptop (ICH7, SPI)
Signed-off-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2...@gmx.net
Acked-by: Michael Karcher flash
would make more
sense.
The superflous comment issue, the NULL pointer on each spi call
issue, and the orphaned noop issue are not something that blocks
acking the patch.
Regards,
Michael Karcher
From ecdafa1b90bf6f0f3f0f4be8ea3a26ac1de05d04 Mon Sep 17 00:00:00 2001
From: Carl-Daniel Hailfinger c
tedious work on that!
Signed-off-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2...@gmx.net
Acked-by: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
+ /* Check that virtual_memory in struct flashctx is placed directly
+ * after the members copied from struct flashchip
this.
Looks fine so far. So go ahead and commit.
Acked-By: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
Regards,
Michael Karcher
signature.asc
Description: This is a digitally signed message part
___
flashrom mailing list
flashrom
= unknown SPI chip (REMS),
This extra line has already be claimed by Stefan Tauner - it's not yours
anymore! ;)
Signed-off-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2...@gmx.net
If you remove the strings.h include or provide a good reason for it, this is
Acked-by: Michael Karcher flash
want to check that the function pointers in pgm are not NULL,
to make the suggested error message without register_opaque more apt.
Otherwise, the patch looks good to me. This is
Acked-By: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
If you feel confident you didn't mess up anything, feel
Am Dienstag, den 26.07.2011, 18:40 +0200 schrieb Carl-Daniel Hailfinger:
We finally have everything committed, and can now release 0.9.4 and then
merge a few riskier patches.
Sounds like a good idea.
Acked-by: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
Thanks to all contributors
was too quick here, and committed after just fixing the first
one. I think this should go in the next cleanup commit or so, or should
we fix that immediately?
Regards,
Michael Karcher
___
flashrom mailing list
flashrom@flashrom.org
http
The usage of the GPIO output register as bitmap can be confirmed from the
vendor board enable code, so the comment has been deleted. It really is
(1gpionumber).
lspci: http://paste.flashrom.org/view.php?id=729
superiotool: http://paste.flashrom.org/view.php?id=730
Signed-off-by: Michael Karcher
(And that is years before
Turbo C++ 2.0)
Regards,
Michael Karcher
___
flashrom mailing list
flashrom@flashrom.org
http://www.flashrom.org/mailman/listinfo/flashrom
This is especially important for the SST FWH compatible chips with 4K sector
size, where status printing for that small size was omitted up to r1347.
Signed-off-by: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
---
82802ab.c |3 ++-
sharplhf00l04.c |6 --
sst49lfxxxc.c
*sector* erase procedure that just was
changed in this commit is for 4k sectors, so dumping the status here is
much more excessive as in the other cases - probably that's the reason
why the status printing was not in.
Regards,
Michael Karcher
___
flashrom
referenced in the
LHF00L04 entry.
Finally, this adds a comment that there are non-volatile (flash memory)
lock bits for 8 sectors in the last 64KB. They are write-only and clearable
at once. Readback seems unsupported.
Signed-off-by: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
---
Makefile
this table
mentions anything about bits affecting only 8KB sized areas.
On the other hand, text of the data sheet nowhere mentions the
sectorwise locking - it is just in the table. I have no idea how to read
that.
Regards,
Michael Karcher
___
flashrom
can be
avoided inside -if CONFIG_INTERNAL.
Signed-off-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2...@gmx.net
The patch looks good.
Acked-by: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
Regards,
Michael Karcher
___
flashrom mailing
Am Mittwoch, den 11.05.2011, 17:27 +0200 schrieb Carl-Daniel Hailfinger:
Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2...@gmx.net
Thanks for the review and the discussion. This is r1299.
Regards,
Michael Karcher
___
flashrom mailing list
Am Donnerstag, den 05.05.2011, 20:47 +0200 schrieb Carl-Daniel
Hailfinger:
Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2...@gmx.net
Thanks for reviewing and acknowledging, this is r1298.
Regards,
Michael Karcher
___
flashrom mailing list
. And that's intentional. With iopl() you are able
not only to flash a BIOS rootkit, but also for example to write random
data to random sectors of parallel ATA hard drives. The latter also
works with ioperm in typical PC configurations.
Regards,
Michael Karcher
is that the dummyflasher has a variable maximal chunk
size specified on the command line, so no constant value can do. Of
course patching the programmer structure instead and using the default
write function is an option.
Regards,
Michael Karcher
no problem with the
union approach, too.
Thanks for your review,
Michael Karcher
___
flashrom mailing list
flashrom@flashrom.org
http://www.flashrom.org/mailman/listinfo/flashrom
stefan.tau...@student.tuwien.ac.at
Thanks for writing and acking.
Committed in r1295.
Regards,
Michael Karcher
___
flashrom mailing list
flashrom@flashrom.org
http://www.flashrom.org/mailman/listinfo/flashrom
are your thoughts about this?
BACKUP IDEA:
If the precious region stuff seems as overdesigned, we should abort as
soon as we find any non-rw region on the ichspi driver.
Regards,
Michael Karcher
___
flashrom mailing list
flashrom@flashrom.org
for other operations (i.e. r/o or locked regions).
Who will make a patch for that, me or you?
Regards,
Michael Karcher
___
flashrom mailing list
flashrom@flashrom.org
http://www.flashrom.org/mailman/listinfo/flashrom
Signed-off-by: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
---
bitbang_spi.c | 11 --
buspirate_spi.c | 10 -
dummyflasher.c |6 ---
ft2232_spi.c| 11 --
ichspi.c| 20 ---
it85spi.c | 10 -
programmer.h| 21
This is to prepare the SPI registration patch without needing to do forward
declarations.
Signed-off-by: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
---
bitbang_spi.c | 84 +-
buspirate_spi.c | 182 +++---
dummyflasher.c | 264
Remove the array spi_programmer, replace it by dynamic registration
instead. Also initially start with no busses supported, and switch to
the default non-SPI only for the internal programmer.
Signed-off-by: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
---
bitbang_spi.c | 14
Signed-off-by: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
---
ichspi.c | 22 ++
1 files changed, 18 insertions(+), 4 deletions(-)
diff --git a/ichspi.c b/ichspi.c
index ed92893..db5ec75 100644
--- a/ichspi.c
+++ b/ichspi.c
@@ -572,7 +572,14 @@ static int
Am Samstag, den 30.04.2011, 00:07 +0200 schrieb Carl-Daniel Hailfinger:
Am 29.04.2011 16:01 schrieb Michael Karcher:
Signed-off-by: Michael Karcherflash...@mkarcher.dialup.fu-berlin.de
Thanks for the patch and for tracking this down and for writing a
thorough analysis!
Acked
,
Michael Karcher
___
flashrom mailing list
flashrom@flashrom.org
http://www.flashrom.org/mailman/listinfo/flashrom
result;
Acked-by: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
moved int i one line up and committed in r1291
Regards,
Michael Karcher
___
flashrom mailing list
flashrom@flashrom.org
http://www.flashrom.org/mailman/listinfo/flashrom
-by: is missing
He had it in the original patch, but was told that as most code in that
patch was not written by him, he can not sign off that. Please see the
end of
http://www.coreboot.org/pipermail/flashrom/2011-April/006252.html
Regards,
Michael Karcher
signature.asc
Description: This is a digitally
programmed prefix opcodes. So 2 does not mean both, but preop1.
Regards,
Michael Karcher
___
flashrom mailing list
flashrom@flashrom.org
http://www.flashrom.org/mailman/listinfo/flashrom
feature of the chipset. Or we need to stop using atomic
sequences.
Regards,
Michael Karcher
___
flashrom mailing list
flashrom@flashrom.org
http://www.flashrom.org/mailman/listinfo/flashrom
Am Donnerstag, den 07.04.2011, 18:40 +0200 schrieb Stefan Reinauer:
* Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
Not every OS has a unix command interpreter. This will break on
DOS. Most likely fine if DOS is detected per ifdef.
Ok, how about this one?
Signed-off-by: Stefan
likely fine if DOS is detected per ifdef.
Regards,
Michael Karcher
___
flashrom mailing list
flashrom@flashrom.org
http://www.flashrom.org/mailman/listinfo/flashrom
Reported by: wickb...@student.chalmers.se
flashrom -V: http://paste.flashrom.org/view.php?id=452
lspci: http://paste.flashrom.org/view.php?id=453
(note that the flashrom dump is with a foreign chip. That
board is originally equipped with an PMC Pm49FL004.
Signed-off-by: Michael Karcher flash
problem. Maybe the need for retrying on
these chips is normal, or our toggle-bit code terminates early...
Regards,
Michael Karcher
___
flashrom mailing list
flashrom@flashrom.org
http://www.flashrom.org/mailman/listinfo/flashrom
address
0x%lx, base);
- } else {
+ } else
+#endif
+ {
snprintf(location, sizeof(location), on %s,
programmer_table[programmer].name);
Acked-by: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
Regards,
Michael Karcher
Am Freitag, den 04.03.2011, 20:27 +0100 schrieb Carl-Daniel Hailfinger:
Auf 03.03.2011 23:42, Michael Karcher schrieb:
Reported by: Michal Janke jank...@gmail.com
Signed-off-by: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
Thanks for reverse engineering this board enable
Am Sonntag, den 06.03.2011, 00:26 +0100 schrieb Carl-Daniel Hailfinger:
flashrom -V: http://paste.flashrom.org/view.php?id=326
lspic: http://paste.flashrom.org/view.php?id=328
superiotool: http://paste.flashrom.org/view.php?id=329
Signed-off-by: Michael Karcher flash
Am Sonntag, den 06.03.2011, 00:25 +0100 schrieb Carl-Daniel Hailfinger:
Michael, if you add a signoff, this is
Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2...@gmx.net
Signed-off and committed as r1268.
Thanks for reviewing,
Michael Karcher
-d.hailfinger.devel.2...@gmx.net
Comitted in 1267, thanks for your review.
Regards,
Michael Karcher
___
flashrom mailing list
flashrom@flashrom.org
http://www.flashrom.org/mailman/listinfo/flashrom
It is extremely unlikely that a chip not requiring delays in probe does
require them in erase. We observed unreliable erasing with a SST49LF004A
with these delays, so remove them if the are not required.
Signed-off-by: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
---
jedec.c | 33
the flashrom
coding style in some places - I send it out to catch some early reviews
on it.
Signed-off-by: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
---
Makefile | 14 +++
flashrom.c | 24 -
mediatek.c | 350
knowledge should take a look at the
sysfs related stuff.
Yeah, that's a good idea. Maybe that code profits from some comments
telling the expected position in the device tree.
Thank you for the review. I will send an improved patch soon.
Regards,
Michael Karcher
Am Montag, den 07.03.2011, 02:44 +0100 schrieb Michael Karcher:
flashrom -V -w: http://paste.flashrom.org/view.php?id=389
Sorry, that's without -V. See here:
http://paste.flashrom.org/view.php?id=394
Regards,
Michael Karcher
___
flashrom mailing
Am Montag, den 07.03.2011, 01:59 +0100 schrieb Carl-Daniel Hailfinger:
Auf 07.03.2011 02:44, Michael Karcher schrieb:
flashrom -V -w: http://paste.flashrom.org/view.php?id=389
Signed-off-by: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
Acked-by: Carl-Daniel Hailfinger c
to change the toggle bit stuff or use the non-slow call. Do I
miss something?
Regards,
Michael Karcher
___
flashrom mailing list
flashrom@flashrom.org
http://www.flashrom.org/mailman/listinfo/flashrom
on an alternate erase
method. Can you provide verbose logs of what you describe here, please?
Regards,
Michael Karcher
___
flashrom mailing list
flashrom@flashrom.org
http://www.flashrom.org/mailman/listinfo/flashrom
-by: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
---
board_enable.c | 29 +++--
1 files changed, 23 insertions(+), 6 deletions(-)
diff --git a/board_enable.c b/board_enable.c
index 5776bf5..26c5fbc 100644
--- a/board_enable.c
+++ b/board_enable.c
@@ -543,7 +543,10
to a reply to this mail or upload to
paste.flashrom.org.
This mail has been cc'ed to the coreboot list for getting this patch
included into superiotool. If something is wrong with that patch, please
Cc: me, as I am not subscribed to the coreboot list. Thanks.
Regards,
Michael Karcher
Add
list of PCI IDs for nvidia southbridges.
flashrom -V: http://paste.flashrom.org/view.php?id=326
lspic: http://paste.flashrom.org/view.php?id=328
superiotool: http://paste.flashrom.org/view.php?id=329
Signed-off-by: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
---
board_enable.c |4
: Extend list of PCI IDs for nvidia southbridges.
flashrom -V: http://paste.flashrom.org/view.php?id=326
lspic: http://paste.flashrom.org/view.php?id=328
superiotool: http://paste.flashrom.org/view.php?id=329
Signed-off-by: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
---
board_enable.c
+ (addr 0x3));
+}
Do we need to call the I/O address region BAR1 if its address is
stored at PCI_BASE_ADDRESS2? That sounds confusing.
Regards,
Michael Karcher
___
flashrom mailing list
flashrom@flashrom.org
http://www.flashrom.org/mailman/listinfo
.
flashrom -V: http://paste.flashrom.org/view.php?id=326
lspic: http://paste.flashrom.org/view.php?id=328
superiotool: http://paste.flashrom.org/view.php?id=329
Signed-off-by: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
---
board_enable.c |4 +++-
print.c|1 +
2 files
. In that case, of one chip, only the EC code and of the other chip,
only the non-EC code would be used. But that doesn't make sense with
your observation that it doesn't work after cloning the old BIOS.
Any help, thoughts you could give me would be of great help
Regards,
Michael Karcher
with the
contents of a file given at the command line.
Regards,
Michael Karcher
___
flashrom mailing list
flashrom@flashrom.org
http://www.flashrom.org/mailman/listinfo/flashrom
Am Montag, den 10.01.2011, 11:26 -0500 schrieb Dan Perry:
You are looking at the *source* code of a unix manual page. Please use
man -l flashrom.8 instead to read that file in a formatted way.
Regards,
Michael Karcher
Thanks for the reply, but where is that?
Where is what? The file
in a formatted way.
Regards,
Michael Karcher
signature.asc
Description: This is a digitally signed message part
___
flashrom mailing list
flashrom@flashrom.org
http://www.flashrom.org/mailman/listinfo/flashrom
Am Mittwoch, den 05.01.2011, 12:59 +0300 schrieb Jon Shadow:
Fixed a few things. Still need someone to test it.
Signed-off-by: Sergey Lichack shadowpilo...@gmail.com
Code looks fine to me, as soon as it is tested, it is:
Acked-by: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
Regards
on a board rev 1.85.
Tested on a rev 1.06 board.
Could you still please add a second device (keep the subsystem IDs zero
if there are none) to the match? I would recommend the LPC bridge, as
the GPIO pins reside in that chip.
Regards,
Michael Karcher
file to use
uint32_t/uint16_t/uint8_t
instead of u8/u16/u32, as the former types are used throughout
flashrom.
Patch v2.
Committed as r1249.
Thanks for your patch.
Regards,
Michael Karcher
___
flashrom mailing list
Am Sonntag, den 26.12.2010, 23:59 +0100 schrieb Idwer Vollering:
Resending as requested, updated to HEAD too.
Thanks for that!
Signed-off-by: Idwer Vollering vid...@gmail.com
Acked-by: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
This is r1248, thanks for adding this feature!
Regards
Hello Ivan,
this patch should add support for the W39L040 chip to flashrom. Please
try it on your hardware. If you can't compile flashrom yourself, ask
on the mailing list or our IRC channel (#flashrom on freenode).
Regards,
Michael Karcher
---
chipdrivers.h |1 +
flashchips.c | 30
be needed to find out whether it is
OK to skip the boot block if they are different.
Regards,
Michael Karcher
___
flashrom mailing list
flashrom@flashrom.org
http://www.flashrom.org/mailman/listinfo/flashrom
Am Sonntag, den 05.12.2010, 16:16 +0100 schrieb Carl-Daniel Hailfinger:
Acked-by: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
Thanks for the detailed review. New patch follows.
Clean up erase function checking.
Signed-off-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2
Am Sonntag, den 05.12.2010, 23:56 +0100 schrieb Carl-Daniel Hailfinger:
Simplify get_next_write in the partial write code.
Suggested by Michael Karcher.
Signed-off-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2...@gmx.net
Index: flashrom-partial_write_get_next_write_simplify
the comment in here: The w39v080fa does not have the
software boot block lock feature if I skimmed over the datasheet
correctly, and the software boot block lock other chips have is
permanent and can not be cleared.
Acked-by: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
Regards,
Michael
erase function is pointless.
+ */
+ break;
+ }
This change looks fine.
As my only nitpicks were about coding style and log verbosity, and I
don't see any technical problems:
Acked-by: Michael Karcher flash...@mkarcher.dialup.fu-berlin.de
.
+ msg_pdbg(Trying External DMI decoder.\n);
s/Trying/Using/
Regards,
Michael Karcher
___
flashrom mailing list
flashrom@flashrom.org
http://www.flashrom.org/mailman/listinfo/flashrom
Am Dienstag, den 16.11.2010, 17:27 +0100 schrieb Carl-Daniel Hailfinger:
Thanks to Michael Karcher for reviewing the patch and pointing out a
missing abort on read failure.
+ ret = flash-read(flash, readbuf, start, len);
+ if (ret) {
+ msg_gerr(Verification impossible
, but frozen)
version 0.9.3 (internal revision code 1204) from
http://qa.coreboot.org/snapshots/flashrom-0.9.3-r1204.tar.bz2
Read the installation from source section in
http://flashrom.org/Downloads
Regards,
Michael Karcher
___
flashrom mailing list
1 - 100 of 411 matches
Mail list logo
