[Flightgear-devel] AirportList
OK, I appear to have the Select Airport from List
option working properly (as far as I can tell). I'm
not completely happy with the solution, as I have had
to declare a constant for PUCLASS_LIST that could be
reassigned within plib. I have used a value at the top
end of the scale to try to reduce the risk, but it is
still possible that this could be broken by changes to
plib.
I'll include the diffs here in case this is worth
using, or in case anyone would like to offer any
advice or suggestions.
regards
Andrew
Index: GUI/AirportList.cxx
===
RCS file:
/var/cvs/FlightGear-0.9/source/src/GUI/AirportList.cxx,v
retrieving revision 1.8
diff -r1.8 AirportList.cxx
25c25
---
44c44
AirportList::getStringValue ()
---
AirportList::getListStringValue ()
46c46
return (char
*)_airports-getAirport(getIntegerValue())-_id.c_str();
---
return (char
*)_airports-getAirport(getListIntegerValue())-_id.c_str();
Index: GUI/AirportList.hxx
===
RCS file:
/var/cvs/FlightGear-0.9/source/src/GUI/AirportList.hxx,v
retrieving revision 1.1
diff -r1.1 AirportList.hxx
18c18
virtual char * getStringValue ();
---
virtual char * getListStringValue ();
Index: GUI/dialog.cxx
===
RCS file:
/var/cvs/FlightGear-0.9/source/src/GUI/dialog.cxx,v
retrieving revision 1.17
diff -r1.17 dialog.cxx
138c138,147
node-setStringValue(object-getStringValue());
---
// Special case to handle lists, as
getStringValue cannot be overridden
if(object-getType() PUCLASS_LIST)
{
node-setStringValue(((puList *)
object)-getListStringValue());
}
else
{
node-setStringValue(object-getStringValue());
}
401c410
return puTextBox;
---
return puTextBox;
Index: GUI/puList.cxx
===
RCS file:
/var/cvs/FlightGear-0.9/source/src/GUI/puList.cxx,v
retrieving revision 1.1
diff -r1.1 puList.cxx
55a56
type |= PUCLASS_LIST;
61a63
type |= PUCLASS_LIST;
78c80
puList::getStringValue ()
---
puList::getListStringValue ()
82a85,90
int
puList::getListIntegerValue()
{
return _list_box-getIntegerValue();
}
Index: GUI/puList.hxx
===
RCS file:
/var/cvs/FlightGear-0.9/source/src/GUI/puList.hxx,v
retrieving revision 1.4
diff -r1.4 puList.hxx
11a12,13
# define PUCLASS_LIST 0x8000 // Hopefully
this value will never be used by plib
27c29,30
virtual char * getStringValue ();
---
virtual char * getListStringValue ();
virtual int getListIntegerValue();
Index: gui/dialogs/airports.xml
===
RCS file:
/var/cvs/FlightGear-0.9/data/gui/dialogs/airports.xml,v
retrieving revision 1.3
diff -r1.3 airports.xml
1c1
?xml version=1.0?
---
?xml version = '1.0'?
5d4
9,12c8,9
!-- The airport list widget appears to have a bug
with layout; it
fails to draw within the x/y/width/height it
is given. --
airport-list
---
!-- The airport list widget appears to have a bug
with layout; it
fails to draw within the x/y/width/height it
is given. -- airport-list
17d13
21,22c17,19
emptystretchtrue/stretch/empty
---
empty
stretchtrue/stretch
/empty
28,30c25,36
commandproperty-assign/command
property/sim/presets/longitude-deg/property
value type=double-/value
---
commandnasal/command
script
setprop(quot;/sim/presets/longitude-degquot;,
-);
setprop(quot;/sim/presets/latitude-degquot;,
-);
setprop(quot;/sim/presets/altitude-ftquot;,
-);
setprop(quot;/sim/presets/airspeed-ktquot;,
0);
setprop(quot;/sim/presets/offset-distancequot;, 0);
setprop(quot;/sim/presets/offset-azimuthquot;, 0);
setprop(quot;/sim/presets/glideslope-degquot;, 0);
setprop(quot;/sim/presets/heading-degquot;,
0);
setprop(quot;/sim/presets/runwayquot;,
quot;quot;);
/script
33,35c39
commandproperty-assign/command
property/sim/presets/latitude-deg/property
value type=double-/value
---
commanddialog-apply/command
38,40c42
commandproperty-assign/command
property/sim/presets/altitude-ft/property
value type=double-/value
---
commandpresets-commit/command
43,46c45
commanddialog-apply/command
/binding
binding
commandpresets-commit/command
---
commanddialog-close/command
49,51c48,50
emptystretchtrue/stretch/empty
---
empty
stretchtrue/stretch
/empty
56c55
commanddialog-close/command
---
commanddialog-close/command
59,60c58,60
emptystretchtrue/stretch/empty
---
empty
stretchtrue/stretch
Re: [Flightgear-devel] AirportList
--- Frederic Bouvier [EMAIL PROTECTED] wrote: Thanks for your efforts. I just have practical remarks regarding patch post to the list. Use unidiff ( -u ) because all those are confusing mail readers that interpret added lines as message quote Attach the file because many lines are split Better yet, send directly to one maintainer with CVS write access This way you will avoid the frustration of having your patch ignored just because it is unusable without a man-month worth of effort to rebuild something that could be understood by the patch utility. Thanks for the advice. I'll try and sort that out when I get back from work. Who would be the best person to send the diffs to? Regards Andrew ___ ALL-NEW Yahoo! Messenger - all new features - even more fun! http://uk.messenger.yahoo.com ___ Flightgear-devel mailing list Flightgear-devel@flightgear.org http://mail.flightgear.org/mailman/listinfo/flightgear-devel 2f585eeea02e2c79d7b1d8c4963bae2d
Re: [Flightgear-devel] Re: AirportList
--- Melchior FRANZ [EMAIL PROTECTED] wrote: * Andrew Midosn -- Tuesday 25 January 2005 09:28: 59,60c58,60 emptystretchtrue/stretch/empty --- empty stretchtrue/stretch /empty ... and make sure that you don't accidentally send the patch to the developer whose coding style you are correcting along with your functional changes, especially if these changes are completely unrelated. m. :-] Ooops - I didn't notice that! I suspect it was the XML editor I was using deciding to enforce its own style. I certainly don't remember making any changes to that part of the file. I would normally try to adopt the coding style of the file I'm editing as far as possible - it's just polite. I'll go back to using vi I think - that's usually quite well behaved. Regards Andrew ___ ALL-NEW Yahoo! Messenger - all new features - even more fun! http://uk.messenger.yahoo.com ___ Flightgear-devel mailing list Flightgear-devel@flightgear.org http://mail.flightgear.org/mailman/listinfo/flightgear-devel 2f585eeea02e2c79d7b1d8c4963bae2d
Re: [Flightgear-devel] Re: AirportList
--- Paul Surgeon [EMAIL PROTECTED] wrote: On Monday, 24 January 2005 10:48, Erik Hofman wrote: Maybe it's even a better idea to have a world map image where you can zoom in in three or four steps to select the desired airport? If someone could add ssgContext support or some way to render to a texture or window inside of FG I could add it within 2 weeks. I already have code that renders a textured WGS 84 ellipsoid in OpenGL with pan/zoom functionality. Adding airports to the globe with picker support would take no more than a day or two. The only issue is that I'm using rather large texture maps - it would take a bit more work to add vector maps. This issue of not being able to render to a sub window is coming back to bite us everytime. If it's not stuff like this then it's moving map/GPS/ND type instruments. Now that sounds like the best idea overall. Mind you, assuming we had the ability to render to a sub-window, I think it's outside my abilities with C++ at present (Python might be a different matter). I'll keep tinkering away and learning for the moment, and wait impatiently for someone else to do the hard stuff! ;-) Regards Andrew ___ ALL-NEW Yahoo! Messenger - all new features - even more fun! http://uk.messenger.yahoo.com ___ Flightgear-devel mailing list Flightgear-devel@flightgear.org http://mail.flightgear.org/mailman/listinfo/flightgear-devel 2f585eeea02e2c79d7b1d8c4963bae2d
[Flightgear-devel] AirportList
I have been playing around with trying to get the 'Select Airport from List' option within FlightGear working. So far I have managed to get the dialog to close and FlightGear to restart when the 'Apply' button is clicked (I just pinched the code from location-on-ground.xml). However, it's still not putting you at the selected airport. The airport list control in the dialog is bound to the airport-id property, and I had assumed that this would be populated using the control's getStringValue() method. But this method doesn't appear to get called at all. So can anyone point me at the code that sets the property that is bound to a gui control. TIA Regards Andrew ___ ALL-NEW Yahoo! Messenger - all new features - even more fun! http://uk.messenger.yahoo.com ___ Flightgear-devel mailing list Flightgear-devel@flightgear.org http://mail.flightgear.org/mailman/listinfo/flightgear-devel 2f585eeea02e2c79d7b1d8c4963bae2d
Re: [Flightgear-devel] Re: AirportList
--- Melchior FRANZ [EMAIL PROTECTED] wrote: http://baron.flightgear.org/pipermail/flightgear-devel/2004-December/033009.html So it can't be done without changes to PLIB. That's a shame. As far as scanning the scenery directory to work out which airports are available is concerned, I'm not sure that's the right solution. I'm thinking of anyone that runs terrasync - they should have access to any airport regardless of whether they currently have the scenery available for it or not, shouldn't they? It might be more useful to be able to apply a filter to the list to reduce it in size. Probably filtering by state for the USA and by country for (most) of the rest of the world would be OK. Of course, we would have to have access to that information, which I don't think is available in apt.dat. Just my opinion anyway. Regards Andrew ___ ALL-NEW Yahoo! Messenger - all new features - even more fun! http://uk.messenger.yahoo.com ___ Flightgear-devel mailing list Flightgear-devel@flightgear.org http://mail.flightgear.org/mailman/listinfo/flightgear-devel 2f585eeea02e2c79d7b1d8c4963bae2d
Re: [Flightgear-devel] AirportList
--- Erik Hofman [EMAIL PROTECTED] wrote: I'm afraid I don't exactly understand what you are requesting here. Do you want to location of the gui-code that sets the property, do you want the code that generates the airport-list for the gui or do you still want something else? I had assumed that getStringValue() wasn't the function that should be used to get the value from a control as it wasn't getting called. So I was hoping that someone could tell me which method *was* being called. From Melchior's reply I gather that I got the right method, but the overridden version on AirportList isn't getting called due to the way PLIB works. I don't know what the chances of getting PLIB changed are, but I do think this (selecting an airport from a list) would be a nice feature. On the other hand, if most people feel that it isn't necessary (you can change airports by using Position Aircraft (on ground) after all) then the select from list option should probably be removed. Regards Andrew ___ ALL-NEW Yahoo! Messenger - all new features - even more fun! http://uk.messenger.yahoo.com ___ Flightgear-devel mailing list Flightgear-devel@flightgear.org http://mail.flightgear.org/mailman/listinfo/flightgear-devel 2f585eeea02e2c79d7b1d8c4963bae2d
Re: [Flightgear-devel] Re: AirportList
--- Paul Surgeon [EMAIL PROTECTED] wrote: The country codes for airports are already Robin's database - in fact he uses them as part of the primary key. However he won't add it to the airport file because X-plane doesn't use them and Austin Meyer doesn't want anything in the apt.dat that is not X-Plane related. I feel that they should be added because they will prove to be very valuable for filtering but I haven't got enough weight to get them added. I can understand Austin wanting to keep the airport file as lean as possible, but like yourself I think the country information is useful. I have only looked at a demo of X-Plane, but if I remember correctly the airport list is similar to FlightGear's - very long and hard to use. This is probably less of a problem for enthusiasts, who will tend to know the code for any airport they want to fly from, but is a pain for beginners who would be happier browsing a list. Regards Andrew ___ ALL-NEW Yahoo! Messenger - all new features - even more fun! http://uk.messenger.yahoo.com ___ Flightgear-devel mailing list Flightgear-devel@flightgear.org http://mail.flightgear.org/mailman/listinfo/flightgear-devel 2f585eeea02e2c79d7b1d8c4963bae2d
[Flightgear-devel] Problems building from CVS
I've just updated my source code from CVS, but the build fails with the following: Making all in Environment make[2]: Entering directory `/home/andrew/cbproject/FlightGear-0.9/source/src/Environment' if g++ -DHAVE_CONFIG_H -I. -I. -I../../src/Include -I../.. -I../../src -I/usr/X11R6/include -I/usr/local//include -g -O2 -D_REENTRANT -MT environment_mgr.o -MD -MP -MF .deps/environment_mgr.Tpo -c -o environment_mgr.o environment_mgr.cxx; \ then mv -f .deps/environment_mgr.Tpo .deps/environment_mgr.Po; else rm -f .deps/environment_mgr.Tpo; exit 1; fi In file included from environment_ctrl.hxx:50, from environment_mgr.cxx:31: fgmetar.hxx: In member function `double FGMetar::getRain() const': fgmetar.hxx:45: error: `_rain' undeclared (first use this function) fgmetar.hxx:45: error: (Each undeclared identifier is reported only once for each function it appears in.) fgmetar.hxx: In member function `double FGMetar::getHail() const': fgmetar.hxx:46: error: `_hail' undeclared (first use this function) fgmetar.hxx: In member function `double FGMetar::getSnow() const': fgmetar.hxx:47: error: `_snow' undeclared (first use this function) make[2]: *** [environment_mgr.o] Error 1 make[2]: Leaving directory `/home/andrew/cbproject/FlightGear-0.9/source/src/Environment' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/andrew/cbproject/FlightGear-0.9/source/src' make: *** [all-recursive] Error 1 It looks as though the methods getRain(), getHail() and getSnow() rely on private attributes that haven't been declared. I have tried adding them as int's, but now get the following error: Making all in Environment make[2]: Entering directory `/home/andrew/cbproject/FlightGear-0.9/source/src/Environment' if g++ -DHAVE_CONFIG_H -I. -I. -I../../src/Include -I../.. -I../../src -I/usr/X11R6/include -I/usr/local//include -g -O2 -D_REENTRANT -MT environment_ctrl.o -MD -MP -MF .deps/environment_ctrl.Tpo -c -o environment_ctrl.o environment_ctrl.cxx; \ then mv -f .deps/environment_ctrl.Tpo .deps/environment_ctrl.Po; else rm -f .deps/environment_ctrl.Tpo; exit 1; fi environment_ctrl.cxx: In constructor ` FGMetarEnvironmentCtrl::FGMetarEnvironmentCtrl()': environment_ctrl.cxx:332: error: no matching function for call to ` FGMetarEnvironmentCtrl::MetarThread::start(int)' /usr/local/include/simgear/threads/SGThread.hxx:134: error: candidates are: int SGThread::start() make[2]: *** [environment_ctrl.o] Error 1 make[2]: Leaving directory `/home/andrew/cbproject/FlightGear-0.9/source/src/Environment' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/andrew/cbproject/FlightGear-0.9/source/src' make: *** [all-recursive] Error 1 Sadly my C++ is very sketchy, so I'm struggling to get past this. However, I'll keep digging, although it would help if anyone could provide any pointers as to the likely cause. Regards Andrew ___ ALL-NEW Yahoo! Messenger - all new features - even more fun! http://uk.messenger.yahoo.com ___ Flightgear-devel mailing list Flightgear-devel@flightgear.org http://mail.flightgear.org/mailman/listinfo/flightgear-devel 2f585eeea02e2c79d7b1d8c4963bae2d
Re: [Flightgear-devel] Problems building from CVS
--- Frederic Bouvier [EMAIL PROTECTED] wrote: Update SimGear too. Yup - my poor tired brain eventually noticed that it was complaining about SimGear *not* FlightGear (doh!), so I've updated that also. I'm still getting errors relating to FGMetar, so it certainly looks as if something's broken there. I'll keep digging. Regards Andrew ___ ALL-NEW Yahoo! Messenger - all new features - even more fun! http://uk.messenger.yahoo.com ___ Flightgear-devel mailing list Flightgear-devel@flightgear.org http://mail.flightgear.org/mailman/listinfo/flightgear-devel 2f585eeea02e2c79d7b1d8c4963bae2d
[Flightgear-devel] FGMetar.cxx
I've fixed one problem with the FGMetar constructor, where the call to the parent class SGMetar was incorrect, but now have another problem. In the constructor the method getCAVOK() is called, although it isn't defined anywhere in either FlightGear or SimGear. Unfortunately I have no idea what this function is supposed to do. I'll try defining it as a bool in FGMetar that just returns True for the moment, but that isn't really a solution. I would really like to sort this out and feel I am contributing in a small way to the project, but I'm not sure enough of what this code is trying to do. Sorry. Regards Andrew ___ ALL-NEW Yahoo! Messenger - all new features - even more fun! http://uk.messenger.yahoo.com ___ Flightgear-devel mailing list Flightgear-devel@flightgear.org http://mail.flightgear.org/mailman/listinfo/flightgear-devel 2f585eeea02e2c79d7b1d8c4963bae2d
Re: [Flightgear-devel] FGMetar.cxx
--- Frederic Bouvier [EMAIL PROTECTED] wrote: You really have screwed your SimGear tree, if you think it is up to date. And that of course was the absolute truth. Having scrapped my SimGear directory completely and started again I now have everything compiling properly. FGMetar is of course fine, and only my brain is defective. My apologies for bothering the list, and my thanks to Fred for not lobbing a virtual half-brick at the idiot who was wasting his time. :-( Regards Andrew ___ ALL-NEW Yahoo! Messenger - all new features - even more fun! http://uk.messenger.yahoo.com ___ Flightgear-devel mailing list Flightgear-devel@flightgear.org http://mail.flightgear.org/mailman/listinfo/flightgear-devel 2f585eeea02e2c79d7b1d8c4963bae2d
Re: [Flightgear-devel] Re: FlightGear 0.9.8, Mac OS X build
--- Andrew Midosn [EMAIL PROTECTED] wrote: I notice that no-one is assuming that this could have been an innocent mistake. I accept that it is unlikely, but it wouldn't be the first time that a file has been included in a software release in error. I would agree that it is entirely inappropriate for this file to be distributed with FlightGear, but has anyone asked the package maintainer if they intended the file to be included? Sorry - I really must finish reading ALL of my mail before replying. I see that this has already been covered, so I'll shut up again now. :-) Regards Andrew ___ ALL-NEW Yahoo! Messenger - all new features - even more fun! http://uk.messenger.yahoo.com ___ Flightgear-devel mailing list Flightgear-devel@flightgear.org http://mail.flightgear.org/mailman/listinfo/flightgear-devel 2f585eeea02e2c79d7b1d8c4963bae2d
Re: [Flightgear-devel] Things to do to improve Flightgear
--- Erik Hofman [EMAIL PROTECTED] wrote: Well, at least it points out to the user that the user interface isn't necessarily a high priority. For now FlightGear has been used and improved by research projects and certified simulator developers. So far we have been able to satisfy every one to some degree, but (and I sure hope not) there might be a time that both user bases start to conflict in the code. It seems slightly odd to me to feel that 'serious' users don't want/need a decent user interface, while gamers do. As a Linux user, and a developer who is happy to use command line tools, I'm certainly not afraid of not having a GUI available. But if someone wants to provide something to make my life easier (like allowing me to browse through a list of airports rather than having to remember the codes for example), then I'm not going to turn my nose up at it. The important thing, I feel, is that any user interface should be carefully designed so that it makes the user's experience of the program easier, and more intuitive. Too often the interface just gets in the way and makes things worse. Certainly keep the command line options - they are extremely useful for those who understand them. Even make the program start without a UI by default. But don't ignore the idea of a user interface purely because FlightGear is a 'serious' application. Just my opinion, of course. Regards Andrew ___ Win a castle for NYE with your mates and Yahoo! Messenger http://uk.messenger.yahoo.com ___ Flightgear-devel mailing list [EMAIL PROTECTED] http://mail.flightgear.org/mailman/listinfo/flightgear-devel 2f585eeea02e2c79d7b1d8c4963bae2d
