Re: [Flightgear-devel] [BUG] FGEnvironment copy constructor bad

2009-01-13 Thread Tim Moore
Csaba Halász wrote: > Hi! > > The copy constructor in question: > > 145 FGEnvironment::FGEnvironment (const FGEnvironment &env) > 146 { > 147 FGEnvironment(); > 148 copy(env); > 149 } > > I guess that wants to call the default constructor first. However, > that doesn'

[Flightgear-devel] [PATCH] property aliasing doesn't keep target node alive

2009-01-13 Thread Csaba Halász
Problem: Apparently when you add an alias to a property node, the reference count of the target of the alias isn't incremented, so it can vanish at any moment. Fix: Since the SGPropertyNode class is hand managing its value pointers anyway, I don't see much point in using SGPropertyNode_ptr here, so

[Flightgear-devel] [PATCH] clouds_3d_enabled member not initialized in src/Environment/fgclouds.cxx

2009-01-13 Thread Csaba Halász
The clouds_3d_enabled member is not initialized in the constructor, but the set_3dClouds function depends on it: void FGClouds::set_3dClouds(bool enable) { if (enable != clouds_3d_enabled) { clouds_3d_enabled = enable; buildCloudLayers(); } } -- Csaba/Jester Index: src/En

[Flightgear-devel] [PATCH] using freed memory in src/Instrumentation/HUD/HUD_ladder.cxx

2009-01-13 Thread Csaba Halász
540 // draw numbers 541 std::ostringstream str; 542 str << i; 543 const char *num = str.str().c_str(); The str.str() is returning a temporary string, that gets immediately freed, taking the returned c_str() with it. Bad. :) Breakpoin

[Flightgear-devel] [BUG] FGEnvironment copy constructor bad

2009-01-13 Thread Csaba Halász
Hi! The copy constructor in question: 145 FGEnvironment::FGEnvironment (const FGEnvironment &env) 146 { 147 FGEnvironment(); 148 copy(env); 149 } I guess that wants to call the default constructor first. However, that doesn't work. See http://www.parashift.com/c++-faq

[Flightgear-devel] The [Re-]Initialization Process in FlightGear: A Specification Proposal

2009-01-13 Thread Jon S. Berndt
In order for the FDMs to consistently and completely handle a reset request from FlightGear, there ought to be a specification that describes what is supposed to happen. Here's a first cut at what a specification for the reset function might say: 1) There MUST be separate functions to a) initial

Re: [Flightgear-devel] [Jsbsim-devel] X-15 issue identified

2009-01-13 Thread Jon S. Berndt
> Also note that the FlightGear model, whether or not extended > in height, is a one-parameter model which (to put it politely) > does not adhere to the laws of physics. It puts out wrong > answers whenever the temperature differs significantly from > ISA standard day. JSBSim has, for a long time

Re: [Flightgear-devel] [Jsbsim-devel] X-15 issue identified

2009-01-13 Thread Jon S. Berndt
> There was an issue some time ago when we had control-fdm-atmosphere set > to false by default. I don't know if this has been resolved by now. > Here is the thread from 2007: > http://www.mail-archive.com/flightgear- > devel%40lists.sourceforge.net/msg13065.html > > Torsten It's an interesting q

Re: [Flightgear-devel] [Jsbsim-devel] X-15 issue identified

2009-01-13 Thread John Denker
On 01/13/2009 12:25 PM, flying.toaster wrote: > flightgear I assume that imposes flight gear own atmosphere model > to the FDM and THIS model is stuck after 10 ft I can easily generate ISA atmosphere data to 71,000 m (232940 ft) ... and beyond that if you wish (to the limited extent tha

Re: [Flightgear-devel] [Jsbsim-devel] X-15 issue identified

2009-01-13 Thread Torsten Dreyer
> Got it, > > The issue is that JSBSIM gets the external atmospheric model > (/environment/params/control-fdm-atmosphere set to true in flightgear). I > assume that imposes flight gear own atmosphere model to the FDM and THIS > model is stuck after 10 ft > > Setting this value to false actuall

Re: [Flightgear-devel] [Jsbsim-devel] X-15 issue identified

2009-01-13 Thread flying.toaster
Got it, The issue is that JSBSIM gets the external atmospheric model (/environment/params/control-fdm-atmosphere set to true in flightgear). I assume that imposes flight gear own atmosphere model to the FDM and THIS model is stuck after 10 ft Setting this value to false actually gets a mo

Re: [Flightgear-devel] [PATCH] fix division by zero in AICarrier

2009-01-13 Thread Csaba Halász
On Sun, Jan 11, 2009 at 2:13 AM, Ron Jensen wrote: > On Fri, 2009-01-02 at 12:35 +, James Turner wrote: >> >> Applied. Frankly, all uses of atan() should probably be replaced with >> atan2(), but with some inspection of the call site to verify the >> change is sane. > > There was some code to

Re: [Flightgear-devel] Custom terragear scenery doesn't match

2009-01-13 Thread Martin Spott
Michael, Michael Smith wrote: > Martin Spott wrote: > > Michael Smith wrote: > >> I have made some scenery using terragear-cs and it has built ok except > >> for it not matching existing scenery. I was told that it was because of > >> me not using the same arrayfit params that the original scen