Re: [Flightgear-devel] ATISs upgrade
* Durk Talsma -- Saturday 03 March 2007: > Personally, I don't object against commented-out cout / cerr statements > in the code I wasn't talking about commented out debug messages. m. - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
[Flightgear-devel] Weekly CVS Changelog Summary: FlightGear data
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= 2007-02-25_04:56:59 (vmmeazza) /var/cvs/FlightGear-0.9/data/AI/PAVictoria_demo.xml Add new scenario to demonstate AIShip "flightplans" =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= 2007-02-25_04:58:05 (vmmeazza) /var/cvs/FlightGear-0.9/data/AI/FlightPlans/PA_PA-Victoria.xml /var/cvs/FlightGear-0.9/data/AI/FlightPlans/PA_Victoria-PA.xml Add flightplans for the new scenario to demonstate AIShip "flightplans" =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= 2007-02-25_05:07:37 (vmmeazza) /var/cvs/FlightGear-0.9/data/AI/PAVictoria_demo.xml Updated to remove reference to aircraft flightplans =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= 2007-02-26_04:37:34 (vmmeazza) /var/cvs/FlightGear-0.9/data/AI/PAVictoria_demo.xml Use a slightly modified ferry =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= 2007-02-26_05:00:04 (mfranz) /var/cvs/FlightGear-0.9/data/Nasal/gui.nas add Dialog.namespace() method, which returns the XML dialog's namespace if the dialog is open and contains embedded , or nil otherwise. This can be used to call dialog functions. =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= 2007-02-26_11:57:55 (mfranz) /var/cvs/FlightGear-0.9/data/Aircraft/ufo/ufo-set.xml /var/cvs/FlightGear-0.9/data/Aircraft/ufo/ufo.nas - allow selection and manipulation of multiple objects - replace lon/lat adjustment with more predictable nearer/farther/left/right adjustment (i.e. movements relative to the UFO position) - add key bindings to move objects =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= 2007-02-26_13:15:26 (mfranz) /var/cvs/FlightGear-0.9/data/Aircraft/ufo/ufo.nas distance scaling doesn't work too well for heading =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= 2007-02-26_14:21:54 (martin) /var/cvs/FlightGear-0.9/data/Aircraft/B-2/Attic/b2.nas /var/cvs/FlightGear-0.9/data/Aircraft/B-2/Models/Attic/fuel-aar.nas Markus Zojer: Please update the B-2 folder to the new version, as almost all files have been updated. We have now flymodes, new instruments and more. =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= 2007-02-26_14:21:55 (martin) /var/cvs/FlightGear-0.9/data/Aircraft/B-2/Models/Instruments-3d/Attic/eicas.xcf /var/cvs/FlightGear-0.9/data/Aircraft/B-2/Models/Instruments-3d/Attic/eicas_4.ac /var/cvs/FlightGear-0.9/data/Aircraft/B-2/Models/Instruments-3d/Attic/eicas_4.xml /var/cvs/FlightGear-0.9/data/Aircraft/B-2/Systems/Attic/nav1-hold.xml Markus Zojer: Please update the B-2 folder to the new version, as almost all files have been updated. We have now flymodes, new instruments and more. =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= 2007-02-26_14:33:16 (martin) /var/cvs/FlightGear-0.9/data/Aircraft/B-2/B-2-set.xml /var/cvs/FlightGear-0.9/data/Aircraft/B-2/B-2-yasim.xml /var/cvs/FlightGear-0.9/data/Aircraft/B-2/flying-HOWTO.txt /var/cvs/FlightGear-0.9/data/Aircraft/B-2/readme-spirit.txt /var/cvs/FlightGear-0.9/data/Aircraft/B-2/thumbnail.jpg /var/cvs/FlightGear-0.9/data/Aircraft/B-2/version-whatsnew.txt /var/cvs/FlightGear-0.9/data/Aircraft/B-2/Models/b2-spirit.xml /var/cvs/FlightGear-0.9/data/Aircraft/B-2/Models/cockpit.rgb /var/cvs/FlightGear-0.9/data/Aircraft/B-2/Models/la_light.xml /var/cvs/FlightGear-0.9/data/Aircraft/B-2/Models/spirit.ac Markus Zojer: Please update the B-2 folder to the new version, as almost all files have been updated. We have now flymodes, new instruments and more. =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= 2007-02-26_14:33:17 (martin) /var/cvs/FlightGear-0.9/data/Aircraft/B-2/Models/spirit_hightex.rgb /var/cvs/FlightGear-0.9/data/Aircraft/B-2/Models/spirit_tex_adv.rgb /var/cvs/FlightGear-0.9/data/Aircraft/B-2/Models/transparent.rgb /var/cvs/FlightGear-0.9/data/Aircraft/B-2/Models/Instruments-3d/aplt.rgb /var/cvs/FlightGear-0.9/data/Aircraft/B-2/Models/Instruments-3d/apmode-hotspots.xml /var/cvs/FlightGear-0.9/data/Aircraft/B-2/Models/Instruments-3d/apmode.ac /var/cvs/FlightGear-0.9/data/Aircraft/B-2/Models/Instruments-3d/apmode.xml /var/cvs/FlightGear-0.9/data/Aircraft/B-2/Models/Instruments-3d/clock.ac /var/cvs/FlightGear-0.9/data/Aircraft/B-2/Models/Instruments-3d/clock.rgb /var/cvs/FlightGear-0.9/data/Aircraft/B-2/Models/Instruments-3d/clock.xml /var/cvs/FlightGear-0.9/data/Aircraft/B-2/Models/Instruments-3d/cockpit.rgb /var/cvs/FlightGear-0.9/data/Aircraft/B-2/Models/Instruments-3d/cons_apeng.xml /var/cvs/FlightGear-0.9/data/Aircraft/B-2/Models/Instruments-3d/consapeng.ac /var/cvs/FlightGear-0.9/data/Aircraft/B-2/Models/Instruments-3d/eng.rgb /var/cvs/FlightGear-0.9/data/Aircraft/B-2/Models/Instruments-3d/glas_2-hotspots.xml /var/cvs/FlightGear-0.9/data/Aircraft/B-2/Models/Instruments-3d/glas_2.ac /var/cvs/FlightGear-0.9/data/Aircraft/B-2/Models/Instruments-3d/glas_2.xml /var/cvs/FlightGear-0.9/data/Aircraft/B-2/Models/Instruments-3d/glas_
[Flightgear-devel] Weekly CVS Changelog Summary: FlightGear source
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= 2007-02-26_05:47:04 (mfranz) /var/cvs/FlightGear-0.9/source/src/AIModel/AIBase.hxx Vivian MEAZZA: call AI models' ::reinit() methods on reinit =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= 2007-02-26_05:47:05 (mfranz) /var/cvs/FlightGear-0.9/source/src/AIModel/AIManager.cxx Vivian MEAZZA: call AI models' ::reinit() methods on reinit =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= 2007-02-26_05:47:07 (mfranz) /var/cvs/FlightGear-0.9/source/src/AIModel/AIBase.hxx /var/cvs/FlightGear-0.9/source/src/AIModel/AIManager.cxx Vivian MEAZZA: call AI models' ::reinit() methods on reinit =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= 2007-02-27_13:45:48 (curt) /var/cvs/FlightGear-0.9/source/utils/GPSsmooth/UGear.cxx /var/cvs/FlightGear-0.9/source/utils/GPSsmooth/UGear_main.cxx Switch to "nav" (cooked) data to drive FlightGear. =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= 2007-02-28_18:30:07 (andy) /var/cvs/FlightGear-0.9/source/src/FDM/YASim/FGFDM.cpp Can't assume that the aircraft has a fuel tank. =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= 2007-02-28_18:32:14 (andy) /var/cvs/FlightGear-0.9/source/src/FDM/YASim/FGFDM.cpp sync with trunk =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= 2007-03-01_11:39:45 (mfranz) /var/cvs/FlightGear-0.9/source/src/Network/native_gui.cxx Csaba HALASZ: fix dme property name =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= 2007-03-01_11:39:49 (mfranz) /var/cvs/FlightGear-0.9/source/src/Network/native_gui.cxx Csaba HALASZ: fix dme property name =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= 2007-03-01_11:53:24 (mfranz) /var/cvs/FlightGear-0.9/source/src/FDM/LaRCsim/ls_interface.c Hans Ulrich NIEDERMANN: """ Fix Y2K bug triggering string overflow sim_control_.date_string is a char[7], so it can contain "yymmdd" and the terminating '\0'. However, nowtime->tm_year is 107 for the year 2007, so you'll end up with a 7 digit number and the string written to sim_control_.date_string is longer than sim_control_.date_string is. Ouch! """ mf: ... and sim_control_.date_string isn't even used. =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= 2007-03-01_11:53:27 (mfranz) /var/cvs/FlightGear-0.9/source/src/FDM/LaRCsim/ls_interface.c Hans Ulrich NIEDERMANN: """ Fix Y2K bug triggering string overflow sim_control_.date_string is a char[7], so it can contain "yymmdd" and the terminating '\0'. However, nowtime->tm_year is 107 for the year 2007, so you'll end up with a 7 digit number and the string written to sim_control_.date_string is longer than sim_control_.date_string is. Ouch! """ mf: ... and sim_control_.date_string isn't even used. =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= 2007-03-01_12:12:48 (frohlich) /var/cvs/FlightGear-0.9/source/src/Main/renderer.cxx Modified Files: src/Main/renderer.cxx: Guard the OpenGL state around pui a bit more 2f585eeea02e2c79d7b1d8c4963bae2d - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
[Flightgear-devel] Weekly CVS Changelog Summary: SimGear
2f585eeea02e2c79d7b1d8c4963bae2d - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] ATISs upgrade
Leave it in! On Sat, 3 Mar 2007 7:07 pm, John Denker wrote: > On 03/03/2007 05:18 PM, Durk Talsma wrote: >> Also note that many cout statements still in the code are >> commented >> out, for potential use in future development / debugging. > > That's exactly what we're talking about today : couts that output > *nothing* unless a developer steps in to request something. > >> Personally, I don't object against commented-out cout / cerr >> statements >> in the code if the author wants to retain them for ongoing >> development. > > Agreed! > > There are thousands of such couts in the code already, and they serve > a useful purpose. > > As I said earlier, there is a theory going around that open code > should be really, really open, in a broad /practical/ sense, not > just in some narrow legal sense. > > This also falls under the heading of DfT (design for test). Having > gone to the trouble of creating a test harness, why not leave it in > there for other folks to use? I don't think it would make much sense > to have each person who wants to test the code re-invent and > re-implement > the test harness. > > - > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share > your > opinions on IT & business topics through brief surveys-and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > ___ > Flightgear-devel mailing list > Flightgear-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/flightgear-devel www.GlobalBoiling.com for daily images about hurricanes, globalwarming and the melting poles. www.ElectricQuakes.com daily solar and earthquake images. - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] ATISs upgrade
On 03/03/2007 05:18 PM, Durk Talsma wrote: > Also note that many cout statements still in the code are commented > out, for potential use in future development / debugging. That's exactly what we're talking about today : couts that output *nothing* unless a developer steps in to request something. > Personally, I don't object against commented-out cout / cerr statements > in the code if the author wants to retain them for ongoing development. Agreed! There are thousands of such couts in the code already, and they serve a useful purpose. As I said earlier, there is a theory going around that open code should be really, really open, in a broad /practical/ sense, not just in some narrow legal sense. This also falls under the heading of DfT (design for test). Having gone to the trouble of creating a test harness, why not leave it in there for other folks to use? I don't think it would make much sense to have each person who wants to test the code re-invent and re-implement the test harness. - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] ATISs upgrade
John Denker wrote: > >> Don't use cout/cerr. Use SG_LOG with appropriate log levels. >> > > There are 2017 comparable uses of cout in FlightGear and 376 more > in SimGear. Why don't you remove some of those? When it gets > down to the point where the ones I've put in are, say, 1% of the > total, I'll consider removing them. > > > Some of these messages probably predate our logging system, others might have slipped in by accident (and I confess being guilty of of this in the past). It is our policy, however, to use the SG_LOG mechanism exclusively. Judging from the small amount of information printed during your average FlightGear session, not many of these cerr / cout statement are in code that is run frequently. The frequent ones are converted by now. Also note that many cout statements still in the code are commented out, for potential use in future development / debugging. Personally, I don't object against commented-out cout / cerr statements in the code if the author wants to retain them for ongoing development. Submitted patches should be free of active ones, however. I have updated the "Submitting Patches" page on the WIKI in order to make this policy better known. Cheers, Durk - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] ATISs upgrade
On 03/03/2007 02:30 PM, Alex Romosan wrote: > virtual void Init()=0; Excellent! Done now. http://www.av8n.com/fly/fgfs/atis.diff That is the Right Way(tm) to express what was intended. Thanks for the suggestion. - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] ATISs upgrade
John Denker writes:
> On 03/03/2007 12:32 PM, Melchior FRANZ wrote:
>
>> hxx:
>> +virtual void Init();
>> cxx:
>> +void FGATC::Init() {
>> +// This should never be called, since each derived class will have its
>> own
>> +// Init() that overrides this one.
>> +}
>>
>> So, why are you adding it?!
>
> Perhaps because the code wouldn't be correct without it?!
then make in a pure virtual function in the header file.
virtual void Init()=0;
this way every derived class will have to implement it but there is no
definition in the base class.
--alex--
--
| I believe the moment is at hand when, by a paranoiac and active |
| advance of the mind, it will be possible (simultaneously with |
| automatism and other passive states) to systematize confusion |
| and thus to help to discredit completely the world of reality. |
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] ATISs upgrade
* John Denker -- Saturday 03 March 2007: > On 03/03/2007 12:32 PM, Melchior FRANZ wrote: > > Don't use cout/cerr. Use SG_LOG with appropriate log levels. > > There are 2017 comparable uses of cout in FlightGear and 376 more > in SimGear. Why don't you remove some of those? If you weren't a newcomer then you would know that this is what I'm routinely doing. A bug doesn't become more acceptable when there are similar bugs elsewhere. What's exactly the problem with fixing that? Either *you* fix it, or someone else has to. Is it fair to load the work on others? > When I changed the indentation just now, to make it more uniform, > it increased the length of the atis.?xx patch from 474 to 487 lines. > That's almost three percent! Are you serious? Correctness is valued higher than shortness. m. - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] ATISs upgrade
On 03/03/2007 12:32 PM, Melchior FRANZ wrote:
> hxx:
> + virtual void Init();
> cxx:
> +void FGATC::Init() {
> +// This should never be called, since each derived class will have its
> own
> +// Init() that overrides this one.
> +}
>
> So, why are you adding it?!
Perhaps because the code wouldn't be correct without it?!
> Don't use cout/cerr. Use SG_LOG with appropriate log levels.
There are 2017 comparable uses of cout in FlightGear and 376 more
in SimGear. Why don't you remove some of those? When it gets
down to the point where the ones I've put in are, say, 1% of the
total, I'll consider removing them.
> atis.cxx is *exclusively* tab indented. Applying this patch would
> mess up the whole file.
Here's a measure of how big a mess we're talking about: When I changed
the indentation just now, to make it more uniform, it increased the
length of the atis.?xx patch from 474 to 487 lines. That's almost
three percent!
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] ATISs upgrade
* John Denker -- Friday 02 March 2007:
> On 03/01/2007 02:19 PM, AJ MacLeod wrote:
> > Was the stuff at line 300 intended to be in there?
>
> Actually yes, I put the call-trace in there for a reason, and I left
> it in there for a reason.
OK. Please remove it. Things like these have no place in the source code:
void FGATCDialog::Init() {
+#if 0
+Called from:
+:#1 0x080e8128 in FGATCDialog::Init (this=0xb375a10) at ATCDialog.cxx:104
+:#2 0x080aedd4 in FGATCMgr::init (this=0xb370748) at ATCmgr.cxx:150
+:#3 0x0807aec6 in fgInitSubsystems () at fg_init.cxx:1698
+:#4 0x0805cc59 in fgIdleFunction () at main.cxx:869
+:#5 0x0809bce1 in GLUTidle () at fg_os.cxx:122
+:#6 0xb7ac3d3a in glutMainLoop () from /usr/lib/libglut.so.3
+:#7 0x0805bbad in fgMainInit (argc=3, argv=0xbfb6ed34) at main.cxx:1029
+#endif
// Add ATC-dialog to the command list
This is the most absurd stuff that I've seen added to a function. I'm
almost inclined to think you want to make fun of us.
hxx:
+ virtual void Init();
cxx:
+void FGATC::Init() {
+// This should never be called, since each derived class will have its own
+// Init() that overrides this one.
+}
So, why are you adding it?!
atis.cxx is *exclusively* tab indented. Please respect that, and don't
replace tabs (8 positions) with two spaces. Applying this patch would
mess up the whole file.
Don't use cout/cerr. Use SG_LOG with appropriate log levels.
This is not a complete review -- I stopped reading when I came to the
badly structured compact code blocks.
m.
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] encoder/altimeter & kap140.nas
On 03/03/2007 03:05 AM, Roy Vegard Ovesen wrote: > I believe that MSVC needs the iterator to be declared before the loop: > int i; > for (i = 0; ; i++) The expression for (int i = 0; ; ) is standard and has been for many years. It occurs in 367 places in FlightGear and 161 more in SimGear. If it caused problems, we would have heard about it before now. - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] [BUG] Scenery spelling mistake
Nick Warne wrote: > On Saturday 03 March 2007 12:57:39 Nick Warne wrote: > > Cannot find model > > file "/opt/fg_scenery/Objects/w010n50/w002n55/lynemouthchimney.ac" > > Failed to load 3D > > model /opt/fg_scenery/Objects/w010n50/w002n55/lynemouthchimney.ac > > > > > > ./2925641.stg:1:OBJECT_STATIC lynemouthchimney.ac -1.5192975 55.2046987 > > 5.39 180 > > Oh, P.S. I don't have a *fetish* with chimneys :-) Just these errors > cropped > up as I flew from Eastleigh to the tip of Scotland today in the Lightning. Oh, I'm glad that you are reporting such mistakes If people wouldn't do so, we'd probably never ever get notice of these. Regarding the 'lynemouthchimney' it looks like the author simply forgot to add the geometry to the repository - the respective field is completely void ;-) Martin. -- Unix _IS_ user friendly - it's just selective about who its friends are ! -- - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] encoder/altimeter & kap140.nas
On 03/03/2007 03:05 AM, Roy Vegard Ovesen wrote:
> If qqq is going to default to 10 (from instrument_mgr.cxx: new Altimeter(
> node , 10)), I think we can just drop it all together and put
> _quantum(node->getDoubleValue("quantum", 10)) in altimeter.cxx.
But it isn't "the" default.
The default for objects is 0.
The default for objects is 10.
Please take a closer look at instrument_mgr.cxx.
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] [BUG] Scenery spelling mistake
On Saturday 03 March 2007 12:57:39 Nick Warne wrote: > On Saturday 03 March 2007 12:50:14 Martin Spott wrote: > > Martin Spott wrote: > > > Thanks for pointing this out, we're going to fix it, > > > > Get a fresh export from Jon's Scenery Objects download site tomorrow, > > if you like, > > > > Martin. > > OK thanks, but I fixed the file myself - at least it is now fixed for > future. Also, while on this subject, I found a call to a missing model too, > I don't know why this is: > > Cannot find model > file "/opt/fg_scenery/Objects/w010n50/w002n55/lynemouthchimney.ac" > Failed to load 3D > model /opt/fg_scenery/Objects/w010n50/w002n55/lynemouthchimney.ac > > > ./2925641.stg:1:OBJECT_STATIC lynemouthchimney.ac -1.5192975 55.2046987 > 5.39 180 Oh, P.S. I don't have a *fetish* with chimneys :-) Just these errors cropped up as I flew from Eastleigh to the tip of Scotland today in the Lightning. Nick - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] [BUG] Scenery spelling mistake
On Saturday 03 March 2007 12:50:14 Martin Spott wrote: > Martin Spott wrote: > > Thanks for pointing this out, we're going to fix it, > > Get a fresh export from Jon's Scenery Objects download site tomorrow, > if you like, > > Martin. OK thanks, but I fixed the file myself - at least it is now fixed for future. Also, while on this subject, I found a call to a missing model too, I don't know why this is: Cannot find model file "/opt/fg_scenery/Objects/w010n50/w002n55/lynemouthchimney.ac" Failed to load 3D model /opt/fg_scenery/Objects/w010n50/w002n55/lynemouthchimney.ac ./2925641.stg:1:OBJECT_STATIC lynemouthchimney.ac -1.5192975 55.2046987 5.39 180 Nick - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] [BUG] Scenery spelling mistake
Martin Spott wrote: > Thanks for pointing this out, we're going to fix it, Get a fresh export from Jon's Scenery Objects download site tomorrow, if you like, Martin. -- Unix _IS_ user friendly - it's just selective about who its friends are ! -- - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] [BUG] Scenery spelling mistake
Hi Nick, Nick Warne wrote: > Failed to open file /opt/fg_scenery/Objects/w010n50/w002n51/DitcotChimney1.xml > > 4 -rw-r--r-- 1 nick users 184 2005-03-06 > 00:48 /opt/fg_scenery/Objects/w010n50/w002n51/DidcotChimney1.xml > > The file is correctly spelt (Didcot, not ditcot), the call to load the file > isn't. Thanks for pointing this out, we're going to fix it, Martin. -- Unix _IS_ user friendly - it's just selective about who its friends are ! -- - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] encoder/altimeter & kap140.nas
* Roy Vegard Ovesen -- Saturday 03 March 2007:
> I believe that MSVC needs the iterator to be declared before the loop:
> int i;
> for (i = 0; ; i++)
No, IIRC there was an issue with two subsequently used variables of
the same name. This didn't work, because MSVC had the scoping wrong:
for (int i = 0; ; i++) {
}
for (int i = 0; ; i++) {
}
But I see this in several places now, and there were no more complaints.
Seems like MS fixed it and those on MS Windows who actually compile
themselves use updated compilers. We can safely tell people now to
fix their setup, and don't have to "fix" perfectly fine fgfs code. :-)
m.
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] ATISs upgrade
Hi Didier, Didier Fabert wrote: > will this patch be commited in the both CVS branch? You can track the progress, especially on the atmosphere-stuff, in the two "altimeter"-related threads on this list, Martin. -- Unix _IS_ user friendly - it's just selective about who its friends are ! -- - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
[Flightgear-devel] [BUG] Scenery spelling mistake
Hi all, Failed to open file /opt/fg_scenery/Objects/w010n50/w002n51/DitcotChimney1.xml 4 -rw-r--r-- 1 nick users 184 2005-03-06 00:48 /opt/fg_scenery/Objects/w010n50/w002n51/DidcotChimney1.xml The file is correctly spelt (Didcot, not ditcot), the call to load the file isn't. http://jonathan.rawle.org/2006/11/05/a-day-of-excitement-in-didcot/ I don't know who fixes scenery items? Nick - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] encoder/altimeter & kap140.nas
On Saturday 03 March 2007 08:31, Melchior FRANZ wrote:
> I don't think it can be applied as it is. I'm no physicist and
> can't comment on the logic, but there are some formal aspects
> to fix IMHO:
>
> atmo.?xx:
>
> - code on the top level must not be indented
> - proper indentation everywhere (Frankly, 2 spaces aren't enough
> for my taste. They produce visual spaghetti code.)
I'll add:
There is a mixture of tabs and spaces here too.
> - comments in a block shall be indented aligned with the block,
> not begin in column 0
> - if (a_tvs_p) delete a_tvs_p; shall be just delete a_tvs_p;
> - cout/cerr must not be used (use SG_LOG with proper log level)
I believe that MSVC needs the iterator to be declared before the loop:
int i;
for (i = 0; ; i++)
> - for (int ii = 0; ; ii++) shall be for (int i = 0; ; i++)
> - don't add empty *and* commented out class definitions
>
> altimeter.cxx:
>
> - don't introduce tab indentation in a file that uses 4 spaces
> - if qqq stands for "quantum, then call it quantum:
> Altimeter::Altimeter ( SGPropertyNode *node, const double qqq)
If qqq is going to default to 10 (from instrument_mgr.cxx: new Altimeter(
node , 10)), I think we can just drop it all together and put
_quantum(node->getDoubleValue("quantum", 10)) in altimeter.cxx.
--
Roy Vegard Ovesen
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel
