DO NOT REPLY [Bug 25756] New: - [PATCH] LineLayoutManager.getNextBreakPoss should return null when the line consists only of suppressible content.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25756. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25756 [PATCH] LineLayoutManager.getNextBreakPoss should return null when the line consists only of suppressible content. Summary: [PATCH] LineLayoutManager.getNextBreakPoss should return null when the line consists only of suppressible content. Product: Fop Version: 1.0dev Platform: PC OS/Version: Linux Status: NEW Severity: Normal Priority: Other Component: page-master/layout AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] The patch adds a routine to test whether the line consists of suppressible content, and a routine to remove all BP of a line, and applies those at the end of a line to return null when the line consists of suppressible content.
DO NOT REPLY [Bug 25756] - [PATCH] LineLayoutManager.getNextBreakPoss should return null when the line consists only of suppressible content.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25756. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25756 [PATCH] LineLayoutManager.getNextBreakPoss should return null when the line consists only of suppressible content. --- Additional Comments From [EMAIL PROTECTED] 2003-12-25 10:24 --- Created an attachment (id=9698) The patch as described
DO NOT REPLY [Bug 25756] - [PATCH] LineLayoutManager.getNextBreakPoss should return null when the line consists only of suppressible content.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25756. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25756 [PATCH] LineLayoutManager.getNextBreakPoss should return null when the line consists only of suppressible content. --- Additional Comments From [EMAIL PROTECTED] 2003-12-25 10:25 --- Created an attachment (id=9699) A short test fo file
Output from NIST test suite
Hi, After 'fixing' the master-reference issue in my copy of the NIST test suite, I ran the tests against 0.20.5 and 1.0dev and merged the result side by side into a single .pdf file. You can download the result (1Mb) here: http://bckfnn-modules.sf.net/out-0.20.5-1.0.pdf For some reason the pdf does not display correctly in my browsers, so it is better to download it. The merged pdf file is created using iText. The square to the left contains the output from 0.20.5 and the square on the right the output from HEAD. Here is also a merge between the pdf files that comes with the NIST suite and head: http://bckfnn-modules.sf.net/out-nist-1.0.pdf There is still a few issues left to fix wink. Another way of using the test suite could be to compare a binary image of the pages against some kind of reference. Has such a approach been tried? Does anyone know of available software that can render a PDF as an image file? regards, finn
Re: Output from NIST test suite
On Thu, 2003-12-25 at 11:42, Finn Bock wrote: Hi, After 'fixing' the master-reference issue in my copy of the NIST test suite, I ran the tests against 0.20.5 and 1.0dev and merged the result side by side into a single .pdf file. Interesting technique. What tool do you use to make the side-by-side comparison ? -- John Austin [EMAIL PROTECTED]
Re: Output from NIST test suite
After 'fixing' the master-reference issue in my copy of the NIST test suite, I ran the tests against 0.20.5 and 1.0dev and merged the result side by side into a single .pdf file. [John Austin] Interesting technique. What tool do you use to make the side-by-side comparison ? This java program: http://bckfnn-modules.sf.net/PairPdf.java to drive iText: http://www.lowagie.com/iText/ which does all the heavy lifting. regards, finn
DO NOT REPLY [Bug 25758] New: - [PATCH] external-graphics scaling with just one content-xxx attribute
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25758. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25758 [PATCH] external-graphics scaling with just one content-xxx attribute Summary: [PATCH] external-graphics scaling with just one content-xxx attribute Product: Fop Version: 1.0dev Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: Other Component: page-master/layout AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Specifying just one of content-height or content-width with a value that is larger than the image size, will ignore the specified property and just add the image with its unscaled size. This patch will use the image size when neither properties are specified and calculate the missing property when one is specified. When both properties are specified, it will use the existing algorihtm to maintain the aspect ratio. It can be tested with NIST adp-height[123].
DO NOT REPLY [Bug 25758] - [PATCH] external-graphics scaling with just one content-xxx attribute
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25758. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25758 [PATCH] external-graphics scaling with just one content-xxx attribute --- Additional Comments From [EMAIL PROTECTED] 2003-12-25 16:31 --- Created an attachment (id=9700) A unified patch against HEAD
DO NOT REPLY [Bug 25758] - [PATCH] external-graphics scaling with just one content-xxx attribute
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25758. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25758 [PATCH] external-graphics scaling with just one content-xxx attribute --- Additional Comments From [EMAIL PROTECTED] 2003-12-25 16:33 --- Created an attachment (id=9701) A testcase adp-height1.fo
DO NOT REPLY [Bug 25758] - [PATCH] external-graphics scaling with just one content-xxx attribute
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25758. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25758 [PATCH] external-graphics scaling with just one content-xxx attribute --- Additional Comments From [EMAIL PROTECTED] 2003-12-25 16:33 --- Created an attachment (id=9702) A testcase image: oransqr.jpg
Re: Output from NIST test suite
On Thu, 2003-12-25 at 11:42, Finn Bock wrote: Hi, After 'fixing' the master-reference issue in my copy of the NIST test suite, I ran the tests against 0.20.5 and 1.0dev and merged the result side by side into a single .pdf file. You can download the result (1Mb) here: http://bckfnn-modules.sf.net/out-0.20.5-1.0.pdf For some reason the pdf does not display correctly in my browsers, so it is better to download it. The merged pdf file is created using iText. The square to the left contains the output from 0.20.5 and the square on the right the output from HEAD. Here is also a merge between the pdf files that comes with the NIST suite and head: http://bckfnn-modules.sf.net/out-nist-1.0.pdf There is still a few issues left to fix wink. Another way of using the test suite could be to compare a binary image of the pages against some kind of reference. Has such a approach been tried? Does anyone know of available software that can render a PDF as an image file? RedHat 9.0 (my system anyhow) includes a command 'pdftopbm' that will convert a PDF to multiple PBM (protable Bit Map) files that might be comparable. They would be convertable in to other formats such as PNG (or GIF for the patent-minded). I found the result pretty poor (ugly text badly in need of anti-aliasing). That might help contribute to keeping images similar. It would certainly help detect pixel-sized changes. That might help regression testing. There are suggestions on the Net that Ghostcript can do this sort of conversion as well. GIMP can read a PDF as well. When I tried it, I got a graphic for every pair of pages (my doc was over 133 pages). Perhaps some script-fu ... ? regards, finn -- John Austin [EMAIL PROTECTED]
Regression tests was: Re: Output from NIST test suite
John Austin wrote: RedHat 9.0 (my system anyhow) includes a command 'pdftopbm' that will convert a PDF to multiple PBM (protable Bit Map) files that might be comparable. ... It would certainly help detect pixel-sized changes. That might help regression testing. We need regression tests badly. Some problems to ponder: a) Tests need to be automated for actually being useful. JUnit seems the way to go. Unfortuanately, it's still underutiliyed in FOP. b) We don't have much *unit* tests. There's only the UtilityCodeTestSuite.java. We need much more tests for basic functionality. The problem seems to be however that an elaborated test harness needs to be written in order to do unt tests for, e.g. layout managers. c) In order to test the whole engine at once, from FO input to generating PDF/whatever, well, a binary compare with a pregenerated PDF would be as sufficient as comparing bitmap images. Problems here: + The files to compare against are binary, and consume a lot of space. Well, take a look at GenericFOPTestCase.java which uses MD5 sums, one for the FO in order to detect accidental changes to the source, and one for the result. + Even small changes have potential to break the whole test suite, even if nothing important changed, let's say the order of entries in a PDF dictionary. Rendering bitmaps from PDF eliminates this, but then you wont find regressions in non-visible stuff. All in all, if there are 143 template PDFs and a change causes mismatches for all, what will you do? Examine everything, comparing pixels, check whether there are visible differences at all, and then judge whether the original or the newly generated PDF is at fault? I don't think this will be done often. Ideas welcome! J.Pietschmann
Re: [VOTE] Finn Bock for Committer
Oleg Tkachenko wrote: J.Pietschmann wrote: Glen Mazza wrote: Therefore, I'm happy to nominate Finn Bock for committer +1 +1 +1 -- Peter B. West http://www.powerup.com.au/~pbwest/resume.html
Re: Merry Christmas/Frohe Weihnachten!
Glen Mazza wrote: Yes, thankfully Bertrand came to the rescue for us here! +1 Merry Christmas and Happy New Year everyone! +1 --- Andreas L. Delmelle [EMAIL PROTECTED] wrote: Happy Holidays ( to everyone who cares ) ! Peter -- Peter B. West http://www.powerup.com.au/~pbwest/resume.html
usage-context-of-suppress-at-line-break
Regarding the recent discussion of space and line break characteristics, I recall that Karen was engaged in a very protracted discussion with the editors on aspects of these questions. At one stage they specified a new property usage-context-of-suppress-at-line-break to resolve issues Karen had raised. To the best of my recollection, this decision was later rescinded, and a clarification added to the pre-existing properties. I have looked for information about this at the W3C, but so far have only recovered the note in http://www.w3.org/2001/10/REC-XSL-20011015-errata What would be more useful is to trace the complete thread of the discussion, including the putative rescinding of this property. If Karen is listening, she may be able to offer some guidance. I remembered this because I added usage-context-of-suppress-at-line-break to PropNames.java, and noted that I would have to remove it after I read the update from the editors. Peter -- Peter B. West http://www.powerup.com.au/~pbwest/resume.html
