Re: HEAD compile problem with JDK 1.3

2004-11-18 Thread J.Pietschmann
Glen Mazza wrote:
No--I think it is that Leader, by being a subclass of
FObj, implements the Constants interface, which has a
(class?) called LeaderPattern.
An inner interface.
 (I'm unsure why it
doesn't work in 1.3--that is strange.)
Me too. Java 1.3 didn't recognize the identifier LeaderPattern,
perhaps there was a change between 1.3 and 1.4 regarding
access to nested interfaces by implementing classes.
Anyway, what's the point of having the constants both in
the Constants interface and nested interfaces? I'm confused.
[buildfile]
Well, now that the FOP website is generated by Forrest,
the various html-* targets could be removed, couldn't they?
J.Pietschmann



Re: HEAD compile problem with JDK 1.3

2004-11-18 Thread Glen Mazza
--- J.Pietschmann [EMAIL PROTECTED] wrote:
 
 Anyway, what's the point of having the constants
 both in
 the Constants interface and nested interfaces? I'm
 confused.
 

I originally wanted to retain it just to make the code
better self-documenting.  One can see the constants
relevant for each property that one is coding with,
and code with less concern of coding a constant
outside the allowed set of constant values for the
property.

But now that I think more about it, the spec already
takes care of the former concern, and as for the
latter problem, whenever it occurs, it would just a 
bug to be identified and removed.  It would not be the
end of the world.  So I now tend to agree with
removing those nested interfaces in the Constants
class.  Any objections?

 [buildfile]
 
 Well, now that the FOP website is generated by
 Forrest,
 the various html-* targets could be removed,
 couldn't they?
 

Makes sense.

Glen



Re: HEAD compile problem with JDK 1.3

2004-11-16 Thread Glen Mazza

--- J.Pietschmann [EMAIL PROTECTED] wrote:

 Hi,
 I tried to compile Fop HEAD with JDK 1.3 (1.3.1_08)
 and got
 loads of errors like
  [javac]

...\fop\src\java\org\apache\fop\fo\flow\Leader.java:112:
Constant expression required.
  [javac] case LeaderPattern.SPACE:
  [javac] ^
 
 Surprisingly, the very same workarea compiles fine
 after a clean
 and using Java 1.4.2_03.
 
 There is no file LeaderPattern.java in the source
 tree, 

No--I think it is that Leader, by being a subclass of
FObj, implements the Constants interface, which has a
(class?) called LeaderPattern.  (I'm unsure why it
doesn't work in 1.3--that is strange.)


 BTW the buildfile could use some de-cruftification
 too (remove
 the gensrc/.../properties stuff and a few now
 meaningless subtitutions)
 

Ja, das ist eine gute Idee.  Bitte dekruften Sie der
Build-Datei.

Glen