Re: Logging for FOrayFont

2005-09-08 Thread J.Pietschmann
Victor Mote wrote: OK. Still I miss your point. Well, I think loggin is much overrated and it is really overdone in FOP. Fatal errors are fatal errors. Just throw an exception and let someone else figure out what to do. Some examples from the FOP code where logging doesn't help: public int

ForayFont dependency in graphics commons; was: Logging for FOrayFont

2005-09-06 Thread Thomas DeWeese
Hi all, So this is a tricky one. I really feel like I'm getting in the way of FOP stuff, but on the other hand as far as I can see the ForayFont stuff would have almost zero advantage for Batik's use of the PDF Transcoder. This is because Batik has to do all of it's own text layout and

Re: ForayFont dependency in graphics commons; was: Logging for FOrayFont

2005-09-06 Thread Jeremias Maerki
Thanks for chiming in, Thomas. It should be possible to have that pluggable for Batik. After all, the text bridge mechanism from Batik provides an ideal way to plug that functionality in. A few random notes on the topic: - The PDF library has dependencies on the font subsystem, so we would need

Re: Logging for FOrayFont

2005-09-06 Thread Simon Pepping
On Mon, Sep 05, 2005 at 09:35:26PM +0200, Jeremias Maerki wrote: As I said, widely differing views between Batik and FOP about this. In my own personal opinion, I'm with you. From the POV of XML Graphics Commons we have a problem. We've voted on the plan for Commons where we said that we'd try

RE: Logging for FOrayFont

2005-09-06 Thread Victor Mote
Simon Pepping wrote: It would of course be easier if all components would use a standard interface like Commons Logging. But that is not going to happen in this world. FWIW, I am not opposed to having FOray use Commons Logging instead of a home-grown interface. But that is actually an

Re: Logging for FOrayFont

2005-09-05 Thread Chris Bowditch
Jeremias Maerki wrote: I got a little shock when I realized a problem I didn't think of when we discussed moving FOP components over to XML Graphics Commons. We said we would try to remove logging code from these basic components entirely. Now, I forgot to consider the decision to use FOrayFont

Re: Logging for FOrayFont

2005-09-05 Thread Vincent Hennebert
I'm satisfied with your explanations. Please just add a LEVEL_DEBUG constant and I'm OK with your interface. OK, I have added the constant LEVEL_DEBUG back, and have also added a new one called LEVEL_TRACE. PLEASE NOTE: LEVEL_DEBUG is now equal to LEVEL_FINER (it previously was equal to

Re: Logging for FOrayFont

2005-09-05 Thread Jeremias Maerki
On 05.09.2005 17:05:48 Victor Mote wrote: Jeremias Maerki wrote: I got a little shock when I realized a problem I didn't think of when we discussed moving FOP components over to XML Graphics Commons. We said we would try to remove logging code from these basic components entirely.

Re: Logging for FOrayFont

2005-09-05 Thread Simon Pepping
On Mon, Sep 05, 2005 at 07:33:33PM +0200, Jeremias Maerki wrote: On 05.09.2005 17:05:48 Victor Mote wrote: Jeremias Maerki wrote: The design considerations are as follows: 1. FOrayFont needs to be able to log messages. For whom? For the developer or for the end-user? Because that's

Re: Logging for FOrayFont

2005-09-05 Thread J.Pietschmann
Jeremias Maerki wrote: I'm ever growing more cofident that developer-oriented logging should be done through a static logging facility (like Commons Logging) and that end-user-oriented logging needs to operate per processing run (like Avalon Logger) but not necessarily through a standard logging

Re: Logging for FOrayFont

2005-09-05 Thread Jeremias Maerki
As I said, widely differing views between Batik and FOP about this. In my own personal opinion, I'm with you. From the POV of XML Graphics Commons we have a problem. We've voted on the plan for Commons where we said that we'd try to remove the dependency on Commons Logging. If there is a problem

RE: Logging for FOrayFont

2005-09-05 Thread Victor Mote
J.Pietschmann wrote: /me ducks. Hehe. I've also thought again that designing certain interfaces (and piling them on each other) must be really really fun. Your meaning here is, at best, ambiguous. Please clarify. Victor Mote

Re: Logging for FOrayFont

2005-09-05 Thread Jeremias Maerki
I'm sorry but I've got to stop here. No energy left for this discussion. I didn't manage to get my meaning across and so we're talking about different things. I'll try to look into aXSL and FOray later and see if I can create a patch to demonstrate what I was talking about. Sorry for wasting your

Re: Logging for FOrayFont

2005-09-05 Thread J.Pietschmann
Victor Mote wrote: Your meaning here is, at best, ambiguous. Please clarify. If you've looked into a fair number of open source projects, and add projects from your work environment, you'll probably see certain abstractions over and over again. Counting the number of reincarnations, logging

Re: Logging for FOrayFont

2005-09-04 Thread Vincent Hennebert
Victor Mote a écrit : Actually there is not a level named debug, although I might have defined that constant equal to finest in one of the earlier versions. This does not appear in CVS. I would suggest you to redefine such a constant to remove any ambiguity, as as you can see it confused me.

Re: Logging for FOrayFont

2005-09-03 Thread Vincent Hennebert
Hi Victor, What I liked with the Avalon Logger is the one-to-one correspondance between it and Commons' Log; commons just has one more level which is trace. So writing a Logger adapter that delegates logs to a Log instance is trivial. Now it's different because PseudoLogger has 7 log levels

RE: Logging for FOrayFont

2005-09-03 Thread Victor Mote
Vincent Hennebert wrote: What I liked with the Avalon Logger is the one-to-one correspondance between it and Commons' Log; commons just has one more level which is trace. So writing a Logger adapter that delegates logs to a Log instance is trivial. Now it's different because