DO NOT REPLY [Bug 36015] New: - [PATCH] testcase for leaders with leader-pattern=rule
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36015. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36015 Summary: [PATCH] testcase for leaders with leader-pattern=rule Product: Fop Version: 1.0dev Platform: Other OS/Version: other Status: NEW Severity: normal Priority: P2 Component: general AssignedTo: fop-dev@xml.apache.org ReportedBy: [EMAIL PROTECTED] Attached testcase file to go into test/layoutengine/testcases -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 36015] - [PATCH] testcase for leaders with leader-pattern=rule
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36015. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36015 --- Additional Comments From [EMAIL PROTECTED] 2005-08-04 10:04 --- Created an attachment (id=15883) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=15883action=view) leader-dots.xml - Set of test for leaders of type dots Doesn't seem to work for leader-pattern-width with percentage specification. Will bug separately. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 36017] New: - [PATCH] testcase for leaders with leader-pattern=space
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36017. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36017 Summary: [PATCH] testcase for leaders with leader-pattern=space Product: Fop Version: 1.0dev Platform: Other OS/Version: other Status: NEW Severity: normal Priority: P2 Component: general AssignedTo: fop-dev@xml.apache.org ReportedBy: [EMAIL PROTECTED] Attached testcase file to go into test/layoutengine/testcases -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 36011] - Setting word-spacing on justified blocks removes justification
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36011. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36011 --- Additional Comments From [EMAIL PROTECTED] 2005-08-04 10:19 --- I'm not sure whether this behaviour is wrong. The recommendation (7.16.8) states that space This allows the user to specify a range of adjustments in addition to the default space between words. The minimum and maximum values specify the limits of the adjustment. Setting word-space=0pt (which means .minimum=0pt, .optimum=0pt, .maximum=0pt) you tell the application that there is no possible space adjustment, so there is no way to justify the text, unless adjusting explicitly-set letter-spacing. But I could just be wrong, is there any clarifying opinion? -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 36017] - [PATCH] testcase for leaders with leader-pattern=space
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36017. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36017 --- Additional Comments From [EMAIL PROTECTED] 2005-08-04 10:20 --- Created an attachment (id=15884) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=15884action=view) leader-space.xml - Set of test for leaders of type space None of the tests current generate any leaders. Will bug separately. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 36018] New: - leader-pattern=space doesn't appear to work
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36018. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36018 Summary: leader-pattern=space doesn't appear to work Product: Fop Version: 1.0dev Platform: Other OS/Version: other Status: NEW Severity: normal Priority: P2 Component: page-master/layout AssignedTo: fop-dev@xml.apache.org ReportedBy: [EMAIL PROTECTED] See testcase attached to Bug #36017. No leaders are generated. The same file produces leaders when processed through xep. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 36011] - Setting word-spacing on justified blocks removes justification
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36011. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36011 --- Additional Comments From [EMAIL PROTECTED] 2005-08-04 10:30 --- Luca, interesting point. It was my understanding from the reading of the spec that normal and 0pt are virtually the same: For normal: .optimum = (the normal inter-word space, as defined by the current font and/or the UA - the inline-progression-dimension of the glyph-area obtained by formatting the fo:character) / 2, .maximum = .optimum, .minimum = .optimum, .precedence = force, and .conditionality = discard. For a length: .optimum = length / 2, .maximum = .optimum, .minimum = .optimum, .precedence = force, and .conditionality = discard. These two formulas would give the same values for length=0pt assuming the normal inter-word space, as defined by the current font and/or the UA is the same as the inline-progression-dimension of the glyph-area obtained by formatting the fo:character. But when specifying normal the block is properly justified. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 36011] - Setting word-spacing on justified blocks removes justification
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36011. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36011 --- Additional Comments From [EMAIL PROTECTED] 2005-08-04 10:38 --- The spec contains many comments that these feature are very user agent- dependant. So I think we have some liberty (or uncertainty) on how we implement this. IMO text-align=justify should probably override a restricting word-spacing setting. In this case it should probably simply contribute minimum and optimum values but not allow the maximum constraint to restrict the stretchability necessary for the justification. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 36016] - leader-pattern-width=percentage gives error
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36016. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36016 --- Additional Comments From [EMAIL PROTECTED] 2005-08-04 10:41 --- Jeremias, OK - I will treat easy on the percentages. Manuel PS: I hope I do the right thing by the project in raising all these bugs. I certainly don't want to create unneccessary noise or distractions but thought it would be best to document any problems I encountered one by one while putting those testcases together. I think I am through all the items you flagged as yes? or TODO Write test cases on the compliance page any way. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
Re: DO NOT REPLY [Bug 36008] - [PATCH] letter-spacing testcases
[EMAIL PROTECTED] wrote: Christian: It appears we both went for this one at the same time! Its now been applied :-) Sorry for any confusion. DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36008. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36008 [EMAIL PROTECTED] changed: What|Removed |Added CC||fop-dev@xml.apache.org Status|NEW |ASSIGNED
DO NOT REPLY [Bug 36016] - leader-pattern-width=percentage gives error
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36016. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36016 --- Additional Comments From [EMAIL PROTECTED] 2005-08-04 10:50 --- Manuel, don't worry, this is absolutely great! These test cases will help us improve quality in the long term and also help keep track of all the problems. I just hope noone expects us to fix all this in very short order. Especially the fact that you already provide very short test cases in the right format helps tremendously! -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 36011] - Setting word-spacing on justified blocks removes justification
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36011. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36011 --- Additional Comments From [EMAIL PROTECTED] 2005-08-04 10:58 --- I'm unsure, too, but indeed, reading the thing again, word-spacing=0pt and word-spacing=normal seem to be the same. The space is in addition (!) to the normal spacing so it should not really be a real interaction with the spacing generated by text-align=justify. The spec says that there may be implementation-specific limits when word-spacing is negative. I still think that justification mostly overrides word-spacing if its restrictions cannot be met. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
Re: DO NOT REPLY [Bug 36008] - [PATCH] letter-spacing testcases
Try svn revert -R. Thanks for all the helping hands! On 04.08.2005 10:58:52 Christian Geisert wrote: Chris Bowditch schrieb: [EMAIL PROTECTED] wrote: Christian: It appears we both went for this one at the same time! Its now been applied :-) Sorry for any confusion. No problem, noticed it just before committing (need now to find out how to take back a svn add ;-) Will you commit the other testcases too or should I take over some? -- Christian Jeremias Maerki
Re: DO NOT REPLY [Bug 36008] - [PATCH] letter-spacing testcases
Christian Geisert wrote: Chris Bowditch schrieb: [EMAIL PROTECTED] wrote: Christian: It appears we both went for this one at the same time! Its now been applied :-) Sorry for any confusion. No problem, noticed it just before committing (need now to find out how to take back a svn add ;-) Will you commit the other testcases too or should I take over some? I don't mind either way; I'll hold off for now and commit them later today if you don't get there first :-) Chris
Re: Att: Manuel
Jeremias, On Thu, 4 Aug 2005 04:44 pm, Jeremias Maerki wrote: Manuel, given your enthusiasm for helping us (THANK YOU!) and the number of recent contributions, may I ask you to sign an Individual Contributor License Agreement (ICLA) and send that to the ASF? ... Just faxed it off. Had to get the old fax machine out of the cupboard, dust it off, reconnect, read the manual (yuk...) to find out how to set date/time etc. :-). Manuel Jeremias Maerki
DO NOT REPLY [Bug 36010] - [PATCH] word-spacing testcases
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36010. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36010 [EMAIL PROTECTED] changed: What|Removed |Added CC||fop-dev@xml.apache.org Status|NEW |ASSIGNED -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. You are on the CC list for the bug, or are watching someone who is.
DO NOT REPLY [Bug 36011] - Setting word-spacing on justified blocks removes justification
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36011. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36011 --- Additional Comments From [EMAIL PROTECTED] 2005-08-04 11:32 --- Maybe there is a case (although unlikely, I must admit!) which could make significant to have word-spacing=0pt != word-spacing=normal Let's suppose I want some text to be justified modifying only the letter spaces, while I desire word-spaces to have all the same width: I would easily set letter-spacing.minimum, .optimum and .maximum as I wish, and word- spacing=0pt. But if word-spacing=0pt is the same as normal, to avoid word space adjustment I should set word-spacing.minimum=Xpt, .optimum=0pt and .maximum=-Y, where X and Y are meant to undo the stretch and shrink of a word space (which are application dependent, so I could not know them). To be more clear: I thought that a word space min-opt-max values come from the size of a space character, let's call it W, according to the font; if the property word-spacing is explicitly set, then the resulting min-opt-max size is: W + .minimum, W + .optimum, W + .maximum while when word-spacing is normal we use some hard-coded, default values, obtaining: W + UA.min, W + UA.opt, W + UA.max But if I don't succeed in convincing you, I won't insist :-) -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 36011] - Setting word-spacing on justified blocks removes justification
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36011. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36011 --- Additional Comments From [EMAIL PROTECTED] 2005-08-04 11:57 --- As I said, I'm unsure about this. Simply the fact that there is an enum value normal for word-space and the default is not 0pt suggests that you're probably right and normal may indeed have a different meaning. Let's simply make sure all the variants are documented using test cases. They are so precious in discussions like these. I almost sound like I'm obsessed with test cases, but then I probably am. :-) -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 36010] - [PATCH] word-spacing testcases
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36010. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36010 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2005-08-04 12:03 --- Testcases added, thanks for your contribution -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. You are on the CC list for the bug, or are watching someone who is.
DO NOT REPLY [Bug 36011] - Setting word-spacing on justified blocks removes justification
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36011. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36011 --- Additional Comments From [EMAIL PROTECTED] 2005-08-04 12:11 --- Luca, your interpretation seems reasonable but I interpreted the spec to suggest for the normal case: .maximum = .optimum and .minimum = .optimum. This appears to be in conflict with your interpretation that allows for .maximum .optimum and .minimum .optimum in the normal case. Of course being so new to all of this I won't insist either :-). -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 36011] - Setting word-spacing on justified blocks removes justification
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36011. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36011 --- Additional Comments From [EMAIL PROTECTED] 2005-08-04 12:30 --- I tend to agree with Luca here. If text-align=justify then it is perfectly reasonable that word spacing is adjusted and if the user has specified a word- spacing min/max with no leeway then justification may not work. This seems reasonable as word-spacing is an advanced setting and so users who change it should be aware that it may have ramifications on justification. Another way of looking at this is text-align=justify is the case where word- spacing=0pt != word-spacing=normal Again, this seems reasonable. I am inclined to reject this bug, but perhaps we should wait for opinions from other committers first. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 36007] - letter-spacing property causes ClassCastException
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36007. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36007 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
Re: svn commit: r227338 [1/2] - /xmlgraphics/fop/trunk/test/layoutengine/testcases/
[EMAIL PROTECTED] wrote: Author: jeremias Date: Thu Aug 4 03:10:14 2005 New Revision: 227338 URL: http://svn.apache.org/viewcvs?rev=227338view=rev Log: Setting svn:eol-style and svn:keywords where necessary. Need to lookup why these are missing only on some. You beat me to this. I tried to MSN you but you were away! How do you do this using Tortoise SVN ?? Chris
DO NOT REPLY [Bug 36013] - [PATCH] testcase for leaders with leader-pattern=rule
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36013. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36013 [EMAIL PROTECTED] changed: What|Removed |Added CC||fop-dev@xml.apache.org Status|NEW |ASSIGNED --- Additional Comments From [EMAIL PROTECTED] 2005-08-04 12:43 --- Yes, noticed this problem at the tests we did at hackathon -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. You are on the CC list for the bug, or are watching someone who is.
DO NOT REPLY [Bug 36015] - [PATCH] testcase for leaders with leader-pattern=dots
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36015. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36015 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED Summary|[PATCH] testcase for leaders|[PATCH] testcase for leaders |with leader-pattern=rule |with leader-pattern=dots -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
Re: svn commit: r227338 [1/2] - /xmlgraphics/fop/trunk/test/layoutengine/testcases/
Jeremias Maerki wrote: Hehe. Right mouse button on a file, select Properties and go the the Subversion tab. There, you can set the properties per file. AFAIK, TortoiseSVN doesn't support batch operations in this area. Yes I've found it (I was looking under the SVN sub menu before). You check the recursive check box when viewing a top level folder to have all files and sub folders processed. I've used the command-line: svn propset svn:keyword Author Date Id Revision *.xml svn propset svn:eol-style native *.xml svn commit -m blah much easier. BTW, I didn't find out why certain files didn't carry the properties. I wish there was a way to easily fix the most common properties (*.xml, *.java). Isn't it just new files that don't have these properties by default. I guess it's up to the committers to add the properties when they create a new file. Chris
Re: svn commit: r227338 [1/2] - /xmlgraphics/fop/trunk/test/layoutengine/testcases/
On 04.08.2005 13:42:04 Chris Bowditch wrote: Jeremias Maerki wrote: Hehe. Right mouse button on a file, select Properties and go the the Subversion tab. There, you can set the properties per file. AFAIK, TortoiseSVN doesn't support batch operations in this area. Yes I've found it (I was looking under the SVN sub menu before). You check the recursive check box when viewing a top level folder to have all files and sub folders processed. D'oh, I'm using TortoiseSVN for such a long time that I didn't even see that new checkbox being introduced. I've used the command-line: svn propset svn:keyword Author Date Id Revision *.xml svn propset svn:eol-style native *.xml svn commit -m blah much easier. BTW, I didn't find out why certain files didn't carry the properties. I wish there was a way to easily fix the most common properties (*.xml, *.java). Isn't it just new files that don't have these properties by default. I guess it's up to the committers to add the properties when they create a new file. Well, I added most of the test cases in there and I've never paid attention to this. Maybe Subclipse adds this automatically or something like that. I will pay attention next time I add a test case. Jeremias Maerki
DO NOT REPLY [Bug 36025] New: - [PATCH] font-size testcases
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36025. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36025 Summary: [PATCH] font-size testcases Product: Fop Version: 1.0dev Platform: Other OS/Version: other Status: NEW Severity: normal Priority: P2 Component: general AssignedTo: fop-dev@xml.apache.org ReportedBy: [EMAIL PROTECTED] I'll attach 3 files for testing absolute, relative and percentage font sizes. As before they are designed to go into test/layoutengine/testcases. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 36025] - [PATCH] font-size testcases
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36025. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36025 --- Additional Comments From [EMAIL PROTECTED] 2005-08-04 13:58 --- Created an attachment (id=15887) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=15887action=view) font-size-absolute.xml - Test cases for font-size=absolute absolute font sizes don't work currently. Do we need a separate bug for that or is that a well known feature? -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 36025] - [PATCH] font-size testcases
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36025. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36025 --- Additional Comments From [EMAIL PROTECTED] 2005-08-04 13:59 --- Created an attachment (id=15888) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=15888action=view) font-size-relative.xml - Test cases for font-size=relative relative font sizes don't work currently. Do we need a separate bug for that or is that a well known feature? -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
DO NOT REPLY [Bug 36013] - [PATCH] testcase for leaders with leader-pattern=rule
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36013. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36013 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2005-08-04 14:25 --- Testcases added, thanks for your contribution -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. You are on the CC list for the bug, or are watching someone who is.
DO NOT REPLY [Bug 36025] - [PATCH] font-size testcases
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36025. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36025 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
Re: Checks for testcase was: (Re: DO NOT REPLY [Bug 36025] - [PATCH] font-size testcases)
Manuel Mall wrote: Chris, Hi Manuel, On Thu, 4 Aug 2005 09:31 pm, [EMAIL PROTECTED] wrote: ... --- Additional Comments From [EMAIL PROTECTED] ... I have added some checks to make the tests a little more effective at detecting regressions. I would be grateful if you could have a go at this yourself next time. If you're not sure how to do this, just ask on fop-dev. I was thinking myself that I needed to do something about adding stuff to the checks section but have no real idea where to start. I assume these checks are against the internal area tree? Any way, in the moment this is still a big black hole for me and I would very much appreciate any helpful suggestions how I could go best about to achieve some enlightenment in that area. The checks are actually against the Area Tree Output. You can generate it and see what it looks like for any fo by running the following command line: fop foo.fo -at foo.xml There are 2 basic checks you can do (I could be wrong; I'm not the expect here): 1) true check, useful for checking the presence/absence of an element or attribute in this XML output. It has a single attribute xpath= which is just an xpath expression which can select a node in the XML output. 2) eval check, which grabs the value of a attribute specified by the xpath attribute and checks it matches the expected value specified in the expected attribute. As an example I added some checks to your font-size tests to see that a medium font was in fact 12pt. Internally all FOP's measurements are in milli-pt, so the check actually looks for the value 12000 I hope this gives you the basic idea, Chris
Re: Checks for testcase was: (Re: DO NOT REPLY [Bug 36025] - [PATCH] font-size testcases)
I've documented some of the stuff concerning layoutengine tests on the Wiki: http://wiki.apache.org/xmlgraphics-fop/HowToCreateLayoutEngineTests I see that it was not enough, so I'll add some more info later today. Gotta run now. Sorry. On 04.08.2005 17:14:02 Manuel Mall wrote: Chris, On Thu, 4 Aug 2005 10:59 pm, Chris Bowditch wrote: Manuel Mall wrote: Chris, Hi Manuel, ... The checks are actually against the Area Tree Output. You can generate it and see what it looks like for any fo by running the following command line: fop foo.fo -at foo.xml OK, got that. There are 2 basic checks you can do (I could be wrong; I'm not the expect here): 1) true check, useful for checking the presence/absence of an element or attribute in this XML output. It has a single attribute xpath= which is just an xpath expression which can select a node in the XML output. 2) eval check, which grabs the value of a attribute specified by the xpath attribute and checks it matches the expected value specified in the expected attribute. As an example I added some checks to your font-size tests to see that a medium font was in fact 12pt. Internally all FOP's measurements are in milli-pt, so the check actually looks for the value 12000 I hope this gives you the basic idea, Thanks that's great I think I understand. Last (is there ever?) question: How can I run a testcase and test my checks.../checks section? Do I have to somehow invoke Jeremias LayoutEngineTestSuite? And if so what's the best way to do that? Thanks for your help Manuel Chris Jeremias Maerki
Re: Checks for testcase was: (Re: DO NOT REPLY [Bug 36025] - [PATCH] font-size testcases)
Manuel Mall wrote: Chris, Thanks that's great I think I understand. Cool. Thanks for all your help. Last (is there ever?) question: How can I run a testcase and test my checks.../checks section? Do I have to somehow invoke Jeremias LayoutEngineTestSuite? And if so what's the best way to do that? Well it's always a good idea to check the tests before submitting them. The layout engine tests are run as part of the build. You can tell Ant just to run a particular target in the Ant script. For example, to just run the tests and not the full build type; ant junit If a test is meant to fail, then it's a good idea to disable it by default otherwise it will cause the build to fail. You do that by adding the filename of the test to the file disabled-testcases.txt in the test/layoutengine directory. Chris
Re: Checks for testcase was: (Re: DO NOT REPLY [Bug 36025] - [PATCH] font-size testcases)
On Thu, 4 Aug 2005 11:17 pm, Jeremias Maerki wrote: I've documented some of the stuff concerning layoutengine tests on the Wiki: http://wiki.apache.org/xmlgraphics-fop/HowToCreateLayoutEngineTests I see that it was not enough, so I'll add some more info later today. Gotta run now. Sorry. Jeremias, Ahhh, that is enough for me to get going. I just didn't find the WIKI page when looking for it. The page does not seem to be linked from either the DeveloperPages or the FOPProjectPages. Not to worry, all sorted now. Gotta run as well - need to get some sleep. Manuel
DO NOT REPLY [Bug 36004] - [PATCH] Block content in inline content
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36004. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36004 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Additional Comments From [EMAIL PROTECTED] 2005-08-04 22:31 --- Moved to the branch 'inlineblock' for further development -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
Re: svn: eol-style
I am also trying svn:keywords=Id. Many files have 'svn:keywords : Author Date Id Revision', but my subversion manual suggests that of those only Id is recognized, along with e.g. LastChangedDate. Id comprises all known keywords. Simon On Thu, Aug 04, 2005 at 03:52:30PM +0200, Jeremias Maerki wrote: Maybe it would make sense to enable the auto-props feature of SVN client. See the SVN config file (on Windows found in %USERPROFILE%\Application Data\Subversion\): snip/ ### Set enable-auto-props to 'yes' to enable automatic properties ### for 'svn add' and 'svn import', it defaults to 'no'. ### Automatic properties are defined in the section 'auto-props'. # enable-auto-props = yes ### Section for configuring automatic properties. ### The format of the entries is: ### file-name-pattern = propname[=value][;propname[=value]...] ### The file-name-pattern can contain wildcards (such as '*' and ### '?'). All entries which match will be applied to the file. ### Note that auto-props functionality must be enabled, which ### is typically done by setting the 'enable-auto-props' option. # [auto-props] # *.c = svn:eol-style=native # *.cpp = svn:eol-style=native # *.h = svn:eol-style=native # *.dsp = svn:eol-style=CRLF # *.dsw = svn:eol-style=CRLF # *.sh = svn:eol-style=native;svn:executable # *.txt = svn:eol-style=native # *.png = svn:mime-type=image/png # *.jpg = svn:mime-type=image/jpeg # Makefile = svn:eol-style=native I'll give it a try. On 04.08.2005 15:44:07 Jeremias Maerki wrote: Well, for XML Files this is not a big problem usually, but for Java files it usually is. But for text files in general, native EOLs make life easier for certain people. Furthermore, I don't see any such conventions documented (which doesn't mean there's no project standard): http://xml.apache.org/fop/dev/conventions.html Within the ASF in general I see a wide-spread use of the native setting. On 04.08.2005 15:37:12 Chris Bowditch wrote: fellow devs, should this really be set to native ? I just did a merge conflicts using SVN Tortoise (BTW, SVN is really superior to CVS, Im really impressed!) and it changed the line endings of CR+LF. I thought the Project standard was Unix style LF line endings. So shouldn't this setting reflect this? Chris Jeremias Maerki Jeremias Maerki -- Simon Pepping home page: http://www.leverkruid.nl
DO NOT REPLY [Bug 36036] - [PATCH] Support for font-size=absolute and font-size=relative
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=36036. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36036 --- Additional Comments From [EMAIL PROTECTED] 2005-08-05 05:30 --- Created an attachment (id=15895) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=15895action=view) The patch -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
