Re: Volunteering to work on FOP development
Hi Jonathan, that's extremely good to hear! Welcome! Say thanks from me to your management! This is a good decision for your company as you can build knowledge on an obviously important component in your software portfolio and you can help steer FOP into directions that help you and your customers. As for starting suggestions, that is rather difficult. There are so many things that you could start. Many are quite hard, especially when it goes into the area of the layout engine. I guess the usual everygreens are OTF/CFF font support or TrueType support for PostScript output which shouldn't be all that hard but are of high value to FOP's users. But they are not tasks that are done in half a day. If you don't want to start working off the issue list of your company, you could go through the Bugzilla tracker and review some open issues. A lot is outdated (and can be closed) or just slipped through the cracks but it could be a nice (but slightly inefficient) way to get to know FOP. We'll gladly help you with pointers once you picked something to work on. On 14.09.2009 21:32:25 Jonathan Levinson wrote: Hi, My management has asked me to volunteer to help fix FOP bugs and add FOP enhancements. I'm not yet familiar with FOP internals though I've read your design documents. I work for InterSystems: www.intersystems.com http://www.intersystems.com . I'm responsible for the InterSystems reporting engine: ZEN Reports. ZEN Reports generates XSLT to transform XML to XSL-FO and uses RenderX XEP, FOP, and Antenna House for rendering engines. I have to start somewhere and a question I have is this: what would be a good starter bug or enhancement for me to work on? Can anyone give me any pointers on how to get started? Thanks! Best Regards, Jonathan S. Levinson Senior Software Developer Object Group InterSystems 617-621-0600 Jeremias Maerki
Re: DO NOT REPLY [Bug 47805] [PATCH] implements color pcl output
On 14.09.2009 22:01:08 pohukai wrote: Thank you for your comments. 1) Auto-detection wasn't meant to be detecting the actual printer capabilities but meant to determine whether grayscaling of images would take place. See line 403 of PCLGenerator. In our current use of FOP 0.20x, we have b/w images but wasn't sure how to force b/w when a color image was implemented. Ah, I see. 2) I'm new to FOP and all of it's capabilities and configuration usage. I think a lot of what I really need should be and can be handled there. I wasn't fully aware of this file. 3) I didn't change anything with scaling of the images...at least not intentionally. In my testing, with LOTS of jpg, bmp, these render correctly and print on the PCL5c perfectly. I should have phrased that differently. Sorry. The conversion to blackwhite currently does the scaling, too, because PCL can't scale images itself. You probably just missed that you'd need to scale the color images to get them to the right size. I'd like to implement TIFF compression just to get the PCL file size down. You mean CCITT compression, don't you. FYI, I've started a CCITT Group 4 compressor some time ago, but haven't finished, yet. It's kind of a little pet project of mine which I only pursue while travelling. Let me know when you start on that. I can pass you my unfinished code if you want. Please note that CCITT compression is not just interesting for PCL output but also for PDF, PostScript and AFP! And besides that Apache Commons Sanselan could also use that. So it's going to be important to keep the compressor general and not tied to PCL. 4) I wasn't aware of the 'coding' style. I didn't see a style guideline. Can you point me to one? I was paranoid of making any changes and only placed my initials in there for my reference as I was testing. Of course, these would be removed. Our conventions can be found here: http://xmlgraphics.apache.org/fop/dev/conventions.html Please also note the Checkstyle config file in FOP's root directory that can help you match our conventions. Thanks!!! JimG Bugzilla from bugzi...@apache.org wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=47805 --- Comment #4 from Jeremias Maerki jerem...@apache.org 2009-09-10 00:25:14 PDT --- I'm not seeing any auto-detection in the patch. What do you refer to? The offline PCL production doesn't allow for bi-directional querying of the printer to get its capabilities so there can't be any auto-detection anyway. As Chris noted, not all printers support PCL5C. My Brother HL-1250, for example, prints out garbage with the patch applied. IMO, it's imperative to have a configuration option to enable/disable PCL5C functionality. I see various issues with the patch: - the output is no longer compatible with PCL5 printers. - I got ByteArrayOutOfBoundsExceptions with many of my usual test images. - PJL support is disabled in a hard-coded fashion (Jim, you can disable PJL in configuration, no need to do that in code: http://xmlgraphics.apache.org/fop/trunk/output.html#pcl-configuration) - If I interpreted this correctly from my short test, the color images don't get scaled if the image is not used in its intrinsic size. - PCLGenerator.paintBitmap() converts an image to monochrome even though its later rendered in color which gives away lots of performance. Image conversion is an expensive operation. - an updated patch should be a bit closer to FOP's coding style (no tabs in particular). Also, you should remove your initials spread throughout the code. Due attribution will be given in the status file and the commit messages. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. -- View this message in context: http://www.nabble.com/DO-NOT-REPLY--Bug-47805--New%3A--PATCH--implements-color-pcl-output-tp25353950p25442523.html Sent from the FOP - Dev mailing list archive at Nabble.com. Jeremias Maerki
Re: State of OpenType Font Implementation
Hi Alex, second good news today. I guess we need to define what should be covered by Open Type. One important aspect is certainly CFF support (which I've just mentioned to Jonathan a few minutes ago). Another aspect is what Bertrand Delacrétaz started to look into: ligatures, character combination and such. CFF should be relatively easy to implement. Ligature support is going to be much harder as this will have effects into the layout engine. OpenType fonts that have TrueType glyphs and don't require the advanced typographical stuff are already supported today, but many OTF fonts have CFF glyph data. So that would be the first priority IMO. On 15.09.2009 09:23:39 Alexander Kiel wrote: Hi, I'm new to the fop-dev list but use FOP for some years already. Recently I tried to use OpenType fonts. As documented FOP doesn't support OpenType fonts yet. The last and only discussion I could found on fop-dev is from 2006 [1]. Looking into the trunk, there is not really anything done with respect to OpenType. So what is the state of OpenType support in 2009? Sure I could possibly help implementing it. Best Regards Alex [1]: http://www.mail-archive.com/fop-dev@xmlgraphics.apache.org/msg04892.html - e-mail: alexanderk...@gmx.net web:www.alexanderkiel.net Jeremias Maerki
Re: Volunteering to work on FOP development
Jonathan Levinson wrote: Hi, Hi Jonathon, My management has asked me to volunteer to help fix FOP bugs and add FOP enhancements. I’m not yet familiar with FOP internals though I’ve read your design documents. Good news indeed. FOP is short on development resources. I take it you have read the FOP Coding Guidelines [1] and got SVN client and Java IDE setup? I work for InterSystems: www.intersystems.com http://www.intersystems.com http://www.intersystems.com . I’m responsible for the InterSystems reporting engine: ZEN Reports. ZEN Reports generates XSLT to transform XML to XSL-FO and uses RenderX XEP, FOP, and Antenna House for rendering engines. I have to start somewhere and a question I have is this: what would be a good “starter bug” or enhancement for me to work on? Can anyone give me any pointers on how to get started? The trick for a newbie is to avoid the layout engine. Still there are plenty of bugs in the Renderers/Painters, FO Tree or Properties component. I had a quick flick through bugzilla and found [2] which may be an FOTree related issue and [3] which looks like a Properties bug [1] http://xmlgraphics.apache.org/fop/dev/conventions.html [2] http://issues.apache.org/bugzilla/show_bug.cgi?id=47835 [3] http://issues.apache.org/bugzilla/show_bug.cgi?id=47709 Thanks, Chris Thanks! Best Regards, Jonathan S. Levinson Senior Software Developer Object Group InterSystems 617-621-0600
Re: State of OpenType Font Implementation
Hi Jeremias, ok I think the first step would be to add CFF support into org.apache.fop.fonts.truetype.TTFFile or to split TTFFile into TrueTypeFile and OpenTypeFile and add CFF support only to OpenTypeFile. In the last hour I waded through TTFReader, TTFFile, TTFDirTabEntry and the OpenType Spec [1]. What about refactoring this code mess as a whole? I mean seriously, does all of the FOP code looks like this one? Best Regards Alex [1]: http://www.microsoft.com/typography/otspec/otff.htm - e-mail: alexanderk...@gmx.net web:www.alexanderkiel.net On Tue, 2009-09-15 at 09:48 +0200, Jeremias Maerki wrote: Hi Alex, second good news today. I guess we need to define what should be covered by Open Type. One important aspect is certainly CFF support (which I've just mentioned to Jonathan a few minutes ago). Another aspect is what Bertrand Delacrétaz started to look into: ligatures, character combination and such. CFF should be relatively easy to implement. Ligature support is going to be much harder as this will have effects into the layout engine. OpenType fonts that have TrueType glyphs and don't require the advanced typographical stuff are already supported today, but many OTF fonts have CFF glyph data. So that would be the first priority IMO. On 15.09.2009 09:23:39 Alexander Kiel wrote: Hi, I'm new to the fop-dev list but use FOP for some years already. Recently I tried to use OpenType fonts. As documented FOP doesn't support OpenType fonts yet. The last and only discussion I could found on fop-dev is from 2006 [1]. Looking into the trunk, there is not really anything done with respect to OpenType. So what is the state of OpenType support in 2009? Sure I could possibly help implementing it. Best Regards Alex [1]: http://www.mail-archive.com/fop-dev@xmlgraphics.apache.org/msg04892.html - e-mail: alexanderk...@gmx.net web:www.alexanderkiel.net Jeremias Maerki signature.asc Description: This is a digitally signed message part
Sub Version
Hi, I couldn't find any subversion numbers on the bugs which are fixed/resolved. I am very new to the FOP users/dev list. If we don't have a column 'subversion' on the bug, will it be nice to write down the subversion number in your comments? so that all the users will verify the code easily for the bugs which are resolved. Thanks, Venkat.
Re: State of OpenType Font Implementation
Alex, please note that the FOP code has been developed by multiple volunteers over the last ten years. As such, it does not always follow one clear path of design. That said, refactoring the FOP code for easier reading / maintainability is definitely wanted! The proper steps would be: - ensure that there are junit tests for the existing functionality. If not, add them. - ensure all junit tests run on your machine - refactor away, keeping in mind fop's conventions: http://xmlgraphics.apache.org/fop/dev/conventions.html Please note that FOP is currently still on Java 1.4. - ensure all junit tests still pass - create a bug report with [patch] in the subject line and attach your patch. Max Alexander Kiel schrieb: Hi Jeremias, ok I think the first step would be to add CFF support into org.apache.fop.fonts.truetype.TTFFile or to split TTFFile into TrueTypeFile and OpenTypeFile and add CFF support only to OpenTypeFile. In the last hour I waded through TTFReader, TTFFile, TTFDirTabEntry and the OpenType Spec [1]. What about refactoring this code mess as a whole? I mean seriously, does all of the FOP code looks like this one? Best Regards Alex [1]: http://www.microsoft.com/typography/otspec/otff.htm - e-mail: alexanderk...@gmx.net web:www.alexanderkiel.net On Tue, 2009-09-15 at 09:48 +0200, Jeremias Maerki wrote: Hi Alex, second good news today. I guess we need to define what should be covered by Open Type. One important aspect is certainly CFF support (which I've just mentioned to Jonathan a few minutes ago). Another aspect is what Bertrand Delacrétaz started to look into: ligatures, character combination and such. CFF should be relatively easy to implement. Ligature support is going to be much harder as this will have effects into the layout engine. OpenType fonts that have TrueType glyphs and don't require the advanced typographical stuff are already supported today, but many OTF fonts have CFF glyph data. So that would be the first priority IMO. On 15.09.2009 09:23:39 Alexander Kiel wrote: Hi, I'm new to the fop-dev list but use FOP for some years already. Recently I tried to use OpenType fonts. As documented FOP doesn't support OpenType fonts yet. The last and only discussion I could found on fop-dev is from 2006 [1]. Looking into the trunk, there is not really anything done with respect to OpenType. So what is the state of OpenType support in 2009? Sure I could possibly help implementing it. Best Regards Alex [1]: http://www.mail-archive.com/fop-dev@xmlgraphics.apache.org/msg04892.html - e-mail: alexanderk...@gmx.net web:www.alexanderkiel.net Jeremias Maerki -- http://max.berger.name/ OpenPGP ID: C93C5700 Fpr: AB6638CE472A499B3959 ADA2F989A2E5C93C5700 signature.asc Description: OpenPGP digital signature
RE: Volunteering to work on FOP development
Yes, I've read the FOP Coding Guidelines [1]. I have an SVN client (Tortoise SVN) and IDE (InteillJ IDEA) set up. Thanks for the advice on where to get started! I'm looking at [3] http://issues.apache.org/bugzilla/show_bug.cgi?id=47709, which is the failure of the amendment to the font-shorthand-test, and which you say looks like a Properties bug. Best Regards, Jonathan S. Levinson Senior Software Developer Object Group InterSystems 617-621-0600 -Original Message- From: Chris Bowditch [mailto:bowditch_ch...@hotmail.com] Sent: Tuesday, September 15, 2009 4:06 AM To: fop-dev@xmlgraphics.apache.org Subject: Re: Volunteering to work on FOP development Jonathan Levinson wrote: Hi, Hi Jonathon, My management has asked me to volunteer to help fix FOP bugs and add FOP enhancements. I'm not yet familiar with FOP internals though I've read your design documents. Good news indeed. FOP is short on development resources. I take it you have read the FOP Coding Guidelines [1] and got SVN client and Java IDE setup? I work for InterSystems: www.intersystems.com http://www.intersystems.com http://www.intersystems.com . I'm responsible for the InterSystems reporting engine: ZEN Reports. ZEN Reports generates XSLT to transform XML to XSL-FO and uses RenderX XEP, FOP, and Antenna House for rendering engines. I have to start somewhere and a question I have is this: what would be a good starter bug or enhancement for me to work on? Can anyone give me any pointers on how to get started? The trick for a newbie is to avoid the layout engine. Still there are plenty of bugs in the Renderers/Painters, FO Tree or Properties component. I had a quick flick through bugzilla and found [2] which may be an FOTree related issue and [3] which looks like a Properties bug [1] http://xmlgraphics.apache.org/fop/dev/conventions.html [2] http://issues.apache.org/bugzilla/show_bug.cgi?id=47835 [3] http://issues.apache.org/bugzilla/show_bug.cgi?id=47709 Thanks, Chris Thanks! Best Regards, Jonathan S. Levinson Senior Software Developer Object Group InterSystems 617-621-0600
Re: State of OpenType Font Implementation
Hi Max, I apologize for my not so kind words. I'm on the way to refactor the TTFFile part and hopefully add CFF support. I will follow your suggestions and issue my patch. Best Regards Alex - e-mail: alexanderk...@gmx.net web:www.alexanderkiel.net On Tue, 2009-09-15 at 17:28 +0200, Max Berger wrote: Alex, please note that the FOP code has been developed by multiple volunteers over the last ten years. As such, it does not always follow one clear path of design. That said, refactoring the FOP code for easier reading / maintainability is definitely wanted! The proper steps would be: - ensure that there are junit tests for the existing functionality. If not, add them. - ensure all junit tests run on your machine - refactor away, keeping in mind fop's conventions: http://xmlgraphics.apache.org/fop/dev/conventions.html Please note that FOP is currently still on Java 1.4. - ensure all junit tests still pass - create a bug report with [patch] in the subject line and attach your patch. Max Alexander Kiel schrieb: Hi Jeremias, ok I think the first step would be to add CFF support into org.apache.fop.fonts.truetype.TTFFile or to split TTFFile into TrueTypeFile and OpenTypeFile and add CFF support only to OpenTypeFile. In the last hour I waded through TTFReader, TTFFile, TTFDirTabEntry and the OpenType Spec [1]. What about refactoring this code mess as a whole? I mean seriously, does all of the FOP code looks like this one? Best Regards Alex [1]: http://www.microsoft.com/typography/otspec/otff.htm - e-mail: alexanderk...@gmx.net web:www.alexanderkiel.net On Tue, 2009-09-15 at 09:48 +0200, Jeremias Maerki wrote: Hi Alex, second good news today. I guess we need to define what should be covered by Open Type. One important aspect is certainly CFF support (which I've just mentioned to Jonathan a few minutes ago). Another aspect is what Bertrand Delacrétaz started to look into: ligatures, character combination and such. CFF should be relatively easy to implement. Ligature support is going to be much harder as this will have effects into the layout engine. OpenType fonts that have TrueType glyphs and don't require the advanced typographical stuff are already supported today, but many OTF fonts have CFF glyph data. So that would be the first priority IMO. On 15.09.2009 09:23:39 Alexander Kiel wrote: Hi, I'm new to the fop-dev list but use FOP for some years already. Recently I tried to use OpenType fonts. As documented FOP doesn't support OpenType fonts yet. The last and only discussion I could found on fop-dev is from 2006 [1]. Looking into the trunk, there is not really anything done with respect to OpenType. So what is the state of OpenType support in 2009? Sure I could possibly help implementing it. Best Regards Alex [1]: http://www.mail-archive.com/fop-dev@xmlgraphics.apache.org/msg04892.html - e-mail: alexanderk...@gmx.net web:www.alexanderkiel.net Jeremias Maerki signature.asc Description: This is a digitally signed message part
Re: DO NOT REPLY [Bug 47805] [PATCH] implements color pcl output
http://h2.www2.hp.com/bc/docs/support/SupportManual/bpl13210/bpl13210.pdf http://h2.www2.hp.com/bc/docs/support/SupportManual/bpl13210/bpl13210.pdf I was planning to implement HP's flavor of TIFF. See page 15-17 -- View this message in context: http://www.nabble.com/DO-NOT-REPLY--Bug-47805--New%3A--PATCH--implements-color-pcl-output-tp25353950p25458427.html Sent from the FOP - Dev mailing list archive at Nabble.com.
Re: DO NOT REPLY [Bug 47805] [PATCH] implements color pcl output
Just to further clarify. The TIFF format I was referring to is for the embedded PCL graphics (RAW, RLE, and TIFF). I wouldn't use HP's TIFF algorithm as an exporting format like PDF, PCL, or other output formats supported by FOP. pohukai wrote: http://h2.www2.hp.com/bc/docs/support/SupportManual/bpl13210/bpl13210.pdf http://h2.www2.hp.com/bc/docs/support/SupportManual/bpl13210/bpl13210.pdf I was planning to implement HP's flavor of TIFF. See page 15-17 -- View this message in context: http://www.nabble.com/DO-NOT-REPLY--Bug-47805--New%3A--PATCH--implements-color-pcl-output-tp25353950p25458683.html Sent from the FOP - Dev mailing list archive at Nabble.com.
