Re: Building Fop 1.0dev with JDK 1.3 ??
Until we decide otherwise, FOP is still targeted at JDK 1.3 but you're right it currently doesn't compile. Nobody took the time, yet, to make it compile under 1.3. It's on my list of things but there are so many little things still to do. If you could try to fix it and send a patch that would be absolutely awesome! Do you want to try? On 27.07.2005 08:14:14 Bielik, Robert wrote: The question seemed to fit in this list rather than fop-users: I've checked out the fop trunk and tried to build it with JDK 1.3, however that doesn't seem to work (getting a number of compile errors on among other things, java.awt.Color) Is the trunk known to require JDK1.4 or higher, if not, what do I need to think about ? The reason I need JDK 1.3 is that I'm trying to fit fop into an application where JRE1.3 is used, AND I need it to be able to render the (embedded) SVG in the XSL-FO which is what doesn't work for me in fop 0.20.5. TIA /Rob Jeremias Maerki
RE: Building Fop 1.0dev with JDK 1.3 ??
Phew... OK, I'll try. Though I have very limited insight into FOP to know what my changes would incur, and unfortunately _very_ limited time so I don't want you to count on me... ;) Btw, when you develop FOP, what environment are you using ? I'm thinking of cramming it into Eclipse which is sailing up to be my number 1 choice of IDE :) Regards /R -Original Message- From: Jeremias Maerki [mailto:[EMAIL PROTECTED] Sent: Wednesday, July 27, 2005 8:48 AM To: fop-dev@xmlgraphics.apache.org Subject: Re: Building Fop 1.0dev with JDK 1.3 ?? Until we decide otherwise, FOP is still targeted at JDK 1.3 but you're right it currently doesn't compile. Nobody took the time, yet, to make it compile under 1.3. It's on my list of things but there are so many little things still to do. If you could try to fix it and send a patch that would be absolutely awesome! Do you want to try? On 27.07.2005 08:14:14 Bielik, Robert wrote: The question seemed to fit in this list rather than fop-users: I've checked out the fop trunk and tried to build it with JDK 1.3, however that doesn't seem to work (getting a number of compile errors on among other things, java.awt.Color) Is the trunk known to require JDK1.4 or higher, if not, what do I need to think about ? The reason I need JDK 1.3 is that I'm trying to fit fop into an application where JRE1.3 is used, AND I need it to be able to render the (embedded) SVG in the XSL-FO which is what doesn't work for me in fop 0.20.5. TIA /Rob Jeremias Maerki
RE: Building Fop 1.0dev with JDK 1.3 ??
Ok, I've now managed to get everything to compile alright. It wasn't really any large problems. However, there is one in Java2DRenderer.java regarding ColorModel: Original code (1001): ColorModel cm = new ComponentColorModel(ColorSpace. getInstance(ColorSpace.CS_LINEAR_RGB), false, false, ColorModel.OPAQUE, DataBuffer.TYPE_BYTE); which made javac complain about wrong number of arguments. It seems that an int[] denoting the bitdepth of each color component was lacking, so I changed it to: ColorModel cm = new ComponentColorModel(ColorSpace.getInstance(ColorSpace.CS_LINEAR_RGB), new int[] {8, 8, 8}, false, false, ColorModel.OPAQUE, DataBuffer.TYPE_BYTE); I guess thats OK? (since there seems to be no alpha component) However, then ant crashes at build.xml (480) complaining about wrong timestamp format: -MM-dd'T'HH:mm:ssZ so I changed that to the other jar creation tstamp formats: MMdd-HHmmss-z Then it all goes through. However, if it'll work, that's another matter... ;) /R -Original Message- From: Jeremias Maerki [mailto:[EMAIL PROTECTED] Sent: Wednesday, July 27, 2005 9:07 AM To: fop-dev@xmlgraphics.apache.org Subject: Re: Building Fop 1.0dev with JDK 1.3 ?? On 27.07.2005 08:54:27 Bielik, Robert wrote: Phew... OK, I'll try. Though I have very limited insight into FOP to know what my changes would incur, and unfortunately _very_ limited time so I don't want you to count on me... ;) If you have very limited time then it's probably too soon for you to try out FOP Trunk. It's still work in progress and we're only planning the first preview (!) release. It's not like the whole thing is already fit for production work. It's a good time for interested people to try out the code and provide some feedback (or even better, fixes). Btw, when you develop FOP, what environment are you using ? I'm thinking of cramming it into Eclipse which is sailing up to be my number 1 choice of IDE :) You're free to choose. I personally use Eclipse as do a few others. Just make sure you run ant codegen to create the build/gensrc directory which you have to add to the source path. http://wiki.apache.org/xmlgraphics-fop/FOPIDESetupGuide Regards /R -Original Message- From: Jeremias Maerki [mailto:[EMAIL PROTECTED] Sent: Wednesday, July 27, 2005 8:48 AM To: fop-dev@xmlgraphics.apache.org Subject: Re: Building Fop 1.0dev with JDK 1.3 ?? Until we decide otherwise, FOP is still targeted at JDK 1.3 but you're right it currently doesn't compile. Nobody took the time, yet, to make it compile under 1.3. It's on my list of things but there are so many little things still to do. If you could try to fix it and send a patch that would be absolutely awesome! Do you want to try? On 27.07.2005 08:14:14 Bielik, Robert wrote: The question seemed to fit in this list rather than fop-users: I've checked out the fop trunk and tried to build it with JDK 1.3, however that doesn't seem to work (getting a number of compile errors on among other things, java.awt.Color) Is the trunk known to require JDK1.4 or higher, if not, what do I need to think about ? The reason I need JDK 1.3 is that I'm trying to fit fop into an application where JRE1.3 is used, AND I need it to be able to render the (embedded) SVG in the XSL-FO which is what doesn't work for me in fop 0.20.5. TIA /Rob Jeremias Maerki Jeremias Maerki
Re: Building Fop 1.0dev with JDK 1.3 ??
Thanks for taking the time. Are you sure that these are all the changes that were necessary? When I change what you indicated here, I still get a few other errors. If you made more than just these modifications would you please send us a patch so I can put the changes into the repository? The thing that surprises me is the timestamp stuff but that should be no problem since it is only informational. The fix in Java2DRenderer looks fine. I'll verify that it still works when I add the changes to the repo. On 27.07.2005 10:09:25 Bielik, Robert wrote: Ok, I've now managed to get everything to compile alright. It wasn't really any large problems. However, there is one in Java2DRenderer.java regarding ColorModel: Original code (1001): ColorModel cm = new ComponentColorModel(ColorSpace. getInstance(ColorSpace.CS_LINEAR_RGB), false, false, ColorModel.OPAQUE, DataBuffer.TYPE_BYTE); which made javac complain about wrong number of arguments. It seems that an int[] denoting the bitdepth of each color component was lacking, so I changed it to: ColorModel cm = new ComponentColorModel(ColorSpace.getInstance(ColorSpace.CS_LINEAR_RGB), new int[] {8, 8, 8}, false, false, ColorModel.OPAQUE, DataBuffer.TYPE_BYTE); I guess thats OK? (since there seems to be no alpha component) However, then ant crashes at build.xml (480) complaining about wrong timestamp format: -MM-dd'T'HH:mm:ssZ so I changed that to the other jar creation tstamp formats: MMdd-HHmmss-z Then it all goes through. However, if it'll work, that's another matter... ;) /R -Original Message- From: Jeremias Maerki [mailto:[EMAIL PROTECTED] Sent: Wednesday, July 27, 2005 9:07 AM To: fop-dev@xmlgraphics.apache.org Subject: Re: Building Fop 1.0dev with JDK 1.3 ?? On 27.07.2005 08:54:27 Bielik, Robert wrote: Phew... OK, I'll try. Though I have very limited insight into FOP to know what my changes would incur, and unfortunately _very_ limited time so I don't want you to count on me... ;) If you have very limited time then it's probably too soon for you to try out FOP Trunk. It's still work in progress and we're only planning the first preview (!) release. It's not like the whole thing is already fit for production work. It's a good time for interested people to try out the code and provide some feedback (or even better, fixes). Btw, when you develop FOP, what environment are you using ? I'm thinking of cramming it into Eclipse which is sailing up to be my number 1 choice of IDE :) You're free to choose. I personally use Eclipse as do a few others. Just make sure you run ant codegen to create the build/gensrc directory which you have to add to the source path. http://wiki.apache.org/xmlgraphics-fop/FOPIDESetupGuide Regards /R -Original Message- From: Jeremias Maerki [mailto:[EMAIL PROTECTED] Sent: Wednesday, July 27, 2005 8:48 AM To: fop-dev@xmlgraphics.apache.org Subject: Re: Building Fop 1.0dev with JDK 1.3 ?? Until we decide otherwise, FOP is still targeted at JDK 1.3 but you're right it currently doesn't compile. Nobody took the time, yet, to make it compile under 1.3. It's on my list of things but there are so many little things still to do. If you could try to fix it and send a patch that would be absolutely awesome! Do you want to try? On 27.07.2005 08:14:14 Bielik, Robert wrote: The question seemed to fit in this list rather than fop-users: I've checked out the fop trunk and tried to build it with JDK 1.3, however that doesn't seem to work (getting a number of compile errors on among other things, java.awt.Color) Is the trunk known to require JDK1.4 or higher, if not, what do I need to think about ? The reason I need JDK 1.3 is that I'm trying to fit fop into an application where JRE1.3 is used, AND I need it to be able to render the (embedded) SVG in the XSL-FO which is what doesn't work for me in fop 0.20.5. TIA /Rob Jeremias Maerki Jeremias Maerki Jeremias Maerki
RE: Building Fop 1.0dev with JDK 1.3 ??
No, there were a couple of other changes. They were as follows: 1) In PageSequenceLayoutManager.java inner class PageBreaker, all 'log.' were changed to 'pslm.log.' so that the log instance in PageSeq...Manager.java is called. 2) In org.apache.fop.render.bitmap.TIFFRenderer the getLogger() call in the inner class LazyPageImagesIterator method next() was out-commented. I'm not sure how to get to TIFFRenderer.getLogger() from here. 3) In org.apache.fop.render.java2d.Java2DRenderer all calls to Color constants were changed to lower case. Here it was Color.WHITE - Color.white. 4) In org.apache.fop.render.pdf.PDFXMLHandler it was Color.BLACK - Color.black . If memory serves me right, that was it :) /R -Original Message- From: Jeremias Maerki [mailto:[EMAIL PROTECTED] Sent: Wednesday, July 27, 2005 10:34 AM To: fop-dev@xmlgraphics.apache.org Subject: Re: Building Fop 1.0dev with JDK 1.3 ?? Thanks for taking the time. Are you sure that these are all the changes that were necessary? When I change what you indicated here, I still get a few other errors. If you made more than just these modifications would you please send us a patch so I can put the changes into the repository? The thing that surprises me is the timestamp stuff but that should be no problem since it is only informational. The fix in Java2DRenderer looks fine. I'll verify that it still works when I add the changes to the repo. On 27.07.2005 10:09:25 Bielik, Robert wrote: Ok, I've now managed to get everything to compile alright. It wasn't really any large problems. However, there is one in Java2DRenderer.java regarding ColorModel: Original code (1001): ColorModel cm = new ComponentColorModel(ColorSpace. getInstance(ColorSpace.CS_LINEAR_RGB), false, false, ColorModel.OPAQUE, DataBuffer.TYPE_BYTE); which made javac complain about wrong number of arguments. It seems that an int[] denoting the bitdepth of each color component was lacking, so I changed it to: ColorModel cm = new ComponentColorModel(ColorSpace.getInstance(ColorSpace.CS_LINEAR_RGB), new int[] {8, 8, 8}, false, false, ColorModel.OPAQUE, DataBuffer.TYPE_BYTE); I guess thats OK? (since there seems to be no alpha component) However, then ant crashes at build.xml (480) complaining about wrong timestamp format: -MM-dd'T'HH:mm:ssZ so I changed that to the other jar creation tstamp formats: MMdd-HHmmss-z Then it all goes through. However, if it'll work, that's another matter... ;) /R -Original Message- From: Jeremias Maerki [mailto:[EMAIL PROTECTED] Sent: Wednesday, July 27, 2005 9:07 AM To: fop-dev@xmlgraphics.apache.org Subject: Re: Building Fop 1.0dev with JDK 1.3 ?? On 27.07.2005 08:54:27 Bielik, Robert wrote: Phew... OK, I'll try. Though I have very limited insight into FOP to know what my changes would incur, and unfortunately _very_ limited time so I don't want you to count on me... ;) If you have very limited time then it's probably too soon for you to try out FOP Trunk. It's still work in progress and we're only planning the first preview (!) release. It's not like the whole thing is already fit for production work. It's a good time for interested people to try out the code and provide some feedback (or even better, fixes). Btw, when you develop FOP, what environment are you using ? I'm thinking of cramming it into Eclipse which is sailing up to be my number 1 choice of IDE :) You're free to choose. I personally use Eclipse as do a few others. Just make sure you run ant codegen to create the build/gensrc directory which you have to add to the source path. http://wiki.apache.org/xmlgraphics-fop/FOPIDESetupGuide Regards /R -Original Message- From: Jeremias Maerki [mailto:[EMAIL PROTECTED] Sent: Wednesday, July 27, 2005 8:48 AM To: fop-dev@xmlgraphics.apache.org Subject: Re: Building Fop 1.0dev with JDK 1.3 ?? Until we decide otherwise, FOP is still targeted at JDK 1.3 but you're right it currently doesn't compile. Nobody took the time, yet, to make it compile under 1.3. It's on my list of things but there are so many little things still to do. If you could try to fix it and send a patch that would be absolutely awesome! Do you want to try? On 27.07.2005 08:14:14 Bielik, Robert wrote: The question seemed to fit in this list rather than fop-users: I've checked out the fop trunk and tried to build it with JDK 1.3, however that doesn't seem to work (getting a number of compile errors on among other things, java.awt.Color
Re: Building Fop 1.0dev with JDK 1.3 ??
I see. So, do you know how to create a patch? Just run svn diff mydiff.txt and send us the file. That way I don't have to recreate all your changes. Thanks in advance! On 27.07.2005 10:44:54 Bielik, Robert wrote: No, there were a couple of other changes. They were as follows: 1) In PageSequenceLayoutManager.java inner class PageBreaker, all 'log.' were changed to 'pslm.log.' so that the log instance in PageSeq...Manager.java is called. 2) In org.apache.fop.render.bitmap.TIFFRenderer the getLogger() call in the inner class LazyPageImagesIterator method next() was out-commented. I'm not sure how to get to TIFFRenderer.getLogger() from here. 3) In org.apache.fop.render.java2d.Java2DRenderer all calls to Color constants were changed to lower case. Here it was Color.WHITE - Color.white. 4) In org.apache.fop.render.pdf.PDFXMLHandler it was Color.BLACK - Color.black . If memory serves me right, that was it :) /R -Original Message- From: Jeremias Maerki [mailto:[EMAIL PROTECTED] Sent: Wednesday, July 27, 2005 10:34 AM To: fop-dev@xmlgraphics.apache.org Subject: Re: Building Fop 1.0dev with JDK 1.3 ?? Thanks for taking the time. Are you sure that these are all the changes that were necessary? When I change what you indicated here, I still get a few other errors. If you made more than just these modifications would you please send us a patch so I can put the changes into the repository? The thing that surprises me is the timestamp stuff but that should be no problem since it is only informational. The fix in Java2DRenderer looks fine. I'll verify that it still works when I add the changes to the repo. On 27.07.2005 10:09:25 Bielik, Robert wrote: Ok, I've now managed to get everything to compile alright. It wasn't really any large problems. However, there is one in Java2DRenderer.java regarding ColorModel: Original code (1001): ColorModel cm = new ComponentColorModel(ColorSpace. getInstance(ColorSpace.CS_LINEAR_RGB), false, false, ColorModel.OPAQUE, DataBuffer.TYPE_BYTE); which made javac complain about wrong number of arguments. It seems that an int[] denoting the bitdepth of each color component was lacking, so I changed it to: ColorModel cm = new ComponentColorModel(ColorSpace.getInstance(ColorSpace.CS_LINEAR_RGB), new int[] {8, 8, 8}, false, false, ColorModel.OPAQUE, DataBuffer.TYPE_BYTE); I guess thats OK? (since there seems to be no alpha component) However, then ant crashes at build.xml (480) complaining about wrong timestamp format: -MM-dd'T'HH:mm:ssZ so I changed that to the other jar creation tstamp formats: MMdd-HHmmss-z Then it all goes through. However, if it'll work, that's another matter... ;) /R -Original Message- From: Jeremias Maerki [mailto:[EMAIL PROTECTED] Sent: Wednesday, July 27, 2005 9:07 AM To: fop-dev@xmlgraphics.apache.org Subject: Re: Building Fop 1.0dev with JDK 1.3 ?? On 27.07.2005 08:54:27 Bielik, Robert wrote: Phew... OK, I'll try. Though I have very limited insight into FOP to know what my changes would incur, and unfortunately _very_ limited time so I don't want you to count on me... ;) If you have very limited time then it's probably too soon for you to try out FOP Trunk. It's still work in progress and we're only planning the first preview (!) release. It's not like the whole thing is already fit for production work. It's a good time for interested people to try out the code and provide some feedback (or even better, fixes). Btw, when you develop FOP, what environment are you using ? I'm thinking of cramming it into Eclipse which is sailing up to be my number 1 choice of IDE :) You're free to choose. I personally use Eclipse as do a few others. Just make sure you run ant codegen to create the build/gensrc directory which you have to add to the source path. http://wiki.apache.org/xmlgraphics-fop/FOPIDESetupGuide Regards /R -Original Message- From: Jeremias Maerki [mailto:[EMAIL PROTECTED] Sent: Wednesday, July 27, 2005 8:48 AM To: fop-dev@xmlgraphics.apache.org Subject: Re: Building Fop 1.0dev with JDK 1.3 ?? Until we decide otherwise, FOP is still targeted at JDK 1.3 but you're right it currently doesn't compile. Nobody took the time, yet, to make it compile under 1.3. It's on my list of things but there are so many little things still to do. If you could try to fix it and send a patch that would be absolutely awesome! Do you want
RE: Building Fop 1.0dev with JDK 1.3 ??
Ok, diff file is attached. build.properties and build.xml is included in it but I guess you can scrap that part... Regards, /Robert -Original Message- From: Jeremias Maerki [mailto:[EMAIL PROTECTED] Sent: Wednesday, July 27, 2005 10:50 AM To: fop-dev@xmlgraphics.apache.org Subject: Re: Building Fop 1.0dev with JDK 1.3 ?? I see. So, do you know how to create a patch? Just run svn diff mydiff.txt and send us the file. That way I don't have to recreate all your changes. Thanks in advance! Index: src/java/org/apache/fop/render/java2d/Java2DRenderer.java === --- src/java/org/apache/fop/render/java2d/Java2DRenderer.java (revision 225262) +++ src/java/org/apache/fop/render/java2d/Java2DRenderer.java (working copy) @@ -883,7 +883,7 @@ state.getGraph().draw(line); // lower Leader line.setLine(startx, starty + thickness, endx, starty + thickness); -state.getGraph().setColor(Color.WHITE); +state.getGraph().setColor(Color.white); state.getGraph().draw(line); // TODO the implementation could be nicer, f.eg. with triangles at @@ -904,7 +904,7 @@ state.getGraph().draw(line); // upperLeader line.setLine(startx, starty, endx, starty); -state.getGraph().setColor(Color.WHITE); +state.getGraph().setColor(Color.white); state.getGraph().draw(line); // TODO the implementation could be nicer, f.eg. with triangles at @@ -998,9 +998,10 @@ byte[] raw = fopimage.getBitmaps(); // TODO Hardcoded color and sample models, FIX ME! -ColorModel cm = new ComponentColorModel(ColorSpace -.getInstance(ColorSpace.CS_LINEAR_RGB), false, false, -ColorModel.OPAQUE, DataBuffer.TYPE_BYTE); +ColorModel cm = new ComponentColorModel(ColorSpace.getInstance(ColorSpace.CS_LINEAR_RGB), + new int[] {8, 8, 8}, + false, false, + ColorModel.OPAQUE, DataBuffer.TYPE_BYTE); SampleModel sampleModel = new PixelInterleavedSampleModel( DataBuffer.TYPE_BYTE, w, h, 3, w * 3, new int[] { 0, 1, 2 }); DataBuffer dbuf = new DataBufferByte(raw, w * h * 3); Index: src/java/org/apache/fop/render/pdf/PDFXMLHandler.java === --- src/java/org/apache/fop/render/pdf/PDFXMLHandler.java (revision 225262) +++ src/java/org/apache/fop/render/pdf/PDFXMLHandler.java (working copy) @@ -266,8 +266,8 @@ PDFRenderer renderer = (PDFRenderer)context.getRenderer(); renderer.saveGraphicsState(); //pdfInfo.currentStream.add(q\n); -renderer.setColor(Color.BLACK, false, null); -renderer.setColor(Color.BLACK, true, null); +renderer.setColor(Color.black, false, null); +renderer.setColor(Color.black, true, null); // transform so that the coordinates (0,0) is from the top left // and positive is down and to the right. (0,0) is where the // viewBox puts it. Index: src/java/org/apache/fop/render/bitmap/TIFFRenderer.java === --- src/java/org/apache/fop/render/bitmap/TIFFRenderer.java (revision 225262) +++ src/java/org/apache/fop/render/bitmap/TIFFRenderer.java (working copy) @@ -185,7 +185,7 @@ } public Object next() { -getLogger().debug([ + (current + 1) + ]); +//getLogger().debug([ + (current + 1) + ]); // Renders current page as image BufferedImage pageImage = null; Index: src/java/org/apache/fop/layoutmgr/PageSequenceLayoutManager.java === --- src/java/org/apache/fop/layoutmgr/PageSequenceLayoutManager.java (revision 225262) +++ src/java/org/apache/fop/layoutmgr/PageSequenceLayoutManager.java (working copy) @@ -188,7 +188,7 @@ needColumnBalancing = (childLC.getNextSpan() == Constants.EN_ALL); } if (needColumnBalancing) { -log.debug(Column balancing necessary for the next element list!!!); +pslm.log.debug(Column balancing necessary for the next element list!!!); } return nextSequenceStartsOn; } @@ -302,8 +302,8 @@ protected void doPhase3(PageBreakingAlgorithm alg, int partCount, BlockSequence originalList, BlockSequence effectiveList) { if (needColumnBalancing) { -log.debug(Column balancing now!!!); - log.debug(===); +pslm.log.debug(Column balancing now
Re: Building Fop 1.0dev with JDK 1.3 ??
Thanks a lot, Robert. This saved me a lot of time. I've committed your patch to the repository. http://svn.apache.org/viewcvs?rev=225486view=rev On 27.07.2005 10:56:19 Bielik, Robert wrote: Ok, diff file is attached. build.properties and build.xml is included in it but I guess you can scrap that part... Regards, /Robert -Original Message- From: Jeremias Maerki [mailto:[EMAIL PROTECTED] Sent: Wednesday, July 27, 2005 10:50 AM To: fop-dev@xmlgraphics.apache.org Subject: Re: Building Fop 1.0dev with JDK 1.3 ?? I see. So, do you know how to create a patch? Just run svn diff mydiff.txt and send us the file. That way I don't have to recreate all your changes. Thanks in advance! Jeremias Maerki
Re: Building Fop 1.0dev with JDK 1.3 ??
That was to be expected. Run a svn revert -R .. This will revert all the files to the state in the repository. Note that you will lose any changes that you made since you sent the patch. HTH. On 27.07.2005 14:17:17 Bielik, Robert wrote: You're welcome :) However, I did a svn up and several .java files had conflict resolve markers in them ( = ). I'm not used to svn, is there something more I need to do? /Robert -Original Message- From: Jeremias Maerki [mailto:[EMAIL PROTECTED] Sent: Wednesday, July 27, 2005 12:02 PM To: fop-dev@xmlgraphics.apache.org Subject: Re: Building Fop 1.0dev with JDK 1.3 ?? Thanks a lot, Robert. This saved me a lot of time. I've committed your patch to the repository. http://svn.apache.org/viewcvs?rev=225486view=rev On 27.07.2005 10:56:19 Bielik, Robert wrote: Ok, diff file is attached. build.properties and build.xml is included in it but I guess you can scrap that part... Regards, /Robert -Original Message- From: Jeremias Maerki [mailto:[EMAIL PROTECTED] Sent: Wednesday, July 27, 2005 10:50 AM To: fop-dev@xmlgraphics.apache.org Subject: Re: Building Fop 1.0dev with JDK 1.3 ?? I see. So, do you know how to create a patch? Just run svn diff mydiff.txt and send us the file. That way I don't have to recreate all your changes. Thanks in advance! Jeremias Maerki Jeremias Maerki