Re: Codeformatting finished

2001-08-01 Thread Tore Engvig
On Wed, 1 Aug 2001 [EMAIL PROTECTED] wrote: Hi. Good, but some typo and other files suffer from same un-escaped problem. Attached patch will fix typos and other files. Thanks, I commited your patch. I'll do a thorough check for unicode escapes tomorrow and will also take a look at

Re: Codeformatting finished

2001-07-31 Thread Tore Engvig
On Mon, 30 Jul 2001, Arved Sandstrom wrote: I see in ViewCVS that everything looks OK, and I managed to 'cvs update' one file as a test, but I can't 'cvs checkout' at the moment. Anyone else having this problem? Nope, I checked out just now. [snip] If I can figure out exactly what it is

Re: Codeformatting finished

2001-07-31 Thread s-sasaki
Hi. After codeformatting, some file is broken, I guess. Looking into org/apache/fop/fonts/Glyphs.java and org/apache/fop/layout/LineArea.java, for example, unicode-escaped characters(such as \u2297) become unescaped or ?. (Maybe, characters in ISO-8859-1 got unescaped, and others become ?.)

Re: Codeformatting finished

2001-07-31 Thread Peter B. West
I've noticed that the formatter has been pretty aggressive in overriding the right margin. It has exceeded 80 cols in files which had conformed to that margin (e.g. DocumentReader.java), going to such lengths as to merge string constants which had previously been split with +, and merging

Re: Codeformatting finished

2001-07-30 Thread Arved Sandstrom
On Monday 30 July 2001 21:38, you wrote: It's also a bit unfortunate that Mark's patch isn't yet commited. Anyone volunteer for this? It's just too big for me. I see in ViewCVS that everything looks OK, and I managed to 'cvs update' one file as a test, but I can't 'cvs checkout' at the