Re: Code Quality Metrics

2008-06-13 Thread Chris Bowditch
Max Berger wrote: Hi Max, Many of these could be automatically solved using the eclipse "cleanup" tools (which can actually be called on the whole src dir!). However, that would result in a change in almost every file, and making merging of separate branches almost impossible. This shoul

Re: Code Quality Metrics

2008-06-13 Thread Vincent Hennebert
Hi, Jeremias Maerki wrote: > I'm scared by the thought of having a program "clean" our source code > changing lots of files. I prefer the approach that the devs shall try to > improve the code while they are working on it. Agreed. Even if that doesn’t prevent us from scheduling a big “code cleanu

Print JPEG HeadlessException - Please Help

2008-06-13 Thread Surj
Ok i am using fop-0.20.5 and all I am trying to do is get a jpeg images and send it to a postscript printer, i think this did work at some point but it is difficult to tell with so many releases. So the code looks something like this: PrinterID printerID = getPrinterID(); Process process

Re: Code Quality Metrics

2008-06-13 Thread Max Berger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Vincent, Vincent Hennebert schrieb: >> 18000 PMD violations is just sick. Things like rule [1] doesn't really help >> the source code. We can do that if we get a budget for >> nuclear-power-plant-grade >> software. > Same here I guess. Now may be the

Non-applicable properties? (was: ClassCastException when using Table Cells in FOP 0.95B)

2008-06-13 Thread Andreas Delmelle
>- Oorspronkelijk bericht - >Van: Andreas Delmelle [mailto:[EMAIL PROTECTED] >Verzonden: vrijdag, juni 13, 2008 01:18 PM > >>- Oorspronkelijk bericht - >>Van: Vincent Hennebert [mailto:[EMAIL PROTECTED] >>Verzonden: vrijdag, juni 13, 2008 12:17 PM >> > >> >>FOP lacks of robustness h

Re: Code Quality Metrics

2008-06-13 Thread Andreas Delmelle
>- Oorspronkelijk bericht - >Van: Max Berger [mailto:[EMAIL PROTECTED] >Verzonden: vrijdag, juni 13, 2008 01:11 PM > >> +1 >> I must say, I’ve never really grasped the benefit of doing this. I’d be >> happy to be enlightened, though. > >Sure: > >Declaring a parameter / variable as final mak

Re: Non-applicable properties? (was: ClassCastException when using Table Cells in FOP 0.95B)

2008-06-13 Thread Andreas Delmelle
>- Oorspronkelijk bericht - >Van: Andreas Delmelle [mailto:[EMAIL PROTECTED] >Verzonden: vrijdag, juni 13, 2008 03:56 PM > In this case, all it takes is one look at the property definition (*) to find > out > that the behavior is only defined for fo:table-cell and fo:table-column. forg

Re: Print JPEG HeadlessException - Please Help

2008-06-13 Thread Surj
Oh by the way i am using Java 1.4.2.8 if that makes a diff or not. Surj wrote: > > Ok i am using fop-0.20.5 and all I am trying to do is get a jpeg images > and send it to a postscript printer, i think this did work at some point > but it is difficult to tell with so many releases. So the c

Re: Print JPEG HeadlessException - Please Help

2008-06-13 Thread Andreas Delmelle
>- Oorspronkelijk bericht - >Van: Surj [mailto:[EMAIL PROTECTED] >Verzonden: vrijdag, juni 13, 2008 05:07 PM > >Oh by the way i am using Java 1.4.2.8 if that makes a diff or not. > >Surj wrote: >> >> Ok i am using fop-0.20.5 and all I am trying to do is get a jpeg images >> and send it to a

Re: Non-applicable properties? (was: ClassCastException when using Table Cells in FOP 0.95B)

2008-06-13 Thread Chris Bowditch
Andreas Delmelle wrote: In the meantime, I made this change locally, but stumbled on the fact that we do not have an event defined for non-applicable properties. Now I'm wondering whether we should warn about those at all. According to the XSL-FO Recommendation, any property may be specifie

Re: Code Quality Metrics

2008-06-13 Thread Vincent Hennebert
Hi, Thanks for your explanation. Max Berger wrote: >>> [1] >>> http://pmd.sourceforge.net/rules/optimizations.html#MethodArgumentCouldBeFinal > >> +1 >> I must say, I’ve never really grasped the benefit of doing this. I’d be >> happy to be enlightened, though. > > Sure: > > Declaring a parame

Re: Non-applicable properties? (was: ClassCastException when using Table Cells in FOP 0.95B)

2008-06-13 Thread Vincent Hennebert
Chris, Andreas, You’re both right of course. I didn’t have that possibility in mind when writing my post to fop-dev. No warning needed indeed :-) > Andreas Delmelle wrote: >> The only modification would be: >> * surrounding the method body of >> ColumnNumberPropertyMaker.make(PropertyList, Stri

Re: Print JPEG HeadlessException - Please Help

2008-06-13 Thread Surj
Yes the 'java.awt.headless=true' specified as a parameter when starting up the weblogic container, is there any other way of setting this i.e. programmatically during startup. Thanks Andreas Delmelle-2 wrote: > >>- Oorspronkelijk bericht - >>Van: Surj [mailto:[EMAIL PROTECTED] >>Verz

Re: Code Quality Metrics

2008-06-13 Thread Andreas Delmelle
>- Oorspronkelijk bericht - >Van: Vincent Hennebert [mailto:[EMAIL PROTECTED] >Verzonden: vrijdag, juni 13, 2008 08:31 PM >FWIW, I do re-assign local variables sometimes (rarely). When the new >value serves the same purpose, and creating a new variable with another >name would actually loo

Re: Print JPEG HeadlessException - Please Help

2008-06-13 Thread Andreas Delmelle
>- Oorspronkelijk bericht - >Van: Surj [mailto:[EMAIL PROTECTED] >Verzonden: vrijdag, juni 13, 2008 09:23 PM > >Yes the 'java.awt.headless=true' specified as a parameter when starting up >the weblogic container, is there any other way of setting this i.e. >programmatically during startup.

Re: Non-applicable properties? (was: ClassCastException when using Table Cells in FOP 0.95B)

2008-06-13 Thread Andreas Delmelle
>- Oorspronkelijk bericht - >Van: Vincent Hennebert [mailto:[EMAIL PROTECTED] >Verzonden: vrijdag, juni 13, 2008 08:40 PM > >You’re both right of course. I didn’t have that possibility in mind when >writing my post to fop-dev. No warning needed indeed :-) [Me: ] >>> * if it is not a

Re: Code Quality Metrics

2008-06-13 Thread Cameron McCormack
Max Berger: > since this came up, here is a list of tools I use for software quality > checking (and all them them can check for generic list types). All of > them have Eclipse and maven plugins (and ant tasks, and ) Incidentally, I would be happy too if we had some written-down guidelines