Hi, Jeremias Maerki wrote: > I'm scared by the thought of having a program "clean" our source code > changing lots of files. I prefer the approach that the devs shall try to > improve the code while they are working on it.
Agreed. Even if that doesn’t prevent us from scheduling a big “code cleanupathon” when we’re ready, i.e., at a moment where there’s no active branch, only the Trunk. Far, far away? Probably ;-) > BTW, I think there's one or two rules in our Checkstyle file that > probably should/could be removed. For example, the frequent warning > about "field hiding" and "Utility classes should not have a public > constructor". But that's a separate discussion I guess. I’ve been wanting to lauch this discussion for a while. It definitely makes sense to re-visit all of the rules and decide upon a set that we really want to follow. That should encourage devs to take checkstyle warnings more into account, instead of just thinking: “That bl... checkstyle annoys me with all its stupid warnings”. I must confess that that’s what I’m thinking myself sometimes :-\ > 18000 PMD violations is just sick. Things like rule [1] doesn't really help > the source code. We can do that if we get a budget for > nuclear-power-plant-grade > software. Same here I guess. Now may be the right time to launch the debate, actually. I’ll try to gather some energy in the next days for that. > [1] > http://pmd.sourceforge.net/rules/optimizations.html#MethodArgumentCouldBeFinal +1 I must say, I’ve never really grasped the benefit of doing this. I’d be happy to be enlightened, though. > On 12.06.2008 08:28:35 Max Berger wrote: >> Dear Fop-Devs, >> >> Jeremias is right - you actually need to use the output of these >> reports. At this time there are: >> >> 1849 checkstyle violations >> 18702 pmd violations >> possible (find)bugs. >> >> Many of these could be automatically solved using the eclipse >> "cleanup" tools (which can actually be called on the whole src dir!). >> However, that would result in a change in almost every file, and >> making merging of separate branches almost impossible. This should >> therefore not be done until 0.95 is released, to allow backporting. >> The main question is, should it be done at all? >> >> Max <snip/> Vincent -- Vincent Hennebert Anyware Technologies http://people.apache.org/~vhennebert http://www.anyware-tech.com Apache FOP Committer FOP Development/Consulting
