Re: [VOTE] Merge Temp_WhitespaceManagement to trunk

2014-04-28 Thread Luis Bernardo
If the implemented behavior is select-first-fitting then it makes sense. The behavior I observed is the one you described. The wiki page described best-fitting and I had built an example based on what I expected best fit to be. On Mon, Apr 28, 2014 at 7:27 AM, Vincent Hennebert wrote: > Hi Luis,

Re: [VOTE] Merge Temp_WhitespaceManagement to trunk

2014-04-28 Thread Luis Bernardo
In the situation where I see this feature being used (like to place a banner ad, very likely an image, at the bottom of a page) I don't see these constraints as being a problem. Hence my vote. On Mon, Apr 28, 2014 at 3:31 AM, Glenn Adams wrote: > Are those reasonable constraints? > > > > On Sun

RE: [VOTE] Merge Temp_WhitespaceManagement to trunk

2014-04-27 Thread Robert Meyer
+1 From: Glenn Adams<mailto:gl...@skynav.com> Sent: ‎4/‎28/‎2014 3:32 To: FOP Developers<mailto:fop-dev@xmlgraphics.apache.org> Subject: Re: [VOTE] Merge Temp_WhitespaceManagement to trunk Are those reasonable constraints? On Sun, Apr 27, 2014 at 4

Re: [VOTE] Merge Temp_WhitespaceManagement to trunk

2014-04-27 Thread Vincent Hennebert
Hi Luis, thanks for testing this. I tested with the attached example and the result is not what I expected. It is also possible that I don't understand what best fit means. The value of the option hasn’t been changed yet but it will be when merging to trunk. Its name will be select-first-fitt

Re: [VOTE] Merge Temp_WhitespaceManagement to trunk

2014-04-27 Thread Glenn Adams
Are those reasonable constraints? On Sun, Apr 27, 2014 at 4:38 PM, Luis Bernardo wrote: > > Further testing showed that this only seems to work if: > -- the multi-switch element is the last element with content in the page > -- the alternatives are ordered from the largest to the smallest > Sinc

Re: [VOTE] Merge Temp_WhitespaceManagement to trunk

2014-04-27 Thread Luis Bernardo
Further testing showed that this only seems to work if: -- the multi-switch element is the last element with content in the page -- the alternatives are ordered from the largest to the smallest Since the constraints are not too restrictive, +1 On 4/26/14, 11:49 PM, Luis Bernardo wrote: I test

Re: [VOTE] Merge Temp_WhitespaceManagement to trunk

2014-04-26 Thread Luis Bernardo
I tested with the attached example and the result is not what I expected. It is also possible that I don't understand what best fit means. I was expecting yellow, yellow, yellow. Instead I get yellow, blue, yellow. Can you please comment? On 4/24/14, 11:58 PM, Luis Bernardo wrote: Vincent

Re: [VOTE] Merge Temp_WhitespaceManagement to trunk

2014-04-24 Thread Luis Bernardo
Vincent, if you hold off tallying the votes till Monday then I will run some tests before I vote. On 4/22/14, 5:11 PM, Vincent Hennebert wrote: Hi, as you may be aware, Seifeddine Dridi has been working for the past few months on an extension to manage the white space available in a document

Re: [VOTE] Merge Temp_WhitespaceManagement to trunk

2014-04-23 Thread Chris Bowditch
+1 Thanks to Vincent and Seifeddine for a great new feature. Thanks, Chris On 22/04/2014 17:11, Vincent Hennebert wrote: Hi, as you may be aware, Seifeddine Dridi has been working for the past few months on an extension to manage the white space available in a document. It is based on the fo

Re: [VOTE] Merge Temp_WhitespaceManagement to trunk

2014-04-22 Thread Clay Leeds
+1 from me! Thanks for your hard work! Cheers! Clay -- "My religion is simple. My religion is kindness." - HH The Dalai Lama of Tibet > On Apr 22, 2014, at 9:11 AM, Vincent Hennebert wrote: > > Hi, > > as you may be aware, Seifeddine Dridi has been working for the past few > months on an ex

Re: [VOTE] Merge Temp_WhitespaceManagement to trunk

2014-04-22 Thread Mehdi Houshmand
+1 from me On 22 April 2014 19:59, Glenn Adams wrote: > In that case, I will add my +1. > > Thanks for the good work Seifeddine and Vincent! > > > On Tue, Apr 22, 2014 at 12:33 PM, Vincent Hennebert > wrote: > >> On 22/04/14 18:25, Glenn Adams wrote: >> >>> Are you satisfied with the level of

Re: [VOTE] Merge Temp_WhitespaceManagement to trunk

2014-04-22 Thread Glenn Adams
In that case, I will add my +1. Thanks for the good work Seifeddine and Vincent! On Tue, Apr 22, 2014 at 12:33 PM, Vincent Hennebert wrote: > On 22/04/14 18:25, Glenn Adams wrote: > >> Are you satisfied with the level of testing that is included in the patch >> to >> fully cover the new functio

Re: [VOTE] Merge Temp_WhitespaceManagement to trunk

2014-04-22 Thread Vincent Hennebert
On 22/04/14 18:25, Glenn Adams wrote: Are you satisfied with the level of testing that is included in the patch to fully cover the new functionality? Yes, several tests have been added to the layout test suite. Of course, given the complexity of the layout engine, it’s very hard to be sure ever

Re: [VOTE] Merge Temp_WhitespaceManagement to trunk

2014-04-22 Thread Glenn Adams
Are you satisfied with the level of testing that is included in the patch to fully cover the new functionality? Also, could you describe where we ended up with as far as user visible extensions? New elements, attributes (properties)? Thanks, Glenn On Tue, Apr 22, 2014 at 10:11 AM, Vincent Henne