RE: FOP change-bar support

[Jan Tosovsky]

Hi Thomas,

On 2016-08-04 Thomas Furst wrote:
> 
> This gives me a better idea of HOW the change-bars are applied. As I've
> stated from the beginning of this thread, I a new to the FOP source
> code, so I will need to start digging into it to get a better
> understanding of WHERE these values are determined and used. I can see
> where using a static value of 105% would not be ideal.

please include the original text in your replies, sometimes it is hard to
decipher what are you refering to.

Anyway, we should join our efforts incorporate the current change bars patch
into the trunk. The curent code have 2 known issues, both of them rather
cosmetic. In my opinion this shouldn't be a blocker. Once it is in main
codebase, it will be much more handy to other developers to investigate
these issue and propose a fix.

To my knowledge, both cases require passing additional info, which is not
curently available within the rendering phase:
a) actual line height (to make inline change bars touching)
b) writing direction (to place change bars to the proper margin)

However, the last version of the patch wasn't reviewed for more than one
year ...
We can just hope it will improve now as there are more people asking this
feature ;-)

Jan

Re: FOP change-bar support

[Furst,Thomas]

Stephan,

This gives me a better idea of HOW the change-bars are applied. As I've stated 
from the beginning of this thread, I a new to the FOP source code, so I will 
need to start digging into it to get a better understanding of WHERE these 
values are determined and used. I can see where using a static value of 105% 
would not be ideal.

Thanks,

Tom Furst
Systems/Technical Lead
[RCMTlogo]
116 High Street
Westerly, RI 02891
Office: 401-315-6652
Cell: 860-705-2135
mailto:thomas.fu...@rcmt.com
mailto:thomas.fu...@lmco.com



This message has been scanned for malware by Websense. www.websense.com

Aw: Re: FOP change-bar support

[Stephan Thesing]

Hello,

well, the way that the change-bar patch works is that for each layout manager, when an area is created, the change-bars that affect the layout manager (which come from
the FO element the manager was created for) are copied to that newly created area.

Then, in the rendering of the area tree, a change-bar with the same height as the area is drawn on the correct border.

Thus, if several line-areas are created which are apart by a line separator space, this will lead to gaps between the change bars.

Rather than adjusting by an empirical value, I would assume it is better to add to the change-bar at such areas the info for the gap and when rendering
extend the change-bar by that amount.

Doing always a 105% expansion of the height will lead to wrong results for e.g. figures or tables IMHO.

 

Best regards

   Stephan


 

 



Gesendet: Montag, 01. August 2016 um 18:42 Uhr
Von: "Furst,Thomas" <thomas.fu...@rcmt.com>
An: "fop-dev@xmlgraphics.apache.org" <fop-dev@xmlgraphics.apache.org>
Betreff: Re: FOP change-bar support




I am not sure if this is something that has been identified previously, or if it even will matter, but I found that if I set the line-height of the text to 0.95, that the change-bar gap disappears. Maybe I am thinking too simply, but this makes me believe that if I can set the change-bar length to 105% of the line height, it should always cover the gap. Again, maybe I am taking too simplistic an approach, but just looking for some dialog on this to see if I am on the right or wrong track.

 

Thank you,

 

Tom Furst

 

 

Tom Furst

Systems/Technical Lead



116 High Street

Westerly, RI 02891

Office: 401-315-6652

Cell: 860-705-2135

mailto:thomas.fu...@rcmt.com

mailto:thomas.fu...@lmco.com

 

 

This message has been scanned for malware by Websense. www.websense.com

Re: FOP change-bar support

[Furst,Thomas]

I am not sure if this is something that has been identified previously, or if 
it even will matter, but I found that if I set the line-height of the text to 
0.95, that the change-bar gap disappears. Maybe I am thinking too simply, but 
this makes me believe that if I can set the change-bar length to 105% of the 
line height, it should always cover the gap. Again, maybe I am taking too 
simplistic an approach, but just looking for some dialog on this to see if I am 
on the right or wrong track.



Thank you,



Tom Furst


Tom Furst
Systems/Technical Lead
[RCMTlogo]
116 High Street
Westerly, RI 02891
Office: 401-315-6652
Cell: 860-705-2135
mailto:thomas.fu...@rcmt.com
mailto:thomas.fu...@lmco.com



This message has been scanned for malware by Websense. www.websense.com

Re: FOP change-bar support

[Furst,Thomas]

Andreas,

Thank you for the info. I downloaded a source distribution and manually applied 
all of the items in the patch, and have a working FOP with change-bars. I have 
begun to poke around some. I am very curious as to how to fix the line created 
between each line of text in the change bar. I see this is a known issue, so I 
am not sure that with my lack of experience I will be able to provide any 
insight, but I suppose stranger things have happened.

I will certainly be looking into using an IDE in the future, as I am sure it 
would be much quicker. Not mention, it is probably the correct way to do it.

Thanks,

Tom

Sent from Mail for Windows 10



This message has been scanned for malware by Websense. www.websense.com

Re: FOP change-bar support

[Andreas Delmelle]

Hi Tom

> On 22 Jul 2016, at 23:34, Furst,Thomas  wrote:
> 
> Hi Andreas,
> 
> I am new to attempting to be a part of FOP development. Where can I learn 
> more about how to apply a patch? I imagine I need to get the source download, 
> do I just update the file(s) outlined in the patches at the given link? Sorry 
> for asking such newb questions, but am unsure of where to begin.
> 


In that case, be sure to start here: http://xmlgraphics.apache.org/fop/dev/

You would indeed need a source download. The easiest way to do so is to check 
out FOP trunk from Subversion or Github with a Java IDE. Personally, I prefer 
using Jetbrains' IntelliJ IDEA, which has a free community version that 
integrates very well with OS X/macOS and Windows, but Eclipse or Netbeans would 
work just as well.

Given that Maven integration has been added to FOP, it should prove fairly 
trivial to do a build once the checkout is done. Note: you will need to install 
the SVN or Git binary as well, depending on your platform. For OS X/macOS, both 
are included in the XCode command-line tools available for download on the 
Apple Dev website.

Applying patches to your local sandbox from within an IDE is a proverbial piece 
of cake, if they are very recent. Your IDE will have a menu 'VCS' or 'Version 
Control' or something, which will normally have an option 'Apply Patch...'

The more outdated the patch however, the higher the risk that things will 
become significantly more difficult. I have not tried it with the patches in 
the mentioned JIRA ticket recently, so not sure yet if it will really be that 
problematic. Could be that SVN will automatically trace things back to the 
revision of the patch, and 'knows' where the respective source files have moved 
to (?)


HTH!

Cheers

Andreas

Re: FOP change-bar support

[Andreas Delmelle]

Hi Tom

> On 20 Jul 2016, at 21:13, Furst,Thomas  wrote:
> 
> I use FOP to publish XML for technical manual content. Do so, there are times 
> where we need to indicate where a change has been applied to the document. I 
> know the FO tags exist, just that FOP does not currently support this markup. 
> Is there any plan to work on this? How can I become involved in working 
> towards making it functional in FOP?

Actually, quite some work and research has already been done by others, to 
provide support fo:change-bar. 
So, if you are serious about contributing, then the best place to start is 
probably to have a look at https://issues.apache.org/jira/browse/FOP-1760

Obviously, there are other details to work out, but that would be for a later 
change. For now, best to see if you can find your way in the patch(es) 
available in JIRA and catch up, so you don't have to start from scratch.

Do note that those patches are already rather old, so the first thing to sort 
out would be to make it work with current trunk. Things have been restructured 
quite a bit in order to provide full integration with Maven. OTOH, those 
changes mainly concern additional folders/subfolders. The classes themselves 
have not changed that much, and should still be relatively easy to find.

Apart from that, feel free to post any follow-up questions to this list.

Thanks!


Andreas