Re: svn commit: r525078 - in /xmlgraphics/fop/trunk: ./ src/java/org/apache/fop/area/ src/java/org/apache/fop/fo/extensions/destination/ src/java/org/apache/fop/pdf/

2007-04-17 Thread Vincent Hennebert
Hi Jay, Jay Bryant a écrit : >> - if your modifications are non-trivial (as is the case here), it's very >> important to add a note about them in the status.xml file. The content >> of this file appears on the following web page: >> http://xmlgraphics.apache.org/fop/changes.html > > Where? In

Re: svn commit: r525078 - in /xmlgraphics/fop/trunk: ./ src/java/org/apache/fop/area/ src/java/org/apache/fop/fo/extensions/destination/ src/java/org/apache/fop/pdf/

2007-04-06 Thread Jay Bryant
- I suggest you to install and setup checkstyle if you haven't done yet; OK. Did that. - don't forget to add the ASF headers (checkstyle will notify you about that, BTW) and set the "svn:keywords Id" and "svn:eol-style native" on new files. Other folks corrected that for me, I guess, but I

Re: svn commit: r525078 - in /xmlgraphics/fop/trunk: ./ src/java/org/apache/fop/area/ src/java/org/apache/fop/fo/extensions/destination/ src/java/org/apache/fop/pdf/

2007-04-03 Thread Vincent Hennebert
Hi Jay, First, congratulations for this new feature! This is a great addition to FOP. A few remarks about your commit: - I suggest you to install and setup checkstyle if you haven't done yet; - don't forget to add the ASF headers (checkstyle will notify you about that, BTW) and set the "svn:key