Re: [foreman-dev] Unify date format in Foreman and plugins

2017-04-13 Thread Bryan Kearney
On 04/13/2017 03:53 AM, Marek Hulán wrote: On středa 12. dubna 2017 19:12:32 CEST Bryan Kearney wrote: On 04/12/2017 09:39 AM, Marek Hulán wrote: <%= l(report.last_report_at, :format => :long) %> which prints "April 10, 2017 17:08". The month name and potentially the format is localized based

Re: [foreman-dev] Unify date format in Foreman and plugins

2017-04-13 Thread Greg Sutcliffe
+1 for consistency, further comments below ;) On Thu, 2017-04-13 at 10:05 +0200, Marek Hulán wrote: > > > On the reports (where you see multiple) then I think the "ago" > > > format isn't useful because the granularity is too low so it's > > > hard to compare. IMHO in a list they should all have t

Re: [foreman-dev] Unify date format in Foreman and plugins

2017-04-13 Thread Marek Hulán
On čtvrtek 13. dubna 2017 8:13:11 CEST Timo Goebel wrote: > Am 12.04.17 um 18:21 schrieb Ewoud Kohl van Wijngaarden: > > On Wed, Apr 12, 2017 at 06:02:34PM +0200, Marek Hulán wrote: > >> Thanks guys so far, I'm sending comments below in text that are also > >> relevant for lzap's comments in previo

Re: [foreman-dev] Unify date format in Foreman and plugins

2017-04-13 Thread Marek Hulán
On středa 12. dubna 2017 19:12:32 CEST Bryan Kearney wrote: > On 04/12/2017 09:39 AM, Marek Hulán wrote: > > <%= l(report.last_report_at, :format => :long) %> > > > > which prints "April 10, 2017 17:08". The month name and potentially the > > format is localized based on current user locale. > >

Re: [foreman-dev] Unify date format in Foreman and plugins

2017-04-12 Thread Timo Goebel
Am 12.04.17 um 18:21 schrieb Ewoud Kohl van Wijngaarden: On Wed, Apr 12, 2017 at 06:02:34PM +0200, Marek Hulán wrote: Thanks guys so far, I'm sending comments below in text that are also relevant for lzap's comments in previous email. On středa 12. dubna 2017 16:56:52 CEST Ewoud Kohl van Wijnga

Re: [foreman-dev] Unify date format in Foreman and plugins

2017-04-12 Thread Bryan Kearney
On 04/12/2017 09:39 AM, Marek Hulán wrote: <%= l(report.last_report_at, :format => :long) %> which prints "April 10, 2017 17:08". The month name and potentially the format is localized based on current user locale. What is the effort to make this a user driven setting? -- bk -- You received th

Re: [foreman-dev] Unify date format in Foreman and plugins

2017-04-12 Thread Bryan Kearney
On 04/12/2017 11:55 AM, Marek Hulán wrote: On středa 12. dubna 2017 16:14:36 CEST Bryan Kearney wrote: +1 on the format To make sure I am clear: 1) Dates will be stored in the DB as UTC. yes, but should not matter since the TZ info part of the value and we'd always convert it according to cur

Re: [foreman-dev] Unify date format in Foreman and plugins

2017-04-12 Thread Marek Hulán
On středa 12. dubna 2017 17:55:21 CEST Marek Hulán wrote: > On středa 12. dubna 2017 16:14:36 CEST Bryan Kearney wrote: > > +1 on the format > > > > To make sure I am clear: > > > > 1) Dates will be stored in the DB as UTC. > > yes, but should not matter since the TZ info part of the value and w

Re: [foreman-dev] Unify date format in Foreman and plugins

2017-04-12 Thread Ewoud Kohl van Wijngaarden
On Wed, Apr 12, 2017 at 06:02:34PM +0200, Marek Hulán wrote: > Thanks guys so far, I'm sending comments below in text that are also relevant > for lzap's comments in previous email. > > On středa 12. dubna 2017 16:56:52 CEST Ewoud Kohl van Wijngaarden wrote: > > I second that there are cases wher

Re: [foreman-dev] Unify date format in Foreman and plugins

2017-04-12 Thread Marek Hulán
Thanks guys so far, I'm sending comments below in text that are also relevant for lzap's comments in previous email. On středa 12. dubna 2017 16:56:52 CEST Ewoud Kohl van Wijngaarden wrote: > I second that there are cases where "ago" is preferred. For the last > puppet run on the host page it's m

Re: [foreman-dev] Unify date format in Foreman and plugins

2017-04-12 Thread Marek Hulán
On středa 12. dubna 2017 16:14:36 CEST Bryan Kearney wrote: > +1 on the format > > To make sure I am clear: > > 1) Dates will be stored in the DB as UTC. yes, but should not matter since the TZ info part of the value and we'd always convert it according to current user locale > 2) Dates will be

Re: [foreman-dev] Unify date format in Foreman and plugins

2017-04-12 Thread Ewoud Kohl van Wijngaarden
I second that there are cases where "ago" is preferred. For the last puppet run on the host page it's much easier to know if it was an hour ago. Then I don't have to try and remember what day and time it is. However, in a table of all puppet reports then the exact date is the correct unit. The tabl

Re: [foreman-dev] Unify date format in Foreman and plugins

2017-04-12 Thread Lukas Zapletal
I like "ago" format with hover full date value. Thanks for putting effort in this! LZ On Wed, Apr 12, 2017 at 3:39 PM, Marek Hulán wrote: > Hello, > > I'd like to suggest one recommended way of displaying date/time information on > all pages. We started a discussion in a PR [1] that would change

Re: [foreman-dev] Unify date format in Foreman and plugins

2017-04-12 Thread Bryan Kearney
+1 on the format To make sure I am clear: 1) Dates will be stored in the DB as UTC. 2) Dates will be shown to the user based on their locale. Questions i have: a) If I enter a new date, am I entering it in my time zone? Assume serrver is in UTC +1 and I am in UTC -1. If I enter it in at 23:00

[foreman-dev] Unify date format in Foreman and plugins

2017-04-12 Thread Marek Hulán
Hello, I'd like to suggest one recommended way of displaying date/time information on all pages. We started a discussion in a PR [1] that would change the format for config reports, please take a look there for possible solutions. After a discussion with Roxanne (cc) on another page we agreed o