Re: [fossil-dev] Build system changes on Windows

2015-06-18 Thread Gaurav M. Bhandarkar
Will you be using Load-Time Dynamic Linking for zlib? If yes, will you be checking-in the import lib file too or leaving it to the developer to provide it. If it's the later, then you will need to take the path of the import lib file from the user as another argument to nmake. This kind of makes th

Re: [fossil-dev] Build system changes on Windows

2015-06-17 Thread Jan Danielsson
On 17/06/15 11:47, Jan Nijtmans wrote: >>Feature: On a few systems I want to have a dynamically linked >> fossil.exe. I'm thinking "FOSSIL_DYNAMIC_LINK=1" (changes default ZLIB >> to zdll.lib, /MT -> /MD, and link against DLL CRT). > > Well, I would expect this to be two different options: /M

Re: [fossil-dev] Build system changes on Windows

2015-06-17 Thread Jan Danielsson
On 17/06/15 11:56, Gaurav M. Bhandarkar wrote: [---] > If "not-to-build-zlib-all-the-time" is the feature wanted, can this be > provided by things like incremental linking/compiling and not an extra > compile time argument? I don't see the problem; it's literally only adding "FOSSIL_BUILD_ZLIB=

Re: [fossil-dev] Build system changes on Windows

2015-06-17 Thread Jan Danielsson
On 17/06/15 04:39, Joe Mistachkin wrote: >>Bug: It seems like the build system wrongly assumes that if one is >> building against zlib, one wants to build zlib. There should be a >> FOSSIL_BUILD_ZLIB, just as there is a FOSSIL_BUILD_SSL. > > This is not a bug, per se. Since zlib is in the tr

Re: [fossil-dev] Build system changes on Windows

2015-06-17 Thread Gaurav M. Bhandarkar
Since this could affect me (a fossil user on windows) I'm commenting: > There should be a FOSSIL_BUILD_ZLIB, just as there is a FOSSIL_BUILD_SSL I assume ZLIB is a necessary dependency for compiling fossil while SSL is optional. It makes sense not to ask if we want to build zlib or not at compile

Re: [fossil-dev] Build system changes on Windows

2015-06-17 Thread Jan Nijtmans
2015-06-17 2:29 GMT+02:00 Jan Danielsson : >Feature: On a few systems I want to have a dynamically linked > fossil.exe. I'm thinking "FOSSIL_DYNAMIC_LINK=1" (changes default ZLIB > to zdll.lib, /MT -> /MD, and link against DLL CRT). Well, I would expect this to be two different options: /MT v

Re: [fossil-dev] Build system changes on Windows

2015-06-16 Thread Joe Mistachkin
Jan Danielsson wrote: > >Bug: It seems like the build system wrongly assumes that if one is > building against zlib, one wants to build zlib. There should be a > FOSSIL_BUILD_ZLIB, just as there is a FOSSIL_BUILD_SSL. > This is not a bug, per se. Since zlib is in the tree, I figured it was

Re: [fossil-dev] Build system changes on Windows

2015-06-16 Thread Scott Robison
On Tue, Jun 16, 2015 at 6:29 PM, Jan Danielsson wrote: > Hey, > >In the very near future I'm going to make two changes to > Makefile.msc, unless someone protests. > >Bug: It seems like the build system wrongly assumes that if one is > building against zlib, one wants to build zlib. There

[fossil-dev] Build system changes on Windows

2015-06-16 Thread Jan Danielsson
Hey, In the very near future I'm going to make two changes to Makefile.msc, unless someone protests. Bug: It seems like the build system wrongly assumes that if one is building against zlib, one wants to build zlib. There should be a FOSSIL_BUILD_ZLIB, just as there is a FOSSIL_BUILD_SSL.