Re: [fossil-users] [PATCH] Improve symlink following offile_wd_isdir()

2017-11-30 Thread bytevolcano
On Thu, 30 Nov 2017 13:19:38 +0100 Jan Nijtmans wrote: > This patch has no relation to fossil's symlink support, it's just part > of the code to find a suitable temporary directory to write some > intermediate file. It's unfortunate it's that complicated, but useful >

Re: [fossil-users] [PATCH] Improve symlink following offile_wd_isdir()

2017-11-30 Thread Dominique Devienne
On Thu, Nov 30, 2017 at 1:19 PM, Jan Nijtmans wrote: > 2017-11-28 0:20 GMT+01:00 : > > On Mon, 27 Nov 2017 09:52:19 -0500 > > Richard Hipp wrote: > >> I am very sorry that I allowed symbolic link support into Fossil in > >>

Re: [fossil-users] [PATCH] Improve symlink following offile_wd_isdir()

2017-11-30 Thread Jan Nijtmans
2017-11-28 0:20 GMT+01:00 : > On Mon, 27 Nov 2017 09:52:19 -0500 > Richard Hipp wrote: >> I am very sorry that I allowed symbolic link support into Fossil in >> the first place. (Symbolic link support was neither designed nor >> written by me - it is

Re: [fossil-users] [PATCH] Improve symlink following offile_wd_isdir()

2017-11-27 Thread David Mason
I use symlinks *very* heavily. Almost exactly 10% of the files in my main fossil hierarchy are actually symlinks. Fossil not supporting them would be a huge drawback for me. Good support for symlinks and nested repositories are 2 of the details I like best about Fossil (in addition to the obvious

Re: [fossil-users] [PATCH] Improve symlink following offile_wd_isdir()

2017-11-27 Thread bytevolcano
On Mon, 27 Nov 2017 09:52:19 -0500 Richard Hipp wrote: > I am in receipt of your patch. I have not evaluated it yet because > the entire symbolic-link mechanism in Fossil is confused and very > difficult to manage. It mostly works now, but is brittle. A > seemingly simple

Re: [fossil-users] [PATCH] Improve symlink following offile_wd_isdir()

2017-11-27 Thread Richard Hipp
On 11/27/17, bytevolc...@safe-mail.net wrote: > Ping. I am in receipt of your patch. I have not evaluated it yet because the entire symbolic-link mechanism in Fossil is confused and very difficult to manage. It mostly works now, but is brittle. A seemingly simple

Re: [fossil-users] [PATCH] Improve symlink following offile_wd_isdir()

2017-11-27 Thread bytevolcano
Ping. On Sat, 25 Nov 2017 11:42:29 + bytevolc...@safe-mail.net wrote: Index: src/file.c == --- src/file.c +++ src/file.c @@ -327,24 +327,30 @@ ** zFilename is a directory -OR- a symlink that points to a directory. ** Return 0

Re: [fossil-users] [PATCH] Improve symlink following offile_wd_isdir()

2017-11-25 Thread bytevolcano
Fixed a typo resulting in absolute cases not being picked up well. Index: src/file.c == --- src/file.c +++ src/file.c @@ -327,24 +327,30 @@ ** zFilename is a directory -OR- a symlink that points to a directory. ** Return 0 if