Re: [fossil-users] Code review and branch per issue

2010-10-05 Thread Laurens Van Houtven
Hi Richard, First of all thanks for your reply. Why we create branches: the idea in our workflow is that stuff in trunk gets put to production (after a continuous integration system runs all the tests on it). One of the steps between development and production is mandatory code review.

Re: [fossil-users] Code review and branch per issue

2010-10-05 Thread Eric
On Tue, October 5, 2010 at 12:39 pm, Laurens Van Houtven l...@laurensvh.be wrote: Hi Richard, First of all thanks for your reply. snip The branch you linked me looks great and almost like something that would work wonders, but I do not understand conceptually why the branch is open and

[fossil-users] Code review and branch per issue

2010-10-04 Thread Laurens Van Houtven
Hello, I'm trying to migrate a Trac workflow to Fossil. Here's what it looks like: For each feature: 1. create ticket 2. create branch 3. implement 4. submit branch for review 5. review: if not good, back to 3 6. merge branch to trunk (trunk gets handed off to continuous integration/deployment

Re: [fossil-users] Code review and branch per issue

2010-10-04 Thread Lluís Batlle i Rossell
On Mon, Oct 04, 2010 at 10:55:02PM +0200, Laurens Van Houtven wrote: Hello, I'm trying to migrate a Trac workflow to Fossil. Here's what it looks like: For each feature: 1. create ticket 2. create branch 3. implement 4. submit branch for review 5. review: if not good, back to 3 6.

Re: [fossil-users] Code review and branch per issue

2010-10-04 Thread Richard Hipp
On Mon, Oct 4, 2010 at 6:02 PM, Laurens Van Houtven l...@laurensvh.bewrote: 2010/10/4 Lluís Batlle i Rossell virik...@gmail.com: On Mon, Oct 04, 2010 at 10:55:02PM +0200, Laurens Van Houtven wrote: You can review against the trunk version it was updated from. As any DVCS, fossil does not

Re: [fossil-users] Code review and branch per issue

2010-10-04 Thread Richard Hipp
2010/10/4 Lluís Batlle i Rossell virik...@gmail.com On Mon, Oct 04, 2010 at 10:55:02PM +0200, Laurens Van Houtven wrote: I wonder how difficult it will be in fossil to find the version of the parent branch last merged into a child branch. Fossil does this automatically for you when you